svn commit: r257455 - head/sys/net

2013-10-31 Thread Andre Oppermann
Author: andre Date: Thu Oct 31 15:46:10 2013 New Revision: 257455 URL: http://svnweb.freebsd.org/changeset/base/257455 Log: Make struct ifnet readable and comprehensible again by grouping and ordering related variables, fields and locks next to each other. Add more comments to variables.

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Luigi Rizzo
On Thu, Oct 31, 2013 at 03:46:10PM +, Andre Oppermann wrote: Author: andre Date: Thu Oct 31 15:46:10 2013 New Revision: 257455 URL: http://svnweb.freebsd.org/changeset/base/257455 Log: Make struct ifnet readable and comprehensible again by grouping and ordering related variables,

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Andre Oppermann
On 31.10.2013 19:03, Luigi Rizzo wrote: On Thu, Oct 31, 2013 at 03:46:10PM +, Andre Oppermann wrote: Author: andre Date: Thu Oct 31 15:46:10 2013 New Revision: 257455 URL: http://svnweb.freebsd.org/changeset/base/257455 Log: Make struct ifnet readable and comprehensible again by

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Ian Lepore
On Thu, 2013-10-31 at 20:08 +0100, Andre Oppermann wrote: On 31.10.2013 19:03, Luigi Rizzo wrote: On Thu, Oct 31, 2013 at 03:46:10PM +, Andre Oppermann wrote: Author: andre Date: Thu Oct 31 15:46:10 2013 New Revision: 257455 URL: http://svnweb.freebsd.org/changeset/base/257455

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Luigi Rizzo
On Thu, Oct 31, 2013 at 01:27:25PM -0600, Ian Lepore wrote: ... Is there any chance all this reworking might get us to a position where the protocol header in an mbuf doesn't have to be 32-bit aligned anymore? We pay a pretty heavy price for that requirement in the drivers of the least

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Ian Lepore
On Thu, 2013-10-31 at 21:05 +0100, Luigi Rizzo wrote: On Thu, Oct 31, 2013 at 01:27:25PM -0600, Ian Lepore wrote: ... Is there any chance all this reworking might get us to a position where the protocol header in an mbuf doesn't have to be 32-bit aligned anymore? We pay a pretty heavy

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread John-Mark Gurney
Luigi Rizzo wrote this message on Thu, Oct 31, 2013 at 21:05 +0100: On Thu, Oct 31, 2013 at 01:27:25PM -0600, Ian Lepore wrote: ... Is there any chance all this reworking might get us to a position where the protocol header in an mbuf doesn't have to be 32-bit aligned anymore? We pay a

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Luigi Rizzo
On Thu, Oct 31, 2013 at 01:49:16PM -0700, John-Mark Gurney wrote: Luigi Rizzo wrote this message on Thu, Oct 31, 2013 at 21:05 +0100: On Thu, Oct 31, 2013 at 01:27:25PM -0600, Ian Lepore wrote: ... Is there any chance all this reworking might get us to a position where the protocol

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread John-Mark Gurney
Luigi Rizzo wrote this message on Thu, Oct 31, 2013 at 22:13 +0100: On Thu, Oct 31, 2013 at 01:49:16PM -0700, John-Mark Gurney wrote: Luigi Rizzo wrote this message on Thu, Oct 31, 2013 at 21:05 +0100: On Thu, Oct 31, 2013 at 01:27:25PM -0600, Ian Lepore wrote: ... Is there any chance

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Andre Oppermann
On 31.10.2013 20:27, Ian Lepore wrote: On Thu, 2013-10-31 at 20:08 +0100, Andre Oppermann wrote: On 31.10.2013 19:03, Luigi Rizzo wrote: On Thu, Oct 31, 2013 at 03:46:10PM +, Andre Oppermann wrote: Author: andre Date: Thu Oct 31 15:46:10 2013 New Revision: 257455 URL:

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Andre Oppermann
On 31.10.2013 21:15, Ian Lepore wrote: On Thu, 2013-10-31 at 21:05 +0100, Luigi Rizzo wrote: On Thu, Oct 31, 2013 at 01:27:25PM -0600, Ian Lepore wrote: ... Is there any chance all this reworking might get us to a position where the protocol header in an mbuf doesn't have to be 32-bit aligned

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Ian Lepore
On Thu, 2013-10-31 at 23:17 +0100, Andre Oppermann wrote: On 31.10.2013 20:27, Ian Lepore wrote: On Thu, 2013-10-31 at 20:08 +0100, Andre Oppermann wrote: On 31.10.2013 19:03, Luigi Rizzo wrote: On Thu, Oct 31, 2013 at 03:46:10PM +, Andre Oppermann wrote: Author: andre Date: Thu Oct

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Luigi Rizzo
On Thu, Oct 31, 2013 at 03:14:57PM -0700, John-Mark Gurney wrote: Luigi Rizzo wrote this message on Thu, Oct 31, 2013 at 22:13 +0100: On Thu, Oct 31, 2013 at 01:49:16PM -0700, John-Mark Gurney wrote: Luigi Rizzo wrote this message on Thu, Oct 31, 2013 at 21:05 +0100: On Thu, Oct 31, 2013

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Andre Oppermann
On 31.10.2013 23:32, Ian Lepore wrote: On Thu, 2013-10-31 at 23:17 +0100, Andre Oppermann wrote: On 31.10.2013 20:27, Ian Lepore wrote: On Thu, 2013-10-31 at 20:08 +0100, Andre Oppermann wrote: On 31.10.2013 19:03, Luigi Rizzo wrote: On Thu, Oct 31, 2013 at 03:46:10PM +, Andre Oppermann

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread John-Mark Gurney
Luigi Rizzo wrote this message on Thu, Oct 31, 2013 at 23:41 +0100: On Thu, Oct 31, 2013 at 03:14:57PM -0700, John-Mark Gurney wrote: Luigi Rizzo wrote this message on Thu, Oct 31, 2013 at 22:13 +0100: On Thu, Oct 31, 2013 at 01:49:16PM -0700, John-Mark Gurney wrote: Luigi Rizzo wrote

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread John-Mark Gurney
Andre Oppermann wrote this message on Thu, Oct 31, 2013 at 23:41 +0100: I know of only one modern ARM SoC that's able to DMA network packets on a 2-byte boundary (actually even it requires a 4-byte boundary, but it's willing to stuff the first 16 bits with zeroes and offset everything that

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Adrian Chadd
On 31 October 2013 20:22, John-Mark Gurney j...@funkthat.com wrote: Andre Oppermann wrote this message on Thu, Oct 31, 2013 at 23:41 +0100: I know of only one modern ARM SoC that's able to DMA network packets on a 2-byte boundary (actually even it requires a 4-byte boundary, but it's willing