On 26.12.2013 06:13, Dimitry Andric wrote:
On 26 Dec 2013, at 02:51, Adrian Chadd adr...@freebsd.org wrote:
I'd prefer you didn't remove unused code in drivers like this. If you
must, #if 0 them out.
I don't mind either way, but some other people are very much opposed to
littering code with
Pedro Giffuni wrote this message on Sun, Dec 29, 2013 at 15:51 -0500:
On 26.12.2013 06:13, Dimitry Andric wrote:
On 26 Dec 2013, at 02:51, Adrian Chadd adr...@freebsd.org wrote:
I'd prefer you didn't remove unused code in drivers like this. If you
must, #if 0 them out.
I don't mind either
On Dec 29, 2013, at 2:28 PM, John-Mark Gurney j...@funkthat.com wrote:
Pedro Giffuni wrote this message on Sun, Dec 29, 2013 at 15:51 -0500:
On 26.12.2013 06:13, Dimitry Andric wrote:
On 26 Dec 2013, at 02:51, Adrian Chadd adr...@freebsd.org wrote:
I'd prefer you didn't remove unused code in
On 26 Dec 2013, at 02:51, Adrian Chadd adr...@freebsd.org wrote:
I'd prefer you didn't remove unused code in drivers like this. If you
must, #if 0 them out.
I don't mind either way, but some other people are very much opposed to
littering code with #if 0'd sections. So, how do to determine
Author: dim
Date: Wed Dec 25 22:45:33 2013
New Revision: 259896
URL: http://svnweb.freebsd.org/changeset/base/259896
Log:
In sys/dev/cxgb/common/cxgb_mc5.c, remove static function
dbgi_wr_addr3(), which is unused since r167514.
MFC after:3 days
Modified:
Hi Dim,
I'd prefer you didn't remove unused code in drivers like this. If you
must, #if 0 them out.
Future people hacking on the driver may find it nice to have as much
code in there which talks to the hardware. It may not be currently
called, but it's at least there.
Thanks,
-adrian
On 25
