Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-31 Thread John Baldwin
On Monday, March 30, 2015 04:21:03 PM Randall Stewart wrote: John: As I just said, Warner and I feel we can get by with making the int - short/short so we preserver the KPI and at the same time achieve the objective .. My big concern was no intel platforms but Warner gave me a green

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-31 Thread John Baldwin
On Monday, March 30, 2015 06:26:25 PM Randall Stewart wrote: On Mar 30, 2015, at 9:16 AM, John Baldwin j...@freebsd.org wrote: On Saturday, March 28, 2015 12:50:24 PM Randall Stewart wrote: Author: rrs Date: Sat Mar 28 12:50:24 2015 New Revision: 280785 URL:

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-31 Thread Eric van Gyzen
Now as to the -1 - NOCPU This is like pulling on a string on your sweater.. the only sensible solution that I could come up with after chatting with Lawrence is to add #include sys/proc.h to everyone that uses the callout.h and does not have it already… (putting it into callout.h

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-31 Thread Julian Elischer
On 4/1/15 12:01 AM, Eric van Gyzen wrote: Now as to the -1 - NOCPU This is like pulling on a string on your sweater.. the only sensible solution that I could come up with after chatting with Lawrence is to add #include sys/proc.h to everyone that uses the callout.h and does not have it

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-31 Thread Julian Elischer
On 3/31/15 8:26 AM, Randall Stewart wrote: On Mar 30, 2015, at 9:16 AM, John Baldwin j...@freebsd.org mailto:j...@freebsd.org wrote: On Saturday, March 28, 2015 12:50:24 PM Randall Stewart wrote: Author: rrs Date: Sat Mar 28 12:50:24 2015 New Revision: 280785 URL:

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-30 Thread John Baldwin
On Saturday, March 28, 2015 01:48:49 PM Davide Italiano wrote: On Sat, Mar 28, 2015 at 12:04 PM, Randall Stewart r...@netflix.com wrote: Hmm does the KPI include the size of the callout structure (which is private)? It's KBI, not KPI. If so I suppose we could change the

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-30 Thread John Baldwin
On Saturday, March 28, 2015 12:50:24 PM Randall Stewart wrote: Author: rrs Date: Sat Mar 28 12:50:24 2015 New Revision: 280785 URL: https://svnweb.freebsd.org/changeset/base/280785 Log: Change the callout to supply -1 to indicate we are not changing CPU, also add protection against

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-30 Thread John Baldwin
On Monday, March 30, 2015 11:16:20 AM John Baldwin wrote: The second sentence quite seem to be English (have a lock touches s/sentence quite/sentence doesn't quite/ *sigh* -- John Baldwin ___ svn-src-all@freebsd.org mailing list

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-30 Thread Randall Stewart via svn-src-all
John: Comments below.. On Mar 30, 2015, at 9:16 AM, John Baldwin j...@freebsd.org wrote: On Saturday, March 28, 2015 12:50:24 PM Randall Stewart wrote: Author: rrs Date: Sat Mar 28 12:50:24 2015 New Revision: 280785 URL: https://svnweb.freebsd.org/changeset/base/280785 Log: Change

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-30 Thread Randall Stewart via svn-src-all
John: As I just said, Warner and I feel we can get by with making the int - short/short so we preserver the KPI and at the same time achieve the objective .. My big concern was no intel platforms but Warner gave me a green light there ;-) R On Mar 30, 2015, at 10:10 AM, John Baldwin

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-30 Thread Randall Stewart via svn-src-all
Davide: I have had a long chat this weekend with imp, and both he and I feel the right fix is to *not* bump the version, but instead change the two fields to shorts. That way the length will still say the same so we can MFC this. I will be committing that shortly, I have it testing inside right

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-30 Thread Randall Stewart via svn-src-all
John: FYI in getting this setup, NOCPU will mean callout.h will need to include sys/proc.h I hope thats ok.. either that or I need to do a #ifndef NOCPU #define NOCPU (-1) #endif.. Which seems ugly.. R On Mar 30, 2015, at 2:38 PM, John Baldwin j...@freebsd.org wrote: On Monday, March 30,

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-30 Thread Randall Stewart via svn-src-all
On Mar 30, 2015, at 9:16 AM, John Baldwin j...@freebsd.org wrote: On Saturday, March 28, 2015 12:50:24 PM Randall Stewart wrote: Author: rrs Date: Sat Mar 28 12:50:24 2015 New Revision: 280785 URL: https://svnweb.freebsd.org/changeset/base/280785 Log: Change the callout to supply -1 to

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-28 Thread Adrian Chadd
Hi, There's been at least one report of a regression on -current. i haven't tried this on various MIPS hardware devices yet. -adrian ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-28 Thread Davide Italiano
On Sat, Mar 28, 2015 at 12:04 PM, Randall Stewart r...@netflix.com wrote: Hmm does the KPI include the size of the callout structure (which is private)? It's KBI, not KPI. If so I suppose we could change the c_flags/c_iflags to ushort … I'm not familiar with your changes enough to

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-28 Thread Davide Italiano
On Sat, Mar 28, 2015 at 5:50 AM, Randall Stewart r...@freebsd.org wrote: Author: rrs Date: Sat Mar 28 12:50:24 2015 New Revision: 280785 URL: https://svnweb.freebsd.org/changeset/base/280785 Log: Change the callout to supply -1 to indicate we are not changing CPU, also add protection

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-28 Thread Bjoern A. Zeeb
On 28 Mar 2015, at 12:50 , Randall Stewart r...@freebsd.org wrote: Author: rrs Date: Sat Mar 28 12:50:24 2015 New Revision: 280785 URL: https://svnweb.freebsd.org/changeset/base/280785 Log: Change the callout to supply -1 to indicate we are not changing CPU, also add protection

Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-28 Thread Bjoern A. Zeeb
On 28 Mar 2015, at 13:33 , Bjoern A. Zeeb b...@freebsd.org wrote: On 28 Mar 2015, at 12:50 , Randall Stewart r...@freebsd.org wrote: Author: rrs Date: Sat Mar 28 12:50:24 2015 New Revision: 280785 URL: https://svnweb.freebsd.org/changeset/base/280785 Log: Change the callout to

svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys

2015-03-28 Thread Randall Stewart
Author: rrs Date: Sat Mar 28 12:50:24 2015 New Revision: 280785 URL: https://svnweb.freebsd.org/changeset/base/280785 Log: Change the callout to supply -1 to indicate we are not changing CPU, also add protection against invalid CPU's as well as split c_flags and c_iflags so that if a user