Re: svn commit: r290711 - head/sys/ofed/drivers/infiniband/core

2015-11-13 Thread Hans Petter Selasky
Hi, On 11/12/15 18:17, Conrad Meyer wrote: These should cast through (u)intptr_t rather than unsigned long. This is Linux code, and they use "unsigned long" for pointer casts everywhere, trying to not break their style. BTW: I added to linux_compat.c: CTASSERT(sizeof(unsigned long) ==

Re: svn commit: r290711 - head/sys/ofed/drivers/infiniband/core

2015-11-13 Thread Konstantin Belousov
On Fri, Nov 13, 2015 at 09:18:54AM +0100, Hans Petter Selasky wrote: > Hi, > > On 11/12/15 18:17, Conrad Meyer wrote: > > These should cast through (u)intptr_t rather than unsigned long. > > > > This is Linux code, and they use "unsigned long" for pointer casts > everywhere, trying to not break

Re: svn commit: r290711 - head/sys/ofed/drivers/infiniband/core

2015-11-13 Thread Bruce Evans
On Fri, 13 Nov 2015, David Chisnall wrote: On 13 Nov 2015, at 08:35, Konstantin Belousov wrote: On Fri, Nov 13, 2015 at 09:18:54AM +0100, Hans Petter Selasky wrote: Hi, On 11/12/15 18:17, Conrad Meyer wrote: These should cast through (u)intptr_t rather than unsigned

Re: svn commit: r290711 - head/sys/ofed/drivers/infiniband/core

2015-11-13 Thread Hans Petter Selasky
On 11/13/15 15:10, David Chisnall wrote: Note that this is not true of all downstreams. We currently have 128 and 256-bit void*s with 64-bit longs on CHERI, and I believe that bde’s version has 32-bit longs on all platforms. David Hi David, Converting the LinuxKPI to use uintptr_t instead

Re: svn commit: r290711 - head/sys/ofed/drivers/infiniband/core

2015-11-13 Thread David Chisnall
On 13 Nov 2015, at 08:35, Konstantin Belousov wrote: > > On Fri, Nov 13, 2015 at 09:18:54AM +0100, Hans Petter Selasky wrote: >> Hi, >> >> On 11/12/15 18:17, Conrad Meyer wrote: >>> These should cast through (u)intptr_t rather than unsigned long. >>> >> >> This is Linux

svn commit: r290711 - head/sys/ofed/drivers/infiniband/core

2015-11-12 Thread Hans Petter Selasky
Author: hselasky Date: Thu Nov 12 10:12:20 2015 New Revision: 290711 URL: https://svnweb.freebsd.org/changeset/base/290711 Log: Fix integer to pointer of different size conversion warnings when using GCC for 32-bit platforms. The integer size in this case is hardcoded 64-bit while the

Re: svn commit: r290711 - head/sys/ofed/drivers/infiniband/core

2015-11-12 Thread Conrad Meyer
These should cast through (u)intptr_t rather than unsigned long. Best, Conrad On Thu, Nov 12, 2015 at 2:12 AM, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Nov 12 10:12:20 2015 > New Revision: 290711 > URL: https://svnweb.freebsd.org/changeset/base/290711 > >