Re: svn commit: r292955 - head/lib/libmd

2016-01-02 Thread Bruce Evans
On Sat, 2 Jan 2016, Allan Jude wrote: On 2015-12-31 13:50, Allan Jude wrote: On 2015-12-31 13:32, Jonathan T. Looney wrote: On 12/31/15, 2:15 AM, "Allan Jude" wrote: It seems these problems also slow things down, a lot: # time md5 /media/md5test/bigdata MD5

Re: svn commit: r292955 - head/lib/libmd

2016-01-02 Thread Allan Jude
On 2016-01-02 05:07, Bruce Evans wrote: > On Sat, 2 Jan 2016, Allan Jude wrote: > >> On 2015-12-31 13:50, Allan Jude wrote: >>> On 2015-12-31 13:32, Jonathan T. Looney wrote: On 12/31/15, 2:15 AM, "Allan Jude" wrote: > It seems these problems also slow things

Re: svn commit: r292955 - head/lib/libmd

2016-01-01 Thread Allan Jude
On 2015-12-31 13:50, Allan Jude wrote: > On 2015-12-31 13:32, Jonathan T. Looney wrote: >> On 12/31/15, 2:15 AM, "Allan Jude" wrote: >> >>> It seems these problems also slow things down, a lot: >>> >>> # time md5 /media/md5test/bigdata >>> MD5 (/media/md5test/bigdata) =

Re: svn commit: r292955 - head/lib/libmd

2015-12-31 Thread Allan Jude
On 2015-12-31 13:32, Jonathan T. Looney wrote: > On 12/31/15, 2:15 AM, "Allan Jude" wrote: > >> It seems these problems also slow things down, a lot: >> >> # time md5 /media/md5test/bigdata >> MD5 (/media/md5test/bigdata) = 6afad0bf5d8318093e943229be05be67 >> 4.310u 3.476s

Re: svn commit: r292955 - head/lib/libmd

2015-12-31 Thread Jonathan T. Looney
Dear Bruce, On 12/30/15, 10:03 PM, "Bruce Evans" wrote: >On Wed, 30 Dec 2015, Jonathan T. Looney wrote: > >> Log: >> Fix a file descriptor leak in mdXhl.c (which is used by numerous >>hashing >> algorithms. > >This code had amazingly low quality and is still especially

Re: svn commit: r292955 - head/lib/libmd

2015-12-31 Thread Jonathan T. Looney
On 12/31/15, 2:15 AM, "Allan Jude" wrote: >It seems these problems also slow things down, a lot: > ># time md5 /media/md5test/bigdata >MD5 (/media/md5test/bigdata) = 6afad0bf5d8318093e943229be05be67 >4.310u 3.476s 0:07.79 99.8% 20+167k 0+0io 0pf+0w ># time env

Re: svn commit: r292955 - head/lib/libmd

2015-12-30 Thread Allan Jude
On 2015-12-30 23:10, Bruce Evans wrote: > On Thu, 31 Dec 2015, Bruce Evans wrote: > >> >> wc /proc/0/* works. md5 works like wc using a hack to avoid calling this >> broken function. E.g., >> >>for i in $(ls /proc/0/*); do echo -n "$i: "; md5 <$i; done # gives >> >> /proc/0/cmdline:

Re: svn commit: r292955 - head/lib/libmd

2015-12-30 Thread Bruce Evans
On Wed, 30 Dec 2015, Jonathan T. Looney wrote: Log: Fix a file descriptor leak in mdXhl.c (which is used by numerous hashing algorithms. This code had amazingly low quality and is still especially broken near the main leak fixed. Modified: head/lib/libmd/mdXhl.c

Re: svn commit: r292955 - head/lib/libmd

2015-12-30 Thread Bruce Evans
On Thu, 31 Dec 2015, Bruce Evans wrote: wc /proc/0/* works. md5 works like wc using a hack to avoid calling this broken function. E.g., for i in $(ls /proc/0/*); do echo -n "$i: "; md5 <$i; done # gives /proc/0/cmdline: 3c5896b1ac441f4998f052e2126e8d20 /proc/0/ctl:

svn commit: r292955 - head/lib/libmd

2015-12-30 Thread Jonathan T. Looney
Author: jtl Date: Wed Dec 30 18:04:50 2015 New Revision: 292955 URL: https://svnweb.freebsd.org/changeset/base/292955 Log: Fix a file descriptor leak in mdXhl.c (which is used by numerous hashing algorithms. CID: 1305669,1305611,1305663,1305603,1305584,1305639,1346865,1305601