Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

On Tue, 12 Jan 2016, Conrad Meyer wrote: On Tue, Jan 12, 2016 at 5:32 PM, Ian Lepore wrote: Yep, but then I had to do this because ef->off is 64 bits even on 32 bit arches, so I got a pointer/int size mismatch warning... Index: common/load_elf.c

Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

On Tue, 12 Jan 2016, Ian Lepore wrote: On Wed, 2016-01-13 at 01:17 +, Steven Hartland wrote: On 13/01/2016 00:54, Ian Lepore wrote: On Wed, 2016-01-13 at 00:43 +, Steven Hartland wrote: ... Passes a full tinderbox so I assume your forcing gcc for some reason? For several reasons.

Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

On Wed, 2016-01-13 at 00:43 +, Steven Hartland wrote: > On 13/01/2016 00:41, Ian Lepore wrote: > > On Tue, 2016-01-12 at 02:17 +, Steven Hartland wrote: > > > Author: smh > > > Date: Tue Jan 12 02:17:39 2016 > > > New Revision: 293724 > > > URL:

Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

On Tue, Jan 12, 2016 at 4:54 PM, Ian Lepore wrote: ... > For several reasons. The fact that gcc isn't the default compiler > doesn't mean that it's okay for code to not compile with gcc; it's > still a supported compiler for arm. Agreed. It also makes things messier when

Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

On 2016-01-12 20:05, NGie Cooper wrote: On Tue, Jan 12, 2016 at 4:54 PM, Ian Lepore wrote: ... For several reasons. The fact that gcc isn't the default compiler doesn't mean that it's okay for code to not compile with gcc; it's still a supported compiler for arm. Agreed.

Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

On 13/01/2016 00:54, Ian Lepore wrote: On Wed, 2016-01-13 at 00:43 +, Steven Hartland wrote: On 13/01/2016 00:41, Ian Lepore wrote: On Tue, 2016-01-12 at 02:17 +, Steven Hartland wrote: Author: smh Date: Tue Jan 12 02:17:39 2016 New Revision: 293724 URL:

Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

On 13/01/2016 01:10, Allan Jude wrote: On 2016-01-12 20:05, NGie Cooper wrote: On Tue, Jan 12, 2016 at 4:54 PM, Ian Lepore wrote: ... For several reasons. The fact that gcc isn't the default compiler doesn't mean that it's okay for code to not compile with gcc; it's still

Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

On 13/01/2016 00:41, Ian Lepore wrote: On Tue, 2016-01-12 at 02:17 +, Steven Hartland wrote: Author: smh Date: Tue Jan 12 02:17:39 2016 New Revision: 293724 URL: https://svnweb.freebsd.org/changeset/base/293724 Log: Enable warnings in EFI boot code Set WARNS if not set for EFI

Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

On Tue, 2016-01-12 at 02:17 +, Steven Hartland wrote: > Author: smh > Date: Tue Jan 12 02:17:39 2016 > New Revision: 293724 > URL: https://svnweb.freebsd.org/changeset/base/293724 > > Log: > Enable warnings in EFI boot code > > Set WARNS if not set for EFI boot code and fix the issues

Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

On Wed, 2016-01-13 at 01:17 +, Steven Hartland wrote: > > On 13/01/2016 00:54, Ian Lepore wrote: > > On Wed, 2016-01-13 at 00:43 +, Steven Hartland wrote: > > > On 13/01/2016 00:41, Ian Lepore wrote: > > > > On Tue, 2016-01-12 at 02:17 +, Steven Hartland wrote: > > > > > Author: smh >

Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

On Wed, 2016-01-13 at 01:17 +, Steven Hartland wrote: > > On 13/01/2016 00:54, Ian Lepore wrote: > > [...] > > Could you detail detail how you're switching to gcc so I an run a > full pass on that too? > > Regards > Steve > > I have this in the make.conf I use for this

Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

On Tue, Jan 12, 2016 at 5:32 PM, Ian Lepore wrote: > Yep, but then I had to do this because ef->off is 64 bits even on 32 > bit arches, so I got a pointer/int size mismatch warning... > > Index: common/load_elf.c >

svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64 i...

Author: smh Date: Tue Jan 12 02:17:39 2016 New Revision: 293724 URL: https://svnweb.freebsd.org/changeset/base/293724 Log: Enable warnings in EFI boot code Set WARNS if not set for EFI boot code and fix the issues highlighted by setting it. Most components are set to WARNS level 6