Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread Conrad Meyer
I'll borrow my explanation from the NTB review: There is the sbuf itself, and there is some buffer for data. Either can be on the stack or the heap independently. This is controlled with the DYNSTRUCT and DYNAMIC flags respectively. sbuf_new() just initializes an sbuf. Depending on the inputs pas

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread Ulrich Spörlein
On Apr 26, 2016 11:44 AM, "Conrad Meyer" wrote: > > Right. False positive. Coverity doesn't grok sbuf memory management fully. > If someone can explain it to me in very simple words, I can update the model to make these go away ... maybe. ___ svn-src-

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread Conrad Meyer
Right. False positive. Coverity doesn't grok sbuf memory management fully. On Tue, Apr 26, 2016 at 11:22 AM, NGie Cooper wrote: > > > On Apr 26, 2016, at 11:03, Ulrich Spörlein wrote: > > > > 2016-04-25 10:06 GMT-07:00 Jamie Gritton : > >> Author: jamie > >> Date: Mon Apr 25 17:06:50 2016 > >

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread NGie Cooper
> On Apr 26, 2016, at 11:03, Ulrich Spörlein wrote: > > 2016-04-25 10:06 GMT-07:00 Jamie Gritton : >> Author: jamie >> Date: Mon Apr 25 17:06:50 2016 >> New Revision: 298585 >> URL: https://svnweb.freebsd.org/changeset/base/298585 >> >> Log: >> Encapsulate SYSV IPC objects in jails. Define pe

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread Ulrich Spörlein
2016-04-25 10:06 GMT-07:00 Jamie Gritton : > Author: jamie > Date: Mon Apr 25 17:06:50 2016 > New Revision: 298585 > URL: https://svnweb.freebsd.org/changeset/base/298585 > > Log: > Encapsulate SYSV IPC objects in jails. Define per-module parameters > sysvmsg, sysvsem, and sysvshm, with the fo

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread Konstantin Belousov
On Mon, Apr 25, 2016 at 05:06:50PM +, Jamie Gritton wrote: > Author: jamie > Date: Mon Apr 25 17:06:50 2016 > New Revision: 298585 > URL: https://svnweb.freebsd.org/changeset/base/298585 > > Log: > Encapsulate SYSV IPC objects in jails. Define per-module parameters > sysvmsg, sysvsem, and

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-25 Thread James Gritton
That's a big oops on my part - msg and sem had nearly identical logic, but I got it backwards on shm. I'll put a fix in shortly. - Jamie On 2016-04-25 14:28, Subbsd wrote: I do not know how it works for/in jails, but looks like this breaks work SHM in host. I've got on any QT-based applicati

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-25 Thread Subbsd
I do not know how it works for/in jails, but looks like this breaks work SHM in host. I've got on any QT-based application after this commit: EP Get failed: 'Feature not implemented. The feature requested is not implemented by the recipient or server and therefore cannot be processed.' (501)" [23:

svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-25 Thread Jamie Gritton
Author: jamie Date: Mon Apr 25 17:06:50 2016 New Revision: 298585 URL: https://svnweb.freebsd.org/changeset/base/298585 Log: Encapsulate SYSV IPC objects in jails. Define per-module parameters sysvmsg, sysvsem, and sysvshm, with the following bahavior: inherit: allow full access to the I