Re: svn commit: r302253 - head/sys/cam/scsi

2016-06-28 Thread Kenneth D. Merry
On Tue, Jun 28, 2016 at 11:27:25 -0700, Sean Bruno wrote: > > > On 06/28/16 11:17, Ken Merry wrote: > > This is incorrect. It should be scsi_ulto4b() instead. > > > > The dxfer_len argument to scsi_persistent_reserve_out() is a uint32_t, and > > the length field in the CDB structure is 4

Re: svn commit: r302253 - head/sys/cam/scsi

2016-06-28 Thread Sean Bruno
On 06/28/16 11:17, Ken Merry wrote: > This is incorrect. It should be scsi_ulto4b() instead. > > The dxfer_len argument to scsi_persistent_reserve_out() is a uint32_t, and > the length field in the CDB structure is 4 bytes long. > > Sorry I didn’t get around to commenting on the PR,

Re: svn commit: r302253 - head/sys/cam/scsi

2016-06-28 Thread Ken Merry
This is incorrect. It should be scsi_ulto4b() instead. The dxfer_len argument to scsi_persistent_reserve_out() is a uint32_t, and the length field in the CDB structure is 4 bytes long. Sorry I didn’t get around to commenting on the PR, otherwise I would have caught this previously. Ken —

svn commit: r302253 - head/sys/cam/scsi

2016-06-28 Thread Sean Bruno
Author: sbruno Date: Tue Jun 28 18:08:47 2016 New Revision: 302253 URL: https://svnweb.freebsd.org/changeset/base/302253 Log: Correct PERSISTENT RESERVE OUT command and populate scsi_cmd->length. PR: 202625 Submitted by: niakr...@gmail.com Reviewed by: scottl Approved by: