On 07/20/16 18:35, Gleb Smirnoff wrote:
Randall,
I have just tested and r303037 brings the TCP panic back. I
got two crashes during 2.5 hours.
Hi Gleb,
There is more than one way to fix the TCP panic. You don't _need_ to
change the return values of callout_stop(). You _can_ make a new
You are most welcome to backout anything you like.. as far as
I am concerned you own the code..
R
> On Jul 20, 2016, at 6:35 PM, Gleb Smirnoff wrote:
>
> Randall,
>
> I have just tested and r303037 brings the TCP panic back. I
> got two crashes during 2.5 hours.
>
> In
Randall,
I have just tested and r303037 brings the TCP panic back. I
got two crashes during 2.5 hours.
In your email [1] you are right, there is regression that (-1)
return value is lost. This problem was worked on in the PR 210884,
and we were very close to commiting the fix.
The whole
Gleb
I wish you would have responded earlier.. I am more than glad to hand
off all kern_timeout.c to you… please take it commit what you want to
it and have it. I hate the code and I dislike having to touch it.
Its yours.. I can assure you I will not touch it again.
R
> On Jul 20, 2016, at 8:53
On Tue, Jul 19, 2016 at 06:31:19PM +, Randall Stewart wrote:
R> Author: rrs
R> Date: Tue Jul 19 18:31:19 2016
R> New Revision: 303037
R> URL: https://svnweb.freebsd.org/changeset/base/303037
R>
R> Log:
R> This reverts out Gleb's changes and adds three small
R> fixes that I think closes up
> On Jul 19, 2016, at 11:31, Randall Stewart wrote:
>
> Author: rrs
> Date: Tue Jul 19 18:31:19 2016
> New Revision: 303037
> URL: https://svnweb.freebsd.org/changeset/base/303037
>
> Log:
> This reverts out Gleb's changes and adds three small
> fixes that I think closes up
Author: rrs
Date: Tue Jul 19 18:31:19 2016
New Revision: 303037
URL: https://svnweb.freebsd.org/changeset/base/303037
Log:
This reverts out Gleb's changes and adds three small
fixes that I think closes up the races Gleb was
looking for. This is running quite nicely in Netflix and
now no