On Fri, Apr 07, 2017 at 11:02:06AM -0700, Ngie Cooper wrote:
> Bah. I missed the nested FreeBSD in OpenBSD comment.. nevermind the part
> about enabling power support. It's too early for me to be thinking critically
> I guess..
But you are helping support my case for
On Thu, Apr 06, 2017 at 10:19:48PM -0700, Ngie Cooper (yaneurabeya) wrote:
> > On Apr 6, 2017, at 15:21, David E. O'Brien wrote:
> Hi David,
> I think you meant to delete the other piece of code (__FreeBSD__ is
> always defined).
Hi Ngie,
I removed 100% dead code.
> On Apr 7, 2017, at 10:59, Ngie Cooper wrote:
>
>
>> On Apr 7, 2017, at 10:17, Xin LI wrote:
>>
>> No, David's change was correct.
>>
>> The code context is something like:
>>
>> #ifdef __FreeBSD__
>> [...]
>> #else /* OpenBSD */
>> ...
>> #ifdef
> On Apr 7, 2017, at 10:17, Xin LI wrote:
>
> No, David's change was correct.
>
> The code context is something like:
>
> #ifdef __FreeBSD__
> [...]
> #else /* OpenBSD */
> ...
> #ifdef __FreeBSD__ /* -- this portion got removed -- */
> ...
> #else
> ...
> #endif
> [...]
>
No, David's change was correct.
The code context is something like:
#ifdef __FreeBSD__
[...]
#else /* OpenBSD */
...
#ifdef __FreeBSD__ /* -- this portion got removed -- */
...
#else
...
#endif
[...]
#endif
On Thu, Apr 6, 2017 at 10:19 PM, Ngie Cooper (yaneurabeya)
> On Apr 6, 2017, at 15:21, David E. O'Brien wrote:
>
> Author: obrien
> Date: Thu Apr 6 22:21:49 2017
> New Revision: 316591
> URL: https://svnweb.freebsd.org/changeset/base/316591
>
> Log:
> Remove dead code.
> The #ifdef __FreeBSD__ section within the OpenBSD
Author: obrien
Date: Thu Apr 6 22:21:49 2017
New Revision: 316591
URL: https://svnweb.freebsd.org/changeset/base/316591
Log:
Remove dead code.
The #ifdef __FreeBSD__ section within the OpenBSD tpm_attach() implementation
can never be active.
Modified:
head/sys/dev/tpm/tpm.c
Modified: