Re: svn commit: r318539 - head/lib/libthr/thread

2017-07-26 Thread Michael Zhilin
Konstantin, Thank you for quick reply. Here is review request to revert field change: https://reviews.freebsd.org/D11738 Thanks! On Wed, Jul 26, 2017 at 6:23 PM, Konstantin Belousov wrote: > On Wed, Jul 26, 2017 at 06:09:00PM +0300, Michael Zhilin wrote: > > Hi Eric,

Re: svn commit: r318539 - head/lib/libthr/thread

2017-07-26 Thread Konstantin Belousov
On Wed, Jul 26, 2017 at 06:09:00PM +0300, Michael Zhilin wrote: > Hi Eric, Konstantin, > > This commit breaks libthread_db a bit, particular change is: > -struct pthread_key _thread_keytable[PTHREAD_KEYS_MAX]; > +static struct pthread_key _thread_keytable[PTHREAD_KEYS_MAX]; > > In libthread_db

Re: svn commit: r318539 - head/lib/libthr/thread

2017-07-26 Thread Michael Zhilin
Hi Eric, Konstantin, This commit breaks libthread_db a bit, particular change is: -struct pthread_key _thread_keytable[PTHREAD_KEYS_MAX]; +static struct pthread_key _thread_keytable[PTHREAD_KEYS_MAX]; In libthread_db there is check if _thread_keytable is found in symbols of debugged process:

svn commit: r318539 - head/lib/libthr/thread

2017-05-19 Thread Eric van Gyzen
Author: vangyzen Date: Fri May 19 13:04:05 2017 New Revision: 318539 URL: https://svnweb.freebsd.org/changeset/base/318539 Log: libthr: fix warnings at WARNS=6 Fix warnings about the following when WARNS=6 (which I will commit soon): - casting away const - no previous 'extern'