Re: svn commit: r324609 - head/sys/sys

2017-10-14 Thread Mateusz Guzik
On Sat, Oct 14, 2017 at 11:23 AM, Svatopluk Kraus wrote: > On Sat, Oct 14, 2017 at 2:48 AM, Mateusz Guzik wrote: > > Justification for the change was provided in the commit message: it makes > > .text smaller on amd64 and probably all architectures. > > > >

Re: svn commit: r324609 - head/sys/sys

2017-10-14 Thread Svatopluk Kraus
On Sat, Oct 14, 2017 at 2:48 AM, Mateusz Guzik wrote: > On Sat, Oct 14, 2017 at 2:30 AM, Ian Lepore wrote: >> >> On Fri, 2017-10-13 at 23:38 +0200, Svatopluk Kraus wrote: >> > MTX_UNOWNED is a flag. You did not change its value from 4 to 0, you >> > removed

Re: svn commit: r324609 - head/sys/sys

2017-10-13 Thread Mateusz Guzik
On Sat, Oct 14, 2017 at 2:30 AM, Ian Lepore wrote: > On Fri, 2017-10-13 at 23:38 +0200, Svatopluk Kraus wrote: > > MTX_UNOWNED is a flag. You did not change its value from 4 to 0, you > > removed it actually. I have very bad feeling about it. But maybe, it's > > really possible

Re: svn commit: r324609 - head/sys/sys

2017-10-13 Thread Ian Lepore
On Fri, 2017-10-13 at 23:38 +0200, Svatopluk Kraus wrote: > MTX_UNOWNED is a flag. You did not change its value from 4 to 0, you > removed it actually. I have very bad feeling about it. But maybe, it's > really possible and in that case, a very good explanation should be > provided. > > Svata >

Re: svn commit: r324609 - head/sys/sys

2017-10-13 Thread Svatopluk Kraus
MTX_UNOWNED is a flag. You did not change its value from 4 to 0, you removed it actually. I have very bad feeling about it. But maybe, it's really possible and in that case, a very good explanation should be provided. Svata On Fri, Oct 13, 2017 at 10:31 PM, Mateusz Guzik

Re: svn commit: r324609 - head/sys/sys

2017-10-13 Thread Mateusz Guzik
On Fri, Oct 13, 2017 at 10:54 PM, Ian Lepore wrote: > On Fri, 2017-10-13 at 20:31 +, Mateusz Guzik wrote: > > Author: mjg > > Date: Fri Oct 13 20:31:56 2017 > > New Revision: 324609 > > URL: https://svnweb.freebsd.org/changeset/base/324609 > > > > Log: > > mtx: change

Re: svn commit: r324609 - head/sys/sys

2017-10-13 Thread Ian Lepore
On Fri, 2017-10-13 at 20:31 +, Mateusz Guzik wrote: > Author: mjg > Date: Fri Oct 13 20:31:56 2017 > New Revision: 324609 > URL: https://svnweb.freebsd.org/changeset/base/324609 > > Log: >   mtx: change MTX_UNOWNED from 4 to 0 >    >   The value is spread all over the kernel and zeroing a

svn commit: r324609 - head/sys/sys

2017-10-13 Thread Mateusz Guzik
Author: mjg Date: Fri Oct 13 20:31:56 2017 New Revision: 324609 URL: https://svnweb.freebsd.org/changeset/base/324609 Log: mtx: change MTX_UNOWNED from 4 to 0 The value is spread all over the kernel and zeroing a register is cheaper/shorter than setting it up to an arbitrary value.