Re: svn commit: r339468 - in head/sys: kern sys

2018-10-20 Thread Conrad Meyer
Yep! On Sat, Oct 20, 2018 at 1:49 PM Ed Schouten wrote: > > Op za 20 okt. 2018 om 21:59 schreef Conrad Meyer : > > > Can kdb_active, tp == NULL and panicstr != NULL even occur in this > > > case? tty_info() can only get called in non-degenerate cases, right? > > > > I think you are correct, but I

Re: svn commit: r339468 - in head/sys: kern sys

2018-10-20 Thread Ed Schouten
Op za 20 okt. 2018 om 21:59 schreef Conrad Meyer : > > Can kdb_active, tp == NULL and panicstr != NULL even occur in this > > case? tty_info() can only get called in non-degenerate cases, right? > > I think you are correct, but I did not want to investigate to confirm. > This was just the direct,

Re: svn commit: r339468 - in head/sys: kern sys

2018-10-20 Thread Conrad Meyer
Hi Ed, On Sat, Oct 20, 2018 at 11:54 AM Ed Schouten wrote: > Op za 20 okt. 2018 om 20:31 schreef Conrad Meyer : > > +static int > > +sbuf_tty_drain(void *a, const char *d, int len) > > +{ > > + struct tty *tp; > > + int rc; > > + > > + tp = a; > > + > > + if (kdb_active)

Re: svn commit: r339468 - in head/sys: kern sys

2018-10-20 Thread Ed Schouten
Hi there, Op za 20 okt. 2018 om 20:31 schreef Conrad Meyer : > +static int > +sbuf_tty_drain(void *a, const char *d, int len) > +{ > + struct tty *tp; > + int rc; > + > + tp = a; > + > + if (kdb_active) { > + cnputsn(d, len); > + return (len); >

svn commit: r339468 - in head/sys: kern sys

2018-10-20 Thread Conrad Meyer
Author: cem Date: Sat Oct 20 18:31:36 2018 New Revision: 339468 URL: https://svnweb.freebsd.org/changeset/base/339468 Log: Replace ttyprintf with sbuf_printf and tty drain routine Add string variants of cnputc and tty_putchar, and use them from the tty sbuf drain routine. Suggested