Author: emaste
Date: Tue Aug 20 17:44:03 2019
New Revision: 351254
URL: https://svnweb.freebsd.org/changeset/base/351254
Log:
mqueuefs: fix compat32 struct file leak
In a compat32 error case we previously leaked a struct file.
Submitted by: Karsten König, Secfault Security
Security: CVE-2019-5603
Modified:
head/sys/kern/uipc_mqueue.c
Modified: head/sys/kern/uipc_mqueue.c
==============================================================================
--- head/sys/kern/uipc_mqueue.c Tue Aug 20 17:39:32 2019 (r351253)
+++ head/sys/kern/uipc_mqueue.c Tue Aug 20 17:44:03 2019 (r351254)
@@ -2806,7 +2806,7 @@ freebsd32_kmq_timedsend(struct thread *td,
if (uap->abs_timeout != NULL) {
error = copyin(uap->abs_timeout, &ets32, sizeof(ets32));
if (error != 0)
- return (error);
+ goto out;
CP(ets32, ets, tv_sec);
CP(ets32, ets, tv_nsec);
abs_timeout = &ets;
@@ -2815,6 +2815,7 @@ freebsd32_kmq_timedsend(struct thread *td,
waitok = !(fp->f_flag & O_NONBLOCK);
error = mqueue_send(mq, uap->msg_ptr, uap->msg_len,
uap->msg_prio, waitok, abs_timeout);
+out:
fdrop(fp, td);
return (error);
}
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
