Hmm
It looks like BBR needs an update too since it calls the inpcb detach of the
ratelimit function too… I may
need to reassess this since it should use only the tcp_ratelimit interfaces…
but for now an simple
ifdef will work
make sure to pick up r352660
(and actually it might be best to
Right
Thats because GENERIC does not add the optional TCP stacks.
Ok the problem is fixed with r352659
The tcp_ratelimit.h had a mixed up ifdef
i.e.
#ifdef RATELIMIT
#ifdef _KERNEL
definitions
#else
macro definitions that return error
#endif
#endif
Which should have been the opposite
Ok I have found it
Its a reversal in an ifdef in tcp_ratelimit.h .. it supposed to be that if
its not define (RATELIMIT) the main interfaces return errors.. and the
ifdef kernel/ratelimit is reversed of what it should be.
Let me fix that :)
R
> On Sep 24, 2019, at 12:55 PM, Randall Stewart
I mean the head (r352657) world and GENERIC kernel can be built
successfully on 12.0-R, which is we guaranteed.
Also the LINT kernel build is fine on CI:
https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/13781/
So I was curious about the build environment of that build failure.
Best,
Li-Wen
On
12.0R would not have BBR .. its only in head… hmm it could be a issue with
TCP_RATELIMIT not defined
though I did compile GENERIC without the extra stacks (and without rate limit
and hpts) and that
compiled ok..
R
> On Sep 24, 2019, at 12:49 PM, Li-Wen Hsu wrote:
>
> On Tue, Sep 24, 2019 at
This is strange I built this and have it running on my machine
with the standard
make buildkern KERNCONF=myconf
and
make installkern KERNCONF=myconf
Why can I build and it blow up.. last time I saw this I was building in
amd64/compile and
was getting a warning that somehow is an error.. but
On Tue, Sep 24, 2019 at 9:29 PM O. Hartmann wrote:
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Am Tue, 24 Sep 2019 18:18:11 + (UTC)
> Randall Stewart schrieb:
>
> > Author: rrs
> > Date: Tue Sep 24 18:18:11 2019
> > New Revision: 352657
> > URL:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Am Tue, 24 Sep 2019 18:18:11 + (UTC)
Randall Stewart schrieb:
> Author: rrs
> Date: Tue Sep 24 18:18:11 2019
> New Revision: 352657
> URL: https://svnweb.freebsd.org/changeset/base/352657
>
> Log:
> This commit adds BBR (Bottleneck
Author: rrs
Date: Tue Sep 24 18:18:11 2019
New Revision: 352657
URL: https://svnweb.freebsd.org/changeset/base/352657
Log:
This commit adds BBR (Bottleneck Bandwidth and RTT) congestion control. This
is a completely separate TCP stack (tcp_bbr.ko) that will be built only if
you add the make
