Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Pedro Giffuni
On 22/02/2020 14:37, Kyle Evans wrote: On Sat, Feb 22, 2020 at 1:21 PM Pedro Giffuni wrote: On 22/02/2020 14:13, Ian Lepore wrote: On Sat, 2020-02-22 at 20:01 +0100, Dimitry Andric wrote: On 22 Feb 2020, at 17:44, Mateusz Guzik wrote: On 2/22/20, Kyle Evans wrote: On Sat, Feb 22, 2020

Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Joerg Sonnenberger
On Sat, Feb 22, 2020 at 08:24:45PM +0100, Dimitry Andric wrote: > It might be better to define our own UNREACHABLE macro, similar to what > llvm itself does, roughly something like: > > __noreturn void internal_unreachable(const char *, const char *, int); > #define UNREACHABLE(msg)

Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Kyle Evans
On Sat, Feb 22, 2020 at 1:21 PM Pedro Giffuni wrote: > > > On 22/02/2020 14:13, Ian Lepore wrote: > > On Sat, 2020-02-22 at 20:01 +0100, Dimitry Andric wrote: > >> On 22 Feb 2020, at 17:44, Mateusz Guzik wrote: > >>> On 2/22/20, Kyle Evans wrote: > On Sat, Feb 22, 2020 at 10:25 AM Ian

Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Dimitry Andric
On 22 Feb 2020, at 20:13, Ian Lepore wrote: > > On Sat, 2020-02-22 at 20:01 +0100, Dimitry Andric wrote: ... >> E.g. this is *not* meant as a way to enforce the program to abort at >> runtime, if the supposedly unreachable part is actually reached. >> >> For this purpose, one should use an

Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Pedro Giffuni
On 22/02/2020 14:13, Ian Lepore wrote: On Sat, 2020-02-22 at 20:01 +0100, Dimitry Andric wrote: On 22 Feb 2020, at 17:44, Mateusz Guzik wrote: On 2/22/20, Kyle Evans wrote: On Sat, Feb 22, 2020 at 10:25 AM Ian Lepore wrote: On Sat, 2020-02-22 at 16:20 +, Kyle Evans wrote: Author:

Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Ian Lepore
On Sat, 2020-02-22 at 20:01 +0100, Dimitry Andric wrote: > On 22 Feb 2020, at 17:44, Mateusz Guzik wrote: > > > > On 2/22/20, Kyle Evans wrote: > > > On Sat, Feb 22, 2020 at 10:25 AM Ian Lepore > > > wrote: > > > > > > > > On Sat, 2020-02-22 at 16:20 +, Kyle Evans wrote: > > > > > Author:

Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Dimitry Andric
On 22 Feb 2020, at 17:44, Mateusz Guzik wrote: > > On 2/22/20, Kyle Evans wrote: >> On Sat, Feb 22, 2020 at 10:25 AM Ian Lepore wrote: >>> >>> On Sat, 2020-02-22 at 16:20 +, Kyle Evans wrote: Author: kevans Date: Sat Feb 22 16:20:04 2020 New Revision: 358248 URL:

Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Kyle Evans
On Sat, Feb 22, 2020 at 11:18 AM Mateusz Guzik wrote: > > On 2/22/20, Kyle Evans wrote: > > On Sat, Feb 22, 2020 at 10:44 AM Mateusz Guzik wrote: > >> > >> On 2/22/20, Kyle Evans wrote: > >> > On Sat, Feb 22, 2020 at 10:25 AM Ian Lepore wrote: > >> >> > >> >> On Sat, 2020-02-22 at 16:20

Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Mateusz Guzik
On 2/22/20, Kyle Evans wrote: > On Sat, Feb 22, 2020 at 10:44 AM Mateusz Guzik wrote: >> >> On 2/22/20, Kyle Evans wrote: >> > On Sat, Feb 22, 2020 at 10:25 AM Ian Lepore wrote: >> >> >> >> On Sat, 2020-02-22 at 16:20 +, Kyle Evans wrote: >> >> > Author: kevans >> >> > Date: Sat Feb 22

Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Kyle Evans
On Sat, Feb 22, 2020 at 10:44 AM Mateusz Guzik wrote: > > On 2/22/20, Kyle Evans wrote: > > On Sat, Feb 22, 2020 at 10:25 AM Ian Lepore wrote: > >> > >> On Sat, 2020-02-22 at 16:20 +, Kyle Evans wrote: > >> > Author: kevans > >> > Date: Sat Feb 22 16:20:04 2020 > >> > New Revision: 358248 >

Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Mateusz Guzik
On 2/22/20, Kyle Evans wrote: > On Sat, Feb 22, 2020 at 10:25 AM Ian Lepore wrote: >> >> On Sat, 2020-02-22 at 16:20 +, Kyle Evans wrote: >> > Author: kevans >> > Date: Sat Feb 22 16:20:04 2020 >> > New Revision: 358248 >> > URL: https://svnweb.freebsd.org/changeset/base/358248 >> > >> >

Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Kyle Evans
On Sat, Feb 22, 2020 at 10:25 AM Ian Lepore wrote: > > On Sat, 2020-02-22 at 16:20 +, Kyle Evans wrote: > > Author: kevans > > Date: Sat Feb 22 16:20:04 2020 > > New Revision: 358248 > > URL: https://svnweb.freebsd.org/changeset/base/358248 > > > > Log: > > vm_radix: prefer

Re: svn commit: r358248 - head/sys/vm

2020-02-22 Thread Ian Lepore
On Sat, 2020-02-22 at 16:20 +, Kyle Evans wrote: > Author: kevans > Date: Sat Feb 22 16:20:04 2020 > New Revision: 358248 > URL: https://svnweb.freebsd.org/changeset/base/358248 > > Log: > vm_radix: prefer __builtin_unreachable() to an unreachable panic() > > This provides the needed

svn commit: r358248 - head/sys/vm

2020-02-22 Thread Kyle Evans
Author: kevans Date: Sat Feb 22 16:20:04 2020 New Revision: 358248 URL: https://svnweb.freebsd.org/changeset/base/358248 Log: vm_radix: prefer __builtin_unreachable() to an unreachable panic() This provides the needed hint to GCC and offers an annotation for readers to observe that it's