Re: svn commit: r366207 - head/lib/libc/gen

2020-10-01 Thread Kyle Evans
On Thu, Oct 1, 2020 at 10:45 AM Konstantin Belousov wrote: > > On Mon, Sep 28, 2020 at 07:01:38PM +0300, Konstantin Belousov wrote: > > On Mon, Sep 28, 2020 at 10:06:55AM -0500, Kyle Evans wrote: > > > I would be tempted to just revert the rest of the local modifications > > > (sans negative

Re: svn commit: r366207 - head/lib/libc/gen

2020-10-01 Thread Konstantin Belousov
On Mon, Sep 28, 2020 at 07:01:38PM +0300, Konstantin Belousov wrote: > On Mon, Sep 28, 2020 at 10:06:55AM -0500, Kyle Evans wrote: > > I would be tempted to just revert the rest of the local modifications > > (sans negative check, maybe) and widen it in the one spot that the > > compiler complains

Re: svn commit: r366207 - head/lib/libc/gen

2020-09-28 Thread Konstantin Belousov
On Mon, Sep 28, 2020 at 10:06:55AM -0500, Kyle Evans wrote: > I would be tempted to just revert the rest of the local modifications > (sans negative check, maybe) and widen it in the one spot that the > compiler complains about: > > - if (strlcpy(buf, execpath, buflen_) >=

Re: svn commit: r366207 - head/lib/libc/gen

2020-09-28 Thread Kyle Evans
On Mon, Sep 28, 2020 at 10:04 AM Konstantin Belousov wrote: > > On Sun, Sep 27, 2020 at 10:08:49PM -0600, Alan Somers wrote: > > On Sun, Sep 27, 2020 at 5:15 PM Konstantin Belousov > > wrote: > > > > > On Sun, Sep 27, 2020 at 10:26:41PM +, Alan Somers wrote: > > > > Author: asomers > > > >

Re: svn commit: r366207 - head/lib/libc/gen

2020-09-28 Thread Konstantin Belousov
On Sun, Sep 27, 2020 at 10:08:49PM -0600, Alan Somers wrote: > On Sun, Sep 27, 2020 at 5:15 PM Konstantin Belousov > wrote: > > > On Sun, Sep 27, 2020 at 10:26:41PM +, Alan Somers wrote: > > > Author: asomers > > > Date: Sun Sep 27 22:26:41 2020 > > > New Revision: 366207 > > > URL:

Re: svn commit: r366207 - head/lib/libc/gen

2020-09-28 Thread Scott Long
> On Sep 27, 2020, at 10:08 PM, Alan Somers wrote: > > On Sun, Sep 27, 2020 at 5:15 PM Konstantin Belousov > wrote: > On Sun, Sep 27, 2020 at 10:26:41PM +, Alan Somers wrote: > > Author: asomers > > Date: Sun Sep 27 22:26:41 2020 > > New Revision: 366207 > > URL:

Re: svn commit: r366207 - head/lib/libc/gen

2020-09-27 Thread Alan Somers
On Sun, Sep 27, 2020 at 5:15 PM Konstantin Belousov wrote: > On Sun, Sep 27, 2020 at 10:26:41PM +, Alan Somers wrote: > > Author: asomers > > Date: Sun Sep 27 22:26:41 2020 > > New Revision: 366207 > > URL: https://svnweb.freebsd.org/changeset/base/366207 > > > > Log: > > Misc compiler

Re: svn commit: r366207 - head/lib/libc/gen

2020-09-27 Thread Konstantin Belousov
On Sun, Sep 27, 2020 at 10:26:41PM +, Alan Somers wrote: > Author: asomers > Date: Sun Sep 27 22:26:41 2020 > New Revision: 366207 > URL: https://svnweb.freebsd.org/changeset/base/366207 > > Log: > Misc compiler warning fixes in lib/libc > > Reviewed by:kevans, imp > MFC

svn commit: r366207 - head/lib/libc/gen

2020-09-27 Thread Alan Somers
Author: asomers Date: Sun Sep 27 22:26:41 2020 New Revision: 366207 URL: https://svnweb.freebsd.org/changeset/base/366207 Log: Misc compiler warning fixes in lib/libc Reviewed by: kevans, imp MFC after:2 weeks Differential Revision:https://reviews.freebsd.org/D26534