Re: svn commit: r367692 - head/sys/sys

2020-11-17 Thread John Baldwin
On 11/17/20 2:37 PM, Warner Losh wrote: > On Tue, Nov 17, 2020 at 3:18 PM John Baldwin wrote: > >> On 11/14/20 2:34 PM, Warner Losh wrote: >>> true, but a version bump forces that and versions are cheap enough... >> >> Strictly speaking, version bumps don't force anything to recompile, they >>

Re: svn commit: r367692 - head/sys/sys

2020-11-17 Thread Warner Losh
On Tue, Nov 17, 2020 at 3:18 PM John Baldwin wrote: > On 11/14/20 2:34 PM, Warner Losh wrote: > > true, but a version bump forces that and versions are cheap enough... > > Strictly speaking, version bumps don't force anything to recompile, they > just ensure that newer modules won't load on

Re: svn commit: r367692 - head/sys/sys

2020-11-17 Thread Cy Schubert
In message <0015bc22-4568-93cc-5c77-e97c4f5e2...@freebsd.org>, John Baldwin wri tes: > On 11/14/20 2:34 PM, Warner Losh wrote: > > true, but a version bump forces that and versions are cheap enough... > > Strictly speaking, version bumps don't force anything to recompile, they > just ensure that

Re: svn commit: r367692 - head/sys/sys

2020-11-17 Thread John Baldwin
On 11/14/20 2:34 PM, Warner Losh wrote: > true, but a version bump forces that and versions are cheap enough... Strictly speaking, version bumps don't force anything to recompile, they just ensure that newer modules won't load on older kernels. In this case, the change to sys/ucred.h will result

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Mateusz Guzik
There are "KBI" breaking changes happening all the time and version bumps only sometimes happen. The build process already has infrastructure to rebuild all port kmods as well -- see PORTS_MODULES in make.conf(5) Perhaps it would be beneficial to add checking that the kernel is older than the

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Warner Losh
true, but a version bump forces that and versions are cheap enough... Warner On Sat, Nov 14, 2020 at 1:58 PM Mateusz Guzik wrote: > you are expected to recompile all your kernel modules every time you > update head > > On 11/14/20, Shawn Webb wrote: > > Are there any kernel modules (in base,

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Mateusz Guzik
you are expected to recompile all your kernel modules every time you update head On 11/14/20, Shawn Webb wrote: > Are there any kernel modules (in base, in ports, or out-of-both-trees) > that access struct ucred? > > On Sat, Nov 14, 2020 at 09:51:47PM +0100, Mateusz Guzik wrote: >> I don't think

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Shawn Webb
Are there any kernel modules (in base, in ports, or out-of-both-trees) that access struct ucred? On Sat, Nov 14, 2020 at 09:51:47PM +0100, Mateusz Guzik wrote: > I don't think so, it does not change any APIs > > On 11/14/20, Shawn Webb wrote: > > On Sat, Nov 14, 2020 at 07:20:37PM +,

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Mateusz Guzik
I don't think so, it does not change any APIs On 11/14/20, Shawn Webb wrote: > On Sat, Nov 14, 2020 at 07:20:37PM +, Mateusz Guzik wrote: >> Author: mjg >> Date: Sat Nov 14 19:20:37 2020 >> New Revision: 367692 >> URL: https://svnweb.freebsd.org/changeset/base/367692 >> >> Log: >> cred:

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Shawn Webb
On Sat, Nov 14, 2020 at 07:20:37PM +, Mateusz Guzik wrote: > Author: mjg > Date: Sat Nov 14 19:20:37 2020 > New Revision: 367692 > URL: https://svnweb.freebsd.org/changeset/base/367692 > > Log: > cred: reorder cr_audit to be closer to the lock > > This makes cr_uid avoid sharing. > >

svn commit: r367692 - head/sys/sys

2020-11-14 Thread Mateusz Guzik
Author: mjg Date: Sat Nov 14 19:20:37 2020 New Revision: 367692 URL: https://svnweb.freebsd.org/changeset/base/367692 Log: cred: reorder cr_audit to be closer to the lock This makes cr_uid avoid sharing. Modified: head/sys/sys/ucred.h Modified: head/sys/sys/ucred.h