Re: svn commit: r329812 - head/sys/cam

In our experience this is very device dependent, what lead you to this conclusion? On 22/02/2018 05:43, Warner Losh wrote: Author: imp Date: Thu Feb 22 05:43:20 2018 New Revision: 329812 URL: https://svnweb.freebsd.org/changeset/base/329812 Log: Don't sort TRIMs. While the code for

svn commit: r329817 - in head/etc: . rc.d

Author: araujo Date: Thu Feb 22 08:25:39 2018 New Revision: 329817 URL: https://svnweb.freebsd.org/changeset/base/329817 Log: The firewall_type is ignored if not set in rc.conf or rc.conf.local, after r190575 there is an option to call rc.firewall with the firewall_type passed in as an

svn commit: r329818 - head/sys/cam

Author: imp Date: Thu Feb 22 10:55:23 2018 New Revision: 329818 URL: https://svnweb.freebsd.org/changeset/base/329818 Log: Fix typo in last commit after last rebase before commit... Modified: head/sys/cam/cam_iosched.c Modified: head/sys/cam/cam_iosched.c

svn commit: r329819 - in head/sys: cam cam/ata cam/nvme cam/scsi dev/nvme

Author: imp Date: Thu Feb 22 11:18:33 2018 New Revision: 329819 URL: https://svnweb.freebsd.org/changeset/base/329819 Log: Backout r329818, r329816 and r329815. These aren't the commits I thought I was testing prior to commit. Revert until I can sort out what happened and fix it.

Re: svn commit: r329814 - head/sys/cam

On Thu, Feb 22, 2018 at 12:01 AM, Allan Jude wrote: > On 2018-02-22 01:07, O. Hartmann wrote: > > On Thu, 22 Feb 2018 05:43:50 + (UTC) > > Warner Losh wrote: > > > >> Author: imp > >> Date: Thu Feb 22 05:43:50 2018 > >> New Revision: 329814 > >> URL:

svn commit: r329823 - in head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs: . sys

Author: avg Date: Thu Feb 22 13:06:27 2018 New Revision: 329823 URL: https://svnweb.freebsd.org/changeset/base/329823 Log: another rework of getzfsvfs / getzfsvfs_impl code This change is designed to account for yet another difference between illumos and FreeBSD VFS. In FreeBSD a

svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

Author: wma Date: Thu Feb 22 13:32:31 2018 New Revision: 329824 URL: https://svnweb.freebsd.org/changeset/base/329824 Log: NVMe: Add big-endian support Remove bitfields from defined structures as they are not portable. Instead use shift and mask macros in the driver and nvmecontrol

Re: svn commit: r329737 - head/stand/i386/boot2

On Wed, 21 Feb 2018, Benno Rice wrote: On Feb 21, 2018, at 10:46 AM, Colin Percival wrote: On 02/21/18 10:10, Benno Rice wrote: Curiously, changing whitespace seems to cause the md5 of the .o files to differ these days hence the following testing strategy: Tested

svn commit: r329821 - head/sys/cam

Author: imp Date: Thu Feb 22 11:51:50 2018 New Revision: 329821 URL: https://svnweb.freebsd.org/changeset/base/329821 Log: Revert r329814 as well. It should have been in r329819. Modified: head/sys/cam/cam_iosched.c Modified: head/sys/cam/cam_iosched.c

Re: svn commit: r329814 - head/sys/cam

On Feb 22, 2018 3:57 AM, "Warner Losh" wrote: On Thu, Feb 22, 2018 at 12:01 AM, Allan Jude wrote: > On 2018-02-22 01:07, O. Hartmann wrote: > > On Thu, 22 Feb 2018 05:43:50 + (UTC) > > Warner Losh wrote: > > > >> Author: imp > >>

svn commit: r329820 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: avg Date: Thu Feb 22 11:41:00 2018 New Revision: 329820 URL: https://svnweb.freebsd.org/changeset/base/329820 Log: followup to r329556, completely remove the covered vnode assert vrele() acquires the vnode lock only if the hold count drops to zero. In other scenarios it needs

svn commit: r329822 - head/sbin

Author: wma Date: Thu Feb 22 12:31:28 2018 New Revision: 329822 URL: https://svnweb.freebsd.org/changeset/base/329822 Log: Add bsdlabel and fdisk to powerpc64 Submitted by: Wojciech Macek Obtained from: Semihalf Sponsored by: IBM, QCM

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > Author: wma > Date: Thu Feb 22 13:32:31 2018 > New Revision: 329824 > URL: https://svnweb.freebsd.org/changeset/base/329824 > > Log: > NVMe: Add big-endian support > > Remove bitfields from defined structures as they

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: > On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers wrote: > > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > > > >> Author: wma > >> Date: Thu Feb 22 13:32:31 2018 > >> New

svn commit: r329827 - head/sys/dev/nvme

Author: kevans Date: Thu Feb 22 16:16:49 2018 New Revision: 329827 URL: https://svnweb.freebsd.org/changeset/base/329827 Log: nvme: Unbreak LE builds after r329824 The parameter 'p' is unused if _BYTE_ORDER == _LITTLE_ENDIAN. Add in a (void)p to fix the build. Modified:

svn commit: r329830 - head/sbin/nvmecontrol

Author: asomers Date: Thu Feb 22 17:47:16 2018 New Revision: 329830 URL: https://svnweb.freebsd.org/changeset/base/329830 Log: nvmecontrol: fix build on amd64/clang Broken by:329824 Sponsored by: Spectra Logic Corp Modified: head/sbin/nvmecontrol/identify.c Modified:

Re: svn commit: r329830 - head/sbin/nvmecontrol

On Thu, 2018-02-22 at 17:47 +, Alan Somers wrote: > Author: asomers > Date: Thu Feb 22 17:47:16 2018 > New Revision: 329830 > URL: https://svnweb.freebsd.org/changeset/base/329830 > > Log: >   nvmecontrol: fix build on amd64/clang >    >   Broken by: 329824 >   Sponsored by: Spectra

svn commit: r329831 - head/stand/userboot/userboot

Author: kevans Date: Thu Feb 22 18:49:53 2018 New Revision: 329831 URL: https://svnweb.freebsd.org/changeset/base/329831 Log: Fix userboot w/ ZFS after r329725 r329725 cleaned up ZFS commands duplicated in multiple places, but userboot was not setting HAVE_ZFS when MK_ZFS != "no". This

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

Thanks and sorry for troubles! These lines must have got lost somewhere during rebase as we run tinderbox with this patch yesterday. Regards, Wojtek wma@ 2018-02-22 17:22 GMT+01:00 Alan Somers : > On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: > >>

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

Yes, I'm doing that right now. So far it seems everything is there, but will confirm to be 100% sure. Warner, I'm very sorry for not waiting for your comments. The review was dead for few days and I thought that all was already said, but maybe should have waited a little longer... Let me know

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

On Thu, Feb 22, 2018 at 9:49 AM, Wojciech Macek wrote: > Yes, I'm doing that right now. So far it seems everything is there, but > will confirm to be 100% sure. > > Warner, I'm very sorry for not waiting for your comments. The review was > dead for few days and I thought that

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers wrote: > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > >> Author: wma >> Date: Thu Feb 22 13:32:31 2018 >> New Revision: 329824 >> URL: https://svnweb.freebsd.org/changeset/base/329824 >> >> Log: >>

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: > On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers wrote: > > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > > > >> Author: wma > >> Date: Thu Feb 22 13:32:31 2018 > >> New

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

I know all about losing things during the rebase I'd be a lot happier if you could confirm that nothing else was lost. It's a large patch, which makes it impossible for others to do it... It seems to build, and seems to be working in the light testing I've done this morning... Warner On

svn commit: r329829 - head/sys/kern

Author: vangyzen Date: Thu Feb 22 17:09:26 2018 New Revision: 329829 URL: https://svnweb.freebsd.org/changeset/base/329829 Log: sched_ule: update a comment to reflect reality MFC after:3 days Sponsored by: Dell EMC Modified: head/sys/kern/sched_ule.c Modified:

svn commit: r329833 - stable/11/sys/dev/mxge

Author: rpokala Date: Thu Feb 22 19:39:44 2018 New Revision: 329833 URL: https://svnweb.freebsd.org/changeset/base/329833 Log: MFC r329295: Panasas discovered that ioctl(SIOCGLAGGPORT) returns ENOTTY for mxge(4) when the NIC is not a member of a lagg. This came as a surprise, because the

svn commit: r329835 - stable/10/sys/ofed/drivers/infiniband/core

Author: hselasky Date: Thu Feb 22 20:09:21 2018 New Revision: 329835 URL: https://svnweb.freebsd.org/changeset/base/329835 Log: Fix for LINT-NOINET kernel build. This is a direct commit. Reported by: rpokala@ Sponsored by: Mellanox Technologies Modified:

svn commit: r329837 - head/sys/kern

Author: mjg Date: Thu Feb 22 20:39:25 2018 New Revision: 329837 URL: https://svnweb.freebsd.org/changeset/base/329837 Log: Fix up sysctl vfs.buffercache broken in r329612 Sample problem: top: sysctl(vfs.bufspace...) expected 8, got 4 Reported by: O. Hartmann Modified:

svn commit: r329832 - in head: share/man/man4 sys/conf sys/dev/gpio sys/modules sys/modules/chvgpio

Author: gonzo Date: Thu Feb 22 19:12:32 2018 New Revision: 329832 URL: https://svnweb.freebsd.org/changeset/base/329832 Log: [chvgpio] add GPIO driver for Intel Z8xxx SoC family Add chvgpio(4) driver for Intel Z8xxx SoC family. This product was formerly known as Cherry Trail but Linux

svn commit: r329834 - stable/10/sys/dev/mxge

Author: rpokala Date: Thu Feb 22 19:40:03 2018 New Revision: 329834 URL: https://svnweb.freebsd.org/changeset/base/329834 Log: MFC r329295: Panasas discovered that ioctl(SIOCGLAGGPORT) returns ENOTTY for mxge(4) when the NIC is not a member of a lagg. This came as a surprise, because the

svn commit: r329836 - head/stand/lua

Author: kevans Date: Thu Feb 22 20:10:23 2018 New Revision: 329836 URL: https://svnweb.freebsd.org/changeset/base/329836 Log: lualoader: Attend to some 80-col issues, pointed out by luacheck Graphics have a tendency to cause 80-col issues, so make an exception to our standard indentation

svn commit: r329838 - stable/10/sys/conf

Author: hselasky Date: Thu Feb 22 20:48:02 2018 New Revision: 329838 URL: https://svnweb.freebsd.org/changeset/base/329838 Log: Fix for LINT kernel build. This is a direct commit. Discussed with: np@ Reported by: rpokala@ Sponsored by: Mellanox Technologies Modified:

svn commit: r329841 - head/sys/modules/imx/imx_i2c

Author: ian Date: Thu Feb 22 22:25:26 2018 New Revision: 329841 URL: https://svnweb.freebsd.org/changeset/base/329841 Log: Add a missing line continuation. How many commits does it take to get a simple module makefile working? Apparently at least three. Pointy hat to: ian

svn commit: r329844 - head/sys/kern

Author: truckman Date: Fri Feb 23 00:12:51 2018 New Revision: 329844 URL: https://svnweb.freebsd.org/changeset/base/329844 Log: Decrease latency by not wrapping the idle loop's potentially lengthy search for a thread to steal inside a critical section. Since this allows the search to be

svn commit: r329845 - head/usr.sbin/mptutil

Author: asomers Date: Fri Feb 23 00:17:50 2018 New Revision: 329845 URL: https://svnweb.freebsd.org/changeset/base/329845 Log: Fix numerous Coverity issues in mptutil Most are memory or file descriptor leaks. Three were unannotated fallthroughs in a switch/case statement. One was an

svn commit: r329843 - in head: share/man/man4 sys/conf sys/dev/jedec_dimm sys/modules/i2c sys/modules/i2c/jedec_dimm

Author: rpokala Date: Thu Feb 22 23:18:46 2018 New Revision: 329843 URL: https://svnweb.freebsd.org/changeset/base/329843 Log: jedec_dimm(4): report asset info and temperatures for DDR3 and DDR4 DIMMs A super-set of the functionality of jedec_ts(4). jedec_dimm(4) reports asset

svn commit: r329846 - head/lib/libc/gen

Author: pfg Date: Fri Feb 23 00:28:00 2018 New Revision: 329846 URL: https://svnweb.freebsd.org/changeset/base/329846 Log: getpeereid(3): Fix behavior on failure to match documentation. According to the getpeereid(3) documentation, on failure the value -1 is returned and the global

svn commit: r329860 - head/stand

Author: imp Date: Fri Feb 23 04:06:15 2018 New Revision: 329860 URL: https://svnweb.freebsd.org/changeset/base/329860 Log: Floaty McFloatface is funnier... Submitted by: emaste@ Modified: head/stand/defs.mk Modified: head/stand/defs.mk

svn commit: r329848 - head/lib/libc/stdio

Author: pfg Date: Fri Feb 23 01:11:57 2018 New Revision: 329848 URL: https://svnweb.freebsd.org/changeset/base/329848 Log: __printf_render_int(): small type change to match use. Variable l is consistently used as an int rather than a char. Sort names while here. Obtained from:

svn commit: r329852 - head/stand/lua

Author: kevans Date: Fri Feb 23 02:53:50 2018 New Revision: 329852 URL: https://svnweb.freebsd.org/changeset/base/329852 Log: Add copyright notice to core.lua I've also made some not-insignificant changes/additions to this file, to include the added constants, ACPI changes, boot

svn commit: r329851 - head/stand/lua

Author: kevans Date: Fri Feb 23 02:51:35 2018 New Revision: 329851 URL: https://svnweb.freebsd.org/changeset/base/329851 Log: Add SPDX tags to lua files Modified: head/stand/lua/cli.lua head/stand/lua/color.lua head/stand/lua/config.lua head/stand/lua/core.lua

svn commit: r329855 - head/sys/dev/qlxgbe

Author: davidcs Date: Fri Feb 23 03:36:24 2018 New Revision: 329855 URL: https://svnweb.freebsd.org/changeset/base/329855 Log: 1. Added support to offline a port if is error recovery on successful. 2. Sysctls to enable/disable driver_state_dump and error_recovery. 3. Sysctl to control the

svn commit: r329856 - head/stand/lua

Author: kevans Date: Fri Feb 23 04:03:07 2018 New Revision: 329856 URL: https://svnweb.freebsd.org/changeset/base/329856 Log: lualoader: Use "local function x()" instead of "local x = function()" The latter is good, but the former is more elegant and clear about what 'x' is. Adopt it,

svn commit: r329859 - in head: contrib/compiler-rt/lib/builtins include stand sys/arm/include sys/arm64/include sys/mips/include sys/powerpc/include sys/riscv/include sys/sparc64/include sys/sys sy...

Author: imp Date: Fri Feb 23 04:04:25 2018 New Revision: 329859 URL: https://svnweb.freebsd.org/changeset/base/329859 Log: Do not include float interfaces when using libsa. We don't support float in the boot loaders, so don't include interfaces for float or double in systems headers. In

svn commit: r329857 - in head/stand: . liblua

Author: imp Date: Fri Feb 23 04:04:03 2018 New Revision: 329857 URL: https://svnweb.freebsd.org/changeset/base/329857 Log: Centralize lua defines We need to ensure that we defined Numbers as int64_t everywhere we build for lua. Previously, we were compiling part of the code with

svn commit: r329858 - head/contrib/lua/src

Author: imp Date: Fri Feb 23 04:04:18 2018 New Revision: 329858 URL: https://svnweb.freebsd.org/changeset/base/329858 Log: When the LUA_FLOAT_TYPE != LUA_FLOAT_INT64, we can't reference float or double so ifdef that code out when the numbers aren't float at all. There's still references

svn commit: r329861 - head/stand/lua

Author: kevans Date: Fri Feb 23 04:12:19 2018 New Revision: 329861 URL: https://svnweb.freebsd.org/changeset/base/329861 Log: lualoader: Track effective line number, use it for drawing Takes into account hidden entries, so that we don't draw blank lines in place of a hidden item.

svn commit: r329853 - in head: lib/libifconfig share/examples/libifconfig usr.sbin/wlandebug

Author: asomers Date: Fri Feb 23 03:11:43 2018 New Revision: 329853 URL: https://svnweb.freebsd.org/changeset/base/329853 Log: libifconfig: multiple feature additions Added the ability to: * Create virtual interfaces * Create vlan interfaces * Get interface fib * Get interface

svn commit: r329847 - stable/11/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: mav Date: Fri Feb 23 00:38:42 2018 New Revision: 329847 URL: https://svnweb.freebsd.org/changeset/base/329847 Log: MFC r329091: Add sysctls for dnode block and indirect block shifts. Modified: stable/11/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dnode.c Directory Properties:

Re: svn commit: r329859 - in head: contrib/compiler-rt/lib/builtins include stand sys/arm/include sys/arm64/include sys/mips/include sys/powerpc/include sys/riscv/include sys/sparc64/include sys/sys s

On Fri, 23 Feb 2018, Warner Losh wrote: Log: Do not include float interfaces when using libsa. We don't support float in the boot loaders, so don't include interfaces for float or double in systems headers. In addition, take the unusual step of spiking double and float to prevent any more

svn commit: r329862 - head/sys/powerpc/conf

Author: wma Date: Fri Feb 23 07:43:52 2018 New Revision: 329862 URL: https://svnweb.freebsd.org/changeset/base/329862 Log: powerpc64: add NVMe to GENERIC64 NVMe support is ready and should be compiled-in to the ppc64 kernel. Submitted by: Wojciech Macek

svn commit: r329850 - head/stand/lua

Author: kevans Date: Fri Feb 23 02:47:51 2018 New Revision: 329850 URL: https://svnweb.freebsd.org/changeset/base/329850 Log: lualoader: Drop unused return values; we'll only use the first Modified: head/stand/lua/loader.lua Modified: head/stand/lua/loader.lua

svn commit: r329854 - head/stand/lua

Author: kevans Date: Fri Feb 23 03:18:24 2018 New Revision: 329854 URL: https://svnweb.freebsd.org/changeset/base/329854 Log: lualoader: shallowCopyTable => deepCopyTable I called it a shallow copy, but it wasn't really a shallow copy at all. Modified: head/stand/lua/core.lua

Re: svn commit: r329795 - in vendor-sys/illumos/dist/uts/common: fs/zfs fs/zfs/sys sys/fs

On 22.02.2018 02:16, Andriy Gapon wrote: > On 22/02/2018 04:25, Alexander Motin wrote: >> Author: mav >> Date: Thu Feb 22 02:25:09 2018 >> New Revision: 329795 >> URL: https://svnweb.freebsd.org/changeset/base/329795 >> >> Log: >> r329793 | mav | 2018-02-22 04:21:03 +0200 (чт, 22 февр. 2018) |

Re: svn commit: r329822 - head/sbin

This commit message is missing why these are needed on powerpc, e.g. why aren’t you able to use gpart. Andrew > On 22 Feb 2018, at 12:31, Wojciech Macek wrote: > > Author: wma > Date: Thu Feb 22 12:31:28 2018 > New Revision: 329822 > URL:

svn commit: r329826 - head/tools/boot

Author: kevans Date: Thu Feb 22 15:29:57 2018 New Revision: 329826 URL: https://svnweb.freebsd.org/changeset/base/329826 Log: lua-lint: Add note about luacheck in ports, silence warning luacheck was added in ports r462609. Silence warning about cli_execute -- it's non-standard, but

svn commit: r329825 - in head/sys/compat/linuxkpi/common: include/linux src

Author: hselasky Date: Thu Feb 22 15:29:19 2018 New Revision: 329825 URL: https://svnweb.freebsd.org/changeset/base/329825 Log: Return correct error code to user-space when a system call receives a signal in the LinuxKPI. The read(), write() and mmap() system calls can return either

Re: svn commit: r329817 - in head/etc: . rc.d

> Author: araujo > Date: Thu Feb 22 08:25:39 2018 > New Revision: 329817 > URL: https://svnweb.freebsd.org/changeset/base/329817 > > Log: > The firewall_type is ignored if not set in rc.conf or rc.conf.local, > after r190575 there is an option to call rc.firewall with the firewall_type >