Re: bug triaging (was: Re: svn commit: r331728 - in stable/11/etc: . rc.d)

2018-03-30 11:04 GMT+08:00 Mark Linimon : > This is addressed to developers in general, not just rgrimes, but he > made the comments, so ... > > On Thu, Mar 29, 2018 at 09:33:44AM -0700, Rodney W. Grimes wrote: > > It seems that the Phabricator review system is somewhat

svn commit: r331758 - head/usr.sbin/makefs

Author: emaste Date: Fri Mar 30 03:38:08 2018 New Revision: 331758 URL: https://svnweb.freebsd.org/changeset/base/331758 Log: makefs: sync fragment and block size with newfs r222319 in newfs raised the default blocksize for UFS/FFS filesystems from 16K to 32K and the default fragment

bug triaging (was: Re: svn commit: r331728 - in stable/11/etc: . rc.d)

This is addressed to developers in general, not just rgrimes, but he made the comments, so ... On Thu, Mar 29, 2018 at 09:33:44AM -0700, Rodney W. Grimes wrote: > It seems that the Phabricator review system is somewhat dysfunctional > in that actual review is only happening in some cases. Some

svn commit: r331757 - head/sys/dev/hyperv/vmbus

Author: emaste Date: Fri Mar 30 02:25:12 2018 New Revision: 331757 URL: https://svnweb.freebsd.org/changeset/base/331757 Log: Correct comment typo in Hyper-V PR: 226665 Submitted by: Ryo ONODERA MFC after:3 days Modified: head/sys/dev/hyperv/vmbus/hyperv.c Modified:

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thu, Mar 29, 2018 at 09:33:44AM -0700, Rodney W. Grimes wrote: > ... > It seems that the Phabricator review system is somewhat disfunctional > in that actual review is only happening in some cases. Some people > have even stated they flat out hate it. Others say that it is the > way to go.

svn commit: r331756 - in stable/11/sys/compat/linuxkpi/common: include/asm include/linux include/net src

Author: emaste Date: Fri Mar 30 02:04:46 2018 New Revision: 331756 URL: https://svnweb.freebsd.org/changeset/base/331756 Log: MFC r331433: linuxkpi whitespace cleanup Modified: stable/11/sys/compat/linuxkpi/common/include/asm/byteorder.h

svn commit: r331755 - stable/11/sys/compat/linux

Author: emaste Date: Fri Mar 30 01:53:14 2018 New Revision: 331755 URL: https://svnweb.freebsd.org/changeset/base/331755 Log: MFC r331426: Rationalize license text on Linuxolator files Many licenses on Linuxolator files contained small variations from the standard FreeBSD license text.

svn commit: r331752 - stable/11/sys/conf

Author: emaste Date: Fri Mar 30 01:22:47 2018 New Revision: 331752 URL: https://svnweb.freebsd.org/changeset/base/331752 Log: MFC r320695 (bdrewery): Fix out-of-tree kernel builds after r331730 (MFC of r320275) when bsd.linker.mk not yet installed. Modified:

svn commit: r331751 - stable/11/sys/conf

Author: emaste Date: Fri Mar 30 01:19:53 2018 New Revision: 331751 URL: https://svnweb.freebsd.org/changeset/base/331751 Log: MFC r329373: Correct module symbol export handling EXPORT_SYMS can be set to YES, NO, a list of symbols to export from a module, or to a filename containing such

svn commit: r331750 - stable/11/share/mk

Author: emaste Date: Fri Mar 30 00:10:39 2018 New Revision: 331750 URL: https://svnweb.freebsd.org/changeset/base/331750 Log: MFC r321417: enable filter lib linker feature flag for lld 5.0+ Also switch the logic to enable this for any non-lld linker, since filter library support is

Re: svn commit: r331098 - in head/sys: net netinet netinet6

30.03.2018, 02:10, "Bjoern A. Zeeb" : > On 17 Mar 2018, at 17:05, Alexander V. Chernikov wrote: > >>  Author: melifaro >>  Date: Sat Mar 17 17:05:48 2018 >>  New Revision: 331098 >>  URL: https://svnweb.freebsd.org/changeset/base/331098 >> >>  Log: >>    Fix

Re: svn commit: r331098 - in head/sys: net netinet netinet6

On 17 Mar 2018, at 17:05, Alexander V. Chernikov wrote: Author: melifaro Date: Sat Mar 17 17:05:48 2018 New Revision: 331098 URL: https://svnweb.freebsd.org/changeset/base/331098 Log: Fix outgoing TCP/UDP packet drop on arp/ndp entry expiration. Current arp/nd code relies on the feedback

svn commit: r331749 - stable/10/sys/compat/svr4

Author: emaste Date: Thu Mar 29 22:31:14 2018 New Revision: 331749 URL: https://svnweb.freebsd.org/changeset/base/331749 Log: MF11 r331330: Fix kernel memory disclosure in svr4_sys_getdents64 svr4_sys_getdents64() copies a dirent structure to userland. When calculating the record length

svn commit: r331747 - in stable/11/sys: conf kern sys

Author: brooks Date: Thu Mar 29 19:53:56 2018 New Revision: 331747 URL: https://svnweb.freebsd.org/changeset/base/331747 Log: MFC r328522: Create deprecation management functions. gone_in(majar, msg); If we're running in FreeBSD major, tell the user this code

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thu, Mar 29, 2018 at 1:39 PM, Ian Lepore wrote: > On Thu, 2018-03-29 at 09:33 -0700, Rodney W. Grimes wrote: > > > > > > On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > > > > > > > > > > > > > > > > > > Author: araujo > > > > > Date: Thu Mar 29 04:51:07 2018 >

svn commit: r331746 - in head/sys: dev/bhnd/bhndb mips/broadcom

Author: landonf Date: Thu Mar 29 19:48:50 2018 New Revision: 331746 URL: https://svnweb.freebsd.org/changeset/base/331746 Log: bhnd(4): Use the new BHND_CAP_BP64 capability flag to exclude DMA translations unsupported by the backplane. Modified: head/sys/dev/bhnd/bhndb/bhndb.c

svn commit: r331745 - head/sys/netinet

Author: np Date: Thu Mar 29 19:48:17 2018 New Revision: 331745 URL: https://svnweb.freebsd.org/changeset/base/331745 Log: Fix RSS build (broken in r331309). Sponsored by: Chelsio Communications Modified: head/sys/netinet/in_pcb.c Modified: head/sys/netinet/in_pcb.c

svn commit: r331744 - in head: share/man/man9 sys/dev/bhnd sys/dev/bhnd/bcma sys/dev/bhnd/bhndb sys/dev/bhnd/siba

Author: landonf Date: Thu Mar 29 19:44:15 2018 New Revision: 331744 URL: https://svnweb.freebsd.org/changeset/base/331744 Log: bhnd(4): include a subset of the ChipCommon capability flags in bhnd_chipid; this provides early access to device capability flags required by bhnd(4) bus and

svn commit: r331743 - head/lib/libdl

Author: kevans Date: Thu Mar 29 19:43:29 2018 New Revision: 331743 URL: https://svnweb.freebsd.org/changeset/base/331743 Log: Add libdl to clibs package libdl is a filter on libc, and pretty lightweight. Add it to the 'clibs' package with libc, effectively tying them together in a

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thu, 2018-03-29 at 09:33 -0700, Rodney W. Grimes wrote: > > > > On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > > > > > > > > > > > > > > Author: araujo > > > > Date: Thu Mar 29 04:51:07 2018 > > > > New Revision: 331728 > > > > URL:

svn commit: r331742 - in stable/11: contrib/mdocml lib lib/libc/gen lib/libdl share/mk

Author: kib Date: Thu Mar 29 19:32:25 2018 New Revision: 331742 URL: https://svnweb.freebsd.org/changeset/base/331742 Log: MFC r320872: Create libdl.so.1 as a filter for libc.so.7 which exports public dl* functions. Added: stable/11/lib/libdl/ - copied from r320872, head/lib/libdl/

svn commit: r331741 - in stable: 10/release/arm 11/release/arm

Author: gjb Date: Thu Mar 29 19:29:12 2018 New Revision: 331741 URL: https://svnweb.freebsd.org/changeset/base/331741 Log: MFC r331562 (manu): release: arm: Copy boot.scr from ports Latest u-boot update need u-boot script to load and start ubldr. (See D14230 for more details)

svn commit: r331741 - in stable: 10/release/arm 11/release/arm

Author: gjb Date: Thu Mar 29 19:29:12 2018 New Revision: 331741 URL: https://svnweb.freebsd.org/changeset/base/331741 Log: MFC r331562 (manu): release: arm: Copy boot.scr from ports Latest u-boot update need u-boot script to load and start ubldr. (See D14230 for more details)

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thu, Mar 29, 2018 at 11:45 AM, John Baldwin wrote: > On Thursday, March 29, 2018 09:33:44 AM Rodney W. Grimes wrote: > > > On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > > That's not a blocker for committing; plenty of time elapsed to allow > > > anyone to

Re: svn commit: r331686 - head

On Thu, Mar 29, 2018 at 11:28 AM, John Baldwin wrote: > On Wednesday, March 28, 2018 09:54:41 PM Dimitry Andric wrote: > > On 28 Mar 2018, at 18:51, John Baldwin wrote: > > > > > > Author: jhb > > > Date: Wed Mar 28 16:51:05 2018 > > > New Revision: 331686 >

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thursday, March 29, 2018 09:33:44 AM Rodney W. Grimes wrote: > > On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > That's not a blocker for committing; plenty of time elapsed to allow > > anyone to reject the change. IMO, even a flat-out rejection isn't a > > blocker to committing

Re: svn commit: r331686 - head

On Wednesday, March 28, 2018 09:54:41 PM Dimitry Andric wrote: > On 28 Mar 2018, at 18:51, John Baldwin wrote: > > > > Author: jhb > > Date: Wed Mar 28 16:51:05 2018 > > New Revision: 331686 > > URL: https://svnweb.freebsd.org/changeset/base/331686 > > > > Log: > > Expand

svn commit: r331740 - head

Author: brooks Date: Thu Mar 29 17:44:55 2018 New Revision: 331740 URL: https://svnweb.freebsd.org/changeset/base/331740 Log: It is March not May. Reported by: jkim Modified: head/UPDATING Modified: head/UPDATING

svn commit: r331739 - head/sys/dev/qlxgbe

Author: davidcs Date: Thu Mar 29 17:36:34 2018 New Revision: 331739 URL: https://svnweb.freebsd.org/changeset/base/331739 Log: 1. Add additional debug prints. 2. Break transmit when IFF_DRV_RUNNING is OFF. 3. set desc_count=0 for default case in switch in ql_rcv_isr() MFC after:5 days

svn commit: r331738 - head/sys/sys

Author: markj Date: Thu Mar 29 17:19:59 2018 New Revision: 331738 URL: https://svnweb.freebsd.org/changeset/base/331738 Log: Have TD_LOCKS_DEC() assert that td_locks is positive. This makes it easier to catch lock accounting bugs, since the problem is otherwise only detected upon a

Re: svn commit: r331728 - in stable/11/etc: . rc.d

> On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > > > > > Author: araujo > > > Date: Thu Mar 29 04:51:07 2018 > > > New Revision: 331728 > > > URL: https://svnweb.freebsd.org/changeset/base/331728 > > > > > > Log: > > > ? MFC r329817: > > I must of missed this when it landed in

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > > > Author: araujo > > Date: Thu Mar 29 04:51:07 2018 > > New Revision: 331728 > > URL: https://svnweb.freebsd.org/changeset/base/331728 > > > > Log: > >   MFC r329817: > I must of missed this when it landed in ^/head > > > > >  

svn commit: r331737 - head/sys/dev/de

Author: brooks Date: Thu Mar 29 15:58:49 2018 New Revision: 331737 URL: https://svnweb.freebsd.org/changeset/base/331737 Log: GC never enabled support for SIOCGADDRROM and SIOCGCHIPID. When de(4) was imported in 1997 the world was not ready for these ioctls. In over 20 years that hasn't

svn commit: r331736 - stable/11/sys/kern

Author: kib Date: Thu Mar 29 15:12:03 2018 New Revision: 331736 URL: https://svnweb.freebsd.org/changeset/base/331736 Log: MFC r331375: Do not send signals to init directly from shutdown_nice(9), do it from the task context. Modified: stable/11/sys/kern/kern_shutdown.c Directory

svn commit: r331735 - stable/11/sys/amd64/amd64

Author: kib Date: Thu Mar 29 15:08:40 2018 New Revision: 331735 URL: https://svnweb.freebsd.org/changeset/base/331735 Log: MFC r331374: Fixes for ptrace(PT_GETXSTATE_INFO) related to the padding in struct ptrace_xstate_info). Modified: stable/11/sys/amd64/amd64/ptrace_machdep.c Directory

svn commit: r331734 - stable/10/sys/dev/jedec_dimm

Author: rpokala Date: Thu Mar 29 15:01:01 2018 New Revision: 331734 URL: https://svnweb.freebsd.org/changeset/base/331734 Log: MFC 331345: jedec_dimm: Use correct string length when populating sc->slotid_str Don't limit the copy to the size of the target string *pointer* (always 4

svn commit: r331733 - stable/11/sys/dev/jedec_dimm

Author: rpokala Date: Thu Mar 29 15:00:48 2018 New Revision: 331733 URL: https://svnweb.freebsd.org/changeset/base/331733 Log: MFC 331345: jedec_dimm: Use correct string length when populating sc->slotid_str Don't limit the copy to the size of the target string *pointer* (always 4

svn commit: r331732 - head/sys/vm

Author: markj Date: Thu Mar 29 14:27:40 2018 New Revision: 331732 URL: https://svnweb.freebsd.org/changeset/base/331732 Log: Fix the background laundering mechanism after r329882. Rather than using the number of inactive queue scans as a metric for how many clean pages are being freed by

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thu, Mar 29, 2018, 9:20 PM Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: araujo > > Date: Thu Mar 29 04:51:07 2018 > > New Revision: 331728 > > URL: https://svnweb.freebsd.org/changeset/base/331728 > > > > Log: > > MFC r329817: > > I must of missed this when it landed

svn commit: r331731 - head/contrib/llvm/tools/lld/ELF

Author: dim Date: Thu Mar 29 13:55:23 2018 New Revision: 331731 URL: https://svnweb.freebsd.org/changeset/base/331731 Log: Pull in r328738 from upstream lld trunk (by Rafael Espindola): Strip @VER suffices from the LTO output. This fixes pr36623. The problem is that we have

Re: svn commit: r331728 - in stable/11/etc: . rc.d

> Author: araujo > Date: Thu Mar 29 04:51:07 2018 > New Revision: 331728 > URL: https://svnweb.freebsd.org/changeset/base/331728 > > Log: > MFC r329817: I must of missed this when it landed in ^/head > The firewall_type is ignored if not set in rc.conf or rc.conf.local, > after r190575

svn commit: r331730 - in stable/11: . share/mk sys/conf

Author: emaste Date: Thu Mar 29 12:52:58 2018 New Revision: 331730 URL: https://svnweb.freebsd.org/changeset/base/331730 Log: MFC kernel build-id support MFC r320244, r320245, r320246, r320247, r320248, r320249, r320250 (bdrewery): Add basic bsd.linker.mk auto included from