Re: svn commit: r334104 - in head/sys: netinet sys

[Gleb Smirnoff]

On Thu, May 24, 2018 at 06:44:20AM +0200, Mateusz Guzik wrote:
M> I fundamentally disagree with this part.
M> 
M> If a known value of a given field is needed for assertion purposes, you
M> can add (possibly conditional) code setting this specific value. It
M> probably should not be zero if it can be helped.
M> 
M> Conditional zeroing of the *whole* struct depending on invariants will
M> *hide* uninitialized memory read bugs - production kernel will have
M> whatever it happens to find, while *debug* kernel will guarantee to
M> have all the values zeroed. In fact the flag actively combats redzoning.
M> if the resulting allocation is zeroed, poisoning is actively neutered.
M> But only if debug is enabled.
M> 
M> That said, I find the change harmful.

+1 on fundamentally disagree with M_ZERO_INVARIANTS. It makes the
INVARIANTS-enabled kernels to crash _later_ than production kernels,
since instead of uma_junk it places clean zeroes.

May be changes like that deserve more than a 30 minute time frame for review?

-- 
Gleb Smirnoff
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333860 - head/sys/kern

[Gleb Smirnoff]

Let me repeat again. The warning is a false positive, and thus assignment
isn't useful. I'm not worried about a single instruction, more about
polluting the code.

If the warning was escalated to build error, and we did carry about
building with gcc8, in this case the assignment should be added with
a comment /* pacify gcc */.

On Wed, May 23, 2018 at 03:59:33PM -0700, Matthew Macy wrote:
M> On Wed, May 23, 2018 at 3:57 PM, Gleb Smirnoff  wrote:
M> > The initialization isn't useful.
M> 
M> It silences a gcc warning. So yes it is. It's this exchange which is not 
useful.
M> 
M> -M
M> 
M> 
M> > On Wed, May 23, 2018 at 03:52:42PM -0700, Matthew Macy wrote:
M> > M> Talk to the gcc devs. The warning is useful even if there are false 
positives.
M> > M>
M> > M> On Wed, May 23, 2018 at 3:27 PM, Gleb Smirnoff  
wrote:
M> > M> >   Hi,
M> > M> >
M> > M> > On Sat, May 19, 2018 at 05:10:52AM +, Matt Macy wrote:
M> > M> > M> Author: mmacy
M> > M> > M> Date: Sat May 19 05:10:51 2018
M> > M> > M> New Revision: 333860
M> > M> > M> URL: https://svnweb.freebsd.org/changeset/base/333860
M> > M> > M>
M> > M> > M> Log:
M> > M> > M>   sendfile: annotate unused value and ensure that npages is 
actually initialized
M> > M> > M>
M> > M> > M> Modified:
M> > M> > M>   head/sys/kern/kern_sendfile.c
M> > M> > M>
M> > M> > M> Modified: head/sys/kern/kern_sendfile.c
M> > M> > M> 
==
M> > M> > M> --- head/sys/kern/kern_sendfile.cSat May 19 05:09:10 2018  
  (r333859)
M> > M> > M> +++ head/sys/kern/kern_sendfile.cSat May 19 05:10:51 2018  
  (r333860)
M> > M> > M> @@ -341,7 +341,7 @@ sendfile_swapin(vm_object_t obj, struct sf_io 
*sfio, o
M> > M> > M>  }
M> > M> > M>
M> > M> > M>  for (int i = 0; i < npages;) {
M> > M> > M> -int j, a, count, rv;
M> > M> > M> +int j, a, count, rv __unused;
M> > M> > M>
M> > M> > M>  /* Skip valid pages. */
M> > M> > M>  if (vm_page_is_valid(pa[i], vmoff(i, off) & PAGE_MASK,
M> > M> > M> @@ -688,6 +688,7 @@ retry_space:
M> > M> > M>  if (space == 0) {
M> > M> > M>  sfio = NULL;
M> > M> > M>  nios = 0;
M> > M> > M> +npages = 0;
M> > M> > M>  goto prepend_header;
M> > M> > M>  }
M> > M> > M>  hdr_uio = NULL;
M> > M> >
M> > M> > This initialization is redundant and a compiler warning if exists is 
wrong.
M> > M> >
M> > M> > If we jump down to prepend_header with nios == 0, we won't ever use 
npages.
M> > M> >
M> > M> > --
M> > M> > Gleb Smirnoff
M> >
M> > --
M> > Gleb Smirnoff

-- 
Gleb Smirnoff
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcstat...

[Matt Macy]

Author: mmacy
Date: Thu May 24 04:30:06 2018
New Revision: 334128
URL: https://svnweb.freebsd.org/changeset/base/334128

Log:
  libpmcstat: compile in events based on json description

Added:
  head/lib/libpmcstat/libpmcstat_pmu_util.c   (contents, props changed)
  head/lib/libpmcstat/pmu-events/
  head/lib/libpmcstat/pmu-events/Makefile   (contents, props changed)
  head/lib/libpmcstat/pmu-events/README   (contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/
  head/lib/libpmcstat/pmu-events/arch/arm64/
  head/lib/libpmcstat/pmu-events/arch/arm64/arm/
  head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/
  head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/branch.json   
(contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/bus.json   
(contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/cache.json   
(contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/memory.json   
(contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/other.json   
(contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/pipeline.json   
(contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/arm64/armv8-recommended.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/arm64/cavium/
  head/lib/libpmcstat/pmu-events/arch/arm64/cavium/thunderx2/
  head/lib/libpmcstat/pmu-events/arch/arm64/cavium/thunderx2/core-imp-def.json  
 (contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/arm64/hisilicon/
  head/lib/libpmcstat/pmu-events/arch/arm64/hisilicon/hip08/
  head/lib/libpmcstat/pmu-events/arch/arm64/hisilicon/hip08/core-imp-def.json   
(contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/arm64/mapfile.csv   (contents, props 
changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/
  head/lib/libpmcstat/pmu-events/arch/powerpc/mapfile.csv   (contents, props 
changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power8/
  head/lib/libpmcstat/pmu-events/arch/powerpc/power8/cache.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power8/floating-point.json   
(contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power8/frontend.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power8/marked.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power8/memory.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power8/other.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power8/pipeline.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power8/pmc.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power8/translation.json   
(contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power9/
  head/lib/libpmcstat/pmu-events/arch/powerpc/power9/cache.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power9/floating-point.json   
(contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power9/frontend.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power9/marked.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power9/memory.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power9/other.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power9/pipeline.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power9/pmc.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/powerpc/power9/translation.json   
(contents, props changed)
  head/lib/libpmcstat/pmu-events/arch/s390/
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z10/
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z10/basic.json   (contents, props 
changed)
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z10/crypto.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z10/extended.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z13/
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z13/basic.json   (contents, props 
changed)
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z13/crypto.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z13/extended.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z14/
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z14/basic.json   (contents, props 
changed)
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z14/crypto.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z14/extended.json   (contents, 
props changed)
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z196/
  head/lib/libpmcstat/pmu-events/arch/s390/cf_z196/basic.json   (contents, 
props changed)
  

svn commit: r334129 - head/sys/amd64/conf

[Matt Macy]

Author: mmacy
Date: Thu May 24 04:31:53 2018
New Revision: 334129
URL: https://svnweb.freebsd.org/changeset/base/334129

Log:
  take NUMA out

Modified:
  head/sys/amd64/conf/GENERIC-NODEBUG

Modified: head/sys/amd64/conf/GENERIC-NODEBUG
==
--- head/sys/amd64/conf/GENERIC-NODEBUG Thu May 24 04:30:06 2018
(r334128)
+++ head/sys/amd64/conf/GENERIC-NODEBUG Thu May 24 04:31:53 2018
(r334129)
@@ -38,4 +38,3 @@ nooptions   BUF_TRACKING
 nooptions   DEADLKRES
 nooptions   FULL_BUF_TRACKING
 
-optionsNUMA
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

UPDATE

[HELP DESK]

Esto es para informarle que el sistema de actualizaci�n / mantenimiento de 
nuestros sistemas se realizar� entre las 10 p.m.-11 p.m. el d�a de hoy. Como 
resultado, se le pedir� que verifique su correo electr�nico mediante HAGA CLIC 
AQU� para que podamos actualizar tu Zimbra. Una vez m�s, lamentamos cualquier 
inconveniente que esto pueda causarle___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334120 - head/share/mk

[Conrad Meyer]

On Wed, May 23, 2018 at 6:28 PM, Eitan Adler  wrote:
> On 23 May 2018 at 14:26, Ed Maste  wrote:
>> Author: emaste
>> Date: Wed May 23 21:26:33 2018
>> New Revision: 334120
>> URL: https://svnweb.freebsd.org/changeset/base/334120
>>
>> Log:
>>   Revert r334081 (-Wmain) as it broke the build on gcc architectures
>
> I tested this with "make universe". Can you give me an example build
> log that failed?

In a just-previous revision (r334078), you mentioned testing with
"make universe TARGETS='amd64 arm arm64 i386 sparc64'" and not "make
universe" proper.  The former is a subset and does not include MIPS,
as Ed's tinderbox link shows.

Conrad
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: Deorbiting i386

[Pedro Giffuni]

FWIW;

On 23/05/2018 17:18, Cy Schubert wrote:

In message <20180523202228.gc58...@spindle.one-eyed-alien.net>, Brooks
Davis wr
ites:


--QRj9sO5tAVLaXnSD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 24, 2018 at 02:53:16AM +0700, Eugene Grosbein wrote:

24.05.2018 2:30, Cy Schubert wrote:
=20

Except for old computers and old software that segfaults on 64-bit, how=

  many people still use i386?

=20
Full disclosure: I'd like to see i386 deorbited before I retire.

=20
Plese don't. I routinely use FreeBSD11/i386 for cheap VPS hosts having le=

ss than 2G memory

because amd64 has noticeable overhead. I even have ZFS-only i386 VPS, her=

e is live example with 1G only:

=20
Mem: 10M Active, 69M Inact, 230M Wired, 685M Free
ARC: 75M Total, 1953K MFU, 31M MRU, 172K Anon, 592K Header, 42M Other
  3500K Compressed, 29M Uncompressed, 8.61:1 Ratio
Swap: 1024M Total, 1024M Free
=20
The VPS has only 20G of disk space and ZFS compression gives
compressratio 2.22x for ports, 2.51x for src, 2.29x for obj
and 1.95x for installed i386 system plus other software and data.

I think we're quite a ways from being ready to axe i386.

For VPS applications, we should probably get x32 support in place which
should give us the best of both worlds.

That said, we either need to rev the i386 ABI to use a 64-bit time_t or
kill it in the not to distant future or we risk embedded systems failing
in place in 2038.  If we assume a 15 year life for most equipment to
fail electrically or mechanically that says FreeBSD 13 shouldn't support
the current i386 ABI.

Rereading this, I'm confused. FreeBSD 13? 2023? Either works for me,
though 2023 is more reasonable and gives people more than enough time
to migrate.


IMHO, we shouldn't at all plan to deorbit i386: it is a platform that is 
very easy to test on Jenkins/bhyve. If we want to keep FreeBSD 
multiplatform it is way easier to test and find bugs on i386 than on 
other 32 bit platforms. It is fully functional and much more than 
historic value.


X32 sadly didn't catch on linux on AFAICT, although I wouldn't object to 
it appearing on FreeBSD.


Pedro.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334120 - head/share/mk

[Ed Maste]

On 23 May 2018 at 21:28, Eitan Adler  wrote:
> On 23 May 2018 at 14:26, Ed Maste  wrote:
>> Author: emaste
>> Date: Wed May 23 21:26:33 2018
>> New Revision: 334120
>> URL: https://svnweb.freebsd.org/changeset/base/334120
>>
>> Log:
>>   Revert r334081 (-Wmain) as it broke the build on gcc architectures
>
> I tested this with "make universe". Can you give me an example build
> log that failed?

I saw it via https://ci.freebsd.org/tinderbox - an example log is here:
https://ci.freebsd.org/job/FreeBSD-head-mips-build/2330/console

cc1plus: warning: command line option "-Wmain" is valid for C/ObjC but
not for C++

> Would CFLAGS.clang += -Wmain be okay?

I suspect so.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334120 - head/share/mk

[Eitan Adler]

On 23 May 2018 at 14:26, Ed Maste  wrote:
> Author: emaste
> Date: Wed May 23 21:26:33 2018
> New Revision: 334120
> URL: https://svnweb.freebsd.org/changeset/base/334120
>
> Log:
>   Revert r334081 (-Wmain) as it broke the build on gcc architectures

I tested this with "make universe". Can you give me an example build
log that failed?

Would CFLAGS.clang += -Wmain be okay?

-- 
Eitan Adler
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334104 - in head/sys: netinet sys

[Eitan Adler]

On 23 May 2018 at 17:40, Jonathan T. Looney  wrote:
> On Wed, May 23, 2018 at 7:13 PM, Matthew Macy  wrote:
>>
>> On Wed, May 23, 2018 at 11:52 AM, John Baldwin  wrote:
>> > On Wednesday, May 23, 2018 05:00:05 PM Matt Macy wrote:
>> >> Author: mmacy
>> >> Date: Wed May 23 17:00:05 2018
>> >> New Revision: 334104
>> >> URL: https://svnweb.freebsd.org/changeset/base/334104
>> >>
>> >> Log:
>> >>   epoch: allow for conditionally asserting that the epoch context
>> >> fields
>> >>   are unused by zeroing on INVARIANTS builds
>> >
>> > Is M_ZERO really so bad that you need to make it conditional?
>>
>> In this case not at all. It's only exercised by sysctl handlers. I'm
>> mostly responding to an inquiry by jtl. However, gratuitous M_ZERO
>> usage does have a cumulative adverse performance impact.
>
> I appreciate you making this change. And, I do think it is worth avoiding
> M_ZERO where it is unnecessary, for the reason you state.
>
>> > I would probably have preferred something like 'M_ZERO_INVARIANTS'
>> > instead perhaps (or M_ZERO_EPOCH) that only controls M_ZERO and is
>> > still or'd with M_WAITOK or M_NOWAIT.
>>
>> Yes. I like that better too. Thanks.
>
> Yes, that does seem better.

+1 to M_ZERO_INVARIANTS


-- 
Eitan Adler
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: Deorbiting i386 (was: Re: svn commit: r333388 - in head: . share/man/man4 sys/confsys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/toolstools/tools/nxge usr.sbin/bsdconfig/sh

[Brooks Davis]

On Wed, May 23, 2018 at 03:18:59PM -0700, Cy Schubert wrote:
> In message <20180523202228.gc58...@spindle.one-eyed-alien.net>, Brooks 
> Davis wr
> ites:
> > 
> >
> > --QRj9sO5tAVLaXnSD
> > Content-Type: text/plain; charset=us-ascii
> > Content-Disposition: inline
> > Content-Transfer-Encoding: quoted-printable
> >
> > On Thu, May 24, 2018 at 02:53:16AM +0700, Eugene Grosbein wrote:
> > > 24.05.2018 2:30, Cy Schubert wrote:
> > >=20
> > > > Except for old computers and old software that segfaults on 64-bit, how=
> >  many people still use i386?
> > > >=20
> > > > Full disclosure: I'd like to see i386 deorbited before I retire.
> > >=20
> > > Plese don't. I routinely use FreeBSD11/i386 for cheap VPS hosts having le=
> > ss than 2G memory
> > > because amd64 has noticeable overhead. I even have ZFS-only i386 VPS, her=
> > e is live example with 1G only:
> > >=20
> > > Mem: 10M Active, 69M Inact, 230M Wired, 685M Free
> > > ARC: 75M Total, 1953K MFU, 31M MRU, 172K Anon, 592K Header, 42M Other
> > >  3500K Compressed, 29M Uncompressed, 8.61:1 Ratio
> > > Swap: 1024M Total, 1024M Free
> > >=20
> > > The VPS has only 20G of disk space and ZFS compression gives
> > > compressratio 2.22x for ports, 2.51x for src, 2.29x for obj
> > > and 1.95x for installed i386 system plus other software and data.
> >
> > I think we're quite a ways from being ready to axe i386.
> >
> > For VPS applications, we should probably get x32 support in place which
> > should give us the best of both worlds.
> >
> > That said, we either need to rev the i386 ABI to use a 64-bit time_t or
> > kill it in the not to distant future or we risk embedded systems failing
> > in place in 2038.  If we assume a 15 year life for most equipment to
> > fail electrically or mechanically that says FreeBSD 13 shouldn't support
> > the current i386 ABI.
> 
> Rereading this, I'm confused. FreeBSD 13? 2023? Either works for me, 
> though 2023 is more reasonable and gives people more than enough time 
> to migrate.

My guess is that FreeBSD 12 will be supported through 2023, maybe a
little longer.  I'd rather not provide *any* support to the current past
2023 which would imply we shouldn't support it in 13 which will extend
beyond that.  One could come up with a different and also reasonable
timeline and that should probably be a job for core++.  It's worth
noting that we could just decide we're breaking the ABI early in the 13
cycle and not kill i386.

-- Brooks


signature.asc
Description: PGP signature

svn commit: r334126 - head/sbin/devd

[Matt Macy]

Author: mmacy
Date: Thu May 24 01:12:06 2018
New Revision: 334126
URL: https://svnweb.freebsd.org/changeset/base/334126

Log:
  devd: drop WARNS back down to 3 until 6 actually works with GCC

Modified:
  head/sbin/devd/Makefile

Modified: head/sbin/devd/Makefile
==
--- head/sbin/devd/Makefile Thu May 24 01:04:56 2018(r334125)
+++ head/sbin/devd/Makefile Thu May 24 01:12:06 2018(r334126)
@@ -2,6 +2,7 @@
 
 .include 
 
+WARNS?= 3
 PACKAGE=runtime
 PROG_CXX=devd
 SRCS=  devd.cc token.l parse.y y.tab.h
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334125 - in head/sys: netinet sys

[Matt Macy]

Author: mmacy
Date: Thu May 24 01:04:56 2018
New Revision: 334125
URL: https://svnweb.freebsd.org/changeset/base/334125

Log:
  convert allocations to INVARIANTS M_ZERO

Modified:
  head/sys/netinet/ip_divert.c
  head/sys/netinet/raw_ip.c
  head/sys/netinet/tcp_subr.c
  head/sys/netinet/udp_usrreq.c
  head/sys/sys/epoch.h

Modified: head/sys/netinet/ip_divert.c
==
--- head/sys/netinet/ip_divert.cThu May 24 01:03:31 2018
(r334124)
+++ head/sys/netinet/ip_divert.cThu May 24 01:04:56 2018
(r334125)
@@ -672,7 +672,7 @@ div_pcblist(SYSCTL_HANDLER_ARGS)
if (error)
return error;
 
-   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_EPOCH_CALL_WAITOK);
+   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_WAITOK|M_ZERO_INVARIANTS);
inp_list = il->il_inp_list;

INP_INFO_RLOCK(_divcbinfo);

Modified: head/sys/netinet/raw_ip.c
==
--- head/sys/netinet/raw_ip.c   Thu May 24 01:03:31 2018(r334124)
+++ head/sys/netinet/raw_ip.c   Thu May 24 01:04:56 2018(r334125)
@@ -1056,7 +1056,7 @@ rip_pcblist(SYSCTL_HANDLER_ARGS)
if (error)
return (error);
 
-   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_EPOCH_CALL_WAITOK);
+   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_WAITOK|M_ZERO_INVARIANTS);
inp_list = il->il_inp_list;
 
INP_INFO_RLOCK(_ripcbinfo);

Modified: head/sys/netinet/tcp_subr.c
==
--- head/sys/netinet/tcp_subr.c Thu May 24 01:03:31 2018(r334124)
+++ head/sys/netinet/tcp_subr.c Thu May 24 01:04:56 2018(r334125)
@@ -2151,7 +2151,7 @@ tcp_pcblist(SYSCTL_HANDLER_ARGS)
if (error)
return (error);
 
-   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_EPOCH_CALL_WAITOK);
+   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_WAITOK|M_ZERO_INVARIANTS);
inp_list = il->il_inp_list;
 
INP_INFO_WLOCK(_tcbinfo);

Modified: head/sys/netinet/udp_usrreq.c
==
--- head/sys/netinet/udp_usrreq.c   Thu May 24 01:03:31 2018
(r334124)
+++ head/sys/netinet/udp_usrreq.c   Thu May 24 01:04:56 2018
(r334125)
@@ -874,7 +874,7 @@ udp_pcblist(SYSCTL_HANDLER_ARGS)
error = SYSCTL_OUT(req, , sizeof xig);
if (error)
return (error);
-   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_EPOCH_CALL_WAITOK);
+   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_WAITOK|M_ZERO_INVARIANTS);
inp_list = il->il_inp_list;
 
INP_INFO_RLOCK(_udbinfo);

Modified: head/sys/sys/epoch.h
==
--- head/sys/sys/epoch.hThu May 24 01:03:31 2018(r334124)
+++ head/sys/sys/epoch.hThu May 24 01:04:56 2018(r334125)
@@ -64,14 +64,6 @@ int in_epoch(void);
 DPCPU_DECLARE(int, epoch_cb_count);
 DPCPU_DECLARE(struct grouptask, epoch_cb_task);
 
-#ifdef INVARIANTS
-#define M_EPOCH_CALL_NOWAIT(M_NOWAIT|M_ZERO)
-#define M_EPOCH_CALL_WAITOK(M_WAITOK|M_ZERO)
-#else
-#define M_EPOCH_CALL_NOWAITM_NOWAIT
-#define M_EPOCH_CALL_WAITOKM_WAITOK
-#endif
-
 static __inline void
 epoch_enter_preempt(epoch_t epoch)
 {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334124 - head/sys/sys

[Matt Macy]

Author: mmacy
Date: Thu May 24 01:03:31 2018
New Revision: 334124
URL: https://svnweb.freebsd.org/changeset/base/334124

Log:
  malloc: Add flag for conditionally zeroing for INVARIANTS builds

Modified:
  head/sys/sys/malloc.h

Modified: head/sys/sys/malloc.h
==
--- head/sys/sys/malloc.h   Thu May 24 00:06:55 2018(r334123)
+++ head/sys/sys/malloc.h   Thu May 24 01:03:31 2018(r334124)
@@ -59,6 +59,13 @@
 
 #defineM_MAGIC 877983977   /* time when first defined :-) 
*/
 
+#ifdef INVARIANTS
+#defineM_ZERO_INVARIANTS   M_ZERO
+#else
+#defineM_ZERO_INVARIANTS   0
+#endif
+
+
 /*
  * Two malloc type structures are present: malloc_type, which is used by a
  * type owner to declare the type, and malloc_type_internal, which holds
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334104 - in head/sys: netinet sys

[Jonathan T. Looney]

On Wed, May 23, 2018 at 7:13 PM, Matthew Macy  wrote:
>
> On Wed, May 23, 2018 at 11:52 AM, John Baldwin  wrote:
> > On Wednesday, May 23, 2018 05:00:05 PM Matt Macy wrote:
> >> Author: mmacy
> >> Date: Wed May 23 17:00:05 2018
> >> New Revision: 334104
> >> URL: https://svnweb.freebsd.org/changeset/base/334104
> >>
> >> Log:
> >>   epoch: allow for conditionally asserting that the epoch context
fields
> >>   are unused by zeroing on INVARIANTS builds
> >
> > Is M_ZERO really so bad that you need to make it conditional?
>
> In this case not at all. It's only exercised by sysctl handlers. I'm
> mostly responding to an inquiry by jtl. However, gratuitous M_ZERO
> usage does have a cumulative adverse performance impact.

I appreciate you making this change. And, I do think it is worth avoiding
M_ZERO where it is unnecessary, for the reason you state.

> > I would probably have preferred something like 'M_ZERO_INVARIANTS'
> > instead perhaps (or M_ZERO_EPOCH) that only controls M_ZERO and is
> > still or'd with M_WAITOK or M_NOWAIT.
>
> Yes. I like that better too. Thanks.

Yes, that does seem better.

Thanks!

Jonathan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334123 - head/sys/netgraph

[John Baldwin]

Author: jhb
Date: Thu May 24 00:06:55 2018
New Revision: 334123
URL: https://svnweb.freebsd.org/changeset/base/334123

Log:
  Catch up two more places to the V_ifnet change to a CK_STAILQ.

Modified:
  head/sys/netgraph/ng_ether.c
  head/sys/netgraph/ng_gif.c

Modified: head/sys/netgraph/ng_ether.c
==
--- head/sys/netgraph/ng_ether.cWed May 23 21:39:29 2018
(r334122)
+++ head/sys/netgraph/ng_ether.cThu May 24 00:06:55 2018
(r334123)
@@ -868,7 +868,7 @@ vnet_ng_ether_init(const void *unused)
 
/* Create nodes for any already-existing Ethernet interfaces. */
IFNET_RLOCK();
-   TAILQ_FOREACH(ifp, _ifnet, if_link) {
+   CK_STAILQ_FOREACH(ifp, _ifnet, if_link) {
if (ifp->if_type == IFT_ETHER
|| ifp->if_type == IFT_L2VLAN)
ng_ether_attach(ifp);

Modified: head/sys/netgraph/ng_gif.c
==
--- head/sys/netgraph/ng_gif.c  Wed May 23 21:39:29 2018(r334122)
+++ head/sys/netgraph/ng_gif.c  Thu May 24 00:06:55 2018(r334123)
@@ -558,7 +558,7 @@ ng_gif_mod_event(module_t mod, int event, void *data)
IFNET_RLOCK();
VNET_FOREACH(vnet_iter) {
CURVNET_SET_QUIET(vnet_iter); /* XXX revisit quiet */
-   TAILQ_FOREACH(ifp, _ifnet, if_link) {
+   CK_STAILQ_FOREACH(ifp, _ifnet, if_link) {
if (ifp->if_type == IFT_GIF)
ng_gif_attach(ifp);
}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334104 - in head/sys: netinet sys

[Matthew Macy]

On Wed, May 23, 2018 at 11:52 AM, John Baldwin  wrote:
> On Wednesday, May 23, 2018 05:00:05 PM Matt Macy wrote:
>> Author: mmacy
>> Date: Wed May 23 17:00:05 2018
>> New Revision: 334104
>> URL: https://svnweb.freebsd.org/changeset/base/334104
>>
>> Log:
>>   epoch: allow for conditionally asserting that the epoch context fields
>>   are unused by zeroing on INVARIANTS builds
>
> Is M_ZERO really so bad that you need to make it conditional?

In this case not at all. It's only exercised by sysctl handlers. I'm
mostly responding to an inquiry by jtl. However, gratuitous M_ZERO
usage does have a cumulative adverse performance impact.

> I would probably have preferred something like 'M_ZERO_INVARIANTS'
> instead perhaps (or M_ZERO_EPOCH) that only controls M_ZERO and is
> still or'd with M_WAITOK or M_NOWAIT.

Yes. I like that better too. Thanks.

-M
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334104 - in head/sys: netinet sys

[John Baldwin]

On Wednesday, May 23, 2018 05:00:05 PM Matt Macy wrote:
> Author: mmacy
> Date: Wed May 23 17:00:05 2018
> New Revision: 334104
> URL: https://svnweb.freebsd.org/changeset/base/334104
> 
> Log:
>   epoch: allow for conditionally asserting that the epoch context fields
>   are unused by zeroing on INVARIANTS builds

Is M_ZERO really so bad that you need to make it conditional?

I would probably have preferred something like 'M_ZERO_INVARIANTS'
instead perhaps (or M_ZERO_EPOCH) that only controls M_ZERO and is
still or'd with M_WAITOK or M_NOWAIT.

-- 
John Baldwin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334073 - head

[John Baldwin]

On Wednesday, May 23, 2018 12:09:59 PM Eitan Adler wrote:
> On 23 May 2018 at 09:27, John Baldwin  wrote:
> > On Wednesday, May 23, 2018 04:09:01 AM Eitan Adler wrote:
> >> Author: eadler
> >> Date: Wed May 23 04:09:01 2018
> >> New Revision: 334073
> >> URL: https://svnweb.freebsd.org/changeset/base/334073
> >>
> >> Log:
> >>   README: Reduce the textdump; describe the project
> >>
> >>   Rework the README to make it a little easier for new users. This is the
> >>   first file many will see when persuing the FreeBSD source code so
> >>
> >>   - remove some of the text describes how to build. This is better covered
> >>   in the linked documentation.
> >>   - add a small blurb for what FreeBSD is. Some users might find this
> >>   document through features such as github search so they may not even
> >>   know what the project is
> >>
> >>   generally, gear this file for the new, accidental, or casual user rather
> >>   than towards someone seeking fuller documentation.
> >>
> >> Modified:
> >>   head/README
> >>   head/README.md
> >>
> >> Modified: head/README
> >> ==
> >> --- head/README   Wed May 23 03:41:22 2018(r334072)
> >> +++ head/README   Wed May 23 04:09:01 2018(r334073)
> >> @@ -2,35 +2,25 @@ This is the top level of the FreeBSD source directory.
> >> -
> >> -The kernel configuration files reside in the sys//conf
> >> -sub-directory.  GENERIC is the default configuration used in release 
> >> builds.
> >> -NOTES contains entries and documentation for all possible
> >> -devices, not just those commonly used.
> >
> > I do think this paragraph is still useful as part of the Source Roadmap and
> > not really part of the build instructions.
> 
> I added a reference to sys//conf to the bottom of the
> README.Adding something about NOTES might be helpful, but IMHO closer
> to the build.

Yes, but the directory doesn't tell you which file is the default kernel.
I'm thinking in terms of a random person browsing the tree via github's web
interface who doesn't know which files are which in which case I think this
note was kind of useful.

-- 
John Baldwin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333860 - head/sys/kern

[Matthew Macy]

On Wed, May 23, 2018 at 3:57 PM, Gleb Smirnoff  wrote:
> The initialization isn't useful.

It silences a gcc warning. So yes it is. It's this exchange which is not useful.

-M


> On Wed, May 23, 2018 at 03:52:42PM -0700, Matthew Macy wrote:
> M> Talk to the gcc devs. The warning is useful even if there are false 
> positives.
> M>
> M> On Wed, May 23, 2018 at 3:27 PM, Gleb Smirnoff  wrote:
> M> >   Hi,
> M> >
> M> > On Sat, May 19, 2018 at 05:10:52AM +, Matt Macy wrote:
> M> > M> Author: mmacy
> M> > M> Date: Sat May 19 05:10:51 2018
> M> > M> New Revision: 333860
> M> > M> URL: https://svnweb.freebsd.org/changeset/base/333860
> M> > M>
> M> > M> Log:
> M> > M>   sendfile: annotate unused value and ensure that npages is actually 
> initialized
> M> > M>
> M> > M> Modified:
> M> > M>   head/sys/kern/kern_sendfile.c
> M> > M>
> M> > M> Modified: head/sys/kern/kern_sendfile.c
> M> > M> 
> ==
> M> > M> --- head/sys/kern/kern_sendfile.cSat May 19 05:09:10 2018
> (r333859)
> M> > M> +++ head/sys/kern/kern_sendfile.cSat May 19 05:10:51 2018
> (r333860)
> M> > M> @@ -341,7 +341,7 @@ sendfile_swapin(vm_object_t obj, struct sf_io 
> *sfio, o
> M> > M>  }
> M> > M>
> M> > M>  for (int i = 0; i < npages;) {
> M> > M> -int j, a, count, rv;
> M> > M> +int j, a, count, rv __unused;
> M> > M>
> M> > M>  /* Skip valid pages. */
> M> > M>  if (vm_page_is_valid(pa[i], vmoff(i, off) & PAGE_MASK,
> M> > M> @@ -688,6 +688,7 @@ retry_space:
> M> > M>  if (space == 0) {
> M> > M>  sfio = NULL;
> M> > M>  nios = 0;
> M> > M> +npages = 0;
> M> > M>  goto prepend_header;
> M> > M>  }
> M> > M>  hdr_uio = NULL;
> M> >
> M> > This initialization is redundant and a compiler warning if exists is 
> wrong.
> M> >
> M> > If we jump down to prepend_header with nios == 0, we won't ever use 
> npages.
> M> >
> M> > --
> M> > Gleb Smirnoff
>
> --
> Gleb Smirnoff
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333860 - head/sys/kern

[Gleb Smirnoff]

The initialization isn't useful.

On Wed, May 23, 2018 at 03:52:42PM -0700, Matthew Macy wrote:
M> Talk to the gcc devs. The warning is useful even if there are false 
positives.
M> 
M> On Wed, May 23, 2018 at 3:27 PM, Gleb Smirnoff  wrote:
M> >   Hi,
M> >
M> > On Sat, May 19, 2018 at 05:10:52AM +, Matt Macy wrote:
M> > M> Author: mmacy
M> > M> Date: Sat May 19 05:10:51 2018
M> > M> New Revision: 333860
M> > M> URL: https://svnweb.freebsd.org/changeset/base/333860
M> > M>
M> > M> Log:
M> > M>   sendfile: annotate unused value and ensure that npages is actually 
initialized
M> > M>
M> > M> Modified:
M> > M>   head/sys/kern/kern_sendfile.c
M> > M>
M> > M> Modified: head/sys/kern/kern_sendfile.c
M> > M> 
==
M> > M> --- head/sys/kern/kern_sendfile.cSat May 19 05:09:10 2018
(r333859)
M> > M> +++ head/sys/kern/kern_sendfile.cSat May 19 05:10:51 2018
(r333860)
M> > M> @@ -341,7 +341,7 @@ sendfile_swapin(vm_object_t obj, struct sf_io 
*sfio, o
M> > M>  }
M> > M>
M> > M>  for (int i = 0; i < npages;) {
M> > M> -int j, a, count, rv;
M> > M> +int j, a, count, rv __unused;
M> > M>
M> > M>  /* Skip valid pages. */
M> > M>  if (vm_page_is_valid(pa[i], vmoff(i, off) & PAGE_MASK,
M> > M> @@ -688,6 +688,7 @@ retry_space:
M> > M>  if (space == 0) {
M> > M>  sfio = NULL;
M> > M>  nios = 0;
M> > M> +npages = 0;
M> > M>  goto prepend_header;
M> > M>  }
M> > M>  hdr_uio = NULL;
M> >
M> > This initialization is redundant and a compiler warning if exists is wrong.
M> >
M> > If we jump down to prepend_header with nios == 0, we won't ever use npages.
M> >
M> > --
M> > Gleb Smirnoff

-- 
Gleb Smirnoff
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333860 - head/sys/kern

[Matthew Macy]

Talk to the gcc devs. The warning is useful even if there are false positives.

On Wed, May 23, 2018 at 3:27 PM, Gleb Smirnoff  wrote:
>   Hi,
>
> On Sat, May 19, 2018 at 05:10:52AM +, Matt Macy wrote:
> M> Author: mmacy
> M> Date: Sat May 19 05:10:51 2018
> M> New Revision: 333860
> M> URL: https://svnweb.freebsd.org/changeset/base/333860
> M>
> M> Log:
> M>   sendfile: annotate unused value and ensure that npages is actually 
> initialized
> M>
> M> Modified:
> M>   head/sys/kern/kern_sendfile.c
> M>
> M> Modified: head/sys/kern/kern_sendfile.c
> M> 
> ==
> M> --- head/sys/kern/kern_sendfile.cSat May 19 05:09:10 2018
> (r333859)
> M> +++ head/sys/kern/kern_sendfile.cSat May 19 05:10:51 2018
> (r333860)
> M> @@ -341,7 +341,7 @@ sendfile_swapin(vm_object_t obj, struct sf_io *sfio, o
> M>  }
> M>
> M>  for (int i = 0; i < npages;) {
> M> -int j, a, count, rv;
> M> +int j, a, count, rv __unused;
> M>
> M>  /* Skip valid pages. */
> M>  if (vm_page_is_valid(pa[i], vmoff(i, off) & PAGE_MASK,
> M> @@ -688,6 +688,7 @@ retry_space:
> M>  if (space == 0) {
> M>  sfio = NULL;
> M>  nios = 0;
> M> +npages = 0;
> M>  goto prepend_header;
> M>  }
> M>  hdr_uio = NULL;
>
> This initialization is redundant and a compiler warning if exists is wrong.
>
> If we jump down to prepend_header with nios == 0, we won't ever use npages.
>
> --
> Gleb Smirnoff
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Deorbiting i386 (was: Re: svn commit: r333388 - in head: . share/man/man4 sys/confsys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/toolstools/tools/nxge usr.sbin/bsdconfig/sha

[Cy Schubert]

In message <20180523202228.gc58...@spindle.one-eyed-alien.net>, Brooks 
Davis wr
ites:
> 
>
> --QRj9sO5tAVLaXnSD
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Thu, May 24, 2018 at 02:53:16AM +0700, Eugene Grosbein wrote:
> > 24.05.2018 2:30, Cy Schubert wrote:
> >=20
> > > Except for old computers and old software that segfaults on 64-bit, how=
>  many people still use i386?
> > >=20
> > > Full disclosure: I'd like to see i386 deorbited before I retire.
> >=20
> > Plese don't. I routinely use FreeBSD11/i386 for cheap VPS hosts having le=
> ss than 2G memory
> > because amd64 has noticeable overhead. I even have ZFS-only i386 VPS, her=
> e is live example with 1G only:
> >=20
> > Mem: 10M Active, 69M Inact, 230M Wired, 685M Free
> > ARC: 75M Total, 1953K MFU, 31M MRU, 172K Anon, 592K Header, 42M Other
> >  3500K Compressed, 29M Uncompressed, 8.61:1 Ratio
> > Swap: 1024M Total, 1024M Free
> >=20
> > The VPS has only 20G of disk space and ZFS compression gives
> > compressratio 2.22x for ports, 2.51x for src, 2.29x for obj
> > and 1.95x for installed i386 system plus other software and data.
>
> I think we're quite a ways from being ready to axe i386.
>
> For VPS applications, we should probably get x32 support in place which
> should give us the best of both worlds.
>
> That said, we either need to rev the i386 ABI to use a 64-bit time_t or
> kill it in the not to distant future or we risk embedded systems failing
> in place in 2038.  If we assume a 15 year life for most equipment to
> fail electrically or mechanically that says FreeBSD 13 shouldn't support
> the current i386 ABI.

Rereading this, I'm confused. FreeBSD 13? 2023? Either works for me, 
though 2023 is more reasonable and gives people more than enough time 
to migrate.


-- 
Cheers,
Cy Schubert 
FreeBSD UNIX:     Web:  http://www.FreeBSD.org

The need of the many outweighs the greed of the few.


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333860 - head/sys/kern

[Gleb Smirnoff]

  Hi,

On Sat, May 19, 2018 at 05:10:52AM +, Matt Macy wrote:
M> Author: mmacy
M> Date: Sat May 19 05:10:51 2018
M> New Revision: 333860
M> URL: https://svnweb.freebsd.org/changeset/base/333860
M> 
M> Log:
M>   sendfile: annotate unused value and ensure that npages is actually 
initialized
M> 
M> Modified:
M>   head/sys/kern/kern_sendfile.c
M> 
M> Modified: head/sys/kern/kern_sendfile.c
M> 
==
M> --- head/sys/kern/kern_sendfile.cSat May 19 05:09:10 2018
(r333859)
M> +++ head/sys/kern/kern_sendfile.cSat May 19 05:10:51 2018
(r333860)
M> @@ -341,7 +341,7 @@ sendfile_swapin(vm_object_t obj, struct sf_io *sfio, o
M>  }
M>  
M>  for (int i = 0; i < npages;) {
M> -int j, a, count, rv;
M> +int j, a, count, rv __unused;
M>  
M>  /* Skip valid pages. */
M>  if (vm_page_is_valid(pa[i], vmoff(i, off) & PAGE_MASK,
M> @@ -688,6 +688,7 @@ retry_space:
M>  if (space == 0) {
M>  sfio = NULL;
M>  nios = 0;
M> +npages = 0;
M>  goto prepend_header;
M>  }
M>  hdr_uio = NULL;

This initialization is redundant and a compiler warning if exists is wrong.

If we jump down to prepend_header with nios == 0, we won't ever use npages.

-- 
Gleb Smirnoff
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333668 - vendor/tcpdump/dist

[Gleb Smirnoff]

On Wed, May 23, 2018 at 02:27:07PM -0700, Gleb Smirnoff wrote:
T> On Wed, May 23, 2018 at 02:25:13PM -0700, Gleb Smirnoff wrote:
T> T>   Hi,
T> T> 
T> T> do we commit cherry-picks into vendor/ subversion space? I believe we 
don't.
T> T> 
T> T> Cherry-picks should go directly to head. vendor/ should get only tagged
T> T> full tree updates.
T> 
T> Ehrm, and these two commits actually are already in head, since they came
T> to tcpdump from us.
T> 
T> What was the point of r333668?

Sorry, I was wrong on my first email, but not in the second. We commit vendor
patches to vendor/ area, but what r333668 brought it in is originally a FreeBSD
patch. So I still can't understand the point of r333668.

-- 
Gleb Smirnoff
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334122 - in head/sys: amd64/amd64 i386/i386 sys

[Konstantin Belousov]

Author: kib
Date: Wed May 23 21:39:29 2018
New Revision: 334122
URL: https://svnweb.freebsd.org/changeset/base/334122

Log:
  x86: stop unconditionally clearing PSL_T on the trace trap.
  
  We certainly should clear PSL_T when calling the SIGTRAP signal
  handler, which is already done by all x86 sendsig(9) ABI code.  On the
  other hand, there is no obvious reason why PSL_T needs to be cleared
  when returning from the signal handler.  For instance, Linux allows
  userspace to set PSL_T and keep tracing enabled for the desired
  period.  There are userspace programs which would use PSL_T if we make
  it possible, for instance sbcl.
  
  Remember if PSL_T was set by PT_STEP or PT_SETSTEP by mean of TDB_STEP
  flag, and only clear it when the flag is set.
  
  Discussed with:   Ali Mashtizadeh
  Reviewed by:  jhb (previous version)
  Sponsored by: The FreeBSD Foundation
  MFC after:2 weeks
  Differential revision:https://reviews.freebsd.org/D15054

Modified:
  head/sys/amd64/amd64/machdep.c
  head/sys/amd64/amd64/trap.c
  head/sys/i386/i386/machdep.c
  head/sys/i386/i386/trap.c
  head/sys/sys/proc.h

Modified: head/sys/amd64/amd64/machdep.c
==
--- head/sys/amd64/amd64/machdep.c  Wed May 23 21:26:41 2018
(r334121)
+++ head/sys/amd64/amd64/machdep.c  Wed May 23 21:39:29 2018
(r334122)
@@ -1978,7 +1978,12 @@ ptrace_set_pc(struct thread *td, unsigned long addr)
 int
 ptrace_single_step(struct thread *td)
 {
-   td->td_frame->tf_rflags |= PSL_T;
+
+   PROC_LOCK_ASSERT(td->td_proc, MA_OWNED);
+   if ((td->td_frame->tf_rflags & PSL_T) == 0) {
+   td->td_frame->tf_rflags |= PSL_T;
+   td->td_dbgflags |= TDB_STEP;
+   }
return (0);
 }
 
@@ -1986,7 +1991,9 @@ int
 ptrace_clear_single_step(struct thread *td)
 {
 
+   PROC_LOCK_ASSERT(td->td_proc, MA_OWNED);
td->td_frame->tf_rflags &= ~PSL_T;
+   td->td_dbgflags &= ~TDB_STEP;
return (0);
 }
 

Modified: head/sys/amd64/amd64/trap.c
==
--- head/sys/amd64/amd64/trap.c Wed May 23 21:26:41 2018(r334121)
+++ head/sys/amd64/amd64/trap.c Wed May 23 21:39:29 2018(r334122)
@@ -285,8 +285,14 @@ trap(struct trapframe *frame)
signo = SIGTRAP;
ucode = TRAP_TRACE;
dr6 = rdr6();
-   if (dr6 & DBREG_DR6_BS)
-   frame->tf_rflags &= ~PSL_T;
+   if ((dr6 & DBREG_DR6_BS) != 0) {
+   PROC_LOCK(td->td_proc);
+   if ((td->td_dbgflags & TDB_STEP) != 0) {
+   td->td_frame->tf_rflags &= ~PSL_T;
+   td->td_dbgflags &= ~TDB_STEP;
+   }
+   PROC_UNLOCK(td->td_proc);
+   }
break;
 
case T_ARITHTRAP:   /* arithmetic trap */

Modified: head/sys/i386/i386/machdep.c
==
--- head/sys/i386/i386/machdep.cWed May 23 21:26:41 2018
(r334121)
+++ head/sys/i386/i386/machdep.cWed May 23 21:39:29 2018
(r334122)
@@ -2764,7 +2764,12 @@ ptrace_set_pc(struct thread *td, u_long addr)
 int
 ptrace_single_step(struct thread *td)
 {
-   td->td_frame->tf_eflags |= PSL_T;
+
+   PROC_LOCK_ASSERT(td->td_proc, MA_OWNED);
+   if ((td->td_frame->tf_eflags & PSL_T) == 0) {
+   td->td_frame->tf_eflags |= PSL_T;
+   td->td_dbgflags |= TDB_STEP;
+   }
return (0);
 }
 
@@ -2772,7 +2777,9 @@ int
 ptrace_clear_single_step(struct thread *td)
 {
 
+   PROC_LOCK_ASSERT(td->td_proc, MA_OWNED);
td->td_frame->tf_eflags &= ~PSL_T;
+   td->td_dbgflags &= ~TDB_STEP;
return (0);
 }
 

Modified: head/sys/i386/i386/trap.c
==
--- head/sys/i386/i386/trap.c   Wed May 23 21:26:41 2018(r334121)
+++ head/sys/i386/i386/trap.c   Wed May 23 21:39:29 2018(r334122)
@@ -337,8 +337,14 @@ user_trctrap_out:
signo = SIGTRAP;
ucode = TRAP_TRACE;
dr6 = rdr6();
-   if (dr6 & DBREG_DR6_BS)
-   frame->tf_eflags &= ~PSL_T;
+   if ((dr6 & DBREG_DR6_BS) != 0) {
+   PROC_LOCK(td->td_proc);
+   if ((td->td_dbgflags & TDB_STEP) != 0) {
+   td->td_frame->tf_eflags &= ~PSL_T;
+   td->td_dbgflags &= ~TDB_STEP;
+   }
+   

Re: svn commit: r333668 - vendor/tcpdump/dist

[Xin LI]

On Wed, May 23, 2018 at 2:25 PM Gleb Smirnoff  wrote:

>Hi,

> do we commit cherry-picks into vendor/ subversion space? I believe we
don't.

Yes we do.  Actually doing it _properly_ would make future imports easier.

> Cherry-picks should go directly to head. vendor/ should get only tagged
> full tree updates.

No, that would make future merges harder.  Let's say you want to apply a
patchset P, if it's already accepted by upstream, you would do:

  - Commit it against vendor/.../dist
  - "svn merge -c  ^/dist" or merge -r:

If the patchset was not accepted at the time, but later accepted as-is, you
would compensate the local change with:

  - Commit it against vendor/.../dist
  - "svn merge -c ... --record-only ..."

Lastly, if the patchset was adopted by upstream with changes, you would do
a similar change for the first one, but tweak the local copy to reduce diff
against the cherry-picked dist/ version.

This way, svn would know that the change is already done in dist/ and
calculate diff's more accurately for future merges.

Note that Slava didn't commit the mergeinfo update in head/, which should
be done to take advantage of this maneuver.  Without it, svn would have
problem figuring the right delta.


> On Wed, May 16, 2018 at 08:43:08AM +, Slava Shwartsman wrote:
> S> Author: slavash
> S> Date: Wed May 16 08:43:08 2018
> S> New Revision: 333668
> S> URL: https://svnweb.freebsd.org/changeset/base/333668
> S>
> S> Log:
> S>   Vendor import two upstream commits:
> S>   c1bb8784abd3ca978e376b0d10e324db0491237b
> S>   9c4af7213cc2543a1f5586d8f2c19f86aa0cbe72
> S>
> S>   When using tcpdump -I -i wlanN and wlanN is not a monitor mode VAP,
> S>   tcpdump will print an error message saying rfmon is not supported.
> S>
> S>   Give a concise explanation as to how one might solve this problem by
> S>   creating a monitor mode VAP.
> S>
> S>   Approved by:hselasky (mentor), kib (mentor)
> S>   Sponsored by:   Mellanox Technologies
> S>
> S> Modified:
> S>   vendor/tcpdump/dist/tcpdump.c
> S>
> S> Modified: vendor/tcpdump/dist/tcpdump.c
> S>
==
> S> --- vendor/tcpdump/dist/tcpdump.cWed May 16 06:52:08 2018
  (r333667)
> S> +++ vendor/tcpdump/dist/tcpdump.cWed May 16 08:43:08 2018
  (r333668)
> S> @@ -108,6 +108,10 @@ The Regents of the University of California.  All
righ
> S>  #endif /* HAVE_CAP_NG_H */
> S>  #endif /* HAVE_LIBCAP_NG */
> S>
> S> +#ifdef __FreeBSD__
> S> +#include 
> S> +#endif /* __FreeBSD__ */
> S> +
> S>  #include "netdissect.h"
> S>  #include "interface.h"
> S>  #include "addrtoname.h"
> S> @@ -1044,6 +1048,30 @@ open_interface(const char *device,
netdissect_options
> S>  } else if (status == PCAP_ERROR_PERM_DENIED && *cp !=
'\0')
> S>  error("%s: %s\n(%s)", device,
> S>  pcap_statustostr(status), cp);
> S> +#ifdef __FreeBSD__
> S> +else if (status == PCAP_ERROR_RFMON_NOTSUP &&
> S> +strncmp(device, "wlan", 4) == 0) {
> S> +char parent[8], newdev[8];
> S> +char sysctl[32];
> S> +size_t s = sizeof(parent);
> S> +
> S> +snprintf(sysctl, sizeof(sysctl),
> S> +"net.wlan.%d.%%parent", atoi(device + 4));
> S> +sysctlbyname(sysctl, parent, , NULL, 0);
> S> +strlcpy(newdev, device, sizeof(newdev));
> S> +/* Suggest a new wlan device. */
> S> +/* FIXME: incrementing the index this way is not
going to work well
> S> + * when the index is 9 or greater but the only
consequence in this
> S> + * specific case would be an error message that
looks a bit odd.
> S> + */
> S> +newdev[strlen(newdev)-1]++;
> S> +error("%s is not a monitor mode VAP\n"
> S> +"To create a new monitor mode VAP use:\n"
> S> +"  ifconfig %s create wlandev %s wlanmode
monitor\n"
> S> +"and use %s as the tcpdump interface",
> S> +device, newdev, parent, newdev);
> S> +}
> S> +#endif
> S>  else
> S>  error("%s: %s", device,
> S>  pcap_statustostr(status));
> S>

> --
> Gleb Smirnoff
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333668 - vendor/tcpdump/dist

[Gleb Smirnoff]

On Wed, May 23, 2018 at 02:25:13PM -0700, Gleb Smirnoff wrote:
T>   Hi,
T> 
T> do we commit cherry-picks into vendor/ subversion space? I believe we don't.
T> 
T> Cherry-picks should go directly to head. vendor/ should get only tagged
T> full tree updates.

Ehrm, and these two commits actually are already in head, since they came
to tcpdump from us.

What was the point of r333668?

-- 
Gleb Smirnoff
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334121 - head/sys/i386/i386

[Konstantin Belousov]

Author: kib
Date: Wed May 23 21:26:41 2018
New Revision: 334121
URL: https://svnweb.freebsd.org/changeset/base/334121

Log:
  Stop obliterating actual exception type for emulated traps from vm86.
  
  Wording and reviewed by:  jhb
  Sponsored by: The FreeBSD Foundation
  MFC after:1 week
  Differential revision:https://reviews.freebsd.org/D15054

Modified:
  head/sys/i386/i386/trap.c

Modified: head/sys/i386/i386/trap.c
==
--- head/sys/i386/i386/trap.c   Wed May 23 21:26:33 2018(r334120)
+++ head/sys/i386/i386/trap.c   Wed May 23 21:26:41 2018(r334121)
@@ -357,7 +357,6 @@ user_trctrap_out:
if (frame->tf_eflags & PSL_VM) {
signo = vm86_emulate((struct vm86frame *)frame);
if (signo == SIGTRAP) {
-   type = T_TRCTRAP;
load_dr6(rdr6() | 0x4000);
goto user_trctrap_out;
}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334120 - head/share/mk

[Ed Maste]

Author: emaste
Date: Wed May 23 21:26:33 2018
New Revision: 334120
URL: https://svnweb.freebsd.org/changeset/base/334120

Log:
  Revert r334081 (-Wmain) as it broke the build on gcc architectures

Modified:
  head/share/mk/bsd.sys.mk

Modified: head/share/mk/bsd.sys.mk
==
--- head/share/mk/bsd.sys.mkWed May 23 21:25:49 2018(r334119)
+++ head/share/mk/bsd.sys.mkWed May 23 21:26:33 2018(r334120)
@@ -28,7 +28,7 @@ CFLAGS+=  -std=${CSTD}
 #CFLAGS+=  -pedantic
 .if defined(WARNS)
 .if ${WARNS} >= 1
-CWARNFLAGS+=   -Wsystem-headers -Wmain
+CWARNFLAGS+=   -Wsystem-headers
 .if !defined(NO_WERROR) && !defined(NO_WERROR.${COMPILER_TYPE})
 CWARNFLAGS+=   -Werror
 .endif # !NO_WERROR && !NO_WERROR.${COMPILER_TYPE}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334119 - in head/sys: amd64/amd64 i386/i386

[Konstantin Belousov]

Author: kib
Date: Wed May 23 21:25:49 2018
New Revision: 334119
URL: https://svnweb.freebsd.org/changeset/base/334119

Log:
  Style.
  
  Wording and reviewed by:  jhb
  Sponsored by: The FreeBSD Foundation
  MFC after:3 days
  Differential revision:https://reviews.freebsd.org/D15054

Modified:
  head/sys/amd64/amd64/machdep.c
  head/sys/i386/i386/machdep.c

Modified: head/sys/amd64/amd64/machdep.c
==
--- head/sys/amd64/amd64/machdep.c  Wed May 23 21:02:14 2018
(r334118)
+++ head/sys/amd64/amd64/machdep.c  Wed May 23 21:25:49 2018
(r334119)
@@ -1985,6 +1985,7 @@ ptrace_single_step(struct thread *td)
 int
 ptrace_clear_single_step(struct thread *td)
 {
+
td->td_frame->tf_rflags &= ~PSL_T;
return (0);
 }

Modified: head/sys/i386/i386/machdep.c
==
--- head/sys/i386/i386/machdep.cWed May 23 21:02:14 2018
(r334118)
+++ head/sys/i386/i386/machdep.cWed May 23 21:25:49 2018
(r334119)
@@ -2771,6 +2771,7 @@ ptrace_single_step(struct thread *td)
 int
 ptrace_clear_single_step(struct thread *td)
 {
+
td->td_frame->tf_eflags &= ~PSL_T;
return (0);
 }
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333668 - vendor/tcpdump/dist

[Gleb Smirnoff]

  Hi,

do we commit cherry-picks into vendor/ subversion space? I believe we don't.

Cherry-picks should go directly to head. vendor/ should get only tagged
full tree updates.

On Wed, May 16, 2018 at 08:43:08AM +, Slava Shwartsman wrote:
S> Author: slavash
S> Date: Wed May 16 08:43:08 2018
S> New Revision: 333668
S> URL: https://svnweb.freebsd.org/changeset/base/333668
S> 
S> Log:
S>   Vendor import two upstream commits:
S>   c1bb8784abd3ca978e376b0d10e324db0491237b
S>   9c4af7213cc2543a1f5586d8f2c19f86aa0cbe72
S>   
S>   When using tcpdump -I -i wlanN and wlanN is not a monitor mode VAP,
S>   tcpdump will print an error message saying rfmon is not supported.
S>   
S>   Give a concise explanation as to how one might solve this problem by
S>   creating a monitor mode VAP.
S>   
S>   Approved by:hselasky (mentor), kib (mentor)
S>   Sponsored by:   Mellanox Technologies
S> 
S> Modified:
S>   vendor/tcpdump/dist/tcpdump.c
S> 
S> Modified: vendor/tcpdump/dist/tcpdump.c
S> 
==
S> --- vendor/tcpdump/dist/tcpdump.cWed May 16 06:52:08 2018
(r333667)
S> +++ vendor/tcpdump/dist/tcpdump.cWed May 16 08:43:08 2018
(r333668)
S> @@ -108,6 +108,10 @@ The Regents of the University of California.  All righ
S>  #endif /* HAVE_CAP_NG_H */
S>  #endif /* HAVE_LIBCAP_NG */
S>  
S> +#ifdef __FreeBSD__
S> +#include 
S> +#endif /* __FreeBSD__ */
S> +
S>  #include "netdissect.h"
S>  #include "interface.h"
S>  #include "addrtoname.h"
S> @@ -1044,6 +1048,30 @@ open_interface(const char *device, netdissect_options 
S>  } else if (status == PCAP_ERROR_PERM_DENIED && *cp != '\0')
S>  error("%s: %s\n(%s)", device,
S>  pcap_statustostr(status), cp);
S> +#ifdef __FreeBSD__
S> +else if (status == PCAP_ERROR_RFMON_NOTSUP &&
S> +strncmp(device, "wlan", 4) == 0) {
S> +char parent[8], newdev[8];
S> +char sysctl[32];
S> +size_t s = sizeof(parent);
S> +
S> +snprintf(sysctl, sizeof(sysctl),
S> +"net.wlan.%d.%%parent", atoi(device + 4));
S> +sysctlbyname(sysctl, parent, , NULL, 0);
S> +strlcpy(newdev, device, sizeof(newdev));
S> +/* Suggest a new wlan device. */
S> +/* FIXME: incrementing the index this way is not going 
to work well
S> + * when the index is 9 or greater but the only 
consequence in this
S> + * specific case would be an error message that looks a 
bit odd.
S> + */
S> +newdev[strlen(newdev)-1]++;
S> +error("%s is not a monitor mode VAP\n"
S> +"To create a new monitor mode VAP use:\n"
S> +"  ifconfig %s create wlandev %s wlanmode monitor\n"
S> +"and use %s as the tcpdump interface",
S> +device, newdev, parent, newdev);
S> +}
S> +#endif
S>  else
S>  error("%s: %s", device,
S>  pcap_statustostr(status));
S> 

-- 
Gleb Smirnoff
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334118 - in head/sys: compat/linprocfs compat/linux compat/linuxkpi/common/include/linux dev/mlx5/mlx5_ib dev/wtap net net/altq netinet netinet/netdump netinet6 netpfil/pf nfs ofed/dri...

[Matt Macy]

Author: mmacy
Date: Wed May 23 21:02:14 2018
New Revision: 334118
URL: https://svnweb.freebsd.org/changeset/base/334118

Log:
  UDP: further performance improvements on tx
  
  Cumulative throughput while running 64
netperf -H $DUT -t UDP_STREAM -- -m 1
  on a 2x8x2 SKL went from 1.1Mpps to 2.5Mpps
  
  Single stream throughput increases from 910kpps to 1.18Mpps
  
  Baseline:
  https://people.freebsd.org/~mmacy/2018.05.11/udpsender2.svg
  
  - Protect read access to global ifnet list with epoch
  https://people.freebsd.org/~mmacy/2018.05.11/udpsender3.svg
  
  - Protect short lived ifaddr references with epoch
  https://people.freebsd.org/~mmacy/2018.05.11/udpsender4.svg
  
  - Convert if_afdata read lock path to epoch
  https://people.freebsd.org/~mmacy/2018.05.11/udpsender5.svg
  
  A fix for the inpcbhash contention is pending sufficient time
  on a canary at LLNW.
  
  Reviewed by:  gallatin
  Sponsored by: Limelight Networks
  Differential Revision:https://reviews.freebsd.org/D15409

Modified:
  head/sys/compat/linprocfs/linprocfs.c
  head/sys/compat/linux/linux_ioctl.c
  head/sys/compat/linuxkpi/common/include/linux/inetdevice.h
  head/sys/dev/mlx5/mlx5_ib/mlx5_ib_main.c
  head/sys/dev/wtap/if_wtap.c
  head/sys/net/altq/altq_subr.c
  head/sys/net/bridgestp.c
  head/sys/net/if.c
  head/sys/net/if_llatbl.c
  head/sys/net/if_llatbl.h
  head/sys/net/if_var.h
  head/sys/net/route.c
  head/sys/net/rtsock.c
  head/sys/netinet/igmp.c
  head/sys/netinet/in.c
  head/sys/netinet/in_mcast.c
  head/sys/netinet/in_pcb.c
  head/sys/netinet/in_var.h
  head/sys/netinet/ip_divert.c
  head/sys/netinet/ip_icmp.c
  head/sys/netinet/ip_input.c
  head/sys/netinet/ip_mroute.c
  head/sys/netinet/ip_options.c
  head/sys/netinet/ip_output.c
  head/sys/netinet/netdump/netdump_client.c
  head/sys/netinet/raw_ip.c
  head/sys/netinet/sctp_bsd_addr.c
  head/sys/netinet6/icmp6.c
  head/sys/netinet6/in6.c
  head/sys/netinet6/in6_ifattach.c
  head/sys/netinet6/in6_pcb.c
  head/sys/netinet6/ip6_input.c
  head/sys/netinet6/nd6.c
  head/sys/netinet6/raw_ip6.c
  head/sys/netpfil/pf/pf_if.c
  head/sys/nfs/bootp_subr.c
  head/sys/nfs/nfs_diskless.c
  head/sys/ofed/drivers/infiniband/core/ib_roce_gid_mgmt.c

Modified: head/sys/compat/linprocfs/linprocfs.c
==
--- head/sys/compat/linprocfs/linprocfs.c   Wed May 23 20:55:01 2018
(r334117)
+++ head/sys/compat/linprocfs/linprocfs.c   Wed May 23 21:02:14 2018
(r334118)
@@ -1138,7 +1138,7 @@ linux_ifname(struct ifnet *ifp, char *buffer, size_t b
 
/* Determine the (relative) unit number for ethernet interfaces */
ethno = 0;
-   TAILQ_FOREACH(ifscan, _ifnet, if_link) {
+   CK_STAILQ_FOREACH(ifscan, _ifnet, if_link) {
if (ifscan == ifp)
return (snprintf(buffer, buflen, "eth%d", ethno));
if (IFP_IS_ETH(ifscan))
@@ -1166,7 +1166,7 @@ linprocfs_donetdev(PFS_FILL_ARGS)
 
CURVNET_SET(TD_TO_VNET(curthread));
IFNET_RLOCK();
-   TAILQ_FOREACH(ifp, _ifnet, if_link) {
+   CK_STAILQ_FOREACH(ifp, _ifnet, if_link) {
linux_ifname(ifp, ifname, sizeof ifname);
sbuf_printf(sb, "%6.6s: ", ifname);
sbuf_printf(sb, "%7ju %7ju %4ju %4ju %4lu %5lu %10lu %9ju ",

Modified: head/sys/compat/linux/linux_ioctl.c
==
--- head/sys/compat/linux/linux_ioctl.c Wed May 23 20:55:01 2018
(r334117)
+++ head/sys/compat/linux/linux_ioctl.c Wed May 23 21:02:14 2018
(r334118)
@@ -2150,7 +2150,7 @@ ifname_linux_to_bsd(struct thread *td, const char *lxn
is_eth = (len == 3 && !strncmp(lxname, "eth", len)) ? 1 : 0;
CURVNET_SET(TD_TO_VNET(td));
IFNET_RLOCK();
-   TAILQ_FOREACH(ifp, _ifnet, if_link) {
+   CK_STAILQ_FOREACH(ifp, _ifnet, if_link) {
/*
 * Allow Linux programs to use FreeBSD names. Don't presume
 * we never have an interface named "eth", so don't make
@@ -2188,7 +2188,7 @@ linux_ioctl_ifname(struct thread *td, struct l_ifreq *
index = 1;  /* ifr.ifr_ifindex starts from 1 */
ethno = 0;
error = ENODEV;
-   TAILQ_FOREACH(ifp, _ifnet, if_link) {
+   CK_STAILQ_FOREACH(ifp, _ifnet, if_link) {
if (ifr.ifr_ifindex == index) {
if (IFP_IS_ETH(ifp))
snprintf(ifr.ifr_name, LINUX_IFNAMSIZ,
@@ -2240,7 +2240,7 @@ linux_ifconf(struct thread *td, struct ifconf *uifc)
if ((l_uintptr_t)ifc.ifc_buf == PTROUT(NULL)) {
ifc.ifc_len = 0;
IFNET_RLOCK();
-   TAILQ_FOREACH(ifp, _ifnet, if_link) {
+   CK_STAILQ_FOREACH(ifp, _ifnet, if_link) {
CK_STAILQ_FOREACH(ifa, >if_addrhead, ifa_link) {
struct sockaddr 

svn commit: r334116 - head/sys/netinet

[Matt Macy]

Author: mmacy
Date: Wed May 23 20:50:09 2018
New Revision: 334116
URL: https://svnweb.freebsd.org/changeset/base/334116

Log:
  udp: assign flowid to udp sockets round-robin
  
  On a 2x8x2 SKL this increases measured throughput with 64
  netperf -H $DUT -t UDP_STREAM -- -m 1
  
  from 590kpps to 1.1Mpps
  before:
  https://people.freebsd.org/~mmacy/2018.05.11/udpsender.svg
  after:
  https://people.freebsd.org/~mmacy/2018.05.11/udpsender2.svg

Modified:
  head/sys/netinet/udp_usrreq.c

Modified: head/sys/netinet/udp_usrreq.c
==
--- head/sys/netinet/udp_usrreq.c   Wed May 23 20:06:04 2018
(r334115)
+++ head/sys/netinet/udp_usrreq.c   Wed May 23 20:50:09 2018
(r334116)
@@ -1565,6 +1565,7 @@ udp_abort(struct socket *so)
 static int
 udp_attach(struct socket *so, int proto, struct thread *td)
 {
+   static uint32_t udp_flowid;
struct inpcb *inp;
struct inpcbinfo *pcbinfo;
int error;
@@ -1585,6 +1586,8 @@ udp_attach(struct socket *so, int proto, struct thread
inp = sotoinpcb(so);
inp->inp_vflag |= INP_IPV4;
inp->inp_ip_ttl = V_ip_defttl;
+   inp->inp_flowid = atomic_fetchadd_int(_flowid, 1);
+   inp->inp_flowtype = M_HASHTYPE_OPAQUE;
 
error = udp_newudpcb(inp);
if (error) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333388 - in head: . share/man/man4 sys/confsys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/toolstools/tools/nxge usr.sbin/bsdconfig/share

[Cy Schubert]

In message <20180523202228.gc58...@spindle.one-eyed-alien.net>, Brooks 
Davis wr
ites:
> 
>
> --QRj9sO5tAVLaXnSD
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Thu, May 24, 2018 at 02:53:16AM +0700, Eugene Grosbein wrote:
> > 24.05.2018 2:30, Cy Schubert wrote:
> >=20
> > > Except for old computers and old software that segfaults on 64-bit, how=
>  many people still use i386?
> > >=20
> > > Full disclosure: I'd like to see i386 deorbited before I retire.
> >=20
> > Plese don't. I routinely use FreeBSD11/i386 for cheap VPS hosts having le=
> ss than 2G memory
> > because amd64 has noticeable overhead. I even have ZFS-only i386 VPS, her=
> e is live example with 1G only:
> >=20
> > Mem: 10M Active, 69M Inact, 230M Wired, 685M Free
> > ARC: 75M Total, 1953K MFU, 31M MRU, 172K Anon, 592K Header, 42M Other
> >  3500K Compressed, 29M Uncompressed, 8.61:1 Ratio
> > Swap: 1024M Total, 1024M Free
> >=20
> > The VPS has only 20G of disk space and ZFS compression gives
> > compressratio 2.22x for ports, 2.51x for src, 2.29x for obj
> > and 1.95x for installed i386 system plus other software and data.
>
> I think we're quite a ways from being ready to axe i386.
>
> For VPS applications, we should probably get x32 support in place which
> should give us the best of both worlds.
>
> That said, we either need to rev the i386 ABI to use a 64-bit time_t or
> kill it in the not to distant future or we risk embedded systems failing
> in place in 2038.  If we assume a 15 year life for most equipment to
> fail electrically or mechanically that says FreeBSD 13 shouldn't support
> the current i386 ABI.

I think many of the Linux distros have already done this or are 
seriously discussing it.


-- 
Cheers,
Cy Schubert 
FreeBSD UNIX:     Web:  http://www.FreeBSD.org

The need of the many outweighs the greed of the few.


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333388 - in head: . share/man/man4 sys/confsys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/toolstools/tools/nxge usr.sbin/bsdconfig/share

[Cy Schubert]

In message <5b05c6ac.6010...@grosbein.net>, Eugene Grosbein writes:
> 24.05.2018 2:30, Cy Schubert wrote:
>
> > Except for old computers and old software that segfaults on 64-bit, how man
> y people still use i386?
> > 
> > Full disclosure: I'd like to see i386 deorbited before I retire.
>
> Plese don't. I routinely use FreeBSD11/i386 for cheap VPS hosts having less t
> han 2G memory
> because amd64 has noticeable overhead. I even have ZFS-only i386 VPS, here is
>  live example with 1G only:
>
> Mem: 10M Active, 69M Inact, 230M Wired, 685M Free
> ARC: 75M Total, 1953K MFU, 31M MRU, 172K Anon, 592K Header, 42M Other
>  3500K Compressed, 29M Uncompressed, 8.61:1 Ratio
> Swap: 1024M Total, 1024M Free

I did say before I retire and I have no immediate plans. However 
dealing with 32-bit issues are a PITA and considering the causes of, 
IMO, most of the -CURRENT build failures over the past year, I suspect 
others may also feel the same way. Also, when there are i386 buildworld 
failures, people hardly complain. I do because my build scripts here 
build both (which I also do for ports). It is a fair bit of overhead.

>
> The VPS has only 20G of disk space and ZFS compression gives
> compressratio 2.22x for ports, 2.51x for src, 2.29x for obj
> and 1.95x for installed i386 system plus other software and data.

 I used a 768 MB Pentium M with compressed ZFS on a 40 GB disk, I think 
that was about 10 or 12 years ago. Documented on our wiki. That same 
machine is now my i386 testbed, used a few times a year. It now has 2 
GB RAM and 150 GB disk. Same configuration, just a little bigger.


-- 
Cheers,
Cy Schubert 
FreeBSD UNIX:     Web:  http://www.FreeBSD.org

The need of the many outweighs the greed of the few.


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334115 - in head: share/man/man4 sys/dev/usb/template

[Ravi Pokala]

Hi Traz,

You're referring to power consumption in terms of (milli)Amps. That's not 
right; power is measured in Watts. What you're actually talking about is 
*current*. And it looks like in some situations USB devices can draw more than 
500mA.

https://en.wikipedia.org/wiki/USB_(Physical)#POWER

Thanks,

Ravi (rpokala@) 

-Original Message-
From:  on behalf of Edward Tomasz Napierala 

Date: 2018-05-23, Wednesday at 13:06
To: , , 

Subject: svn commit: r334115 - in head: share/man/man4 sys/dev/usb/template

Author: trasz
Date: Wed May 23 20:06:04 2018
New Revision: 334115
URL: https://svnweb.freebsd.org/changeset/base/334115

Log:
  Centralize USB device mode bus power reporting, and add
  hw.usb.template_power sysctl to control it.
  
  Reviewed by:  hselasky@ (earlier version)
  MFC after:2 weeks
  Sponsored by: The FreeBSD Foundation

Modified:
  head/share/man/man4/usb_template.4
  head/sys/dev/usb/template/usb_template.c
  head/sys/dev/usb/template/usb_template_audio.c
  head/sys/dev/usb/template/usb_template_cdce.c
  head/sys/dev/usb/template/usb_template_kbd.c
  head/sys/dev/usb/template/usb_template_midi.c
  head/sys/dev/usb/template/usb_template_modem.c
  head/sys/dev/usb/template/usb_template_mouse.c
  head/sys/dev/usb/template/usb_template_msc.c
  head/sys/dev/usb/template/usb_template_mtp.c
  head/sys/dev/usb/template/usb_template_multi.c
  head/sys/dev/usb/template/usb_template_phone.c
  head/sys/dev/usb/template/usb_template_serialnet.c

Modified: head/share/man/man4/usb_template.4
==
--- head/share/man/man4/usb_template.4  Wed May 23 19:55:47 2018
(r334114)
+++ head/share/man/man4/usb_template.4  Wed May 23 20:06:04 2018
(r334115)
@@ -23,7 +23,7 @@
 .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 .\" SUCH DAMAGE.
 .\"
-.Dd May 17, 2018
+.Dd May 23, 2018
 .Dt USB_TEMPLATE 4
 .Os
 .
@@ -100,6 +100,11 @@ tunables:
 .It Va hw.usb.template
 Currently selected template.
 Set to -1 to make the device disappear from the USB host point of view.
+.It Va hw.usb.template_power
+USB bus power consumption in mA.
+Must be between 0 and 500.
+Setting to 0 marks the device as self-powered.
+Defaults to 500mA.
 .It Va hw.usb.templates.N
 Configuration for template number
 .Va N .

Modified: head/sys/dev/usb/template/usb_template.c
==
--- head/sys/dev/usb/template/usb_template.cWed May 23 19:55:47 2018
(r334114)
+++ head/sys/dev/usb/template/usb_template.cWed May 23 20:06:04 2018
(r334115)
@@ -76,14 +76,12 @@
 #include 
 #endif /* USB_GLOBAL_INCLUDE_FILE */
 
-SYSCTL_NODE(_hw_usb, OID_AUTO, templates, CTLFLAG_RW, 0,
-"USB device side templates");
-
 MODULE_DEPEND(usb_template, usb, 1, 1, 1);
 MODULE_VERSION(usb_template, 1);
 
 /* function prototypes */
 
+static int sysctl_hw_usb_template_power(SYSCTL_HANDLER_ARGS);
 static voidusb_make_raw_desc(struct usb_temp_setup *, const uint8_t *);
 static voidusb_make_endpoint_desc(struct usb_temp_setup *,
const struct usb_temp_endpoint_desc *);
@@ -117,6 +115,33 @@ static usb_error_t usb_temp_setup_by_index(struct usb_
uint16_t index);
 static voidusb_temp_init(void *);
 
+SYSCTL_NODE(_hw_usb, OID_AUTO, templates, CTLFLAG_RW, 0,
+"USB device side templates");
+SYSCTL_PROC(_hw_usb, OID_AUTO, template_power,
+CTLTYPE_INT | CTLFLAG_RWTUN | CTLFLAG_MPSAFE,
+NULL, 0, sysctl_hw_usb_template_power,
+"I", "USB bus power consumption in mA");
+
+static int usb_template_power = 500;   /* 500mA */
+
+static int
+sysctl_hw_usb_template_power(SYSCTL_HANDLER_ARGS)
+{
+   int error, val;
+
+   val = usb_template_power;
+   error = sysctl_handle_int(oidp, , 0, req);
+   if (error != 0 || req->newptr == NULL)
+   return (error);
+
+   if (val < 0 || val > 500)
+   return (EINVAL);
+
+   usb_template_power = val;
+
+   return (0);
+}
+
 /**
  * usb_decode_str_desc
  *
@@ -426,6 +451,7 @@ usb_make_config_desc(struct usb_temp_setup *temp,
struct usb_config_descriptor *cd;
const struct usb_temp_interface_desc **tid;
uint16_t old_size;
+   int power;
 
/* Reserve memory */
 
@@ -463,13 +489,16 @@ usb_make_config_desc(struct usb_temp_setup *temp,
cd->bConfigurationValue = temp->bConfigurationValue;
cd->iConfiguration = tcd->iConfiguration;
cd->bmAttributes = tcd->bmAttributes;
-   cd->bMaxPower = tcd->bMaxPower;
-   cd->bmAttributes |= (UC_REMOTE_WAKEUP | UC_BUS_POWERED);
 
-   if 

Re: svn commit: r333388 - in head: . share/man/man4 sys/confsys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/toolstools/tools/nxge usr.sbin/bsdconfig/share

[Brooks Davis]

On Thu, May 24, 2018 at 02:53:16AM +0700, Eugene Grosbein wrote:
> 24.05.2018 2:30, Cy Schubert wrote:
> 
> > Except for old computers and old software that segfaults on 64-bit, how 
> > many people still use i386?
> > 
> > Full disclosure: I'd like to see i386 deorbited before I retire.
> 
> Plese don't. I routinely use FreeBSD11/i386 for cheap VPS hosts having less 
> than 2G memory
> because amd64 has noticeable overhead. I even have ZFS-only i386 VPS, here is 
> live example with 1G only:
> 
> Mem: 10M Active, 69M Inact, 230M Wired, 685M Free
> ARC: 75M Total, 1953K MFU, 31M MRU, 172K Anon, 592K Header, 42M Other
>  3500K Compressed, 29M Uncompressed, 8.61:1 Ratio
> Swap: 1024M Total, 1024M Free
> 
> The VPS has only 20G of disk space and ZFS compression gives
> compressratio 2.22x for ports, 2.51x for src, 2.29x for obj
> and 1.95x for installed i386 system plus other software and data.

I think we're quite a ways from being ready to axe i386.

For VPS applications, we should probably get x32 support in place which
should give us the best of both worlds.

That said, we either need to rev the i386 ABI to use a 64-bit time_t or
kill it in the not to distant future or we risk embedded systems failing
in place in 2038.  If we assume a 15 year life for most equipment to
fail electrically or mechanically that says FreeBSD 13 shouldn't support
the current i386 ABI.

-- Brooks


signature.asc
Description: PGP signature

Re: svn commit: r334008 - head/bin/sh

[Bryan Drewery]

On 5/22/2018 5:30 PM, Bryan Drewery wrote:
> On 5/22/2018 1:22 PM, Jilles Tjoelker wrote:
>> On Tue, May 22, 2018 at 10:17:41AM +0200, O. Hartmann wrote:
>>> On Mon, 21 May 2018 21:45:53 -0700
>>> Cy Schubert  wrote:
 In message <20180522061339.21497...@freyja.zeit4.iv.bundesimmobilien.de>
 , "O. H
 artmann" writes:
> On Mon, 21 May 2018 21:52:48 + (UTC)
> Jilles Tjoelker  wrote:
>>
>> Author: jilles
>> Date: Mon May 21 21:52:48 2018
>> New Revision: 334008
>> URL: https://svnweb.freebsd.org/changeset/base/334008
>>
>> Log:
>>   sh: Split CNL syntax category to avoid a check on state[level].syntax
>>
>>   No functional change is intended.
>>
>> Modified:
>>   head/bin/sh/mksyntax.c
>>   head/bin/sh/parser.c
>>> [snip]
>>
> Have this been tested? Doesn't compile for me:
>>
> [...]
> Building /usr/obj/usr/src/amd64.amd64/kerberos5/libexec/hprop/hprop
> --- all_subdir_rescue ---
> --- parser.o ---
> /usr/src/bin/sh/parser.c:1440:9: error: use of undeclared identifier 
> 'CQNL'
> case CQNL:
>  ^
> --- all_subdir_gnu ---
> Building 
> /usr/obj/usr/src/amd64.amd64/gnu/usr.bin/gdb/libgdb/amd64bsd-nat.o
> --- all_subdir_rescue ---
> 1 error generated.
> *** [parser.o] Error code 1
>>
> make[6]: stopped in /usr/src/bin/sh
>>
 CQNL is defined in /usr/obj/opt/src/svn-current/amd64.amd64/bin/sh/synta
 x.h, generated by mksyntax.
>>
 slippy$ ag -s CQNL /export/obj/opt/src/svn-current/amd64.amd64/bin/sh/*.
 h
 /export/obj/opt/src/svn-current/amd64.amd64/bin/sh/syntax.h
 11:#define CQNL 2  /* newline character in quotes */
 slippy$ 
>>
 Remove the file if it's not defined in your syntax.h.
>>
 Just out of interest, do you use meta mode?
>>
>>> I think such a question is of common interest if errors/bugs like that 
>>> occur:
>>> Yes, I use/compile world/kernel with META mode.
>>
>> The change itself is fine. It built for me and for Jenkins
>> (ci.freebsd.org). What is not fine is an incremental build with meta
>> mode. Apparently, the  syntax.h: .NOMETA  rule added in r301285 causes
>> bmake to build some files against the old syntax.h, even though syntax.c
>> and syntax.h will be rebuilt.
>>
>> To fix this, it may be possible to generate a meta file for syntax.h
>> based on the one for syntax.c. The same would be done for builtins.[ch]
>> and nodes.[ch].
>>
>> Conceptually simpler is accepting what make would like: one command
>> generates one file only. This is not really new with meta mode since a
> 
> Yeah bmake (both with and without meta mode) is lacking in properly
> handling 1 target generating multiple files.  It's a big frustration of
> mine as every pattern I've seen does not do the right thing.  I'll look
> into this case more. For now just remove the syntax.h file from the
> objdir or remove the bin/sh dir.
> 
>> somewhat ugly .ORDER declaration had been necessary before. The .c
>> content can go inside a #ifdef in the .h file so the .c file need not be
>> autogenerated, or the tools can be run twice, once to generate the .c
>> file and once to generate the .h file. In both cases, the tools will be
>> somewhat uglier in order to simplify the build system.
>>
> 
> 


The problem is the rescue build is doing 'make foo.o bar.o' rather than
'make all', so the implicit 'make depend' phase is skipped. Switching
rescue (crunchgen) to use 'make all' fixes it. I am testing a full build
of that now and will commit it soon.

The .NOMETA does certainly cause the problem but 'make all' ensures the
implicit 'make depend' will always run for all modes as intended.

-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature

Re: svn commit: r333388 - in head: . share/man/man4 sys/conf sys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/tools tools/tools/nxge usr.sbin/bsdconfig/share

[Warner Losh]

On Wed, May 23, 2018 at 1:11 PM, Bjoern A. Zeeb <
bzeeb-li...@lists.zabbadoz.net> wrote:

> On 23 May 2018, at 18:20, Brooks Davis wrote:
>
> On Wed, May 23, 2018 at 10:41:17AM -0700, Gleb Smirnoff wrote:
>>
>>> On Tue, May 08, 2018 at 09:14:29PM +, Sean Bruno wrote:
>>> S> Log:
>>> S>   nxge(4):
>>> S>   Remove nxge(4) and associated man page and tools in FreeBSD 12.0.
>>> ...
>>> S> +20180508:
>>> S> +The nxge(4) driver has been removed.  This driver was for PCI-X
>>> 10g
>>> S> +cards made by s2io/Neterion.  The company was aquired by Exar and
>>> S> +no longer sells or supports Ethernet products.  If you have
>>> device
>>> S> +nxge in your kernel config file it must be removed.
>>> S> +
>>>
>>> If end of sales and support is enough to remove 10g driver from the
>>> kernel,
>>> can we please delete all 10Mbit, 100Mbit 10+ year old drivers from the
>>> kernel?
>>>
>>
>> It's probably a good idea to add deprecation notices for them now and
>> merge for 11 to find out which ones still have users.  Someone on IRC
>> mentioned that FreeNAS removed them and ended up restoring one, but I
>> don't remember which one it was.
>>
>> My gut feeling is that we're a bit late in the game for doing a mass
>> removal for 12, but we should definitely do so for 13.
>>
>
> I’d be very careful.  I can still buy a lot of 100Mbit/s cards and you
> constantly find them on new SoCs still which don’t do Gbit/s.  Also there’s
> a lot of legacy hw floating around for some of them.  12 definitively seems
> to be too short term.


There's a lot of really old drivers we could safely retire in 13 and not
affect more than a handful of users who could easily buy a new add-in card
since several of the early Bill Paul tulip drivers never were designed into
mobos.

There's no compelling reason to move quickly with 12 retirement. But
marking them *NOW* as going away in 13 will let us get some feedback from
people / situations that would be affected in plenty of time to change
course.

Warner
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334077 - in head/sbin/devd: . tests

[Warner Losh]

On Wed, May 23, 2018 at 1:39 AM, Eitan Adler  wrote:

> Author: eadler
> Date: Wed May 23 07:39:02 2018
> New Revision: 334077
> URL: https://svnweb.freebsd.org/changeset/base/334077
>
> Log:
>   devd: correct two warnings
>
>   - catching a polymorphic type by value
>   - "output between 16 and 95 bytes into a destination of size 80"
>
> Modified:
>   head/sbin/devd/devd.cc
>   head/sbin/devd/tests/client_test.c
>
> Modified: head/sbin/devd/devd.cc
> 
> ==
> --- head/sbin/devd/devd.cc  Wed May 23 07:39:00 2018(r334076)
> +++ head/sbin/devd/devd.cc  Wed May 23 07:39:02 2018(r334077)
> @@ -1087,7 +1087,7 @@ event_loop(void)
> try {
> process_event(buffer);
> }
> -   catch (std::length_error e) {
> +   catch (const std::length_error& e) {
> devdlog(LOG_ERR, "Dropping event
> %s "
> "due to low memory", buffer);
> }
>
> Modified: head/sbin/devd/tests/client_test.c
> 
> ==
> --- head/sbin/devd/tests/client_test.c  Wed May 23 07:39:00 2018
> (r334076)
> +++ head/sbin/devd/tests/client_test.c  Wed May 23 07:39:02 2018
> (r334077)
> @@ -50,7 +50,7 @@ create_two_events(void)
> FILE *create_stdout;
> FILE *destroy_stdout;
> char mdname[80];
> -   char destroy_cmd[80];
> +   char destroy_cmd[95];
> char *error;
>

I know it's just a test, but 95 seems equally as magical as 80...

Warner


> create_stdout = popen("mdconfig -a -s 64 -t null", "r");
>
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334115 - in head: share/man/man4 sys/dev/usb/template

[Edward Tomasz Napierala]

Author: trasz
Date: Wed May 23 20:06:04 2018
New Revision: 334115
URL: https://svnweb.freebsd.org/changeset/base/334115

Log:
  Centralize USB device mode bus power reporting, and add
  hw.usb.template_power sysctl to control it.
  
  Reviewed by:  hselasky@ (earlier version)
  MFC after:2 weeks
  Sponsored by: The FreeBSD Foundation

Modified:
  head/share/man/man4/usb_template.4
  head/sys/dev/usb/template/usb_template.c
  head/sys/dev/usb/template/usb_template_audio.c
  head/sys/dev/usb/template/usb_template_cdce.c
  head/sys/dev/usb/template/usb_template_kbd.c
  head/sys/dev/usb/template/usb_template_midi.c
  head/sys/dev/usb/template/usb_template_modem.c
  head/sys/dev/usb/template/usb_template_mouse.c
  head/sys/dev/usb/template/usb_template_msc.c
  head/sys/dev/usb/template/usb_template_mtp.c
  head/sys/dev/usb/template/usb_template_multi.c
  head/sys/dev/usb/template/usb_template_phone.c
  head/sys/dev/usb/template/usb_template_serialnet.c

Modified: head/share/man/man4/usb_template.4
==
--- head/share/man/man4/usb_template.4  Wed May 23 19:55:47 2018
(r334114)
+++ head/share/man/man4/usb_template.4  Wed May 23 20:06:04 2018
(r334115)
@@ -23,7 +23,7 @@
 .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 .\" SUCH DAMAGE.
 .\"
-.Dd May 17, 2018
+.Dd May 23, 2018
 .Dt USB_TEMPLATE 4
 .Os
 .
@@ -100,6 +100,11 @@ tunables:
 .It Va hw.usb.template
 Currently selected template.
 Set to -1 to make the device disappear from the USB host point of view.
+.It Va hw.usb.template_power
+USB bus power consumption in mA.
+Must be between 0 and 500.
+Setting to 0 marks the device as self-powered.
+Defaults to 500mA.
 .It Va hw.usb.templates.N
 Configuration for template number
 .Va N .

Modified: head/sys/dev/usb/template/usb_template.c
==
--- head/sys/dev/usb/template/usb_template.cWed May 23 19:55:47 2018
(r334114)
+++ head/sys/dev/usb/template/usb_template.cWed May 23 20:06:04 2018
(r334115)
@@ -76,14 +76,12 @@
 #include 
 #endif /* USB_GLOBAL_INCLUDE_FILE */
 
-SYSCTL_NODE(_hw_usb, OID_AUTO, templates, CTLFLAG_RW, 0,
-"USB device side templates");
-
 MODULE_DEPEND(usb_template, usb, 1, 1, 1);
 MODULE_VERSION(usb_template, 1);
 
 /* function prototypes */
 
+static int sysctl_hw_usb_template_power(SYSCTL_HANDLER_ARGS);
 static voidusb_make_raw_desc(struct usb_temp_setup *, const uint8_t *);
 static voidusb_make_endpoint_desc(struct usb_temp_setup *,
const struct usb_temp_endpoint_desc *);
@@ -117,6 +115,33 @@ static usb_error_t usb_temp_setup_by_index(struct usb_
uint16_t index);
 static voidusb_temp_init(void *);
 
+SYSCTL_NODE(_hw_usb, OID_AUTO, templates, CTLFLAG_RW, 0,
+"USB device side templates");
+SYSCTL_PROC(_hw_usb, OID_AUTO, template_power,
+CTLTYPE_INT | CTLFLAG_RWTUN | CTLFLAG_MPSAFE,
+NULL, 0, sysctl_hw_usb_template_power,
+"I", "USB bus power consumption in mA");
+
+static int usb_template_power = 500;   /* 500mA */
+
+static int
+sysctl_hw_usb_template_power(SYSCTL_HANDLER_ARGS)
+{
+   int error, val;
+
+   val = usb_template_power;
+   error = sysctl_handle_int(oidp, , 0, req);
+   if (error != 0 || req->newptr == NULL)
+   return (error);
+
+   if (val < 0 || val > 500)
+   return (EINVAL);
+
+   usb_template_power = val;
+
+   return (0);
+}
+
 /**
  * usb_decode_str_desc
  *
@@ -426,6 +451,7 @@ usb_make_config_desc(struct usb_temp_setup *temp,
struct usb_config_descriptor *cd;
const struct usb_temp_interface_desc **tid;
uint16_t old_size;
+   int power;
 
/* Reserve memory */
 
@@ -463,13 +489,16 @@ usb_make_config_desc(struct usb_temp_setup *temp,
cd->bConfigurationValue = temp->bConfigurationValue;
cd->iConfiguration = tcd->iConfiguration;
cd->bmAttributes = tcd->bmAttributes;
-   cd->bMaxPower = tcd->bMaxPower;
-   cd->bmAttributes |= (UC_REMOTE_WAKEUP | UC_BUS_POWERED);
 
-   if (temp->self_powered) {
-   cd->bmAttributes |= UC_SELF_POWERED;
-   } else {
+   power = usb_template_power;
+   cd->bMaxPower = power / 2; /* 2 mA units */
+   cd->bmAttributes |= UC_REMOTE_WAKEUP;
+   if (power > 0) {
+   cd->bmAttributes |= UC_BUS_POWERED;
cd->bmAttributes &= ~UC_SELF_POWERED;
+   } else {
+   cd->bmAttributes &= ~UC_BUS_POWERED;
+   cd->bmAttributes |= UC_SELF_POWERED;
}
}
 }

Modified: head/sys/dev/usb/template/usb_template_audio.c

svn commit: r334114 - in head: sys/sys usr.sbin/pmcstat

[Matt Macy]

Author: mmacy
Date: Wed May 23 19:55:47 2018
New Revision: 334114
URL: https://svnweb.freebsd.org/changeset/base/334114

Log:
  pmc: bump PMC major version to reflect ABI breakage and make warning not 
require verbose

Modified:
  head/sys/sys/pmc.h
  head/usr.sbin/pmcstat/pmcstat_log.c

Modified: head/sys/sys/pmc.h
==
--- head/sys/sys/pmc.h  Wed May 23 19:17:17 2018(r334113)
+++ head/sys/sys/pmc.h  Wed May 23 19:55:47 2018(r334114)
@@ -61,7 +61,7 @@
  *
  * The patch version is incremented for every bug fix.
  */
-#definePMC_VERSION_MAJOR   0x03
+#definePMC_VERSION_MAJOR   0x04
 #definePMC_VERSION_MINOR   0x01
 #definePMC_VERSION_PATCH   0x
 

Modified: head/usr.sbin/pmcstat/pmcstat_log.c
==
--- head/usr.sbin/pmcstat/pmcstat_log.c Wed May 23 19:17:17 2018
(r334113)
+++ head/usr.sbin/pmcstat/pmcstat_log.c Wed May 23 19:55:47 2018
(r334114)
@@ -406,7 +406,7 @@ pmcstat_print_log(void)
ev.pl_u.pl_i.pl_version,
pmc_name_of_cputype(ev.pl_u.pl_i.pl_arch));
if ((ev.pl_u.pl_i.pl_version & 0xFF00) !=
-   PMC_VERSION_MAJOR << 24 && args.pa_verbosity > 0)
+   PMC_VERSION_MAJOR << 24)
warnx(
 "WARNING: Log version 0x%x != expected version 0x%x.",
ev.pl_u.pl_i.pl_version, PMC_VERSION);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333388 - in head: . share/man/man4 sys/confsys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/toolstools/tools/nxge usr.sbin/bsdconfig/share

[Eugene Grosbein]

24.05.2018 2:30, Cy Schubert wrote:

> Except for old computers and old software that segfaults on 64-bit, how many 
> people still use i386?
> 
> Full disclosure: I'd like to see i386 deorbited before I retire.

Plese don't. I routinely use FreeBSD11/i386 for cheap VPS hosts having less 
than 2G memory
because amd64 has noticeable overhead. I even have ZFS-only i386 VPS, here is 
live example with 1G only:

Mem: 10M Active, 69M Inact, 230M Wired, 685M Free
ARC: 75M Total, 1953K MFU, 31M MRU, 172K Anon, 592K Header, 42M Other
 3500K Compressed, 29M Uncompressed, 8.61:1 Ratio
Swap: 1024M Total, 1024M Free

The VPS has only 20G of disk space and ZFS compression gives
compressratio 2.22x for ports, 2.51x for src, 2.29x for obj
and 1.95x for installed i386 system plus other software and data.

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334074 - head/sys/sys

[Matthew Macy]

Thanks.

On Wed, May 23, 2018 at 11:40 AM, Mark Linimon  wrote:
> On Wed, May 23, 2018 at 09:56:00AM -0700, Matthew Macy wrote:
>> Thanks updated for 1200064. Someone(tm) needs to do 1200063.
>
> done.
>
> mcl
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r333388 - in head: . share/man/man4 sys/confsys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/toolstools/tools/nxge usr.sbin/bsdconfig/share

[Cy Schubert]

Except for old computers and old software that segfaults on 64-bit, how many 
people still use i386?

Full disclosure: I'd like to see i386 deorbited before I retire.

---
Sent using a tiny phone keyboard.
Apologies for any typos and autocorrect.
Also, this old phone only supports top post. Apologies.

Cy Schubert
 or 
The need of the many outweighs the greed of the few.
---

-Original Message-
From: Stefan Esser
Sent: 23/05/2018 11:44
To: rgri...@freebsd.org; Mark Linimon
Cc: Gleb Smirnoff; Sean Bruno; svn-src-h...@freebsd.org; 
svn-src-all@freebsd.org; src-committ...@freebsd.org
Subject: Re: svn commit: r88 - in head: . share/man/man4 
sys/confsys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys 
tools/toolstools/tools/nxge usr.sbin/bsdconfig/share

Am 23.05.18 um 20:14 schrieb Rodney W. Grimes:
>> On Wed, May 23, 2018 at 10:41:17AM -0700, Gleb Smirnoff wrote:
>>> If end of sales and support is enough to remove 10g driver from the kernel,
>>> can we please delete all 10Mbit, 100Mbit 10+ year old drivers from the 
>>> kernel?
>>
>> Depends on how many existing users we want to screw over.  Not everyone
>> replaces all their hardware every 2 years, folks.
> 
> And some of us buy 2 year old hardware because it is cheap,
> and serves our needs just fine.   Even 8 year old servers
> make usable machines today.
> 
>> The difference is that the Exar chips failed in the marketplace; very
>> few seem to have made it out into the wild.
>>
>> Given, 10Mbit-only things are way past their sell-by date.
> 
> Do we even have any 10Mbit only drivers?  I think that all the
> 10mbit drivers also support 100mbit devices, but maybe there
> are some odd cases I cant remeber.

AFAIK and FWIW:

ed(4), le(4) on amd64 and on i386 (ISA and PCI)
ex(4), ep(4) on i386 (ISA and PCcard)

Regards, STefan

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334113 - in head: share/misc usr.bin/calendar/calendars

[Leandro Lupori]

Author: luporl
Date: Wed May 23 19:17:17 2018
New Revision: 334113
URL: https://svnweb.freebsd.org/changeset/base/334113

Log:
  Adding myself to committers-src.dot and calendar.freebsd
  
  Approved by:  jhibbits (mentor)

Modified:
  head/share/misc/committers-src.dot
  head/usr.bin/calendar/calendars/calendar.freebsd

Modified: head/share/misc/committers-src.dot
==
--- head/share/misc/committers-src.dot  Wed May 23 19:07:03 2018
(r334112)
+++ head/share/misc/committers-src.dot  Wed May 23 19:17:17 2018
(r334113)
@@ -238,6 +238,7 @@ leitao [label="Breno Leitao\nlei...@freebsd.org\n2018/
 lidl [label="Kurt Lidl\nl...@freebsd.org\n2015/10/21"]
 loos [label="Luiz Otavio O Souza\nl...@freebsd.org\n2013/07/03"]
 lstewart [label="Lawrence Stewart\nlstew...@freebsd.org\n2008/10/06"]
+luporl [label="Leandro Lupori\nlup...@freebsd.org\n2018/05/21"]
 manu [label="Emmanuel Vadot\nm...@freebsd.org\n2016/04/24"]
 marcel [label="Marcel Moolenaar\nmar...@freebsd.org\n1999/07/03"]
 marius [label="Marius Strobl\nmar...@freebsd.org\n2004/04/17"]
@@ -591,6 +592,7 @@ jhb -> rpokala
 jhb -> arichardson
 
 jhibbits -> leitao
+jhibbits -> luporl
 
 jimharris -> carl
 
@@ -713,6 +715,7 @@ njl -> sepotvin
 nwhitehorn -> andreast
 nwhitehorn -> jhibbits
 nwhitehorn -> leitao
+nwhitehorn -> luporl
 
 obrien -> benno
 obrien -> groudier

Modified: head/usr.bin/calendar/calendars/calendar.freebsd
==
--- head/usr.bin/calendar/calendars/calendar.freebsdWed May 23 19:07:03 
2018(r334112)
+++ head/usr.bin/calendar/calendars/calendar.freebsdWed May 23 19:17:17 
2018(r334113)
@@ -176,6 +176,7 @@
 05/09  Daniel Eischen  born in Syracuse, New York, 
United States, 1963
 05/09  Aaron Dalton  born in Boise, Idaho, United States, 
1973
 05/09  Jase Thew  born in Abergavenny, Gwent, United 
Kingdom, 1974
+05/09  Leandro Lupori  born in Sao Paulo, Sao Paulo, 
Brazil, 1983
 05/10  Markus Brueffer  born in Gronau, 
Nordrhein-Westfalen, Germany, 1977
 05/11  Kurt Lidl  born in Rockville, Maryland, United 
States, 1968
 05/11  Jesus Rodriguez  born in Barcelona, Spain, 1972
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333388 - in head: . share/man/man4 sys/conf sys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/tools tools/tools/nxge usr.sbin/bsdconfig/share

[Rodney W. Grimes]

> Am 23.05.18 um 20:14 schrieb Rodney W. Grimes:
> >> On Wed, May 23, 2018 at 10:41:17AM -0700, Gleb Smirnoff wrote:
> >>> If end of sales and support is enough to remove 10g driver from the 
> >>> kernel,
> >>> can we please delete all 10Mbit, 100Mbit 10+ year old drivers from the 
> >>> kernel?
> >>
> >> Depends on how many existing users we want to screw over.  Not everyone
> >> replaces all their hardware every 2 years, folks.
> > 
> > And some of us buy 2 year old hardware because it is cheap,
> > and serves our needs just fine.   Even 8 year old servers
> > make usable machines today.
> > 
> >> The difference is that the Exar chips failed in the marketplace; very
> >> few seem to have made it out into the wild.
> >>
> >> Given, 10Mbit-only things are way past their sell-by date.
> > 
> > Do we even have any 10Mbit only drivers?  I think that all the
> > 10mbit drivers also support 100mbit devices, but maybe there
> > are some odd cases I cant remeber.
> 
> AFAIK and FWIW:
> 
> ed(4), le(4) on amd64 and on i386 (ISA and PCI)

ed(4) has many 100 mbit cards.
I recall recently booting something that showed up with an ed0:

le(4) has some 100 mbit cards.  Mostly supersceded by lnc(4)

> ex(4), ep(4) on i386 (ISA and PCcard)
These are truely dead, IMHO.


-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333388 - in head: . share/man/man4 sys/conf sys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/tools tools/tools/nxge usr.sbin/bsdconfig/share

[Bjoern A. Zeeb]

On 23 May 2018, at 18:20, Brooks Davis wrote:


On Wed, May 23, 2018 at 10:41:17AM -0700, Gleb Smirnoff wrote:

On Tue, May 08, 2018 at 09:14:29PM +, Sean Bruno wrote:
S> Log:
S>   nxge(4):
S>   Remove nxge(4) and associated man page and tools in FreeBSD 
12.0.

...
S> +20180508:
S> +	The nxge(4) driver has been removed.  This driver was for PCI-X 
10g
S> +	cards made by s2io/Neterion.  The company was aquired by Exar 
and
S> +	no longer sells or supports Ethernet products.  If you have 
device

S> + nxge in your kernel config file it must be removed.
S> +

If end of sales and support is enough to remove 10g driver from the 
kernel,
can we please delete all 10Mbit, 100Mbit 10+ year old drivers from 
the kernel?


It's probably a good idea to add deprecation notices for them now and
merge for 11 to find out which ones still have users.  Someone on IRC
mentioned that FreeNAS removed them and ended up restoring one, but I
don't remember which one it was.

My gut feeling is that we're a bit late in the game for doing a mass
removal for 12, but we should definitely do so for 13.


I’d be very careful.  I can still buy a lot of 100Mbit/s cards and you 
constantly find them on new SoCs still which don’t do Gbit/s.  Also 
there’s a lot of legacy hw floating around for some of them.  12 
definitively seems to be too short term.


/bz
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334073 - head

[Eitan Adler]

On 23 May 2018 at 09:27, John Baldwin  wrote:
> On Wednesday, May 23, 2018 04:09:01 AM Eitan Adler wrote:
>> Author: eadler
>> Date: Wed May 23 04:09:01 2018
>> New Revision: 334073
>> URL: https://svnweb.freebsd.org/changeset/base/334073
>>
>> Log:
>>   README: Reduce the textdump; describe the project
>>
>>   Rework the README to make it a little easier for new users. This is the
>>   first file many will see when persuing the FreeBSD source code so
>>
>>   - remove some of the text describes how to build. This is better covered
>>   in the linked documentation.
>>   - add a small blurb for what FreeBSD is. Some users might find this
>>   document through features such as github search so they may not even
>>   know what the project is
>>
>>   generally, gear this file for the new, accidental, or casual user rather
>>   than towards someone seeking fuller documentation.
>>
>> Modified:
>>   head/README
>>   head/README.md
>>
>> Modified: head/README
>> ==
>> --- head/README   Wed May 23 03:41:22 2018(r334072)
>> +++ head/README   Wed May 23 04:09:01 2018(r334073)
>> @@ -2,35 +2,25 @@ This is the top level of the FreeBSD source directory.
>> -
>> -The kernel configuration files reside in the sys//conf
>> -sub-directory.  GENERIC is the default configuration used in release builds.
>> -NOTES contains entries and documentation for all possible
>> -devices, not just those commonly used.
>
> I do think this paragraph is still useful as part of the Source Roadmap and
> not really part of the build instructions.

I added a reference to sys//conf to the bottom of the
README.Adding something about NOTES might be helpful, but IMHO closer
to the build.



-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334112 - in head/sys: arm64/rockchip/clk conf

[Emmanuel Vadot]

Author: manu
Date: Wed May 23 19:07:03 2018
New Revision: 334112
URL: https://svnweb.freebsd.org/changeset/base/334112

Log:
  arm64: rockchip: Add proper armclock support
  
  The core clock (armclk) on RockChip SoC is special.
  It can derive it's clock from many PLLs but RockChip recommand to do it
  from "apll" on old SoC and "npll" on new SoC. The reason for choosing npll
  is that it's have less jitter and is more close to the arm core on the SoC.
  r14 added the core clock as a composite clock but due to it's specials
  property we need to deal with it differently.
  A new rk_clk_armclk type is added for this and it supports only the "npll"
  as we don't run on old RockChip SoC that only have the "apll".
  It will always reparent to "npll" and set the frequency according to a rate
  table that is known to be good.
  For now we set the "npll" to the desired frequency and just set the core clk
  divider to 1 as its parent it just used for the core clk.

Added:
  head/sys/arm64/rockchip/clk/rk_clk_armclk.c   (contents, props changed)
  head/sys/arm64/rockchip/clk/rk_clk_armclk.h   (contents, props changed)
Modified:
  head/sys/arm64/rockchip/clk/rk3328_cru.c
  head/sys/arm64/rockchip/clk/rk_cru.c
  head/sys/arm64/rockchip/clk/rk_cru.h
  head/sys/conf/files.arm64

Modified: head/sys/arm64/rockchip/clk/rk3328_cru.c
==
--- head/sys/arm64/rockchip/clk/rk3328_cru.cWed May 23 17:55:30 2018
(r334111)
+++ head/sys/arm64/rockchip/clk/rk3328_cru.cWed May 23 19:07:03 2018
(r334112)
@@ -593,9 +593,60 @@ static struct rk_clk_composite_def aclk_bus_pre = {
.flags = RK_CLK_COMPOSITE_HAVE_MUX | RK_CLK_COMPOSITE_HAVE_GATE,
 };
 
+static struct rk_clk_armclk_rates rk3328_armclk_rates[] = {
+   {
+   .freq = 129600,
+   .div = 1,
+   },
+   {
+   .freq = 12,
+   .div = 1,
+   },
+   {
+   .freq = 110400,
+   .div = 1,
+   },
+   {
+   .freq = 100800,
+   .div = 1,
+   },
+   {
+   .freq = 91200,
+   .div = 1,
+   },
+   {
+   .freq = 81600,
+   .div = 1,
+   },
+   {
+   .freq = 69600,
+   .div = 1,
+   },
+   {
+   .freq = 6,
+   .div = 1,
+   },
+   {
+   .freq = 40800,
+   .div = 1,
+   },
+   {
+   .freq = 31200,
+   .div = 1,
+   },
+   {
+   .freq = 21600,
+   .div = 1,
+   },
+   {
+   .freq = 9600,
+   .div = 1,
+   },
+};
+
 #defineARMCLK  6
 static const char *armclk_parents[] = {"apll", "gpll", "dpll", "npll" };
-static struct rk_clk_composite_def armclk = {
+static struct rk_clk_armclk_def armclk = {
.clkdef = {
.id = ARMCLK,
.name = "armclk",
@@ -610,6 +661,11 @@ static struct rk_clk_composite_def armclk = {
.div_width = 5,
 
.flags = RK_CLK_COMPOSITE_HAVE_MUX,
+   .main_parent = 3, /* npll */
+   .alt_parent = 0, /* apll */
+
+   .rates = rk3328_armclk_rates,
+   .nrates = nitems(rk3328_armclk_rates),
 };
 
 /* CRU_CLKSEL_CON1 */
@@ -825,15 +881,16 @@ static struct rk_clk rk3328_clks[] = {
},
{
.type = RK_CLK_COMPOSITE,
-   .clk.composite = 
-   },
-   {
-   .type = RK_CLK_COMPOSITE,
.clk.composite = _bus_pre
},
{
.type = RK_CLK_COMPOSITE,
.clk.composite = _bus_pre
+   },
+
+   {
+   .type = RK_CLK_ARMCLK,
+   .clk.armclk = ,
},
 
{

Added: head/sys/arm64/rockchip/clk/rk_clk_armclk.c
==
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ head/sys/arm64/rockchip/clk/rk_clk_armclk.c Wed May 23 19:07:03 2018
(r334112)
@@ -0,0 +1,237 @@
+/*-
+ * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
+ *
+ * Copyright (c) 2018 Emmanuel Vadot 
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
+ * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED 

Re: svn commit: r333388 - in head: . share/man/man4 sys/conf sys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/tools tools/tools/nxge usr.sbin/bsdconfig/share

[Warner Losh]

On Wed, May 23, 2018, 12:44 PM Stefan Esser  wrote:

> Am 23.05.18 um 20:14 schrieb Rodney W. Grimes:
> >> On Wed, May 23, 2018 at 10:41:17AM -0700, Gleb Smirnoff wrote:
> >>> If end of sales and support is enough to remove 10g driver from the
> kernel,
> >>> can we please delete all 10Mbit, 100Mbit 10+ year old drivers from the
> kernel?
> >>
> >> Depends on how many existing users we want to screw over.  Not everyone
> >> replaces all their hardware every 2 years, folks.
> >
> > And some of us buy 2 year old hardware because it is cheap,
> > and serves our needs just fine.   Even 8 year old servers
> > make usable machines today.
> >
> >> The difference is that the Exar chips failed in the marketplace; very
> >> few seem to have made it out into the wild.
> >>
> >> Given, 10Mbit-only things are way past their sell-by date.
> >
> > Do we even have any 10Mbit only drivers?  I think that all the
> > 10mbit drivers also support 100mbit devices, but maybe there
> > are some odd cases I cant remeber.
>
> AFAIK and FWIW:
>
> ed(4), le(4) on amd64 and on i386 (ISA and PCI)
> ex(4), ep(4) on i386 (ISA and PCcard)
>

My plans are to retire PC Card and these drivers in 13. Machines that have
this hardware still run 12 OK. Packages make them upgradable still, but its
clear the hand writing is on the wall.

Ed and ep also support 100M, but are unable to do line rate.

Warner

Warner

>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333388 - in head: . share/man/man4 sys/conf sys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/tools tools/tools/nxge usr.sbin/bsdconfig/share

[Stefan Esser]

Am 23.05.18 um 20:14 schrieb Rodney W. Grimes:
>> On Wed, May 23, 2018 at 10:41:17AM -0700, Gleb Smirnoff wrote:
>>> If end of sales and support is enough to remove 10g driver from the kernel,
>>> can we please delete all 10Mbit, 100Mbit 10+ year old drivers from the 
>>> kernel?
>>
>> Depends on how many existing users we want to screw over.  Not everyone
>> replaces all their hardware every 2 years, folks.
> 
> And some of us buy 2 year old hardware because it is cheap,
> and serves our needs just fine.   Even 8 year old servers
> make usable machines today.
> 
>> The difference is that the Exar chips failed in the marketplace; very
>> few seem to have made it out into the wild.
>>
>> Given, 10Mbit-only things are way past their sell-by date.
> 
> Do we even have any 10Mbit only drivers?  I think that all the
> 10mbit drivers also support 100mbit devices, but maybe there
> are some odd cases I cant remeber.

AFAIK and FWIW:

ed(4), le(4) on amd64 and on i386 (ISA and PCI)
ex(4), ep(4) on i386 (ISA and PCcard)

Regards, STefan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334073 - head

[John Baldwin]

On Wednesday, May 23, 2018 04:09:01 AM Eitan Adler wrote:
> Author: eadler
> Date: Wed May 23 04:09:01 2018
> New Revision: 334073
> URL: https://svnweb.freebsd.org/changeset/base/334073
> 
> Log:
>   README: Reduce the textdump; describe the project
>   
>   Rework the README to make it a little easier for new users. This is the
>   first file many will see when persuing the FreeBSD source code so
>   
>   - remove some of the text describes how to build. This is better covered
>   in the linked documentation.
>   - add a small blurb for what FreeBSD is. Some users might find this
>   document through features such as github search so they may not even
>   know what the project is
>   
>   generally, gear this file for the new, accidental, or casual user rather
>   than towards someone seeking fuller documentation.
> 
> Modified:
>   head/README
>   head/README.md
> 
> Modified: head/README
> ==
> --- head/README   Wed May 23 03:41:22 2018(r334072)
> +++ head/README   Wed May 23 04:09:01 2018(r334073)
> @@ -2,35 +2,25 @@ This is the top level of the FreeBSD source directory.
> -
> -The kernel configuration files reside in the sys//conf
> -sub-directory.  GENERIC is the default configuration used in release builds.
> -NOTES contains entries and documentation for all possible
> -devices, not just those commonly used.

I do think this paragraph is still useful as part of the Source Roadmap and
not really part of the build instructions.

> -
> -
>  Source Roadmap:
>  ---
>  
> @@ -69,6 +59,8 @@ share   Shared resources.
>  standBoot loader sources.
>  
>  sys  Kernel sources.
> +
> +sys//conf Kernel configuration file
>  
>  testsRegression tests which can be run by Kyua.  See 
> tests/README
>   for additional information.
> 

-- 
John Baldwin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334074 - head/sys/sys

[Mark Linimon]

On Wed, May 23, 2018 at 09:56:00AM -0700, Matthew Macy wrote:
> Thanks updated for 1200064. Someone(tm) needs to do 1200063.

done.

mcl
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333388 - in head: . share/man/man4 sys/conf sys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/tools tools/tools/nxge usr.sbin/bsdconfig/share

[Mark Linimon]

On Wed, May 23, 2018 at 11:14:59AM -0700, Rodney W. Grimes wrote:
> And some of us buy 2 year old hardware because it is cheap,

Some of us don't have that kind of budget anymore.

mcl
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333388 - in head: . share/man/man4 sys/conf sys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/tools tools/tools/nxge usr.sbin/bsdconfig/share

[Warner Losh]

On Wed, May 23, 2018, 12:20 PM Brooks Davis  wrote:

> On Wed, May 23, 2018 at 10:41:17AM -0700, Gleb Smirnoff wrote:
> > On Tue, May 08, 2018 at 09:14:29PM +, Sean Bruno wrote:
> > S> Log:
> > S>   nxge(4):
> > S>   Remove nxge(4) and associated man page and tools in FreeBSD 12.0.
> > ...
> > S> +20180508:
> > S> +  The nxge(4) driver has been removed.  This driver was for PCI-X 10g
> > S> +  cards made by s2io/Neterion.  The company was aquired by Exar and
> > S> +  no longer sells or supports Ethernet products.  If you have device
> > S> +  nxge in your kernel config file it must be removed.
> > S> +
> >
> > If end of sales and support is enough to remove 10g driver from the
> kernel,
> > can we please delete all 10Mbit, 100Mbit 10+ year old drivers from the
> kernel?
>
> It's probably a good idea to add deprecation notices for them now and
> merge for 11 to find out which ones still have users.  Someone on IRC
> mentioned that FreeNAS removed them and ended up restoring one, but I
> don't remember which one it was.
>
> My gut feeling is that we're a bit late in the game for doing a mass
> removal for 12, but we should definitely do so for 13.
>

I'd planned on doing exactly this. There are also really old CAM drivers
that need to go so we can c lookean up other things...

I'd also planned on putting gone in 13 for pc card and cardbus stuff, which
is what's gating some nic drivers leaving...

Warner

>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333388 - in head: . share/man/man4 sys/conf sys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/tools tools/tools/nxge usr.sbin/bsdconfig/share

[Eugene Grosbein]

24.05.2018 1:14, Rodney W. Grimes wrote:

>> On Wed, May 23, 2018 at 10:41:17AM -0700, Gleb Smirnoff wrote:
>>> If end of sales and support is enough to remove 10g driver from the kernel,
>>> can we please delete all 10Mbit, 100Mbit 10+ year old drivers from the 
>>> kernel?
>>
>> Depends on how many existing users we want to screw over.  Not everyone
>> replaces all their hardware every 2 years, folks.
> 
> And some of us buy 2 year old hardware because it is cheap,
> and serves our needs just fine.   Even 8 year old servers
> make usable machines today.

My home router runs 11.1-STABLE/i386 using PC-104 form factor system from the 
year 2007
having AMD Geode processor not capable of 64 bit mode, RAM maxed at 1GB 
(2x512MB DIMMs),
UDMA100 IDE/PATA controller and two 100Mbit vr(4) vlan-capable network 
interfaces.

It can route/nat PPPoE connection at 100M wire speed, performs IPSEC at 
33Mbit/s using
cryptodev/onboard AES accelerator while acting as WiFi access point same time
using multi-AP capable AR5212 ath(4) miniPCI (not miniPCI-E) card.

And I love FreeBSD for that.

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333388 - in head: . share/man/man4 sys/conf sys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/tools tools/tools/nxge usr.sbin/bsdconfig/share

[Brooks Davis]

On Wed, May 23, 2018 at 10:41:17AM -0700, Gleb Smirnoff wrote:
> On Tue, May 08, 2018 at 09:14:29PM +, Sean Bruno wrote:
> S> Log:
> S>   nxge(4):
> S>   Remove nxge(4) and associated man page and tools in FreeBSD 12.0.
> ...
> S> +20180508:
> S> +  The nxge(4) driver has been removed.  This driver was for PCI-X 10g
> S> +  cards made by s2io/Neterion.  The company was aquired by Exar and
> S> +  no longer sells or supports Ethernet products.  If you have device
> S> +  nxge in your kernel config file it must be removed.
> S> +
> 
> If end of sales and support is enough to remove 10g driver from the kernel,
> can we please delete all 10Mbit, 100Mbit 10+ year old drivers from the kernel?

It's probably a good idea to add deprecation notices for them now and
merge for 11 to find out which ones still have users.  Someone on IRC
mentioned that FreeNAS removed them and ended up restoring one, but I
don't remember which one it was.

My gut feeling is that we're a bit late in the game for doing a mass
removal for 12, but we should definitely do so for 13.

-- Brooks


signature.asc
Description: PGP signature

Re: svn commit: r333388 - in head: . share/man/man4 sys/conf sys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/tools tools/tools/nxge usr.sbin/bsdconfig/share

[Rodney W. Grimes]

> On Wed, May 23, 2018 at 10:41:17AM -0700, Gleb Smirnoff wrote:
> > If end of sales and support is enough to remove 10g driver from the kernel,
> > can we please delete all 10Mbit, 100Mbit 10+ year old drivers from the 
> > kernel?
> 
> Depends on how many existing users we want to screw over.  Not everyone
> replaces all their hardware every 2 years, folks.

And some of us buy 2 year old hardware because it is cheap,
and serves our needs just fine.   Even 8 year old servers
make usable machines today.

> The difference is that the Exar chips failed in the marketplace; very
> few seem to have made it out into the wild.
> 
> Given, 10Mbit-only things are way past their sell-by date.

Do we even have any 10Mbit only drivers?  I think that all the
10mbit drivers also support 100mbit devices, but maybe there
are some odd cases I cant remeber.

I do agree that we need to be very carefull about killing "dead wood",
and have advocated proper notice as a first order to helping with that.

I think we also need to be able to back track if we find we have
made a mistake.

-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334074 - head/sys/sys

[Mark Linimon]

On Wed, May 23, 2018 at 12:05:24PM -0600, Ian Lepore wrote:
> Well, they're supposed to be.

>From my own experience, they are often not.

> I think it would be more likely to happen if you didn't have to get
> intimate with xml code to add a simple note to a file.

It's cut-and-paste.

Or, it's easy enough to ask a doc committer to build-test it for you.

/me off to update his build tree

mcl
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333388 - in head: . share/man/man4 sys/conf sys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/tools tools/tools/nxge usr.sbin/bsdconfig/share

[Mark Linimon]

On Wed, May 23, 2018 at 10:41:17AM -0700, Gleb Smirnoff wrote:
> If end of sales and support is enough to remove 10g driver from the kernel,
> can we please delete all 10Mbit, 100Mbit 10+ year old drivers from the kernel?

Depends on how many existing users we want to screw over.  Not everyone
replaces all their hardware every 2 years, folks.

The difference is that the Exar chips failed in the marketplace; very
few seem to have made it out into the wild.

Given, 10Mbit-only things are way past their sell-by date.

mcl
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334074 - head/sys/sys

[Ian Lepore]

On Wed, 2018-05-23 at 09:43 -0700, John Baldwin wrote:
> On Wednesday, May 23, 2018 06:15:55 AM Matt Macy wrote:
> > 
> > Author: mmacy
> > Date: Wed May 23 06:15:55 2018
> > New Revision: 334074
> > URL: https://svnweb.freebsd.org/changeset/base/334074
> > 
> > Log:
> >   Bump FreeBSD_version after r333813
> > 
> > Modified:
> >   head/sys/sys/param.h
> FYI, these values are documented in
> head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml in
> the doc
> repository.
> 

Well, they're supposed to be. Does anybody ever actually do that? I
think it would be more likely to happen if you didn't have to get
intimate with xml code to add a simple note to a file.

-- Ian
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333388 - in head: . share/man/man4 sys/conf sys/dev/nxge sys/modules sys/modules/nxge tools/kerneldoc/subsys tools/tools tools/tools/nxge usr.sbin/bsdconfig/share

[Gleb Smirnoff]

On Tue, May 08, 2018 at 09:14:29PM +, Sean Bruno wrote:
S> Log:
S>   nxge(4):
S>   Remove nxge(4) and associated man page and tools in FreeBSD 12.0.
...
S> +20180508:
S> +The nxge(4) driver has been removed.  This driver was for PCI-X 10g
S> +cards made by s2io/Neterion.  The company was aquired by Exar and
S> +no longer sells or supports Ethernet products.  If you have device
S> +nxge in your kernel config file it must be removed.
S> +

If end of sales and support is enough to remove 10g driver from the kernel,
can we please delete all 10Mbit, 100Mbit 10+ year old drivers from the kernel?

-- 
Gleb Smirnoff
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334111 - head/lib/libc/sys

[Konstantin Belousov]

Author: kib
Date: Wed May 23 17:55:30 2018
New Revision: 334111
URL: https://svnweb.freebsd.org/changeset/base/334111

Log:
  Note that PT_SETSTEP is auto-cleared.
  
  Wording and reviewed by:  jhb
  Sponsored by: The FreeBSD Foundation
  MFC after:3 days
  Differential revision:https://reviews.freebsd.org/D15054

Modified:
  head/lib/libc/sys/ptrace.2

Modified: head/lib/libc/sys/ptrace.2
==
--- head/lib/libc/sys/ptrace.2  Wed May 23 17:44:29 2018(r334110)
+++ head/lib/libc/sys/ptrace.2  Wed May 23 17:55:30 2018(r334111)
@@ -2,7 +2,7 @@
 .\"$NetBSD: ptrace.2,v 1.2 1995/02/27 12:35:37 cgd Exp $
 .\"
 .\" This file is in the public domain.
-.Dd December 1, 2017
+.Dd May 22, 2018
 .Dt PTRACE 2
 .Os
 .Sh NAME
@@ -606,6 +606,7 @@ The return value from
 is the count of array entries filled in.
 .It Dv PT_SETSTEP
 This request will turn on single stepping of the specified process.
+Stepping is automatically disabled when a single step trap is caught.
 .It Dv PT_CLEARSTEP
 This request will turn off single stepping of the specified process.
 .It Dv PT_SUSPEND
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334110 - head/sys/dev/hwpmc

[Matt Macy]

Author: mmacy
Date: Wed May 23 17:44:29 2018
New Revision: 334110
URL: https://svnweb.freebsd.org/changeset/base/334110

Log:
  hwppmc: set threadid in callchain records - second part of r334108

Modified:
  head/sys/dev/hwpmc/hwpmc_logging.c
  head/sys/dev/hwpmc/hwpmc_mod.c

Modified: head/sys/dev/hwpmc/hwpmc_logging.c
==
--- head/sys/dev/hwpmc/hwpmc_logging.c  Wed May 23 17:30:23 2018
(r334109)
+++ head/sys/dev/hwpmc/hwpmc_logging.c  Wed May 23 17:44:29 2018
(r334110)
@@ -181,7 +181,7 @@ static struct mtx pmc_kthread_mtx;  /* sleep lock */
  * Assertions about the log file format.
  */
 
-CTASSERT(sizeof(struct pmclog_callchain) == 6*4 +
+CTASSERT(sizeof(struct pmclog_callchain) == 8*4 +
 PMC_CALLCHAIN_DEPTH_MAX*sizeof(uintfptr_t));
 CTASSERT(sizeof(struct pmclog_closelog) == 3*4);
 CTASSERT(sizeof(struct pmclog_dropnotify) == 3*4);
@@ -190,12 +190,12 @@ CTASSERT(sizeof(struct pmclog_map_in) == PATH_MAX +
 CTASSERT(offsetof(struct pmclog_map_in,pl_pathname) ==
 4*4 + sizeof(uintfptr_t));
 CTASSERT(sizeof(struct pmclog_map_out) == 4*4 + 2*sizeof(uintfptr_t));
-CTASSERT(sizeof(struct pmclog_pcsample) == 6*4 + sizeof(uintfptr_t));
+CTASSERT(sizeof(struct pmclog_pcsample) == 8*4 + sizeof(uintfptr_t));
 CTASSERT(sizeof(struct pmclog_pmcallocate) == 6*4);
 CTASSERT(sizeof(struct pmclog_pmcattach) == 5*4 + PATH_MAX);
 CTASSERT(offsetof(struct pmclog_pmcattach,pl_pathname) == 5*4);
 CTASSERT(sizeof(struct pmclog_pmcdetach) == 5*4);
-CTASSERT(sizeof(struct pmclog_proccsw) == 5*4 + 8);
+CTASSERT(sizeof(struct pmclog_proccsw) == 6*4 + 8);
 CTASSERT(sizeof(struct pmclog_procexec) == 5*4 + PATH_MAX +
 sizeof(uintfptr_t));
 CTASSERT(offsetof(struct pmclog_procexec,pl_pathname) == 5*4 +
@@ -907,8 +907,11 @@ pmclog_process_callchain(struct pmc *pm, struct pmc_sa
flags = PMC_CALLCHAIN_TO_CPUFLAGS(ps->ps_cpu,ps->ps_flags);
PMCLOG_RESERVE_SAFE(po, CALLCHAIN, recordlen);
PMCLOG_EMIT32(ps->ps_pid);
+   PMCLOG_EMIT32(ps->ps_tid);
PMCLOG_EMIT32(pm->pm_id);
PMCLOG_EMIT32(flags);
+   /* unused for now */
+   PMCLOG_EMIT32(0);
for (n = 0; n < ps->ps_nsamples; n++)
PMCLOG_EMITADDR(ps->ps_pc[n]);
PMCLOG_DESPATCH_SAFE(po);
@@ -1033,7 +1036,7 @@ pmclog_process_pmcdetach(struct pmc *pm, pid_t pid)
  */
 
 void
-pmclog_process_proccsw(struct pmc *pm, struct pmc_process *pp, pmc_value_t v)
+pmclog_process_proccsw(struct pmc *pm, struct pmc_process *pp, pmc_value_t v, 
struct thread *td)
 {
struct pmc_owner *po;
 
@@ -1049,6 +1052,7 @@ pmclog_process_proccsw(struct pmc *pm, struct pmc_proc
PMCLOG_EMIT32(pm->pm_id);
PMCLOG_EMIT64(v);
PMCLOG_EMIT32(pp->pp_proc->p_pid);
+   PMCLOG_EMIT32(td->td_tid);
PMCLOG_DESPATCH(po);
 }
 

Modified: head/sys/dev/hwpmc/hwpmc_mod.c
==
--- head/sys/dev/hwpmc/hwpmc_mod.c  Wed May 23 17:30:23 2018
(r334109)
+++ head/sys/dev/hwpmc/hwpmc_mod.c  Wed May 23 17:44:29 2018
(r334110)
@@ -1657,7 +1657,7 @@ pmc_process_csw_out(struct thread *td)
mtx_pool_unlock_spin(pmc_mtxpool, pm);
 
if (pm->pm_flags & PMC_F_LOG_PROCCSW)
-   pmclog_process_proccsw(pm, pp, tmp);
+   pmclog_process_proccsw(pm, pp, tmp, td);
}
}
 
@@ -4576,10 +4576,13 @@ pmc_process_interrupt(int cpu, int ring, struct pmc *p
counter_u64_add(pm->pm_runcount, 1);/* hold onto PMC */
 
ps->ps_pmc = pm;
-   if ((td = curthread) && td->td_proc)
-   ps->ps_pid = td->td_proc->p_pid;
-   else
-   ps->ps_pid = -1;
+   ps->ps_pid = -1;
+   ps->ps_tid = -1;
+   if ((td = curthread) != NULL) {
+   ps->ps_tid = td->td_tid;
+   if (td->td_proc)
+   ps->ps_pid = td->td_proc->p_pid;
+   }
ps->ps_cpu = cpu;
ps->ps_td = td;
ps->ps_flags = inuserspace ? PMC_CC_F_USERSPACE : 0;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334109 - head

[Matt Macy]

Author: mmacy
Date: Wed May 23 17:30:23 2018
New Revision: 334109
URL: https://svnweb.freebsd.org/changeset/base/334109

Log:
  UPDATING: note that the pmc callchain ABI has changed

Modified:
  head/UPDATING

Modified: head/UPDATING
==
--- head/UPDATING   Wed May 23 17:25:00 2018(r334108)
+++ head/UPDATING   Wed May 23 17:30:23 2018(r334109)
@@ -51,6 +51,12 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 12.x IS SLOW:
 
 ** SPECIAL WARNING: **
 
+20180523:
+   The on-disk format for hwpmc callchain records has changed to include
+   threadid corresponding to a given record. This changes the field 
offsets
+   and thus requires that libpmcstat be rebuilt before using a kernel
+   later than r334108.
+
 20180517:
The vxge(4) driver has been removed.  This driver was introduced into
HEAD one week before the Exar left the Ethernet market and is not
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334108 - in head: lib/libpmc lib/libpmcstat sys/sys usr.sbin/pmcstat

[Matt Macy]

Author: mmacy
Date: Wed May 23 17:25:00 2018
New Revision: 334108
URL: https://svnweb.freebsd.org/changeset/base/334108

Log:
  hwpmc: add thread id field to callchain and context switch records to allow 
filtering
  on thread in post-processing.
  
  To generate stacks for just ${THREADID}:
  
  pmcstat -R ${PREFIX}.pmcstat -L ${THREADID} -z100 -G ${PREFIX}.stacks
  
  Sponsored by: Limelight Networks

Modified:
  head/lib/libpmc/pmclog.c
  head/lib/libpmc/pmclog.h
  head/lib/libpmcstat/libpmcstat.h
  head/lib/libpmcstat/libpmcstat_logging.c
  head/sys/sys/pmc.h
  head/sys/sys/pmclog.h
  head/usr.sbin/pmcstat/pmcstat.c

Modified: head/lib/libpmc/pmclog.c
==
--- head/lib/libpmc/pmclog.cWed May 23 17:05:12 2018(r334107)
+++ head/lib/libpmc/pmclog.cWed May 23 17:25:00 2018(r334108)
@@ -326,8 +326,10 @@ pmclog_get_event(void *cookie, char **data, ssize_t *l
switch (ev->pl_type = PMCLOG_HEADER_TO_TYPE(h)) {
case PMCLOG_TYPE_CALLCHAIN:
PMCLOG_READ32(le,ev->pl_u.pl_cc.pl_pid);
+   PMCLOG_READ32(le,ev->pl_u.pl_cc.pl_tid);
PMCLOG_READ32(le,ev->pl_u.pl_cc.pl_pmcid);
PMCLOG_READ32(le,ev->pl_u.pl_cc.pl_cpuflags);
+   PMCLOG_READ32(le,ev->pl_u.pl_cc.pl_cpuflags2);
PMCLOG_GET_CALLCHAIN_SIZE(ev->pl_u.pl_cc.pl_npc,evlen);
for (npc = 0; npc < ev->pl_u.pl_cc.pl_npc; npc++)
PMCLOG_READADDR(le,ev->pl_u.pl_cc.pl_pc[npc]);
@@ -363,6 +365,7 @@ pmclog_get_event(void *cookie, char **data, ssize_t *l
PMCLOG_READADDR(le,ev->pl_u.pl_s.pl_pc);
PMCLOG_READ32(le,ev->pl_u.pl_s.pl_pmcid);
PMCLOG_READ32(le,ev->pl_u.pl_s.pl_usermode);
+   PMCLOG_READ32(le,ev->pl_u.pl_s.pl_tid);
break;
case PMCLOG_TYPE_PMCALLOCATE:
PMCLOG_READ32(le,ev->pl_u.pl_a.pl_pmcid);
@@ -393,6 +396,7 @@ pmclog_get_event(void *cookie, char **data, ssize_t *l
PMCLOG_READ32(le,ev->pl_u.pl_c.pl_pmcid);
PMCLOG_READ64(le,ev->pl_u.pl_c.pl_value);
PMCLOG_READ32(le,ev->pl_u.pl_c.pl_pid);
+   PMCLOG_READ32(le,ev->pl_u.pl_c.pl_tid);
break;
case PMCLOG_TYPE_PROCEXEC:
PMCLOG_GET_PATHLEN(pathlen,evlen,pmclog_procexec);

Modified: head/lib/libpmc/pmclog.h
==
--- head/lib/libpmc/pmclog.hWed May 23 17:05:12 2018(r334107)
+++ head/lib/libpmc/pmclog.hWed May 23 17:25:00 2018(r334108)
@@ -47,8 +47,10 @@ enum pmclog_state {
 
 struct pmclog_ev_callchain {
uint32_tpl_pid;
+   uint32_tpl_tid;
uint32_tpl_pmcid;
uint32_tpl_cpuflags;
+   uint32_tpl_cpuflags2;
uint32_tpl_npc;
uintfptr_t  pl_pc[PMC_CALLCHAIN_DEPTH_MAX];
 };
@@ -79,7 +81,9 @@ struct pmclog_ev_map_out {
 struct pmclog_ev_pcsample {
uintfptr_t  pl_pc;
pid_t   pl_pid;
+   pid_t   pl_tid;
pmc_id_tpl_pmcid;
+   uint32_tpl_flags;
uint32_tpl_usermode;
 };
 
@@ -110,6 +114,7 @@ struct pmclog_ev_pmcdetach {
 
 struct pmclog_ev_proccsw {
pid_t   pl_pid;
+   pid_t   pl_tid;
pmc_id_tpl_pmcid;
pmc_value_t pl_value;
 };

Modified: head/lib/libpmcstat/libpmcstat.h
==
--- head/lib/libpmcstat/libpmcstat.hWed May 23 17:05:12 2018
(r334107)
+++ head/lib/libpmcstat/libpmcstat.hWed May 23 17:25:00 2018
(r334108)
@@ -107,6 +107,7 @@ struct pmcstat_args {
 #defineFLAG_HAS_DURATION   0x0008  /* -l secs */
 #defineFLAG_DO_WIDE_GPROF_HC   0x0010  /* -e */
 #defineFLAG_SKIP_TOP_FN_RES0x0020  /* -I */
+#defineFLAG_FILTER_THREAD_ID   0x0040  /* -L */
 
int pa_required;/* required features */
int pa_pplugin; /* pre-processing plugin */
@@ -131,6 +132,7 @@ struct pmcstat_args {
int pa_topcolor;/* terminal support color */
int pa_mergepmc;/* merge PMC with same name */
double  pa_duration;/* time duration */
+   uint32_t pa_tid;
int pa_argc;
char**pa_argv;
STAILQ_HEAD(, pmcstat_ev) pa_events;

Modified: head/lib/libpmcstat/libpmcstat_logging.c
==
--- head/lib/libpmcstat/libpmcstat_logging.cWed May 23 17:05:12 2018
(r334107)
+++ head/lib/libpmcstat/libpmcstat_logging.cWed May 23 17:25:00 2018
(r334108)
@@ -313,6 +313,11 @@ 

Re: svn commit: r334054 - in head: sys/kern sys/netipsec tools/tools/crypto usr.bin/netstat

[Conrad Meyer]

On Wed, May 23, 2018 at 12:23 AM, Emeric POUPON
 wrote:
>> From: "Conrad Meyer" 
>
>> Can users control arbitrary key_allocsp() calls?  If so, it seems
>> concerning to expose hit/miss stats on cached security keys.
>
> I am not sure to understand, could you please tell more about what you mean?

If users can insert arbitrary keys into the cache, they can check the
hit/miss statistics to tell if that key was already present --
revealing key contents.  This would be a major problem.

https://security.stackexchange.com/questions/10617/what-is-a-cryptographic-oracle

Best,
Conrad
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334107 - head/lib/libthr

[John Baldwin]

Author: jhb
Date: Wed May 23 17:05:12 2018
New Revision: 334107
URL: https://svnweb.freebsd.org/changeset/base/334107

Log:
  Remove references to the LIBC_SCCS and SYSLIBC_SCCS C macros.
  
  This language dates back to when libthr was libc_r that included its own
  syscalls and replaced libc entirely.  It hasn't been relevant for a long
  time.

Modified:
  head/lib/libthr/Makefile

Modified: head/lib/libthr/Makefile
==
--- head/lib/libthr/MakefileWed May 23 17:02:12 2018(r334106)
+++ head/lib/libthr/MakefileWed May 23 17:05:12 2018(r334107)
@@ -3,10 +3,7 @@
 # All library objects contain FreeBSD revision strings by default; they may be
 # excluded as a space-saving measure.  To produce a library that does
 # not contain these strings, add -DSTRIP_FBSDID (see ) to CFLAGS
-# below.  Note, there are no IDs for syscall stubs whose sources are generated.
-# To included legacy CSRG sccsid strings, add -DLIBC_SCCS and -DSYSLIBC_SCCS
-# (for system call stubs) to CFLAGS below.  -DSYSLIBC_SCCS affects just the
-# system call stubs.
+# below.
 
 PACKAGE=   clibs
 SHLIBDIR?= /lib
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334106 - head/lib/libutil

[John Baldwin]

Author: jhb
Date: Wed May 23 17:02:12 2018
New Revision: 334106
URL: https://svnweb.freebsd.org/changeset/base/334106

Log:
  Use __SCCSID() for SCCS IDs.
  
  - Define NO__SCCSID in CFLAGS to preserve existing behavior of omitting
SCCS IDs by default.
  - While here, fix the $FreeBSD$ in pw_util.c to use __FBSDID.

Modified:
  head/lib/libutil/Makefile
  head/lib/libutil/login_tty.c
  head/lib/libutil/pty.c
  head/lib/libutil/pw_util.c
  head/lib/libutil/uucplock.c

Modified: head/lib/libutil/Makefile
==
--- head/lib/libutil/Makefile   Wed May 23 17:01:28 2018(r334105)
+++ head/lib/libutil/Makefile   Wed May 23 17:02:12 2018(r334106)
@@ -19,7 +19,7 @@ SRCS= _secure_path.c auth.c expand_number.c flopen.c f
stub.c trimdomain.c uucplock.c
 INCS=  libutil.h login_cap.h
 
-CFLAGS+= -DLIBC_SCCS
+CFLAGS+= -DNO__SCCSID
 
 .if ${MK_INET6_SUPPORT} != "no"
 CFLAGS+= -DINET6

Modified: head/lib/libutil/login_tty.c
==
--- head/lib/libutil/login_tty.cWed May 23 17:01:28 2018
(r334105)
+++ head/lib/libutil/login_tty.cWed May 23 17:02:12 2018
(r334106)
@@ -31,12 +31,7 @@
 
 #include 
 __FBSDID("$FreeBSD$");
-
-#if defined(LIBC_SCCS) && !defined(lint)
-#if 0
-static char sccsid[] = "@(#)login_tty.c8.1 (Berkeley) 6/4/93";
-#endif
-#endif /* LIBC_SCCS and not lint */
+__SCCSID("@(#)login_tty.c  8.1 (Berkeley) 6/4/93");
 
 #include 
 

Modified: head/lib/libutil/pty.c
==
--- head/lib/libutil/pty.c  Wed May 23 17:01:28 2018(r334105)
+++ head/lib/libutil/pty.c  Wed May 23 17:02:12 2018(r334106)
@@ -31,12 +31,7 @@
 
 #include 
 __FBSDID("$FreeBSD$");
-
-#if defined(LIBC_SCCS) && !defined(lint)
-#if 0
-static char sccsid[] = "@(#)pty.c  8.3 (Berkeley) 5/16/94";
-#endif
-#endif /* LIBC_SCCS and not lint */
+__SCCSID("@(#)pty.c8.3 (Berkeley) 5/16/94");
 
 #include 
 #include 

Modified: head/lib/libutil/pw_util.c
==
--- head/lib/libutil/pw_util.c  Wed May 23 17:01:28 2018(r334105)
+++ head/lib/libutil/pw_util.c  Wed May 23 17:02:12 2018(r334106)
@@ -36,13 +36,9 @@
  * SUCH DAMAGE.
  */
 
-#ifndef lint
-#if 0
-static const char sccsid[] = "@(#)pw_util.c8.3 (Berkeley) 4/2/94";
-#endif
-static const char rcsid[] =
-  "$FreeBSD$";
-#endif /* not lint */
+#include 
+__FBSDID("$FreeBSD$");
+__SCCSID("@(#)pw_util.c8.3 (Berkeley) 4/2/94");
 
 /*
  * This file is used by all the "password" programs; vipw(8), chpass(1),

Modified: head/lib/libutil/uucplock.c
==
--- head/lib/libutil/uucplock.c Wed May 23 17:01:28 2018(r334105)
+++ head/lib/libutil/uucplock.c Wed May 23 17:02:12 2018(r334106)
@@ -31,10 +31,7 @@
 
 #include 
 __FBSDID("$FreeBSD$");
-
-#ifndef lint
-static const char sccsid[] = "@(#)uucplock.c   8.1 (Berkeley) 6/6/93";
-#endif /* not lint */
+__SCCSID("@(#)uucplock.c   8.1 (Berkeley) 6/6/93");
 
 #include 
 #include 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334105 - head/lib/libmd

[Mark Johnston]

Author: markj
Date: Wed May 23 17:01:28 2018
New Revision: 334105
URL: https://svnweb.freebsd.org/changeset/base/334105

Log:
  Revert r334090.
  
  It causes the 32bit compat build of libmd to fail with:
  
  libmd/rmd160c.c:86:9: error: 'ripemd160_block' macro redefined
  #define ripemd160_block ripemd160_block_x86
  ^
  libmd/ripemd.h:122:9: note: previous definition is here
  #define ripemd160_block _libmd_ripemd160_block

Modified:
  head/lib/libmd/Makefile
  head/lib/libmd/mdXhl.c

Modified: head/lib/libmd/Makefile
==
--- head/lib/libmd/Makefile Wed May 23 17:00:05 2018(r334104)
+++ head/lib/libmd/Makefile Wed May 23 17:01:28 2018(r334105)
@@ -15,7 +15,7 @@ SRCS= md4c.c md5c.c md4hl.c md5hl.c \
 INCS=  md4.h md5.h ripemd.h sha.h sha256.h sha384.h sha512.h sha512t.h \
skein.h skein_port.h skein_freebsd.h skein_iv.h
 
-WARNS?=1
+WARNS?=0
 
 MAN+=  md4.3 md5.3 ripemd.3 sha.3 sha256.3 sha512.3 skein.3
 MLINKS+=md4.3 MD4Init.3 md4.3 MD4Update.3 md4.3 MD4Final.3

Modified: head/lib/libmd/mdXhl.c
==
--- head/lib/libmd/mdXhl.c  Wed May 23 17:00:05 2018(r334104)
+++ head/lib/libmd/mdXhl.c  Wed May 23 17:01:28 2018(r334105)
@@ -54,7 +54,8 @@ MDXFdChunk(int fd, char *buf, off_t ofs, off_t len)
 {
unsigned char buffer[16*1024];
MDX_CTX ctx;
-   int readrv;
+   struct stat stbuf;
+   int readrv, e;
off_t remain;
 
if (len < 0) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334104 - in head/sys: netinet sys

[Matt Macy]

Author: mmacy
Date: Wed May 23 17:00:05 2018
New Revision: 334104
URL: https://svnweb.freebsd.org/changeset/base/334104

Log:
  epoch: allow for conditionally asserting that the epoch context fields
  are unused by zeroing on INVARIANTS builds

Modified:
  head/sys/netinet/ip_divert.c
  head/sys/netinet/raw_ip.c
  head/sys/netinet/tcp_subr.c
  head/sys/netinet/udp_usrreq.c
  head/sys/sys/epoch.h

Modified: head/sys/netinet/ip_divert.c
==
--- head/sys/netinet/ip_divert.cWed May 23 16:31:46 2018
(r334103)
+++ head/sys/netinet/ip_divert.cWed May 23 17:00:05 2018
(r334104)
@@ -670,7 +670,7 @@ div_pcblist(SYSCTL_HANDLER_ARGS)
if (error)
return error;
 
-   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_WAITOK|M_ZERO);
+   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_EPOCH_CALL_WAITOK);
inp_list = il->il_inp_list;

INP_INFO_RLOCK(_divcbinfo);

Modified: head/sys/netinet/raw_ip.c
==
--- head/sys/netinet/raw_ip.c   Wed May 23 16:31:46 2018(r334103)
+++ head/sys/netinet/raw_ip.c   Wed May 23 17:00:05 2018(r334104)
@@ -1056,7 +1056,7 @@ rip_pcblist(SYSCTL_HANDLER_ARGS)
if (error)
return (error);
 
-   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_WAITOK|M_ZERO);
+   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_EPOCH_CALL_WAITOK);
inp_list = il->il_inp_list;
 
INP_INFO_RLOCK(_ripcbinfo);

Modified: head/sys/netinet/tcp_subr.c
==
--- head/sys/netinet/tcp_subr.c Wed May 23 16:31:46 2018(r334103)
+++ head/sys/netinet/tcp_subr.c Wed May 23 17:00:05 2018(r334104)
@@ -2151,7 +2151,7 @@ tcp_pcblist(SYSCTL_HANDLER_ARGS)
if (error)
return (error);
 
-   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_WAITOK|M_ZERO);
+   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_EPOCH_CALL_WAITOK);
inp_list = il->il_inp_list;
 
INP_INFO_WLOCK(_tcbinfo);

Modified: head/sys/netinet/udp_usrreq.c
==
--- head/sys/netinet/udp_usrreq.c   Wed May 23 16:31:46 2018
(r334103)
+++ head/sys/netinet/udp_usrreq.c   Wed May 23 17:00:05 2018
(r334104)
@@ -874,7 +874,7 @@ udp_pcblist(SYSCTL_HANDLER_ARGS)
error = SYSCTL_OUT(req, , sizeof xig);
if (error)
return (error);
-   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_WAITOK|M_ZERO);
+   il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb *), 
M_TEMP, M_EPOCH_CALL_WAITOK);
inp_list = il->il_inp_list;
 
INP_INFO_RLOCK(_udbinfo);

Modified: head/sys/sys/epoch.h
==
--- head/sys/sys/epoch.hWed May 23 16:31:46 2018(r334103)
+++ head/sys/sys/epoch.hWed May 23 17:00:05 2018(r334104)
@@ -64,6 +64,14 @@ int in_epoch(void);
 DPCPU_DECLARE(int, epoch_cb_count);
 DPCPU_DECLARE(struct grouptask, epoch_cb_task);
 
+#ifdef INVARIANTS
+#define M_EPOCH_CALL_NOWAIT(M_NOWAIT|M_ZERO)
+#define M_EPOCH_CALL_WAITOK(M_WAITOK|M_ZERO)
+#else
+#define M_EPOCH_CALL_NOWAITM_NOWAIT
+#define M_EPOCH_CALL_WAITOKM_WAITOK
+#endif
+
 static __inline void
 epoch_enter_preempt(epoch_t epoch)
 {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334074 - head/sys/sys

[Matthew Macy]

On Wed, May 23, 2018 at 9:43 AM, John Baldwin  wrote:
> On Wednesday, May 23, 2018 06:15:55 AM Matt Macy wrote:
>> Author: mmacy
>> Date: Wed May 23 06:15:55 2018
>> New Revision: 334074
>> URL: https://svnweb.freebsd.org/changeset/base/334074
>>
>> Log:
>>   Bump FreeBSD_version after r333813
>>
>> Modified:
>>   head/sys/sys/param.h
>
> FYI, these values are documented in
> head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml in the doc
> repository.


Thanks updated for 1200064. Someone(tm) needs to do 1200063.

-M
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334074 - head/sys/sys

[Matthew Macy]

Track

On Wed, May 23, 2018 at 06:53 Ian Lepore  wrote:

> On Wed, 2018-05-23 at 06:15 +, Matt Macy wrote:
> > Author: mmacy
> > Date: Wed May 23 06:15:55 2018
> > New Revision: 334074
> > URL: https://svnweb.freebsd.org/changeset/base/334074
> >
> > Log:
> >   Bump FreeBSD_version after r333813
> >
> > Modified:
> >   head/sys/sys/param.h
> >
> > Modified: head/sys/sys/param.h
> > 
> ==
> > --- head/sys/sys/param.h  Wed May 23 04:09:01 2018(r334073)
> > +++ head/sys/sys/param.h  Wed May 23 06:15:55 2018(r334074)
> > @@ -60,7 +60,7 @@
> >   *   in the range 5 to 9.
> >   */
> >  #undef __FreeBSD_version
> > -#define __FreeBSD_version 1200063/* Master, propagated to newvers */
> > +#define __FreeBSD_version 1200064/* Master, propagated to newvers */
> >
> >  /*
> >   * __FreeBSD_kernel__ indicates that this system uses the kernel of
> FreeBSD,
> >
>
> Nothing about this commit or the commit message for r333813 says why a
> version bump would be warranted. New user-visible features?  API
> change? The diff for r333813 doesn't appear to contain either of those.
>

Out of tree drivers need to conditionally compile for the change of the
multicast address list in ifnet from TAILQ to CK_STAILQ




-- Ian
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334074 - head/sys/sys

[John Baldwin]

On Wednesday, May 23, 2018 06:15:55 AM Matt Macy wrote:
> Author: mmacy
> Date: Wed May 23 06:15:55 2018
> New Revision: 334074
> URL: https://svnweb.freebsd.org/changeset/base/334074
> 
> Log:
>   Bump FreeBSD_version after r333813
> 
> Modified:
>   head/sys/sys/param.h

FYI, these values are documented in
head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml in the doc
repository.

-- 
John Baldwin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334089 - head/sbin/dumpon

[John Baldwin]

On Wednesday, May 23, 2018 10:45:32 AM Eitan Adler wrote:
> Author: eadler
> Date: Wed May 23 10:45:32 2018
> New Revision: 334089
> URL: https://svnweb.freebsd.org/changeset/base/334089
> 
> Log:
>   dumpon: point to better kernel debug symbols.
>   
>   The objdir is temporary, and the current example points to GENERIC.
>   Instead point to the installed location of the debug symbols that are
>   supposed to match the kernel you are using.
>   
>   PR: 223993
>   Submitted by:   trond.endres...@ximalas.info

Actually, it's better to point to the kernel in this case (kgdb 
/boot/kernel/kernel).
Some versions of ports kgdb won't recognize kernel.debug as a kernel and treat 
it
as a userland binary instead.

> Modified:
>   head/sbin/dumpon/dumpon.8
> 
> Modified: head/sbin/dumpon/dumpon.8
> ==
> --- head/sbin/dumpon/dumpon.8 Wed May 23 10:39:02 2018(r334088)
> +++ head/sbin/dumpon/dumpon.8 Wed May 23 10:45:32 2018(r334089)
> @@ -311,11 +311,11 @@ The
>  can be now examined using
>  .Xr kgdb 1 :
>  .Pp
> -.Dl # kgdb /usr/obj/sys/GENERIC/kernel.debug vmcore.#
> +.Dl # kgdb /usr/lib/debug/boot/kernel/kernel.debug vmcore.#
>  .Pp
>  or shorter:
>  .Pp
> -.Dl # kgdb -n # /usr/obj/sys/GENERIC/kernel.debug
> +.Dl # kgdb -n # /usr/lib/debug/boot/kernel/kernel.debug
>  .Pp
>  The core was decrypted properly if
>  .Xr kgdb 1
> 


-- 
John Baldwin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334103 - in head/sys/i386: i386 include

[Konstantin Belousov]

Author: kib
Date: Wed May 23 16:31:46 2018
New Revision: 334103
URL: https://svnweb.freebsd.org/changeset/base/334103

Log:
  Support IBRS for i386.
  
  Tested by:pho
  Sponsored by: The FreeBSD Foundation
  MFC after:1 week
  Differential revision:https://reviews.freebsd.org/D15522

Modified:
  head/sys/i386/i386/exception.s
  head/sys/i386/i386/genassym.c
  head/sys/i386/i386/support.s
  head/sys/i386/include/asmacros.h

Modified: head/sys/i386/i386/exception.s
==
--- head/sys/i386/i386/exception.s  Wed May 23 16:28:31 2018
(r334102)
+++ head/sys/i386/i386/exception.s  Wed May 23 16:31:46 2018
(r334103)
@@ -310,6 +310,8 @@ IDTVEC(dbg)
jz  calltrap
 dbg_user:
NMOVE_STACKS
+   movl$handle_ibrs_entry,%eax
+   call*%eax
pushl   %esp
movl$trap,%eax
call*%eax
@@ -337,6 +339,8 @@ nmi_mchk_common:
 * Do not switch to the thread kernel stack, otherwise we might
 * obliterate the previous context partially copied from the
 * trampoline stack.
+* Do not re-enable IBRS, there is no good place to store
+* previous state if we come from the kernel.
 */
movl%cr3, %eax
movl%eax, TF_ERR(%esp)
@@ -364,6 +368,8 @@ IDTVEC(int0x80_syscall)
SET_KERNEL_SREGS
cld
MOVE_STACKS
+   movl$handle_ibrs_entry,%eax
+   call*%eax
sti
FAKE_MCOUNT(TF_EIP(%esp))
pushl   %esp
@@ -509,7 +515,9 @@ doreti_exit:
jmp 2f
 1: testl   $SEL_RPL_MASK, TF_CS(%esp)
jz  doreti_popl_fs
-2: movl%esp, %esi
+2: movl$handle_ibrs_exit,%eax
+   call*%eax
+   movl%esp, %esi
movlPCPU(TRAMPSTK), %edx
subl%ecx, %edx
movl%edx, %edi

Modified: head/sys/i386/i386/genassym.c
==
--- head/sys/i386/i386/genassym.c   Wed May 23 16:28:31 2018
(r334102)
+++ head/sys/i386/i386/genassym.c   Wed May 23 16:31:46 2018
(r334103)
@@ -221,6 +221,7 @@ ASSYM(PC_PRIVATE_TSS, offsetof(struct pcpu, pc_private
 ASSYM(PC_KESP0, offsetof(struct pcpu, pc_kesp0));
 ASSYM(PC_TRAMPSTK, offsetof(struct pcpu, pc_trampstk));
 ASSYM(PC_COPYOUT_BUF, offsetof(struct pcpu, pc_copyout_buf));
+ASSYM(PC_IBPB_SET, offsetof(struct pcpu, pc_ibpb_set));
 
 #ifdef DEV_APIC
 ASSYM(LA_EOI, LAPIC_EOI * LAPIC_MEM_MUL);

Modified: head/sys/i386/i386/support.s
==
--- head/sys/i386/i386/support.sWed May 23 16:28:31 2018
(r334102)
+++ head/sys/i386/i386/support.sWed May 23 16:31:46 2018
(r334103)
@@ -433,9 +433,31 @@ msr_onfault:
ret
 
 ENTRY(handle_ibrs_entry)
-   ret
+   cmpb$0,hw_ibrs_active
+   je  1f
+   movl$MSR_IA32_SPEC_CTRL,%ecx
+   rdmsr
+   orl $(IA32_SPEC_CTRL_IBRS|IA32_SPEC_CTRL_STIBP),%eax
+   orl $(IA32_SPEC_CTRL_IBRS|IA32_SPEC_CTRL_STIBP)>>32,%edx
+   wrmsr
+   movb$1,PCPU(IBPB_SET)
+   /*
+* i386 does not implement SMEP, but the 4/4 split makes this not
+* that important.
+*/
+1: ret
 END(handle_ibrs_entry)
 
 ENTRY(handle_ibrs_exit)
-   ret
+   cmpb$0,PCPU(IBPB_SET)
+   je  1f
+   pushl   %ecx
+   movl$MSR_IA32_SPEC_CTRL,%ecx
+   rdmsr
+   andl$~(IA32_SPEC_CTRL_IBRS|IA32_SPEC_CTRL_STIBP),%eax
+   andl$~((IA32_SPEC_CTRL_IBRS|IA32_SPEC_CTRL_STIBP)>>32),%edx
+   wrmsr
+   popl%ecx
+   movb$0,PCPU(IBPB_SET)
+1: ret
 END(handle_ibrs_exit)

Modified: head/sys/i386/include/asmacros.h
==
--- head/sys/i386/include/asmacros.hWed May 23 16:28:31 2018
(r334102)
+++ head/sys/i386/include/asmacros.hWed May 23 16:31:46 2018
(r334103)
@@ -218,10 +218,14 @@
testl   $PCB_VM86CALL, PCB_FLAGS(%eax)
jnz .L\@.3
NMOVE_STACKS
+   movl$handle_ibrs_entry,%edx
+   call*%edx
jmp .L\@.3
 .L\@.1:testb   $SEL_RPL_MASK, TF_CS(%esp)
jz  .L\@.3
 .L\@.2:MOVE_STACKS
+   movl$handle_ibrs_entry,%edx
+   call*%edx
 .L\@.3:
.endm
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334102 - head/usr.bin/calendar

[Brad Davis]

Author: brd
Date: Wed May 23 16:28:31 2018
New Revision: 334102
URL: https://svnweb.freebsd.org/changeset/base/334102

Log:
  Switch calendar installs to use FILES and SYMLINKS instead of bare install(1)
  
  Also explicitly list each file to install so we don't silently add or miss
  some.
  
  Approved by:  bapt (mentor)

Modified:
  head/usr.bin/calendar/Makefile

Modified: head/usr.bin/calendar/Makefile
==
--- head/usr.bin/calendar/Makefile  Wed May 23 15:43:35 2018
(r334101)
+++ head/usr.bin/calendar/Makefile  Wed May 23 16:28:31 2018
(r334102)
@@ -12,25 +12,99 @@ INTER=  de_AT.ISO_8859-15 de_DE.ISO8859-1 fr_F
pt_BR.UTF-8 ru_RU.KOI8-R ru_RU.UTF-8 uk_UA.KOI8-U
 DE_LINKS=   de_DE.ISO8859-15
 FR_LINKS=   fr_FR.ISO8859-15
-TEXTMODE?= 444
 
-beforeinstall:
-   ${INSTALL} ${TAG_ARGS} -o ${BINOWN} -g ${BINGRP} -m ${TEXTMODE} \
-   ${.CURDIR}/calendars/calendar.* ${DESTDIR}${SHAREDIR}/calendar
+FILESGROUPS+=  CALS
+CALS=  calendars/calendar.all \
+   calendars/calendar.australia \
+   calendars/calendar.birthday \
+   calendars/calendar.brazilian \
+   calendars/calendar.christian \
+   calendars/calendar.computer \
+   calendars/calendar.croatian \
+   calendars/calendar.dutch \
+   calendars/calendar.freebsd \
+   calendars/calendar.french \
+   calendars/calendar.german \
+   calendars/calendar.history \
+   calendars/calendar.holiday \
+   calendars/calendar.hungarian \
+   calendars/calendar.judaic \
+   calendars/calendar.lotr \
+   calendars/calendar.music \
+   calendars/calendar.newzealand \
+   calendars/calendar.russian \
+   calendars/calendar.southafrica \
+   calendars/calendar.ukrainian \
+   calendars/calendar.usholiday \
+   calendars/calendar.world
+CALSDIR=   ${SHAREDIR}/calendar
+
+CAL_de_AT.ISO_8859-15= calendar.feiertag
+
+CAL_de_DE.ISO8859-1=   calendar.all \
+   calendar.feiertag \
+   calendar.geschichte \
+   calendar.kirche \
+   calendar.literatur \
+   calendar.musik \
+   calendar.wissenschaft
+
+CAL_fr_FR.ISO8859-1=   calendar.all \
+   calendar.fetes \
+   calendar.french \
+   calendar.jferies \
+   calendar.proverbes
+
+CAL_hr_HR.ISO8859-2=   calendar.all \
+   calendar.praznici
+
+CAL_hu_HU.ISO8859-2=   calendar.all \
+   calendar.nevnapok \
+   calendar.unnepek
+
+CAL_pt_BR.ISO8859-1=   calendar.all \
+   calendar.commemorative \
+   calendar.holidays \
+   calendar.mcommemorative
+
+CAL_pt_BR.UTF-8=   calendar.all \
+   calendar.commemorative \
+   calendar.holidays \
+   calendar.mcommemorative
+
+CAL_ru_RU.KOI8-R=  calendar.all \
+   calendar.common \
+   calendar.holiday \
+   calendar.military \
+   calendar.orthodox \
+   calendar.pagan
+
+CAL_ru_RU.UTF-8=   calendar.all \
+   calendar.common \
+   calendar.holiday \
+   calendar.military \
+   calendar.orthodox \
+   calendar.pagan
+
+CAL_uk_UA.KOI8-U=  calendar.all \
+   calendar.holiday \
+   calendar.misc \
+   calendar.orthodox
+
 .for lang in ${INTER}
-   ${INSTALL} ${TAG_ARGS} -o ${BINOWN} -g ${BINGRP} -m ${TEXTMODE} \
-   ${.CURDIR}/calendars/${lang}/calendar.* \
-   ${DESTDIR}${SHAREDIR}/calendar/${lang} 
+FILESGROUPS+=  CALS_${lang}
+CALS_${lang}DIR=   ${SHAREDIR}/calendar/${lang}
+.for file in ${CAL_${lang}}
+CALS_${lang}+= ${file:S@^@calendars/${lang}/@}
 .endfor
+.endfor
+
+
 .for link in ${DE_LINKS}
-   rm -rf ${DESTDIR}${SHAREDIR}/calendar/${link}
-   ${INSTALL} ${TAG_ARGS} -l s de_DE.ISO8859-1 \
-   ${DESTDIR}${SHAREDIR}/calendar/${link}
+SYMLINKS+= de_DE.ISO8859-1 ${SHAREDIR}/calendar/${link}
 .endfor
 .for link in ${FR_LINKS}
-   rm -rf ${DESTDIR}${SHAREDIR}/calendar/${link}
-   ${INSTALL} ${TAG_ARGS} -l s fr_FR.ISO8859-1 \
-   ${DESTDIR}${SHAREDIR}/calendar/${link}
+SYMLINKS+= fr_FR.ISO8859-1 ${SHAREDIR}/calendar/${link}
 .endfor
 
 HAS_TESTS=
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334089 - head/sbin/dumpon

[Warner Losh]

On Wed, May 23, 2018, 8:35 AM Rodney W. Grimes <
free...@pdx.rh.cn85.dnsmgr.net> wrote:

> > On 23 May 2018 at 10:15, Rodney W. Grimes
> >  wrote:
> > >> Author: eadler
> > >> Date: Wed May 23 10:45:32 2018
> > >> New Revision: 334089
> > >> URL: https://svnweb.freebsd.org/changeset/base/334089
> > >>
> > >> Log:
> > >>   dumpon: point to better kernel debug symbols.
> > >> ...
> > >
> > > You should of probably also included that fact that kgdb now must be
> invoked
> > > /usr/libexec/kgdb, as it has been moved.
> >
> > Rather, dumon should document installing the gdb port or package.
>
> I would say both would be better.
>

Better still would be to svn rm gdb... i know we can't today, but we are
getting close...

Warner

-- 
> Rod Grimes
> rgri...@freebsd.org
>
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334101 - head/sys/arm64/include

[Mark Johnston]

Author: markj
Date: Wed May 23 15:43:35 2018
New Revision: 334101
URL: https://svnweb.freebsd.org/changeset/base/334101

Log:
  Add GET_STACK_USAGE() for arm64.
  
  Its absence meant that GEOM direct dispatch was disabled (the service
  routines check the current thread's stack usage to determine whether
  to hand off the request to a dedicated thread), and this change is
  sufficient to enable direct dispatch by default.
  
  Reviewed by:  allanjude
  MFC after:2 weeks
  Differential Revision:https://reviews.freebsd.org/D15527

Modified:
  head/sys/arm64/include/proc.h

Modified: head/sys/arm64/include/proc.h
==
--- head/sys/arm64/include/proc.h   Wed May 23 15:26:56 2018
(r334100)
+++ head/sys/arm64/include/proc.h   Wed May 23 15:43:35 2018
(r334101)
@@ -54,4 +54,18 @@ struct syscall_args {
int narg;
 };
 
+#ifdef _KERNEL
+
+#include 
+
+#defineGET_STACK_USAGE(total, used) do {   
\
+   struct thread *td = curthread;  \
+   (total) = td->td_kstack_pages * PAGE_SIZE - sizeof(struct pcb); \
+   (used) = (char *)td->td_kstack +\
+   td->td_kstack_pages * PAGE_SIZE -   \
+   (char *)\
+} while (0)
+
+#endif
+
 #endif /* !_MACHINE_PROC_H_ */
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334100 - head/share/man/man9

[Mark Johnston]

Author: markj
Date: Wed May 23 15:26:56 2018
New Revision: 334100
URL: https://svnweb.freebsd.org/changeset/base/334100

Log:
  Document the return value of sbuf_bcat(9).
  
  MFC after:1 week

Modified:
  head/share/man/man9/sbuf.9

Modified: head/share/man/man9/sbuf.9
==
--- head/share/man/man9/sbuf.9  Wed May 23 15:22:58 2018(r334099)
+++ head/share/man/man9/sbuf.9  Wed May 23 15:26:56 2018(r334100)
@@ -25,7 +25,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd August 17, 2017
+.Dd May 23, 2018
 .Dt SBUF 9
 .Os
 .Sh NAME
@@ -624,6 +624,7 @@ function returns \-1 if
 was invalid, and zero otherwise.
 .Pp
 The
+.Fn sbuf_bcat ,
 .Fn sbuf_cat ,
 .Fn sbuf_cpy ,
 .Fn sbuf_printf ,
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334099 - head/sys/dev/ata/chipsets

[Alexander Motin]

Author: mav
Date: Wed May 23 15:22:58 2018
New Revision: 334099
URL: https://svnweb.freebsd.org/changeset/base/334099

Log:
  Add ready polling after PHY reset on VIA SATA controllers.
  
  According to PR there are cases of controller hang if soft reset is
  sent before device report ready status after the hard reset.
  
  I don't think this patch is perfect, but it was reported as working
  by the submitter, and I have neither the old hardware nor interest to
  test some improved version, so just done some style cleaning.
  
  PR:   183294
  Submitted by: alexandre.mart...@netasq.com
  MFC after:1 month

Modified:
  head/sys/dev/ata/chipsets/ata-via.c

Modified: head/sys/dev/ata/chipsets/ata-via.c
==
--- head/sys/dev/ata/chipsets/ata-via.c Wed May 23 14:19:06 2018
(r334098)
+++ head/sys/dev/ata/chipsets/ata-via.c Wed May 23 15:22:58 2018
(r334099)
@@ -449,12 +449,29 @@ static void
 ata_via_sata_reset(device_t dev)
 {
struct ata_channel *ch = device_get_softc(dev);
-   int devs;
+   int devs, count;
+   uint8_t status;
 
if (ch->unit == 0) {
devs = ata_sata_phy_reset(dev, 0, 0);
-   DELAY(1);
+   count = 0;
+   do {
+   ATA_IDX_OUTB(ch, ATA_DRIVE, ATA_D_IBM | ATA_D_LBA |
+   ATA_DEV(ATA_MASTER));
+   DELAY(1000);
+   status = ATA_IDX_INB(ch, ATA_STATUS);
+   count++;
+   } while (status & ATA_S_BUSY && count < 100);
+
devs += ata_sata_phy_reset(dev, 1, 0);
+   count = 0;
+   do {
+   ATA_IDX_OUTB(ch, ATA_DRIVE, ATA_D_IBM | ATA_D_LBA |
+   ATA_DEV(ATA_SLAVE));
+   DELAY(1000);
+   status = ATA_IDX_INB(ch, ATA_STATUS);
+   count++;
+   } while (status & ATA_S_BUSY && count < 100);
} else
devs = 1;
if (devs)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334089 - head/sbin/dumpon

[Rodney W. Grimes]

> On 23 May 2018 at 10:15, Rodney W. Grimes
>  wrote:
> >> Author: eadler
> >> Date: Wed May 23 10:45:32 2018
> >> New Revision: 334089
> >> URL: https://svnweb.freebsd.org/changeset/base/334089
> >>
> >> Log:
> >>   dumpon: point to better kernel debug symbols.
> >> ...
> >
> > You should of probably also included that fact that kgdb now must be invoked
> > /usr/libexec/kgdb, as it has been moved.
> 
> Rather, dumon should document installing the gdb port or package.

I would say both would be better.


-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334098 - head/share/misc

[Breno Leitao]

Author: leitao
Date: Wed May 23 14:19:06 2018
New Revision: 334098
URL: https://svnweb.freebsd.org/changeset/base/334098

Log:
  Adding myself share/misc/committers-src.dot.

Modified:
  head/share/misc/committers-src.dot

Modified: head/share/misc/committers-src.dot
==
--- head/share/misc/committers-src.dot  Wed May 23 14:05:56 2018
(r334097)
+++ head/share/misc/committers-src.dot  Wed May 23 14:19:06 2018
(r334098)
@@ -234,6 +234,7 @@ kmacy [label="Kip Macy\nkm...@freebsd.org\n2005/06/01"
 kp [label="Kristof Provost\n...@freebsd.org\n2015/03/22"]
 landonf [label="Landon Fuller\nland...@freebsd.org\n2016/05/31"]
 le [label="Lukas Ertl\n...@freebsd.org\n2004/02/02"]
+leitao [label="Breno Leitao\nlei...@freebsd.org\n2018/05/22"]
 lidl [label="Kurt Lidl\nl...@freebsd.org\n2015/10/21"]
 loos [label="Luiz Otavio O Souza\nl...@freebsd.org\n2013/07/03"]
 lstewart [label="Lawrence Stewart\nlstew...@freebsd.org\n2008/10/06"]
@@ -589,6 +590,8 @@ jhb -> rnoland
 jhb -> rpokala
 jhb -> arichardson
 
+jhibbits -> leitao
+
 jimharris -> carl
 
 jkh -> dfr
@@ -709,6 +712,7 @@ njl -> sepotvin
 
 nwhitehorn -> andreast
 nwhitehorn -> jhibbits
+nwhitehorn -> leitao
 
 obrien -> benno
 obrien -> groudier
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334089 - head/sbin/dumpon

[Ed Maste]

On 23 May 2018 at 10:15, Rodney W. Grimes
 wrote:
>> Author: eadler
>> Date: Wed May 23 10:45:32 2018
>> New Revision: 334089
>> URL: https://svnweb.freebsd.org/changeset/base/334089
>>
>> Log:
>>   dumpon: point to better kernel debug symbols.
>> ...
>
> You should of probably also included that fact that kgdb now must be invoked
> /usr/libexec/kgdb, as it has been moved.

Rather, dumon should document installing the gdb port or package.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334089 - head/sbin/dumpon

[Rodney W. Grimes]

> Author: eadler
> Date: Wed May 23 10:45:32 2018
> New Revision: 334089
> URL: https://svnweb.freebsd.org/changeset/base/334089
> 
> Log:
>   dumpon: point to better kernel debug symbols.
>   
>   The objdir is temporary, and the current example points to GENERIC.
>   Instead point to the installed location of the debug symbols that are
>   supposed to match the kernel you are using.
>   
>   PR: 223993
>   Submitted by:   trond.endres...@ximalas.info
> 
> Modified:
>   head/sbin/dumpon/dumpon.8
> 
> Modified: head/sbin/dumpon/dumpon.8
> ==
> --- head/sbin/dumpon/dumpon.8 Wed May 23 10:39:02 2018(r334088)
> +++ head/sbin/dumpon/dumpon.8 Wed May 23 10:45:32 2018(r334089)
> @@ -311,11 +311,11 @@ The
>  can be now examined using
>  .Xr kgdb 1 :
>  .Pp
> -.Dl # kgdb /usr/obj/sys/GENERIC/kernel.debug vmcore.#
> +.Dl # kgdb /usr/lib/debug/boot/kernel/kernel.debug vmcore.#

You should of probably also included that fact that kgdb now must be invoked
/usr/libexec/kgdb, as it has been moved.

>  .Pp
>  or shorter:
>  .Pp
> -.Dl # kgdb -n # /usr/obj/sys/GENERIC/kernel.debug
> +.Dl # kgdb -n # /usr/lib/debug/boot/kernel/kernel.debug
>  .Pp
>  The core was decrypted properly if
>  .Xr kgdb 1
> 
> 

-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334089 - head/sbin/dumpon

[Ed Maste]

On 23 May 2018 at 06:45, Eitan Adler  wrote:
> Author: eadler
> Date: Wed May 23 10:45:32 2018
> New Revision: 334089
> URL: https://svnweb.freebsd.org/changeset/base/334089
>
> Log:
>   dumpon: point to better kernel debug symbols.
>...
> -.Dl # kgdb /usr/obj/sys/GENERIC/kernel.debug vmcore.#
> +.Dl # kgdb /usr/lib/debug/boot/kernel/kernel.debug vmcore.#

This should be /boot/kernel/kernel, or perhaps $(sysctl -n
kern.bootfile). The kernel ELF object contains a .gnu_debuglink
section that points to the debug data contained in kernel.debug.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334097 - stable/10/etc/periodic/daily

[Ed Maste]

Author: emaste
Date: Wed May 23 14:05:56 2018
New Revision: 334097
URL: https://svnweb.freebsd.org/changeset/base/334097

Log:
  MFC r326074: filter all passwords (not only changed) from periodic passwd 
backup
  
  The periodic 200.backup-passwd script outputs any differences it finds
  in master.passwd, relative to the previous backup.  It intends to elide
  the encrypted password field, but previously did so only for changed
  lines (i.e., those beginning with - or + in the diff).
  
  Apply the sed expression also to unchanged lines to also elide their
  passwords.
  
  PR:   223461
  Reported by:  Andre Albsmeier
  Sponsored by: The FreeBSD Foundation

Modified:
  stable/10/etc/periodic/daily/200.backup-passwd
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/etc/periodic/daily/200.backup-passwd
==
--- stable/10/etc/periodic/daily/200.backup-passwd  Wed May 23 13:59:37 
2018(r334096)
+++ stable/10/etc/periodic/daily/200.backup-passwd  Wed May 23 14:05:56 
2018(r334097)
@@ -42,7 +42,7 @@ case "$daily_backup_passwd_enable" in
[ $rc -lt 1 ] && rc=1
echo "$host passwd diffs:"
diff -uI '^#' $bak/master.passwd.bak /etc/master.passwd |\
-   sed 's/^\([-+][^-+:]*\):[^:]*:/\1:(password):/'
+   sed 's/^\([-+ ][^-+:]*\):[^:]*:/\1:(password):/'
mv $bak/master.passwd.bak $bak/master.passwd.bak2
cp -p /etc/master.passwd $bak/master.passwd.bak || rc=3
fi
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334096 - stable/10/sys/modules

[Ed Maste]

Author: emaste
Date: Wed May 23 13:59:37 2018
New Revision: 334096
URL: https://svnweb.freebsd.org/changeset/base/334096

Log:
  sys/modules: don't build bxe,qlxgbe if the user objects to sourceless ucode
  
  MFC of r322682 and r322684
  
  PR:   204747
  Submitted by: Fabian Keil
  Obtained from:ElectroBSD

Modified:
  stable/10/sys/modules/Makefile
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/modules/Makefile
==
--- stable/10/sys/modules/Makefile  Wed May 23 13:48:16 2018
(r334095)
+++ stable/10/sys/modules/Makefile  Wed May 23 13:59:37 2018
(r334096)
@@ -500,7 +500,9 @@ _aout=  aout
 _apm=  apm
 _arcnet=   arcnet
 _bktr= bktr
+.if ${MK_SOURCELESS_UCODE} != "no"
 _bxe=  bxe
+.endif
 _cardbus=  cardbus
 _cbb=  cbb
 .if ${MK_SOURCELESS_UCODE} != "no"
@@ -792,7 +794,9 @@ _pccard=pccard
 _pms=  pms
 _qlxge=qlxge
 _qlxgb=qlxgb
+.if ${MK_SOURCELESS_UCODE} != "no"
 _qlxgbe=   qlxgbe
+.endif
 _qlnx= qlnx
 _rdma= rdma
 _s3=   s3
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334074 - head/sys/sys

[Ian Lepore]

On Wed, 2018-05-23 at 06:15 +, Matt Macy wrote:
> Author: mmacy
> Date: Wed May 23 06:15:55 2018
> New Revision: 334074
> URL: https://svnweb.freebsd.org/changeset/base/334074
> 
> Log:
>   Bump FreeBSD_version after r333813
> 
> Modified:
>   head/sys/sys/param.h
> 
> Modified: head/sys/sys/param.h
> ==
> --- head/sys/sys/param.h  Wed May 23 04:09:01 2018(r334073)
> +++ head/sys/sys/param.h  Wed May 23 06:15:55 2018(r334074)
> @@ -60,7 +60,7 @@
>   *   in the range 5 to 9.
>   */
>  #undef __FreeBSD_version
> -#define __FreeBSD_version 1200063/* Master, propagated to newvers */
> +#define __FreeBSD_version 1200064/* Master, propagated to newvers */
>  
>  /*
>   * __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD,
> 

Nothing about this commit or the commit message for r333813 says why a
version bump would be warranted. New user-visible features?  API
change? The diff for r333813 doesn't appear to contain either of those.

-- Ian
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334078 - head/sbin/devd

[Eitan Adler]

On 23 May 2018 at 06:35, Warner Losh  wrote:
>
>
> On Wed, May 23, 2018 at 1:39 AM, Eitan Adler  wrote:
>>
>> Author: eadler
>> Date: Wed May 23 07:39:05 2018
>> New Revision: 334078
>> URL: https://svnweb.freebsd.org/changeset/base/334078
>>
>> Log:
>>   devd: compile at WARNS=6
>>
>>   Verified with "make universe TARGETS='amd64 arm arm64 i386 sparc64'"
>>
>> Modified:
>>   head/sbin/devd/Makefile
>>   head/sbin/devd/devd.cc
>>   head/sbin/devd/token.l
>>
> ...
>>
>> Modified: head/sbin/devd/token.l
>>
>> ==
>> --- head/sbin/devd/token.l  Wed May 23 07:39:02 2018(r334077)
>> +++ head/sbin/devd/token.l  Wed May 23 07:39:05 2018(r334078)
>> @@ -38,6 +38,7 @@
>>  #include "devd.h"
>>  #include "y.tab.h"
>>
>> +extern int lineno;
>>  int lineno = 1;
>>
>>  static void
>
>
> This is completely bogus.  Never ever ever just put extern in the line
> before to avoid the warning. That's wrong 100% of the time.

You're right. thanks for the reminder. See r334095


-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334095 - head/sbin/devd

[Eitan Adler]

Author: eadler
Date: Wed May 23 13:48:16 2018
New Revision: 334095
URL: https://svnweb.freebsd.org/changeset/base/334095

Log:
  devd: Move variable declaration to header
  
  Reminder by:  imp

Modified:
  head/sbin/devd/devd.cc
  head/sbin/devd/devd.h
  head/sbin/devd/token.l

Modified: head/sbin/devd/devd.cc
==
--- head/sbin/devd/devd.cc  Wed May 23 13:10:57 2018(r334094)
+++ head/sbin/devd/devd.cc  Wed May 23 13:48:16 2018(r334095)
@@ -140,7 +140,6 @@ typedef struct client {
 } client_t;
 
 extern FILE *yyin;
-extern int lineno;
 
 static const char notify = '!';
 static const char nomatch = '?';

Modified: head/sbin/devd/devd.h
==
--- head/sbin/devd/devd.h   Wed May 23 13:10:57 2018(r334094)
+++ head/sbin/devd/devd.h   Wed May 23 13:48:16 2018(r334095)
@@ -52,6 +52,7 @@ void set_variable(const char *, const char *);
 void yyerror(const char *s);
 int  yylex(void);
 int  yyparse(void);
+extern int lineno;
 __END_DECLS
 
 #define PATH_DEVCTL"/dev/devctl"

Modified: head/sbin/devd/token.l
==
--- head/sbin/devd/token.l  Wed May 23 13:10:57 2018(r334094)
+++ head/sbin/devd/token.l  Wed May 23 13:48:16 2018(r334095)
@@ -38,7 +38,6 @@
 #include "devd.h"
 #include "y.tab.h"
 
-extern int lineno;
 int lineno = 1;
 
 static void
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r334078 - head/sbin/devd

[Warner Losh]

On Wed, May 23, 2018 at 1:39 AM, Eitan Adler  wrote:

> Author: eadler
> Date: Wed May 23 07:39:05 2018
> New Revision: 334078
> URL: https://svnweb.freebsd.org/changeset/base/334078
>
> Log:
>   devd: compile at WARNS=6
>
>   Verified with "make universe TARGETS='amd64 arm arm64 i386 sparc64'"
>
> Modified:
>   head/sbin/devd/Makefile
>   head/sbin/devd/devd.cc
>   head/sbin/devd/token.l
>
> ...

> Modified: head/sbin/devd/token.l
> 
> ==
> --- head/sbin/devd/token.l  Wed May 23 07:39:02 2018(r334077)
> +++ head/sbin/devd/token.l  Wed May 23 07:39:05 2018(r334078)
> @@ -38,6 +38,7 @@
>  #include "devd.h"
>  #include "y.tab.h"
>
> +extern int lineno;
>  int lineno = 1;
>
>  static void


This is completely bogus.  Never ever ever just put extern in the line
before to avoid the warning. That's wrong 100% of the time.

Fix it right by putting this in devd.h.

Warner
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334094 - head/sys/net

[Luca Pizzamiglio]

Author: pizzamig (ports committer)
Date: Wed May 23 13:10:57 2018
New Revision: 334094
URL: https://svnweb.freebsd.org/changeset/base/334094

Log:
  Improve MAC address uniqueness on if_epair(4).
  
  As reported in PR184149, it can happen that epair devices can have the same
  MAC address.
  This solution is based on a 32-bit hash, obtained combining the if_index of
  the a interface and the hostid.
  If the hostid is zero, a random number is used.
  
  PR:   184149
  Reviewed by:  wollman, eugen
  Approved by:  cognet
  Differential Revision:https://reviews.freebsd.org/D15329

Modified:
  head/sys/net/if_epair.c

Modified: head/sys/net/if_epair.c
==
--- head/sys/net/if_epair.c Wed May 23 12:10:16 2018(r334093)
+++ head/sys/net/if_epair.c Wed May 23 13:10:57 2018(r334094)
@@ -53,10 +53,14 @@
 __FBSDID("$FreeBSD$");
 
 #include 
+#include 
+#include 
 #include 
+#include 
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -713,6 +717,9 @@ epair_clone_create(struct if_clone *ifc, char *name, s
struct ifnet *ifp;
char *dp;
int error, unit, wildcard;
+   uint64_t hostid;
+   uint32_t key[3];
+   uint32_t hash;
uint8_t eaddr[ETHER_ADDR_LEN];  /* 00:00:00:00:00:00 */
 
/*
@@ -724,14 +731,12 @@ epair_clone_create(struct if_clone *ifc, char *name, s
if (params) {
scb = (struct epair_softc *)params;
ifp = scb->ifp;
-   /* Assign a hopefully unique, locally administered etheraddr. */
-   eaddr[0] = 0x02;
-   eaddr[3] = (ifp->if_index >> 8) & 0xff;
-   eaddr[4] = ifp->if_index & 0xff;
+   /* Copy epairNa etheraddr and change the last byte. */
+   memcpy(eaddr, scb->oifp->if_hw_addr, ETHER_ADDR_LEN);
eaddr[5] = 0x0b;
ether_ifattach(ifp, eaddr);
/* Correctly set the name for the cloner list. */
-   strlcpy(name, scb->ifp->if_xname, len);
+   strlcpy(name, ifp->if_xname, len);
return (0);
}
 
@@ -835,10 +840,21 @@ epair_clone_create(struct if_clone *ifc, char *name, s
ifp->if_init  = epair_init;
if_setsendqlen(ifp, ifqmaxlen);
if_setsendqready(ifp);
-   /* Assign a hopefully unique, locally administered etheraddr. */
+
+   /*
+* Calculate the etheraddr hashing the hostid and the
+* interface index. The result would be hopefully unique
+*/
+   getcredhostid(curthread->td_ucred, (unsigned long *));
+   if (hostid == 0) 
+   arc4rand(, sizeof(hostid), 0);
+   key[0] = (uint32_t)ifp->if_index;
+   key[1] = (uint32_t)(hostid & 0x);
+   key[2] = (uint32_t)((hostid >> 32) & 0xf);
+   hash = jenkins_hash32(key, 3, 0);
+
eaddr[0] = 0x02;
-   eaddr[3] = (ifp->if_index >> 8) & 0xff;
-   eaddr[4] = ifp->if_index & 0xff;
+   memcpy([1], , 4);
eaddr[5] = 0x0a;
ether_ifattach(ifp, eaddr);
sca->if_qflush = ifp->if_qflush;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334093 - head/sbin/kldstat

[Eitan Adler]

Author: eadler
Date: Wed May 23 12:10:16 2018
New Revision: 334093
URL: https://svnweb.freebsd.org/changeset/base/334093

Log:
  kldstat: align size to the right
  
  This makes it easier to compare numbers directly.
  
  PR:   215747
  Submitted by: "Alexander von Gernler" 

Modified:
  head/sbin/kldstat/kldstat.c

Modified: head/sbin/kldstat/kldstat.c
==
--- head/sbin/kldstat/kldstat.c Wed May 23 11:59:29 2018(r334092)
+++ head/sbin/kldstat/kldstat.c Wed May 23 12:10:16 2018(r334093)
@@ -80,7 +80,7 @@ printfile(int fileid, int verbose, int humanized)
   printf("%2d %4d %p %5s %s",
   stat.id, stat.refs, stat.address, buf, stat.name);
} else {
-   printf("%2d %4d %p %-8zx %s",
+   printf("%2d %4d %p %8zx %s",
stat.id, stat.refs, stat.address, stat.size, stat.name);
}
 }
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334091 - head/sbin/md5

[Eitan Adler]

Author: eadler
Date: Wed May 23 11:45:46 2018
New Revision: 334091
URL: https://svnweb.freebsd.org/changeset/base/334091

Log:
  md5: perform compare case-insenstive
  
  md5 generates a md5 hash lowercase, but it might be provided in
  uppercase. Allow this.
  
  PR:   205598
  Reported by:  ohauer
  MFC After:2 weeks

Modified:
  head/sbin/md5/md5.c

Modified: head/sbin/md5/md5.c
==
--- head/sbin/md5/md5.c Wed May 23 11:20:16 2018(r334090)
+++ head/sbin/md5/md5.c Wed May 23 11:45:46 2018(r334091)
@@ -243,7 +243,7 @@ main(int argc, char *argv[])
else
printf("%s (%s) = %s",
Algorithm[digest].name, *argv, p);
-   if (checkAgainst && strcmp(checkAgainst,p))
+   if (checkAgainst && strcasecmp(checkAgainst, p) 
!= 0)
{
checksFailed++;
if (!qflag)
@@ -282,7 +282,7 @@ MDString(const Algorithm_t *alg, const char *string)
printf("%s \"%s\"", buf, string);
else
printf("%s (\"%s\") = %s", alg->name, string, buf);
-   if (checkAgainst && strcmp(buf,checkAgainst))
+   if (checkAgainst && strcasecmp(buf,checkAgainst) != 0)
{
checksFailed++;
if (!qflag)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334090 - head/lib/libmd

[Eitan Adler]

Author: eadler
Date: Wed May 23 11:20:16 2018
New Revision: 334090
URL: https://svnweb.freebsd.org/changeset/base/334090

Log:
  libmd: build with WARNS=1
  
  - build with WARNS=1. This works without any changes
  - remove two unused variables noticed at WARNS=2

Modified:
  head/lib/libmd/Makefile
  head/lib/libmd/mdXhl.c

Modified: head/lib/libmd/Makefile
==
--- head/lib/libmd/Makefile Wed May 23 10:45:32 2018(r334089)
+++ head/lib/libmd/Makefile Wed May 23 11:20:16 2018(r334090)
@@ -15,7 +15,7 @@ SRCS= md4c.c md5c.c md4hl.c md5hl.c \
 INCS=  md4.h md5.h ripemd.h sha.h sha256.h sha384.h sha512.h sha512t.h \
skein.h skein_port.h skein_freebsd.h skein_iv.h
 
-WARNS?=0
+WARNS?=1
 
 MAN+=  md4.3 md5.3 ripemd.3 sha.3 sha256.3 sha512.3 skein.3
 MLINKS+=md4.3 MD4Init.3 md4.3 MD4Update.3 md4.3 MD4Final.3

Modified: head/lib/libmd/mdXhl.c
==
--- head/lib/libmd/mdXhl.c  Wed May 23 10:45:32 2018(r334089)
+++ head/lib/libmd/mdXhl.c  Wed May 23 11:20:16 2018(r334090)
@@ -54,8 +54,7 @@ MDXFdChunk(int fd, char *buf, off_t ofs, off_t len)
 {
unsigned char buffer[16*1024];
MDX_CTX ctx;
-   struct stat stbuf;
-   int readrv, e;
+   int readrv;
off_t remain;
 
if (len < 0) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334089 - head/sbin/dumpon

[Eitan Adler]

Author: eadler
Date: Wed May 23 10:45:32 2018
New Revision: 334089
URL: https://svnweb.freebsd.org/changeset/base/334089

Log:
  dumpon: point to better kernel debug symbols.
  
  The objdir is temporary, and the current example points to GENERIC.
  Instead point to the installed location of the debug symbols that are
  supposed to match the kernel you are using.
  
  PR:   223993
  Submitted by: trond.endres...@ximalas.info

Modified:
  head/sbin/dumpon/dumpon.8

Modified: head/sbin/dumpon/dumpon.8
==
--- head/sbin/dumpon/dumpon.8   Wed May 23 10:39:02 2018(r334088)
+++ head/sbin/dumpon/dumpon.8   Wed May 23 10:45:32 2018(r334089)
@@ -311,11 +311,11 @@ The
 can be now examined using
 .Xr kgdb 1 :
 .Pp
-.Dl # kgdb /usr/obj/sys/GENERIC/kernel.debug vmcore.#
+.Dl # kgdb /usr/lib/debug/boot/kernel/kernel.debug vmcore.#
 .Pp
 or shorter:
 .Pp
-.Dl # kgdb -n # /usr/obj/sys/GENERIC/kernel.debug
+.Dl # kgdb -n # /usr/lib/debug/boot/kernel/kernel.debug
 .Pp
 The core was decrypted properly if
 .Xr kgdb 1
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334088 - head/share/timedef

[Eitan Adler]

Author: eadler
Date: Wed May 23 10:39:02 2018
New Revision: 334088
URL: https://svnweb.freebsd.org/changeset/base/334088

Log:
  timedef: Update Czech timedef
  
  This changes date format from 2015/05/12 to 05.12.2015.
  
  PR:   200591
  Submitted by: grafnet...@dekanat.mff.cuni.cz

Modified:
  head/share/timedef/cs_CZ.ISO8859-2.src

Modified: head/share/timedef/cs_CZ.ISO8859-2.src
==
--- head/share/timedef/cs_CZ.ISO8859-2.src  Wed May 23 10:13:17 2018
(r334087)
+++ head/share/timedef/cs_CZ.ISO8859-2.src  Wed May 23 10:39:02 2018
(r334088)
@@ -53,7 +53,7 @@ sobota
 %H:%M:%S
 #
 # x_fmt
-%Y/%m/%d
+%d.%m.%Y
 #
 # c_fmt
 %a %e %b %X %Y
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"