svn commit: r349937 - head/usr.sbin/bhyve

2019-07-11 Thread Sean Chittenden
Author: seanc (ports committer) Date: Fri Jul 12 05:53:13 2019 New Revision: 349937 URL: https://svnweb.freebsd.org/changeset/base/349937 Log: usr.sbin/bhyve: unconditionally initialize the NVMe completion status Follow-up work to improve the handling of unsupported/invalid opcodes is

svn commit: r349936 - head/sbin/camcontrol

2019-07-11 Thread Warner Losh
Author: imp Date: Fri Jul 12 05:35:45 2019 New Revision: 349936 URL: https://svnweb.freebsd.org/changeset/base/349936 Log: Retire support for -DMINIMALISTIC We've not used this in years since we retired sysinstall, and it hasn't compiled in at least a year. A full camcontrol is only

svn commit: r349934 - head/usr.bin/cpio

2019-07-11 Thread Warner Losh
Author: imp Date: Fri Jul 12 05:19:06 2019 New Revision: 349934 URL: https://svnweb.freebsd.org/changeset/base/349934 Log: There is no SMALLER define anymore here Stop defining SMALLER. Since we replaced cpio with libarchive version, there's no options to make it smaller. Also, the

svn commit: r349935 - head/usr.sbin/bhyve

2019-07-11 Thread Sean Chittenden
Author: seanc (ports committer) Date: Fri Jul 12 05:19:37 2019 New Revision: 349935 URL: https://svnweb.freebsd.org/changeset/base/349935 Log: usr.sbin/bhyve: free resources when erroring out of pci_vtnet_init() Coverity CID: 1402978 Approved by: vmaffione Reviewed by: jhb

svn commit: r349933 - head/rescue/rescue

2019-07-11 Thread Warner Losh
Author: imp Date: Fri Jul 12 04:44:50 2019 New Revision: 349933 URL: https://svnweb.freebsd.org/changeset/base/349933 Log: Remove unused defines since r147075 When the OpenBSD dhclient was brought in 14 years ago, we stopped supporting building a reduced sized dhclient, yet retained the

svn commit: r349932 - stable/12/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 02:15:06 2019 New Revision: 349932 URL: https://svnweb.freebsd.org/changeset/base/349932 Log: MFC r349929: Move the new ipf_pcksum6() function from ip_fil_freebsd.c to fil.c. The reason for this is that ipftest(8), which still works on FreeBSD-11, fails to

svn commit: r349931 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 02:14:05 2019 New Revision: 349931 URL: https://svnweb.freebsd.org/changeset/base/349931 Log: MFC r349927, r349929: r349927: Resolve IPv6 checksum errors with stateful inspection. According to PR/203585 this appears to have been broken by r235959, which

svn commit: r349931 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 02:14:05 2019 New Revision: 349931 URL: https://svnweb.freebsd.org/changeset/base/349931 Log: MFC r349927, r349929: r349927: Resolve IPv6 checksum errors with stateful inspection. According to PR/203585 this appears to have been broken by r235959, which

svn commit: r349930 - in stable/12: sbin/swapon share/man/man5

2019-07-11 Thread Doug Moore
Author: dougm Date: Fri Jul 12 02:03:43 2019 New Revision: 349930 URL: https://svnweb.freebsd.org/changeset/base/349930 Log: MFC r349286, r349293 Modify swapon(8) to invoke BIO_DELETE to trim swap devices, either if '-E' appears on the swapon command line, or if "trimonce" appears as

svn commit: r349929 - head/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 01:59:08 2019 New Revision: 349929 URL: https://svnweb.freebsd.org/changeset/base/349929 Log: Move the new ipf_pcksum6() function from ip_fil_freebsd.c to fil.c. The reason for this is that ipftest(8), which still works on FreeBSD-11, fails to link to it,

svn commit: r349928 - in head/stand: efi/libefi libsa

2019-07-11 Thread Justin Hibbits
Author: jhibbits Date: Fri Jul 12 00:54:20 2019 New Revision: 349928 URL: https://svnweb.freebsd.org/changeset/base/349928 Log: Allow efi loader to get network params from uboot Summary: efi loader does not work with static network parameters. It always uses BOOTP/DHCP and also uses

svn commit: r349927 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 00:50:33 2019 New Revision: 349927 URL: https://svnweb.freebsd.org/changeset/base/349927 Log: MFC r348987, r348989: Resolve IPv6 checksum errors with stateful inspection. According to PR/203585 this appears to have been broken by r235959, which predates the

svn commit: r349927 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 00:50:33 2019 New Revision: 349927 URL: https://svnweb.freebsd.org/changeset/base/349927 Log: MFC r348987, r348989: Resolve IPv6 checksum errors with stateful inspection. According to PR/203585 this appears to have been broken by r235959, which predates the

svn commit: r349927 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 00:50:33 2019 New Revision: 349927 URL: https://svnweb.freebsd.org/changeset/base/349927 Log: MFC r348987, r348989: Resolve IPv6 checksum errors with stateful inspection. According to PR/203585 this appears to have been broken by r235959, which predates the

svn commit: r349926 - stable/12/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 00:35:43 2019 New Revision: 349926 URL: https://svnweb.freebsd.org/changeset/base/349926 Log: MFC r348986: Register pfil hooks when VNET != vnet0. r302298, which virtualized ipf, assumed the pfil hook registration performed in ipf_modload() would take are of

svn commit: r349925 - head/usr.sbin/bhyve

2019-07-11 Thread Sean Chittenden
Author: seanc (ports committer) Date: Thu Jul 11 23:54:50 2019 New Revision: 349925 URL: https://svnweb.freebsd.org/changeset/base/349925 Log: usr.sbin/bhyve: send an initialized value to wake up blocking kqueue This is a no-op initialization because nothing reads this value. "This

svn commit: r349924 - in head/lib/libsecureboot: . openpgp

2019-07-11 Thread Simon J. Gerraty
Author: sjg Date: Thu Jul 11 22:06:59 2019 New Revision: 349924 URL: https://svnweb.freebsd.org/changeset/base/349924 Log: libsecureboot: avoid recusion in ve_trust_init set our guard value immediately. also replace call to ve_trust_init in opgp_sig.c:initialize with call to

svn commit: r349923 - head/sys/kern

2019-07-11 Thread Doug Moore
Author: dougm Date: Thu Jul 11 20:52:39 2019 New Revision: 349923 URL: https://svnweb.freebsd.org/changeset/base/349923 Log: Address problems in blist_alloc introduced in r349777. The swap block allocator could become corrupted if a retry to allocate swap space, after a larger allocation

svn commit: r349922 - stable/11/sys/dev/netmap

2019-07-11 Thread Vincenzo Maffione
Author: vmaffione Date: Thu Jul 11 20:29:50 2019 New Revision: 349922 URL: https://svnweb.freebsd.org/changeset/base/349922 Log: MFC r349752 netmap: fix kernel pointer printing in netmap_generic.c Print the adapter name rather than the address of the adapter to avoid kernel address

svn commit: r349921 - stable/12/sys/dev/netmap

2019-07-11 Thread Vincenzo Maffione
Author: vmaffione Date: Thu Jul 11 20:14:59 2019 New Revision: 349921 URL: https://svnweb.freebsd.org/changeset/base/349921 Log: MFC r349753 netmap: Remove pointer leakage in netmap_mem2.c PR: 238641 Submitted by: Fuqian Huang Reviewed by:vmaffione Modified:

svn commit: r349920 - stable/12/sys/dev/netmap

2019-07-11 Thread Vincenzo Maffione
Author: vmaffione Date: Thu Jul 11 20:13:51 2019 New Revision: 349920 URL: https://svnweb.freebsd.org/changeset/base/349920 Log: MFC r349752 netmap: fix kernel pointer printing in netmap_generic.c Print the adapter name rather than the address of the adapter to avoid kernel address

svn commit: r349919 - head/usr.sbin/bhyve

2019-07-11 Thread Sean Chittenden
Author: seanc (ports committer) Date: Thu Jul 11 19:51:33 2019 New Revision: 349919 URL: https://svnweb.freebsd.org/changeset/base/349919 Log: usr.sbin/bhyve: commit miss from r349918 Submitted by: markj Approved by: markj Differential Revision:

svn commit: r349918 - head/usr.sbin/bhyve

2019-07-11 Thread Sean Chittenden
Author: seanc (ports committer) Date: Thu Jul 11 19:41:14 2019 New Revision: 349918 URL: https://svnweb.freebsd.org/changeset/base/349918 Log: usr.sbin/bhyve: free leaked memory during option parsing Also update to use strsep(3) instead of strtok(3). Most of this commit inadvertently

svn commit: r349917 - head/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Thu Jul 11 19:36:18 2019 New Revision: 349917 URL: https://svnweb.freebsd.org/changeset/base/349917 Log: Remove a tautological test for adding a rule in the block that adds rules. MFC after:1 week Modified: head/sys/contrib/ipfilter/netinet/fil.c Modified:

svn commit: r349916 - head/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Thu Jul 11 19:36:14 2019 New Revision: 349916 URL: https://svnweb.freebsd.org/changeset/base/349916 Log: Correct r349898. The default is add a rule. MFC after:1 week X-MFC with: r349898 Modified: head/sys/contrib/ipfilter/netinet/fil.c Modified:

svn commit: r349915 - head/usr.sbin/bhyve

2019-07-11 Thread Sean Chittenden
Author: seanc (ports committer) Date: Thu Jul 11 19:26:35 2019 New Revision: 349915 URL: https://svnweb.freebsd.org/changeset/base/349915 Log: usr.sbin/bhyve: initialize return value in xhci device interrupt handler Coverity CID: 1357340 Approved by: scottl, markj Differential

svn commit: r349914 - head/usr.sbin/bhyve

2019-07-11 Thread Sean Chittenden
Author: seanc (ports committer) Date: Thu Jul 11 19:07:45 2019 New Revision: 349914 URL: https://svnweb.freebsd.org/changeset/base/349914 Log: usr.sbin/bhyve: free resources if there is an initialization error in rfb Coverity CID: 1357335 Approved by: markj, jhb Differential Revision:

Re: svn commit: r349893 - in head/sys: modules/tcp/rack netinet netinet/tcp_stacks sys

2019-07-11 Thread John Baldwin
On 7/10/19 9:48 PM, Randall Stewart wrote: > John: > > Thanks for the suggestions.. I have committed changes to the two > nits. As to M_PROTO1, I see that in the NF world we have removed > M_PROTO12 and moved the M_PROTO’s up 1 i.e. M_PROTO1 == 0x2000 > > So for now it is safe, since the

svn commit: r349913 - head/sys/x86/x86

2019-07-11 Thread Konstantin Belousov
Author: kib Date: Thu Jul 11 16:22:49 2019 New Revision: 349913 URL: https://svnweb.freebsd.org/changeset/base/349913 Log: Ensure that mds_handler always points to a valid method. Depending on system configuration, version, and architecture, mds_handler might be dereferenced from doreti

svn commit: r349912 - head/lib/libthr/thread

2019-07-11 Thread Konstantin Belousov
Author: kib Date: Thu Jul 11 16:19:33 2019 New Revision: 349912 URL: https://svnweb.freebsd.org/changeset/base/349912 Log: Restore ability to pass NULL name argument to pthread_set_name_np(3) to clear the thread name. PR: 239142 Submitted by: Lewis Donzis MFC after:3 days

Re: svn commit: r349896 - head/contrib/telnet/telnet

2019-07-11 Thread Shawn Webb
On Fri, Jul 12, 2019 at 01:30:25AM +1000, Bruce Evans wrote: > On Thu, 11 Jul 2019, Enji Cooper wrote: > > > > On Jul 10, 2019, at 3:36 PM, Philip Paeps wrote: > > > > > > Author: philip > > > Date: Wed Jul 10 22:36:14 2019 > > > New Revision: 349896 > > > URL:

svn commit: r349911 - stable/12/sys/vm

2019-07-11 Thread Mark Johnston
Author: markj Date: Thu Jul 11 15:38:40 2019 New Revision: 349911 URL: https://svnweb.freebsd.org/changeset/base/349911 Log: MFC r349612: Mark pages allocated from the per-CPU cache. Modified: stable/12/sys/vm/vm_page.c stable/12/sys/vm/vm_page.h Directory Properties: stable/12/

svn commit: r349910 - head/sys/arm64/include

2019-07-11 Thread Mark Johnston
Author: markj Date: Thu Jul 11 15:36:59 2019 New Revision: 349910 URL: https://svnweb.freebsd.org/changeset/base/349910 Log: Fix some ISS bit definitions for data aborts. MFC after:1 week Sponsored by: The FreeBSD Foundation Modified: head/sys/arm64/include/armreg.h Modified:

Re: svn commit: r349896 - head/contrib/telnet/telnet

2019-07-11 Thread Bruce Evans
On Thu, 11 Jul 2019, Enji Cooper wrote: On Jul 10, 2019, at 3:36 PM, Philip Paeps wrote: Author: philip Date: Wed Jul 10 22:36:14 2019 New Revision: 349896 URL: https://svnweb.freebsd.org/changeset/base/349896 Log: telnet: fix minor style violation While here also fix a very unlikely NULL

Re: svn commit: r349896 - head/contrib/telnet/telnet

2019-07-11 Thread Shawn Webb
On Thu, Jul 11, 2019 at 01:02:15AM -0700, Enji Cooper wrote: > > > On Jul 10, 2019, at 3:36 PM, Philip Paeps wrote: > > > > Author: philip > > Date: Wed Jul 10 22:36:14 2019 > > New Revision: 349896 > > URL: https://svnweb.freebsd.org/changeset/base/349896 > > > > Log: > > telnet: fix minor

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-11 Thread Bruce Evans
On Thu, 11 Jul 2019, Alexey Dokuchaev wrote: On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: New Revision: 349890 URL: https://svnweb.freebsd.org/changeset/base/349890 Log: telnet: fix a couple of snprintf() buffer overflows I see few fixes in this fix. I see even more

Re: svn commit: r349907 - head/sys/netinet/tcp_stacks

2019-07-11 Thread Cy Schubert
Cy Schubert writes: > In message <201907110438.x6b4cxx1054...@repo.freebsd.org>, Randall > Stewart writ > es: > > Author: rrs > > Date: Thu Jul 11 04:38:33 2019 > > New Revision: 349907 > > URL: https://svnweb.freebsd.org/changeset/base/349907 > > > > Log: > > Update copyright per JBH's

Re: svn commit: r349907 - head/sys/netinet/tcp_stacks

2019-07-11 Thread Cy Schubert
In message <201907110438.x6b4cxx1054...@repo.freebsd.org>, Randall Stewart writ es: > Author: rrs > Date: Thu Jul 11 04:38:33 2019 > New Revision: 349907 > URL: https://svnweb.freebsd.org/changeset/base/349907 > > Log: > Update copyright per JBH's suggestions.. thanks. > > Modified: >

Re: svn commit: r349907 - head/sys/netinet/tcp_stacks

2019-07-11 Thread Enji Cooper
> On Jul 10, 2019, at 9:38 PM, Randall Stewart wrote: > > Author: rrs > Date: Thu Jul 11 04:38:33 2019 > New Revision: 349907 > URL: https://svnweb.freebsd.org/changeset/base/349907 > > Log: > Update copyright per JBH's suggestions.. thanks. > > Modified: >

Re: svn commit: r349896 - head/contrib/telnet/telnet

2019-07-11 Thread Enji Cooper
> On Jul 10, 2019, at 3:36 PM, Philip Paeps wrote: > > Author: philip > Date: Wed Jul 10 22:36:14 2019 > New Revision: 349896 > URL: https://svnweb.freebsd.org/changeset/base/349896 > > Log: > telnet: fix minor style violation > > While here also fix a very unlikely NULL pointer

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-11 Thread Eitan Adler
On Wed, 10 Jul 2019 at 10:42, Philip Paeps wrote: > Author: philip > Date: Wed Jul 10 17:42:04 2019 > New Revision: 349890 > URL: https://svnweb.freebsd.org/changeset/base/349890 > > Log: > telnet: fix a couple of snprintf() buffer overflows > > Obtained from:Juniper Networks > MFC

svn commit: r349909 - head/sys/dev/mpr

2019-07-11 Thread Warner Losh
Author: imp Date: Thu Jul 11 06:22:15 2019 New Revision: 349909 URL: https://svnweb.freebsd.org/changeset/base/349909 Log: More fully implement the state machine. When a command is finished running, we must transition it from INQUEUE to busy state. We were failing to do that, so we hit a