svn commit: r359501 - head/sys/kern

2020-03-31 Thread Jason A. Harmening
Author: jah
Date: Wed Apr  1 04:51:39 2020
New Revision: 359501
URL: https://svnweb.freebsd.org/changeset/base/359501

Log:
  deadlkres: include thread name in panic messages
  
  Reviewed by:  markj
  MFC after:1 week
  Differential Revision:https://reviews.freebsd.org/D24235

Modified:
  head/sys/kern/kern_clock.c

Modified: head/sys/kern/kern_clock.c
==
--- head/sys/kern/kern_clock.c  Wed Apr  1 03:27:47 2020(r359500)
+++ head/sys/kern/kern_clock.c  Wed Apr  1 04:51:39 2020(r359501)
@@ -205,8 +205,9 @@ deadlres_td_on_lock(struct proc *p, struct thread *td,
 * Accordingly with provided thresholds, this thread is stuck
 * for too long on a turnstile.
 */
-   panic("%s: possible deadlock detected for %p, "
-   "blocked for %d ticks\n", __func__, td, tticks);
+   panic("%s: possible deadlock detected for %p (%s), "
+   "blocked for %d ticks\n", __func__,
+   td, sched_tdname(td), tticks);
 }
 
 static void
@@ -239,8 +240,9 @@ deadlres_td_sleep_q(struct proc *p, struct thread *td,
if (!strcmp(blessed[i], td->td_wmesg))
return;
 
-   panic("%s: possible deadlock detected for %p, "
-   "blocked for %d ticks\n", __func__, td, tticks);
+   panic("%s: possible deadlock detected for %p (%s), "
+   "blocked for %d ticks\n", __func__,
+   td, sched_tdname(td), tticks);
}
 }
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359500 - head/sys/dev/ahci

2020-03-31 Thread Alexander Motin
Author: mav
Date: Wed Apr  1 03:27:47 2020
New Revision: 359500
URL: https://svnweb.freebsd.org/changeset/base/359500

Log:
  Add support for AHCI BIOS/OS Handoff.
  
  This allows clean handoff from BIOS implementing some asynchronous I/O to
  the OS AHCI driver.  During attach driver declares OS ownership request
  and waits from 25ms to 2s for BIOS to complete operation and release the
  hardware.
  
  MFC after:2 weeks

Modified:
  head/sys/dev/ahci/ahci.c
  head/sys/dev/ahci/ahci.h

Modified: head/sys/dev/ahci/ahci.c
==
--- head/sys/dev/ahci/ahci.cWed Apr  1 03:19:42 2020(r359499)
+++ head/sys/dev/ahci/ahci.cWed Apr  1 03:27:47 2020(r359500)
@@ -141,7 +141,27 @@ int
 ahci_ctlr_reset(device_t dev)
 {
struct ahci_controller *ctlr = device_get_softc(dev);
+   uint32_t v;
int timeout;
+
+   /* BIOS/OS Handoff */
+   if ((ATA_INL(ctlr->r_mem, AHCI_VS) >= 0x00010200) &&
+   (ATA_INL(ctlr->r_mem, AHCI_CAP2) & AHCI_CAP2_BOH) &&
+   ((v = ATA_INL(ctlr->r_mem, AHCI_BOHC)) & AHCI_BOHC_OOS) == 0) {
+
+   /* Request OS ownership. */
+   ATA_OUTL(ctlr->r_mem, AHCI_BOHC, v | AHCI_BOHC_OOS);
+
+   /* Wait up to 2s for BIOS ownership release. */
+   for (timeout = 0; timeout < 80; timeout++) {
+   DELAY(25000);
+   v = ATA_INL(ctlr->r_mem, AHCI_BOHC);
+   if ((v & AHCI_BOHC_BOS) == 0)
+   break;
+   if ((v & AHCI_BOHC_BB) == 0)
+   break;
+   }
+   }
 
/* Enable AHCI mode */
ATA_OUTL(ctlr->r_mem, AHCI_GHC, AHCI_GHC_AE);

Modified: head/sys/dev/ahci/ahci.h
==
--- head/sys/dev/ahci/ahci.hWed Apr  1 03:19:42 2020(r359499)
+++ head/sys/dev/ahci/ahci.hWed Apr  1 03:27:47 2020(r359500)
@@ -214,6 +214,13 @@
 #defineAHCI_CAP2_SADM  0x0010
 #defineAHCI_CAP2_DESO  0x0020
 
+#define AHCI_BOHC   0x28
+#defineAHCI_BOHC_BOS   0x0001
+#defineAHCI_BOHC_OOS   0x0002
+#defineAHCI_BOHC_SOOE  0x0004
+#defineAHCI_BOHC_OOC   0x0008
+#defineAHCI_BOHC_BB0x0010
+
 #define AHCI_VSCAP  0xa4
 #define AHCI_OFFSET 0x100
 #define AHCI_STEP   0x80
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r359499 - head/sys/dev/ahci

2020-03-31 Thread Ravi Pokala
-Original Message-
From:  on behalf of Alexander Motin 

Date: 2020-03-31, Tuesday at 20:19
To: , , 

Subject: svn commit: r359499 - head/sys/dev/ahci

Author: mav
Date: Wed Apr  1 03:19:42 2020
New Revision: 359499
URL: https://svnweb.freebsd.org/changeset/base/359499

Log:
  Add ID for JMicron JMB582/JMB585 AHCI controller.
  
  JMB582 has 2 6Gbps SATA ports and PCIe 3.0 x1.
  JMB585 has 5 6Gbps SATA ports and PCIe 3.0 x2.
  
  Both chips support AHCI v1.31, Port Multiplier with FBS and 8 MSI vectors.

Hi Alexander,

The second line of diff seems unrelated...?

Thanks,

Ravi (rpokala@)

  MFC after:2 weeks

Modified:
  head/sys/dev/ahci/ahci_pci.c

Modified: head/sys/dev/ahci/ahci_pci.c

==
--- head/sys/dev/ahci/ahci_pci.cWed Apr  1 02:13:01 2020
(r359498)
+++ head/sys/dev/ahci/ahci_pci.cWed Apr  1 03:19:42 2020
(r359499)
@@ -247,6 +247,7 @@ static const struct {
{0x2365197b, 0x00, "JMicron JMB365",AHCI_Q_NOFORCE},
{0x2366197b, 0x00, "JMicron JMB366",AHCI_Q_NOFORCE},
{0x2368197b, 0x00, "JMicron JMB368",AHCI_Q_NOFORCE},
+   {0x0585197b, 0x00, "JMicron JMB58x",0},
{0x61ab, 0x00, "Marvell 88SE6111",  AHCI_Q_NOFORCE | AHCI_Q_NOPMP |
AHCI_Q_1CH | AHCI_Q_EDGEIS},
{0x612111ab, 0x00, "Marvell 88SE6121",  AHCI_Q_NOFORCE | AHCI_Q_NOPMP |
@@ -399,6 +400,7 @@ ahci_probe(device_t dev)
 !(ahci_ids[i].quirks & AHCI_Q_NOFORCE {
/* Do not attach JMicrons with single PCI function. */
if (pci_get_vendor(dev) == 0x197b &&
+   (ahci_ids[i].quirks & AHCI_Q_NOFORCE) &&
(pci_read_config(dev, 0xdf, 1) & 0x40) == 0)
return (ENXIO);
snprintf(buf, sizeof(buf), "%s AHCI SATA controller",



___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359499 - head/sys/dev/ahci

2020-03-31 Thread Alexander Motin
Author: mav
Date: Wed Apr  1 03:19:42 2020
New Revision: 359499
URL: https://svnweb.freebsd.org/changeset/base/359499

Log:
  Add ID for JMicron JMB582/JMB585 AHCI controller.
  
  JMB582 has 2 6Gbps SATA ports and PCIe 3.0 x1.
  JMB585 has 5 6Gbps SATA ports and PCIe 3.0 x2.
  
  Both chips support AHCI v1.31, Port Multiplier with FBS and 8 MSI vectors.
  
  MFC after:2 weeks

Modified:
  head/sys/dev/ahci/ahci_pci.c

Modified: head/sys/dev/ahci/ahci_pci.c
==
--- head/sys/dev/ahci/ahci_pci.cWed Apr  1 02:13:01 2020
(r359498)
+++ head/sys/dev/ahci/ahci_pci.cWed Apr  1 03:19:42 2020
(r359499)
@@ -247,6 +247,7 @@ static const struct {
{0x2365197b, 0x00, "JMicron JMB365",AHCI_Q_NOFORCE},
{0x2366197b, 0x00, "JMicron JMB366",AHCI_Q_NOFORCE},
{0x2368197b, 0x00, "JMicron JMB368",AHCI_Q_NOFORCE},
+   {0x0585197b, 0x00, "JMicron JMB58x",0},
{0x61ab, 0x00, "Marvell 88SE6111",  AHCI_Q_NOFORCE | AHCI_Q_NOPMP |
AHCI_Q_1CH | AHCI_Q_EDGEIS},
{0x612111ab, 0x00, "Marvell 88SE6121",  AHCI_Q_NOFORCE | AHCI_Q_NOPMP |
@@ -399,6 +400,7 @@ ahci_probe(device_t dev)
 !(ahci_ids[i].quirks & AHCI_Q_NOFORCE {
/* Do not attach JMicrons with single PCI function. */
if (pci_get_vendor(dev) == 0x197b &&
+   (ahci_ids[i].quirks & AHCI_Q_NOFORCE) &&
(pci_read_config(dev, 0xdf, 1) & 0x40) == 0)
return (ENXIO);
snprintf(buf, sizeof(buf), "%s AHCI SATA controller",
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359498 - head/sys/netinet6

2020-03-31 Thread Andrey V. Elsukov
Author: ae
Date: Wed Apr  1 02:13:01 2020
New Revision: 359498
URL: https://svnweb.freebsd.org/changeset/base/359498

Log:
  Ignore ND6 neighbor advertisement received for static link-layer entries.
  
  Previously such NA could override manually created LLE.
  
  Reported by:  Martin Beran 
  Reviewed by:  melifaro
  MFC after:10 days

Modified:
  head/sys/netinet6/nd6_nbr.c

Modified: head/sys/netinet6/nd6_nbr.c
==
--- head/sys/netinet6/nd6_nbr.c Tue Mar 31 22:41:57 2020(r359497)
+++ head/sys/netinet6/nd6_nbr.c Wed Apr  1 02:13:01 2020(r359498)
@@ -754,6 +754,12 @@ nd6_na_input(struct mbuf *m, int off, int icmp6len)
goto freeit;
}
 
+   /*
+* Do not try to override static entry.
+*/
+   if (ln->la_flags & LLE_STATIC)
+   goto freeit;
+
if (ln->ln_state == ND6_LLINFO_INCOMPLETE) {
/*
 * If the link-layer has address, and no lladdr option came,
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359497 - head

2020-03-31 Thread Warner Losh
Author: imp
Date: Tue Mar 31 22:41:57 2020
New Revision: 359497
URL: https://svnweb.freebsd.org/changeset/base/359497

Log:
  Add powerpcspe to the EXTRA_TARGETS
  
  Currently, powerpcspe is broken with clang. Add it to the EXTRA_TARGETS until
  that's fixed.
  
  Reviewed by: brooks, bdrewery, emaste (LGTM)
  MFC After: 3 days
  Differential Revision: https://reviews.freebsd.org/D24212

Modified:
  head/Makefile

Modified: head/Makefile
==
--- head/Makefile   Tue Mar 31 22:41:53 2020(r359496)
+++ head/Makefile   Tue Mar 31 22:41:57 2020(r359497)
@@ -494,19 +494,20 @@ worlds: .PHONY
 .if make(universe) || make(universe_kernels) || make(tinderbox) || \
 make(targets) || make(universe-toolchain)
 #
-# Don't build rarely used architectures unless requested.
+# Don't build rarely used, semi-supported architectures unless requested.
 #
 .if defined(EXTRA_TARGETS)
 EXTRA_ARCHES_mips= mipsel mipshf mipselhf mips64el mips64hf mips64elhf
 EXTRA_ARCHES_mips+=mipsn32
+# powerpcspe excluded from main list until clang fixed
+EXTRA_ARCHES_powerpc=  powerpcspe
 .endif
 TARGETS?=amd64 arm arm64 i386 mips powerpc riscv
 _UNIVERSE_TARGETS= ${TARGETS}
 TARGET_ARCHES_arm?=armv6 armv7
 TARGET_ARCHES_arm64?=  aarch64
 TARGET_ARCHES_mips?=   mips mips64 ${EXTRA_ARCHES_mips}
-# powerpcspe excluded until clang fixed
-TARGET_ARCHES_powerpc?=powerpc powerpc64
+TARGET_ARCHES_powerpc?=powerpc powerpc64 ${EXTRA_ARCHES_powerpc}
 TARGET_ARCHES_riscv?=  riscv64 riscv64sf
 .for target in ${TARGETS}
 TARGET_ARCHES_${target}?= ${target}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359495 - head

2020-03-31 Thread Warner Losh
Author: imp
Date: Tue Mar 31 22:41:48 2020
New Revision: 359495
URL: https://svnweb.freebsd.org/changeset/base/359495

Log:
  Fix make kernels to match original commit message
  
  make kernels was originally documented (in commit r295099) as the same as make
  universe -DJUST_BUILD_KERNELS. However, it used the 
UNIVERSE_TARGET=buildkernel
  which is subtly different in that it also builds the toolchains and doesn't
  build the LINT modules unless they happened to already exist in the tree. This
  unbreaks POLA and just builds the kernels, including LINT, now rather than all
  that other stuff as well. When the commit originally happened, the two just
  differed by the LINT bug. r335711 introduced the universe dependency on the
  toolchain that wasn't present before, which diverged the two further. This
  restores the original intent of r295099.
  
  Reviewed by: brooks, bdrewery, emaste (LGTM)
  MFC After: 3 days
  Differential Revision: https://reviews.freebsd.org/D24212

Modified:
  head/Makefile

Modified: head/Makefile
==
--- head/Makefile   Tue Mar 31 22:41:43 2020(r359494)
+++ head/Makefile   Tue Mar 31 22:41:48 2020(r359495)
@@ -479,7 +479,7 @@ kernel-toolchains: .PHONY
@cd ${.CURDIR}; ${SUB_MAKE} UNIVERSE_TARGET=kernel-toolchain universe
 
 kernels: .PHONY
-   @cd ${.CURDIR}; ${SUB_MAKE} UNIVERSE_TARGET=buildkernel universe
+   @cd ${.CURDIR}; ${SUB_MAKE} universe -DWITHOUT_WORLDS
 
 worlds: .PHONY
@cd ${.CURDIR}; ${SUB_MAKE} UNIVERSE_TARGET=buildworld universe
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359496 - head/share/man/man7

2020-03-31 Thread Warner Losh
Author: imp
Date: Tue Mar 31 22:41:53 2020
New Revision: 359496
URL: https://svnweb.freebsd.org/changeset/base/359496

Log:
  Document universe better
  
  Document the kernels and worlds targets. Document the TARGETS and 
EXTRA_TARGETS
  variables.
  
  Reviewed by: brooks, bdrewery, emaste (LGTM)
  MFC After: 3 days
  Differential Revision: https://reviews.freebsd.org/D24212

Modified:
  head/share/man/man7/build.7

Modified: head/share/man/man7/build.7
==
--- head/share/man/man7/build.7 Tue Mar 31 22:41:48 2020(r359495)
+++ head/share/man/man7/build.7 Tue Mar 31 22:41:53 2020(r359496)
@@ -289,6 +289,18 @@ for all kernels for that architecture,
 including
 .Pa LINT .
 This command takes a long time.
+.It Cm kernels
+Like
+.Cm universe
+with
+.Va WITHOUT_WORLDS
+defined so only the kernels for each architecture are built.
+.It Cm worlds
+Like
+.Cm universe
+with
+.Va WITHOUT_KERNELS
+defined so only the worlds for each architecture are built.
 .It Cm update
 Get updated sources as configured in
 .Xr make.conf 5 .
@@ -761,7 +773,7 @@ The default action is to build documentation for all l
 .Pp
 Builds using the
 .Cm universe
-target are influenced by the following
+and related targets are influenced by the following
 .Xr make 1
 variables:
 .Bl -tag -width ".Va MAKE_JUST_KERNELS"
@@ -786,6 +798,15 @@ target for each supported architecture instead of the 
 building a world and one or more kernels.
 This variable implies
 .Va WITHOUT_KERNELS .
+.It Va TARGETS
+Only build the listed targets instead of each supported architecture.
+.It Va EXTRA_TARGETS
+In addition to the supported architectures, build the semi-supported
+architectures.
+A semi-supported architecture has build support in the
+.Fx
+tree, but receives significantly less testing and is generally for
+fringe uses that do not have a wide appeal.
 .El
 .Sh FILES
 .Bl -tag -width ".Pa /usr/share/examples/etc/make.conf" -compact
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359494 - in head: . share/man/man7

2020-03-31 Thread Warner Losh
Author: imp
Date: Tue Mar 31 22:41:43 2020
New Revision: 359494
URL: https://svnweb.freebsd.org/changeset/base/359494

Log:
  Make universe configuration more consistent with rest of system
  
  Add 'WITHOUT_WORLDS' and 'WITHOUT_KERNELS' as aliases for the inconsistently
  named MAKE_JUST_KERNELS and MAKE_JUST_WORLDS respectively. I always forget the
  MAKE_ part (or is it BUILD_), and it's inconsistent with everything
  else. Document the new things, but leave speculation of any eventual 
MAKE_JUST_*
  deprecation out of the manuals and comments.
  
  Reviewed by: brooks, bdrewery, emaste (LGTM)
  MFC After: 3 days
  Differential Revision: https://reviews.freebsd.org/D24212

Modified:
  head/Makefile
  head/share/man/man7/build.7

Modified: head/Makefile
==
--- head/Makefile   Tue Mar 31 20:09:20 2020(r359493)
+++ head/Makefile   Tue Mar 31 22:41:43 2020(r359494)
@@ -5,10 +5,12 @@
 #
 # universe- *Really* build *everything* (buildworld and
 #   all kernels on all architectures).  Define
-#   MAKE_JUST_KERNELS to only build kernels,
-#   MAKE_JUST_WORLDS to only build userland.
+#   MAKE_JUST_KERNELS or WITHOUT_WORLDS to only build 
kernels,
+#   MAKE_JUST_WORLDS or WITHOUT_KERNELS to only build 
userland.
 # tinderbox   - Same as universe, but presents a list of failed build
 #   targets and exits with an error if there were any.
+# worlds - Same as universe, except just makes the worlds.
+# kernels- Same as universe, except just makes the kernels.
 # buildworld  - Rebuild *everything*, including glue to help do
 #   upgrades.
 # installworld- Install everything built by "buildworld".
@@ -104,6 +106,15 @@
 # For more information, see the build(7) manual page.
 #
 
+.if defined(UNIVERSE_TARGET) || defined(MAKE_JUST_WORLDS) || 
defined(WITHOUT_KERNELS)
+__DO_KERNELS=no
+.endif
+.if defined(MAKE_JUST_KERNELS) || defined(WITHOUT_WORLDS)
+__DO_WORLDS=no
+.endif
+__DO_WORLDS?=yes
+__DO_KERNELS?=yes
+
 # This is included so CC is set to ccache for -V, and COMPILER_TYPE/VERSION
 # can be cached for sub-makes. We can't do this while still running on the
 # old fmake from FreeBSD 9.x or older, so avoid including it then to avoid
@@ -521,11 +532,7 @@ universe_${toolchain}_skip: universe_prologue .PHONY
 .endif
 .endfor
 
-.if defined(UNIVERSE_TARGET)
-MAKE_JUST_WORLDS=  YES
-.else
 UNIVERSE_TARGET?=  buildworld
-.endif
 KERNSRCDIR?=   ${.CURDIR}/sys
 
 targets:   .PHONY
@@ -634,7 +641,7 @@ MAKE_PARAMS_${target}+= \
 .endfor
 .endif # !make(targets)
 
-.if !defined(MAKE_JUST_KERNELS)
+.if ${__DO_WORLDS} == "yes"
 universe_${target}_done: universe_${target}_worlds .PHONY
 .for target_arch in ${TARGET_ARCHES_${target}}
 universe_${target}_worlds: universe_${target}_${target_arch} .PHONY
@@ -658,9 +665,9 @@ universe_${target}_${target_arch}: universe_${target}_
${MAKEFAIL}))
@echo ">> ${target}.${target_arch} ${UNIVERSE_TARGET} completed on 
`LC_ALL=C date`"
 .endfor
-.endif # !MAKE_JUST_KERNELS
+.endif # ${__DO_WORLDS} == "yes"
 
-.if !defined(MAKE_JUST_WORLDS)
+.if ${__DO_KERNELS} == "yes"
 universe_${target}_done: universe_${target}_kernels .PHONY
 universe_${target}_kernels: universe_${target}_worlds .PHONY
 universe_${target}_kernels: universe_${target}_prologue .MAKE .PHONY
@@ -673,7 +680,7 @@ universe_${target}_kernels: universe_${target}_prologu
fi
@cd ${.CURDIR}; ${SUB_MAKE} ${.MAKEFLAGS} TARGET=${target} \
universe_kernels
-.endif # !MAKE_JUST_WORLDS
+.endif # ${__DO_KERNELS} == "yes"
 
 # Tell the user the worlds and kernels have completed
 universe_${target}: universe_${target}_done

Modified: head/share/man/man7/build.7
==
--- head/share/man/man7/build.7 Tue Mar 31 20:09:20 2020(r359493)
+++ head/share/man/man7/build.7 Tue Mar 31 22:41:43 2020(r359494)
@@ -24,7 +24,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd December 3, 2018
+.Dd March 29, 2020
 .Dt BUILD 7
 .Os
 .Sh NAME
@@ -775,11 +775,17 @@ while still building each architecture serially.
 Only build kernels for each supported architecture.
 .It Va MAKE_JUST_WORLDS
 Only build worlds for each supported architecture.
+.It Va WITHOUT_WORLDS
+Only build kernels for each supported architecture.
+.It Va WITHOUT_KERNELS
+Only build worlds for each supported architecture.
 .It Va UNIVERSE_TARGET
 Execute the specified
 .Xr make 1
 target for each supported architecture instead of the default action of
 building a world and one or more kernels.
+This variable implies
+.Va WITHOUT_KERNELS .
 .El
 .Sh FILES
 .Bl -tag -width ".Pa /usr/share/examples/etc/make.conf" -compact
___

svn commit: r359493 - head/sys/mips/nlm/dev/net

2020-03-31 Thread Ravi Pokala
Author: rpokala
Date: Tue Mar 31 20:09:20 2020
New Revision: 359493
URL: https://svnweb.freebsd.org/changeset/base/359493

Log:
  Fix build for mips.XLP64 kernel, by re-ordering headers
  
  The log for the failure contained errors like this:
  
  | In file included from ${SRCTOP}/sys/mips/nlm/dev/net/xlpge.c:34:
  | In file included from ${SRCTOP}/sys/sys/systm.h:44:
  | In file included from ./machine/atomic.h:849:
  | ${SRCTOP}/sys/sys/_atomic_subword.h:222:37: error: unknown type name 
'u_long'; did you mean 'long'?
  | atomic_testandset_acq_long(volatile u_long *p, u_int v)
  | ^~
  | long
  
  And similar "unknown type name" errors for u_int, not recognizing bool as a 
type, etc.
  
  This was caused by including  too far down; move it up where it 
belongs.
  
  While here, add a blank line after '__FBSDID()', in keeping with convention.
  
  Reviewed by:  emaste
  Sponsored by: Panasas
  Differential Revision:https://reviews.freebsd.org/D24242

Modified:
  head/sys/mips/nlm/dev/net/xlpge.c

Modified: head/sys/mips/nlm/dev/net/xlpge.c
==
--- head/sys/mips/nlm/dev/net/xlpge.c   Tue Mar 31 17:57:11 2020
(r359492)
+++ head/sys/mips/nlm/dev/net/xlpge.c   Tue Mar 31 20:09:20 2020
(r359493)
@@ -30,10 +30,11 @@
 
 #include 
 __FBSDID("$FreeBSD$");
+
+#include 
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359489 - head/usr.sbin/valectl

2020-03-31 Thread Vincenzo Maffione
Author: vmaffione
Date: Tue Mar 31 16:47:15 2020
New Revision: 359489
URL: https://svnweb.freebsd.org/changeset/base/359489

Log:
  valectl: fix typo in man page
  
  Submitted by: Jose Luis Duran
  MFC after:3 days

Modified:
  head/usr.sbin/valectl/valectl.8

Modified: head/usr.sbin/valectl/valectl.8
==
--- head/usr.sbin/valectl/valectl.8 Tue Mar 31 15:59:29 2020
(r359488)
+++ head/usr.sbin/valectl/valectl.8 Tue Mar 31 16:47:15 2020
(r359489)
@@ -24,7 +24,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd October 26, 2019
+.Dd March 31, 2020
 .Dt VALECTL 8
 .Os
 .Sh NAME
@@ -95,7 +95,7 @@ Create a new persistent VALE port with name
 .Ar interface .
 The name must be different from any other network interface
 already present in the system.
-.It Fl d Ar interface
+.It Fl r Ar interface
 Destroy the persistent VALE port with name
 .Ar inteface .
 .It Fl l Ar valeSSS:PPP
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359490 - in vendor/bsnmp/dist: . config gensnmpdef gensnmptree lib snmp_mibII snmp_ntp snmp_target snmp_usm snmp_vacm snmpd tests

2020-03-31 Thread Hartmut Brandt
Author: harti
Date: Tue Mar 31 17:50:32 2020
New Revision: 359490
URL: https://svnweb.freebsd.org/changeset/base/359490

Log:
  Import version 1.14 of bsnmp. This mainly consists of bug fixes
  in the ASN.1 functions and comes with a test suite for these
  functions.

Added:
  vendor/bsnmp/dist/snmpd/trans_inet.c   (contents, props changed)
  vendor/bsnmp/dist/snmpd/trans_inet.h   (contents, props changed)
  vendor/bsnmp/dist/tests/
  vendor/bsnmp/dist/tests/asn1.cc   (contents, props changed)
  vendor/bsnmp/dist/tests/catch.hpp   (contents, props changed)
  vendor/bsnmp/dist/tests/constbuf.h   (contents, props changed)
  vendor/bsnmp/dist/tests/main.cc   (contents, props changed)
  vendor/bsnmp/dist/tests/snmp_parse_server.cc   (contents, props changed)
Deleted:
  vendor/bsnmp/dist/Makefile.in
  vendor/bsnmp/dist/README.1st
  vendor/bsnmp/dist/config/
  vendor/bsnmp/dist/configure.ac
  vendor/bsnmp/dist/gensnmpdef/Makefile.in
  vendor/bsnmp/dist/gensnmptree/Makefile.in
  vendor/bsnmp/dist/lib/Makefile.in
  vendor/bsnmp/dist/lib/snmptc.h.in
  vendor/bsnmp/dist/libbsnmp.pc.in
  vendor/bsnmp/dist/snmp_mibII/Makefile.in
  vendor/bsnmp/dist/snmp_ntp/Makefile.in
  vendor/bsnmp/dist/snmp_target/Makefile.in
  vendor/bsnmp/dist/snmp_usm/Makefile.in
  vendor/bsnmp/dist/snmp_vacm/Makefile.in
  vendor/bsnmp/dist/snmpd/Makefile.in
Modified:
  vendor/bsnmp/dist/gensnmptree/gensnmptree.1
  vendor/bsnmp/dist/gensnmptree/gensnmptree.c
  vendor/bsnmp/dist/lib/asn1.c
  vendor/bsnmp/dist/lib/bsnmpclient.3
  vendor/bsnmp/dist/lib/snmp.h
  vendor/bsnmp/dist/lib/snmpclient.c
  vendor/bsnmp/dist/lib/snmpclient.h
  vendor/bsnmp/dist/lib/snmpcrypto.c
  vendor/bsnmp/dist/lib/tc.def
  vendor/bsnmp/dist/snmp_mibII/mibII.c
  vendor/bsnmp/dist/snmp_mibII/mibII.h
  vendor/bsnmp/dist/snmp_mibII/mibII_interfaces.c
  vendor/bsnmp/dist/snmp_mibII/snmp_mibII.h
  vendor/bsnmp/dist/snmp_ntp/snmp_ntp.c
  vendor/bsnmp/dist/snmp_target/target_snmp.c
  vendor/bsnmp/dist/snmp_usm/usm_snmp.c
  vendor/bsnmp/dist/snmp_vacm/vacm_snmp.c
  vendor/bsnmp/dist/snmpd/BEGEMOT-SNMPD.txt
  vendor/bsnmp/dist/snmpd/main.c
  vendor/bsnmp/dist/snmpd/snmpd.config
  vendor/bsnmp/dist/snmpd/snmpd.h
  vendor/bsnmp/dist/snmpd/snmpmod.h
  vendor/bsnmp/dist/snmpd/trans_lsock.c
  vendor/bsnmp/dist/snmpd/trans_udp.c
  vendor/bsnmp/dist/snmpd/trap.c
  vendor/bsnmp/dist/snmpd/tree.def

Modified: vendor/bsnmp/dist/gensnmptree/gensnmptree.1
==
--- vendor/bsnmp/dist/gensnmptree/gensnmptree.1 Tue Mar 31 16:47:15 2020
(r359489)
+++ vendor/bsnmp/dist/gensnmptree/gensnmptree.1 Tue Mar 31 17:50:32 2020
(r359490)
@@ -2,7 +2,7 @@
 .\" Copyright (c) 2001-2005
 .\"Fraunhofer Institute for Open Communication Systems (FhG Fokus).
 .\"All rights reserved.
-.\" Copyright (c) 2006
+.\" Copyright (c) 2006,2018
 .\"Hartmut Brandt
 .\"All rights reserved.
 .\"
@@ -31,7 +31,7 @@
 .\"
 .\" $Begemot: gensnmptree.1 383 2006-05-30 07:40:49Z brandt_h $
 .\"
-.Dd May 26, 2006
+.Dd April 2, 2019
 .Dt GENSNMPTREE 1
 .Os
 .Sh NAME
@@ -39,7 +39,7 @@
 .Nd "generate C and header files from a MIB description file"
 .Sh SYNOPSIS
 .Nm
-.Op Fl dEehlt
+.Op Fl dEeFfhlt
 .Op Fl I Ar directory
 .Op Fl i Ar infile
 .Op Fl p Ar prefix
@@ -99,6 +99,12 @@ is the length of the OID.
 .It Va OID_ Ns Ar name
 is the last component of the OID.
 .El
+.It Fl F
+emit definitions for C-functions includeable in a C-file that do some basic
+stuff on enums like value checking and conversion between value and strings.
+.It Fl f
+emit definitions for inline C-functions that do some basic
+stuff on enums like value checking and conversion between value and strings.
 .It Fl h
 Print a short help page.
 .It Fl I Ar directory

Modified: vendor/bsnmp/dist/gensnmptree/gensnmptree.c
==
--- vendor/bsnmp/dist/gensnmptree/gensnmptree.c Tue Mar 31 16:47:15 2020
(r359489)
+++ vendor/bsnmp/dist/gensnmptree/gensnmptree.c Tue Mar 31 17:50:32 2020
(r359490)
@@ -123,9 +123,40 @@ options:\n\
   -i ifile read from the named file instead of stdin\n\
   -l   generate local include directives\n\
   -p prefixprepend prefix to file and variable names\n\
-  -t   generated a .def file\n\
+  -t   generate a .def file\n\
 ";
 
+/**
+ * Program operation.
+ */
+enum op {
+   /** generate the tree */
+   OP_GEN,
+
+   /** extract OIDs */
+   OP_EXTRACT,
+
+   /** print the parsed tree */
+   OP_TREE,
+
+   /** extract enums */
+   OP_ENUMS,
+};
+
+/**
+ * Which functions to create.
+ */
+enum gen_funcs {
+   /** none */
+   GEN_FUNCS_NONE,
+
+   /** functions for header files */
+   GEN_FUNCS_H,
+
+   /** functions for C files */
+   GEN_FUNCS_C,
+};
+
 /*
  * A node in the OID tree
  */
@@ -161,15 +192,18 @@ struct node {
uint32_tindex;  /* index for table entry 

svn commit: r359492 - in vendor: 1.14 bsnmp/1.14

2020-03-31 Thread Hartmut Brandt
Author: harti
Date: Tue Mar 31 17:57:11 2020
New Revision: 359492
URL: https://svnweb.freebsd.org/changeset/base/359492

Log:
  Move the bsnmp 1.14 import tag to the correct place.

Added:
  vendor/bsnmp/1.14/
 - copied from r359491, vendor/1.14/
Deleted:
  vendor/1.14/
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359491 - vendor/1.14

2020-03-31 Thread Hartmut Brandt
Author: harti
Date: Tue Mar 31 17:53:23 2020
New Revision: 359491
URL: https://svnweb.freebsd.org/changeset/base/359491

Log:
  Tag import of version 1.14 of bsnmp.

Added:
  vendor/1.14/
 - copied from r359490, vendor/bsnmp/dist/
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359483 - vendor-crypto/openssl/1.1.1f

2020-03-31 Thread Jung-uk Kim
Author: jkim
Date: Tue Mar 31 15:26:13 2020
New Revision: 359483
URL: https://svnweb.freebsd.org/changeset/base/359483

Log:
  Tag OpenSSL 1.1.1f.

Added:
  vendor-crypto/openssl/1.1.1f/
 - copied from r359482, vendor-crypto/openssl/dist/
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359487 - in head: share/man/man4 sys/netinet sys/netinet/tcp_stacks

2020-03-31 Thread Michael Tuexen
Author: tuexen
Date: Tue Mar 31 15:54:54 2020
New Revision: 359487
URL: https://svnweb.freebsd.org/changeset/base/359487

Log:
  Allow the TCP backhole detection to be disabled at all, enabled only
  for IPv4, enabled only for IPv6, and enabled for IPv4 and IPv6.
  The current blackhole detection might classify a temporary outage as
  an MTU issue and reduces permanently the MSS. Since the consequences of
  such a reduction due to a misclassification are much more drastically
  for IPv4 than for IPv6, allow the administrator to enable it for IPv6 only.
  
  Reviewed by:  bcr@ (man page), Richard Scheffenegger
  Sponsored by: Netflix, Inc.
  Differential Revision:https://reviews.freebsd.org/D24219

Modified:
  head/share/man/man4/tcp.4
  head/sys/netinet/tcp_stacks/bbr.c
  head/sys/netinet/tcp_stacks/rack.c
  head/sys/netinet/tcp_timer.c

Modified: head/share/man/man4/tcp.4
==
--- head/share/man/man4/tcp.4   Tue Mar 31 15:47:55 2020(r359486)
+++ head/share/man/man4/tcp.4   Tue Mar 31 15:54:54 2020(r359487)
@@ -34,7 +34,7 @@
 .\" From: @(#)tcp.48.1 (Berkeley) 6/5/93
 .\" $FreeBSD$
 .\"
-.Dd March 29, 2020
+.Dd March 31, 2020
 .Dt TCP 4
 .Os
 .Sh NAME
@@ -628,21 +628,31 @@ specific connection.
 This is needed to help with connection establishment
 when a broken firewall is in the network path.
 .It Va pmtud_blackhole_detection
-Turn on automatic path MTU blackhole detection.
-In case of retransmits OS will
-lower the MSS to check if it's MTU problem.
-If current MSS is greater than
-configured value to try
+Enable automatic path MTU blackhole detection.
+In case of retransmits of MSS sized segments,
+the OS will lower the MSS to check if it's an MTU problem.
+If the current MSS is greater than the configured value to try
 .Po Va net.inet.tcp.pmtud_blackhole_mss
 and
 .Va net.inet.tcp.v6pmtud_blackhole_mss
 .Pc ,
 it will be set to this value, otherwise,
-MSS will be set to default values
+the MSS will be set to the default values
 .Po Va net.inet.tcp.mssdflt
 and
 .Va net.inet.tcp.v6mssdflt
 .Pc .
+Settings:
+.Bl -tag -compact
+.It 0
+Disable path MTU blackhole detection.
+.It 1
+Enable path MTU blackhole detection for IPv4 and IPv6.
+.It 2
+Enable path MTU blackhole detection only for IPv4.
+.It 3
+Enable path MTU blackhole detection only for IPv6.
+.El
 .It Va pmtud_blackhole_mss
 MSS to try for IPv4 if PMTU blackhole detection is turned on.
 .It Va v6pmtud_blackhole_mss

Modified: head/sys/netinet/tcp_stacks/bbr.c
==
--- head/sys/netinet/tcp_stacks/bbr.c   Tue Mar 31 15:47:55 2020
(r359486)
+++ head/sys/netinet/tcp_stacks/bbr.c   Tue Mar 31 15:54:54 2020
(r359487)
@@ -5041,6 +5041,7 @@ bbr_timeout_rxt(struct tcpcb *tp, struct tcp_bbr *bbr,
 {
int32_t rexmt;
int32_t retval = 0;
+   bool isipv6;
 
bbr->r_ctl.rc_hpts_flags &= ~PACE_TMR_RXT;
if (bbr->rc_all_timers_stopped) {
@@ -5127,11 +5128,16 @@ bbr_timeout_rxt(struct tcpcb *tp, struct tcp_bbr *bbr,
 * of packets and process straight to FIN. In that case we won't
 * catch ESTABLISHED state.
 */
-   if (V_tcp_pmtud_blackhole_detect && (((tp->t_state == TCPS_ESTABLISHED))
-   || (tp->t_state == TCPS_FIN_WAIT_1))) {
 #ifdef INET6
-   int32_t isipv6;
+   isipv6 = (tp->t_inpcb->inp_vflag & INP_IPV6) ? true : false;
+#else
+   isipv6 = false;
 #endif
+   if (((V_tcp_pmtud_blackhole_detect == 1) ||
+   (V_tcp_pmtud_blackhole_detect == 2 && !isipv6) ||
+   (V_tcp_pmtud_blackhole_detect == 3 && isipv6)) &&
+   ((tp->t_state == TCPS_ESTABLISHED) ||
+   (tp->t_state == TCPS_FIN_WAIT_1))) {
 
/*
 * Idea here is that at each stage of mtu probe (usually,

Modified: head/sys/netinet/tcp_stacks/rack.c
==
--- head/sys/netinet/tcp_stacks/rack.c  Tue Mar 31 15:47:55 2020
(r359486)
+++ head/sys/netinet/tcp_stacks/rack.c  Tue Mar 31 15:54:54 2020
(r359487)
@@ -3123,6 +3123,7 @@ rack_timeout_rxt(struct tcpcb *tp, struct tcp_rack *ra
int32_t rexmt;
struct inpcb *inp;
int32_t retval = 0;
+   bool isipv6;
 
inp = tp->t_inpcb;
if (tp->t_timers->tt_flags & TT_STOPPED) {
@@ -3209,11 +3210,16 @@ rack_timeout_rxt(struct tcpcb *tp, struct tcp_rack *ra
 * of packets and process straight to FIN. In that case we won't
 * catch ESTABLISHED state.
 */
-   if (V_tcp_pmtud_blackhole_detect && (((tp->t_state == TCPS_ESTABLISHED))
-   || (tp->t_state == TCPS_FIN_WAIT_1))) {
 #ifdef INET6
-   int32_t isipv6;
+   isipv6 = (tp->t_inpcb->inp_vflag & INP_IPV6) ? true : false;
+#else
+   isipv6 = false;
 #endif
+   if 

svn commit: r359488 - head/share/mk

2020-03-31 Thread Simon J. Gerraty
Author: sjg
Date: Tue Mar 31 15:59:29 2020
New Revision: 359488
URL: https://svnweb.freebsd.org/changeset/base/359488

Log:
  Include ${.CURDIR}/local.init.mk if it exists
  
  This is handy for making local hacks to an app
  (eg to build it as tool for non-BSD host)
  without making a mess of the code base.
  
  Reviewed by:  bdrewery
  MFC after:1 week
  Differential Revision: https://reviews.freebsd.org//D24101

Modified:
  head/share/mk/local.init.mk

Modified: head/share/mk/local.init.mk
==
--- head/share/mk/local.init.mk Tue Mar 31 15:54:54 2020(r359487)
+++ head/share/mk/local.init.mk Tue Mar 31 15:59:29 2020(r359488)
@@ -1,5 +1,8 @@
 # $FreeBSD$
 
+.if !target(__${_this}__)
+__${_this}__:
+
 .if ${.MAKE.MODE:Mmeta*} != ""
 .if !empty(SUBDIR) && !defined(LIB) && !defined(PROG) && 
${.MAKE.MAKEFILES:M*bsd.prog.mk} == ""
 .if ${.MAKE.MODE:Mleaf*} != ""
@@ -33,3 +36,5 @@ CFLAGS+= ${HOST_CFLAGS}
 .endif
 
 .-include "src.init.mk"
+.-include "${.CURDIR}/local.init.mk"
+.endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r359436 - in head/sys: kern net sys

2020-03-31 Thread Kristof Provost

On 31 Mar 2020, at 17:28, Kristof Provost wrote:

On 31 Mar 2020, at 17:17, Mark Johnston wrote:

On Tue, Mar 31, 2020 at 03:51:27PM +0800, Li-Wen Hsu wrote:
On Tue, Mar 31, 2020 at 3:00 PM Kristof Provost  
wrote:


On 31 Mar 2020, at 7:56, Li-Wen Hsu wrote:
On Tue, Mar 31, 2020 at 10:55 AM Mark Johnston  
wrote:

It seems could be triggered by sys.netinet6.frag6.*
sys.netpfil.common.* sbin.pfctl.pfctl_test.* tests, and there 
are lots

of test cases timed out.

Can you help check these?


I see, it is actually caused by r359438.  I'm looking at it now.


I verified that the netpfil and netinet6 tests pass with r359477.


Thanks for the fixing, the latest test panics at epair_qflush:

https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14747/consoleFull

while executing sys.netpfil.pf.* tests. I'm not sure if this is
related or because of previous commits (I suspect the later). I'll
look into this.


That’s a know issue with epair (since EPOCH, I believe).
A number of the pf tests are disabled due to this. See 238870.


I also think so, btw, currently every test run panics so I am afraid
that the recent commits might make status worse (or say, make the
issue easier to reproduce?)


I haven't been able to reproduce any panics or test failures so far.


Once you disable the ‘atf_skip’ lines in the pf tests a simple 
`sudo kldload pfsync && cd /usr/tests/sys/netpfil/pf && sudo kyua 
test` is likely sufficient.


The names:names test is a great candidate for this. Remove the `atf_skip 
…` line in /usr/tests/sys/netpfil/pf/names and run that a few times.
It’s not 100% reliable, but the test is very fast and will likely 
panic every other run or more.


Example backtrace:

panic: epair_qflush: ifp=0xf800079c9000, epair_softc gone? sc=0

cpuid = 1
time = 1585666518
KDB: stack backtrace:
	db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 
0xfe001bd7e790

vpanic() at vpanic+0x182/frame 0xfe001bd7e7e0
panic() at panic+0x43/frame 0xfe001bd7e840
epair_qflush() at epair_qflush+0x1a8/frame 0xfe001bd7e890
if_down() at if_down+0x12d/frame 0xfe001bd7e8c0
	if_detach_internal() at if_detach_internal+0x2ee/frame 
0xfe001bd7e920

if_vmove() at if_vmove+0x3c/frame 0xfe001bd7e970
vnet_if_return() at vnet_if_return+0x50/frame 0xfe001bd7e990
vnet_destroy() at vnet_destroy+0x130/frame 0xfe001bd7e9c0
prison_deref() at prison_deref+0x29d/frame 0xfe001bd7ea00
	taskqueue_run_locked() at taskqueue_run_locked+0xaa/frame 
0xfe001bd7ea80
	taskqueue_thread_loop() at taskqueue_thread_loop+0x94/frame 
0xfe001bd7eab0

fork_exit() at fork_exit+0x80/frame 0xfe001bd7eaf0
fork_trampoline() at fork_trampoline+0xe/frame 0xfe001bd7eaf0
--- trap 0, rip = 0, rsp = 0, rbp = 0 ---
KDB: enter: panic
[ thread pid 0 tid 100014 ]
Stopped at  kdb_enter+0x37: movq$0,0x10927a6(%rip)
db>

You might see different panics too. The epair teardown flow is complex, 
and broken.


Best regards,
Kristof
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359486 - in head: crypto/openssl crypto/openssl/apps crypto/openssl/crypto crypto/openssl/crypto/bn crypto/openssl/crypto/conf crypto/openssl/crypto/err crypto/openssl/crypto/pkcs12 cr...

2020-03-31 Thread Jung-uk Kim
Author: jkim
Date: Tue Mar 31 15:47:55 2020
New Revision: 359486
URL: https://svnweb.freebsd.org/changeset/base/359486

Log:
  Merge OpenSSL 1.1.1f.

Modified:
  head/crypto/openssl/CHANGES
  head/crypto/openssl/NEWS
  head/crypto/openssl/README
  head/crypto/openssl/apps/rehash.c
  head/crypto/openssl/apps/s_server.c
  head/crypto/openssl/crypto/bn/bn_local.h
  head/crypto/openssl/crypto/bn/bn_prime.c
  head/crypto/openssl/crypto/conf/conf_lib.c
  head/crypto/openssl/crypto/err/openssl.txt
  head/crypto/openssl/crypto/ex_data.c
  head/crypto/openssl/crypto/pkcs12/p12_crt.c
  head/crypto/openssl/crypto/ts/ts_rsp_sign.c
  head/crypto/openssl/crypto/ts/ts_rsp_verify.c
  head/crypto/openssl/crypto/x509/x509_cmp.c
  head/crypto/openssl/crypto/x509/x509_trs.c
  head/crypto/openssl/crypto/x509/x509_vfy.c
  head/crypto/openssl/crypto/x509/x_all.c
  head/crypto/openssl/crypto/x509/x_crl.c
  head/crypto/openssl/crypto/x509v3/v3_purp.c
  head/crypto/openssl/doc/man3/BN_generate_prime.pod
  head/crypto/openssl/doc/man3/SSL_get_error.pod
  head/crypto/openssl/doc/man3/X509_get_extension_flags.pod
  head/crypto/openssl/include/openssl/opensslv.h
  head/crypto/openssl/include/openssl/sslerr.h
  head/crypto/openssl/ssl/record/rec_layer_s3.c
  head/crypto/openssl/ssl/ssl_err.c
  head/secure/lib/libcrypto/Makefile.inc
  head/secure/lib/libcrypto/man/man3/ADMISSIONS.3
  head/secure/lib/libcrypto/man/man3/ASN1_INTEGER_get_int64.3
  head/secure/lib/libcrypto/man/man3/ASN1_ITEM_lookup.3
  head/secure/lib/libcrypto/man/man3/ASN1_OBJECT_new.3
  head/secure/lib/libcrypto/man/man3/ASN1_STRING_TABLE_add.3
  head/secure/lib/libcrypto/man/man3/ASN1_STRING_length.3
  head/secure/lib/libcrypto/man/man3/ASN1_STRING_new.3
  head/secure/lib/libcrypto/man/man3/ASN1_STRING_print_ex.3
  head/secure/lib/libcrypto/man/man3/ASN1_TIME_set.3
  head/secure/lib/libcrypto/man/man3/ASN1_TYPE_get.3
  head/secure/lib/libcrypto/man/man3/ASN1_generate_nconf.3
  head/secure/lib/libcrypto/man/man3/ASYNC_WAIT_CTX_new.3
  head/secure/lib/libcrypto/man/man3/ASYNC_start_job.3
  head/secure/lib/libcrypto/man/man3/BF_encrypt.3
  head/secure/lib/libcrypto/man/man3/BIO_ADDR.3
  head/secure/lib/libcrypto/man/man3/BIO_ADDRINFO.3
  head/secure/lib/libcrypto/man/man3/BIO_connect.3
  head/secure/lib/libcrypto/man/man3/BIO_ctrl.3
  head/secure/lib/libcrypto/man/man3/BIO_f_base64.3
  head/secure/lib/libcrypto/man/man3/BIO_f_buffer.3
  head/secure/lib/libcrypto/man/man3/BIO_f_cipher.3
  head/secure/lib/libcrypto/man/man3/BIO_f_md.3
  head/secure/lib/libcrypto/man/man3/BIO_f_null.3
  head/secure/lib/libcrypto/man/man3/BIO_f_ssl.3
  head/secure/lib/libcrypto/man/man3/BIO_find_type.3
  head/secure/lib/libcrypto/man/man3/BIO_get_data.3
  head/secure/lib/libcrypto/man/man3/BIO_get_ex_new_index.3
  head/secure/lib/libcrypto/man/man3/BIO_meth_new.3
  head/secure/lib/libcrypto/man/man3/BIO_new.3
  head/secure/lib/libcrypto/man/man3/BIO_new_CMS.3
  head/secure/lib/libcrypto/man/man3/BIO_parse_hostserv.3
  head/secure/lib/libcrypto/man/man3/BIO_printf.3
  head/secure/lib/libcrypto/man/man3/BIO_push.3
  head/secure/lib/libcrypto/man/man3/BIO_read.3
  head/secure/lib/libcrypto/man/man3/BIO_s_accept.3
  head/secure/lib/libcrypto/man/man3/BIO_s_bio.3
  head/secure/lib/libcrypto/man/man3/BIO_s_connect.3
  head/secure/lib/libcrypto/man/man3/BIO_s_fd.3
  head/secure/lib/libcrypto/man/man3/BIO_s_file.3
  head/secure/lib/libcrypto/man/man3/BIO_s_mem.3
  head/secure/lib/libcrypto/man/man3/BIO_s_null.3
  head/secure/lib/libcrypto/man/man3/BIO_s_socket.3
  head/secure/lib/libcrypto/man/man3/BIO_set_callback.3
  head/secure/lib/libcrypto/man/man3/BIO_should_retry.3
  head/secure/lib/libcrypto/man/man3/BN_BLINDING_new.3
  head/secure/lib/libcrypto/man/man3/BN_CTX_new.3
  head/secure/lib/libcrypto/man/man3/BN_CTX_start.3
  head/secure/lib/libcrypto/man/man3/BN_add.3
  head/secure/lib/libcrypto/man/man3/BN_add_word.3
  head/secure/lib/libcrypto/man/man3/BN_bn2bin.3
  head/secure/lib/libcrypto/man/man3/BN_cmp.3
  head/secure/lib/libcrypto/man/man3/BN_copy.3
  head/secure/lib/libcrypto/man/man3/BN_generate_prime.3
  head/secure/lib/libcrypto/man/man3/BN_mod_inverse.3
  head/secure/lib/libcrypto/man/man3/BN_mod_mul_montgomery.3
  head/secure/lib/libcrypto/man/man3/BN_mod_mul_reciprocal.3
  head/secure/lib/libcrypto/man/man3/BN_new.3
  head/secure/lib/libcrypto/man/man3/BN_num_bytes.3
  head/secure/lib/libcrypto/man/man3/BN_rand.3
  head/secure/lib/libcrypto/man/man3/BN_security_bits.3
  head/secure/lib/libcrypto/man/man3/BN_set_bit.3
  head/secure/lib/libcrypto/man/man3/BN_swap.3
  head/secure/lib/libcrypto/man/man3/BN_zero.3
  head/secure/lib/libcrypto/man/man3/BUF_MEM_new.3
  head/secure/lib/libcrypto/man/man3/CMS_add0_cert.3
  head/secure/lib/libcrypto/man/man3/CMS_add1_recipient_cert.3
  head/secure/lib/libcrypto/man/man3/CMS_add1_signer.3
  head/secure/lib/libcrypto/man/man3/CMS_compress.3
  head/secure/lib/libcrypto/man/man3/CMS_decrypt.3
  head/secure/lib/libcrypto/man/man3/CMS_encrypt.3
  

svn commit: r359485 - stable/11/sys/dev/sound/pci/hda

2020-03-31 Thread Konstantin Belousov
Author: kib
Date: Tue Mar 31 15:28:31 2020
New Revision: 359485
URL: https://svnweb.freebsd.org/changeset/base/359485

Log:
  MFC r359396:
  hdaa: remove verbosity from the normal driver operations.

Modified:
  stable/11/sys/dev/sound/pci/hda/hdac.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/sound/pci/hda/hdac.c
==
--- stable/11/sys/dev/sound/pci/hda/hdac.c  Tue Mar 31 15:26:56 2020
(r359484)
+++ stable/11/sys/dev/sound/pci/hda/hdac.c  Tue Mar 31 15:28:31 2020
(r359485)
@@ -1409,21 +1409,11 @@ hdac_poll_reinit(struct hdac_softc *sc)
pollticks >>= 1;
if (pollticks > hz)
pollticks = hz;
-   if (pollticks < 1) {
-   HDA_BOOTVERBOSE(
-   device_printf(sc->dev,
-   "poll interval < 1 tick !\n");
-   );
+   if (pollticks < 1)
pollticks = 1;
-   }
if (min > pollticks)
min = pollticks;
}
-   HDA_BOOTVERBOSE(
-   device_printf(sc->dev,
-   "poll interval %d -> %d ticks\n",
-   sc->poll_ival, min);
-   );
sc->poll_ival = min;
if (min == 100)
callout_stop(>poll_callout);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r359436 - in head/sys: kern net sys

2020-03-31 Thread Kristof Provost

On 31 Mar 2020, at 17:17, Mark Johnston wrote:

On Tue, Mar 31, 2020 at 03:51:27PM +0800, Li-Wen Hsu wrote:
On Tue, Mar 31, 2020 at 3:00 PM Kristof Provost  
wrote:


On 31 Mar 2020, at 7:56, Li-Wen Hsu wrote:
On Tue, Mar 31, 2020 at 10:55 AM Mark Johnston  
wrote:

It seems could be triggered by sys.netinet6.frag6.*
sys.netpfil.common.* sbin.pfctl.pfctl_test.* tests, and there 
are lots

of test cases timed out.

Can you help check these?


I see, it is actually caused by r359438.  I'm looking at it now.


I verified that the netpfil and netinet6 tests pass with r359477.


Thanks for the fixing, the latest test panics at epair_qflush:

https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14747/consoleFull

while executing sys.netpfil.pf.* tests. I'm not sure if this is
related or because of previous commits (I suspect the later). I'll
look into this.


That’s a know issue with epair (since EPOCH, I believe).
A number of the pf tests are disabled due to this. See 238870.


I also think so, btw, currently every test run panics so I am afraid
that the recent commits might make status worse (or say, make the
issue easier to reproduce?)


I haven't been able to reproduce any panics or test failures so far.


Once you disable the ‘atf_skip’ lines in the pf tests a simple `sudo 
kldload pfsync && cd /usr/tests/sys/netpfil/pf && sudo kyua test` is 
likely sufficient.


There’s a complex race around tearing down epair interfaces and moving 
them back to their home vnet that’s proven very tricky to resolve.


Best regards,
Kristof
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359484 - stable/12/sys/dev/sound/pci/hda

2020-03-31 Thread Konstantin Belousov
Author: kib
Date: Tue Mar 31 15:26:56 2020
New Revision: 359484
URL: https://svnweb.freebsd.org/changeset/base/359484

Log:
  MFC r359396:
  hdaa: remove verbosity from the normal driver operations.

Modified:
  stable/12/sys/dev/sound/pci/hda/hdac.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/sound/pci/hda/hdac.c
==
--- stable/12/sys/dev/sound/pci/hda/hdac.c  Tue Mar 31 15:26:13 2020
(r359483)
+++ stable/12/sys/dev/sound/pci/hda/hdac.c  Tue Mar 31 15:26:56 2020
(r359484)
@@ -1408,21 +1408,11 @@ hdac_poll_reinit(struct hdac_softc *sc)
pollticks >>= 1;
if (pollticks > hz)
pollticks = hz;
-   if (pollticks < 1) {
-   HDA_BOOTVERBOSE(
-   device_printf(sc->dev,
-   "poll interval < 1 tick !\n");
-   );
+   if (pollticks < 1)
pollticks = 1;
-   }
if (min > pollticks)
min = pollticks;
}
-   HDA_BOOTVERBOSE(
-   device_printf(sc->dev,
-   "poll interval %d -> %d ticks\n",
-   sc->poll_ival, min);
-   );
sc->poll_ival = min;
if (min == 100)
callout_stop(>poll_callout);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359482 - in vendor-crypto/openssl/dist: . apps crypto crypto/bn crypto/conf crypto/err crypto/pkcs12 crypto/ts crypto/x509 crypto/x509v3 doc/man3 include/openssl ssl ssl/record

2020-03-31 Thread Jung-uk Kim
Author: jkim
Date: Tue Mar 31 15:25:23 2020
New Revision: 359482
URL: https://svnweb.freebsd.org/changeset/base/359482

Log:
  Import OpenSSL 1.1.1f.

Modified:
  vendor-crypto/openssl/dist/CHANGES
  vendor-crypto/openssl/dist/NEWS
  vendor-crypto/openssl/dist/README
  vendor-crypto/openssl/dist/apps/rehash.c
  vendor-crypto/openssl/dist/apps/s_server.c
  vendor-crypto/openssl/dist/crypto/bn/bn_local.h
  vendor-crypto/openssl/dist/crypto/bn/bn_prime.c
  vendor-crypto/openssl/dist/crypto/conf/conf_lib.c
  vendor-crypto/openssl/dist/crypto/err/openssl.txt
  vendor-crypto/openssl/dist/crypto/ex_data.c
  vendor-crypto/openssl/dist/crypto/pkcs12/p12_crt.c
  vendor-crypto/openssl/dist/crypto/ts/ts_rsp_sign.c
  vendor-crypto/openssl/dist/crypto/ts/ts_rsp_verify.c
  vendor-crypto/openssl/dist/crypto/x509/x509_cmp.c
  vendor-crypto/openssl/dist/crypto/x509/x509_trs.c
  vendor-crypto/openssl/dist/crypto/x509/x509_vfy.c
  vendor-crypto/openssl/dist/crypto/x509/x_all.c
  vendor-crypto/openssl/dist/crypto/x509/x_crl.c
  vendor-crypto/openssl/dist/crypto/x509v3/v3_purp.c
  vendor-crypto/openssl/dist/doc/man3/BN_generate_prime.pod
  vendor-crypto/openssl/dist/doc/man3/SSL_get_error.pod
  vendor-crypto/openssl/dist/doc/man3/X509_get_extension_flags.pod
  vendor-crypto/openssl/dist/include/openssl/opensslv.h
  vendor-crypto/openssl/dist/include/openssl/sslerr.h
  vendor-crypto/openssl/dist/ssl/record/rec_layer_s3.c
  vendor-crypto/openssl/dist/ssl/ssl_err.c

Modified: vendor-crypto/openssl/dist/CHANGES
==
--- vendor-crypto/openssl/dist/CHANGES  Tue Mar 31 13:48:06 2020
(r359481)
+++ vendor-crypto/openssl/dist/CHANGES  Tue Mar 31 15:25:23 2020
(r359482)
@@ -7,6 +7,24 @@
  https://github.com/openssl/openssl/commits/ and pick the appropriate
  release branch.
 
+ Changes between 1.1.1e and 1.1.1f [31 Mar 2020]
+
+  *) Revert the change of EOF detection while reading in libssl to avoid
+ regressions in applications depending on the current way of reporting
+ the EOF. As the existing method is not fully accurate the change to
+ reporting the EOF via SSL_ERROR_SSL is kept on the current development
+ branch and will be present in the 3.0 release.
+ [Tomas Mraz]
+
+  *) Revised BN_generate_prime_ex to not avoid factors 3..17863 in p-1
+ when primes for RSA keys are computed.
+ Since we previously always generated primes == 2 (mod 3) for RSA keys,
+ the 2-prime and 3-prime RSA modules were easy to distinguish, since
+ N = p*q = 1 (mod 3), but N = p*q*r = 2 (mod 3). Therefore fingerprinting
+ 2-prime vs. 3-prime RSA keys was possible by computing N mod 3.
+ This avoids possible fingerprinting of newly generated RSA modules.
+ [Bernd Edlinger]
+
  Changes between 1.1.1d and 1.1.1e [17 Mar 2020]
   *) Properly detect EOF while reading in libssl. Previously if we hit an EOF
  while reading in libssl then we would report an error back to the

Modified: vendor-crypto/openssl/dist/NEWS
==
--- vendor-crypto/openssl/dist/NEWS Tue Mar 31 13:48:06 2020
(r359481)
+++ vendor-crypto/openssl/dist/NEWS Tue Mar 31 15:25:23 2020
(r359482)
@@ -5,10 +5,16 @@
   This file gives a brief overview of the major changes between each OpenSSL
   release. For more details please read the CHANGES file.
 
+  Major changes between OpenSSL 1.1.1e and OpenSSL 1.1.1f [31 Mar 2020]
+
+  o Revert the unexpected EOF reporting via SSL_ERROR_SSL
+
   Major changes between OpenSSL 1.1.1d and OpenSSL 1.1.1e [17 Mar 2020]
 
   o Fixed an overflow bug in the x64_64 Montgomery squaring procedure
 used in exponentiation with 512-bit moduli (CVE-2019-1551)
+  o Properly detect unexpected EOF while reading in libssl and report
+it via SSL_ERROR_SSL
 
   Major changes between OpenSSL 1.1.1c and OpenSSL 1.1.1d [10 Sep 2019]
 

Modified: vendor-crypto/openssl/dist/README
==
--- vendor-crypto/openssl/dist/README   Tue Mar 31 13:48:06 2020
(r359481)
+++ vendor-crypto/openssl/dist/README   Tue Mar 31 15:25:23 2020
(r359482)
@@ -1,7 +1,7 @@
 
- OpenSSL 1.1.1e 17 Mar 2020
+ OpenSSL 1.1.1f 31 Mar 2020
 
- Copyright (c) 1998-2019 The OpenSSL Project
+ Copyright (c) 1998-2020 The OpenSSL Project
  Copyright (c) 1995-1998 Eric A. Young, Tim J. Hudson
  All rights reserved.
 

Modified: vendor-crypto/openssl/dist/apps/rehash.c
==
--- vendor-crypto/openssl/dist/apps/rehash.cTue Mar 31 13:48:06 2020
(r359481)
+++ vendor-crypto/openssl/dist/apps/rehash.cTue Mar 31 15:25:23 2020
(r359482)
@@ -1,5 +1,5 @@
 /*
- * Copyright 2015-2019 The OpenSSL Project Authors. All Rights Reserved.
+ * Copyright 2015-2020 The OpenSSL Project Authors. All 

Re: svn commit: r359436 - in head/sys: kern net sys

2020-03-31 Thread Mark Johnston
On Tue, Mar 31, 2020 at 03:51:27PM +0800, Li-Wen Hsu wrote:
> On Tue, Mar 31, 2020 at 3:00 PM Kristof Provost  wrote:
> >
> > On 31 Mar 2020, at 7:56, Li-Wen Hsu wrote:
> > > On Tue, Mar 31, 2020 at 10:55 AM Mark Johnston  wrote:
> >  It seems could be triggered by sys.netinet6.frag6.*
> >  sys.netpfil.common.* sbin.pfctl.pfctl_test.* tests, and there are lots
> >  of test cases timed out.
> > 
> >  Can you help check these?
> > >>>
> > >>> I see, it is actually caused by r359438.  I'm looking at it now.
> > >>
> > >> I verified that the netpfil and netinet6 tests pass with r359477.
> > >
> > > Thanks for the fixing, the latest test panics at epair_qflush:
> > >
> > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14747/consoleFull
> > >
> > > while executing sys.netpfil.pf.* tests. I'm not sure if this is
> > > related or because of previous commits (I suspect the later). I'll
> > > look into this.
> > >
> > That’s a know issue with epair (since EPOCH, I believe).
> > A number of the pf tests are disabled due to this. See 238870.
> 
> I also think so, btw, currently every test run panics so I am afraid
> that the recent commits might make status worse (or say, make the
> issue easier to reproduce?)

I haven't been able to reproduce any panics or test failures so far.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359481 - head/contrib/jemalloc/include/jemalloc

2020-03-31 Thread Edward Tomasz Napierala
Author: trasz
Date: Tue Mar 31 13:48:06 2020
New Revision: 359481
URL: https://svnweb.freebsd.org/changeset/base/359481

Log:
  Make jemalloc(3) default to retain:true on 64-bit platforms,
  like it already does on Linux and OSX.  This results in significantly
  fewer calls to mmap(2).  This should result in a small reduction
  in system CPU time and improved superpage usage.
  
  Reviewed by:  markj
  Tested by:markj
  MFC after:2 weeks
  Sponsored by: DARPA
  Differential Revision:https://reviews.freebsd.org/D23874

Modified:
  head/contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h

Modified: head/contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h
==
--- head/contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h   Tue Mar 31 
13:43:09 2020(r359480)
+++ head/contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h   Tue Mar 31 
13:48:06 2020(r359481)
@@ -72,6 +72,10 @@
 #  define LG_SIZEOF_PTR3
 #endif
 
+#if LG_VADDR > 32
+#  define JEMALLOC_RETAIN
+#endif
+
 #ifndef JEMALLOC_TLS_MODEL
 #  define JEMALLOC_TLS_MODEL   /* Default. */
 #endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359480 - head/usr.sbin/ctld

2020-03-31 Thread Edward Tomasz Napierala
Author: trasz
Date: Tue Mar 31 13:43:09 2020
New Revision: 359480
URL: https://svnweb.freebsd.org/changeset/base/359480

Log:
  Add 'ctld -t', to test configuration file validity.
  
  Reviewed by:  mav, allanjude, bcr (man pages)
  MFC after:2 weeks
  Sponsored by: Klara Inc.
  Differential Revision:https://reviews.freebsd.org/D23792

Modified:
  head/usr.sbin/ctld/ctld.8
  head/usr.sbin/ctld/ctld.c

Modified: head/usr.sbin/ctld/ctld.8
==
--- head/usr.sbin/ctld/ctld.8   Tue Mar 31 06:25:43 2020(r359479)
+++ head/usr.sbin/ctld/ctld.8   Tue Mar 31 13:43:09 2020(r359480)
@@ -27,7 +27,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd March 23, 2018
+.Dd March 31, 2020
 .Dt CTLD 8
 .Os
 .Sh NAME
@@ -38,6 +38,10 @@
 .Op Fl d
 .Op Fl f Ar config-file
 .Op Fl u
+.Nm
+.Fl t
+.Op Fl f Ar config-file
+.Op Fl u
 .Sh DESCRIPTION
 The
 .Nm
@@ -90,6 +94,8 @@ The daemon sends verbose debug output to standard erro
 put itself in the background.
 The daemon will also not fork and will exit after processing one connection.
 This option is only intended for debugging the target.
+.It Fl t
+Test the configuration file for validity and exit.
 .It Fl u
 Use UCL configuration file format instead of the traditional non-UCL format.
 .El

Modified: head/usr.sbin/ctld/ctld.c
==
--- head/usr.sbin/ctld/ctld.c   Tue Mar 31 06:25:43 2020(r359479)
+++ head/usr.sbin/ctld/ctld.c   Tue Mar 31 13:43:09 2020(r359480)
@@ -69,6 +69,7 @@ usage(void)
 {
 
fprintf(stderr, "usage: ctld [-d][-u][-f config-file]\n");
+   fprintf(stderr, "   ctld -t [-u][-f config-file]\n");
exit(1);
 }
 
@@ -2663,14 +2664,18 @@ main(int argc, char **argv)
const char *config_path = DEFAULT_CONFIG_PATH;
int debug = 0, ch, error;
bool dont_daemonize = false;
+   bool test_config = false;
bool use_ucl = false;
 
-   while ((ch = getopt(argc, argv, "duf:R")) != -1) {
+   while ((ch = getopt(argc, argv, "dtuf:R")) != -1) {
switch (ch) {
case 'd':
dont_daemonize = true;
debug++;
break;
+   case 't':
+   test_config = true;
+   break;
case 'u':
use_ucl = true;
break;
@@ -2701,6 +2706,10 @@ main(int argc, char **argv)
 
if (newconf == NULL)
log_errx(1, "configuration error; exiting");
+
+   if (test_config)
+   return (0);
+
if (debug > 0) {
oldconf->conf_debug = debug;
newconf->conf_debug = debug;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r359436 - in head/sys: kern net sys

2020-03-31 Thread Li-Wen Hsu
On Tue, Mar 31, 2020 at 3:00 PM Kristof Provost  wrote:
>
> On 31 Mar 2020, at 7:56, Li-Wen Hsu wrote:
> > On Tue, Mar 31, 2020 at 10:55 AM Mark Johnston  wrote:
>  It seems could be triggered by sys.netinet6.frag6.*
>  sys.netpfil.common.* sbin.pfctl.pfctl_test.* tests, and there are lots
>  of test cases timed out.
> 
>  Can you help check these?
> >>>
> >>> I see, it is actually caused by r359438.  I'm looking at it now.
> >>
> >> I verified that the netpfil and netinet6 tests pass with r359477.
> >
> > Thanks for the fixing, the latest test panics at epair_qflush:
> >
> > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14747/consoleFull
> >
> > while executing sys.netpfil.pf.* tests. I'm not sure if this is
> > related or because of previous commits (I suspect the later). I'll
> > look into this.
> >
> That’s a know issue with epair (since EPOCH, I believe).
> A number of the pf tests are disabled due to this. See 238870.

I also think so, btw, currently every test run panics so I am afraid
that the recent commits might make status worse (or say, make the
issue easier to reproduce?)

Best,
Li-Wen
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r359479 - in head: share/man/man4 sys/dev/intel sys/modules sys/modules/pchtherm

2020-03-31 Thread Takanori Watanabe
Author: takawata
Date: Tue Mar 31 06:25:43 2020
New Revision: 359479
URL: https://svnweb.freebsd.org/changeset/base/359479

Log:
  Add Platform Controller Hub built-in thermal management device driver.
  
  Differential Revision:https://reviews.freebsd.org/D24077

Added:
  head/share/man/man4/pchtherm.4   (contents, props changed)
  head/sys/dev/intel/pchtherm.c   (contents, props changed)
  head/sys/modules/pchtherm/
  head/sys/modules/pchtherm/Makefile   (contents, props changed)
Modified:
  head/share/man/man4/Makefile
  head/sys/modules/Makefile

Modified: head/share/man/man4/Makefile
==
--- head/share/man/man4/MakefileTue Mar 31 02:36:39 2020
(r359478)
+++ head/share/man/man4/MakefileTue Mar 31 06:25:43 2020
(r359479)
@@ -404,6 +404,7 @@ MAN=aac.4 \
pccard.4 \
pccbb.4 \
pcf.4 \
+   ${_pchtherm.4} \
pci.4 \
pcib.4 \
pcic.4 \
@@ -815,6 +816,7 @@ _nvd.4= nvd.4
 _nvme.4=   nvme.4
 _nvram.4=  nvram.4
 _padlock.4=padlock.4
+_pchtherm.4=   pchtherm.4
 _rr232x.4= rr232x.4
 _speaker.4=speaker.4
 _spkr.4=   spkr.4

Added: head/share/man/man4/pchtherm.4
==
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ head/share/man/man4/pchtherm.4  Tue Mar 31 06:25:43 2020
(r359479)
@@ -0,0 +1,117 @@
+.\"
+.\" Copyright (c) 2020 Takanori Watanabe 
+.\"
+.\" Redistribution and use in source and binary forms, with or without
+.\" modification, are permitted provided that the following conditions
+.\" are met:
+.\" 1. Redistributions of source code must retain the above copyright
+.\"notice, this list of conditions and the following disclaimer.
+.\" 2. Redistributions in binary form must reproduce the above copyright
+.\"notice, this list of conditions and the following disclaimer in the
+.\"documentation and/or other materials provided with the distribution.
+.\"
+.\" THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
+.\" IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+.\" OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+.\" IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+.\" INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+.\" NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+.\" DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+.\" THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+.\" (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+.\" THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+.\"
+.\" $FreeBSD$
+.\"
+.Dd March 15, 2020
+.Dt pchtherm 4
+.Os
+.Sh NAME
+.Nm pchtherm
+.Nd Intel PCH thermal subsystem
+.Sh SYNOPSIS
+.Cd "device pci"
+.Cd "device pchtherm"
+.Sh DESCRIPTION
+The
+.Nm
+driver provides access to sensor data and configuration 
+installed in Intel PCH chipset.
+.Nm
+configuration register.
+.Pp
+The access to
+.Nm
+data is made via the
+.Xr sysctl 8
+interface:
+.Bd -literal
+dev.pchtherm.0.ctt: 115.0C
+dev.pchtherm.0.temperature: 28.5C
+dev.pchtherm.0.t2temp: 91.0C
+dev.pchtherm.0.t1temp: 86.0C
+dev.pchtherm.0.t0temp: 81.0C
+dev.pchtherm.0.tahv: 83.0C
+dev.pchtherm.0.talv: 30.0C
+dev.pchtherm.0.pmtime: 32
+dev.pchtherm.0.pmtemp: 50.0C
+dev.pchtherm.0.%parent: pci0
+dev.pchtherm.0.%pnpinfo: vendor=0x8086 device=0x9d31 subvendor=0x17aa 
subdevice=0x2256 class=0x118000
+dev.pchtherm.0.%location: slot=20 function=2 dbsf=pci0:0:20:2
+dev.pchtherm.0.%driver: pchtherm
+dev.pchtherm.0.%desc: Skylake PCH Thermal Subsystem
+dev.pchtherm.%parent: 
+.Ed
+.Bl -tag -width ".Va dev.pchtherm.%d.pch_hot_level"
+.It Va dev.pchtherm.%d.temperature
+Is the read-only value of the current temperature read by the sensor.
+.It Va dev.pchtherm.%d.ctt
+When the system reaches this temperature, it will shut down.
+This will not appear when this feature is disabled and locked down.
+.It Va dev.pchtherm.%d.t0temp
+When temperature is under this value, system will be in T0 state.
+.It Va dev.pchtherm.%d.t1temp
+When temperature is over
+.Va t0temp
+and under this value, system will be in T1 state.
+.It Va dev.pchtherm.%d.t2temp
+When temperature is over
+.Va t1temp
+and under this value, system will be in T2 state.
+Over this value, system will be in T3 state.
+.It Va dev.pchtherm.%d.talv
+Lower alart value.
+This will not appear when sensor enable bit is locked down and the value is 
zero(which will show -50.0C).
+.It Va dev.pchtherm.%d.tahv
+High alart value.
+This will not appear when sensor enable bit is locked down and the value is 
zero(which will show -50.0C).
+.It Va dev.pchtherm.%d.pmtemp
+Sensor Power management temperature.
+Under this temperature, sensor will idle during
+.Va 

Re: svn commit: r359436 - in head/sys: kern net sys

2020-03-31 Thread Kristof Provost
On 31 Mar 2020, at 7:56, Li-Wen Hsu wrote:
> On Tue, Mar 31, 2020 at 10:55 AM Mark Johnston  wrote:
 It seems could be triggered by sys.netinet6.frag6.*
 sys.netpfil.common.* sbin.pfctl.pfctl_test.* tests, and there are lots
 of test cases timed out.

 Can you help check these?
>>>
>>> I see, it is actually caused by r359438.  I'm looking at it now.
>>
>> I verified that the netpfil and netinet6 tests pass with r359477.
>
> Thanks for the fixing, the latest test panics at epair_qflush:
>
> https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14747/consoleFull
>
> while executing sys.netpfil.pf.* tests. I'm not sure if this is
> related or because of previous commits (I suspect the later). I'll
> look into this.
>
That’s a know issue with epair (since EPOCH, I believe).
A number of the pf tests are disabled due to this. See 238870.

Best regards,
Kristof
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r359459 - head/share/man/man5

2020-03-31 Thread Alexey Dokuchaev
On Mon, Mar 30, 2020 at 07:39:39PM -0400, Ed Maste wrote:
> On Mon, 30 Mar 2020 at 19:03, John Baldwin  wrote:
> >
> > and I haven't seen the commit to
> > actually remove GDB_LIBEXEC yet?
> 
> I haven't seen the commit mail for r359457 yet either, but the change
> is committed.

As of recently, commit mail gets significantly delayed for some reason,
per what I've also observed.

./danfe
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"