Re: svn commit: r244732 - head/sys/sys

2012-12-28 Thread Attilio Rao
On Fri, Dec 28, 2012 at 9:20 AM, Gleb Smirnoff gleb...@freebsd.org wrote: On Thu, Dec 27, 2012 at 08:37:24AM -0800, Attilio Rao wrote: A Speaking of which, as you are here, I just found out that r241037 A breaks the alignment of the structure. A Infact the padding member is not updated

svn commit: r244774 - head/sys/sys

2012-12-28 Thread Attilio Rao
Author: attilio Date: Fri Dec 28 17:41:36 2012 New Revision: 244774 URL: http://svnweb.freebsd.org/changeset/base/244774 Log: Improve bufring impl: - Remove unused br_prod_bufs member - Fixup r241037: buf_ring pads br_prod_* and br_cons_* members at 128 bytes, assuming a fixed cache

svn commit: r244732 - head/sys/sys

2012-12-27 Thread Attilio Rao
Author: attilio Date: Thu Dec 27 12:36:58 2012 New Revision: 244732 URL: http://svnweb.freebsd.org/changeset/base/244732 Log: br_prod_tail and br_cons_tail members are used as barrier to signal bug_ring ownership. However, instructions can be reordered around members write leading to stale

svn commit: r244733 - head/sys/sys

2012-12-27 Thread Attilio Rao
Author: attilio Date: Thu Dec 27 12:53:46 2012 New Revision: 244733 URL: http://svnweb.freebsd.org/changeset/base/244733 Log: Remove an unused var. Sponsored by: EMC / Isilon storage division MFC after:3 days Modified: head/sys/sys/buf_ring.h Modified: head/sys/sys/buf_ring.h

Re: svn commit: r244732 - head/sys/sys

2012-12-27 Thread Attilio Rao
On Thu, Dec 27, 2012 at 4:46 AM, Gleb Smirnoff gleb...@freebsd.org wrote: Attilio, On Thu, Dec 27, 2012 at 12:36:58PM +, Attilio Rao wrote: A Author: attilio A Date: Thu Dec 27 12:36:58 2012 A New Revision: 244732 A URL: http://svnweb.freebsd.org/changeset/base/244732 A A Log

Re: svn commit: r244732 - head/sys/sys

2012-12-27 Thread Attilio Rao
On Thu, Dec 27, 2012 at 5:25 AM, Gleb Smirnoff gleb...@freebsd.org wrote: On Thu, Dec 27, 2012 at 04:55:22AM -0800, Attilio Rao wrote: A On Thu, Dec 27, 2012 at 4:46 AM, Gleb Smirnoff gleb...@freebsd.org wrote: AAttilio, A A On Thu, Dec 27, 2012 at 12:36:58PM +, Attilio Rao wrote

Re: svn commit: r244732 - head/sys/sys

2012-12-27 Thread Attilio Rao
On Thu, Dec 27, 2012 at 5:53 AM, Attilio Rao atti...@freebsd.org wrote: On Thu, Dec 27, 2012 at 5:25 AM, Gleb Smirnoff gleb...@freebsd.org wrote: On Thu, Dec 27, 2012 at 04:55:22AM -0800, Attilio Rao wrote: A On Thu, Dec 27, 2012 at 4:46 AM, Gleb Smirnoff gleb...@freebsd.org wrote

Re: svn commit: r244732 - head/sys/sys

2012-12-27 Thread Attilio Rao
On Thu, Dec 27, 2012 at 7:26 AM, Attilio Rao atti...@freebsd.org wrote: On Thu, Dec 27, 2012 at 5:53 AM, Attilio Rao atti...@freebsd.org wrote: On Thu, Dec 27, 2012 at 5:25 AM, Gleb Smirnoff gleb...@freebsd.org wrote: On Thu, Dec 27, 2012 at 04:55:22AM -0800, Attilio Rao wrote: A On Thu, Dec

Re: svn commit: r244732 - head/sys/sys

2012-12-27 Thread Attilio Rao
On Thu, Dec 27, 2012 at 8:37 AM, Attilio Rao atti...@freebsd.org wrote: On Thu, Dec 27, 2012 at 7:26 AM, Attilio Rao atti...@freebsd.org wrote: On Thu, Dec 27, 2012 at 5:53 AM, Attilio Rao atti...@freebsd.org wrote: On Thu, Dec 27, 2012 at 5:25 AM, Gleb Smirnoff gleb...@freebsd.org wrote

svn commit: r244706 - head/sys/kern

2012-12-26 Thread Attilio Rao
Author: attilio Date: Wed Dec 26 15:20:32 2012 New Revision: 244706 URL: http://svnweb.freebsd.org/changeset/base/244706 Log: Fixup r244240: mp_ncpus will be 1 also in the !SMP and smp_disabled=1 case. There is no point in optimizing further the code and use a TRUE litteral for a path that

svn commit: r244582 - head/sys/kern

2012-12-22 Thread Attilio Rao
Author: attilio Date: Sat Dec 22 09:37:34 2012 New Revision: 244582 URL: http://svnweb.freebsd.org/changeset/base/244582 Log: Fixup r240424: On entering KDB backends, the hijacked thread to run interrupt context can still be idlethread. At that point, without the panic condition, it can

Re: svn commit: r244582 - head/sys/kern

2012-12-22 Thread Attilio Rao
On Sat, Dec 22, 2012 at 10:51 AM, Bruce Evans b...@optusnet.com.au wrote: On Sat, 22 Dec 2012, Attilio Rao wrote: Log: Fixup r240424: On entering KDB backends, the hijacked thread to run interrupt context can still be idlethread. At that point, without the panic condition, it can still

Re: svn commit: r244582 - head/sys/kern

2012-12-22 Thread Attilio Rao
On Sat, Dec 22, 2012 at 1:20 PM, Bruce Evans b...@optusnet.com.au wrote: On Sat, 22 Dec 2012, Attilio Rao wrote: On Sat, Dec 22, 2012 at 10:51 AM, Bruce Evans b...@optusnet.com.au wrote: On Sat, 22 Dec 2012, Attilio Rao wrote: Log: Fixup r240424: On entering KDB backends, the hijacked

svn commit: r244534 - in head/sys: kern ufs/ffs

2012-12-21 Thread Attilio Rao
Author: attilio Date: Fri Dec 21 13:14:12 2012 New Revision: 244534 URL: http://svnweb.freebsd.org/changeset/base/244534 Log: Fixup r218424: uio_yield() was scaling directly to userland priority. When kern_yield() was introduced with the possibility to specify a new priority, the behaviour

Re: svn commit: r243515 - head/sys/kern

2012-12-16 Thread Attilio Rao
On Sun, Dec 16, 2012 at 1:59 AM, Andriy Gapon a...@freebsd.org wrote: on 13/12/2012 22:17 Attilio Rao said the following: Right, but as I said, for the time being we can at least have a correct panic() semantic and take the right time to fix the generic_stop_cpus() and then absorb also

Re: svn commit: r243515 - head/sys/kern

2012-12-13 Thread Attilio Rao
On Thu, Dec 13, 2012 at 10:59 AM, Andriy Gapon a...@freebsd.org wrote: on 09/12/2012 19:27 Attilio Rao said the following: On Sun, Nov 25, 2012 at 2:22 PM, Andriy Gapon a...@freebsd.org wrote: Author: avg Date: Sun Nov 25 14:22:08 2012 New Revision: 243515 URL: http://svnweb.freebsd.org

Re: svn commit: r243515 - head/sys/kern

2012-12-09 Thread Attilio Rao
On Sun, Nov 25, 2012 at 2:22 PM, Andriy Gapon a...@freebsd.org wrote: Author: avg Date: Sun Nov 25 14:22:08 2012 New Revision: 243515 URL: http://svnweb.freebsd.org/changeset/base/243515 Log: remove stop_scheduler_on_panic knob There has not been any complaints about the default

Re: svn commit: r236938 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include x86/acpica

2012-12-09 Thread Attilio Rao
On Tue, Jun 12, 2012 at 1:14 AM, Mitsuru IWASAKI iwas...@freebsd.org wrote: Author: iwasaki Date: Tue Jun 12 00:14:54 2012 New Revision: 236938 URL: http://svn.freebsd.org/changeset/base/236938 Log: Share IPI init and startup code of mp_machdep.c with acpi_wakeup.c as ipi_startup().

svn commit: r244046 - head/sys/kern

2012-12-08 Thread Attilio Rao
Author: attilio Date: Sun Dec 9 04:54:22 2012 New Revision: 244046 URL: http://svnweb.freebsd.org/changeset/base/244046 Log: Add a comment on why inlining critical_enter() may not be a good idea for the general case. Reviewed by: bde MFC after:1 week Modified:

Re: svn commit: r243980 - in head/sys: kern sys

2012-12-07 Thread Attilio Rao
On Fri, Dec 7, 2012 at 8:25 AM, Alfred Perlstein alf...@freebsd.org wrote: Author: alfred Date: Fri Dec 7 08:25:08 2012 New Revision: 243980 URL: http://svnweb.freebsd.org/changeset/base/243980 Log: Allow KASSERT to log instead of panic. This is to allow debug images to be used

svn commit: r243900 - head/sys/kern

2012-12-05 Thread Attilio Rao
Author: attilio Date: Wed Dec 5 15:11:01 2012 New Revision: 243900 URL: http://svnweb.freebsd.org/changeset/base/243900 Log: Check for lockmgr recursion in case of disown and downgrade and panic also in !debugging kernel rather than having undefined behaviour. Tested by:avg MFC

svn commit: r243912 - head/sys/kern

2012-12-05 Thread Attilio Rao
Author: attilio Date: Wed Dec 5 22:32:12 2012 New Revision: 243912 URL: http://svnweb.freebsd.org/changeset/base/243912 Log: Fixup r243901: - As the comment report, CALLOUT_LOCAL_ALLOC cannot be checked directly from the callout flags but might be checked by a cached value. Hence,

Re: svn commit: r243599 - head/sys/kern

2012-11-27 Thread Attilio Rao
On Tue, Nov 27, 2012 at 6:07 AM, David Xu davi...@freebsd.org wrote: Author: davidxu Date: Tue Nov 27 06:07:58 2012 New Revision: 243599 URL: http://svnweb.freebsd.org/changeset/base/243599 Log: Take first active vnode correctly. Thanks. I had send the exact same report to Kirk and Jeff

Re: svn commit: r243599 - head/sys/kern

2012-11-27 Thread Attilio Rao
On Tue, Nov 27, 2012 at 2:35 PM, David Xu listlog2...@gmail.com wrote: On 2012/11/27 21:52, Attilio Rao wrote: On Tue, Nov 27, 2012 at 6:07 AM, David Xu davi...@freebsd.org wrote: Author: davidxu Date: Tue Nov 27 06:07:58 2012 New Revision: 243599 URL: http://svnweb.freebsd.org/changeset

Re: svn commit: r243311 - in head/sys: fs/ext2fs fs/msdosfs fs/nfsclient fs/nullfs fs/unionfs gnu/fs/reiserfs nfsclient ufs/ffs

2012-11-20 Thread Attilio Rao
On Tue, Nov 20, 2012 at 6:20 AM, Bruce Evans b...@optusnet.com.au wrote: On Mon, 19 Nov 2012, Attilio Rao wrote: Log: r16312 is not any longer real since many years (likely since when VFS received granular locking) but the comment present in UFS has been copied all over other filesystems

Re: svn commit: r243311 - in head/sys: fs/ext2fs fs/msdosfs fs/nfsclient fs/nullfs fs/unionfs gnu/fs/reiserfs nfsclient ufs/ffs

2012-11-20 Thread Attilio Rao
On 11/20/12, Bruce Evans b...@optusnet.com.au wrote: On Tue, 20 Nov 2012, Attilio Rao wrote: On Tue, Nov 20, 2012 at 6:20 AM, Bruce Evans b...@optusnet.com.au wrote: On Mon, 19 Nov 2012, Attilio Rao wrote: Log: r16312 is not any longer real since many years (likely since when VFS

Re: svn commit: r243311 - in head/sys: fs/ext2fs fs/msdosfs fs/nfsclient fs/nullfs fs/unionfs gnu/fs/reiserfs nfsclient ufs/ffs

2012-11-20 Thread Attilio Rao
On 11/20/12, Attilio Rao atti...@freebsd.org wrote: On 11/20/12, Bruce Evans b...@optusnet.com.au wrote: On Tue, 20 Nov 2012, Attilio Rao wrote: On Tue, Nov 20, 2012 at 6:20 AM, Bruce Evans b...@optusnet.com.au wrote: On Mon, 19 Nov 2012, Attilio Rao wrote: Log: r16312 is not any longer

Re: svn commit: r243311 - in head/sys: fs/ext2fs fs/msdosfs fs/nfsclient fs/nullfs fs/unionfs gnu/fs/reiserfs nfsclient ufs/ffs

2012-11-20 Thread Attilio Rao
On 11/20/12, Bruce Evans b...@optusnet.com.au wrote: On Tue, 20 Nov 2012, Attilio Rao wrote: On 11/20/12, Attilio Rao atti...@freebsd.org wrote: On 11/20/12, Bruce Evans b...@optusnet.com.au wrote: On Tue, 20 Nov 2012, Attilio Rao wrote: On Tue, Nov 20, 2012 at 6:20 AM, Bruce Evans b

Re: svn commit: r243311 - in head/sys: fs/ext2fs fs/msdosfs fs/nfsclient fs/nullfs fs/unionfs gnu/fs/reiserfs nfsclient ufs/ffs

2012-11-20 Thread Attilio Rao
On 11/20/12, Konstantin Belousov kostik...@gmail.com wrote: On Tue, Nov 20, 2012 at 01:27:07PM +, Attilio Rao wrote: On 11/20/12, Bruce Evans b...@optusnet.com.au wrote: On Tue, 20 Nov 2012, Attilio Rao wrote: On 11/20/12, Attilio Rao atti...@freebsd.org wrote: On 11/20/12, Bruce

svn commit: r243307 - head/sys/kern

2012-11-19 Thread Attilio Rao
Author: attilio Date: Mon Nov 19 20:43:19 2012 New Revision: 243307 URL: http://svnweb.freebsd.org/changeset/base/243307 Log: insmntque() is always called with the lock held in exclusive mode, then: - assume the lock is held in exclusive mode and remove a moot check about the lock

Re: svn commit: r243307 - head/sys/kern

2012-11-19 Thread Attilio Rao
On Mon, Nov 19, 2012 at 8:53 PM, Davide Italiano dav...@freebsd.org wrote: On Mon, Nov 19, 2012 at 9:43 PM, Attilio Rao atti...@freebsd.org wrote: Author: attilio Date: Mon Nov 19 20:43:19 2012 New Revision: 243307 URL: http://svnweb.freebsd.org/changeset/base/243307 Log: insmntque

Re: svn commit: r243307 - head/sys/kern

2012-11-19 Thread Attilio Rao
On Mon, Nov 19, 2012 at 9:08 PM, Davide Italiano dav...@freebsd.org wrote: On Mon, Nov 19, 2012 at 9:55 PM, Attilio Rao atti...@freebsd.org wrote: On Mon, Nov 19, 2012 at 8:53 PM, Davide Italiano dav...@freebsd.org wrote: On Mon, Nov 19, 2012 at 9:43 PM, Attilio Rao atti...@freebsd.org wrote

svn commit: r243311 - in head/sys: fs/ext2fs fs/msdosfs fs/nfsclient fs/nullfs fs/unionfs gnu/fs/reiserfs nfsclient ufs/ffs

2012-11-19 Thread Attilio Rao
Author: attilio Date: Mon Nov 19 22:43:45 2012 New Revision: 243311 URL: http://svnweb.freebsd.org/changeset/base/243311 Log: r16312 is not any longer real since many years (likely since when VFS received granular locking) but the comment present in UFS has been copied all over other

svn commit: r242988 - head/sys/sys

2012-11-13 Thread Attilio Rao
Author: attilio Date: Tue Nov 13 18:24:47 2012 New Revision: 242988 URL: http://svnweb.freebsd.org/changeset/base/242988 Log: Remove unused/obsolete macros. MFC after:3 days Modified: head/sys/sys/lock.h Modified: head/sys/sys/lock.h

svn commit: r242901 - head/sys/sys

2012-11-11 Thread Attilio Rao
Author: attilio Date: Sun Nov 11 23:25:47 2012 New Revision: 242901 URL: http://svnweb.freebsd.org/changeset/base/242901 Log: Tweak comments. In collabouration with: alc Modified: head/sys/sys/_mutex.h head/sys/sys/_rwlock.h Modified: head/sys/sys/_mutex.h

svn commit: r242903 - head/sys/vm

2012-11-11 Thread Attilio Rao
Author: attilio Date: Mon Nov 12 00:30:40 2012 New Revision: 242903 URL: http://svnweb.freebsd.org/changeset/base/242903 Log: Fix DDB command show map XXX: - Check that an argument is always available, otherwise current map printing before to recurse is garbage. - Spit out a message if

svn commit: r242875 - head/sys/fs/fuse

2012-11-10 Thread Attilio Rao
Author: attilio Date: Sat Nov 10 19:32:16 2012 New Revision: 242875 URL: http://svnweb.freebsd.org/changeset/base/242875 Log: - Protect mnt_data and mnt_flags under the mount interlock - Move mp-mnt_stat manipulation where all of them happens Reported by: davide Discussed with:

svn commit: r242833 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs fs/cd9660 fs/devfs fs/ext2fs fs/fdescfs fs/fuse fs/msdosfs fs/nandfs fs/nfsclient fs/nullfs fs/pseudofs fs/tmpfs fs/udf...

2012-11-09 Thread Attilio Rao
Author: attilio Date: Fri Nov 9 18:02:25 2012 New Revision: 242833 URL: http://svnweb.freebsd.org/changeset/base/242833 Log: Complete MPSAFE VFS interface and remove MNTK_MPSAFE flag. Porters should refer to __FreeBSD_version 121 for this change as it may have happened at the same

Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens

2012-11-09 Thread Attilio Rao
On Tue, Nov 6, 2012 at 10:50 PM, Ben Kaduk minimar...@gmail.com wrote: On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov k...@freebsd.org wrote: Author: kib Date: Mon Oct 22 17:50:54 2012 New Revision: 241896 URL: http://svn.freebsd.org/changeset/base/241896 Log: Remove the support

Re: svn commit: r242833 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs fs/cd9660 fs/devfs fs/ext2fs fs/fdescfs fs/fuse fs/msdosfs fs/nandfs fs/nfsclient fs/nullfs fs/pseudofs fs/tmpfs fs/ud

2012-11-09 Thread Attilio Rao
On Fri, Nov 9, 2012 at 6:11 PM, Konstantin Belousov kostik...@gmail.com wrote: On Fri, Nov 09, 2012 at 06:02:26PM +, Attilio Rao wrote: Author: attilio Date: Fri Nov 9 18:02:25 2012 New Revision: 242833 URL: http://svnweb.freebsd.org/changeset/base/242833 Log: Complete MPSAFE VFS

Re: svn commit: r242833 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs fs/cd9660 fs/devfs fs/ext2fs fs/fdescfs fs/fuse fs/msdosfs fs/nandfs fs/nfsclient fs/nullfs fs/pseudofs fs/tmpfs fs/ud

2012-11-09 Thread Attilio Rao
On Fri, Nov 9, 2012 at 6:47 PM, Attilio Rao atti...@freebsd.org wrote: On Fri, Nov 9, 2012 at 6:11 PM, Konstantin Belousov kostik...@gmail.com wrote: On Fri, Nov 09, 2012 at 06:02:26PM +, Attilio Rao wrote: Author: attilio Date: Fri Nov 9 18:02:25 2012 New Revision: 242833 URL: http

Re: svn commit: r242833 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs fs/cd9660 fs/devfs fs/ext2fs fs/fdescfs fs/fuse fs/msdosfs fs/nandfs fs/nfsclient fs/nullfs fs/pseudofs fs/tmpfs fs/ud

2012-11-09 Thread Attilio Rao
On 11/9/12, Konstantin Belousov kostik...@gmail.com wrote: On Fri, Nov 09, 2012 at 06:50:52PM +, Attilio Rao wrote: On Fri, Nov 9, 2012 at 6:47 PM, Attilio Rao atti...@freebsd.org wrote: On Fri, Nov 9, 2012 at 6:11 PM, Konstantin Belousov kostik...@gmail.com wrote: On Fri, Nov 09, 2012

Re: svn commit: r242727 - head/sys/fs/fuse

2012-11-08 Thread Attilio Rao
On 11/8/12, Attilio Rao atti...@freebsd.org wrote: Author: attilio Date: Thu Nov 8 00:32:49 2012 New Revision: 242727 URL: http://svnweb.freebsd.org/changeset/base/242727 Log: - Current caching mode is completely broken because it simply relies on timing of the operations

svn commit: r242727 - head/sys/fs/fuse

2012-11-07 Thread Attilio Rao
Author: attilio Date: Thu Nov 8 00:32:49 2012 New Revision: 242727 URL: http://svnweb.freebsd.org/changeset/base/242727 Log: - Current caching mode is completely broken because it simply relies on timing of the operations and not real lookup, bringing too many false positives. Remove

Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens

2012-11-06 Thread Attilio Rao
On Tue, Nov 6, 2012 at 10:50 PM, Ben Kaduk minimar...@gmail.com wrote: On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov k...@freebsd.org wrote: Author: kib Date: Mon Oct 22 17:50:54 2012 New Revision: 241896 URL: http://svn.freebsd.org/changeset/base/241896 Log: Remove the support

Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens

2012-11-06 Thread Attilio Rao
On Tue, Nov 6, 2012 at 11:03 PM, Ben Kaduk minimar...@gmail.com wrote: On Tue, Nov 6, 2012 at 5:53 PM, Attilio Rao atti...@freebsd.org wrote: On Tue, Nov 6, 2012 at 10:50 PM, Ben Kaduk minimar...@gmail.com wrote: On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov k...@freebsd.org wrote: Hi

Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens

2012-11-06 Thread Attilio Rao
On Tue, Nov 6, 2012 at 11:17 PM, Ben Kaduk minimar...@gmail.com wrote: I do not wish to belabor the point; we all have better things to do with our time. Hopefully this is my last message on the topic. On Tue, Nov 6, 2012 at 6:10 PM, Attilio Rao atti...@freebsd.org wrote: The point

Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens

2012-11-06 Thread Attilio Rao
On Tue, Nov 6, 2012 at 11:38 PM, Alexander Motin m...@freebsd.org wrote: On 07.11.2012 01:20, Attilio Rao wrote: On Tue, Nov 6, 2012 at 11:17 PM, Ben Kaduk minimar...@gmail.com wrote: I do not wish to belabor the point; we all have better things to do with our time. Hopefully this is my

svn commit: r242616 - head/sys/fs/fuse

2012-11-05 Thread Attilio Rao
Author: attilio Date: Mon Nov 5 15:23:54 2012 New Revision: 242616 URL: http://svnweb.freebsd.org/changeset/base/242616 Log: fuse_io* must be able to crunch also VDIR vnodes. Update assert appropriately. Reported and Tested by: flo MFC after:2 months X-MFC:

svn commit: r242515 - in head/sys: kern sys

2012-11-03 Thread Attilio Rao
Author: attilio Date: Sat Nov 3 15:57:37 2012 New Revision: 242515 URL: http://svn.freebsd.org/changeset/base/242515 Log: Merge r242395,242483 from mutex implementation: give rwlock(9) the ability to crunch different type of structures, with the only constraint that they have a lock cookie

svn commit: r242534 - in head/sys: amd64/amd64 i386/i386 ia64/ia64 mips/mips powerpc/aim sparc64/include sparc64/sparc64

2012-11-03 Thread Attilio Rao
Author: attilio Date: Sat Nov 3 23:03:14 2012 New Revision: 242534 URL: http://svn.freebsd.org/changeset/base/242534 Log: Rework the known rwlock to benefit about staying on their own cache line in order to avoid manual frobbing but using struct rwlock_padalign. Reviewed by: alc,

svn commit: r242536 - head/sys/fs/fuse

2012-11-03 Thread Attilio Rao
Author: attilio Date: Sat Nov 3 23:32:32 2012 New Revision: 242536 URL: http://svn.freebsd.org/changeset/base/242536 Log: Fix a bug where operations was carried on even if not implemented, leading to handling of an invalid fdip object. Reported and tested by: flo MFC after:2

svn commit: r242483 - head/sys/sys

2012-11-02 Thread Attilio Rao
Author: attilio Date: Fri Nov 2 16:31:01 2012 New Revision: 242483 URL: http://svn.freebsd.org/changeset/base/242483 Log: Tweak comment to make more clear why it will fail. Submitted by: jimharris Modified: head/sys/sys/mutex.h Modified: head/sys/sys/mutex.h

Re: svn commit: r242402 - in head/sys: kern vm

2012-11-01 Thread Attilio Rao
On 11/1/12, Gleb Smirnoff gleb...@freebsd.org wrote: On Wed, Oct 31, 2012 at 06:33:51PM +, Attilio Rao wrote: A Doesn't this padding to cache line size only help x86 processors in an A SMP kernel? I was expecting to see some #ifdef SMP so that we don't pay A a big price for no gain

Re: svn commit: r242402 - in head/sys: kern vm

2012-11-01 Thread Attilio Rao
On 10/31/12, Andre Oppermann an...@freebsd.org wrote: On 31.10.2012 19:10, Attilio Rao wrote: On Wed, Oct 31, 2012 at 6:07 PM, Attilio Rao atti...@freebsd.org wrote: Author: attilio Date: Wed Oct 31 18:07:18 2012 New Revision: 242402 URL: http://svn.freebsd.org/changeset/base/242402 Log

Re: svn commit: r242402 - in head/sys: kern vm

2012-11-01 Thread Attilio Rao
On Thu, Nov 1, 2012 at 2:01 PM, Ian Lepore free...@damnhippie.dyndns.org wrote: On Thu, 2012-11-01 at 10:42 +, Attilio Rao wrote: On 11/1/12, Gleb Smirnoff gleb...@freebsd.org wrote: On Wed, Oct 31, 2012 at 06:33:51PM +, Attilio Rao wrote: A Doesn't this padding to cache line size

Re: svn commit: r242402 - in head/sys: kern vm

2012-11-01 Thread Attilio Rao
On Thu, Nov 1, 2012 at 2:05 PM, Attilio Rao atti...@freebsd.org wrote: On Thu, Nov 1, 2012 at 2:01 PM, Ian Lepore free...@damnhippie.dyndns.org wrote: On Thu, 2012-11-01 at 10:42 +, Attilio Rao wrote: On 11/1/12, Gleb Smirnoff gleb...@freebsd.org wrote: On Wed, Oct 31, 2012 at 06:33:51PM

Re: svn commit: r242402 - in head/sys: kern vm

2012-11-01 Thread Attilio Rao
On 11/1/12, Ian Lepore free...@damnhippie.dyndns.org wrote: On Thu, 2012-11-01 at 14:07 +, Attilio Rao wrote: On Thu, Nov 1, 2012 at 2:05 PM, Attilio Rao atti...@freebsd.org wrote: On Thu, Nov 1, 2012 at 2:01 PM, Ian Lepore free...@damnhippie.dyndns.org wrote: On Thu, 2012-11-01 at 10

Re: svn commit: r242402 - in head/sys: kern vm

2012-11-01 Thread Attilio Rao
On 11/1/12, Andre Oppermann an...@freebsd.org wrote: On 01.11.2012 12:53, Attilio Rao wrote: On 10/31/12, Andre Oppermann an...@freebsd.org wrote: On 31.10.2012 19:10, Attilio Rao wrote: On Wed, Oct 31, 2012 at 6:07 PM, Attilio Rao atti...@freebsd.org wrote: Author: attilio Date: Wed Oct 31

svn commit: r242395 - in head/sys: kern sys

2012-10-31 Thread Attilio Rao
Author: attilio Date: Wed Oct 31 13:38:56 2012 New Revision: 242395 URL: http://svn.freebsd.org/changeset/base/242395 Log: Give mtx(9) the ability to crunch different type of structures, with the only constraint that they have a lock cookie named mtx_lock. This name, then, becames reserved

svn commit: r242402 - in head/sys: kern vm

2012-10-31 Thread Attilio Rao
Author: attilio Date: Wed Oct 31 18:07:18 2012 New Revision: 242402 URL: http://svn.freebsd.org/changeset/base/242402 Log: Rework the known mutexes to benefit about staying on their own cache line in order to avoid manual frobbing but using struct mtx_padalign. The sole exception being

Re: svn commit: r242402 - in head/sys: kern vm

2012-10-31 Thread Attilio Rao
On Wed, Oct 31, 2012 at 6:07 PM, Attilio Rao atti...@freebsd.org wrote: Author: attilio Date: Wed Oct 31 18:07:18 2012 New Revision: 242402 URL: http://svn.freebsd.org/changeset/base/242402 Log: Rework the known mutexes to benefit about staying on their own cache line in order to avoid

Re: svn commit: r242402 - in head/sys: kern vm

2012-10-31 Thread Attilio Rao
On Wed, Oct 31, 2012 at 6:26 PM, Ian Lepore free...@damnhippie.dyndns.org wrote: On Wed, 2012-10-31 at 18:10 +, Attilio Rao wrote: On Wed, Oct 31, 2012 at 6:07 PM, Attilio Rao atti...@freebsd.org wrote: Author: attilio Date: Wed Oct 31 18:07:18 2012 New Revision: 242402 URL: http

Re: svn commit: r242402 - in head/sys: kern vm

2012-10-31 Thread Attilio Rao
On 10/31/12, Adrian Chadd adr...@freebsd.org wrote: On 31 October 2012 11:33, Attilio Rao atti...@freebsd.org wrote: Doesn't this padding to cache line size only help x86 processors in an SMP kernel? I was expecting to see some #ifdef SMP so that we don't pay a big price for no gain in small

Re: svn commit: r242402 - in head/sys: kern vm

2012-10-31 Thread Attilio Rao
On Wed, Oct 31, 2012 at 8:31 PM, Andre Oppermann an...@freebsd.org wrote: On 31.10.2012 20:40, Ian Lepore wrote: On Thu, 2012-11-01 at 06:30 +1100, Peter Jeremy wrote: On 2012-Oct-31 18:57:37 +, Attilio Rao atti...@freebsd.org wrote: On 10/31/12, Adrian Chadd adr...@freebsd.org wrote

Re: svn commit: r242402 - in head/sys: kern vm

2012-10-31 Thread Attilio Rao
On Wed, Oct 31, 2012 at 11:25 PM, Jim Harris jim.har...@gmail.com wrote: On Wed, Oct 31, 2012 at 3:55 PM, Attilio Rao atti...@freebsd.org wrote: On Wed, Oct 31, 2012 at 8:31 PM, Andre Oppermann an...@freebsd.org wrote: You can define CACHE_LINE_SIZE to 0 on those platforms. Or to make

svn commit: r242356 - head/sys/kern

2012-10-30 Thread Attilio Rao
Author: attilio Date: Tue Oct 30 12:25:52 2012 New Revision: 242356 URL: http://svn.freebsd.org/changeset/base/242356 Log: tdq_lock_pair() already does spinlock_enter() so migration is not possible in sched_balance_pair(). Remove redundant sched_pin(). Reviewed by: marius, jeff

svn commit: r242361 - in head/sys: dev/hwpmc kern

2012-10-30 Thread Attilio Rao
Author: attilio Date: Tue Oct 30 15:10:50 2012 New Revision: 242361 URL: http://svn.freebsd.org/changeset/base/242361 Log: Fixup r240246: hwpmc needs to retain the pinning until ASTs are not executed. This means past the point where userret() is generally executed. Skip the td_pinned

Re: svn commit: r242274 - head/sys/sys

2012-10-29 Thread Attilio Rao
On 10/29/12, Gleb Smirnoff gleb...@freebsd.org wrote: On Mon, Oct 29, 2012 at 01:35:17AM +, Attilio Rao wrote: A Author: attilio A Date: Mon Oct 29 01:35:17 2012 A New Revision: 242274 A URL: http://svn.freebsd.org/changeset/base/242274 A A Log: A Compiler have a precise knowledge

svn commit: r242274 - head/sys/sys

2012-10-28 Thread Attilio Rao
Author: attilio Date: Mon Oct 29 01:35:17 2012 New Revision: 242274 URL: http://svn.freebsd.org/changeset/base/242274 Log: Compiler have a precise knowledge of the content of sched_pin() and sched_unpin() as they are functions static and inline. This way it can do two dangerous things: -

Re: svn commit: r241897 - in head: . sys/sys

2012-10-27 Thread Attilio Rao
On Mon, Oct 22, 2012 at 9:28 PM, Gleb Smirnoff gleb...@freebsd.org wrote: On Mon, Oct 22, 2012 at 07:28:42PM +0100, Attilio Rao wrote: A On 10/22/12, Konstantin Belousov k...@freebsd.org wrote: A Author: kib A Date: Mon Oct 22 17:54:32 2012 A New Revision: 241897 A URL: http

Re: svn commit: r242014 - head/sys/kern

2012-10-24 Thread Attilio Rao
On Wed, Oct 24, 2012 at 8:00 PM, Jim Harris jim.har...@gmail.com wrote: On Wed, Oct 24, 2012 at 11:43 AM, John Baldwin j...@freebsd.org wrote: On Wednesday, October 24, 2012 2:36:41 pm Jim Harris wrote: Author: jimharris Date: Wed Oct 24 18:36:41 2012 New Revision: 242014 URL:

Re: svn commit: r242014 - head/sys/kern

2012-10-24 Thread Attilio Rao
On Wed, Oct 24, 2012 at 7:56 PM, Jim Harris jim.har...@gmail.com wrote: On Wed, Oct 24, 2012 at 11:41 AM, Adrian Chadd adr...@freebsd.org wrote: On 24 October 2012 11:36, Jim Harris jimhar...@freebsd.org wrote: Pad tdq_lock to avoid false sharing with tdq_load and tdq_cpu_idle. Ok, but..

Re: svn commit: r242014 - head/sys/kern

2012-10-24 Thread Attilio Rao
On Wed, Oct 24, 2012 at 8:16 PM, Andre Oppermann an...@freebsd.org wrote: On 24.10.2012 20:56, Jim Harris wrote: On Wed, Oct 24, 2012 at 11:41 AM, Adrian Chadd adr...@freebsd.org wrote: On 24 October 2012 11:36, Jim Harris jimhar...@freebsd.org wrote: Pad tdq_lock to avoid false sharing

Re: svn commit: r242014 - head/sys/kern

2012-10-24 Thread Attilio Rao
On Wed, Oct 24, 2012 at 8:30 PM, Alexander Motin m...@freebsd.org wrote: On 24.10.2012 22:16, Andre Oppermann wrote: On 24.10.2012 20:56, Jim Harris wrote: On Wed, Oct 24, 2012 at 11:41 AM, Adrian Chadd adr...@freebsd.org wrote: On 24 October 2012 11:36, Jim Harris jimhar...@freebsd.org

Re: svn commit: r242014 - head/sys/kern

2012-10-24 Thread Attilio Rao
On Wed, Oct 24, 2012 at 9:25 PM, Andre Oppermann an...@freebsd.org wrote: On 24.10.2012 21:06, Attilio Rao wrote: On Wed, Oct 24, 2012 at 8:00 PM, Jim Harris jim.har...@gmail.com wrote: On Wed, Oct 24, 2012 at 11:43 AM, John Baldwin j...@freebsd.org wrote: On Wednesday, October 24, 2012 2

Re: svn commit: r241897 - in head: . sys/sys

2012-10-22 Thread Attilio Rao
On 10/22/12, Konstantin Belousov k...@freebsd.org wrote: Author: kib Date: Mon Oct 22 17:54:32 2012 New Revision: 241897 URL: http://svn.freebsd.org/changeset/base/241897 Log: Bump __FreeBSD_version and make a note in UPDATING about removal of the support for non-MPSAFE filesystems.

Re: svn commit: r241636 - in head: etc/mtree include lib/libprocstat rescue/rescue sbin sbin/mount share/dict share/man/man7 sys/boot/forth sys/conf sys/geom/label sys/kern sys/mips/rmi sys/modules sy

2012-10-18 Thread Attilio Rao
On 10/18/12, Gleb Kurtsou gleb.kurt...@gmail.com wrote: On (17/10/2012 11:30), Attilio Rao wrote: Author: attilio Date: Wed Oct 17 11:30:00 2012 New Revision: 241636 URL: http://svn.freebsd.org/changeset/base/241636 Log: Disconnect non-MPSAFE NTFS from the build in preparation

svn commit: r241680 - in head: etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/examples/etc share/mk sys/conf sys/kern sys/modules sys/sys usr.bin u...

2012-10-18 Thread Attilio Rao
Author: attilio Date: Thu Oct 18 12:04:56 2012 New Revision: 241680 URL: http://svn.freebsd.org/changeset/base/241680 Log: Disconnect non-MPSAFE SMBFS from the build in preparation for dropping GIANT from VFS. In addition, disconnect also netsmb, which is a base requirement for SMBFS.

Re: svn commit: r241680 - in head: etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/examples/etc share/mk sys/conf sys/kern sys/modules sys/sys usr.bin

2012-10-18 Thread Attilio Rao
On Thu, Oct 18, 2012 at 1:04 PM, Attilio Rao atti...@freebsd.org wrote: Author: attilio Date: Thu Oct 18 12:04:56 2012 New Revision: 241680 URL: http://svn.freebsd.org/changeset/base/241680 Log: Disconnect non-MPSAFE SMBFS from the build in preparation for dropping GIANT from VFS

svn commit: r241682 - head

2012-10-18 Thread Attilio Rao
Author: attilio Date: Thu Oct 18 12:11:13 2012 New Revision: 241682 URL: http://svn.freebsd.org/changeset/base/241682 Log: Record the full non-MPSAFE pack filesystem disconnect. Modified: head/UPDATING Modified: head/UPDATING

svn commit: r241706 - in head/sys: conf geom/label modules/geom/geom_label

2012-10-18 Thread Attilio Rao
Author: attilio Date: Thu Oct 18 22:18:11 2012 New Revision: 241706 URL: http://svn.freebsd.org/changeset/base/241706 Log: It seems that it is preferable to keep support for glabel also for filesystems that we don't support natively. Revert part of r241636 to do so. This patch is not

svn commit: r241629 - in head: . etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/man/man5 share/man/man7 share/mk sys/conf sys/kern sys/modules usr....

2012-10-17 Thread Attilio Rao
Author: attilio Date: Wed Oct 17 11:16:17 2012 New Revision: 241629 URL: http://svn.freebsd.org/changeset/base/241629 Log: Disconnect non-MPSAFE NWFS from the build in preparation for dropping GIANT from VFS. In addition, disconnect also netncp, which is a base requirement for NWFS. In

svn commit: r241636 - in head: etc/mtree include lib/libprocstat rescue/rescue sbin sbin/mount share/dict share/man/man7 sys/boot/forth sys/conf sys/geom/label sys/kern sys/mips/rmi sys/modules sys...

2012-10-17 Thread Attilio Rao
Author: attilio Date: Wed Oct 17 11:30:00 2012 New Revision: 241636 URL: http://svn.freebsd.org/changeset/base/241636 Log: Disconnect non-MPSAFE NTFS from the build in preparation for dropping GIANT from VFS. This code is particulary broken and fragile and other in-kernel implementations

svn commit: r241641 - head/include

2012-10-17 Thread Attilio Rao
Author: attilio Date: Wed Oct 17 13:04:05 2012 New Revision: 241641 URL: http://svn.freebsd.org/changeset/base/241641 Log: Include a piece that was left out during r241629. Pointy hat to:me Modified: head/include/Makefile Modified: head/include/Makefile

Re: svn commit: r241629 - in head: . etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/man/man5 share/man/man7 share/mk sys/conf sys/kern sys/modules usr

2012-10-17 Thread Attilio Rao
On Wed, Oct 17, 2012 at 6:23 PM, Andreas Tobler andre...@freebsd.org wrote: On 17.10.12 13:16, Attilio Rao wrote: Author: attilio Date: Wed Oct 17 11:16:17 2012 New Revision: 241629 URL: http://svn.freebsd.org/changeset/base/241629 Log: Disconnect non-MPSAFE NWFS from the build

Re: svn commit: r241629 - in head: . etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/man/man5 share/man/man7 share/mk sys/conf sys/kern sys/modules usr

2012-10-17 Thread Attilio Rao
On Wed, Oct 17, 2012 at 6:41 PM, Andreas Tobler andre...@freebsd.org wrote: On 17.10.12 19:35, Attilio Rao wrote: On Wed, Oct 17, 2012 at 6:23 PM, Andreas Tobler andre...@freebsd.org wrote: On 17.10.12 13:16, Attilio Rao wrote: Author: attilio Date: Wed Oct 17 11:16:17 2012 New Revision

svn commit: r241604 - in head/sys: conf kern

2012-10-16 Thread Attilio Rao
Author: attilio Date: Tue Oct 16 09:55:31 2012 New Revision: 241604 URL: http://svn.freebsd.org/changeset/base/241604 Log: Disconnect non-MPSAFE HPFS from the build in preparation for dropping GIANT from VFS. This is not targeted for MFC. Modified: head/sys/conf/NOTES

svn commit: r241606 - in head: etc/defaults etc/mtree include sbin/mount share/doc/smm/01.setup share/examples share/man/man7 sys/boot/forth sys/conf sys/kern sys/modules usr.sbin usr.sbin/crunch/e...

2012-10-16 Thread Attilio Rao
Author: attilio Date: Tue Oct 16 09:59:10 2012 New Revision: 241606 URL: http://svn.freebsd.org/changeset/base/241606 Log: Disconnect non-MPSAFE PORTALFS from the build in preparation for dropping GIANT from VFS. This is not targeted for MFC. Modified: head/etc/defaults/rc.conf

svn commit: r241607 - in head: . share/man/man5 sys/boot/forth sys/conf sys/modules

2012-10-16 Thread Attilio Rao
Author: attilio Date: Tue Oct 16 10:04:00 2012 New Revision: 241607 URL: http://svn.freebsd.org/changeset/base/241607 Log: Disconnect non-MPSAFE XFS from the build in preparation for dropping GIANT from VFS. This is not targeted for MFC. Modified: head/MAINTAINERS

svn commit: r241608 - in head: share/man/man4 sys/boot/forth sys/conf sys/modules

2012-10-16 Thread Attilio Rao
Author: attilio Date: Tue Oct 16 10:09:21 2012 New Revision: 241608 URL: http://svn.freebsd.org/changeset/base/241608 Log: Disconnect non-MPSAFE CODAFS from the build in preparation for dropping GIANT from VFS. This is not targeted for MFC. Modified: head/share/man/man4/Makefile

svn commit: r241519 - in head: . sbin sbin/mount_fusefs sys/conf sys/fs/fuse sys/modules sys/modules/fuse

2012-10-13 Thread Attilio Rao
Author: attilio Date: Sat Oct 13 23:54:26 2012 New Revision: 241519 URL: http://svn.freebsd.org/changeset/base/241519 Log: Import a FreeBSD port of the FUSE Linux module. This has been developed during 2 summer of code mandates and being revived by gnn recently. The functionality in this

svn commit: r241521 - head/sys/fs/fuse

2012-10-13 Thread Attilio Rao
Author: attilio Date: Sun Oct 14 03:51:59 2012 New Revision: 241521 URL: http://svn.freebsd.org/changeset/base/241521 Log: Rename s/DEBUG()/FS_DEBUG() and s/DEBUG2G()/FS_DEBUG2G() in order to avoid a name clash in sparc64. MFC after:2 months X-MFC:r241519 Modified:

svn commit: r241522 - head/sbin/mount_fusefs

2012-10-13 Thread Attilio Rao
Author: attilio Date: Sun Oct 14 03:59:17 2012 New Revision: 241522 URL: http://svn.freebsd.org/changeset/base/241522 Log: getopt_long() returns an int. Use the return value accordingly. Pointy hat to:me MFC after:2 months X-MFC:r241519,241521 Modified:

svn commit: r241371 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98 sparc64/include sparc64/sparc64 x86/x86

2012-10-09 Thread Attilio Rao
Author: attilio Date: Tue Oct 9 12:22:43 2012 New Revision: 241371 URL: http://svn.freebsd.org/changeset/base/241371 Log: Reverts r234074,234105,234564,234723,234989,235231-235232 and part of r234247. Use, instead, the static intializer introduced in r239923 for x86 and sparc64

svn commit: r241374 - in head/sys: amd64/include gnu/fs/xfs/FreeBSD i386/include kern mips/include pc98/include sparc64/include sys x86/include

2012-10-09 Thread Attilio Rao
Author: attilio Date: Tue Oct 9 14:32:30 2012 New Revision: 241374 URL: http://svn.freebsd.org/changeset/base/241374 Log: Add an unified macro to deny ability from the compiler to reorder instruction loads/stores at its will. The macro __compiler_membar() is currently supported for both

svn commit: r240624 - head/sys/sys

2012-09-17 Thread Attilio Rao
Author: attilio Date: Tue Sep 18 00:43:15 2012 New Revision: 240624 URL: http://svn.freebsd.org/changeset/base/240624 Log: Remove namespace pollution in _rmlock.h by defining rm_queue structure directly in _rmlock.h and then including it (and its dependencies) in pcpu.h. This leads to few

Re: svn commit: r240475 - in head/sys: dev/hwpmc kern

2012-09-14 Thread Attilio Rao
On 9/14/12, Konstantin Belousov kostik...@gmail.com wrote: On Thu, Sep 13, 2012 at 10:26:22PM +, Attilio Rao wrote: Author: attilio Date: Thu Sep 13 22:26:22 2012 New Revision: 240475 URL: http://svn.freebsd.org/changeset/base/240475 Log: Remove all the checks on curthread != NULL

Re: svn commit: r240475 - in head/sys: dev/hwpmc kern

2012-09-14 Thread Attilio Rao
On Fri, Sep 14, 2012 at 2:38 PM, Konstantin Belousov kostik...@gmail.com wrote: On Fri, Sep 14, 2012 at 01:03:13PM +0100, Attilio Rao wrote: On 9/14/12, Konstantin Belousov kostik...@gmail.com wrote: On Thu, Sep 13, 2012 at 10:26:22PM +, Attilio Rao wrote: Author: attilio Date: Thu Sep

svn commit: r240475 - in head/sys: dev/hwpmc kern

2012-09-13 Thread Attilio Rao
Author: attilio Date: Thu Sep 13 22:26:22 2012 New Revision: 240475 URL: http://svn.freebsd.org/changeset/base/240475 Log: Remove all the checks on curthread != NULL with the exception of some MD trap checks (eg. printtrap()). Generally this check is not needed anymore, as there is not a

<    1   2   3   4   5   6   7   >