svn commit: r344186 - head/sys/fs/fuse

2019-02-15 Thread Conrad Meyer
Author: cem Date: Fri Feb 15 22:52:49 2019 New Revision: 344186 URL: https://svnweb.freebsd.org/changeset/base/344186 Log: FUSE: The FUSE design expects writethrough caching At least prior to 7.23 (which adds FUSE_WRITEBACK_CACHE), the FUSE protocol specifies only clean data to be

svn commit: r344333 - head/sys/fs/fuse

2019-02-19 Thread Conrad Meyer
Author: cem Date: Wed Feb 20 02:48:59 2019 New Revision: 344333 URL: https://svnweb.freebsd.org/changeset/base/344333 Log: fuse: add descriptions for remaining sysctls (Except reclaim revoked; I don't know what that goal of that one is.) Modified: head/sys/fs/fuse/fuse_file.c

svn commit: r344334 - head/sys/fs/fuse

2019-02-19 Thread Conrad Meyer
Author: cem Date: Wed Feb 20 02:49:26 2019 New Revision: 344334 URL: https://svnweb.freebsd.org/changeset/base/344334 Log: Fuse: whitespace and style(9) cleanup Take a pass through fixing some of the most egregious whitespace issues in fs/fuse. Also fix some style(9) warts while here.

svn commit: r343670 - in head/sys: dev/qlnx/qlnxe dev/qlnx/qlnxr modules/qlnx/qlnxr

2019-02-01 Thread Conrad Meyer
Author: cem Date: Fri Feb 1 23:04:45 2019 New Revision: 343670 URL: https://svnweb.freebsd.org/changeset/base/343670 Log: qlnxr(4), qlnxe(4): Unbreak gcc build Remove redundant definitions and conditionalize Clang-specific CFLAGS. Sponsored by: Dell EMC Isilon Modified:

svn commit: r343761 - head/sys/kern

2019-02-04 Thread Conrad Meyer
Author: cem Date: Tue Feb 5 03:32:58 2019 New Revision: 343761 URL: https://svnweb.freebsd.org/changeset/base/343761 Log: extattr_list_vp: Only take shared vnode lock List is a 'read'-type operation that does not modify shared state; it's safe for multiple thread to proceed

svn commit: r343762 - head/sys/kern

2019-02-04 Thread Conrad Meyer
Author: cem Date: Tue Feb 5 04:47:21 2019 New Revision: 343762 URL: https://svnweb.freebsd.org/changeset/base/343762 Log: extattr_list_vp: Narrow locked section somewhat Suggested by: mjg Reviewed by: kib, mjg Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r346116 - head/usr.bin/sort

2019-04-10 Thread Conrad Meyer
Author: cem Date: Thu Apr 11 05:08:49 2019 New Revision: 346116 URL: https://svnweb.freebsd.org/changeset/base/346116 Log: sort(1): Simplify and bound random seeding Bound input file processing length to avoid the issue reported in [1]. For simplicity, only allow regular file and

svn commit: r346110 - head/usr.bin/sort

2019-04-10 Thread Conrad Meyer
Author: cem Date: Thu Apr 11 00:39:06 2019 New Revision: 346110 URL: https://svnweb.freebsd.org/changeset/base/346110 Log: sort(1): Whitespace and style cleanup No functional change. Sponsored by: Dell EMC Isilon Modified: head/usr.bin/sort/sort.c Modified:

svn commit: r345993 - head/sys/kern

2019-04-06 Thread Conrad Meyer
Author: cem Date: Sat Apr 6 21:56:24 2019 New Revision: 345993 URL: https://svnweb.freebsd.org/changeset/base/345993 Log: kern/subr_pctrie: Fix mismatched signedness in assertion comparison 'tos' is an index into an array and never holds a negative value. Correct its signedness to

Re: svn commit: r346120 - head/sys/kern

2019-04-11 Thread Conrad Meyer
Hi Edward, I have a question about this change below. On Thu, Apr 11, 2019 at 4:22 AM Edward Tomasz Napierala wrote: > > Author: trasz > Date: Thu Apr 11 11:21:45 2019 > New Revision: 346120 > URL: https://svnweb.freebsd.org/changeset/base/346120 > > Log: > Use shared vnode locks for the ELF

svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-15 Thread Conrad Meyer
Author: cem Date: Mon Apr 15 18:40:36 2019 New Revision: 346250 URL: https://svnweb.freebsd.org/changeset/base/346250 Log: random(4): Block read_random(9) on initial seeding read_random() is/was used, mostly without error checking, in a lot of very sensitive places in the kernel --

svn commit: r346251 - head/lib/libc/stdlib

2019-04-15 Thread Conrad Meyer
Author: cem Date: Mon Apr 15 18:49:04 2019 New Revision: 346251 URL: https://svnweb.freebsd.org/changeset/base/346251 Log: random.3: Clarify confusing summary random.3 is only "better" in contrast to rand.3. Both are non-cryptographic pseudo-random number generators. The opening blurbs

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-15 Thread Conrad Meyer
On Mon, Apr 15, 2019 at 5:53 PM Conrad Meyer wrote: > E.g., the CI infrastructure for > Riscv/Arm is/was generating minimal filesystem images and not > populating /boot/entropy. I should add, I say "is/was" because I have a PR out which may address the problem: https://github.

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-15 Thread Conrad Meyer
Hi Justin, On Mon, Apr 15, 2019 at 5:01 PM Justin Hibbits wrote: > Given the discussion over there it would probably also fail on powernv, which > also does not use loader. Does power use bsdinstall (which populates /boot/entropy at install time via usr.sbin/bsdinstall/scripts/entropy) and

Re: svn commit: r346259 - head/sys/dev/tpm

2019-04-16 Thread Conrad Meyer
Hi Marcin, Isn't this check racy? Thread TIDs are allocated from a fixed range and can be recycled. Best, Conrad On Mon, Apr 15, 2019 at 7:28 PM Marcin Wojtas wrote: > > Author: mw > Date: Tue Apr 16 02:28:35 2019 > New Revision: 346259 > URL: https://svnweb.freebsd.org/changeset/base/346259

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-16 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 6:19 AM Warner Losh wrote: > On Tue, Apr 16, 2019, 7:04 AM Emmanuel Vadot wrote: >> It's not only CI, all release images (memstick, iso) don't have >> a /boot/entropy. >> Also all arm/arm64 image don't have this file too. >> If /boot/entropy is needed and isn't present

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-16 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 7:24 AM Justin Hibbits wrote: > > Hi Conrad, > ... > [Power] does use bsdinstall to install. How is entropy loaded at startup, > which causes the problem noted in github? There are a couple very early load sources. loader(8) will load early-boot entropy from

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-16 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 9:33 AM Warner Losh wrote: > In that case, we're better off having a MD routine that gets called if > there's no loader-provided entropy pool. Yes, this is more or less the same plan I had. There's no need to add anything MD specific; we already abstract MD random

Re: svn commit: r346263 - head/contrib/tcpdump

2019-04-16 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 6:20 AM Shawn Webb wrote: > Is there any documentation anywhere telling users that Capsicum > support will be disabled under certain circumstances? Hi Shawn, I don't think documenting that makes much sense in general. It would be extremely burdensome to fully document

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-16 Thread Conrad Meyer
Hi Ruslan, On Tue, Apr 16, 2019 at 8:38 AM Ruslan Bukin wrote: > > Hi I just got this: > > ... > _sleep() at random_harvest_deregister_source+0x132 > random_harvest_deregister_source() at read_random+0xc4 > read_random() at vn_fsync_buf+0x594 > vn_fsync_buf() at arc4rand+0xd4 > arc4rand() at

svn commit: r346282 - in head: . share/man/man9 sys/dev/random sys/sys

2019-04-16 Thread Conrad Meyer
Author: cem Date: Tue Apr 16 17:12:17 2019 New Revision: 346282 URL: https://svnweb.freebsd.org/changeset/base/346282 Log: random(4): Add is_random_seeded(9) KPI The imagined use is for early boot consumers of random to be able to make decisions based on whether random is available yet

svn commit: r346292 - in head: . sys/kern

2019-04-16 Thread Conrad Meyer
Author: cem Date: Tue Apr 16 18:47:20 2019 New Revision: 346292 URL: https://svnweb.freebsd.org/changeset/base/346292 Log: stack_protector: Add tunable to bypass random cookies This is a stopgap measure to unbreak installer/VM/embedded boot issues introduced (or at least exposed by) in

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-16 Thread Conrad Meyer
Hi Warner, On Tue, Apr 16, 2019 at 8:47 AM Warner Losh wrote: > On Tue, Apr 16, 2019 at 9:16 AM Ian Lepore wrote: >> Isn't a file full of data which is distributed in identical form to >> everyone the exact opposite of entropy? Ian has the right idea. > It's just to bootstrap entropy for

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-17 Thread Conrad Meyer
On Mon, Apr 15, 2019 at 11:40 AM Conrad Meyer wrote: > > Author: cem > Date: Mon Apr 15 18:40:36 2019 > New Revision: 346250 > URL: https://svnweb.freebsd.org/changeset/base/346250 > > Log: > random(4): Block read_random(9) on initial seeding Hi, For anyone intereste

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-17 Thread Conrad Meyer
:22 AM Adrian Chadd wrote: > > > > On Mon, 15 Apr 2019 at 11:40, Conrad Meyer wrote: >> >> Author: cem >> Date: Mon Apr 15 18:40:36 2019 >> New Revision: 346250 >> URL: https://svnweb.freebsd.org/changeset/base/346250 >> >> Log: >> rand

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-17 Thread Conrad Meyer
Hi Warner, On Wed, Apr 17, 2019 at 10:16 AM Warner Losh wrote: > I'm going to put a very fine point on this: any hard-requirement of entropy > sources is a non-starter. If you require that, your commit will be backed out > and/or hacked around by the addition of a nob in the future. It will

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-17 Thread Conrad Meyer
Hi John, On Wed, Apr 17, 2019 at 9:01 AM John Baldwin wrote: > You're missing the point which is that you've added potential blocking in a > lot of > places by changing the semantics of arc4random. I get it. The thing is, it's a weird blocking semantic. It's not the same as any other

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-16 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 4:31 PM John Baldwin wrote: > bhyveload is effectively the loader in this case. It runs the normal loader > scripts and logic and so would load the guests's /boot/entropy and pass it > to the guest kernel as metadata just like the regular loader. Right, except it doesn't

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-16 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 4:28 PM John Baldwin wrote: > Yes, but we need some kind of non-blocking API, not an > unconditionally-blocking API > that deadlocks. I'm not sure we do. It would be sufficient to check once at subsystem initialization time. There's no race condition such that we block

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-04-16 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 2:32 PM John Baldwin wrote: > There are definitely places arc4random is used where sleeping is not allowed. Sure. > ipsec generating nonces for AES-CBC is one example I can think of off the > top of my head. IVs for AES-CBC are also a great example of a case we should

svn commit: r346187 - in head/usr.bin/hexdump: . tests

2019-04-13 Thread Conrad Meyer
Author: cem Date: Sat Apr 13 16:51:48 2019 New Revision: 346187 URL: https://svnweb.freebsd.org/changeset/base/346187 Log: hexdump(1): Exit gracefully on format strings missing conversion PR: 237263 Submitted by: Bojan Petrovic Modified: head/usr.bin/hexdump/hexdump.h

svn commit: r346175 - head/usr.bin/sort

2019-04-12 Thread Conrad Meyer
Author: cem Date: Sat Apr 13 04:42:17 2019 New Revision: 346175 URL: https://svnweb.freebsd.org/changeset/base/346175 Log: sort(1): Memoize MD5 computation to reduce repeated computation Experimentally, reduces sort -R time of a 148160 line corpus from about 3.15s to about 0.93s on this

svn commit: r347888 - in head/sys/mips: include mips

2019-05-16 Thread Conrad Meyer
Author: cem Date: Thu May 16 19:10:48 2019 New Revision: 347888 URL: https://svnweb.freebsd.org/changeset/base/347888 Log: mips: Implement basic pmap_kenter_device, pmap_kremove_device Unbreak mips.BERI_DE4_SDROOT build, which uses device xdma. Device xdma depends on the

svn commit: r347639 - head/sys/x86/x86

2019-05-15 Thread Conrad Meyer
Author: cem Date: Thu May 16 01:32:54 2019 New Revision: 347639 URL: https://svnweb.freebsd.org/changeset/base/347639 Log: x86: Correctly identify bhyve hypervisor Spotted after a similar report by Olivier Cochard-Labbé. Sponsored by: Dell EMC Isilon Modified:

svn commit: r348255 - head/sys/kern

2019-05-24 Thread Conrad Meyer
Author: cem Date: Fri May 24 22:33:14 2019 New Revision: 348255 URL: https://svnweb.freebsd.org/changeset/base/348255 Log: Disable intr_storm_threshold mechanism by default The ixl.4 manual page has documented that the threshold falsely detects interrupt storms on 40Gbit NICs as long ago

svn commit: r348262 - head/sys/dev/virtio/pci

2019-05-24 Thread Conrad Meyer
Author: cem Date: Sat May 25 01:59:24 2019 New Revision: 348262 URL: https://svnweb.freebsd.org/changeset/base/348262 Log: virtio_pci(4): Fix typo in read_ivar method Prior to this revision, vtpci's BUS_READ_IVAR method on VIRTIO_IVAR_SUBVENDOR accidentally returned the PCI subdevice.

svn commit: r348309 - head/usr.sbin/kldxref

2019-05-27 Thread Conrad Meyer
Author: cem Date: Mon May 27 17:33:20 2019 New Revision: 348309 URL: https://svnweb.freebsd.org/changeset/base/348309 Log: kldxref(8): Sort MDT_MODULE info first in linker.hints output MDT_MODULE info is required to be ordered before any other MDT metadata for a given kld because it

svn commit: r348293 - head/sys/crypto/aesni

2019-05-26 Thread Conrad Meyer
Author: cem Date: Mon May 27 00:47:51 2019 New Revision: 348293 URL: https://svnweb.freebsd.org/changeset/base/348293 Log: aesni(4): Fix trivial type typo This fixes the kernel build with xtoolchain-gcc (6.4.0). X-MFC-With: r348268 Modified: head/sys/crypto/aesni/aesni_ccm.c

svn commit: r348292 - head/sys/sys

2019-05-26 Thread Conrad Meyer
Author: cem Date: Mon May 27 00:43:43 2019 New Revision: 348292 URL: https://svnweb.freebsd.org/changeset/base/348292 Log: sys/bufobj.h: Avoid using C++ reserved keyword 'private' No functional change (except for out-of-tree C++ kmods). Modified: head/sys/sys/bufobj.h Modified:

svn commit: r348294 - head/share/man/man4

2019-05-26 Thread Conrad Meyer
Author: cem Date: Mon May 27 00:51:27 2019 New Revision: 348294 URL: https://svnweb.freebsd.org/changeset/base/348294 Log: virtio.4: Add missing devices and Xr This page could probably use further improvement. Modified: head/share/man/man4/virtio.4 Modified:

svn commit: r348295 - head/sys/dev/virtio/random

2019-05-26 Thread Conrad Meyer
Author: cem Date: Mon May 27 00:55:46 2019 New Revision: 348295 URL: https://svnweb.freebsd.org/changeset/base/348295 Log: virtio_random(4): Remove unneeded reference to device The device_t always references the softc, so we can pass the device and obtain the softc instead of the other

Re: svn commit: r348611 - in head/sys: conf kern

2019-06-04 Thread Conrad Meyer
On Tue, Jun 4, 2019 at 7:15 AM Shawn Webb wrote: > > On Tue, Jun 04, 2019 at 01:07:10PM +, Ed Maste wrote: > > Author: emaste > > Date: Tue Jun 4 13:07:10 2019 > > New Revision: 348611 > > URL: https://svnweb.freebsd.org/changeset/base/348611 > > > > Log: > > Expose the kernel's build-ID

svn commit: r348629 - head/usr.sbin/daemon

2019-06-04 Thread Conrad Meyer
Author: cem Date: Tue Jun 4 16:07:01 2019 New Revision: 348629 URL: https://svnweb.freebsd.org/changeset/base/348629 Log: daemon(8): Don't block SIGTERM during restart delay I believe this was introduced in the original '-r' commit, r231911 (2012). At the time, the scope was limited to

Re: svn commit: r348419 - in head: crypto/heimdal/lib/ipc share/man/man4 sys/compat/linux sys/kern sys/sys usr.sbin/mountd

2019-06-04 Thread Conrad Meyer
On Tue, Jun 4, 2019 at 6:31 PM Bruce Evans wrote: > On Tue, 4 Jun 2019, Gleb Smirnoff wrote: > > Why don't use C99 in 2019 instead of preprocessor define? Should be > > > > union { > > void*_cr_unused1; /* compatibility with old ucred */ > > pid_t cr_pid;

svn commit: r348337 - head/share/man/man9

2019-05-28 Thread Conrad Meyer
Author: cem Date: Tue May 28 20:44:23 2019 New Revision: 348337 URL: https://svnweb.freebsd.org/changeset/base/348337 Log: style.9: Correct usage's definition to match its declaration Suggested by: emaste Reviewed by: delphij, imp, rgrimes, vangyzen (earlier version) Sponsored by:

svn commit: r348489 - in head/sys: conf dev/random dev/virtio/random

2019-05-31 Thread Conrad Meyer
Author: cem Date: Sat Jun 1 01:22:21 2019 New Revision: 348489 URL: https://svnweb.freebsd.org/changeset/base/348489 Log: random(4): Fix RANDOM_LOADABLE build I introduced an obvious compiler error in r346282, so this change fixes that. Unfortunately, RANDOM_LOADABLE isn't covered

svn commit: r348594 - head/share/man/man9

2019-06-03 Thread Conrad Meyer
Author: cem Date: Mon Jun 3 23:57:29 2019 New Revision: 348594 URL: https://svnweb.freebsd.org/changeset/base/348594 Log: style.9: Codify tolerance for eliding blank lines Consensus seems to be that eliding blank lines for functions with no local variables is acceptable. Codify that

svn commit: r348595 - head/sys/dev/virtio/random

2019-06-03 Thread Conrad Meyer
Author: cem Date: Tue Jun 4 00:01:37 2019 New Revision: 348595 URL: https://svnweb.freebsd.org/changeset/base/348595 Log: virtio_random(4): Fix random(4) integration random(4) masks unregistered entropy sources. Prior to this revision, virtio_random(4) did not correctly register a

svn commit: r348598 - in head/sys/dev/virtio: . mmio pci

2019-06-03 Thread Conrad Meyer
Author: cem Date: Tue Jun 4 02:34:59 2019 New Revision: 348598 URL: https://svnweb.freebsd.org/changeset/base/348598 Log: virtio(4): Expose PNP metadata through newbus Expose the same fields and widths from both vtio buses, even though they don't quite line up; several virtio drivers

svn commit: r348599 - in head/sys/dev/virtio: . balloon block console network random scsi

2019-06-03 Thread Conrad Meyer
Author: cem Date: Tue Jun 4 02:37:11 2019 New Revision: 348599 URL: https://svnweb.freebsd.org/changeset/base/348599 Log: virtio(4): Add PNP match metadata for virtio devices Register MODULE_PNP_INFO for virtio devices using the newbus PNP information provided by the previous commit.

svn commit: r349137 - in head: etc/mtree sys/dev/random tests/sys tests/sys/devrandom

2019-06-17 Thread Conrad Meyer
d/tests/sys/devrandom/uint128_test.c Mon Jun 17 14:59:45 2019 (r349137) @@ -0,0 +1,225 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD + * + * Copyright (c) 2019 Conrad Meyer + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + *

svn commit: r349138 - in head: sys/dev/random tests/sys/devrandom

2019-06-17 Thread Conrad Meyer
Author: cem Date: Mon Jun 17 15:09:12 2019 New Revision: 349138 URL: https://svnweb.freebsd.org/changeset/base/349138 Log: random(4): Generalize algorithm-independent APIs At a basic level, remove assumptions about the underlying algorithm (such as output block size and reseeding

svn commit: r349154 - in head: sys/dev/random tests/sys/devrandom

2019-06-17 Thread Conrad Meyer
Author: cem Date: Mon Jun 17 20:29:13 2019 New Revision: 349154 URL: https://svnweb.freebsd.org/changeset/base/349154 Log: random(4): Fortuna: allow increased concurrency Add experimental feature to increase concurrency in Fortuna. As this diverges slightly from canonical Fortuna, and

svn commit: r349176 - head/sys/dev/random

2019-06-18 Thread Conrad Meyer
Author: cem Date: Tue Jun 18 18:50:58 2019 New Revision: 349176 URL: https://svnweb.freebsd.org/changeset/base/349176 Log: random(4): Fix a regression in short AES mode reads In r349154, random device reads of size < 16 bytes (AES block size) were accidentally broken to loop forever.

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Conrad Meyer
Hi Warner, That doesn't seem responsive to the question. On Mon, Jun 10, 2019 at 6:49 AM Warner Losh wrote: > > > > On Mon, Jun 10, 2019, 7:44 AM Conrad Meyer wrote: >> >> On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans wrote: >> > On Mon, 10 Jun 2019 0

svn commit: r349254 - head

2019-06-20 Thread Conrad Meyer
Author: cem Date: Fri Jun 21 00:33:45 2019 New Revision: 349254 URL: https://svnweb.freebsd.org/changeset/base/349254 Log: Fixup UPDATING text for r349253 Requested by: delphij Modified: head/UPDATING Modified: head/UPDATING

svn commit: r349256 - head/libexec/rc/rc.d

2019-06-20 Thread Conrad Meyer
Author: cem Date: Fri Jun 21 02:37:54 2019 New Revision: 349256 URL: https://svnweb.freebsd.org/changeset/base/349256 Log: rc.d/motd: Update motd more robustly Use appropriate fsyncs to persist the rewritten /etc/motd file, when a rewrite is performed. Reported by: Jonathan Walton

svn commit: r349253 - in head: . release/picobsd/bridge release/picobsd/qemu share/man/man4 sys/amd64/conf sys/arm/conf sys/arm64/conf sys/conf sys/i386/conf sys/mips/conf sys/mips/mediatek sys/pow...

2019-06-20 Thread Conrad Meyer
Author: cem Date: Fri Jun 21 00:16:30 2019 New Revision: 349253 URL: https://svnweb.freebsd.org/changeset/base/349253 Log: sys: Remove DEV_RANDOM device option Remove 'device random' from kernel configurations that reference it (most). Replace perhaps mistaken 'nodevice random' in two

Re: svn commit: r349151 - in head: lib/libufs stand/libsa sys/conf sys/dev/iscsi sys/dev/iscsi_initiator sys/dev/liquidio sys/dev/usb/net sys/fs/ext2fs sys/fs/nandfs sys/geom/part sys/geom/raid sys/ke

2019-06-22 Thread Conrad Meyer
Hi Xin Li, On Mon, Jun 17, 2019 at 12:49 PM Xin LI wrote: > > Author: delphij > Date: Mon Jun 17 19:49:08 2019 > New Revision: 349151 > URL: https://svnweb.freebsd.org/changeset/base/349151 > > Log: > Separate kernel crc32() implementation to its own header (gsb_crc32.h) and > rename the

svn commit: r348854 - head/libexec/rc/rc.d

2019-06-10 Thread Conrad Meyer
Author: cem Date: Mon Jun 10 13:34:18 2019 New Revision: 348854 URL: https://svnweb.freebsd.org/changeset/base/348854 Log: /etc/rc.d/local: Fix typo in description PR: 238448 Submitted by: Marián Černý Modified: head/libexec/rc/rc.d/local Modified:

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Conrad Meyer
On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans wrote: > On Mon, 10 Jun 2019 05:28:04 + (UTC) Dmitry Chagin > wrote: > > ... > > URL: https://svnweb.freebsd.org/changeset/base/348847 > > Log: > > Use C11 anonymous unions. > > > > Modified: head/sys/sys/ucred.h > ... > > Isn't this a userland

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Conrad Meyer
On Mon, Jun 10, 2019 at 9:17 AM Bruce Evans wrote: > Only headers and libraries should support -std=c89. has > lots of support for compilers and POSIX versions going back to K C, > and only the K parts are completely broken. Is this due to specific policy, or just inertia? (No one has

svn commit: r347473 - head/sys/netinet/netdump

2019-05-10 Thread Conrad Meyer
Author: cem Date: Fri May 10 23:12:59 2019 New Revision: 347473 URL: https://svnweb.freebsd.org/changeset/base/347473 Log: netdump: Ref the interface we're attached to Serialize netdump configuration / deconfiguration, and discard our configuration when the affiliated interface goes away

svn commit: r347471 - head/sys/netinet/netdump

2019-05-10 Thread Conrad Meyer
Author: cem Date: Fri May 10 23:10:22 2019 New Revision: 347471 URL: https://svnweb.freebsd.org/changeset/base/347471 Log: netdump: Fix boot-time configuration typo Boot-time netdump configuration is much more useful if one can configure the client and gateway addresses. Fix trivial

svn commit: r347467 - head/sys/netinet/netdump

2019-05-10 Thread Conrad Meyer
Author: cem Date: Fri May 10 21:55:11 2019 New Revision: 347467 URL: https://svnweb.freebsd.org/changeset/base/347467 Log: netdump: Don't store sensitive key data we don't need Prior to this revision, struct diocskerneldump_arg (and struct netdump_conf with embedded diocskerneldump_arg

svn commit: r347546 - head/sys/dev/random

2019-05-13 Thread Conrad Meyer
Author: cem Date: Mon May 13 19:35:35 2019 New Revision: 347546 URL: https://svnweb.freebsd.org/changeset/base/347546 Log: Fortuna: Fix false negatives in is_random_seeded() (1) We may have had sufficient entropy to consider Fortuna seeded, but the random_fortuna_seeded() function would

svn commit: r347555 - in head: . sys/kern

2019-05-13 Thread Conrad Meyer
Author: cem Date: Mon May 13 23:37:44 2019 New Revision: 347555 URL: https://svnweb.freebsd.org/changeset/base/347555 Log: Revert r346292 (permit_nonrandom_stackcookies) We have a better, more comprehensive knob for this now: kern.random.initial_seeding.bypass_before_seeding=1.

svn commit: r348076 - head/sys/sys

2019-05-21 Thread Conrad Meyer
Author: cem Date: Wed May 22 00:21:42 2019 New Revision: 348076 URL: https://svnweb.freebsd.org/changeset/base/348076 Log: Revert r348070 Konstantin points out that lockmgr probably requires the whole lock.h anyway. Requested by: kib Modified: head/sys/sys/lockmgr.h Modified:

svn commit: r348078 - head/usr.sbin/pmc

2019-05-21 Thread Conrad Meyer
Author: cem Date: Wed May 22 01:22:33 2019 New Revision: 348078 URL: https://svnweb.freebsd.org/changeset/base/348078 Log: pmc: Fix stack std::string lifetime It's invalid to reference a C++ string's c_str() buffer after the object goes out of scope. Adjust the scope of the string to

svn commit: r348130 - in head/sys/x86: include x86

2019-05-22 Thread Conrad Meyer
Author: cem Date: Wed May 22 23:22:36 2019 New Revision: 348130 URL: https://svnweb.freebsd.org/changeset/base/348130 Log: Decode and name additional x86 feature bits These are all enumerated in Intel's ISA extension reference, 37th ed. Sponsored by: Dell EMC Isilon Modified:

Re: svn commit: r348109 - in head/sys/x86: include x86

2019-05-22 Thread Conrad Meyer
On Wed, May 22, 2019 at 11:06 AM Andriy Gapon wrote: > > On 22/05/2019 16:44, Andrew Gallatin wrote: > > This is needed for AMD SMCA processors, as SMCA uses different > > MSR address for access MCA banks. > > Just curious, what is SMCA? Scalable MCA. It's a set of AMD Fam17h MCA

Re: svn commit: r347638 - in head: . etc lib/libc/gen

2019-05-22 Thread Conrad Meyer
Hi Brad, Ping. It's still broken. Can you revert this please? Thanks, Conrad On Thu, May 16, 2019 at 8:05 AM Conrad Meyer wrote: > > Hi Brad, > > Can you revert this? It seems to break every config-management tool > we have (mergemaster, etcupdate, beinstall ...). > >

Re: svn commit: r348109 - in head/sys/x86: include x86

2019-05-22 Thread Conrad Meyer
On Wed, May 22, 2019 at 12:59 PM John Baldwin wrote: > On 5/22/19 12:12 PM, Conrad Meyer wrote: > > On Wed, May 22, 2019 at 11:06 AM Andriy Gapon wrote: > >> > >> On 22/05/2019 16:44, Andrew Gallatin wrote: > >>> This is needed for AMD SMCA process

svn commit: r348122 - in head/libexec: rc/rc.d save-entropy

2019-05-22 Thread Conrad Meyer
Author: cem Date: Wed May 22 21:47:17 2019 New Revision: 348122 URL: https://svnweb.freebsd.org/changeset/base/348122 Log: save-entropy(8), rc.d/random: Set nodump flag Tag saved entropy files as "nodump," to signal that the files should not be backed up by dump(8) or other automated

svn commit: r348199 - head/sys/dev/random

2019-05-23 Thread Conrad Meyer
Author: cem Date: Thu May 23 21:02:27 2019 New Revision: 348199 URL: https://svnweb.freebsd.org/changeset/base/348199 Log: random(4): deduplicate explicit_bzero() in harvest Pull the responsibility for zeroing events, which is general to any conceivable implementation of a random device

svn commit: r348197 - in head: sbin/decryptcore sbin/dumpon sys/kern sys/sys

2019-05-23 Thread Conrad Meyer
Author: cem Date: Thu May 23 20:12:24 2019 New Revision: 348197 URL: https://svnweb.freebsd.org/changeset/base/348197 Log: EKCD: Add Chacha20 encryption mode Add Chacha20 mode to Encrypted Kernel Crash Dumps. Chacha20 does not require messages to be multiples of block size, so it is

svn commit: r348198 - head/sys/dev/uart

2019-05-23 Thread Conrad Meyer
Author: cem Date: Thu May 23 20:18:46 2019 New Revision: 348198 URL: https://svnweb.freebsd.org/changeset/base/348198 Log: uart_cpu_acpi: Fix GCC build break from r348195 extern declarations are redundant with those in uart_cpu.h, which this file includes. X-MFC-with: r348195

Re: svn commit: r348241 - head

2019-05-24 Thread Conrad Meyer
On Fri, May 24, 2019 at 9:24 AM Andrew Gallatin wrote: > Dumb question about this: Will it update toolchains, or just use what > can find? -DMAKE_JUST_KERNELS doesn't touch toolchains. For that, there is the less memorable build step: export NCPU=$((1 * $(sysctl -n hw.ncpu) / 3)); make

svn commit: r347967 - head/share/man/man4

2019-05-19 Thread Conrad Meyer
Author: cem Date: Sun May 19 06:01:11 2019 New Revision: 347967 URL: https://svnweb.freebsd.org/changeset/base/347967 Log: nvd.4: Reference nda(4) Fix a totally minor typo in nvme.4 while here. Modified: head/share/man/man4/nvd.4 head/share/man/man4/nvme.4 Modified:

svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra12...

2019-05-19 Thread Conrad Meyer
Author: cem Date: Mon May 20 00:38:23 2019 New Revision: 347984 URL: https://svnweb.freebsd.org/changeset/base/347984 Log: Extract eventfilter declarations to sys/_eventfilter.h This allows replacing "sys/eventfilter.h" includes with "sys/_eventfilter.h" in other header files (e.g.,

svn commit: r347948 - in head: sbin/fdisk sys/sys/disk

2019-05-17 Thread Conrad Meyer
Author: cem Date: Sat May 18 00:22:28 2019 New Revision: 347948 URL: https://svnweb.freebsd.org/changeset/base/347948 Log: Add DragonFly's partition number to fdisk(8) and diskmbr.h This change doesn't make any attempt to add support for these slices to the relevent GEOM classes. Just

Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra1

2019-05-20 Thread Conrad Meyer
On Mon, May 20, 2019 at 12:21 PM Peter Jeremy wrote: > > On 2019-May-20 00:38:23 +, Conrad Meyer wrote: > >Author: cem > >Date: Mon May 20 00:38:23 2019 > >New Revision: 347984 > >URL: https://svnweb.freebsd.org/changeset/base/347984 > > > >Log: &g

svn commit: r348067 - head/sys/kern

2019-05-21 Thread Conrad Meyer
Author: cem Date: Tue May 21 21:26:14 2019 New Revision: 348067 URL: https://svnweb.freebsd.org/changeset/base/348067 Log: mqueuefs: Do not allow manipulation of the pseudo-dirents "." and ".." "." and ".." names are not maintained in the mqueuefs dirent datastructure and cannot be

svn commit: r348070 - head/sys/sys

2019-05-21 Thread Conrad Meyer
Author: cem Date: Tue May 21 21:35:37 2019 New Revision: 348070 URL: https://svnweb.freebsd.org/changeset/base/348070 Log: sys/lockmgr.h: Update #error to point at correct _lock.h After r347984, these macros live in sys/_lock.h. No functional change. Sponsored by: Dell EMC Isilon

svn commit: r348064 - in head/sys: arm64/arm64 dev/acpica dev/ixgbe fs/unionfs kern mips/mips riscv/riscv ufs/ffs ufs/ufs vm

2019-05-21 Thread Conrad Meyer
Author: cem Date: Tue May 21 20:38:48 2019 New Revision: 348064 URL: https://svnweb.freebsd.org/changeset/base/348064 Log: Include ktr.h in more compilation units Similar to r348026, exhaustive search for uses of CTRn() and cross reference ktr.h includes. Where it was obvious that an OS

Re: svn commit: r347638 - in head: . etc lib/libc/gen

2019-05-16 Thread Conrad Meyer
Hi Brad, Can you revert this? It seems to break every config-management tool we have (mergemaster, etcupdate, beinstall ...). Additionally, I don't believe this move has been justified — the cons seem to outweigh the pros, if there are any. I skimmed the differential and it was not immediately

svn commit: r347828 - head/sys/dev/xdma

2019-05-16 Thread Conrad Meyer
Author: cem Date: Thu May 16 17:34:36 2019 New Revision: 347828 URL: https://svnweb.freebsd.org/changeset/base/347828 Log: xdma(4): Fix invalid pointer use (breaks arm.SOCFPGA build) In xdma_handle_mem_node(), vmem_size_t and vmem_addr_t pointers were passed to an FDT API that emits

Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra1

2019-05-20 Thread Conrad Meyer
the eventhandler header (and fixing that is trivial), but I'd like to better understand where the leak is so that other misses can be located. Thanks, Conrad On Mon, May 20, 2019 at 12:31 PM Conrad Meyer wrote: > > Hi Peter, > > Thanks for reporting this. I ran a full tinderbox on this ch

svn commit: r348026 - in head/sys: arm/allwinner arm/amlogic/aml8726 arm/freescale/imx arm/rockchip arm/ti/am335x compat/linuxkpi/common/src dev/drm2/ttm dev/fb dev/hdmi dev/iscsi_initiator dev/mlx...

2019-05-20 Thread Conrad Meyer
Author: cem Date: Tue May 21 01:18:43 2019 New Revision: 348026 URL: https://svnweb.freebsd.org/changeset/base/348026 Log: Include eventhandler.h in more compilation units This was enumerated with exhaustive search for sys/eventhandler.h includes, cross-referenced against EVENTHANDLER_*

svn commit: r348022 - in head/sys: dev/netmap netinet/netdump

2019-05-20 Thread Conrad Meyer
Author: cem Date: Tue May 21 00:04:19 2019 New Revision: 348022 URL: https://svnweb.freebsd.org/changeset/base/348022 Log: Add two missing eventhandler.h headers These are obviously missing from the .c files, but don't show up in any tinderbox configuration (due to latent header

Re: svn commit: r346959 - in head/release: . tools

2019-04-30 Thread Conrad Meyer
Thanks, Glen! On Tue, Apr 30, 2019 at 7:29 AM Glen Barber wrote: > > Author: gjb > Date: Tue Apr 30 14:29:09 2019 > New Revision: 346959 > URL: https://svnweb.freebsd.org/changeset/base/346959 > > Log: > Reduce the default image size for virtual machine disk images from > 30GB to 3GB. The

svn commit: r347192 - in head: sbin/dumpon sys/dev/null sys/geom sys/geom/raid sys/kern sys/netinet/netdump sys/sys

2019-05-06 Thread Conrad Meyer
Author: cem Date: Mon May 6 18:24:07 2019 New Revision: 347192 URL: https://svnweb.freebsd.org/changeset/base/347192 Log: List-ify kernel dump device configuration Allow users to specify multiple dump configurations in a prioritized list. This enables fallback to secondary device(s) if

Re: svn commit: r347229 - in head: lib/libsbuf lib/libsbuf/tests share/man/man9 sys/kern sys/sys

2019-05-07 Thread Conrad Meyer
One correction On Tue, May 7, 2019 at 10:47 AM Conrad Meyer wrote: > Author: cem > Date: Tue May 7 17:47:20 2019 > New Revision: 347229 > URL: https://svnweb.freebsd.org/changeset/base/347229 > > Log: > device_printf: Use sbuf for more coherent prints on SMP > >

svn commit: r347229 - in head: lib/libsbuf lib/libsbuf/tests share/man/man9 sys/kern sys/sys

2019-05-07 Thread Conrad Meyer
Author: cem Date: Tue May 7 17:47:20 2019 New Revision: 347229 URL: https://svnweb.freebsd.org/changeset/base/347229 Log: device_printf: Use sbuf for more coherent prints on SMP device_printf does multiple calls to printf allowing other console messages to be inserted between the device

svn commit: r347235 - head/lib/libsbuf

2019-05-07 Thread Conrad Meyer
Author: cem Date: Tue May 7 21:15:11 2019 New Revision: 347235 URL: https://svnweb.freebsd.org/changeset/base/347235 Log: Fix libsbuf sbuf_printf_drain symbol version (Introduced incorrectly in r347229 earlier today.) As pointed out by kevans, 1.6 should be used for FreeBSD 13, like

Re: svn commit: r347066 - in head: sbin/fsck_ffs sys/ufs/ufs

2019-05-07 Thread Conrad Meyer
Hi Kirk, Coverity points out that namlen may be used uninitialized in the following sequence (CID 1401317): On Fri, May 3, 2019 at 2:54 PM Kirk McKusick wrote: > > Author: mckusick > Date: Fri May 3 21:54:14 2019 > New Revision: 347066 > URL: https://svnweb.freebsd.org/changeset/base/347066 >

svn commit: r347239 - head/sys/dev/random

2019-05-07 Thread Conrad Meyer
Author: cem Date: Wed May 8 00:45:16 2019 New Revision: 347239 URL: https://svnweb.freebsd.org/changeset/base/347239 Log: random: x86 driver: Prefer RDSEED over RDRAND when available Per https://software.intel.com/en-us/blogs/2012/11/17/the-difference-between-rdrand-and-rdseed ,

Re: svn commit: r346645 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src sys

2019-05-07 Thread Conrad Meyer
Hi Tycho, On Wed, Apr 24, 2019 at 1:31 PM Tycho Nightingale wrote: > > Author: tychon > Date: Wed Apr 24 20:30:45 2019 > New Revision: 346645 > URL: https://svnweb.freebsd.org/changeset/base/346645 > > Log: > LinuxKPI should use bus_dma(9) to be compatible with an IOMMU > > Reviewed by:

Re: svn commit: r347221 - head/sys/net

2019-05-07 Thread Conrad Meyer
Hi Marius, This change seems to break LINT-NOIP tinderbox builds; one reference to tcp_lro_free() is covered by #if defined(INET) || defined(INET6), but the one added in iflib_rx_structures_free() is not. On Tue, May 7, 2019 at 1:28 AM Marius Strobl wrote: > > Author: marius > Date: Tue May 7

svn commit: r347238 - head/sys/amd64/vmm

2019-05-07 Thread Conrad Meyer
Author: cem Date: Wed May 8 00:40:08 2019 New Revision: 347238 URL: https://svnweb.freebsd.org/changeset/base/347238 Log: vmm(4): Pass through RDSEED feature bit to guests Reviewed by: jhb Approved by: #bhyve (jhb) MFC after:2 leapseconds Sponsored by: Dell EMC Isilon

<    5   6   7   8   9   10   11   12   13   14   >