svn commit: r349451 - head/contrib/ipfilter/tools

2019-06-26 Thread Cy Schubert
Author: cy Date: Thu Jun 27 03:50:13 2019 New Revision: 349451 URL: https://svnweb.freebsd.org/changeset/base/349451 Log: Return a return code scripts might expect. I missed this while reviewing and rewriting a patch in PR/238816. PR: 238816 Reported by: rgrimes@ Pointy hat

svn commit: r349452 - in head: sbin/ipf/ipmon tools/build/mk

2019-06-27 Thread Cy Schubert
Author: cy Date: Thu Jun 27 12:37:44 2019 New Revision: 349452 URL: https://svnweb.freebsd.org/changeset/base/349452 Log: Create a link to the ipmon.conf.5 man page as documented in ipmon.5. Add its corresponding optional removal entry. PR: 238816 MFC after:1 week Modifie

svn commit: r349503 - head/contrib/ipfilter/man

2019-06-27 Thread Cy Schubert
Author: cy Date: Fri Jun 28 04:28:32 2019 New Revision: 349503 URL: https://svnweb.freebsd.org/changeset/base/349503 Log: Document the -B, binary logfile, and the -C config file options. Reference the ipmon.5 man page and ipmon.conf. PR: 238816 MFC after:1 week Modified:

svn commit: r349504 - head/contrib/ipfilter/man

2019-06-27 Thread Cy Schubert
Author: cy Date: Fri Jun 28 04:52:24 2019 New Revision: 349504 URL: https://svnweb.freebsd.org/changeset/base/349504 Log: Fix a typo. PR: 238816 MFC after:1 week X-MFC with: r349503 Modified: head/contrib/ipfilter/man/ipmon.8 Modified: head/contrib/ipfilter/man/ipmon

Re: svn commit: r349503 - head/contrib/ipfilter/man

2019-06-28 Thread Cy Schubert
In message <20190628202903.j1...@besplex.bde.org>, Bruce Evans writes: > On Fri, 28 Jun 2019, Cy Schubert wrote: > > > Log: > > Document the -B, binary logfile, and the -C config file options. > > Reference the ipmon.5 man page and ipmon.conf. > > > > P

svn commit: r349567 - head/sys/contrib/ipfilter/netinet

2019-06-30 Thread Cy Schubert
Author: cy Date: Sun Jun 30 22:27:58 2019 New Revision: 349567 URL: https://svnweb.freebsd.org/changeset/base/349567 Log: Revert r349400. It has uintended effects. Reported by: chris...@netbsd.org X-MFC with: r349400. Modified: head/sys/contrib/ipfilter/netinet/fil.c Modified: head

svn commit: r349568 - head/sys/contrib/ipfilter/netinet

2019-06-30 Thread Cy Schubert
Author: cy Date: Sun Jun 30 22:32:33 2019 New Revision: 349568 URL: https://svnweb.freebsd.org/changeset/base/349568 Log: The RFC 3128 test should be made after the offset mask has been applied. Reported by: chris...@netbsd.org X-MFC with: r349399 Modified: head/sys/contrib/ipfilter

svn commit: r349650 - in stable: 11/lib/libsqlite3 12/lib/libsqlite3

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 16:23:06 2019 New Revision: 349650 URL: https://svnweb.freebsd.org/changeset/base/349650 Log: MFC r342972: Disable FTS3, FTS4, and RTREE in bundled and private sqlite3. Suggested by: delphij@ Reviewed by: delphij@ (for secteam@) Differential Revision:

svn commit: r349650 - in stable: 11/lib/libsqlite3 12/lib/libsqlite3

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 16:23:06 2019 New Revision: 349650 URL: https://svnweb.freebsd.org/changeset/base/349650 Log: MFC r342972: Disable FTS3, FTS4, and RTREE in bundled and private sqlite3. Suggested by: delphij@ Reviewed by: delphij@ (for secteam@) Differential Revision:

svn commit: r349651 - in stable/12/libexec/rc: . rc.d

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 16:43:40 2019 New Revision: 349651 URL: https://svnweb.freebsd.org/changeset/base/349651 Log: MFC r349153: Allow the hostapd program to be specified. This allows users to use hostapd from ports instead of the one in base. The default is the hostapd in base.

svn commit: r349652 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 16:48:46 2019 New Revision: 349652 URL: https://svnweb.freebsd.org/changeset/base/349652 Log: MFC r349331: Clean out duplicate definitions of TCP macros also found in netinet/tcp.h. Modified: stable/11/sys/contrib/ipfilter/netinet/ip_compat.h Directory Propert

svn commit: r349652 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 16:48:46 2019 New Revision: 349652 URL: https://svnweb.freebsd.org/changeset/base/349652 Log: MFC r349331: Clean out duplicate definitions of TCP macros also found in netinet/tcp.h. Modified: stable/12/sys/contrib/ipfilter/netinet/ip_compat.h Directory Propert

svn commit: r349653 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 16:53:59 2019 New Revision: 349653 URL: https://svnweb.freebsd.org/changeset/base/349653 Log: MFC r349362: The definition of icmptypes in ip_compt.h is dead code as it already use the icmptypes in ip_icmp.h. Modified: stable/12/sys/contrib/ipfilter/netinet/i

svn commit: r349653 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 16:53:59 2019 New Revision: 349653 URL: https://svnweb.freebsd.org/changeset/base/349653 Log: MFC r349362: The definition of icmptypes in ip_compt.h is dead code as it already use the icmptypes in ip_icmp.h. Modified: stable/11/sys/contrib/ipfilter/netinet/i

svn commit: r349654 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 17:04:44 2019 New Revision: 349654 URL: https://svnweb.freebsd.org/changeset/base/349654 Log: MFC r349399-349400,349567-349568: Prompted by r349366, ipfilter is also does not conform to RFC 3128 by dropping TCP fragments with offset = 1. In addition to dro

svn commit: r349654 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 17:04:44 2019 New Revision: 349654 URL: https://svnweb.freebsd.org/changeset/base/349654 Log: MFC r349399-349400,349567-349568: Prompted by r349366, ipfilter is also does not conform to RFC 3128 by dropping TCP fragments with offset = 1. In addition to dro

svn commit: r349655 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 17:09:41 2019 New Revision: 349655 URL: https://svnweb.freebsd.org/changeset/base/349655 Log: MFC r349401: While working on PR/238796 I discovered an unused variable in frdest, the next hop structure. It is likely this contributes to PR/238796 though other fa

svn commit: r349655 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 17:09:41 2019 New Revision: 349655 URL: https://svnweb.freebsd.org/changeset/base/349655 Log: MFC r349401: While working on PR/238796 I discovered an unused variable in frdest, the next hop structure. It is likely this contributes to PR/238796 though other fa

svn commit: r349659 - in stable: 10/contrib/ipfilter/man 11/contrib/ipfilter/man 12/contrib/ipfilter/man

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 18:11:22 2019 New Revision: 349659 URL: https://svnweb.freebsd.org/changeset/base/349659 Log: MFC r349448: Fix a typo. PR/238816 initially addressed updates to usage() however it has now become a shopping list of fixes to ipmon man pages and usage().

svn commit: r349659 - in stable: 10/contrib/ipfilter/man 11/contrib/ipfilter/man 12/contrib/ipfilter/man

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 18:11:22 2019 New Revision: 349659 URL: https://svnweb.freebsd.org/changeset/base/349659 Log: MFC r349448: Fix a typo. PR/238816 initially addressed updates to usage() however it has now become a shopping list of fixes to ipmon man pages and usage().

svn commit: r349659 - in stable: 10/contrib/ipfilter/man 11/contrib/ipfilter/man 12/contrib/ipfilter/man

2019-07-03 Thread Cy Schubert
Author: cy Date: Wed Jul 3 18:11:22 2019 New Revision: 349659 URL: https://svnweb.freebsd.org/changeset/base/349659 Log: MFC r349448: Fix a typo. PR/238816 initially addressed updates to usage() however it has now become a shopping list of fixes to ipmon man pages and usage().

svn commit: r349715 - in stable: 11/sbin/ipf/ipmon 11/tools/build/mk 12/sbin/ipf/ipmon 12/tools/build/mk

2019-07-03 Thread Cy Schubert
Author: cy Date: Thu Jul 4 03:04:41 2019 New Revision: 349715 URL: https://svnweb.freebsd.org/changeset/base/349715 Log: MFC r349449, r349452: Add the ipmon.5 man page and link ipmon.conf.5 to it. PR/238816 initially addressed updates to usage() however the PR has morphed into a sho

svn commit: r349715 - in stable: 11/sbin/ipf/ipmon 11/tools/build/mk 12/sbin/ipf/ipmon 12/tools/build/mk

2019-07-03 Thread Cy Schubert
Author: cy Date: Thu Jul 4 03:04:41 2019 New Revision: 349715 URL: https://svnweb.freebsd.org/changeset/base/349715 Log: MFC r349449, r349452: Add the ipmon.5 man page and link ipmon.conf.5 to it. PR/238816 initially addressed updates to usage() however the PR has morphed into a sho

svn commit: r349716 - in stable: 11/contrib/ipfilter/tools 12/contrib/ipfilter/tools

2019-07-03 Thread Cy Schubert
Author: cy Date: Thu Jul 4 03:08:14 2019 New Revision: 349716 URL: https://svnweb.freebsd.org/changeset/base/349716 Log: MFC r349450-349451: Update usage() to refect the current state of ipmon. PR: 238816 Modified: stable/11/contrib/ipfilter/tools/ipmon.c Directory Properties:

svn commit: r349716 - in stable: 11/contrib/ipfilter/tools 12/contrib/ipfilter/tools

2019-07-03 Thread Cy Schubert
Author: cy Date: Thu Jul 4 03:08:14 2019 New Revision: 349716 URL: https://svnweb.freebsd.org/changeset/base/349716 Log: MFC r349450-349451: Update usage() to refect the current state of ipmon. PR: 238816 Modified: stable/12/contrib/ipfilter/tools/ipmon.c Directory Properties:

svn commit: r349759 - in stable: 10/contrib/ipfilter/man 11/contrib/ipfilter/man 12/contrib/ipfilter/man

2019-07-04 Thread Cy Schubert
Author: cy Date: Fri Jul 5 04:24:09 2019 New Revision: 349759 URL: https://svnweb.freebsd.org/changeset/base/349759 Log: MFC r349503-349504: Document the -B, binary logfile, and the -C config file options. Reference the ipmon.5 man page and ipmon.conf. PR: 238816 Modified

svn commit: r349759 - in stable: 10/contrib/ipfilter/man 11/contrib/ipfilter/man 12/contrib/ipfilter/man

2019-07-04 Thread Cy Schubert
Author: cy Date: Fri Jul 5 04:24:09 2019 New Revision: 349759 URL: https://svnweb.freebsd.org/changeset/base/349759 Log: MFC r349503-349504: Document the -B, binary logfile, and the -C config file options. Reference the ipmon.5 man page and ipmon.conf. PR: 238816 Modified

svn commit: r349759 - in stable: 10/contrib/ipfilter/man 11/contrib/ipfilter/man 12/contrib/ipfilter/man

2019-07-04 Thread Cy Schubert
Author: cy Date: Fri Jul 5 04:24:09 2019 New Revision: 349759 URL: https://svnweb.freebsd.org/changeset/base/349759 Log: MFC r349503-349504: Document the -B, binary logfile, and the -C config file options. Reference the ipmon.5 man page and ipmon.conf. PR: 238816 Modified

svn commit: r349842 - head/sys/contrib/ipfilter/netinet

2019-07-08 Thread Cy Schubert
Author: cy Date: Mon Jul 8 19:11:35 2019 New Revision: 349842 URL: https://svnweb.freebsd.org/changeset/base/349842 Log: Correct the description for the low port in the port compare struct. Adjust the high port description to match that of the low port description. MFC after:3 d

svn commit: r349843 - head/sys/contrib/ipfilter/netinet

2019-07-08 Thread Cy Schubert
Author: cy Date: Mon Jul 8 19:11:49 2019 New Revision: 349843 URL: https://svnweb.freebsd.org/changeset/base/349843 Log: Update frtuc struct comments. It not only defines TCP things we are interested in but also UDP. While at it document the source and destination port variables. MF

svn commit: r349898 - head/sys/contrib/ipfilter/netinet

2019-07-10 Thread Cy Schubert
Author: cy Date: Thu Jul 11 00:08:46 2019 New Revision: 349898 URL: https://svnweb.freebsd.org/changeset/base/349898 Log: ipfilter commands, in this case ipf(8), passes its operations and rules via an ioctl interface. Rules can be added or removed and stats and counters can be zeroed out. As

svn commit: r349902 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-10 Thread Cy Schubert
Author: cy Date: Thu Jul 11 00:38:10 2019 New Revision: 349902 URL: https://svnweb.freebsd.org/changeset/base/349902 Log: MFC r349842: Correct the description for the low port in the port compare struct. Adjust the high port description to match that of the low port description. Mod

svn commit: r349902 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-10 Thread Cy Schubert
Author: cy Date: Thu Jul 11 00:38:10 2019 New Revision: 349902 URL: https://svnweb.freebsd.org/changeset/base/349902 Log: MFC r349842: Correct the description for the low port in the port compare struct. Adjust the high port description to match that of the low port description. Mod

svn commit: r349902 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-10 Thread Cy Schubert
Author: cy Date: Thu Jul 11 00:38:10 2019 New Revision: 349902 URL: https://svnweb.freebsd.org/changeset/base/349902 Log: MFC r349842: Correct the description for the low port in the port compare struct. Adjust the high port description to match that of the low port description. Mod

svn commit: r349903 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-10 Thread Cy Schubert
Author: cy Date: Thu Jul 11 00:44:09 2019 New Revision: 349903 URL: https://svnweb.freebsd.org/changeset/base/349903 Log: MFC 349843: Update frtuc struct comments. It not only defines TCP things we are interested in but also UDP. While at it document the source and destination port v

svn commit: r349903 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-10 Thread Cy Schubert
Author: cy Date: Thu Jul 11 00:44:09 2019 New Revision: 349903 URL: https://svnweb.freebsd.org/changeset/base/349903 Log: MFC 349843: Update frtuc struct comments. It not only defines TCP things we are interested in but also UDP. While at it document the source and destination port v

svn commit: r349903 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-10 Thread Cy Schubert
Author: cy Date: Thu Jul 11 00:44:09 2019 New Revision: 349903 URL: https://svnweb.freebsd.org/changeset/base/349903 Log: MFC 349843: Update frtuc struct comments. It not only defines TCP things we are interested in but also UDP. While at it document the source and destination port v

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-10 Thread Cy Schubert
((deprecated)) > to those unsafe functions like gets(), sprintf(), etc.? Or it would > cause too much PITA? sprintf() is not deprecated (https://en.cppreference.com/w/c/io/fprintf) . gets() is removed in C11 (https://en.cppreference.com/w/c/io/gets), replaced by gets_s(). We already have get

Re: svn commit: r349907 - head/sys/netinet/tcp_stacks

2019-07-11 Thread Cy Schubert
counter_u64_add(rack_out_size[TCP_MSS_ACCT_SNDACK], 1); > else if (len == 1) { > This commit updates more than just the copyright. Were the other changes intended? If yes, a) Removing the */ at the other end of the commented block is also needed. b) The commit log is

Re: svn commit: r349907 - head/sys/netinet/tcp_stacks

2019-07-11 Thread Cy Schubert
Cy Schubert writes: > In message <201907110438.x6b4cxx1054...@repo.freebsd.org>, Randall > Stewart writ > es: > > Author: rrs > > Date: Thu Jul 11 04:38:33 2019 > > New Revision: 349907 > > URL: https://svnweb.freebsd.org/changeset/base/349907 > &

svn commit: r349916 - head/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Thu Jul 11 19:36:14 2019 New Revision: 349916 URL: https://svnweb.freebsd.org/changeset/base/349916 Log: Correct r349898. The default is add a rule. MFC after:1 week X-MFC with: r349898 Modified: head/sys/contrib/ipfilter/netinet/fil.c Modified: head/sys/contrib

svn commit: r349917 - head/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Thu Jul 11 19:36:18 2019 New Revision: 349917 URL: https://svnweb.freebsd.org/changeset/base/349917 Log: Remove a tautological test for adding a rule in the block that adds rules. MFC after:1 week Modified: head/sys/contrib/ipfilter/netinet/fil.c Modified: head/sy

svn commit: r349926 - stable/12/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 00:35:43 2019 New Revision: 349926 URL: https://svnweb.freebsd.org/changeset/base/349926 Log: MFC r348986: Register pfil hooks when VNET != vnet0. r302298, which virtualized ipf, assumed the pfil hook registration performed in ipf_modload() would take are of

svn commit: r349927 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 00:50:33 2019 New Revision: 349927 URL: https://svnweb.freebsd.org/changeset/base/349927 Log: MFC r348987, r348989: Resolve IPv6 checksum errors with stateful inspection. According to PR/203585 this appears to have been broken by r235959, which predates the i

svn commit: r349927 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 00:50:33 2019 New Revision: 349927 URL: https://svnweb.freebsd.org/changeset/base/349927 Log: MFC r348987, r348989: Resolve IPv6 checksum errors with stateful inspection. According to PR/203585 this appears to have been broken by r235959, which predates the i

svn commit: r349927 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 00:50:33 2019 New Revision: 349927 URL: https://svnweb.freebsd.org/changeset/base/349927 Log: MFC r348987, r348989: Resolve IPv6 checksum errors with stateful inspection. According to PR/203585 this appears to have been broken by r235959, which predates the i

svn commit: r349929 - head/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 01:59:08 2019 New Revision: 349929 URL: https://svnweb.freebsd.org/changeset/base/349929 Log: Move the new ipf_pcksum6() function from ip_fil_freebsd.c to fil.c. The reason for this is that ipftest(8), which still works on FreeBSD-11, fails to link to it, breaking

svn commit: r349931 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 02:14:05 2019 New Revision: 349931 URL: https://svnweb.freebsd.org/changeset/base/349931 Log: MFC r349927, r349929: r349927: Resolve IPv6 checksum errors with stateful inspection. According to PR/203585 this appears to have been broken by r235959, which p

svn commit: r349931 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 02:14:05 2019 New Revision: 349931 URL: https://svnweb.freebsd.org/changeset/base/349931 Log: MFC r349927, r349929: r349927: Resolve IPv6 checksum errors with stateful inspection. According to PR/203585 this appears to have been broken by r235959, which p

svn commit: r349932 - stable/12/sys/contrib/ipfilter/netinet

2019-07-11 Thread Cy Schubert
Author: cy Date: Fri Jul 12 02:15:06 2019 New Revision: 349932 URL: https://svnweb.freebsd.org/changeset/base/349932 Log: MFC r349929: Move the new ipf_pcksum6() function from ip_fil_freebsd.c to fil.c. The reason for this is that ipftest(8), which still works on FreeBSD-11, fails to li

svn commit: r349979 - head/sys/contrib/ipfilter/netinet

2019-07-13 Thread Cy Schubert
Author: cy Date: Sun Jul 14 02:46:30 2019 New Revision: 349979 URL: https://svnweb.freebsd.org/changeset/base/349979 Log: Recycle the unused FR_CMPSIZ macro which became orphaned in ipfilter 5 prior to its import into FreeBSD. This macro calculates the size to be compared within the frentry

svn commit: r349978 - head/sys/contrib/ipfilter/netinet

2019-07-13 Thread Cy Schubert
Author: cy Date: Sun Jul 14 02:46:26 2019 New Revision: 349978 URL: https://svnweb.freebsd.org/changeset/base/349978 Log: style(9) MFC after:3 days Modified: head/sys/contrib/ipfilter/netinet/fil.c Modified: head/sys/contrib/ipfilter/netinet/fil.c ===

svn commit: r349980 - head/sys/contrib/ipfilter/netinet

2019-07-13 Thread Cy Schubert
Author: cy Date: Sun Jul 14 02:46:34 2019 New Revision: 349980 URL: https://svnweb.freebsd.org/changeset/base/349980 Log: Calculate the offset of the interface name using FR_NAME rather than calclulating it "by hand". This improves consistency with the rest of the code and is in line with pl

svn commit: r350063 - head/sys/contrib/ipfilter/netinet

2019-07-16 Thread Cy Schubert
Author: cy Date: Tue Jul 16 19:00:38 2019 New Revision: 350063 URL: https://svnweb.freebsd.org/changeset/base/350063 Log: Refactor, removing one compare. This changes the return code however the caller only tests for 0 and != 0. One might ask then, why multiple return codes when the calle

svn commit: r350064 - head/sys/contrib/ipfilter/netinet

2019-07-16 Thread Cy Schubert
Author: cy Date: Tue Jul 16 19:00:42 2019 New Revision: 350064 URL: https://svnweb.freebsd.org/changeset/base/350064 Log: As of upstream fil.c CVS r1.53 (March 1, 2009), prior to the import of ipfilter 5.1.2 into FreeBSD-10, the fix for, 2580062 from/to targets should be able to use any inte

svn commit: r350073 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-16 Thread Cy Schubert
Author: cy Date: Wed Jul 17 01:05:33 2019 New Revision: 350073 URL: https://svnweb.freebsd.org/changeset/base/350073 Log: MFC r349978: style(9) Modified: stable/11/sys/contrib/ipfilter/netinet/fil.c Directory Properties: stable/11/ (props changed) Changes in other areas also in this

svn commit: r350073 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-16 Thread Cy Schubert
Author: cy Date: Wed Jul 17 01:05:33 2019 New Revision: 350073 URL: https://svnweb.freebsd.org/changeset/base/350073 Log: MFC r349978: style(9) Modified: stable/12/sys/contrib/ipfilter/netinet/fil.c Directory Properties: stable/12/ (props changed) Changes in other areas also in this

svn commit: r350080 - in vendor/sqlite3/dist: . tea

2019-07-17 Thread Cy Schubert
Author: cy Date: Wed Jul 17 14:14:51 2019 New Revision: 350080 URL: https://svnweb.freebsd.org/changeset/base/350080 Log: Import sqlite3-3.29.0 (329) Modified: vendor/sqlite3/dist/configure vendor/sqlite3/dist/configure.ac vendor/sqlite3/dist/shell.c vendor/sqlite3/dist/sqlite3.c

svn commit: r350081 - vendor/sqlite3/sqlite-autoconf-3290000

2019-07-17 Thread Cy Schubert
Author: cy Date: Wed Jul 17 14:17:50 2019 New Revision: 350081 URL: https://svnweb.freebsd.org/changeset/base/350081 Log: Tag import of sqlite3-3.29.0 (329) Added: vendor/sqlite3/sqlite-autoconf-329/ - copied from r350080, vendor/sqlite3/dist/

svn commit: r350103 - in head/contrib/sqlite3: . tea

2019-07-17 Thread Cy Schubert
Author: cy Date: Thu Jul 18 00:27:28 2019 New Revision: 350103 URL: https://svnweb.freebsd.org/changeset/base/350103 Log: MFV r350080: Update sqlite3-3.28.0 (328) --> sqlite3-3.29.0 (329) MFC after:1 week Modified: head/contrib/sqlite3/configure head/contrib/sqlite3/co

svn commit: r350110 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-18 Thread Cy Schubert
Author: cy Date: Thu Jul 18 11:43:09 2019 New Revision: 350110 URL: https://svnweb.freebsd.org/changeset/base/350110 Log: MFC r349898, r349916: ipfilter commands, in this case ipf(8), passes its operations and rules via an ioctl interface. Rules can be added or removed and stats and cou

svn commit: r350110 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-18 Thread Cy Schubert
Author: cy Date: Thu Jul 18 11:43:09 2019 New Revision: 350110 URL: https://svnweb.freebsd.org/changeset/base/350110 Log: MFC r349898, r349916: ipfilter commands, in this case ipf(8), passes its operations and rules via an ioctl interface. Rules can be added or removed and stats and cou

svn commit: r350111 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-18 Thread Cy Schubert
Author: cy Date: Thu Jul 18 11:46:37 2019 New Revision: 350111 URL: https://svnweb.freebsd.org/changeset/base/350111 Log: MFC r349917: Remove a tautological test for adding a rule in the block that adds rules. Modified: stable/12/sys/contrib/ipfilter/netinet/fil.c Directory Properties:

svn commit: r350111 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-18 Thread Cy Schubert
Author: cy Date: Thu Jul 18 11:46:37 2019 New Revision: 350111 URL: https://svnweb.freebsd.org/changeset/base/350111 Log: MFC r349917: Remove a tautological test for adding a rule in the block that adds rules. Modified: stable/11/sys/contrib/ipfilter/netinet/fil.c Directory Properties:

svn commit: r350188 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-20 Thread Cy Schubert
Author: cy Date: Sun Jul 21 00:44:52 2019 New Revision: 350188 URL: https://svnweb.freebsd.org/changeset/base/350188 Log: MFC r349979: Recycle the unused FR_CMPSIZ macro which became orphaned in ipfilter 5 prior to its import into FreeBSD. This macro calculates the size to be compared w

svn commit: r350188 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-20 Thread Cy Schubert
Author: cy Date: Sun Jul 21 00:44:52 2019 New Revision: 350188 URL: https://svnweb.freebsd.org/changeset/base/350188 Log: MFC r349979: Recycle the unused FR_CMPSIZ macro which became orphaned in ipfilter 5 prior to its import into FreeBSD. This macro calculates the size to be compared w

svn commit: r350189 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-20 Thread Cy Schubert
Author: cy Date: Sun Jul 21 00:47:06 2019 New Revision: 350189 URL: https://svnweb.freebsd.org/changeset/base/350189 Log: MFC r349980: Calculate the offset of the interface name using FR_NAME rather than calclulating it "by hand". This improves consistency with the rest of the code and

svn commit: r350189 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-20 Thread Cy Schubert
Author: cy Date: Sun Jul 21 00:47:06 2019 New Revision: 350189 URL: https://svnweb.freebsd.org/changeset/base/350189 Log: MFC r349980: Calculate the offset of the interface name using FR_NAME rather than calclulating it "by hand". This improves consistency with the rest of the code and

Re: svn commit: r342977 - in head/sys/dev: amdsmn amdtemp

2019-07-22 Thread Cy Schubert
> + temp = ((val >> AMDTEMP_REPTMP10H_CURTMP_SHIFT) & > + AMDTEMP_REPTMP10H_CURTMP_MASK) * 5 / 4; > + > + /* > + * On Family 15h and higher, if CurTmpTjSel is 11b, the range is > + * adjusted down by 49.0 degrees Cels

svn commit: r350234 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-22 Thread Cy Schubert
Author: cy Date: Tue Jul 23 02:30:24 2019 New Revision: 350234 URL: https://svnweb.freebsd.org/changeset/base/350234 Log: MFC r350063: Refactor, removing one compare. This changes the return code however the caller only tests for 0 and != 0. One might ask then, why multiple return co

svn commit: r350234 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-22 Thread Cy Schubert
Author: cy Date: Tue Jul 23 02:30:24 2019 New Revision: 350234 URL: https://svnweb.freebsd.org/changeset/base/350234 Log: MFC r350063: Refactor, removing one compare. This changes the return code however the caller only tests for 0 and != 0. One might ask then, why multiple return co

Re: svn commit: r350301 - head/lib/libsysdecode

2019-07-24 Thread Cy Schubert
; mv -f ${.TARGET}.tmp ${.TARGET} > > Hi Ed, This breaks 32-bit compatibility builds on amd64. --- all_subdir_lib/libsysdecode --- ===> lib/libsysdecode (all) make[5]: make[5]: don't know how to make /export/obj/opt/src/svn-current /amd64.amd64/obj-lib32/tmp/sys/netinet/i

svn commit: r350434 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-29 Thread Cy Schubert
Author: cy Date: Tue Jul 30 03:32:39 2019 New Revision: 350434 URL: https://svnweb.freebsd.org/changeset/base/350434 Log: MFC r350064: As of upstream fil.c CVS r1.53 (March 1, 2009), prior to the import of ipfilter 5.1.2 into FreeBSD-10, the fix for, 2580062 from/to targets should be ab

svn commit: r350434 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-07-29 Thread Cy Schubert
Author: cy Date: Tue Jul 30 03:32:39 2019 New Revision: 350434 URL: https://svnweb.freebsd.org/changeset/base/350434 Log: MFC r350064: As of upstream fil.c CVS r1.53 (March 1, 2009), prior to the import of ipfilter 5.1.2 into FreeBSD-10, the fix for, 2580062 from/to targets should be ab

svn commit: r350548 - head/sys/contrib/ipfilter/netinet

2019-08-02 Thread Cy Schubert
Author: cy Date: Fri Aug 2 22:58:45 2019 New Revision: 350548 URL: https://svnweb.freebsd.org/changeset/base/350548 Log: MFC after:3 days Modified: head/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c Modified: head/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c ===

Re: svn commit: r350548 - head/sys/contrib/ipfilter/netinet

2019-08-02 Thread Cy Schubert
In message <201908022258.x72mwjje001...@repo.freebsd.org>, Cy Schubert writes: > Author: cy > Date: Fri Aug 2 22:58:45 2019 > New Revision: 350548 > URL: https://svnweb.freebsd.org/changeset/base/350548 > > Log: > MFC after: 3 days > This was stupid. The initi

Re: svn commit: r350548 - head/sys/contrib/ipfilter/netinet

2019-08-02 Thread Cy Schubert
In message <201908022307.x72n7ib0010...@slippy.cwsent.com>, Cy Schubert writes: > In message <201908022258.x72mwjje001...@repo.freebsd.org>, Cy Schubert > writes: > > Author: cy > > Date: Fri Aug 2 22:58:45 2019 > > New Revision: 350548 > > URL: https:

svn commit: r350568 - head/sys/contrib/ipfilter/netinet

2019-08-04 Thread Cy Schubert
Author: cy Date: Sun Aug 4 12:47:38 2019 New Revision: 350568 URL: https://svnweb.freebsd.org/changeset/base/350568 Log: Resolve ipfilter kld unload issues related to VNET jails. When the ipfilter kld is loaded, used within VNET jail, and unloaded, then subsequent loading, use, and unloa

svn commit: r350567 - head/sys/contrib/ipfilter/netinet

2019-08-04 Thread Cy Schubert
Author: cy Date: Sun Aug 4 12:47:35 2019 New Revision: 350567 URL: https://svnweb.freebsd.org/changeset/base/350567 Log: Returning an uninitialized error is a bad thing. MFC after:3 days Modified: head/sys/contrib/ipfilter/netinet/mlfk_ipl.c Modified: head/sys/contrib/ipfilter/neti

svn commit: r350577 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-08-04 Thread Cy Schubert
Author: cy Date: Mon Aug 5 00:32:57 2019 New Revision: 350577 URL: https://svnweb.freebsd.org/changeset/base/350577 Log: MFC r350548: #include whitespace adjustments. Modified: stable/11/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c Directory Properties: stable/11/ (props changed)

svn commit: r350577 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-08-04 Thread Cy Schubert
Author: cy Date: Mon Aug 5 00:32:57 2019 New Revision: 350577 URL: https://svnweb.freebsd.org/changeset/base/350577 Log: MFC r350548: #include whitespace adjustments. Modified: stable/12/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c Directory Properties: stable/12/ (props changed)

Re: svn commit: r349929 - head/sys/contrib/ipfilter/netinet

2019-08-05 Thread Cy Schubert
In message <20190806011317.gg1...@freebsd.org>, Gleb Smirnoff writes: > Hi, > > On Fri, Jul 12, 2019 at 01:59:09AM +0000, Cy Schubert wrote: > C> Log: > C> Move the new ipf_pcksum6() function from ip_fil_freebsd.c to fil.c. > C> The reason for this is that

svn commit: r350667 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-08-06 Thread Cy Schubert
Author: cy Date: Wed Aug 7 01:03:35 2019 New Revision: 350667 URL: https://svnweb.freebsd.org/changeset/base/350667 Log: MFC r350567: Returning an uninitialized error is a bad thing. Modified: stable/12/sys/contrib/ipfilter/netinet/mlfk_ipl.c Directory Properties: stable/12/ (props

svn commit: r350667 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-08-06 Thread Cy Schubert
Author: cy Date: Wed Aug 7 01:03:35 2019 New Revision: 350667 URL: https://svnweb.freebsd.org/changeset/base/350667 Log: MFC r350567: Returning an uninitialized error is a bad thing. Modified: stable/11/sys/contrib/ipfilter/netinet/mlfk_ipl.c Directory Properties: stable/11/ (props

svn commit: r350668 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-08-06 Thread Cy Schubert
Author: cy Date: Wed Aug 7 01:08:57 2019 New Revision: 350668 URL: https://svnweb.freebsd.org/changeset/base/350668 Log: MFC r350568: Resolve ipfilter kld unload issues related to VNET jails. When the ipfilter kld is loaded, used within VNET jail, and unloaded, then subsequent loadi

svn commit: r350668 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

2019-08-06 Thread Cy Schubert
Author: cy Date: Wed Aug 7 01:08:57 2019 New Revision: 350668 URL: https://svnweb.freebsd.org/changeset/base/350668 Log: MFC r350568: Resolve ipfilter kld unload issues related to VNET jails. When the ipfilter kld is loaded, used within VNET jail, and unloaded, then subsequent loadi

svn commit: r350669 - stable/11/sys/contrib/ipfilter/netinet

2019-08-06 Thread Cy Schubert
Author: cy Date: Wed Aug 7 01:34:41 2019 New Revision: 350669 URL: https://svnweb.freebsd.org/changeset/base/350669 Log: Revert 350668 from stable/11 only. It is not at the level of VNET support. Modified: stable/11/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c stable/11/sys/contrib/ipfilt

Re: svn commit: r350550 - head/share/mk

2019-08-07 Thread Cy Schubert
treated similar > development-facilitating features in the past, i.e. WITNESS/INVARIANTS, > malloc-debug. Agreed. As with John, I have a combination of git and svn trees on various machines. Some install to different partitions on physical hardware while others are tested in VMs. The ex

svn commit: r350880 - head/sys/contrib/ipfilter/netinet

2019-08-11 Thread Cy Schubert
Author: cy Date: Sun Aug 11 23:54:49 2019 New Revision: 350880 URL: https://svnweb.freebsd.org/changeset/base/350880 Log: r272552 applied the patch from ipfilter upstream fil.c r1.129 to fix broken ipfilter rule matches (upstream bug #554). The upstream patch was incomplete, it resolved all

svn commit: r350881 - head/sys/contrib/ipfilter/netinet

2019-08-11 Thread Cy Schubert
Author: cy Date: Sun Aug 11 23:54:52 2019 New Revision: 350881 URL: https://svnweb.freebsd.org/changeset/base/350881 Log: Calculate the number interface array elements using the new FR_NUM macro instead of the hard-coded value of 4. This is a precursor to increasing the number of interfaces

svn commit: r350882 - head/sys/contrib/ipfilter/netinet

2019-08-11 Thread Cy Schubert
Author: cy Date: Mon Aug 12 02:42:47 2019 New Revision: 350882 URL: https://svnweb.freebsd.org/changeset/base/350882 Log: Initialize the frentry (the control block that defines a rule) checksum to zero. Matching checksums save time and effort by mitigating the need for full rule compare.

svn commit: r347234 - head/lib/libpam/modules/pam_login_access

2019-05-07 Thread Cy Schubert
Author: cy Date: Tue May 7 20:39:39 2019 New Revision: 347234 URL: https://svnweb.freebsd.org/changeset/base/347234 Log: Improve the legibility of the login.access.5 man page by separating each argument into its own paragraph. MFC after:3 days Modified: head/lib/libpam/modules/pam

svn commit: r347347 - in stable: 11/contrib/sqlite3 11/contrib/sqlite3/tea 11/contrib/sqlite3/tea/generic 12/contrib/sqlite3 12/contrib/sqlite3/tea 12/contrib/sqlite3/tea/generic

2019-05-08 Thread Cy Schubert
Author: cy Date: Wed May 8 15:48:55 2019 New Revision: 347347 URL: https://svnweb.freebsd.org/changeset/base/347347 Log: MFC r347139: MFV r347136: Update sqlite3-3.27.2 (3270200) --> sqlite3-3.28.0 (328) Security: CVE-2019-9937, CVE-2019-9936 Modified: stable/12/contrib/sql

svn commit: r347347 - in stable: 11/contrib/sqlite3 11/contrib/sqlite3/tea 11/contrib/sqlite3/tea/generic 12/contrib/sqlite3 12/contrib/sqlite3/tea 12/contrib/sqlite3/tea/generic

2019-05-08 Thread Cy Schubert
Author: cy Date: Wed May 8 15:48:55 2019 New Revision: 347347 URL: https://svnweb.freebsd.org/changeset/base/347347 Log: MFC r347139: MFV r347136: Update sqlite3-3.27.2 (3270200) --> sqlite3-3.28.0 (328) Security: CVE-2019-9937, CVE-2019-9936 Modified: stable/11/contrib/sql

svn commit: r347420 - in stable: 10/lib/libpam/modules/pam_login_access 11/lib/libpam/modules/pam_login_access 12/lib/libpam/modules/pam_login_access

2019-05-09 Thread Cy Schubert
Author: cy Date: Fri May 10 01:02:07 2019 New Revision: 347420 URL: https://svnweb.freebsd.org/changeset/base/347420 Log: MFC r347234: Improve the legibility of the login.access.5 man page by separating each argument into its own paragraph. Modified: stable/12/lib/libpam/modules/pam_lo

svn commit: r347420 - in stable: 10/lib/libpam/modules/pam_login_access 11/lib/libpam/modules/pam_login_access 12/lib/libpam/modules/pam_login_access

2019-05-09 Thread Cy Schubert
Author: cy Date: Fri May 10 01:02:07 2019 New Revision: 347420 URL: https://svnweb.freebsd.org/changeset/base/347420 Log: MFC r347234: Improve the legibility of the login.access.5 man page by separating each argument into its own paragraph. Modified: stable/11/lib/libpam/modules/pam_lo

svn commit: r347420 - in stable: 10/lib/libpam/modules/pam_login_access 11/lib/libpam/modules/pam_login_access 12/lib/libpam/modules/pam_login_access

2019-05-09 Thread Cy Schubert
Author: cy Date: Fri May 10 01:02:07 2019 New Revision: 347420 URL: https://svnweb.freebsd.org/changeset/base/347420 Log: MFC r347234: Improve the legibility of the login.access.5 man page by separating each argument into its own paragraph. Modified: stable/10/lib/libpam/modules/pam_lo

Re: svn commit: r347477 - head/sys/kern

2019-05-10 Thread Cy Schubert
ved by: kib (mentor) > > Modified: > head/sys/kern/subr_blist.c > -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. ___ svn-src-all@freebsd.org mailing list https

Re: svn commit: r347488 - head/usr.sbin/ntp/ntpd

2019-05-11 Thread Cy Schubert
dated upstream since 2017. USNO updates the file when they last paid attention to the file by not updating it. NIST only updates the file when there is indeed an update, that being Ian's point. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need o

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-11 Thread Cy Schubert
hen IPSEC is compiled in. Looking at the upstream code, Darren checks for IPSEC only for BSD based kernels. Zeroing out the pointer only when IPSEC is compiled in, regardless whether the mbuf in question was touched by IPSEC or not seems a little sketchy to me. However I'm inclined to use

<    1   2   3   4   5   6   7   8   9   10   >