Re: svn commit: r359374 - in head: . share/man/man4 share/man/man7 share/man/man9 sys/crypto/aesni sys/crypto/armv8 sys/crypto/blake2 sys/crypto/ccp sys/crypto/via sys/dev/cesa sys/dev/cxgbe sys/dev/c

2020-04-13 Thread John Baldwin
On 4/13/20 12:31 PM, Warner Losh wrote: > On Mon, Apr 13, 2020 at 1:22 PM John-Mark Gurney wrote: > >> John Baldwin wrote this message on Mon, Apr 13, 2020 at 09:56 -0700: >>> On 4/12/20 1:08 PM, Xin Li wrote: >>>> >>>> >>>> On 3/27

Re: svn commit: r359374 - in head: . share/man/man4 share/man/man7 share/man/man9 sys/crypto/aesni sys/crypto/armv8 sys/crypto/blake2 sys/crypto/ccp sys/crypto/via sys/dev/cesa sys/dev/cxgbe sys/dev/c

2020-04-13 Thread John Baldwin
On 4/12/20 1:08 PM, Xin Li wrote: > > > On 3/27/20 11:25 AM, John Baldwin wrote: > [...]> - Drivers no longer register a list of supported algorithms. This >> doesn't quite work when you factor in modes (e.g. a driver might >> support both AES-CBC a

svn commit: r359788 - head

2020-04-10 Thread John Baldwin
Author: jhb Date: Fri Apr 10 23:13:29 2020 New Revision: 359788 URL: https://svnweb.freebsd.org/changeset/base/359788 Log: Document removal of deprecated algorithms for in-kernel GSS. Modified: head/RELNOTES Modified: head/RELNOTES

svn commit: r359787 - head/usr.sbin/gssd

2020-04-10 Thread John Baldwin
Author: jhb Date: Fri Apr 10 23:10:28 2020 New Revision: 359787 URL: https://svnweb.freebsd.org/changeset/base/359787 Log: Remove the -o option from gssd(8). This uses DES and the kernel no longer supports DES for in-kernel GSS. Reviewed by: kp Relnotes: yes Sponsored by:

svn commit: r359786 - in head/sys: conf kgssapi/krb5 modules/kgssapi_krb5

2020-04-10 Thread John Baldwin
Author: jhb Date: Fri Apr 10 23:08:41 2020 New Revision: 359786 URL: https://svnweb.freebsd.org/changeset/base/359786 Log: Remove support for Kernel GSS algorithms deprecated in r348875. This removes support for using DES, Triple DES, and RC4. Reviewed by: cem, kp Tested by:kp

Re: svn commit: r359784 - in head/sys/dev/cxgbe: . crypto

2020-04-10 Thread John Baldwin
On 4/10/20 3:27 PM, John Baldwin wrote: > Author: jhb > Date: Fri Apr 10 22:27:45 2020 > New Revision: 359784 > URL: https://svnweb.freebsd.org/changeset/base/359784 > > Log: > Use both crypto engines on a T6. > > A T6 adapter contains two crypto e

svn commit: r359784 - in head/sys/dev/cxgbe: . crypto

2020-04-10 Thread John Baldwin
Author: jhb Date: Fri Apr 10 22:27:45 2020 New Revision: 359784 URL: https://svnweb.freebsd.org/changeset/base/359784 Log: Use both crypto engines on a T6. A T6 adapter contains two crypto engines on separate channels. This commit distributes sessions between the two engines.

svn commit: r359570 - head/sys/opencrypto

2020-04-02 Thread John Baldwin
Author: jhb Date: Thu Apr 2 17:22:16 2020 New Revision: 359570 URL: https://svnweb.freebsd.org/changeset/base/359570 Log: Avoid checking pointers that are never NULL. Coverity noted that cod pointer is always non-NULL at the end of cryptodev_aead(). While here, fix cryptodev_op() to

svn commit: r359569 - head/sys/opencrypto

2020-04-02 Thread John Baldwin
Author: jhb Date: Thu Apr 2 16:55:28 2020 New Revision: 359569 URL: https://svnweb.freebsd.org/changeset/base/359569 Log: Remove duplicate conditional. CID: 1422192 Reported by: Coverity Modified: head/sys/opencrypto/crypto.c Modified: head/sys/opencrypto/crypto.c

svn commit: r359524 - head/sys/kgssapi/krb5

2020-04-02 Thread John Baldwin
Author: jhb Date: Wed Apr 1 17:09:21 2020 New Revision: 359524 URL: https://svnweb.freebsd.org/changeset/base/359524 Log: Set crp_ilen for crypto requests. Assertions in crypto_dispatch() depend on this value being set to verify that payload and AAD regions are in bounds. Also,

svn commit: r359530 - in head: . lib/libsysdecode sys/amd64/amd64 sys/amd64/ia32 sys/arm/arm sys/arm64/arm64 sys/compat/ia32 sys/conf sys/fs/procfs sys/i386/i386 sys/kern sys/mips/mips sys/modules/...

2020-04-02 Thread John Baldwin
Author: jhb Date: Wed Apr 1 19:22:09 2020 New Revision: 359530 URL: https://svnweb.freebsd.org/changeset/base/359530 Log: Retire procfs-based process debugging. Modern debuggers and process tracers use ptrace() rather than procfs for debugging. ptrace() has a supserset of functionality

Re: svn commit: r359459 - head/share/man/man5

2020-03-30 Thread John Baldwin
ther changes since the last regen. Hmm, 359454 was a markup fix to elf.5 and I haven't seen the commit to actually remove GDB_LIBEXEC yet? -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To

svn commit: r359467 - head/lib/libc/sys

2020-03-30 Thread John Baldwin
Author: jhb Date: Mon Mar 30 21:48:47 2020 New Revision: 359467 URL: https://svnweb.freebsd.org/changeset/base/359467 Log: Trim some duplicate EIO descriptions. While here, drop an extra conjunction from the list of error conditions for the remaining EIO description in symlink(2).

svn commit: r359465 - in head: lib/libc/sys share/man/man9

2020-03-30 Thread John Baldwin
Author: jhb Date: Mon Mar 30 21:44:00 2020 New Revision: 359465 URL: https://svnweb.freebsd.org/changeset/base/359465 Log: Document EINTEGRITY errors for many system calls. EINTEGRITY was previously documented as a UFS-specific error for mount(2). This documents EINTEGRITY as a

Re: svn commit: r359374 - in head: . share/man/man4 share/man/man7 share/man/man9 sys/crypto/aesni sys/crypto/armv8 sys/crypto/blake2 sys/crypto/ccp sys/crypto/via sys/dev/cesa sys/dev/cxgbe sys/dev/c

2020-03-27 Thread John Baldwin
On 3/27/20 11:25 AM, John Baldwin wrote: > Author: jhb > Date: Fri Mar 27 18:25:23 2020 > New Revision: 359374 > URL: https://svnweb.freebsd.org/changeset/base/359374 > > Log: > Refactor driver and consumer interfaces for OCF (in-kernel crypto). I have tested as much

svn commit: r359374 - in head: . share/man/man4 share/man/man7 share/man/man9 sys/crypto/aesni sys/crypto/armv8 sys/crypto/blake2 sys/crypto/ccp sys/crypto/via sys/dev/cesa sys/dev/cxgbe sys/dev/cx...

2020-03-27 Thread John Baldwin
Author: jhb Date: Fri Mar 27 18:25:23 2020 New Revision: 359374 URL: https://svnweb.freebsd.org/changeset/base/359374 Log: Refactor driver and consumer interfaces for OCF (in-kernel crypto). - The linked list of cryptoini structures used in session initialization is replaced with a new

Re: svn commit: r359349 - head/gnu/usr.bin/binutils/ld

2020-03-27 Thread John Baldwin
On 3/27/20 9:54 AM, Brandon Bergren wrote: > > > On Fri, Mar 27, 2020, at 11:40 AM, John Baldwin wrote: >> On 3/26/20 6:12 PM, Brandon Bergren wrote: >>> Author: bdragon >>> Date: Fri Mar 27 01:12:11 2020 >>> New Revision: 359349 >>> UR

Re: svn commit: r359349 - head/gnu/usr.bin/binutils/ld

2020-03-27 Thread John Baldwin
leted: > head/gnu/usr.bin/binutils/ld/ I think Ed mentioned some other cleanups to do as part of this change in ObsoleteFiles.inc as well? -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all

svn commit: r359275 - head

2020-03-24 Thread John Baldwin
Author: jhb Date: Tue Mar 24 18:16:02 2020 New Revision: 359275 URL: https://svnweb.freebsd.org/changeset/base/359275 Log: Disable rarely used architecture variants in make universe by default. If EXTRA_TARGETS is defined, build all supported architecture variants. By default, build

svn commit: r359263 - head/sys/geom/eli

2020-03-23 Thread John Baldwin
Author: jhb Date: Mon Mar 23 21:26:32 2020 New Revision: 359263 URL: https://svnweb.freebsd.org/changeset/base/359263 Log: Use the newer EINTEGRITY error when authentication fails. GELI used to fail with EINVAL when a read request spanned a disk sector whose contents did not match the

Re: svn commit: r357614 - in head/sys: kern sys

2020-03-20 Thread John Baldwin
d if_cxgbe That should give you the error, and then checking the hw.cxgbe.config_file sysctl afterwards will show "default" instead of "kern_tls". Note that you don't need any cxgbe hardware to reproduce this as a fix would result in the value of the sysctl after the kldload be

Re: svn commit: r359053 - head/sys/kern

2020-03-17 Thread John Baldwin
ID"); >> + >> /* >> * The osrelease string is copied from the global (osrelease in vers.c) into >> * prison0 by a sysinit and is inherited by child jails if not changed at >> jail > > This seems a bit complex. Why run a sysinit to init a mutex so that >

svn commit: r359054 - head/lib/libsysdecode

2020-03-17 Thread John Baldwin
Author: jhb Date: Tue Mar 17 23:22:07 2020 New Revision: 359054 URL: https://svnweb.freebsd.org/changeset/base/359054 Log: Fix the workaround to ignore the #warning for GCC. clang and gcc use different warning flags for #warning preprocessor directives. Reported by: Jenkins MFC

svn commit: r359050 - head/tools/build/mk

2020-03-17 Thread John Baldwin
Author: jhb Date: Tue Mar 17 21:11:38 2020 New Revision: 359050 URL: https://svnweb.freebsd.org/changeset/base/359050 Log: Add missing DTrace files for WITHOUT_CDDL=yes. Reviewed by: dteske MFC after:1 week Sponsored by: DARPA Differential Revision:

Re: svn commit: r359047 - in head: lib/libsysdecode sys/fs/procfs sys/sys

2020-03-17 Thread John Baldwin
On 3/17/20 11:44 AM, John Baldwin wrote: > Author: jhb > Date: Tue Mar 17 18:44:03 2020 > New Revision: 359047 > URL: https://svnweb.freebsd.org/changeset/base/359047 > > Log: > Mark procfs-based process debugging as deprecated for FreeBSD 13. > > Attempting

svn commit: r359047 - in head: lib/libsysdecode sys/fs/procfs sys/sys

2020-03-17 Thread John Baldwin
Author: jhb Date: Tue Mar 17 18:44:03 2020 New Revision: 359047 URL: https://svnweb.freebsd.org/changeset/base/359047 Log: Mark procfs-based process debugging as deprecated for FreeBSD 13. Attempting to use ioctls on /proc//mem to control a process will trigger warnings on the console.

Re: svn commit: r358848 - in head/sys/amd64/vmm: intel io

2020-03-10 Thread John Baldwin
iews.freebsd.org/D22942 Reviewed by:grehan Also, it is still good form to wrap the commit logs to fit in 80 cols. -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r358789 - head/share/man/man7

2020-03-10 Thread John Baldwin
r358454. > > Sponsored by: The FreeBSD Foundation Can you update the platforms page on the website as well? -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send

Re: svn commit: r358687 - head/libexec/tftpd/tests

2020-03-05 Thread John Baldwin
nctional tests, which isn't defined > until C11. Raise the -std to C11 to fix the build under freebsd-gcc{6,9}. > > Reported by:mhorne, Jenkins/CI Thanks for fixing! -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://li

Re: svn commit: r358561 - in head: . share/man/man5 share/man/man7 tools/build/options tools/tools/nanobsd/dhcpd tools/tools/nanobsd/embedded usr.bin usr.bin/calendar usr.bin/calendar/calendars usr.bi

2020-03-02 Thread John Baldwin
ndar CVEs or that it's been a maintenance burden? -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r358556 - in head: libexec/tftpd libexec/tftpd/tests usr.bin/tftp

2020-03-02 Thread John Baldwin
Author: jhb Date: Mon Mar 2 22:19:30 2020 New Revision: 358556 URL: https://svnweb.freebsd.org/changeset/base/358556 Log: Add support for the TFTP windowsize option described in RFC 7440. The windowsize option permits multiple blocks to be transmitted before the receiver sends an ACK

Re: svn commit: r358486 - head/sys/dev/bce

2020-03-02 Thread John Baldwin
d fine. Good to clean out the cruft regardless. -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r358415 - in head/sys/dev/cxgbe: . tom

2020-02-27 Thread John Baldwin
Author: jhb Date: Fri Feb 28 00:42:27 2020 New Revision: 358415 URL: https://svnweb.freebsd.org/changeset/base/358415 Log: Rename TOE TLS stats from [rt]x_tls_* to [rt]x_toe_tls_*. This more clearly differentiates TLS records encrypted and decrypted in TOE connections from those

Re: svn commit: r358392 - head/share/man/man9

2020-02-27 Thread John Baldwin
defining alignas, etc. I think what we should do for the kernel is have define map static_assert to _Static_assert and replace existing _Static_assert usage with the proper spelling. -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://l

svn commit: r358394 - head/usr.sbin/bhyve

2020-02-27 Thread John Baldwin
Author: jhb Date: Thu Feb 27 16:51:41 2020 New Revision: 358394 URL: https://svnweb.freebsd.org/changeset/base/358394 Log: Use stream_read() to read all 12 bytes of the RFB client version. read() can return a short read, whereas stream_read() waits until the full version string is read.

Re: svn commit: r358346 - in head/libexec/rtld-elf: . rtld-libc

2020-02-26 Thread John Baldwin
tld-libc/Makefile.inc > head/libexec/rtld-elf/rtld.c > head/libexec/rtld-elf/rtld_tls.h libexec/rtld-elf/sparc64? -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, se

Re: svn commit: r358247 - in head/sys: conf riscv/include

2020-02-24 Thread John Baldwin
t to see if you get an illegal instruction fault (subject to your SBI choosing to emulate that). -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r357891 - head/sys/dev/mlx5/mlx5_en

2020-02-13 Thread John Baldwin
Author: jhb Date: Thu Feb 13 23:04:11 2020 New Revision: 357891 URL: https://svnweb.freebsd.org/changeset/base/357891 Log: Don't check the auth algorithm for GCM. The upstream OpenSSL changes only set the cipher for GCM since the authentication is redundant, and changes to OCF will soon

svn commit: r357890 - in head/sys/dev/cxgbe: . crypto

2020-02-13 Thread John Baldwin
Author: jhb Date: Thu Feb 13 22:55:45 2020 New Revision: 357890 URL: https://svnweb.freebsd.org/changeset/base/357890 Log: Remove the per-TXQ tls_wrs stat. It duplicated the kern_tls_records stat and was not conditional on NIC TLS being enabled. Reviewed by: np Sponsored by:

Re: svn commit: r357361 - in head/sys: kern sys ufs/ufs vm

2020-02-11 Thread John Baldwin
On 2/10/20 11:54 AM, Mateusz Guzik wrote: > On 2/3/20, John Baldwin wrote: >> On 1/31/20 10:46 PM, Mateusz Guzik wrote: >>> Author: mjg >>> Date: Sat Feb 1 06:46:55 2020 >>> New Revision: 357361 >>> URL: https://svnweb.freebsd.org/changese

Re: svn commit: r357695 - in head: sys/kern sys/sys usr.bin/procstat

2020-02-11 Thread John Baldwin
On 2/10/20 11:15 AM, Konstantin Belousov wrote: > On Mon, Feb 10, 2020 at 10:11:43AM -0800, John Baldwin wrote: >> On 2/9/20 4:10 AM, Konstantin Belousov wrote: >>> Author: kib >>> Date: Sun Feb 9 12:10:37 2020 >>> New Revision: 357695 >>> URL: htt

Re: svn commit: r357740 - head/usr.sbin/ntp

2020-02-10 Thread John Baldwin
defined(__arm__) > #define STR_SYSTEM "arm-undermydesk-freebsd" > -#elif defined(__sparc64__) > -#define STR_SYSTEM "sparc64-undermydesk-freebsd" > -#elif defined(__sparc__) > -#define STR_SYSTEM "sparc-undermydesk-freebsd

Re: svn commit: r357703 - head/share/mk

2020-02-10 Thread John Baldwin
re going to do this for any external GCC? It's also broken on amd64, etc. as well when using external GCC. -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r357695 - in head: sys/kern sys/sys usr.bin/procstat

2020-02-10 Thread John Baldwin
I doc says that "bits under the 0xff00 mask are reserved for system semantics". The powerpc and x86-64 docs don't define any bits at all. In practice I think we are free to use AT_FLAGS however we wish as no use cases of "standard" bits have arisen since AT_FLAGS was first define

svn commit: r357643 - head/lib/libc/riscv/gen

2020-02-06 Thread John Baldwin
Author: jhb Date: Thu Feb 6 21:46:15 2020 New Revision: 357643 URL: https://svnweb.freebsd.org/changeset/base/357643 Log: Tidy the _set_tp function for RISC-V. - Use a constant for the offset instead of a magic number. - Use an addi instruction that writes to tp directly instead of a mv

svn commit: r357632 - head/sys/riscv/riscv

2020-02-06 Thread John Baldwin
Author: jhb Date: Thu Feb 6 18:04:45 2020 New Revision: 357632 URL: https://svnweb.freebsd.org/changeset/base/357632 Log: Use the context created in makectx() for stack traces. Always use the kdb_thr_ctx() for db_trace_thread() as on other architectures. Initialize pcb_ra to be the

svn commit: r357630 - head/sys/riscv/riscv

2020-02-06 Thread John Baldwin
Bukin * All rights reserved. + * Copyright (c) 2020 John Baldwin * * Portions of this software were developed by Semihalf under * the sponsorship of the FreeBSD Foundation. @@ -38,15 +39,18 @@ #include __FBSDID("$FreeBSD$"); + #include -#include #include -#include

svn commit: r357595 - head/sys/riscv/include

2020-02-05 Thread John Baldwin
Author: jhb Date: Wed Feb 5 20:34:22 2020 New Revision: 357595 URL: https://svnweb.freebsd.org/changeset/base/357595 Log: Fix EXCP_MASK to include all relevant bits from scause. While cause codes higher than 16 are reserved, the exception code field of the register is defined to be all

svn commit: r357594 - head/sys/riscv/riscv

2020-02-05 Thread John Baldwin
Author: jhb Date: Wed Feb 5 20:32:37 2020 New Revision: 357594 URL: https://svnweb.freebsd.org/changeset/base/357594 Log: Use csr_read() to read sstatus instead of inline assembly. While here, remove a local variable to avoid the CSR read in non-debug kernels. Reviewed by: mhorne

svn commit: r357593 - head/sys/riscv/riscv

2020-02-05 Thread John Baldwin
Author: jhb Date: Wed Feb 5 20:11:08 2020 New Revision: 357593 URL: https://svnweb.freebsd.org/changeset/base/357593 Log: Remove stale workaround for the htif console. In practice this discarded all characters entered at the DDB prompt. Reviewed by: br MFC after:1 week

svn commit: r357591 - head/sys/riscv/include

2020-02-05 Thread John Baldwin
Author: jhb Date: Wed Feb 5 20:06:35 2020 New Revision: 357591 URL: https://svnweb.freebsd.org/changeset/base/357591 Log: Read the breakpoint instruction to determine its length in BKPT_SKIP. This fixes continuing from debug.kdb.enter=1 after enabling the use of compressed instructions

Re: svn commit: r357361 - in head/sys: kern sys ufs/ufs vm

2020-02-03 Thread John Baldwin
S_ACL */ > > -/* > - * Mark this file's access time for update for vfs_mark_atime(). This > - * is called from execve() and mmap(). > - */ Why remove this comment rather than update it? It is largely still true and explains the purpose of the VOP (update the atime) which is now no lon

Re: svn commit: r357407 - head

2020-02-03 Thread John Baldwin
l/lib/libdtrace requires lib/libproc and lib/librtld_db > -.if ${MACHINE_CPUARCH} != "sparc64" > _prebuild_libs+= lib/libprocstat lib/libproc lib/librtld_db > lib/libprocstat__L: lib/libelf__L lib/libkvm__L lib/libutil__L >

Re: svn commit: r357337 - head/sys/riscv/include

2020-01-31 Thread John Baldwin
the compiler will always get those correct. -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r357344 - head/sys/riscv/riscv

2020-01-31 Thread John Baldwin
Author: jhb Date: Fri Jan 31 19:00:48 2020 New Revision: 357344 URL: https://svnweb.freebsd.org/changeset/base/357344 Log: Add stricter checks on user changes to SSTATUS. Rather than trying to blacklist which bits userland can't write to via sigreturn() or setcontext(), only permit

svn commit: r357337 - head/sys/riscv/include

2020-01-31 Thread John Baldwin
Author: jhb Date: Fri Jan 31 17:49:15 2020 New Revision: 357337 URL: https://svnweb.freebsd.org/changeset/base/357337 Log: Fix 64-bit value of SSTATUS_SD to use an unsigned long. While here, fix MSTATUS_SD to match SSTATUS_SD. Reviewed by: mhorne MFC after:2 weeks Sponsored

svn commit: r357313 - head/sys/riscv/riscv

2020-01-30 Thread John Baldwin
Author: jhb Date: Thu Jan 30 22:19:48 2020 New Revision: 357313 URL: https://svnweb.freebsd.org/changeset/base/357313 Log: Trim duplicate CSR swaps from user exceptions. The stack pointer is swapped with the sscratch CSR just before the jump to cpu_exception_handler_user where the first

svn commit: r357305 - in head/sys/riscv: include riscv

2020-01-30 Thread John Baldwin
Author: jhb Date: Thu Jan 30 19:15:27 2020 New Revision: 357305 URL: https://svnweb.freebsd.org/changeset/base/357305 Log: Remove unused fields from struct pcb. cpu_switch/throw() and savectx() do not save or restore any values in these fields which mostly held non-callee-save registers.

svn commit: r357302 - head/sys/kern

2020-01-30 Thread John Baldwin
Author: jhb Date: Thu Jan 30 18:28:02 2020 New Revision: 357302 URL: https://svnweb.freebsd.org/changeset/base/357302 Log: Fix use of an uninitialized variable. ctx (and thus ctx.flags) is stack garbage at the start of this function, so initialize ctx.flags to an explicit value instead

Re: svn commit: r357147 - head/sys/kern

2020-01-26 Thread John Baldwin
On 1/26/20 6:23 AM, John Baldwin wrote: > Author: jhb > Date: Sun Jan 26 14:23:27 2020 > New Revision: 357147 > URL: https://svnweb.freebsd.org/changeset/base/357147 > > Log: > Revert accidental change from r357146. Oops, this was a different warning fix which I've ope

svn commit: r357147 - head/sys/kern

2020-01-26 Thread John Baldwin
Author: jhb Date: Sun Jan 26 14:23:27 2020 New Revision: 357147 URL: https://svnweb.freebsd.org/changeset/base/357147 Log: Revert accidental change from r357146. Modified: head/sys/kern/subr_stats.c Modified: head/sys/kern/subr_stats.c

svn commit: r357146 - in head/sys: dev/mrsas dev/sound/pci kern

2020-01-26 Thread John Baldwin
Author: jhb Date: Sun Jan 26 14:20:57 2020 New Revision: 357146 URL: https://svnweb.freebsd.org/changeset/base/357146 Log: Fix some misleading indentation warnings reported by recent clang. These should not be any functional change. While the change in emul10kx-pcm.c looks like a real

svn commit: r357145 - head/sys/conf

2020-01-26 Thread John Baldwin
Author: jhb Date: Sun Jan 26 14:19:08 2020 New Revision: 357145 URL: https://svnweb.freebsd.org/changeset/base/357145 Log: Compile hack.c with normal CFLAGS + -shared -nostdlib. Originally, hack.c was compiled into a shard object with just -shared -nostdlib. This assumed that ${CC} did

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-26 Thread John Baldwin
not be impossible by simply using m_nextpkt chains in mbufs passed up to ether_input and having ether_input pass them in a loop to the next higher loop (as a first step). That would reduce unlock/lock operations in drivers (for those still using locks on receive) as well

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-26 Thread John Baldwin
'Edit related revisions' in the web ui if you forget to tag a commit. -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r357062 - head/share/man/man9

2020-01-23 Thread John Baldwin
Author: jhb Date: Thu Jan 23 23:36:58 2020 New Revision: 357062 URL: https://svnweb.freebsd.org/changeset/base/357062 Log: Correct the return types of fueword*(). MFC after:1 week Sponsored by: DARPA Modified: head/share/man/man9/fetch.9 Modified: head/share/man/man9/fetch.9

svn commit: r356996 - head

2020-01-22 Thread John Baldwin
Author: jhb Date: Wed Jan 22 21:21:24 2020 New Revision: 356996 URL: https://svnweb.freebsd.org/changeset/base/356996 Log: Remove support for auto-selecting an external binutils. All of the in-tree architectures not supported by in-tree binutils are supported by lld, so the condition is

svn commit: r356911 - stable/12/sys/opencrypto

2020-01-20 Thread John Baldwin
Author: jhb Date: Mon Jan 20 11:54:00 2020 New Revision: 356911 URL: https://svnweb.freebsd.org/changeset/base/356911 Log: MFC 356561: Add stricter checking on mac key lengths. Negative lengths are always invalid. The key length should also be zero for hash algorithms that do not accept

svn commit: r356908 - in stable: 11/sys/opencrypto 12/sys/opencrypto

2020-01-20 Thread John Baldwin
Author: jhb Date: Mon Jan 20 11:19:55 2020 New Revision: 356908 URL: https://svnweb.freebsd.org/changeset/base/356908 Log: MFC 356507,356520: Add a reference count to cryptodev sessions. 356507: Add a reference count to cryptodev sessions. This prevents use-after-free races with

svn commit: r356908 - in stable: 11/sys/opencrypto 12/sys/opencrypto

2020-01-20 Thread John Baldwin
Author: jhb Date: Mon Jan 20 11:19:55 2020 New Revision: 356908 URL: https://svnweb.freebsd.org/changeset/base/356908 Log: MFC 356507,356520: Add a reference count to cryptodev sessions. 356507: Add a reference count to cryptodev sessions. This prevents use-after-free races with

svn commit: r356875 - stable/11/share/man/man7

2020-01-18 Thread John Baldwin
Author: jhb Date: Sat Jan 18 23:46:50 2020 New Revision: 356875 URL: https://svnweb.freebsd.org/changeset/base/356875 Log: MFC 356274: Some minor tweaks to arch(7). - Drop mention of _LP64. FreeBSD's source generally uses __LP64__ instead of _LP64, and the relevant macros are better

svn commit: r356874 - stable/12/share/man/man7

2020-01-18 Thread John Baldwin
Author: jhb Date: Sat Jan 18 23:46:30 2020 New Revision: 356874 URL: https://svnweb.freebsd.org/changeset/base/356874 Log: MFC 356274: Some minor tweaks to arch(7). - Drop mention of _LP64. FreeBSD's source generally uses __LP64__ instead of _LP64, and the relevant macros are better

svn commit: r356872 - stable/12/share/man/man7

2020-01-18 Thread John Baldwin
Author: jhb Date: Sat Jan 18 23:42:57 2020 New Revision: 356872 URL: https://svnweb.freebsd.org/changeset/base/356872 Log: MFC 356209: Formatting fixes for tables, no content changes. - Add missing .Pp after the end of some lists so that there is a blank line before the subsequent

svn commit: r356873 - stable/11/share/man/man7

2020-01-18 Thread John Baldwin
Author: jhb Date: Sat Jan 18 23:43:36 2020 New Revision: 356873 URL: https://svnweb.freebsd.org/changeset/base/356873 Log: MFC 356209: Formatting fixes for tables, no content changes. - Add missing .Pp after the end of some lists so that there is a blank line before the subsequent

svn commit: r356871 - in stable/12/share/man: man4 man9

2020-01-18 Thread John Baldwin
Author: jhb Date: Sat Jan 18 23:30:42 2020 New Revision: 356871 URL: https://svnweb.freebsd.org/changeset/base/356871 Log: MFC 355866,355871: Update the crypto(4) and crypto(9) manpages. 355866: Update the crypto(4) and crypto(9) manpages. There are probably bits that are still

svn commit: r356870 - stable/12/usr.sbin/bhyve

2020-01-18 Thread John Baldwin
Author: jhb Date: Sat Jan 18 23:26:15 2020 New Revision: 356870 URL: https://svnweb.freebsd.org/changeset/base/356870 Log: MFC 355634: Emulate reads of the PCI command register for passthrough devices. VFs return zero for the memory enable bit even if it has been set by a prior write.

svn commit: r356851 - stable/12

2020-01-17 Thread John Baldwin
Author: jhb Date: Fri Jan 17 22:02:35 2020 New Revision: 356851 URL: https://svnweb.freebsd.org/changeset/base/356851 Log: MFC 353932: Strip "sf" suffix when generating a target triple. This fixes the target triple used when compiling riscv64sf with clang. Sponsored by: DARPA

svn commit: r356850 - stable/12/sys/riscv/include

2020-01-17 Thread John Baldwin
Author: jhb Date: Fri Jan 17 21:57:05 2020 New Revision: 356850 URL: https://svnweb.freebsd.org/changeset/base/356850 Log: MFC 353931: Fix atomic_*cmpset32 on riscv64 with clang. The lr.w instruction used to read the value from memory sign-extends the value read from memory. GCC

svn commit: r356840 - head/sys/riscv/riscv

2020-01-17 Thread John Baldwin
Author: jhb Date: Fri Jan 17 19:13:49 2020 New Revision: 356840 URL: https://svnweb.freebsd.org/changeset/base/356840 Log: Check for invalid sstatus values in set_mcontext(). Previously, this check was only in sys_sigreturn() which meant that user applications could write invalid values

svn commit: r356839 - in head/sys: arm64/arm64 riscv/riscv

2020-01-17 Thread John Baldwin
Author: jhb Date: Fri Jan 17 19:01:59 2020 New Revision: 356839 URL: https://svnweb.freebsd.org/changeset/base/356839 Log: Save and restore floating point registers in get/set_mcontext(). arm64 and riscv were only saving and restoring floating point registers for sendsig() and

Re: svn commit: r356831 - head/sys/powerpc/include

2020-01-17 Thread John Baldwin
s the comment said. Thanks, this was the source of the kgdb bug I think. :) -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r356797 - head/share/mk

2020-01-16 Thread John Baldwin
hink the mcount bits for MIPS only work for o32 and are completely broken for n64). Do we know if any other systems still ship -pg libraries as an option? Also, is anyone still using them? -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lis

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-16 Thread John Baldwin
epoch_call(9) - first function, then its argument. NFC > J> > J> Is there some practical impact of changing the argument order or does it > J> just seem more natural to you? > > It is just more natural. I'm suggesting to change prototype of epoch_call() > to the same order

svn commit: r356737 - head/sys/mips/mips

2020-01-14 Thread John Baldwin
Author: jhb Date: Tue Jan 14 18:00:04 2020 New Revision: 356737 URL: https://svnweb.freebsd.org/changeset/base/356737 Log: Preserve the inherited value of the status register in cpu_set_upcall(). Instead of re-deriving the value of SR using logic similar to exec_set_regs(), just inherit

svn commit: r356561 - head/sys/opencrypto

2020-01-09 Thread John Baldwin
Author: jhb Date: Thu Jan 9 18:29:59 2020 New Revision: 356561 URL: https://svnweb.freebsd.org/changeset/base/356561 Log: Add stricter checking on mac key lengths. Negative lengths are always invalid. The key length should also be zero for hash algorithms that do not accept a key.

svn commit: r356520 - head/sys/opencrypto

2020-01-08 Thread John Baldwin
Author: jhb Date: Wed Jan 8 22:16:26 2020 New Revision: 356520 URL: https://svnweb.freebsd.org/changeset/base/356520 Log: Remove no-longer-used function prototype. Reported by: amd64-gcc Modified: head/sys/opencrypto/cryptodev.c Modified: head/sys/opencrypto/cryptodev.c

svn commit: r356509 - head/sys/opencrypto

2020-01-08 Thread John Baldwin
Author: jhb Date: Wed Jan 8 19:05:23 2020 New Revision: 356509 URL: https://svnweb.freebsd.org/changeset/base/356509 Log: Remove unneeded cdevsw methods and D_NEEDGIANT. Reviewed by: kib MFC after:2 weeks Sponsored by: Chelsio Communications Differential Revision:

svn commit: r356508 - head/sys/opencrypto

2020-01-08 Thread John Baldwin
Author: jhb Date: Wed Jan 8 19:03:24 2020 New Revision: 356508 URL: https://svnweb.freebsd.org/changeset/base/356508 Log: Use falloc_noinstall + finstall for crypto file descriptors. Reviewed by: cem, kib MFC after:1 week Sponsored by: Chelsio Communications Differential

svn commit: r356507 - head/sys/opencrypto

2020-01-08 Thread John Baldwin
Author: jhb Date: Wed Jan 8 18:59:23 2020 New Revision: 356507 URL: https://svnweb.freebsd.org/changeset/base/356507 Log: Add a reference count to cryptodev sessions. This prevents use-after-free races with crypto requests (which may sleep) and CIOCFSESSION as well as races from current

svn commit: r356504 - head/share/mk

2020-01-08 Thread John Baldwin
Author: jhb Date: Wed Jan 8 17:49:34 2020 New Revision: 356504 URL: https://svnweb.freebsd.org/changeset/base/356504 Log: Add -mno-relax to CFLAGS in bsd.prog/lib.mk instead of bsd.cpu.mk. bsd.cpu.mk is included by bsd.init.mk before bsd.linker.mk, so it was always setting the flag

svn commit: r356502 - head

2020-01-08 Thread John Baldwin
Author: jhb Date: Wed Jan 8 17:31:54 2020 New Revision: 356502 URL: https://svnweb.freebsd.org/changeset/base/356502 Log: Add notes for MAKE_OBSOLETE_GCC going away and riscv switching to clang/lld. Modified: head/UPDATING Modified: head/UPDATING

svn commit: r356501 - head/share/man/man7

2020-01-08 Thread John Baldwin
Author: jhb Date: Wed Jan 8 17:31:18 2020 New Revision: 356501 URL: https://svnweb.freebsd.org/changeset/base/356501 Log: Remove a mention of MAKE_OBSOLETE_GCC. This should have been included in r356452. Modified: head/share/man/man7/arch.7 Modified: head/share/man/man7/arch.7

svn commit: r356499 - in head: . share/man/man7 share/mk

2020-01-08 Thread John Baldwin
Author: jhb Date: Wed Jan 8 17:25:59 2020 New Revision: 356499 URL: https://svnweb.freebsd.org/changeset/base/356499 Log: Use clang and lld as the default toolchain for RISCV. - Enable clang and lld as system toolchains. - Don't use external GCC for universe by default. - Re-enable

svn commit: r356481 - in head/sys: conf riscv/riscv

2020-01-07 Thread John Baldwin
Author: jhb Date: Tue Jan 7 23:18:31 2020 New Revision: 356481 URL: https://svnweb.freebsd.org/changeset/base/356481 Log: Work around lld's inability to handle undefined weak symbols on risc-v. lld on RISC-V is not yet able to handle undefined weak symbols for non-PIC code in the code

svn commit: r356478 - head

2020-01-07 Thread John Baldwin
Author: jhb Date: Tue Jan 7 21:56:28 2020 New Revision: 356478 URL: https://svnweb.freebsd.org/changeset/base/356478 Log: Don't fail universe kernel stage for TARGET_ARCHes without a kernel config. This fixes a regression in r356418 where the entire universe would fail early due to an

svn commit: r356457 - head/tools/tools/crypto

2020-01-07 Thread John Baldwin
Author: jhb Date: Tue Jan 7 17:07:58 2020 New Revision: 356457 URL: https://svnweb.freebsd.org/changeset/base/356457 Log: Various cleanups to cryptocheck. - Rename 'blkcipher' to 'cipher'. Some of the ciphers being tested are stream ciphers. - Rename 'authenc' to 'eta' as it is

svn commit: r356452 - head

2020-01-07 Thread John Baldwin
Author: jhb Date: Tue Jan 7 16:53:51 2020 New Revision: 356452 URL: https://svnweb.freebsd.org/changeset/base/356452 Log: Remove support for using GCC 4.2.1 from make tinderbox. Reviewed by: emaste Differential Revision:https://reviews.freebsd.org/D23054 Modified:

svn commit: r356420 - head/sys/mips/mips

2020-01-06 Thread John Baldwin
Author: jhb Date: Mon Jan 6 18:02:02 2020 New Revision: 356420 URL: https://svnweb.freebsd.org/changeset/base/356420 Log: Simplify arguments to signal handlers on mips. - Use ksi_addr directly as si_addr in the siginfo instead of the 'badvaddr' register. - Remove a duplicate

svn commit: r356419 - head

2020-01-06 Thread John Baldwin
Author: jhb Date: Mon Jan 6 17:36:28 2020 New Revision: 356419 URL: https://svnweb.freebsd.org/changeset/base/356419 Log: Enable powerpc in make tinderbox using clang instead of GCC. powerpcspe is disabled for now until clang/llvm issues with spe have been fixed. Reviewed by: imp

svn commit: r356418 - head

2020-01-06 Thread John Baldwin
Author: jhb Date: Mon Jan 6 17:34:17 2020 New Revision: 356418 URL: https://svnweb.freebsd.org/changeset/base/356418 Log: Only build kernels for enabled TARGET_ARCHes in make universe/tinderbox. Previously, all of the kernels for a given TARGET were built if that target was enabled.

<    1   2   3   4   5   6   7   8   9   10   >