[label=Matthew N. Dodd\nmd...@freebsd.org\n1999/07/27]
melifaro [label=Alexander V. Chernikov\nmelif...@freebsd.org\n2011/10/04]
mjacob [label=Matt Jacob\nmja...@freebsd.org\n1997/08/13]
+mjg [label=Mateusz Guzik\n...@freebsd.org\n2012/06/04]
mlaier [label=Max Laier\nmla...@freebsd.org\n2004/02/10
Author: mjg
Date: Fri Jun 8 08:04:51 2012
New Revision: 236738
URL: http://svn.freebsd.org/changeset/base/236738
Log:
Plug socket refcount leak on error in sys_sctp_peeloff.
Reviewed by: tuexen
Approved by: trasz (mentor)
MFC after:3 days
Modified:
Author: mjg
Date: Mon Jun 11 17:42:39 2012
New Revision: 236899
URL: http://svn.freebsd.org/changeset/base/236899
Log:
Fix unloading of libiconv module.
Previously it would either loop infinitely or exit with error leaking a lock.
Reported by: Will DeVries
Approved by: trasz
Author: mjg
Date: Mon Jun 11 17:54:40 2012
New Revision: 236900
URL: http://svn.freebsd.org/changeset/base/236900
Log:
MFC r236738:
Plug socket refcount leak on error in sys_sctp_peeloff.
Modified:
stable/9/sys/kern/uipc_syscalls.c
Directory Properties:
stable/9/sys/ (props
Author: mjg
Date: Mon Jun 11 18:10:12 2012
New Revision: 236903
URL: http://svn.freebsd.org/changeset/base/236903
Log:
MFC r236738:
Plug socket refcount leak on error in sys_sctp_peeloff.
Modified:
stable/8/sys/kern/uipc_syscalls.c
Directory Properties:
stable/8/sys/ (props
for new fd with high number.
This fixed the problem for me, although I'm not sure whether it's ok to
grow the table like this:
http://people.freebsd.org/~mjg/patches/fdalloc.patch
--
Mateusz Guzik mjguzik gmail.com
___
svn-src-all@freebsd.org mailing list
On Tue, Jun 12, 2012 at 01:43:35PM +0200, Pawel Jakub Dawidek wrote:
On Tue, Jun 12, 2012 at 12:47:49PM +0200, Mateusz Guzik wrote:
The problem is that fdalloc grows to at most fdp-fd_nfiles * 2, which
still may not be enough to have place for new fd with high number.
I was under
On Tue, Jun 12, 2012 at 06:01:29PM +0200, Pawel Jakub Dawidek wrote:
On Tue, Jun 12, 2012 at 03:49:50PM +0200, Mateusz Guzik wrote:
On Tue, Jun 12, 2012 at 01:43:35PM +0200, Pawel Jakub Dawidek wrote:
On Tue, Jun 12, 2012 at 12:47:49PM +0200, Mateusz Guzik wrote:
The problem
On Tue, Jun 12, 2012 at 11:44:00PM +0200, Pawel Jakub Dawidek wrote:
On Tue, Jun 12, 2012 at 09:18:28PM +0200, Mateusz Guzik wrote:
On Tue, Jun 12, 2012 at 06:01:29PM +0200, Pawel Jakub Dawidek wrote:
Look good and you can just add 'In co-operation with: pjd'.
One minor thing
On Wed, Jun 13, 2012 at 12:29:01PM +0200, Pawel Jakub Dawidek wrote:
On Wed, Jun 13, 2012 at 11:38:07AM +0200, Mateusz Guzik wrote:
On Tue, Jun 12, 2012 at 11:44:00PM +0200, Pawel Jakub Dawidek wrote:
On Tue, Jun 12, 2012 at 09:18:28PM +0200, Mateusz Guzik wrote:
On Tue, Jun 12, 2012
On Wed, Jun 13, 2012 at 01:13:09PM +0200, Pawel Jakub Dawidek wrote:
On Wed, Jun 13, 2012 at 12:53:44PM +0200, Mateusz Guzik wrote:
http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free5.patch
David reported that previous version of the patch fixed panic he was
experiencing, so
Author: mjg
Date: Wed Jun 13 17:12:53 2012
New Revision: 237012
URL: http://svn.freebsd.org/changeset/base/237012
Log:
Re-apply reverted parts of r236935 by pjd with some changes.
If fdalloc() decides to grow fdtable it does it once and at most doubles
the size. This still may be not
Author: mjg
Date: Wed Jun 13 17:18:16 2012
New Revision: 237013
URL: http://svn.freebsd.org/changeset/base/237013
Log:
Remove 'low' argument from fd_last_used().
This function is static and the only caller always passes 0 as low.
While here update note about return values in comment.
Author: mjg
Date: Tue Oct 30 19:46:00 2012
New Revision: 242372
URL: http://svn.freebsd.org/changeset/base/242372
Log:
atrun(8): scale default load average limit with the number of CPUs
Previously atrun refused to run jobs if load average was not below fixed
limit of 1.5.
PR:
Author: mjg
Date: Tue Nov 6 23:04:23 2012
New Revision: 242680
URL: http://svnweb.freebsd.org/changeset/base/242680
Log:
Fix possible spurious sbunlock in sctp_sorecvmsg.
Reviewed by: tuexen
Approved by: trasz (mentor)
MFC after:3 days
Modified:
head/sys/netinet/sctputil.c
Author: mjg
Date: Fri Nov 9 19:31:31 2012
New Revision: 242836
URL: http://svnweb.freebsd.org/changeset/base/242836
Log:
MFC r242680:
Fix possible spurious sbunlock in sctp_sorecvmsg.
Approved by: trasz (mentor)
Modified:
stable/9/sys/netinet/sctputil.c
Directory Properties:
Author: mjg
Date: Fri Nov 9 19:45:17 2012
New Revision: 242839
URL: http://svnweb.freebsd.org/changeset/base/242839
Log:
MFC r242680:
Fix possible spurious sbunlock in sctp_sorecvmsg.
Approved by: trasz (mentor)
Modified:
stable/8/sys/netinet/sctputil.c
Directory Properties:
/stable9-pipe2-full.diff
--
Mateusz Guzik mjguzik gmail.com
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Author: mjg
Date: Tue Nov 13 19:17:21 2012
New Revision: 242990
URL: http://svnweb.freebsd.org/changeset/base/242990
Log:
MFC r242372:
atrun(8): scale default load average limit with the number of CPUs
Previously atrun refused to run jobs if load average was not below fixed
limit of
Author: mjg
Date: Tue Nov 13 19:20:57 2012
New Revision: 242991
URL: http://svnweb.freebsd.org/changeset/base/242991
Log:
MFC r242372:
atrun(8): scale default load average limit with the number of CPUs
Previously atrun refused to run jobs if load average was not below fixed
limit of
Author: mjg
Date: Tue Nov 13 22:01:25 2012
New Revision: 243007
URL: http://svnweb.freebsd.org/changeset/base/243007
Log:
enterpgrp: get rid of pgrp2 variable and use KASSERT directly on pgfind
result.
pgrp2 was used only for debugging, but pgrp2 = pgfind(..) was present in
compiled code
Author: mjg
Date: Sun Nov 18 15:48:34 2012
New Revision: 243234
URL: http://svnweb.freebsd.org/changeset/base/243234
Log:
Fix possible fp reference leak in posix_openpt
Reviewed by: ed
Approved by: trasz (mentor)
MFC after:3 days
Modified:
head/sys/kern/tty_pts.c
Modified:
Author: mjg
Date: Tue Nov 27 01:28:35 2012
New Revision: 243582
URL: http://svnweb.freebsd.org/changeset/base/243582
Log:
MFC r243007:
enterpgrp: get rid of pgrp2 variable and use KASSERT directly on pgfind
result.
pgrp2 was used only for debugging, but pgrp2 = pgfind(..) was present in
Author: mjg
Date: Tue Nov 27 01:30:12 2012
New Revision: 243583
URL: http://svnweb.freebsd.org/changeset/base/243583
Log:
MFC r243007:
enterpgrp: get rid of pgrp2 variable and use KASSERT directly on pgfind
result.
pgrp2 was used only for debugging, but pgrp2 = pgfind(..) was present in
Author: mjg
Date: Tue Nov 27 01:33:23 2012
New Revision: 243584
URL: http://svnweb.freebsd.org/changeset/base/243584
Log:
MFC r243234:
Fix possible fp reference leak in posix_openpt
Modified:
stable/9/sys/kern/tty_pts.c
Directory Properties:
stable/9/sys/ (props changed)
Modified:
Author: mjg
Date: Tue Nov 27 01:35:29 2012
New Revision: 243585
URL: http://svnweb.freebsd.org/changeset/base/243585
Log:
MFC r243234:
Fix possible fp reference leak in posix_openpt
Modified:
stable/8/sys/kern/tty_pts.c
Directory Properties:
stable/8/sys/ (props changed)
;
nfsrv_pool-sp_maxthreads = 4;
}
[..]
--
Mateusz Guzik mjguzik gmail.com
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
On Wed, Nov 28, 2012 at 07:14:23PM -0500, Rick Macklem wrote:
Mateusz Guzik wrote:
On Wed, Nov 28, 2012 at 02:47:32AM +, Alfred Perlstein wrote:
Author: alfred
Date: Wed Nov 28 02:47:31 2012
New Revision: 243645
URL: http://svnweb.freebsd.org/changeset/base/243645
Log
cursory look
I'm not sure if it is ok to just exit.
--
Mateusz Guzik mjguzik gmail.com
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
, off_t
size, off_t of
gettimeofday(xs-start, NULL);
xs-last.tv_sec = xs-last.tv_usec = 0;
xs-size = size;
- xs-offset = offset;
+ xs-offset = 0;
xs-rcvd = offset;
xs-lastrcvd = offset;
if (v_tty v_level 0)
--
Mateusz Guzik mjguzik
On Sun, Dec 09, 2012 at 07:42:02PM +0100, Florian Smeets wrote:
On 09.12.12 19:27, Mateusz Guzik wrote:
On Sun, Dec 09, 2012 at 07:06:22PM +0100, Florian Smeets wrote:
On 16.11.12 13:05, Andre Oppermann wrote:
Author: andre
Date: Fri Nov 16 12:05:10 2012
New Revision: 243147
URL: http
Author: mjg
Date: Thu Jun 27 02:27:13 2013
New Revision: 252288
URL: http://svnweb.freebsd.org/changeset/base/252288
Log:
MFC r249480:
Add fdallocn function and use it when passing fds over unix socket.
This gets rid of unp_externalize fdalloc failed panic.
Modified:
these are safe. But for example DTYPE_SOCKET goes with
fp-f_data, which can go away in the meantime (or I'm misreading the code).
I suggest obtainng ref to fp and passing it down in all cases.
--
Mateusz Guzik mjguzik gmail.com
___
svn-src-all@freebsd.org
Author: mjg
Date: Fri Jun 28 18:32:46 2013
New Revision: 252351
URL: http://svnweb.freebsd.org/changeset/base/252351
Log:
Remove duplicate NULL check in kern_proc_filedesc_out.
No functional changes.
MFC after:1 week
Modified:
head/sys/kern/kern_descrip.c
Modified:
Author: mjg
Date: Sun Jun 30 13:14:46 2013
New Revision: 252414
URL: http://svnweb.freebsd.org/changeset/base/252414
Log:
truss: recognize O_DIRECTORY, O_EXEC, O_TTY_INIT and O_CLOEXEC
MFC after:3 days
Modified:
head/usr.bin/truss/syscalls.c
Modified: head/usr.bin/truss/syscalls.c
Author: mjg
Date: Sun Jun 30 13:17:37 2013
New Revision: 252415
URL: http://svnweb.freebsd.org/changeset/base/252415
Log:
acct: reduce code duplication by using acct_disable as cleanup for
failed kproc_create
MFC after:1 week
Modified:
head/sys/kern/kern_acct.c
Modified:
Author: mjg
Date: Sun Jun 30 19:08:06 2013
New Revision: 252422
URL: http://svnweb.freebsd.org/changeset/base/252422
Log:
acct: create a special plimit object and set it for exiting processes
instead of allocating new one each time
All limits are set to RLIM_INFINITY which sould be ok
Author: mjg
Date: Tue Jul 2 07:36:04 2013
New Revision: 252502
URL: http://svnweb.freebsd.org/changeset/base/252502
Log:
Fix receiving fd over unix socket broken in r247740.
If n fds were passed, it would receive the first one n times.
Reported by: Shawn Webb latt...@gmail.com,
Author: mjg
Date: Wed Jul 3 20:24:37 2013
New Revision: 252595
URL: http://svnweb.freebsd.org/changeset/base/252595
Log:
MFC r252414:
truss: recognize O_DIRECTORY, O_EXEC, O_TTY_INIT and O_CLOEXEC
Modified:
stable/9/usr.bin/truss/syscalls.c
Directory Properties:
stable/9/usr.bin/truss/
Author: mjg
Date: Sun Apr 14 17:08:34 2013
New Revision: 249480
URL: http://svnweb.freebsd.org/changeset/base/249480
Log:
Add fdallocn function and use it when passing fds over unix socket.
This gets rid of unp_externalize fdalloc failed panic.
Reviewed by: pjd
MFC after:1 week
, 0666)) == -1) {
if (errno == EAGAIN || errno == EINTR)
return (-1);
err(EX_CANTCREAT, cannot open %s, name);
EX_UNAVAILABLE is never returned.
--
Mateusz Guzik mjguzik gmail.com
___
svn-src-all
Author: mjg
Date: Tue May 21 21:58:00 2013
New Revision: 250890
URL: http://svnweb.freebsd.org/changeset/base/250890
Log:
passing fd over unix socket: fix a corner case where caller
wants to pass no descriptors.
Previously the kernel would leak memory and try to free a potentially
On Wed, May 22, 2013 at 01:21:48PM +0400, Gleb Smirnoff wrote:
On Tue, May 21, 2013 at 09:58:01PM +, Mateusz Guzik wrote:
M Author: mjg
M Date: Tue May 21 21:58:00 2013
M New Revision: 250890
M URL: http://svnweb.freebsd.org/changeset/base/250890
M
M Log:
M passing fd over unix
Author: mjg
Date: Sun Jul 8 00:51:38 2012
New Revision: 238220
URL: http://svn.freebsd.org/changeset/base/238220
Log:
Unbreak handling of descriptors opened with O_EXEC by fexecve(2).
While here return EBADF for descriptors opened for writing (previously it was
ETXTBSY).
Add
Author: mjg
Date: Mon Jul 9 05:39:31 2012
New Revision: 238272
URL: http://svn.freebsd.org/changeset/base/238272
Log:
Follow-up commit to r238220:
Pass only FEXEC (instead of FREAD|FEXEC) in fgetvp_exec. _fget has to check
for
!FWRITE anyway and may as well know about FREAD.
Make
= vp;
np-n_mount = VFSTOSMBFS(mp);
How about moving this malloc right before np is actually used?
While here some style(9) fixes.
http://people.freebsd.org/~mjg/patches/smbfs_node-malloc.patch
Completely untested (even compile-time); I guess the idea is clear. :)
--
Mateusz Guzik mjguzik
On Sun, Jul 15, 2012 at 06:23:50PM +0200, Christian Brueffer wrote:
On 7/15/12 18:04 , Mateusz Guzik wrote:
On Sun, Jul 15, 2012 at 03:50:12PM +, Christian Brueffer wrote:
Author: brueffer
Date: Sun Jul 15 15:50:12 2012
New Revision: 238491
URL: http://svn.freebsd.org/changeset/base
Author: mjg
Date: Wed Jul 18 04:52:37 2012
New Revision: 238560
URL: http://svn.freebsd.org/changeset/base/238560
Log:
MFC r238220, r238272:
Unbreak handling of descriptors opened with O_EXEC by fexecve(2).
While here return EBADF for descriptors opened for writing (previously it was
Author: mjg
Date: Fri Aug 17 17:45:27 2012
New Revision: 239359
URL: http://svn.freebsd.org/changeset/base/239359
Log:
Remove unused member of struct indir (in_exists) from UFS and EXT2 code.
Reviewed by: mckusick
Approved by: trasz (mentor)
MFC after:1 week
Modified:
Author: mjg
Date: Tue Dec 18 18:34:36 2012
New Revision: 244404
URL: http://svnweb.freebsd.org/changeset/base/244404
Log:
prison_racct_detach can be called for not fully initialized jail, so make it
check that the jail has racct before doing anything
PR: kern/174436
Reviewed
Author: mjg
Date: Fri Dec 21 21:40:51 2012
New Revision: 244566
URL: http://svnweb.freebsd.org/changeset/base/244566
Log:
MFC r244404:
prison_racct_detach can be called for not fully initialized jail, so make
it check that the jail has racct before doing anything
PR:
being leaked.
I think it would be better to teach strlcpy to zero-pad as well.
--
Mateusz Guzik mjguzik gmail.com
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src
Author: mjg
Date: Sun Jan 6 21:47:59 2013
New Revision: 245113
URL: http://svnweb.freebsd.org/changeset/base/245113
Log:
lockmgr: unlock interlock (if requested) when dealing with upgrade/downgrade
requests for LK_NOSHARE locks, just like for shared locks.
PR: kern/174969
Author: mjg
Date: Sun Jan 6 21:56:58 2013
New Revision: 245114
URL: http://svnweb.freebsd.org/changeset/base/245114
Log:
pw: free group returned by gr_add
Modified:
head/usr.sbin/pw/pw_user.c
Modified: head/usr.sbin/pw/pw_user.c
Author: mjg
Date: Sat Jan 12 22:20:37 2013
New Revision: 245345
URL: http://svnweb.freebsd.org/changeset/base/245345
Log:
procstat: only one mode flag can be specified, but required check for 'i'
and 'j' modes was missing. Fix that.
MFC after:3 days
Modified:
Author: mjg
Date: Sun Jan 13 00:32:07 2013
New Revision: 245351
URL: http://svnweb.freebsd.org/changeset/base/245351
Log:
MFC r245113:
lockmgr: unlock interlock (if requested) when dealing with upgrade/downgrade
requests for LK_NOSHARE locks, just like for shared locks.
PR:
Author: mjg
Date: Sun Jan 13 21:25:43 2013
New Revision: 245385
URL: http://svnweb.freebsd.org/changeset/base/245385
Log:
libutil: eliminate 'found' variable in gr_equal
Submitted by: Christoph Mallon christoph.mallon gmx.de
Modified:
head/lib/libutil/gr_util.c
Modified:
Author: mjg
Date: Sun Jan 13 21:26:57 2013
New Revision: 245386
URL: http://svnweb.freebsd.org/changeset/base/245386
Log:
libutil: move group_line_format into the scop of its only user.
Submitted by: Christoph Mallon christoph.mallon gmx.de
Modified:
head/lib/libutil/gr_util.c
Author: mjg
Date: Sun Jan 13 21:28:47 2013
New Revision: 245387
URL: http://svnweb.freebsd.org/changeset/base/245387
Log:
libutil: utilize strsep instead of strcat in a loop in gr_make
Submitted by: Christoph Mallon christoph.mallon gmx.de
Modified:
head/lib/libutil/gr_util.c
Modified:
Author: mjg
Date: Sun Jan 13 22:08:18 2013
New Revision: 245390
URL: http://svnweb.freebsd.org/changeset/base/245390
Log:
libutil: fix typo in comment for gr_fini.
Submitted by: Christoph Mallon christoph.mallon gmx.de
Modified:
head/lib/libutil/gr_util.c
Modified:
Author: mjg
Date: Thu Jan 17 02:42:08 2013
New Revision: 245530
URL: http://svnweb.freebsd.org/changeset/base/245530
Log:
MFC r245345:
procstat: only one mode flag can be specified, but required check for 'i'
and 'j' modes was missing. Fix that.
Modified:
Author: mjg
Date: Sun Jan 27 03:14:54 2013
New Revision: 245956
URL: http://svnweb.freebsd.org/changeset/base/245956
Log:
truss: if file requested with -o flag could not be opened print the reason
MFC after:3 days
Modified:
head/usr.bin/truss/main.c
Modified:
Author: mjg
Date: Sun Jan 27 03:17:35 2013
New Revision: 245957
URL: http://svnweb.freebsd.org/changeset/base/245957
Log:
truss: use 'e' flag for fopen instead of fcntl(.., FD_CLOEXEC)
Modified:
head/usr.bin/truss/main.c
Modified: head/usr.bin/truss/main.c
Author: mjg
Date: Thu Jan 31 01:15:12 2013
New Revision: 246142
URL: http://svnweb.freebsd.org/changeset/base/246142
Log:
MFC r245956:
truss: if file requested with -o flag could not be opened print the reason
Modified:
stable/9/usr.bin/truss/main.c
Directory Properties:
Author: mjg
Date: Thu Jul 10 20:59:54 2014
New Revision: 268505
URL: http://svnweb.freebsd.org/changeset/base/268505
Log:
Avoid relocking filedesc lock when closing fds during fdp destruction.
Don't call bzero nor fdunused from fdfree for such cases. It would do
unnecessary work and
Author: mjg
Date: Thu Jul 10 21:05:45 2014
New Revision: 268507
URL: http://svnweb.freebsd.org/changeset/base/268507
Log:
Don't zero fd_nfiles during fdp destruction.
Code trying to take a look has to check fd_refcnt and it is 0 by that time.
This is a follow up to r268505, without
Author: mjg
Date: Thu Jul 10 21:46:57 2014
New Revision: 268509
URL: http://svnweb.freebsd.org/changeset/base/268509
Log:
Don't make a temporary copy of fixed sysctl strings.
Modified:
head/sys/kern/kern_sysctl.c
Modified: head/sys/kern/kern_sysctl.c
Author: mjg
Date: Thu Jul 10 22:54:38 2014
New Revision: 268514
URL: http://svnweb.freebsd.org/changeset/base/268514
Log:
Eliminate plim and vtmp local vars in exit1.
No functional changes.
MFC after:1 week
Modified:
head/sys/kern/kern_exit.c
Modified:
On Mon, Jun 23, 2014 at 07:35:23PM +0300, Konstantin Belousov wrote:
On Mon, Jun 23, 2014 at 03:16:53PM +0200, Mateusz Guzik wrote:
If traversal while transition to P_INEXEC is allowed, execve dealing
with a setuid binary is problematic. This is more of hypothetical nature
On Fri, Jul 11, 2014 at 12:55:51PM +0300, Konstantin Belousov wrote:
On Fri, Jul 11, 2014 at 04:43:51AM +0200, Mateusz Guzik wrote:
In both cases the same mechanism blocks both exec and exit, this can be
split if needed (p_lock would still cover exit, p_something would cover
exec
Author: mjg
Date: Sat Jul 12 15:35:04 2014
New Revision: 268570
URL: http://svnweb.freebsd.org/changeset/base/268570
Log:
Clear nonblock and async on devctl close instaed of open.
This is a purely cosmetic change.
Modified:
head/sys/kern/subr_bus.c
Modified: head/sys/kern/subr_bus.c
On Sat, Jul 12, 2014 at 07:18:01PM +0300, Konstantin Belousov wrote:
On Sat, Jul 12, 2014 at 03:35:04PM +, Mateusz Guzik wrote:
Author: mjg
Date: Sat Jul 12 15:35:04 2014
New Revision: 268570
URL: http://svnweb.freebsd.org/changeset/base/268570
Log:
Clear nonblock and async
On Sat, Jul 12, 2014 at 08:10:15PM +0300, Konstantin Belousov wrote:
On Sat, Jul 12, 2014 at 06:53:47PM +0200, Mateusz Guzik wrote:
There can be only one 'struct file' for devctl and devclose is only
called when it is about to be destroyed.
fd = open(/dev/devctl);
close(dup(fd
On Sun, Jul 13, 2014 at 04:26:52PM +0300, Konstantin Belousov wrote:
On Fri, Jul 11, 2014 at 01:19:25PM +0200, Mateusz Guzik wrote:
On Fri, Jul 11, 2014 at 12:55:51PM +0300, Konstantin Belousov wrote:
The nolock version requires two atomics on both entry and leave from the
protected
Author: mjg
Date: Mon Jul 14 21:12:59 2014
New Revision: 268634
URL: http://svnweb.freebsd.org/changeset/base/268634
Log:
Manage struct sigacts refcnt with atomics instead of a mutex.
MFC after:1 week
Modified:
head/sys/kern/kern_sig.c
head/sys/sys/signalvar.h
Modified:
Author: mjg
Date: Mon Jul 14 22:40:46 2014
New Revision: 268636
URL: http://svnweb.freebsd.org/changeset/base/268636
Log:
Plug p_pptr null test in do_execve. It is always true.
Modified:
head/sys/kern/kern_exec.c
Modified: head/sys/kern/kern_exec.c
for them.
Either, the change as it is looks wrong. Please revert for the time being.
--
Mateusz Guzik mjguzik gmail.com
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src
On Tue, Jul 15, 2014 at 07:48:46PM -0700, dte...@freebsd.org wrote:
-Original Message-
From: owner-src-committ...@freebsd.org [mailto:owner-src-
committ...@freebsd.org] On Behalf Of Mateusz Guzik
Sent: Tuesday, July 15, 2014 12:16 PM
Indeed, the whole point is to NOT inherit
.
+ exit(EX_USAGE);
+}
+
+ switch(signo) {
+ case 0:
sig 0? I doubt it is ever delivered.
+ if (timedout !preserve)
+ pstat = EXIT_TIMEOUT;
+
Bad indentation.
+ return (pstat);
+}
--
Mateusz Guzik mjguzik gmail.com
On Wed, Jul 16, 2014 at 12:34:11PM +0200, Baptiste Daroussin wrote:
On Wed, Jul 16, 2014 at 12:29:08PM +0200, Mateusz Guzik wrote:
On Wed, Jul 16, 2014 at 09:55:36AM +, Baptiste Daroussin wrote:
+static void
+usage(void)
+{
+ fprintf(stderr, Usage: %s [--signal sig | -s sig
=/ PATH=/sbin:/bin:/usr/sbin:/usr/bin
TERM=$TERM $dir/$script $*
+ exec env -i HOME=/ PATH=/sbin:/bin:/usr/sbin:/usr/bin
$dir/$script $*
fi
done
Thank you.
--
Mateusz Guzik mjguzik gmail.com
___
svn-src-all@freebsd.org
Author: mjg
Date: Wed Jul 23 18:04:52 2014
New Revision: 269020
URL: http://svnweb.freebsd.org/changeset/base/269020
Log:
Cosmetic changes to unp_internalize
Don't throw away the result of fget_unlocked.
Move fdp increment to for loop to make it consistent with similar code
elsewhere.
Author: mjg
Date: Wed Jul 23 19:33:49 2014
New Revision: 269023
URL: http://svnweb.freebsd.org/changeset/base/269023
Log:
Prepare fget_unlocked for reading fd table only once.
Some capsicum functions accept fdp + fd and lookup fde based on that.
Add variants which accept fde.
Author: mjg
Date: Sun Aug 17 06:52:35 2014
New Revision: 270084
URL: http://svnweb.freebsd.org/changeset/base/270084
Log:
MFC r268074:
Perform a lockless check in sigacts_shared.
It is used only during execve (i.e. singlethreaded), so there is no fear
of returning 'not shared' which
Author: mjg
Date: Sun Aug 17 06:54:49 2014
New Revision: 270085
URL: http://svnweb.freebsd.org/changeset/base/270085
Log:
MFC r268087:
Don't call crcopysafe or uifind unnecessarily in execve.
Modified:
stable/10/sys/kern/kern_exec.c
Directory Properties:
stable/10/ (props changed)
Author: mjg
Date: Sun Aug 17 06:56:22 2014
New Revision: 270086
URL: http://svnweb.freebsd.org/changeset/base/270086
Log:
MFC r268136:
Plug gcc warning after r268074 about unitialized newsigacts
Modified:
stable/10/sys/kern/kern_exec.c
Directory Properties:
stable/10/ (props
Author: mjg
Date: Sun Aug 17 06:58:14 2014
New Revision: 270087
URL: http://svnweb.freebsd.org/changeset/base/270087
Log:
MFC r268365:
Don't call crdup nor uifind under vnode lock.
A locked vnode can get into the way of satisyfing malloc with M_WATOK.
This is a fixup to r268087.
Author: mjg
Date: Sun Aug 17 07:00:47 2014
New Revision: 270088
URL: http://svnweb.freebsd.org/changeset/base/270088
Log:
MFC r268505, r268507:
Avoid relocking filedesc lock when closing fds during fdp destruction.
Don't call bzero nor fdunused from fdfree for such cases. It would do
Author: mjg
Date: Sun Aug 17 07:05:30 2014
New Revision: 270089
URL: http://svnweb.freebsd.org/changeset/base/270089
Log:
MFC r259407:
proc exit: don't take PROC_LOCK while freeing rlimits
Code wishing to check rlimits of some process should check whether it
is exiting first, which
Author: mjg
Date: Sun Aug 17 07:06:55 2014
New Revision: 270090
URL: http://svnweb.freebsd.org/changeset/base/270090
Log:
MFC r268514:
Eliminate plim and vtmp local vars in exit1.
No functional changes.
Modified:
stable/10/sys/kern/kern_exit.c
Directory Properties:
stable/10/
Author: mjg
Date: Sun Aug 17 07:16:03 2014
New Revision: 270091
URL: http://svnweb.freebsd.org/changeset/base/270091
Log:
MFC r264114, r264310, r268570:
r264114 by davidxu:
Fix SIGIO delivery. Use fsetown() to handle file descriptor owner
ioctl and use pgsigio() to send SIGIO.
Author: mjg
Date: Sun Aug 17 07:20:37 2014
New Revision: 270092
URL: http://svnweb.freebsd.org/changeset/base/270092
Log:
MFC r268634:
Manage struct sigacts refcnt with atomics instead of a mutex.
Modified:
stable/10/sys/kern/kern_sig.c
stable/10/sys/sys/signalvar.h
Directory
Author: mjg
Date: Sun Aug 17 07:22:40 2014
New Revision: 270093
URL: http://svnweb.freebsd.org/changeset/base/270093
Log:
MFC r268636:
Plug p_pptr null test in do_execve. It is always true.
Modified:
stable/10/sys/kern/kern_exec.c
Directory Properties:
stable/10/ (props changed)
Author: mjg
Date: Sun Aug 17 07:24:23 2014
New Revision: 270094
URL: http://svnweb.freebsd.org/changeset/base/270094
Log:
MFC r269020:
Cosmetic changes to unp_internalize
Don't throw away the result of fget_unlocked.
Move fdp increment to for loop to make it consistent with similar
Author: mjg
Date: Fri May 2 00:52:13 2014
New Revision: 265206
URL: http://svnweb.freebsd.org/changeset/base/265206
Log:
Ignore the error from pipespace_new when creating a pipe.
It can fail if pipe map is exhausted (as a result of too many pipes created),
but it is not fatal and could
On Fri, May 02, 2014 at 10:37:05PM +0400, Chagin Dmitry wrote:
On Wed, Sep 18, 2013 at 08:46:48PM +0200, Mateusz Guzik wrote:
On Wed, Sep 18, 2013 at 05:56:04PM +, Roman Divacky wrote:
Author: rdivacky
Date: Wed Sep 18 17:56:04 2013
New Revision: 255672
URL: http
Author: mjg
Date: Fri May 2 21:41:35 2014
New Revision: 265245
URL: http://svnweb.freebsd.org/changeset/base/265245
Log:
Fix typo in KF_FD_TYPE_TRACE comment: ptrace - ktrace
Modified:
head/sys/sys/user.h
Modified: head/sys/sys/user.h
Author: mjg
Date: Fri May 2 21:55:09 2014
New Revision: 265247
URL: http://svnweb.freebsd.org/changeset/base/265247
Log:
Request a non-exiting process in sysctl_kern_proc_{o,}filedesc
This fixes a race with exit1 freeing p_textvp.
Suggested by: kib
MFC after:1 week
Modified:
Author: mjg
Date: Sat Jul 6 12:56:30 2013
New Revision: 252886
URL: http://svnweb.freebsd.org/changeset/base/252886
Log:
MFC r252415, r252422:
acct: reduce code duplication by using acct_disable as cleanup for
failed kproc_create
acct: create a special plimit object and set it for
Author: mjg
Date: Mon Jul 22 00:44:37 2013
New Revision: 253537
URL: http://svnweb.freebsd.org/changeset/base/253537
Log:
Remove duplicate assertion from tdsendsignal.
MFC after:2 weeks
Modified:
head/sys/kern/kern_sig.c
Modified: head/sys/kern/kern_sig.c
1 - 100 of 2063 matches
Mail list logo
