svn commit: r352842 - head/sys/netinet/tcp_stacks

Author: tuexen Date: Sat Sep 28 13:05:37 2019 New Revision: 352842 URL: https://svnweb.freebsd.org/changeset/base/352842 Log: Ensure that the INP lock is released before leaving [gs]etsockopt() for RACK specific socket options. These issues were found by a syzkaller instance. Reviewed by:

svn commit: r352676 - stable/12/sys/netinet

Author: tuexen Date: Wed Sep 25 10:46:05 2019 New Revision: 352676 URL: https://svnweb.freebsd.org/changeset/base/352676 Log: MFC r352594: Don't hold the info lock when calling sctp_select_a_tag(). This avoids a double lock bug in the NAT colliding state processing of SCTP. Thanks

svn commit: r352675 - stable/12/sys/netinet

Author: tuexen Date: Wed Sep 25 10:44:10 2019 New Revision: 352675 URL: https://svnweb.freebsd.org/changeset/base/352675 Log: MFC r352592: Cleanup the RTO calculation and perform some consistency checks before computing the RTO. This should fix an overflow issue reported by Felix

svn commit: r352674 - stable/12/sys/netinet

Author: tuexen Date: Wed Sep 25 10:42:34 2019 New Revision: 352674 URL: https://svnweb.freebsd.org/changeset/base/352674 Log: MFC r352550: Fix the handling of invalid parameters in ASCONF chunks. Thanks to Mark Wodrich from Google for reproting the issue in

svn commit: r352673 - stable/12/sys/netinet/tcp_stacks

Author: tuexen Date: Wed Sep 25 10:40:49 2019 New Revision: 352673 URL: https://svnweb.freebsd.org/changeset/base/352673 Log: MFC r352512: When the RACK stack computes the space for user data in a TCP segment, it wasn't taking the IP level options into account. This patch fixes this.

svn commit: r352672 - stable/12/sys/netinet6

Author: tuexen Date: Wed Sep 25 10:38:44 2019 New Revision: 352672 URL: https://svnweb.freebsd.org/changeset/base/352672 Log: MFC r352511: When processing an incoming IPv6 packet over the loopback interface which contains Hop-by-Hop options, the mbuf chain is potentially changed in

Re: svn commit: r352658 - head/sys/kern

> On 25. Sep 2019, at 07:13, Peter Holm wrote: > > On Tue, Sep 24, 2019 at 08:01:20PM +, Alexander Motin wrote: >> Author: mav >> Date: Tue Sep 24 20:01:20 2019 >> New Revision: 352658 >> URL: https://svnweb.freebsd.org/changeset/base/352658 >> >> Log: >> Fix/improve interrupt threads

svn commit: r352652 - head/sys/netinet

Author: tuexen Date: Tue Sep 24 13:15:24 2019 New Revision: 352652 URL: https://svnweb.freebsd.org/changeset/base/352652 Log: Plumb a memory leak. Thnanks to Felix Weinrank for finding this issue using fuzz testing and reporting it for the userland stack:

svn commit: r352594 - head/sys/netinet

Author: tuexen Date: Sun Sep 22 11:11:01 2019 New Revision: 352594 URL: https://svnweb.freebsd.org/changeset/base/352594 Log: Don't hold the info lock when calling sctp_select_a_tag(). This avoids a double lock bug in the NAT colliding state processing of SCTP. Thanks to Felix Weinrank

svn commit: r352592 - head/sys/netinet

Author: tuexen Date: Sun Sep 22 10:40:15 2019 New Revision: 352592 URL: https://svnweb.freebsd.org/changeset/base/352592 Log: Cleanup the RTO calculation and perform some consistency checks before computing the RTO. This should fix an overflow issue reported by Felix Weinrank in

svn commit: r352550 - head/sys/netinet

Author: tuexen Date: Fri Sep 20 08:20:20 2019 New Revision: 352550 URL: https://svnweb.freebsd.org/changeset/base/352550 Log: Fix the handling of invalid parameters in ASCONF chunks. Thanks to Mark Wodrich from Google for reproting the issue in https://github.com/sctplab/usrsctp/issues/376

svn commit: r352512 - head/sys/netinet/tcp_stacks

Author: tuexen Date: Thu Sep 19 10:27:47 2019 New Revision: 352512 URL: https://svnweb.freebsd.org/changeset/base/352512 Log: When the RACK stack computes the space for user data in a TCP segment, it wasn't taking the IP level options into account. This patch fixes this. In addition, it

svn commit: r352511 - head/sys/netinet6

Author: tuexen Date: Thu Sep 19 10:22:29 2019 New Revision: 352511 URL: https://svnweb.freebsd.org/changeset/base/352511 Log: When processing an incoming IPv6 packet over the loopback interface which contains Hop-by-Hop options, the mbuf chain is potentially changed in ip6_hopopts_input(),

svn commit: r352510 - stable/11/sys/netinet

Author: tuexen Date: Thu Sep 19 10:06:18 2019 New Revision: 352510 URL: https://svnweb.freebsd.org/changeset/base/352510 Log: MFC r352438: Only allow a SCTP-AUTH shared key to be updated by the application if it is not deactivated and not used. This avoids a use-after-free problem.

svn commit: r352509 - stable/12/sys/netinet

Author: tuexen Date: Thu Sep 19 10:01:19 2019 New Revision: 352509 URL: https://svnweb.freebsd.org/changeset/base/352509 Log: MFC r352438: Only allow a SCTP-AUTH shared key to be updated by the application if it is not deactivated and not used. This avoids a use-after-free problem.

svn commit: r352508 - stable/12/sys/netinet

Author: tuexen Date: Thu Sep 19 09:59:37 2019 New Revision: 352508 URL: https://svnweb.freebsd.org/changeset/base/352508 Log: MFC r352386: Don't write to memory outside of the allocated array for SACK blocks. Obtained from:rrs@ Sponsored by: Netflix, Inc.

svn commit: r352438 - head/sys/netinet

Author: tuexen Date: Tue Sep 17 09:46:42 2019 New Revision: 352438 URL: https://svnweb.freebsd.org/changeset/base/352438 Log: Only allow a SCTP-AUTH shared key to be updated by the application if it is not deactivated and not used. This avoids a use-after-free problem. Reported by:

svn commit: r352386 - head/sys/netinet

Author: tuexen Date: Mon Sep 16 08:18:05 2019 New Revision: 352386 URL: https://svnweb.freebsd.org/changeset/base/352386 Log: Don't write to memory outside of the allocated array for SACK blocks. Obtained from:rrs@ MFC after:3 days Sponsored by:

svn commit: r352361 - head/sys/netinet

Author: tuexen Date: Sun Sep 15 18:29:45 2019 New Revision: 352361 URL: https://svnweb.freebsd.org/changeset/base/352361 Log: When the IP layer calls back into the SCTP layer to perform the SCTP checksum computation, do not assume that the IP header chain and the SCTP common header are in

svn commit: r352284 - in stable/12/sys/netinet: . tcp_stacks

Author: tuexen Date: Fri Sep 13 08:14:46 2019 New Revision: 352284 URL: https://svnweb.freebsd.org/changeset/base/352284 Log: MFC r352072: Only update SACK/DSACK lists when a non-empty segment was received. This fixes hitting a KASSERT with a valid packet exchange. PR:

svn commit: r352072 - in head/sys/netinet: . tcp_stacks

Author: tuexen Date: Mon Sep 9 16:07:47 2019 New Revision: 352072 URL: https://svnweb.freebsd.org/changeset/base/352072 Log: Only update SACK/DSACK lists when a non-empty segment was received. This fixes hitting a KASSERT with a valid packet exchange. Reviewed by: rrs@, Richard

svn commit: r352057 - in stable/11/sys: netinet netinet6

Author: tuexen Date: Mon Sep 9 11:20:15 2019 New Revision: 352057 URL: https://svnweb.freebsd.org/changeset/base/352057 Log: MFC r349986: When calling sctp_initialize_auth_params(), the inp must have at least a read lock. To avoid more complex locking dances, just call it in

svn commit: r352055 - stable/11/contrib/traceroute

Author: tuexen Date: Mon Sep 9 10:44:58 2019 New Revision: 352055 URL: https://svnweb.freebsd.org/changeset/base/352055 Log: The variable names in the description of the port number usage is inconsistent. This patch fixes that and improves the precision of the description. Thanks to Tom

svn commit: r352022 - in stable/12/sys/netinet: . tcp_stacks

Author: tuexen Date: Sat Sep 7 19:58:06 2019 New Revision: 352022 URL: https://svnweb.freebsd.org/changeset/base/352022 Log: Improve DSACK support: MFC This is the second in a number of patches needed to get BBRv1 into the tree. This fixes the DSACK bug but is also needed by BBR. We

svn commit: r352008 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 12:20:47 2019 New Revision: 352008 URL: https://svnweb.freebsd.org/changeset/base/352008 Log: MFC r351655: Fix initialization of top_fsn. Modified: stable/12/sys/netinet/sctp_indata.h Directory Properties: stable/12/ (props changed) Modified:

svn commit: r352007 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 12:19:07 2019 New Revision: 352007 URL: https://svnweb.freebsd.org/changeset/base/352007 Log: MFC r351654: Improve the handling of state cookie parameters in INIT-ACK chunks. This fixes problem with parameters indicating a zero length or partial

svn commit: r352006 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 12:15:23 2019 New Revision: 352006 URL: https://svnweb.freebsd.org/changeset/base/352006 Log: MFC r351641: Improve function definition. Modified: stable/12/sys/netinet/sctp_pcb.c Directory Properties: stable/12/ (props changed) Modified:

svn commit: r352005 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 12:13:58 2019 New Revision: 352005 URL: https://svnweb.freebsd.org/changeset/base/352005 Log: MFC r351638: Improve the handling of illegal sequence number combinations in received data chunks. Abort the association if there are data chunks with larger

svn commit: r352004 - in stable/12/sys/arm64: arm64 include

Author: tuexen Date: Sat Sep 7 12:03:13 2019 New Revision: 352004 URL: https://svnweb.freebsd.org/changeset/base/352004 Log: MFC r351511: Identify eMAG CPU used in Ampere Computing systems. Reviewed by: emaste@ Differential Revision:

svn commit: r352003 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 12:01:41 2019 New Revision: 352003 URL: https://svnweb.freebsd.org/changeset/base/352003 Log: MFC r350745: Fix a typo. Submitted by: Thomas Dreibholz Modified: stable/12/sys/netinet/sctp_asconf.c Directory Properties: stable/12/ (props

svn commit: r352002 - stable/12/share/man/man4

Author: tuexen Date: Sat Sep 7 12:00:17 2019 New Revision: 352002 URL: https://svnweb.freebsd.org/changeset/base/352002 Log: MFC r350627: Reference the RFC instead of the internet draft. Sponsored by: Netflix, Inc. Modified: stable/12/share/man/man4/cc_newreno.4

svn commit: r352001 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 11:58:32 2019 New Revision: 352001 URL: https://svnweb.freebsd.org/changeset/base/352001 Log: MFC r350626: Fix a locking issue in sctp_accept. PR: 238520 Reported by: pho@ Modified: stable/12/sys/netinet/sctp_usrreq.c

svn commit: r352000 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 11:56:43 2019 New Revision: 352000 URL: https://svnweb.freebsd.org/changeset/base/352000 Log: MFC r350625: Fix build issues for the userland stack on Raspbian. Modified: stable/12/sys/netinet/sctp_output.c stable/12/sys/netinet/sctputil.c Directory

svn commit: r351999 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 11:52:35 2019 New Revision: 351999 URL: https://svnweb.freebsd.org/changeset/base/351999 Log: MFC r350520: Fix the reporting of multiple unknown parameters in an received INIT chunk. This also plugs an potential mbuf leak. Thanks to Felix Weinrank for

svn commit: r351998 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 11:51:07 2019 New Revision: 351998 URL: https://svnweb.freebsd.org/changeset/base/351998 Log: MFC r350508: When responding with an ABORT to an INIT chunk containing a HOSTNAME parameter or a parameter with an illegal length, only include an error cause

svn commit: r351997 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 11:49:41 2019 New Revision: 351997 URL: https://svnweb.freebsd.org/changeset/base/351997 Log: MFC r350488: Small cleanup, no functional change intended. Modified: stable/12/sys/netinet/sctp_output.c Directory Properties: stable/12/ (props changed)

svn commit: r351996 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 11:48:25 2019 New Revision: 351996 URL: https://svnweb.freebsd.org/changeset/base/351996 Log: MFC r350487: Consistently cleanup mbufs in case of other memory errors. Modified: stable/12/sys/netinet/sctp_output.c Directory Properties: stable/12/ (props

svn commit: r351995 - stable/12/sys/netinet/cc

Author: tuexen Date: Sat Sep 7 11:46:49 2019 New Revision: 351995 URL: https://svnweb.freebsd.org/changeset/base/351995 Log: MFC r350404: When performing after_idle() or post_recovery(), don't disable the DCTCP specific methods. Also fallthrough NewReno for non ECN capable TCP

svn commit: r351994 - in stable/12: share/man/man4 sys/netinet/cc

Author: tuexen Date: Sat Sep 7 11:33:27 2019 New Revision: 351994 URL: https://svnweb.freebsd.org/changeset/base/351994 Log: MFC r350403: * Improve input validation of sysctl parameters for DCTPC. * Initialize the alpha parameter to a conservative value (like Linux) * Improve handling

svn commit: r351993 - in stable/12: share/man/man4 sys/netinet

Author: tuexen Date: Sat Sep 7 11:31:05 2019 New Revision: 351993 URL: https://svnweb.freebsd.org/changeset/base/351993 Log: MFC r350265: Add a sysctl variable ts_offset_per_conn to change the computation of the TCP TS offset from taking the IP addresses and the TCP port numbers into

svn commit: r351992 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 11:24:29 2019 New Revision: 351992 URL: https://svnweb.freebsd.org/changeset/base/351992 Log: MFC r350254: Don't hold a mutex while calling sbwait. This was found by syzkaller. Submitted by: rrs@ Reported by: markj@ Modified:

svn commit: r351991 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 11:22:24 2019 New Revision: 351991 URL: https://svnweb.freebsd.org/changeset/base/351991 Log: MFC r350248: Fix a LOR in SCTP which was found by running syzkaller. Submitted by: rrs@ Reported by: markj@ Modified:

svn commit: r351979 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 11:19:55 2019 New Revision: 351979 URL: https://svnweb.freebsd.org/changeset/base/351979 Log: MFC r350216: Wakeup the application when doing PD-API for unordered DATA chunks. Work done with rrs@. Modified: stable/12/sys/netinet/sctp_indata.c Directory

svn commit: r351978 - stable/12/usr.sbin/traceroute6

Author: tuexen Date: Sat Sep 7 10:57:47 2019 New Revision: 351978 URL: https://svnweb.freebsd.org/changeset/base/351978 Log: MFC 350028: dd support for ICMPv6 messages indicating a parameter problem related to an unrecognized next header. Modified:

svn commit: r351977 - stable/12/usr.sbin/traceroute6

Author: tuexen Date: Sat Sep 7 10:56:38 2019 New Revision: 351977 URL: https://svnweb.freebsd.org/changeset/base/351977 Log: MFC 350027: Let packet_op() explicitly return the type and code instead of doing this implicitly by encoding it in a number space. No functional change

svn commit: r351976 - stable/12/usr.sbin/traceroute6

Author: tuexen Date: Sat Sep 7 10:55:12 2019 New Revision: 351976 URL: https://svnweb.freebsd.org/changeset/base/351976 Log: MFC r350026: Whitespace change. No functional change. Modified: stable/12/usr.sbin/traceroute6/traceroute6.c Directory Properties: stable/12/ (props changed)

svn commit: r351975 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 10:53:29 2019 New Revision: 351975 URL: https://svnweb.freebsd.org/changeset/base/351975 Log: MFC r34: Add support for MSG_EOR and MSG_EOF in sendmsg() for SCTP. This is an FreeBSD extension, not covered by Posix. This issue was found by

svn commit: r351974 - stable/12/sys/netinet

Author: tuexen Date: Sat Sep 7 10:51:33 2019 New Revision: 351974 URL: https://svnweb.freebsd.org/changeset/base/351974 Log: MFC r349998: Fix socket state handling when freeing an SCTP endpoint. This issue was found by runing syzkaller. Modified: stable/12/sys/netinet/sctp_pcb.c

svn commit: r351973 - stable/12/sys/kern

Author: tuexen Date: Sat Sep 7 10:49:37 2019 New Revision: 351973 URL: https://svnweb.freebsd.org/changeset/base/351973 Log: MFC r349989: Improve the input validation for l_linger. When using the SOL_SOCKET level socket option SO_LINGER, the structure struct linger is used as the

svn commit: r351972 - in stable/12/sys: netinet netinet6

Author: tuexen Date: Sat Sep 7 10:47:43 2019 New Revision: 351972 URL: https://svnweb.freebsd.org/changeset/base/351972 Log: MFC r349986: When calling sctp_initialize_auth_params(), the inp must have at least a read lock. To avoid more complex locking dances, just call it in

svn commit: r351971 - stable/12/sys/netinet6

Author: tuexen Date: Sat Sep 7 10:45:44 2019 New Revision: 351971 URL: https://svnweb.freebsd.org/changeset/base/351971 Log: MFC r349968: r348494 fixes a race in udp_output(). The same race exists in udp_output6(), therefore apply a similar patch to IPv6. Reviewed by: bz@,

svn commit: r351970 - stable/12/contrib/traceroute

Author: tuexen Date: Sat Sep 7 10:39:49 2019 New Revision: 351970 URL: https://svnweb.freebsd.org/changeset/base/351970 Log: MFC r349228: The variable names in the description of the port number usage is inconsistent. This patch fixes that and improves the precision of the

svn commit: r351801 - head/sys/netinet

Author: tuexen Date: Wed Sep 4 04:38:31 2019 New Revision: 351801 URL: https://svnweb.freebsd.org/changeset/base/351801 Log: Fix the SACK block generation in the base TCP stack by bringing it in sync with the RACK stack. Reviewed by: rrs@ MFC after:5 days

svn commit: r351782 - head/sys/netinet/tcp_stacks

Author: tuexen Date: Tue Sep 3 19:48:02 2019 New Revision: 351782 URL: https://svnweb.freebsd.org/changeset/base/351782 Log: Fix two TCP RACK issues: * Convert the TCP delayed ACK timer from ms to ticks as required. This fixes the timer on platforms with hz != 1000. * Don't delay

svn commit: r346400 - head/sys/netinet6

Author: tuexen Date: Fri Apr 19 17:17:41 2019 New Revision: 346400 URL: https://svnweb.freebsd.org/changeset/base/346400 Log: Improve input validation for the socket option IPV6_CHECKSUM. When using the IPPROTO_IPV6 level socket option IPV6_CHECKSUM on a raw IPv6 socket, ensure that the

svn commit: r346401 - head/sys/netinet6

Author: tuexen Date: Fri Apr 19 17:21:35 2019 New Revision: 346401 URL: https://svnweb.freebsd.org/changeset/base/346401 Log: Avoid a buffer overwrite in rip6_output() when computing the checksum as requested by the user via the IPPROTO_IPV6 level socket option IPV6_CHECKSUM. The check if

svn commit: r346406 - head/sys/netinet6

Author: tuexen Date: Fri Apr 19 18:09:37 2019 New Revision: 346406 URL: https://svnweb.freebsd.org/changeset/base/346406 Log: When an IPv6 packet is received for a raw socket which has the IPPROTO_IPV6 level socket option IPV6_CHECKSUM enabled and the checksum check fails, drop the message.

svn commit: r346402 - head/sys/netinet6

Author: tuexen Date: Fri Apr 19 17:28:28 2019 New Revision: 346402 URL: https://svnweb.freebsd.org/changeset/base/346402 Log: When a checksum has to be computed for a received IPv6 packet because it is requested by the application using the IPPROTO_IPV6 level socket option IPV6_CHECKSUM on

svn commit: r346197 - head/sys/net

Author: tuexen Date: Sun Apr 14 10:18:14 2019 New Revision: 346197 URL: https://svnweb.freebsd.org/changeset/base/346197 Log: When sending a routing message, don't allow the user to set the RTF_RNH_LOCKED flag in rtm_flags, since this flag is used only internally. Reported by:

svn commit: r346182 - head/sys/netinet

Author: tuexen Date: Sat Apr 13 10:47:47 2019 New Revision: 346182 URL: https://svnweb.freebsd.org/changeset/base/346182 Log: When sending IPv4 packets on a SOCK_RAW socket using the IP_HDRINCL option, ensure that the ip_hl field is valid. Furthermore, ensure that the complete IPv4 header

svn commit: r346134 - head/sys/netinet

Author: tuexen Date: Thu Apr 11 20:39:12 2019 New Revision: 346134 URL: https://svnweb.freebsd.org/changeset/base/346134 Log: Fix an SCTP related locking issue. Don't report that the TCB_SEND_LOCK is owned, when it is not. This issue was found by running syzkaller. MFC after:

svn commit: r351725 - in head/sys/netinet: . tcp_stacks

Author: tuexen Date: Mon Sep 2 19:04:02 2019 New Revision: 351725 URL: https://svnweb.freebsd.org/changeset/base/351725 Log: This patch improves the DSACK handling to conform with RFC 2883. The lowest SACK block is used when multiple Blocks would be elegible as DSACK blocks ACK blocks get

svn commit: r351655 - head/sys/netinet

Author: tuexen Date: Sun Sep 1 10:39:16 2019 New Revision: 351655 URL: https://svnweb.freebsd.org/changeset/base/351655 Log: Fix initialization of top_fsn. MFC after:3 days Modified: head/sys/netinet/sctp_indata.h Modified: head/sys/netinet/sctp_indata.h

svn commit: r351654 - head/sys/netinet

Author: tuexen Date: Sun Sep 1 10:09:53 2019 New Revision: 351654 URL: https://svnweb.freebsd.org/changeset/base/351654 Log: Improve the handling of state cookie parameters in INIT-ACK chunks. This fixes problem with parameters indicating a zero length or partial parameters after an

svn commit: r351641 - head/sys/netinet

Author: tuexen Date: Sat Aug 31 13:13:40 2019 New Revision: 351641 URL: https://svnweb.freebsd.org/changeset/base/351641 Log: Improve function definition. MFC after:3 days Modified: head/sys/netinet/sctp_pcb.c Modified: head/sys/netinet/sctp_pcb.c

svn commit: r351638 - head/sys/netinet

Author: tuexen Date: Sat Aug 31 08:18:49 2019 New Revision: 351638 URL: https://svnweb.freebsd.org/changeset/base/351638 Log: Improve the handling of illegal sequence number combinations in received data chunks. Abort the association if there are data chunks with larger fragement sequence

svn commit: r351512 - head/sys/netinet

Author: tuexen Date: Mon Aug 26 16:23:47 2019 New Revision: 351512 URL: https://svnweb.freebsd.org/changeset/base/351512 Log: Don't hold the rs_mtx lock while calling malloc(). Reviewed by: rrs@ Sponsored by: Netflix, Inc. Differential Revision:

svn commit: r351511 - in head/sys/arm64: arm64 include

Author: tuexen Date: Mon Aug 26 16:12:14 2019 New Revision: 351511 URL: https://svnweb.freebsd.org/changeset/base/351511 Log: Identify eMAG CPU used in Ampere Computing systems. Reviewed by: emaste@ MFC after:1 week Differential Revision:

svn commit: r350745 - head/sys/netinet

Author: tuexen Date: Thu Aug 8 08:23:27 2019 New Revision: 350745 URL: https://svnweb.freebsd.org/changeset/base/350745 Log: Fix a typo. Submitted by: Thomas Dreibholz MFC after:1 week Modified: head/sys/netinet/sctp_asconf.c Modified:

svn commit: r350627 - head/share/man/man4

Author: tuexen Date: Tue Aug 6 11:26:30 2019 New Revision: 350627 URL: https://svnweb.freebsd.org/changeset/base/350627 Log: Reference the RFC instead of the internet draft. MFC after:1 week Sponsored by: Netflix, Inc. Modified: head/share/man/man4/cc_newreno.4

svn commit: r350625 - head/sys/netinet

Author: tuexen Date: Tue Aug 6 08:33:21 2019 New Revision: 350625 URL: https://svnweb.freebsd.org/changeset/base/350625 Log: Fix build issues for the userland stack on Raspbian. Modified: head/sys/netinet/sctp_output.c head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctp_output.c

svn commit: r350626 - head/sys/netinet

Author: tuexen Date: Tue Aug 6 10:29:19 2019 New Revision: 350626 URL: https://svnweb.freebsd.org/changeset/base/350626 Log: Fix a locking issue in sctp_accept. PR: 238520 Reported by: pho@ MFC after:1 week Modified:

svn commit: r350588 - in head/sys: netinet netinet6

Author: tuexen Date: Mon Aug 5 13:22:15 2019 New Revision: 350588 URL: https://svnweb.freebsd.org/changeset/base/350588 Log: Improve consistency. No functional change. MFC after:3 days Modified: head/sys/netinet/sctp_asconf.c head/sys/netinet/sctp_os_bsd.h

svn commit: r350520 - head/sys/netinet

Author: tuexen Date: Thu Aug 1 19:45:34 2019 New Revision: 350520 URL: https://svnweb.freebsd.org/changeset/base/350520 Log: Fix the reporting of multiple unknown parameters in an received INIT chunk. This also plugs an potential mbuf leak. Thanks to Felix Weinrank for reporting this issue

svn commit: r350508 - head/sys/netinet

Author: tuexen Date: Thu Aug 1 17:36:15 2019 New Revision: 350508 URL: https://svnweb.freebsd.org/changeset/base/350508 Log: When responding with an ABORT to an INIT chunk containing a HOSTNAME parameter or a parameter with an illegal length, only include an error cause indicating why the

svn commit: r350488 - head/sys/netinet

Author: tuexen Date: Wed Jul 31 21:39:03 2019 New Revision: 350488 URL: https://svnweb.freebsd.org/changeset/base/350488 Log: Small cleanup, no functional change intended. MFC after:3 days Modified: head/sys/netinet/sctp_output.c Modified: head/sys/netinet/sctp_output.c

svn commit: r350487 - head/sys/netinet

Author: tuexen Date: Wed Jul 31 21:29:17 2019 New Revision: 350487 URL: https://svnweb.freebsd.org/changeset/base/350487 Log: Consistently cleanup mbufs in case of other memory errors. MFC after:3 days Modified: head/sys/netinet/sctp_output.c Modified:

svn commit: r350404 - head/sys/netinet/cc

Author: tuexen Date: Mon Jul 29 09:19:48 2019 New Revision: 350404 URL: https://svnweb.freebsd.org/changeset/base/350404 Log: When performing after_idle() or post_recovery(), don't disable the DCTCP specific methods. Also fallthrough NewReno for non ECN capable TCP connections and improve

svn commit: r350403 - in head: share/man/man4 sys/netinet/cc

Author: tuexen Date: Mon Jul 29 08:50:35 2019 New Revision: 350403 URL: https://svnweb.freebsd.org/changeset/base/350403 Log: * Improve input validation of sysctl parameters for DCTPC. * Initialize the alpha parameter to a conservative value (like Linux) * Improve handling of arithmetic.

svn commit: r350265 - in head: share/man/man4 sys/netinet

Author: tuexen Date: Tue Jul 23 21:28:20 2019 New Revision: 350265 URL: https://svnweb.freebsd.org/changeset/base/350265 Log: Add a sysctl variable ts_offset_per_conn to change the computation of the TCP TS offset from taking the IP addresses and the TCP port numbers into account to a

svn commit: r350254 - head/sys/netinet

Author: tuexen Date: Tue Jul 23 18:31:07 2019 New Revision: 350254 URL: https://svnweb.freebsd.org/changeset/base/350254 Log: Don't hold a mutex while calling sbwait. This was found by syzkaller. Submitted by: rrs@ Reported by: markj@ MFC after:1 week

svn commit: r350248 - head/sys/netinet

Author: tuexen Date: Tue Jul 23 18:07:36 2019 New Revision: 350248 URL: https://svnweb.freebsd.org/changeset/base/350248 Log: Fix a LOR in SCTP which was found by running syzkaller. Submitted by: rrs@ Reported by: markj@ MFC after:1 week Modified:

svn commit: r350216 - head/sys/netinet

Author: tuexen Date: Mon Jul 22 18:11:35 2019 New Revision: 350216 URL: https://svnweb.freebsd.org/changeset/base/350216 Log: Wakeup the application when doing PD-API for unordered DATA chunks. Work done with rrs@. MFC after:1 week Modified: head/sys/netinet/sctp_indata.c

svn commit: r350061 - head/sys/netinet/tcp_stacks

Author: tuexen Date: Tue Jul 16 17:54:20 2019 New Revision: 350061 URL: https://svnweb.freebsd.org/changeset/base/350061 Log: Fix compilation on platforms using gcc. When compiling RACK on platforms using gcc, a warning that tcp_outflags is defined but not used is issued and terminates

svn commit: r350028 - head/usr.sbin/traceroute6

Author: tuexen Date: Tue Jul 16 12:57:59 2019 New Revision: 350028 URL: https://svnweb.freebsd.org/changeset/base/350028 Log: Add support for ICMPv6 messages indicating a parameter problem related to an unrecognized next header. MFC after:2 weeks Modified:

svn commit: r350027 - head/usr.sbin/traceroute6

Author: tuexen Date: Tue Jul 16 12:38:17 2019 New Revision: 350027 URL: https://svnweb.freebsd.org/changeset/base/350027 Log: Let packet_op() explicitly return the type and code instead of doing this implicitly by encoding it in a number space. No functional change intended. This is

svn commit: r350026 - head/usr.sbin/traceroute6

Author: tuexen Date: Tue Jul 16 10:06:41 2019 New Revision: 350026 URL: https://svnweb.freebsd.org/changeset/base/350026 Log: Whitespace change. No functional change. MFC after:2 weeks Modified: head/usr.sbin/traceroute6/traceroute6.c Modified:

Re: svn commit: r349999 - head/sys/netinet

> On 16. Jul 2019, at 00:55, Oliver Pinter > wrote: > > > > On Monday, July 15, 2019, Michael Tuexen wrote: > Author: tuexen > Date: Mon Jul 15 14:54:04 2019 > New Revision: 34 > URL: https://svnweb.freebsd.org/changeset/base/34 > > Log: >

svn commit: r350011 - head/sys/netinet

Author: tuexen Date: Mon Jul 15 20:45:01 2019 New Revision: 350011 URL: https://svnweb.freebsd.org/changeset/base/350011 Log: Don't free read control entries, which are still on the stream queue when adding them the the read queue fails MFC after:1 week Modified:

svn commit: r349999 - head/sys/netinet

Author: tuexen Date: Mon Jul 15 14:54:04 2019 New Revision: 34 URL: https://svnweb.freebsd.org/changeset/base/34 Log: Add support for MSG_EOR and MSG_EOF in sendmsg() for SCTP. This is an FreeBSD extension, not covered by Posix. This issue was found by running syzkaller.

svn commit: r349998 - head/sys/netinet

Author: tuexen Date: Mon Jul 15 14:52:52 2019 New Revision: 349998 URL: https://svnweb.freebsd.org/changeset/base/349998 Log: Fix socket state handling when freeing an SCTP endpoint. This issue was found by runing syzkaller. MFC after:1 week Modified:

svn commit: r349989 - head/sys/kern

Author: tuexen Date: Sun Jul 14 21:44:18 2019 New Revision: 349989 URL: https://svnweb.freebsd.org/changeset/base/349989 Log: Improve the input validation for l_linger. When using the SOL_SOCKET level socket option SO_LINGER, the structure struct linger is used as the option value. The

svn commit: r349986 - in head/sys: netinet netinet6

Author: tuexen Date: Sun Jul 14 12:04:39 2019 New Revision: 349986 URL: https://svnweb.freebsd.org/changeset/base/349986 Log: When calling sctp_initialize_auth_params(), the inp must have at least a read lock. To avoid more complex locking dances, just call it in sctp_aloc_assoc() when the

svn commit: r349968 - head/sys/netinet6

Author: tuexen Date: Sat Jul 13 12:45:08 2019 New Revision: 349968 URL: https://svnweb.freebsd.org/changeset/base/349968 Log: r348494 fixes a race in udp_output(). The same race exists in udp_output6(), therefore apply a similar patch to IPv6. Reported by:

svn commit: r349228 - head/contrib/traceroute

Author: tuexen Date: Thu Jun 20 12:38:41 2019 New Revision: 349228 URL: https://svnweb.freebsd.org/changeset/base/349228 Log: The variable names in the description of the port number usage is inconsistent. This patch fixes that and improves the precision of the description. Thanks to Tom

svn commit: r349226 - stable/12/sys/netinet/tcp_stacks

Author: tuexen Date: Thu Jun 20 07:50:38 2019 New Revision: 349226 URL: https://svnweb.freebsd.org/changeset/base/349226 Log: MFC r348728: r347382 added receiver side DSACK support for the TCP base stack. The corresponding changes for the RACK stack where missed and are added by this

svn commit: r348728 - head/sys/netinet/tcp_stacks

Author: tuexen Date: Thu Jun 6 07:49:03 2019 New Revision: 348728 URL: https://svnweb.freebsd.org/changeset/base/348728 Log: r347382 added receiver side DSACK support for the TCP base stack. The corresponding changes for the RACK stack where missed and are added by this commit.

Re: svn commit: r348435 - stable/11/sys/netinet

> On 30. May 2019, at 19:20, John Baldwin wrote: > > On 5/30/19 9:32 AM, Michael Tuexen wrote: >> Author: tuexen >> Date: Thu May 30 16:32:18 2019 >> New Revision: 348435 >> URL: https://svnweb.freebsd.org/changeset/base/348435 >> >> Log: >>

svn commit: r348441 - stable/11/sys/netinet

Author: tuexen Date: Thu May 30 17:31:19 2019 New Revision: 348441 URL: https://svnweb.freebsd.org/changeset/base/348441 Log: Unbreak the powerpc, powerpc64, and sparc64 builds. The issue was introduced in r348435. Approved by: re (gjb@) Modified:

Re: svn commit: r348435 - stable/11/sys/netinet

> On 30. May 2019, at 19:20, John Baldwin wrote: > > On 5/30/19 9:32 AM, Michael Tuexen wrote: >> Author: tuexen >> Date: Thu May 30 16:32:18 2019 >> New Revision: 348435 >> URL: https://svnweb.freebsd.org/changeset/base/348435 >> >> Log: >>

<    1   2   3   4   5   6   7   8   9   10   >