Re: svn commit: r227791 - head/sys/netinet

2011-11-21 Thread Qing Li
Logically speaking the prefix route should not be removed until all of the address related housing keeping tasks have been completed successfully. Putting "in_scrubprefix()" at the top does not gain you anything at all, but can potentially be problematic if additional tasks are in fact performed i

Re: svn commit: r227791 - head/sys/netinet

2011-11-21 Thread Qing Li
> > From my point of view logically speaking, we should first remove route, > then remove address. Otherwise, for a short time we've got an invalid > route in table. > For a short time you have an invalid address, it is faster to remove the address from the list to prevent usage, then to flush the

Re: svn commit: r227791 - head/sys/netinet

2011-11-23 Thread Qing Li
> >  first I'd like to notice that we are speaking about obsoleted interfaces. > Yup, that's why you don't see me commenting on your other commits around ia_netmask stuff, do you ? > > Back to your comments: > > I have made a test case that proves, that usage of deleted address isn't > prevente

svn commit: r228092 - stable/8/sys/netinet6

2011-11-28 Thread Qing Li
Author: qingli Date: Mon Nov 28 19:53:16 2011 New Revision: 228092 URL: http://svn.freebsd.org/changeset/base/228092 Log: MFC 227460 A default route learned from the RAs could be deleted manually after its installation. This removal may be accidental and can prevent the default route fr

svn commit: r196569 - head/sys/netinet6

2009-08-26 Thread Qing Li
Author: qingli Date: Wed Aug 26 21:32:50 2009 New Revision: 196569 URL: http://svn.freebsd.org/changeset/base/196569 Log: When multiple interfaces exist in the system, with each interface having an IPv6 address assigned to it, and if an incoming packet received on one interface has a packet

svn commit: r196608 - head/sys/netinet

2009-08-28 Thread Qing Li
Author: qingli Date: Fri Aug 28 05:37:31 2009 New Revision: 196608 URL: http://svn.freebsd.org/changeset/base/196608 Log: Do not try to free the rt_lle entry of the cached route in ip_output() if the cached route was not initialized from the flow-table. The rt_lle entry is invalid unless it

svn commit: r196609 - head/sys/net

2009-08-28 Thread Qing Li
Author: qingli Date: Fri Aug 28 07:01:09 2009 New Revision: 196609 URL: http://svn.freebsd.org/changeset/base/196609 Log: In ip_output(), the flow-table module must not try to cache L2/L3 information for interface of IFF_POINTOPOINT or IFF_LOOPBACK type. Since the L2 information (rt_lle) is

svn commit: r196649 - head/sys/netinet6

2009-08-29 Thread Qing Li
Author: qingli Date: Sun Aug 30 02:07:23 2009 New Revision: 196649 URL: http://svn.freebsd.org/changeset/base/196649 Log: Prefix on-link verification is being performed on statically configured prefixes. Since these statically configured prefixes do not have any associated advertising router

svn commit: r196671 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet6

2009-08-30 Thread Qing Li
Author: qingli Date: Sun Aug 30 22:36:46 2009 New Revision: 196671 URL: http://svn.freebsd.org/changeset/base/196671 Log: MFC r196569 When multiple interfaces exist in the system, with each interface having an IPv6 address assigned to it, and if an incoming packet received on one inte

svn commit: r196672 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet

2009-08-30 Thread Qing Li
Author: qingli Date: Sun Aug 30 22:39:49 2009 New Revision: 196672 URL: http://svn.freebsd.org/changeset/base/196672 Log: MFC r196608 Do not try to free the rt_lle entry of the cached route in ip_output() if the cached route was not initialized from the flow-table. The rt_lle entry is

svn commit: r196673 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

2009-08-30 Thread Qing Li
Author: qingli Date: Sun Aug 30 22:42:32 2009 New Revision: 196673 URL: http://svn.freebsd.org/changeset/base/196673 Log: MFC r196609 In ip_output(), the flow-table module must not try to cache L2/L3 information for interface of IFF_POINTOPOINT or IFF_LOOPBACK type. Since the L2 infor

svn commit: r196674 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet6

2009-08-30 Thread Qing Li
Author: qingli Date: Sun Aug 30 22:44:12 2009 New Revision: 196674 URL: http://svn.freebsd.org/changeset/base/196674 Log: MFC r196649 Prefix on-link verification is being performed on statically configured prefixes. Since these statically configured prefixes do not have any associated

svn commit: r196679 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

2009-08-30 Thread Qing Li
Author: qingli Date: Mon Aug 31 00:18:17 2009 New Revision: 196679 URL: http://svn.freebsd.org/changeset/base/196679 Log: As part of r196609, a call to "rtalloc" did not take the fib into account. So call the appropriate "rtalloc_ign_fib()" instead of calling "rtalloc_ign()". Reviewed

svn commit: r196678 - head/sys/net

2009-08-30 Thread Qing Li
Author: qingli Date: Mon Aug 31 00:14:37 2009 New Revision: 196678 URL: http://svn.freebsd.org/changeset/base/196678 Log: As part of r196609, a call to "rtalloc" did not take the fib into account. So call the appropriate "rtalloc_ign_fib()" instead of calling "rtalloc_ign()". Reviewed

RE: svn commit: r196673 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

2009-08-31 Thread Qing Li
> > With this change, can I mark the following two TODO items as done: > > * RTM_CHANGE in net/rtsock.c can incorrectly set > RTF_GATEWAY (QingLi) (in > progress) > * flowtable mishandles gateway (G) routes on POINT2POINT interfaces > (BrianSomers) (in progress) > AFAIK, Yes. > >

RE: svn commit: r196679 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

2009-08-31 Thread Qing Li
> > On Mon, 31 Aug 2009, Qing Li wrote: > > > As part of r196609, a call to "rtalloc" did not take the > fib into > > account. So call the appropriate "rtalloc_ign_fib()" instead of > > calling "rtalloc_ign()". > > &g

svn commit: r196714 - head/sys/netinet

2009-08-31 Thread Qing Li
Author: qingli Date: Mon Aug 31 21:02:48 2009 New Revision: 196714 URL: http://svn.freebsd.org/changeset/base/196714 Log: This patch fixes the following issues: - Routing messages are not generated when adding and removing interface address aliases. - Loopback route installed for an i

svn commit: r196865 - head/sys/netinet6

2009-09-05 Thread Qing Li
Author: qingli Date: Sat Sep 5 16:50:55 2009 New Revision: 196865 URL: http://svn.freebsd.org/changeset/base/196865 Log: This patch fixes an address scope violation. Considering the scenario where an anycast address is assigned on one interface, and a global address with the same scope is a

svn commit: r196864 - in head/sys: net netinet6

2009-09-05 Thread Qing Li
Author: qingli Date: Sat Sep 5 16:43:16 2009 New Revision: 196864 URL: http://svn.freebsd.org/changeset/base/196864 Log: This patch fixes the following issues: - Interface link-local address is not reachable within the node that owns the interface, this is due to the mismatch in addre

svn commit: r196868 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet6

2009-09-05 Thread Qing Li
Author: qingli Date: Sat Sep 5 17:35:31 2009 New Revision: 196868 URL: http://svn.freebsd.org/changeset/base/196868 Log: MFC r196865 This patch fixes an address scope violation. Considering the scenario where an anycast address is assigned on one interface, and a global address with

svn commit: r196869 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net netinet6

2009-09-05 Thread Qing Li
Author: qingli Date: Sat Sep 5 17:40:27 2009 New Revision: 196869 URL: http://svn.freebsd.org/changeset/base/196869 Log: MFC r196864 This patch fixes the following issues: - Interface link-local address is not reachable within the node that owns the interface, this is due to the mi

svn commit: r196871 - in head/sys: net netinet6

2009-09-05 Thread Qing Li
Author: qingli Date: Sat Sep 5 20:24:37 2009 New Revision: 196871 URL: http://svn.freebsd.org/changeset/base/196871 Log: The addresses that are assigned to the loopback interface should be part of the kernel routing table. Reviewed by: bz MFC after:immediately Modified: head/sy

svn commit: r196872 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net netinet6

2009-09-05 Thread Qing Li
Author: qingli Date: Sat Sep 5 20:35:18 2009 New Revision: 196872 URL: http://svn.freebsd.org/changeset/base/196872 Log: MFC r196871 The addresses that are assigned to the loopback interface should be part of the kernel routing table. Reviewed by: bz Approved by: re Modified:

svn commit: r197203 - head/sys/netinet

2009-09-14 Thread Qing Li
Author: qingli Date: Mon Sep 14 22:19:47 2009 New Revision: 197203 URL: http://svn.freebsd.org/changeset/base/197203 Log: Previously local end of point-to-point interface is not reachable within the system that owns the interface. Packets destined to the local end point leak to the wire towa

svn commit: r197210 - in head/sys: netinet nfsclient

2009-09-14 Thread Qing Li
Author: qingli Date: Tue Sep 15 01:01:03 2009 New Revision: 197210 URL: http://svn.freebsd.org/changeset/base/197210 Log: The bootp code installs an interface address and the nfs client module tries to install the same address again. This extra code is removed, which was discovered by the re

svn commit: r197212 - head/sys/nfsclient

2009-09-14 Thread Qing Li
Author: qingli Date: Tue Sep 15 02:22:57 2009 New Revision: 197212 URL: http://svn.freebsd.org/changeset/base/197212 Log: Simply remove the code instead of using "#if 0". Pointed out by sam Modified: head/sys/nfsclient/nfs_vfsops.c Modified: head/sys/nfsclient/nfs_vfsops.c =

svn commit: r197225 - head/sys/netinet

2009-09-15 Thread Qing Li
Author: qingli Date: Tue Sep 15 18:39:27 2009 New Revision: 197225 URL: http://svn.freebsd.org/changeset/base/197225 Log: This patch enables the node to respond to ARP requests for configured proxy ARP entries. Reviewed by: bz MFC after:immediately Modified: head/sys/netinet/if_

svn commit: r197227 - in head/sys: net netinet netinet6

2009-09-15 Thread Qing Li
Author: qingli Date: Tue Sep 15 19:18:34 2009 New Revision: 197227 URL: http://svn.freebsd.org/changeset/base/197227 Log: Self pointing routes are installed for configured interface addresses and address aliases. After an interface is brought down and brought back up again, those self pointi

svn commit: r197229 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet

2009-09-15 Thread Qing Li
Author: qingli Date: Tue Sep 15 19:38:29 2009 New Revision: 197229 URL: http://svn.freebsd.org/changeset/base/197229 Log: MFC r197203 Previously local end of point-to-point interface is not reachable within the system that owns the interface. Packets destined to the local end point le

svn commit: r197231 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet

2009-09-15 Thread Qing Li
Author: qingli Date: Tue Sep 15 19:58:33 2009 New Revision: 197231 URL: http://svn.freebsd.org/changeset/base/197231 Log: MFC r196714 This patch fixes the following issues: - Routing messages are not generated when adding and removing interface address aliases. - Loopback route

svn commit: r197235 - head/sys/nfsclient

2009-09-15 Thread Qing Li
Author: qingli Date: Tue Sep 15 22:09:42 2009 New Revision: 197235 URL: http://svn.freebsd.org/changeset/base/197235 Log: Reverting the previous change for now. Some users reports the patch fixes their issues but one reports a failure in NFS ROOT. Revert the change for now pending further in

svn commit: r197237 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet nfsclient

2009-09-15 Thread Qing Li
Author: qingli Date: Tue Sep 15 22:25:19 2009 New Revision: 197237 URL: http://svn.freebsd.org/changeset/base/197237 Log: MFC r197210, 197212, 197235 The bootp code installs an interface address and the nfs client module tries to install the same address again. This extra code is remo

svn commit: r197238 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet

2009-09-15 Thread Qing Li
Author: qingli Date: Tue Sep 15 22:37:17 2009 New Revision: 197238 URL: http://svn.freebsd.org/changeset/base/197238 Log: MFC r197225 This patch enables the node to respond to ARP requests for configured proxy ARP entries. Reviewed by: bz Approved by: re Modified: stable/8/s

svn commit: r197239 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net netinet netinet6

2009-09-15 Thread Qing Li
Author: qingli Date: Tue Sep 15 22:46:06 2009 New Revision: 197239 URL: http://svn.freebsd.org/changeset/base/197239 Log: MFC r197227 Self pointing routes are installed for configured interface addresses and address aliases. After an interface is brought down and brought back up again

Re: svn commit: r197210 - in head/sys: netinet nfsclient

2009-09-15 Thread Qing Li
cklem wrote: > > > On Tue, 15 Sep 2009, Bjoern A. Zeeb wrote: > >> On Tue, 15 Sep 2009, Qing Li wrote: >> >>> Author: qingli >>> Date: Tue Sep 15 01:01:03 2009 >>> New Revision: 197210 >>> URL: http://svn.freebsd.org/changeset/base/197210 &

svn commit: r197364 - head/sys/net

2009-09-20 Thread Qing Li
Author: qingli Date: Sun Sep 20 17:22:19 2009 New Revision: 197364 URL: http://svn.freebsd.org/changeset/base/197364 Log: A wrong variable is used when setting up the interface address route, which broke source address selection in some code paths. Submitted by: noted by bz Reviewed b

svn commit: r197365 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

2009-09-20 Thread Qing Li
Author: qingli Date: Sun Sep 20 17:46:56 2009 New Revision: 197365 URL: http://svn.freebsd.org/changeset/base/197365 Log: MFC r197364 A wrong variable is used when setting up the interface address route, which broke source address selection in some code paths. Submitted by: noted

svn commit: r197687 - head/sys/net

2009-10-01 Thread Qing Li
Author: qingli Date: Thu Oct 1 20:32:29 2009 New Revision: 197687 URL: http://svn.freebsd.org/changeset/base/197687 Log: The flow-table associates TCP/UDP flows and IP destinations with specific routes. When the routing table changes, for example, when a new route with a more specific prefi

Re: svn commit: r197687 - head/sys/net

2009-10-01 Thread Qing Li
I misinterpreted the "Submitted by:" field. I thought I put in the names of persons who reported the bug. Disregard the "Submitted by" field for this checkin. It's my code. Something breaks, my fault, email me ... -- Qing On Thu, Oct 1, 2009 at 1:32 PM, Qing Li

svn commit: r197695 - head/sys/netinet

2009-10-01 Thread Qing Li
Author: qingli Date: Fri Oct 2 01:34:55 2009 New Revision: 197695 URL: http://svn.freebsd.org/changeset/base/197695 Log: Previously, if an address alias is configured on an interface, and this address alias has a prefix matching that of another address configured on the same interface, then

svn commit: r197696 - head/sys/netinet

2009-10-01 Thread Qing Li
Author: qingli Date: Fri Oct 2 01:45:11 2009 New Revision: 197696 URL: http://svn.freebsd.org/changeset/base/197696 Log: Remove a log message from production code. This log message can be triggered by a misconfigured host that is sending out gratuious ARPs. This log message can also be trig

Re: svn commit: r197687 - head/sys/net

2009-10-02 Thread Qing Li
I believe this patch will fix your issue. In fact two other users of openvpn reports the exact same problem symptom. Please give it a try and let me know how it works out for you. -- Qing On Thu, Oct 1, 2009 at 11:22 PM, Tom Judge wrote: > Qing Li wrote: >> >> Author: qingli &

svn commit: r197810 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

2009-10-06 Thread Qing Li
Author: qingli Date: Tue Oct 6 18:47:02 2009 New Revision: 197810 URL: http://svn.freebsd.org/changeset/base/197810 Log: MFC r197687 The flow-table associates TCP/UDP flows and IP destinations with specific routes. When the routing table changes, for example, when a new route with a

svn commit: r197811 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet

2009-10-06 Thread Qing Li
Author: qingli Date: Tue Oct 6 19:44:44 2009 New Revision: 197811 URL: http://svn.freebsd.org/changeset/base/197811 Log: MFC 197695 Previously, if an address alias is configured on an interface, and this address alias has a prefix matching that of another address configured on the sa

svn commit: r197813 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet

2009-10-06 Thread Qing Li
Author: qingli Date: Tue Oct 6 20:33:02 2009 New Revision: 197813 URL: http://svn.freebsd.org/changeset/base/197813 Log: MFC r197696 Remove a log message from production code. This log message can be triggered by a misconfigured host that is sending out gratuious ARPs. This log messa

svn commit: r198111 - head/sys/netinet

2009-10-14 Thread Qing Li
Author: qingli Date: Thu Oct 15 06:12:04 2009 New Revision: 198111 URL: http://svn.freebsd.org/changeset/base/198111 Log: This patch fixes the following issues in the ARP operation: 1. There is a regression issue in the ARP code. The incomplete ARP entry was timing out too quickly (1 s

Re: svn commit: r198111 - head/sys/netinet

2009-10-14 Thread Qing Li
Forgot to mention the return code was incorrect. The function was returning EHOSTUNEACH when it should be returning EHOSTDOWN. This is also fixed by this patch. -- Qing On Wed, Oct 14, 2009 at 11:12 PM, Qing Li wrote: > Author: qingli > Date: Thu Oct 15 06:12:04 2009 > New Revisio

svn commit: r198298 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet

2009-10-20 Thread Qing Li
Author: qingli Date: Tue Oct 20 17:44:50 2009 New Revision: 198298 URL: http://svn.freebsd.org/changeset/base/198298 Log: MFC r198111 This patch fixes the following issues in the ARP operation: 1. There is a regression issue in the ARP code. The incomplete ARP entry was timing o

svn commit: r198301 - head/sys/netinet

2009-10-20 Thread Qing Li
Author: qingli Date: Tue Oct 20 17:55:42 2009 New Revision: 198301 URL: http://svn.freebsd.org/changeset/base/198301 Log: In the ARP callout timer expiration function, the current time_second is compared against the entry expiration time value (that was set based on time_second) to check if

svn commit: r198306 - head/sys/net

2009-10-20 Thread Qing Li
Author: qingli Date: Tue Oct 20 21:27:03 2009 New Revision: 198306 URL: http://svn.freebsd.org/changeset/base/198306 Log: The flow-table function flowtable_route_flush() may be called during system initialization time. Since the flow-table is designed to maintain per CPU flow cache, the exis

svn commit: r198308 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet

2009-10-20 Thread Qing Li
Author: qingli Date: Tue Oct 20 21:36:56 2009 New Revision: 198308 URL: http://svn.freebsd.org/changeset/base/198308 Log: MFC 198301 In the ARP callout timer expiration function, the current time_second is compared against the entry expiration time value (that was set based on time_se

Re: svn commit: r198301 - head/sys/netinet

2009-10-21 Thread Qing Li
I believe this patch will fix your crash. -- Qing On Wed, Oct 21, 2009 at 12:58 AM, Robert Watson wrote: > On Tue, 20 Oct 2009, Qing Li wrote: > >>  In the ARP callout timer expiration function, the current time_second >>  is compared against the entry expiration time value (

svn commit: r198353 - head/sys/net

2009-10-21 Thread Qing Li
Author: qingli Date: Thu Oct 22 00:32:01 2009 New Revision: 198353 URL: http://svn.freebsd.org/changeset/base/198353 Log: Verify "smp_started" is true before calling sched_bind() and sched_unbind(). Reviewed by: kmacy MFC after:3 days Modified: head/sys/net/flowtable.c Modified

svn commit: r198371 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

2009-10-22 Thread Qing Li
Author: qingli Date: Thu Oct 22 18:48:25 2009 New Revision: 198371 URL: http://svn.freebsd.org/changeset/base/198371 Log: MFC 198306 The flow-table function flowtable_route_flush() may be called during system initialization time. Since the flow-table is designed to maintain per CPU fl

svn commit: r198418 - in head/sys: netinet netinet6

2009-10-23 Thread Qing Li
Author: qingli Date: Fri Oct 23 18:27:34 2009 New Revision: 198418 URL: http://svn.freebsd.org/changeset/base/198418 Log: Use the correct option name in the preprocessor command to enable or disable diagnostic messages. Reviewed by: ru MFC after:3 days Modified: head/sys/netinet

svn commit: r198566 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

2009-10-28 Thread Qing Li
Author: qingli Date: Wed Oct 28 21:43:16 2009 New Revision: 198566 URL: http://svn.freebsd.org/changeset/base/198566 Log: MFC r198353 Verify "smp_started" is true before calling sched_bind() and sched_unbind(). Reviewed by: kmacy Modified: stable/8/sys/ (props changed) stab

svn commit: r198567 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet netinet6

2009-10-28 Thread Qing Li
Author: qingli Date: Wed Oct 28 21:45:25 2009 New Revision: 198567 URL: http://svn.freebsd.org/changeset/base/198567 Log: MFC r198418 Use the correct option name in the preprocessor command to enable or disable diagnostic messages. Reviewed by: ru Modified: stable/8/sys/ (pro

svn commit: r198568 - in releng/8.0/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

2009-10-28 Thread Qing Li
Author: qingli Date: Wed Oct 28 22:00:49 2009 New Revision: 198568 URL: http://svn.freebsd.org/changeset/base/198568 Log: MFC r198353 Verify "smp_started" is true before calling sched_bind() and sched_unbind(). Reviewed by: kmacy Approved by: re Modified: releng/8.0/sys/ (

svn commit: r225163 - head/sys/net

2011-08-24 Thread Qing Li
Author: qingli Date: Thu Aug 25 04:31:20 2011 New Revision: 225163 URL: http://svn.freebsd.org/changeset/base/225163 Log: When the RADIX_MPATH kernel option is enabled, the RADIX_MPATH code tries to find the first route node of an ECMP chain before executing the route command. If the system

svn commit: r225223 - head/sys/netinet

2011-08-27 Thread Qing Li
Author: qingli Date: Sun Aug 28 00:14:40 2011 New Revision: 225223 URL: http://svn.freebsd.org/changeset/base/225223 Log: When an interface address route is removed from the system, another route with the same prefix is searched for as a replacement. The current code did not bypass routes th

svn commit: r225405 - head/sys/dev/ixgbe

2011-09-05 Thread Qing Li
Author: qingli Date: Mon Sep 5 17:54:19 2011 New Revision: 225405 URL: http://svn.freebsd.org/changeset/base/225405 Log: The maximum read size of incoming packets is done in 1024-byte increments. The current code was rounding down the maximum frame size instead of routing up, resulting in a

svn commit: r225946 - head/sys/netinet

2011-10-03 Thread Qing Li
Author: qingli Date: Mon Oct 3 19:06:55 2011 New Revision: 225946 URL: http://svn.freebsd.org/changeset/base/225946 Log: This patch allows ARP to work properly in the presence of self-referencing routes. This patch is a rework of r223862. Reviewed by: bz, zec MFC after:5 days Mod

svn commit: r225947 - head/sys/netinet

2011-10-03 Thread Qing Li
Author: qingli Date: Mon Oct 3 19:51:18 2011 New Revision: 225947 URL: http://svn.freebsd.org/changeset/base/225947 Log: A system may have multiple physical interfaces, all of which are on the same prefix. Since a single route entry is installed for the prefix (without RADIX_MPATH), incomin

svn commit: r226040 - head/sys/netinet6

2011-10-05 Thread Qing Li
Author: qingli Date: Wed Oct 5 16:27:11 2011 New Revision: 226040 URL: http://svn.freebsd.org/changeset/base/226040 Log: The IFA_RTSELF instead of the IFA_ROUTE flag should be checked to determine if a loopback route should be installed for an interface IPv6 address. Another condition is th

Re: svn commit: r226040 - head/sys/netinet6

2011-10-05 Thread Qing Li
, Oct 5, 2011 at 4:21 PM, Bjoern A. Zeeb wrote: > > On 5. Oct 2011, at 16:27 , Qing Li wrote: > >> Author: qingli >> Date: Wed Oct  5 16:27:11 2011 >> New Revision: 226040 >> URL: http://svn.freebsd.org/changeset/base/226040 >> >> Log: >>  The IFA_RTS

svn commit: r226114 - head/sys/netinet

2011-10-07 Thread Qing Li
Author: qingli Date: Fri Oct 7 18:01:34 2011 New Revision: 226114 URL: http://svn.freebsd.org/changeset/base/226114 Log: Remove the reference held on the loopback route when the interface address is being deleted. Only the last reference holder deletes the loopback route. All other delete o

svn commit: r226120 - head/sys/netinet

2011-10-07 Thread Qing Li
Author: qingli Date: Fri Oct 7 22:22:19 2011 New Revision: 226120 URL: http://svn.freebsd.org/changeset/base/226120 Log: Do not try removing an ARP entry associated with a given interface address if that interface does not support ARP. Otherwise the system will generate error messages unnec

Re: svn commit: r225947 - head/sys/netinet

2011-10-09 Thread Qing Li
Hi Gleb, > > On Mon, Oct 03, 2011 at 07:51:19PM +, Qing Li wrote: > Q> Author: qingli > Q> Date: Mon Oct  3 19:51:18 2011 > Q> New Revision: 225947 > Q> URL: http://svn.freebsd.org/changeset/base/225947 > Q> > Q> Log: > Q>   A system may have m

Re: svn commit: r225947 - head/sys/netinet

2011-10-10 Thread Qing Li
Okay, now I know what's confusing you ... it's that bug I introduced :-) The 2nd "if()" check on the RTF_GATEWAY flag should have been an "else if()". In a nutshell, the logic is any indirect route should fail the check, except for that special host route. Attached is the rework of that part of

svn commit: r226224 - head/sys/netinet

2011-10-10 Thread Qing Li
Author: qingli Date: Mon Oct 10 17:41:11 2011 New Revision: 226224 URL: http://svn.freebsd.org/changeset/base/226224 Log: All indirect routes will fail the rtcheck, except for a special host route where the destination IP and the gateway IP is the same. This special case handling is only mea

svn commit: r226230 - stable/8/sys/netinet

2011-10-10 Thread Qing Li
Author: qingli Date: Mon Oct 10 19:41:00 2011 New Revision: 226230 URL: http://svn.freebsd.org/changeset/base/226230 Log: MFC 225946 This patch allows ARP to work properly in the presence of self-referencing routes. This patch is a rework of r223862. Reviewed by: bz, zec Modified:

Re: svn commit: r226224 - head/sys/netinet

2011-10-10 Thread Qing Li
MFC 225946 is the original patch, 225947 messed up the logic a bit while putting in the fix for another issue. 226224 is the fix to 225947, which I will MFC tomorrow. --Qing 2011/10/10 Gleb Smirnoff : >  Qing, > > On Mon, Oct 10, 2011 at 05:41:11PM +0000, Qing Li wrote: > Q> Aut

svn commit: r226232 - stable/8/sys/netinet

2011-10-10 Thread Qing Li
Author: qingli Date: Mon Oct 10 20:54:20 2011 New Revision: 226232 URL: http://svn.freebsd.org/changeset/base/226232 Log: MFC 225947 A system may have multiple physical interfaces, all of which are on the same prefix. Since a single route entry is installed for the prefix (without RADIX

svn commit: r226235 - in stable/8/sys: net netinet netinet6

2011-10-10 Thread Qing Li
Author: qingli Date: Mon Oct 10 21:34:55 2011 New Revision: 226235 URL: http://svn.freebsd.org/changeset/base/226235 Log: MFC 222143 The statically configured (permanent) ARP entries are removed when an interface is brought down, even though the interface address is still valid. This pa

svn commit: r226236 - stable/8/sys/netinet

2011-10-10 Thread Qing Li
Author: qingli Date: Mon Oct 10 21:38:19 2011 New Revision: 226236 URL: http://svn.freebsd.org/changeset/base/226236 Log: MFC 222438 Supply the LLE_STATIC flag bit to in_ifscurb() when scrubbing interface address so that proper clean up will take place in the routing code. This patch fi

svn commit: r226237 - stable/8/sys/netinet

2011-10-10 Thread Qing Li
Author: qingli Date: Mon Oct 10 21:41:34 2011 New Revision: 226237 URL: http://svn.freebsd.org/changeset/base/226237 Log: MFC 226114 Remove the reference held on the loopback route when the interface address is being deleted. Only the last reference holder deletes the loopback route. Al

svn commit: r226238 - stable/8/sys/netinet

2011-10-10 Thread Qing Li
Author: qingli Date: Mon Oct 10 21:43:53 2011 New Revision: 226238 URL: http://svn.freebsd.org/changeset/base/226238 Log: MFC 226120 Do not try removing an ARP entry associated with a given interface address if that interface does not support ARP. Otherwise the system will generate erro

svn commit: r226239 - stable/8/sys/netinet

2011-10-10 Thread Qing Li
Author: qingli Date: Mon Oct 10 21:46:37 2011 New Revision: 226239 URL: http://svn.freebsd.org/changeset/base/226239 Log: MFC 225223 When an interface address route is removed from the system, another route with the same prefix is searched for as a replacement. The current code did not

svn commit: r226240 - stable/8/sys/netinet6

2011-10-10 Thread Qing Li
Author: qingli Date: Mon Oct 10 21:48:40 2011 New Revision: 226240 URL: http://svn.freebsd.org/changeset/base/226240 Log: MFC 226040 The IFA_RTSELF instead of the IFA_ROUTE flag should be checked to determine if a loopback route should be installed for an interface IPv6 address. Another

svn commit: r226241 - stable/8/sys/net

2011-10-10 Thread Qing Li
Author: qingli Date: Mon Oct 10 21:54:19 2011 New Revision: 226241 URL: http://svn.freebsd.org/changeset/base/226241 Log: MFC 225163 When the RADIX_MPATH kernel option is enabled, the RADIX_MPATH code tries to find the first route node of an ECMP chain before executing the route command

svn commit: r226287 - stable/9/sys/netinet

2011-10-12 Thread Qing Li
Author: qingli Date: Wed Oct 12 08:08:08 2011 New Revision: 226287 URL: http://svn.freebsd.org/changeset/base/226287 Log: MFC 225946 This patch allows ARP to work properly in the presence of self-referencing routes. This patch is a rework of r223862. Reviewed by: bz, zec Approved

svn commit: r226326 - stable/9/sys/netinet

2011-10-12 Thread Qing Li
Author: qingli Date: Wed Oct 12 21:02:58 2011 New Revision: 226326 URL: http://svn.freebsd.org/changeset/base/226326 Log: MFC 225947 A system may have multiple physical interfaces, all of which are on the same prefix. Since a single route entry is installed for the prefix (without RADIX

svn commit: r226330 - stable/8/sys/netinet

2011-10-12 Thread Qing Li
Author: qingli Date: Thu Oct 13 00:37:39 2011 New Revision: 226330 URL: http://svn.freebsd.org/changeset/base/226330 Log: MFC 226224 All indirect routes will fail the rtcheck, except for a special host route where the destination IP and the gateway IP is the same. This special case hand

svn commit: r226331 - stable/9/sys/netinet

2011-10-12 Thread Qing Li
Author: qingli Date: Thu Oct 13 00:44:24 2011 New Revision: 226331 URL: http://svn.freebsd.org/changeset/base/226331 Log: MFC 226224 All indirect routes will fail the rtcheck, except for a special host route where the destination IP and the gateway IP is the same. This special case hand

svn commit: r226332 - stable/9/sys/netinet6

2011-10-12 Thread Qing Li
Author: qingli Date: Thu Oct 13 03:21:48 2011 New Revision: 226332 URL: http://svn.freebsd.org/changeset/base/226332 Log: MFC 226040 The IFA_RTSELF instead of the IFA_ROUTE flag should be checked to determine if a loopback route should be installed for an interface IPv6 address. Another

svn commit: r226333 - stable/9/sys/netinet

2011-10-13 Thread Qing Li
Author: qingli Date: Thu Oct 13 08:26:23 2011 New Revision: 226333 URL: http://svn.freebsd.org/changeset/base/226333 Log: MFC 226114 Remove the reference held on the loopback route when the interface address is being deleted. Only the last reference holder deletes the loopback route. Al

svn commit: r226337 - stable/9/sys/netinet

2011-10-13 Thread Qing Li
Author: qingli Date: Thu Oct 13 09:21:49 2011 New Revision: 226337 URL: http://svn.freebsd.org/changeset/base/226337 Log: MFC 226120 PR: kern/159602 Submitted by: pluknet Approved by: re (kib) Modified: stable/9/sys/netinet/in.c Directory Properties: stable/9/sys/ (pro

svn commit: r226451 - head/sys/netinet6

2011-10-16 Thread Qing Li
Author: qingli Date: Sun Oct 16 22:15:13 2011 New Revision: 226451 URL: http://svn.freebsd.org/changeset/base/226451 Log: The IPv6 code was influx at the time of r196865 due to the L2/L3 separation rewrite changes. r196865 was committed to fix a scope violation problem in the following test

svn commit: r226453 - head/sys/netinet6

2011-10-16 Thread Qing Li
Author: qingli Date: Sun Oct 16 22:24:04 2011 New Revision: 226453 URL: http://svn.freebsd.org/changeset/base/226453 Log: The code change made in r226040 was incomplete and resulted in routes such as fe80::1%lo0 no being installed. This patch completes the original intended fix. Reviewe

svn commit: r226455 - stable/9/sys/netinet6

2011-10-16 Thread Qing Li
Author: qingli Date: Mon Oct 17 03:35:24 2011 New Revision: 226455 URL: http://svn.freebsd.org/changeset/base/226455 Log: MFC 226453 The code change made in r226040 was incomplete and resulted in routes such as fe80::1%lo0 no being installed. This patch completes the original intended f

svn commit: r226485 - stable/8/sys/netinet6

2011-10-17 Thread Qing Li
Author: qingli Date: Tue Oct 18 01:56:43 2011 New Revision: 226485 URL: http://svn.freebsd.org/changeset/base/226485 Log: MFC 226453 The code change made in r226040 was incomplete and resulted in routes such as fe80::1%lo0 no being installed. This patch completes the original intended f

svn commit: r226710 - head/sys/net

2011-10-24 Thread Qing Li
Author: qingli Date: Tue Oct 25 00:34:39 2011 New Revision: 226710 URL: http://svn.freebsd.org/changeset/base/226710 Log: The host-id/interface-id can have a specific value and is properly masked out when adding a prefix route through the "route" command. However, when deleting the route, si

svn commit: r226713 - head/sys/netinet

2011-10-24 Thread Qing Li
Author: qingli Date: Tue Oct 25 04:06:29 2011 New Revision: 226713 URL: http://svn.freebsd.org/changeset/base/226713 Log: Exclude host routes when checking for prefix coverage on multiple interfaces. A host route has a NULL mask so check for that condition. I have also been told by developer

svn commit: r226877 - stable/8/sys/netinet

2011-10-27 Thread Qing Li
Author: qingli Date: Fri Oct 28 03:58:33 2011 New Revision: 226877 URL: http://svn.freebsd.org/changeset/base/226877 Log: MFC 226713 Exclude host routes when checking for prefix coverage on multiple interfaces. A host route has a NULL mask so check for that condition. I have also been t

svn commit: r226878 - stable/8/sys/netinet6

2011-10-27 Thread Qing Li
Author: qingli Date: Fri Oct 28 04:04:21 2011 New Revision: 226878 URL: http://svn.freebsd.org/changeset/base/226878 Log: MFC 226451 The IPv6 code was influx at the time of r196865 due to the L2/L3 separation rewrite changes. r196865 was committed to fix a scope violation problem in the

svn commit: r227002 - stable/9/sys/netinet

2011-11-01 Thread Qing Li
Author: qingli Date: Tue Nov 1 18:29:06 2011 New Revision: 227002 URL: http://svn.freebsd.org/changeset/base/227002 Log: MFC 226713 Exclude host routes when checking for prefix coverage on multiple interfaces. A host route has a NULL mask so check for that condition. I have also been t

svn commit: r227003 - stable/8/sys/net

2011-11-01 Thread Qing Li
Author: qingli Date: Tue Nov 1 19:29:03 2011 New Revision: 227003 URL: http://svn.freebsd.org/changeset/base/227003 Log: MFC 226710 The host-id/interface-id can have a specific value and is properly masked out when adding a prefix route through the "route" command. However, when deleti

svn commit: r227005 - stable/9/sys/netinet6

2011-11-01 Thread Qing Li
Author: qingli Date: Tue Nov 1 21:21:36 2011 New Revision: 227005 URL: http://svn.freebsd.org/changeset/base/227005 Log: MFC 226451 The IPv6 code was influx at the time of r196865 due to the L2/L3 separation rewrite changes. r196865 was committed to fix a scope violation problem in the

svn commit: r227008 - stable/9/sys/net

2011-11-01 Thread Qing Li
Author: qingli Date: Tue Nov 1 22:22:46 2011 New Revision: 227008 URL: http://svn.freebsd.org/changeset/base/227008 Log: MFC 226710 The host-id/interface-id can have a specific value and is properly masked out when adding a prefix route through the "route" command. However, when deleti

svn commit: r227460 - head/sys/netinet6

2011-11-11 Thread Qing Li
Author: qingli Date: Fri Nov 11 23:22:38 2011 New Revision: 227460 URL: http://svn.freebsd.org/changeset/base/227460 Log: A default route learned from the RAs could be deleted manually after its installation. This removal may be accidental and can prevent the default route from being install

  1   2   >