Re: svn commit: r284049 - in head/sys: dev/ixl modules/ixl modules/ixlv

2015-06-08 Thread Jack Vogel
I did not realize this, but there is an update utility on our public site, this will update your hardware to the latest released version of FW provided its an OEM generic product, if you have another OEM specific adapter (say HP or Dell...), then you will need to get the update from them.

Re: svn commit: r284049 - in head/sys: dev/ixl modules/ixl modules/ixlv

2015-06-05 Thread Jack Vogel
Well, you know me don't you :) Larger customers will have some kind of field engineer to contact, but if anyone here, ahem, doesn't you can work with me to get what you need. Cheers, Jack On Fri, Jun 5, 2015 at 4:07 PM, Adrian Chadd adr...@freebsd.org wrote: Hi! Is there any public

Re: svn commit: r280182 - in head/sys: amd64/conf conf dev/ixgbe modules/ix modules/ixgbe modules/ixv

2015-03-18 Thread Jack Vogel
OK, thanks for pointing that out, I'll include them. On Wed, Mar 18, 2015 at 8:20 AM, Nathan Whitehorn nwhiteh...@freebsd.org wrote: On 03/17/15 11:32, Jack F Vogel wrote: Author: jfv Date: Tue Mar 17 18:32:28 2015 New Revision: 280182 URL:

Re: svn commit: r280182 - in head/sys: amd64/conf conf dev/ixgbe modules/ix modules/ixgbe modules/ixv

2015-03-17 Thread Jack Vogel
Am on it fix coming. On Tue, Mar 17, 2015 at 12:03 PM, Gleb Smirnoff gleb...@freebsd.org wrote: On Tue, Mar 17, 2015 at 06:32:29PM +, Jack F Vogel wrote: J Author: jfv J Date: Tue Mar 17 18:32:28 2015 J New Revision: 280182 J URL: https://svnweb.freebsd.org/changeset/base/280182

Re: svn commit: r277084 - in head/sys: dev/ixl modules/ixl modules/ixlv

2015-01-12 Thread Jack Vogel
Opps, missing chunk, fix coming. Jack On Mon, Jan 12, 2015 at 11:47 AM, Bjoern A. Zeeb b...@freebsd.org wrote: On 12 Jan 2015, at 18:43 , Jack F Vogel j...@freebsd.org wrote: Author: jfv Date: Mon Jan 12 18:43:34 2015 New Revision: 277084 URL:

Re: svn commit: r275431 - in head/sys/dev: e1000 ixgbe

2014-12-02 Thread Jack Vogel
Just to make it clear, I am not opposed to what this code was trying to do, in fact I think its a pretty cool idea, but I think it can be implemented more cleanly. Eric and myself will be discussing the details. Jack On Tue, Dec 2, 2014 at 3:02 PM, Jack F Vogel j...@freebsd.org wrote:

Re: svn commit: r275136 - in head/sys: dev/e1000 dev/ixgbe kern sys

2014-12-01 Thread Jack Vogel
There is no mystery about who's drivers these are, and its not like it would take a lot of effort to figure out ownership and ask us for review. Remove this commit until I have had time to look it over! Jack On Mon, Dec 1, 2014 at 7:56 AM, Alfred Perlstein bri...@mu.org wrote: On Dec 1,

Re: svn commit: r275136 - in head/sys: dev/e1000 dev/ixgbe kern sys

2014-12-01 Thread Jack Vogel
Really, and did I say that I approved, because I do not recall the event? Jack On Mon, Dec 1, 2014 at 8:08 AM, Alfred Perlstein bri...@mu.org wrote: Jack you were asked. Please see the review system. Sent from my iPhone On Dec 1, 2014, at 8:05 AM, Jack Vogel jfvo...@gmail.com wrote

Re: svn commit: r275136 - in head/sys: dev/e1000 dev/ixgbe kern sys

2014-12-01 Thread Jack Vogel
Not taking it personally, in this case I see some style things I don't like, and I'm not at all clear why this is even necessary, what the old way of doing queue config was missing for instance? Thanks Steve, Jack On Mon, Dec 1, 2014 at 11:04 AM, Steven Hartland ste...@multiplay.co.uk wrote:

Re: svn commit: r270806 - head/sys/dev/ixl

2014-08-29 Thread Jack Vogel
I certainly agree that it would be a bit ridiculous to do 40G in a 32bit environment :) Jack On Fri, Aug 29, 2014 at 10:14 AM, Konstantin Belousov kostik...@gmail.com wrote: On Fri, Aug 29, 2014 at 12:40:01PM +, Bjoern A. Zeeb wrote: Author: bz Date: Fri Aug 29 12:40:01 2014 New

Re: svn commit: r270806 - head/sys/dev/ixl

2014-08-29 Thread Jack Vogel
OH, and I just asked the team here, and found out we explicitly do NOT support any 32 bit environment for this driver. Jack On Fri, Aug 29, 2014 at 10:49 AM, Jack Vogel jfvo...@gmail.com wrote: I certainly agree that it would be a bit ridiculous to do 40G in a 32bit environment :) Jack

Re: svn commit: r270631 - in stable/10/sys: conf dev/ixl modules/ixl modules/ixlv

2014-08-25 Thread Jack Vogel
Not yet, only the README, there will be a manual page coming soon I hope. Jack On Mon, Aug 25, 2014 at 3:19 PM, Glen Barber g...@freebsd.org wrote: On Mon, Aug 25, 2014 at 10:04:29PM +, Jack F Vogel wrote: Author: jfv Date: Mon Aug 25 22:04:29 2014 New Revision: 270631 URL:

Re: svn commit: r266423 - in head/sys: conf dev/i40e modules/i40e

2014-05-20 Thread Jack Vogel
If you don't like the name there's this wonderful feature of ifconfig ifconfig i40e0 name eth0 (or whatever pleases you...) Oh and Bruce, I did run into the string length issue, so with this driver the queues are all named 'q%d', I might go back and change the earlier drivers. I found the 'too

Re: svn commit: r259642 - head/sys/netinet

2013-12-20 Thread Jack Vogel
I agree with Gleb, ifdef 0 is silly, after all, that's why we have source history, its not like the offending code is gone forever :) So I guess its both of us muttering Gleb :) Jack On Fri, Dec 20, 2013 at 9:05 AM, Adrian Chadd adr...@freebsd.org wrote: On 20 December 2013 00:44, Gleb

Re: svn commit: r247430 - in stable/8/sys: conf dev/e1000 modules/em modules/igb

2013-02-27 Thread Jack Vogel
Oh, that's odd, then HEAD should be broken too, do you have more detail? Jack On Wed, Feb 27, 2013 at 6:23 PM, Glen Barber g...@freebsd.org wrote: Jack, This commit seems to break the build for at least powerpc and sparc64. Glen On Thu, Feb 28, 2013 at 12:22:04AM +, Jack F Vogel

Re: svn commit: r247430 - in stable/8/sys: conf dev/e1000 modules/em modules/igb

2013-02-27 Thread Jack Vogel
LOL, I would see the messages just as I sent this, never mind. Jack On Wed, Feb 27, 2013 at 9:39 PM, Jack Vogel jfvo...@gmail.com wrote: Oh, that's odd, then HEAD should be broken too, do you have more detail? Jack On Wed, Feb 27, 2013 at 6:23 PM, Glen Barber g...@freebsd.org wrote

Re: svn commit: r247430 - in stable/8/sys: conf dev/e1000 modules/em modules/igb

2013-02-27 Thread Jack Vogel
I am checking with Luigi to see if an MFC of his code is a viable solution, if not I will change my core code. Stay tuned... Jack On Wed, Feb 27, 2013 at 9:41 PM, Jack Vogel jfvo...@gmail.com wrote: LOL, I would see the messages just as I sent this, never mind. Jack On Wed, Feb 27, 2013

Re: svn commit: r247035 - head/sys/dev/ixgbe

2013-02-20 Thread Jack Vogel
OK, this change must be backed out. This was not run past me, and this is a shared code file, that means its code that we license in both GPL, BSD, and closed source licensing, and thus we CANNOT accept changes without special handling. Further, I do not author this code, its done by another team

Re: svn commit: r247035 - head/sys/dev/ixgbe

2013-02-20 Thread Jack Vogel
No, I'm not confused, I am the owner of the driver, and keep the FreeBSD code and the Intel code in sync, any changes to the code should be run by me first. Jack On Wed, Feb 20, 2013 at 10:57 AM, Dag-Erling Smørgrav d...@des.no wrote: Jack Vogel jfvo...@gmail.com writes: OK, this change

Re: svn commit: r247035 - head/sys/dev/ixgbe

2013-02-20 Thread Jack Vogel
My attitude? And what part of courtesy were you missing, did I make comments about you or your behavior. At this point I'd say you owe me an apology as well as the uncommit. Jack On Wed, Feb 20, 2013 at 11:07 AM, Dag-Erling Smørgrav d...@des.no wrote: Juli Mallett jmall...@freebsd.org writes:

Re: svn commit: r243714 - in head/sys/dev: ixgbe netmap

2012-12-01 Thread Jack Vogel
On Sat, Dec 1, 2012 at 12:40 AM, Andre Oppermann an...@freebsd.org wrote: On 30.11.2012 23:19, Jack F Vogel wrote: Author: jfv Date: Fri Nov 30 22:19:18 2012 New Revision: 243714 URL: http://svnweb.freebsd.org/**changeset/base/243714http://svnweb.freebsd.org/changeset/base/243714 Log:

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-31 Thread Jack Vogel
Yes, I agree John, that was ugly, I'm already taking care of it with my changes, I'll send you a copy to check out. Jack On Tue, Jul 31, 2012 at 9:12 AM, John Baldwin j...@freebsd.org wrote: On Tuesday, July 31, 2012 11:16:07 am Garrett Cooper wrote: On Tue, Jul 31, 2012 at 8:13 AM, Andrey

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-31 Thread Jack Vogel
|CTLFLAG_RW, limit, value, description); } -#endif On Tue, Jul 31, 2012 at 9:29 AM, Garrett Cooper yaneg...@gmail.com wrote: On Tue, Jul 31, 2012 at 9:20 AM, Jack Vogel jfvo...@gmail.com wrote: Yes, I agree John, that was ugly, I'm already taking care of it with my changes, I'll send you a copy

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-31 Thread Jack Vogel
Right, that code got left in lem when i split it off from em by mistake, just cleaning that up. Will commit this then. Jack On Tue, Jul 31, 2012 at 11:09 AM, John Baldwin j...@freebsd.org wrote: On Tuesday, July 31, 2012 1:46:59 pm Jack Vogel wrote: No, like so: This looks good to me

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-30 Thread Jack Vogel
: http://svn.freebsd.org/changeset/base/238765 Log: Use legacy interrupts as a default. This gives up to 10% speedup when used in qemu (and this driver is for non-PCIe cards, so probably its largest use is in virtualized environments). Approved by:Jack Vogel MFC after

Re: svn commit: r236729 - head/sys/dev/ixgbe

2012-06-07 Thread Jack Vogel
Just because the Linux driver does something does not mean that FreeBSD should, this may be OK, but it isn't something automatic, and with a thing like this you should at least have asked me first... please next time? Jack On Thu, Jun 7, 2012 at 3:57 PM, Maksim Yevmenkin e...@freebsd.org wrote:

Re: svn commit: r235527 - stable/9/sys/dev/e1000

2012-05-17 Thread Jack Vogel
Cool, thanks Luigi! Jack On Thu, May 17, 2012 at 8:24 AM, Luigi Rizzo ri...@iet.unipi.it wrote: On Thu, May 17, 2012 at 03:51:14PM +0200, Luigi Rizzo wrote: ... Hi Jack, Some of the netmap-related changes in this merge don't work, at least not for the LINT kernels: should be

Re: svn commit: r223350 - head/sys/dev/e1000

2011-06-21 Thread Jack Vogel
LOL, the old adage is true, you just can't please all the people... :) The way the code now is it assigns a default, but you could still have a loader entry that would change it for all adapters if you wanted to, but ok, if you prefer the older for this. What other globals do you think should be

Re: svn commit: r223350 - head/sys/dev/e1000

2011-06-21 Thread Jack Vogel
...@palisadesystems.comwrote: On Jun 21, 2011, at 11:07 AM, Jack Vogel wrote: LOL, the old adage is true, you just can't please all the people... :) The way the code now is it assigns a default, but you could still have a loader entry that would change it for all adapters if you wanted to, but ok

Re: svn commit: r222588 - head/sys/dev/ixgbe

2011-06-01 Thread Jack Vogel
Opps, will fix directly, forgot about a last minute change to ixv.c Jack On Wed, Jun 1, 2011 at 9:32 PM, Martin Wilke m...@freebsd.org wrote: that commit break the build .. -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc -I. -I/usr/src/sys

Re: svn commit: r221789 - in head/sys/dev: ahci ata ata/chipsets ichsmb ichwd sound/pci/hda

2011-05-11 Thread Jack Vogel
Hmmm, thanks for pointing that out, will check on Seth's email, clearly one or the other is wrong. Jack On Wed, May 11, 2011 at 4:59 PM, Garrett Cooper yaneg...@gmail.com wrote: On May 11, 2011, at 4:31 PM, Jack F Vogel wrote: +#define HDA_INTEL_PPT1

Re: svn commit: r219753 - head/sys/dev/e1000

2011-03-18 Thread Jack Vogel
The problem is that the shared code is delivered to me as a component. I generally do try to filter it a little, but if I start diverging from the internal component files, then I just introduce a never-ending task for myself to do that. It also is tested in house as a complete component, so every

Re: svn commit: r218581 - head/sys/dev/e1000

2011-02-11 Thread Jack Vogel
Ya, I just saw that, I think I will Bjoern, only because its gonna be a problem the next time I check in shared code, I don't really even own the stuff, when my internal build runs it just filters the defines in the stuff according to my needs, but doesn't directly change anything. I was gonna

Re: svn commit: r215922 - in stable/7/sys: conf dev/e1000 modules/em modules/igb

2010-11-26 Thread Jack Vogel
Working all day on my holidays... got tired and forgot the svn add, its fixed. Jack On Fri, Nov 26, 2010 at 7:35 PM, Lawrence Stewart lstew...@freebsd.orgwrote: Hi Jack, On 11/27/10 12:09, Jack F Vogel wrote: Author: jfv Date: Sat Nov 27 01:09:54 2010 New Revision: 215922 URL:

Re: svn commit: r214363 - head/sys/dev/e1000

2010-10-25 Thread Jack Vogel
Always forget a couple items when I list changes and since some people are about such things let me add: - Also add 3 tier mbuf cluster size, based on the MTU, so as you increase beyond standard you go 4K, and once over that you get 9K clusters now. - Add a sysctl to change the

Re: svn commit: r209611 - head/sys/dev/e1000

2010-06-30 Thread Jack Vogel
Yes, work is in progress to add it to ixgbe as well, it turned out to be a bit messier because the owners of the shared code did things a bit differently. I am still designing it so that its just a special case in the main driver, this is different than Linux which made both of them as seperate

Re: svn commit: r209609 - head/sys/dev/ixgbe

2010-06-30 Thread Jack Vogel
It wont work as a delta, I figured just putting the new delta over it was ok, but if you think it should be reverted then by all means... Jack On Wed, Jun 30, 2010 at 2:39 PM, John Baldwin j...@freebsd.org wrote: On Wednesday 30 June 2010 12:28:28 pm Jack F Vogel wrote: Author: jfv Date:

Re: svn commit: r209611 - head/sys/dev/e1000

2010-06-30 Thread Jack Vogel
On Wed, Jun 30, 2010 at 2:50 PM, Julian Elischer jul...@elischer.orgwrote: On 6/30/10 10:26 AM, Jack F Vogel wrote: Author: jfv Date: Wed Jun 30 17:26:47 2010 New Revision: 209611 URL: http://svn.freebsd.org/changeset/base/209611 Log: SR-IOV support added to igb What this provides

Re: svn commit: r209622 - head/sys/dev/ixgbe

2010-06-30 Thread Jack Vogel
I went to a LOT of trouble setting up a mirror at home and just as I went to commit the change its updated. While I understand the good intentions, please don't do this again. If I had been unresponsive for days or something I understand, but its been hours, and I was fixing it. Jack On Wed,

Re: svn commit: r209241 - head/sys/dev/e1000

2010-06-16 Thread Jack Vogel
Awesome, look forward to checking this out, thanks much George!! Jack On Wed, Jun 16, 2010 at 10:36 AM, George V. Neville-Neil g...@freebsd.orgwrote: Author: gnn Date: Wed Jun 16 17:36:53 2010 New Revision: 209241 URL: http://svn.freebsd.org/changeset/base/209241 Log: Move statistics

Re: svn commit: r209068 - head/sys/dev/e1000

2010-06-15 Thread Jack Vogel
Ahhh, thanks for report John, will fix that asap. Jack On Tue, Jun 15, 2010 at 12:49 PM, John Baldwin j...@freebsd.org wrote: On Friday 11 June 2010 4:54:27 pm Jack F Vogel wrote: Author: jfv Date: Fri Jun 11 20:54:27 2010 New Revision: 209068 URL:

Re: svn commit: r209060 - head/sys/dev/ixgbe

2010-06-11 Thread Jack Vogel
HM, I put in a change in response to some people having problems with mbuf resources, it seemed to work ok, but now i'm kinda concerned. Does this happen every time you bring the device up? In the routine 'ixgbe_setup_receive_ring()' I changed a couple of M_NOWAIT's to M_WAITOK, thinking

Re: svn commit: r209060 - head/sys/dev/ixgbe

2010-06-11 Thread Jack Vogel
Odd though, because that code is in the driver on a system with 16 cores and I'm not hearing about any problem from my test engineer. Jack On Fri, Jun 11, 2010 at 1:13 PM, Bjoern A. Zeeb b...@freebsd.org wrote: On Fri, 11 Jun 2010, Jack Vogel wrote: Hi, HM, I put in a change

Re: svn commit: r209060 - head/sys/dev/ixgbe

2010-06-11 Thread Jack Vogel
OK, that's kinda what I was guessing... Damn, guess I'll have to change it back. Thanks for letting me know. Jack On Fri, Jun 11, 2010 at 1:23 PM, Bjoern A. Zeeb b...@freebsd.org wrote: On Fri, 11 Jun 2010, Jack Vogel wrote: Odd though, because that code is in the driver on a system

Re: svn commit: r209060 - head/sys/dev/ixgbe

2010-06-11 Thread Jack Vogel
On Fri, Jun 11, 2010 at 1:27 PM, Jack Vogel jfvo...@gmail.com wrote: On Fri, Jun 11, 2010 at 1:23 PM, Bjoern A. Zeeb b...@freebsd.org wrote: On Fri, 11 Jun 2010, Jack Vogel wrote: Odd though, because that code is in the driver on a system with 16 cores and I'm not hearing about any

Re: svn commit: r209068 - head/sys/dev/e1000

2010-06-11 Thread Jack Vogel
LOL, I'm sorry John, I actually did put them into my local source, I dont know what happened, just not my day :( Jack On Fri, Jun 11, 2010 at 2:25 PM, John Baldwin j...@freebsd.org wrote: On Friday 11 June 2010 4:54:27 pm Jack F Vogel wrote: Author: jfv Date: Fri Jun 11 20:54:27 2010

Re: svn commit: r206215 - in stable/8/sys/modules: em ixgbe

2010-04-05 Thread Jack Vogel
Its been without the if_ prefix for a couple years :) However if enough people's sense of propriety is offended I suppose I could change it. As for adding it to the modules/Makefile, the main reason it was not was that the users of 10G were very small, but that is changing so I suppose its time

Re: svn commit: r205904 - head/sys/dev/ixgbe

2010-03-30 Thread Jack Vogel
Mad dash fixes always are a bad idea, lol. Thanks, correcting it. Jack On Tue, Mar 30, 2010 at 12:34 PM, Koop Mast k...@freebsd.org wrote: On Tue, 2010-03-30 at 19:09 +, Jack F Vogel wrote: Modified: head/sys/dev/ixgbe/ixgbe.c head/sys/dev/ixgbe/ixgbe.h Modified:

Re: svn commit: r200268 - head/sys/dev/e1000

2009-12-14 Thread Jack Vogel
Fixed in the commit today. Test again please. Jack On Sun, Dec 13, 2009 at 8:49 PM, Lawrence Stewart lstew...@freebsd.orgwrote: [picking a recent e1000 commit] Hi Jack, I'm getting the following panic on head r200376 on my HP DC7800 work desktop: mtx_lock() of spin mutex

Re: svn commit: r200523 - head/sys/dev/e1000

2009-12-14 Thread Jack Vogel
Well, its a unique lock in the shared code, and I was already naming the other em locks, if there is some big loss in my doing that I don't have any big emotional investment in them being that way :) Jack On Mon, Dec 14, 2009 at 11:31 AM, John Baldwin j...@freebsd.org wrote: On Monday 14

Re: svn commit: r196387 - in stable/8/sys: . dev/e1000

2009-08-19 Thread Jack Vogel
Thanks for doing this for me Xin. Jack On Wed, Aug 19, 2009 at 11:08 AM, Xin LI delp...@freebsd.org wrote: Author: delphij Date: Wed Aug 19 18:08:50 2009 New Revision: 196387 URL: http://svn.freebsd.org/changeset/base/196387 Log: MFC r196386: Temporarily enhance em(4) and igb(4)

Re: svn commit: r194925 - head/sys/dev/e1000

2009-06-25 Thread Jack Vogel
Oh, hmmm, wasn't aware of that, I'll take a look at it today. Thanks John, Jack On Thu, Jun 25, 2009 at 5:21 AM, John Baldwin j...@freebsd.org wrote: On Wednesday 24 June 2009 6:16:02 pm Jack F Vogel wrote: Author: jfv Date: Wed Jun 24 22:16:02 2009 New Revision: 194925 URL:

Re: svn commit: r191566 - head/sys/dev/e1000

2009-04-27 Thread Jack Vogel
DUH, thanks for catching it quickly, the build breaking would have sooner or later though :) Jack On Mon, Apr 27, 2009 at 11:33 AM, Andreas Tobler andreast-l...@fgznet.chwrote: Jack F Vogel wrote: Author: jfv Date: Mon Apr 27 17:22:14 2009 New Revision: 191566 URL:

Re: svn commit: r191065 - head/sys/dev/e1000

2009-04-14 Thread Jack Vogel
LOL, er I meant Randall Stewert, must be thinking of old films, sorry Randall :) On Tue, Apr 14, 2009 at 10:14 AM, Jack F Vogel j...@freebsd.org wrote: Author: jfv Date: Tue Apr 14 17:14:35 2009 New Revision: 191065 URL: http://svn.freebsd.org/changeset/base/191065 Log: Thanks to

Re: svn commit: r191065 - head/sys/dev/e1000

2009-04-14 Thread Jack Vogel
2 SCTP specific bugs, one is a missing shift to correctly identify SCTP type in the descriptor, the second was incorrectly assigning rather than 'or-ing' the csum_flags, leading to the inability to do other types of offload downstream. The third bug was more subtle, the code to detect a CRC

Re: svn commit: r190872 - head/sys/dev/e1000

2009-04-13 Thread Jack Vogel
There is quite a bit of shared code changes to support alternate mac addressing, if you look at the diffs you'll notice in attach I inserted a reset, and then also moved where hardware init is called, this is because the shared code now requires RAR(0) to have a valid address in it when it does