svn commit: r367905 - head/cddl/contrib/opensolaris/common/ctf

2020-11-20 Thread Jonathan T. Looney
Author: jtl Date: Fri Nov 20 17:26:02 2020 New Revision: 367905 URL: https://svnweb.freebsd.org/changeset/base/367905 Log: When copying types from one CTF container to another, ensure that we encode 0-length (i.e. "") structure and union member names as offset 0. This ensures that we don't c

Re: svn commit: r367763 - head/cddl/contrib/opensolaris/common/ctf

2020-11-17 Thread Jonathan T. Looney
On Tue, Nov 17, 2020 at 9:07 AM Jonathan T. Looney wrote: > Author: jtl > Date: Tue Nov 17 14:07:27 2020 > New Revision: 367763 > URL: https://svnweb.freebsd.org/changeset/base/367763 > > Log: > When copying types from one CTF container to another, ensure that we > al

svn commit: r367763 - head/cddl/contrib/opensolaris/common/ctf

2020-11-17 Thread Jonathan T. Looney
Author: jtl Date: Tue Nov 17 14:07:27 2020 New Revision: 367763 URL: https://svnweb.freebsd.org/changeset/base/367763 Log: When copying types from one CTF container to another, ensure that we always copy intrinsic data types before copying bitfields which are based on those types. This ensur

svn commit: r367685 - head/tests/sys/netinet

2020-11-14 Thread Jonathan T. Looney
Author: jtl Date: Sat Nov 14 15:44:28 2020 New Revision: 367685 URL: https://svnweb.freebsd.org/changeset/base/367685 Log: Add a regression test for the port-selection behavior fixed in r367680. Reviewed by: markj, olivier, tuexen Sponsored by: Netflix Differential Revision:htt

svn commit: r367680 - head/sys/netinet6

2020-11-14 Thread Jonathan T. Looney
Author: jtl Date: Sat Nov 14 14:50:34 2020 New Revision: 367680 URL: https://svnweb.freebsd.org/changeset/base/367680 Log: Fix implicit automatic local port selection for IPv6 during connect calls. When a user creates a TCP socket and tries to connect to the socket without explicitly bind

svn commit: r367573 - head/sys/vm

2020-11-10 Thread Jonathan T. Looney
Author: jtl Date: Tue Nov 10 18:12:09 2020 New Revision: 367573 URL: https://svnweb.freebsd.org/changeset/base/367573 Log: When destroying a UMA zone which has a reserve (set with uma_zone_reserve()), messages like the following appear on the console: "Freed UMA keg (Test zone) was not empty

Re: svn commit: r360019 - head/tests/sys/kern

2020-04-20 Thread Jonathan T. Looney
On Sun, Apr 19, 2020 at 5:03 PM Enji Cooper wrote: > > > On Apr 16, 2020, at 1:07 PM, Jonathan T. Looney wrote: > > > > Author: jtl > > Date: Thu Apr 16 20:07:34 2020 > > New Revision: 360019 > > URL: https://svnweb.freebsd.org/changeset/base/360019 >

svn commit: r360020 - in head/sys: netinet netinet6

2020-04-16 Thread Jonathan T. Looney
Author: jtl Date: Thu Apr 16 20:17:24 2020 New Revision: 360020 URL: https://svnweb.freebsd.org/changeset/base/360020 Log: Avoid calling protocol drain routines more than once per reclamation event. mb_reclaim() calls the protocol drain routines for each protocol in each domain. Some prot

svn commit: r360019 - head/tests/sys/kern

2020-04-16 Thread Jonathan T. Looney
Author: jtl Date: Thu Apr 16 20:07:34 2020 New Revision: 360019 URL: https://svnweb.freebsd.org/changeset/base/360019 Log: Add a regression test for the changes in r359922 and r359923. Note that the Python code has been tested on both Python 2.7 and 3.7. Reviewed by: olivier MFC aft

svn commit: r359923 - in head: lib/libc/sys sys/kern sys/sys

2020-04-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Apr 14 15:38:18 2020 New Revision: 359923 URL: https://svnweb.freebsd.org/changeset/base/359923 Log: Make sonewconn() overflow messages have per-socket rate-limits and values. sonewconn() emits debug-level messages when a listen socket's queue overflows. Currently, s

svn commit: r359922 - head/sys/kern

2020-04-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Apr 14 15:30:34 2020 New Revision: 359922 URL: https://svnweb.freebsd.org/changeset/base/359922 Log: Print more detail as part of the sonewconn() overflow message. When a socket's listen queue overflows, sonewconn() emits a debug-level log message. These messages are

svn commit: r359921 - head/sys/sys

2020-04-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Apr 14 15:27:24 2020 New Revision: 359921 URL: https://svnweb.freebsd.org/changeset/base/359921 Log: Make the path length of UNIX domain sockets specified by a #define. Also, add a comment describing the historical context for this length. Reviewed by: bz, jhb, kbow

svn commit: r357742 - head/sys/vm

2020-02-10 Thread Jonathan T. Looney
Author: jtl Date: Mon Feb 10 18:06:38 2020 New Revision: 357742 URL: https://svnweb.freebsd.org/changeset/base/357742 Log: Modify the vm.panic_on_oom sysctl to take a count of events. Currently, the vm.panic_on_oom sysctl is a boolean which controls the behavior of the VM system when it e

svn commit: r352746 - head/sys/netinet

2019-09-26 Thread Jonathan T. Looney
Author: jtl Date: Thu Sep 26 15:18:57 2019 New Revision: 352746 URL: https://svnweb.freebsd.org/changeset/base/352746 Log: Add new functionality to switch to using cookies exclusively when we the syn cache overflows. Whether this is due to an attack or due to the system having more legitimat

svn commit: r352745 - head/sys/netinet

2019-09-26 Thread Jonathan T. Looney
Author: jtl Date: Thu Sep 26 15:06:46 2019 New Revision: 352745 URL: https://svnweb.freebsd.org/changeset/base/352745 Log: Access the syncache secret directly from the V_tcp_syncache variable, rather than indirectly through the backpointer to the tcp_syncache structure stored in the hashtabl

svn commit: r352744 - head/sys/netinet

2019-09-26 Thread Jonathan T. Looney
Author: jtl Date: Thu Sep 26 15:02:34 2019 New Revision: 352744 URL: https://svnweb.freebsd.org/changeset/base/352744 Log: Remove the unused sch parameter to the syncache_respond() function. The use of this parameter was removed in r313330. This commit now removes passing this now-unused par

svn commit: r350829 - stable/11/sys/kern

2019-08-09 Thread Jonathan T. Looney
Author: jtl Date: Sat Aug 10 00:02:45 2019 New Revision: 350829 URL: https://svnweb.freebsd.org/changeset/base/350829 Log: MFC r350815: In m_pulldown(), before trying to prepend bytes to the subsequent mbuf, ensure that the subsequent mbuf contains the remainder of the bytes the call

svn commit: r350828 - stable/12/sys/kern

2019-08-09 Thread Jonathan T. Looney
Author: jtl Date: Sat Aug 10 00:01:25 2019 New Revision: 350828 URL: https://svnweb.freebsd.org/changeset/base/350828 Log: MFC r350815: In m_pulldown(), before trying to prepend bytes to the subsequent mbuf, ensure that the subsequent mbuf contains the remainder of the bytes the call

svn commit: r350815 - head/sys/kern

2019-08-08 Thread Jonathan T. Looney
Author: jtl Date: Fri Aug 9 05:18:59 2019 New Revision: 350815 URL: https://svnweb.freebsd.org/changeset/base/350815 Log: In m_pulldown(), before trying to prepend bytes to the subsequent mbuf, ensure that the subsequent mbuf contains the remainder of the bytes the caller sought. If this is

svn commit: r349197 - stable/12/sys/netinet/tcp_stacks

2019-06-19 Thread Jonathan T. Looney
Author: jtl Date: Wed Jun 19 16:25:39 2019 New Revision: 349197 URL: https://svnweb.freebsd.org/changeset/base/349197 Log: MFC r349192: Add the ability to limit how much the code will fragment the RACK send map in response to SACKs. The default behavior is unchanged; however, the lim

svn commit: r349192 - head/sys/netinet/tcp_stacks

2019-06-19 Thread Jonathan T. Looney
Author: jtl Date: Wed Jun 19 13:55:00 2019 New Revision: 349192 URL: https://svnweb.freebsd.org/changeset/base/349192 Log: Add the ability to limit how much the code will fragment the RACK send map in response to SACKs. The default behavior is unchanged; however, the limit can be activated b

svn commit: r348996 - head/sys/dev/ipmi

2019-06-12 Thread Jonathan T. Looney
Author: jtl Date: Wed Jun 12 16:06:31 2019 New Revision: 348996 URL: https://svnweb.freebsd.org/changeset/base/348996 Log: The current IPMI KCS code is waiting 100us for all transitions (roughly between each byte either sent or received). However, most transitions actually complete in 2-3 mi

Re: svn commit: r348810 - head/sys/x86/x86

2019-06-08 Thread Jonathan T. Looney
Hi Enji, On Sat, Jun 8, 2019 at 3:58 PM Enji Cooper wrote: > > Modified: > > head/sys/x86/x86/mca.c > > > > Modified: head/sys/x86/x86/mca.c > > > == > > --- head/sys/x86/x86/mca.cSat Jun 8 17:49:17 2019(r34880

svn commit: r348810 - head/sys/x86/x86

2019-06-08 Thread Jonathan T. Looney
Author: jtl Date: Sat Jun 8 18:26:48 2019 New Revision: 348810 URL: https://svnweb.freebsd.org/changeset/base/348810 Log: Currently, MCA entries remain on an every-growing linked list. This means that it becomes increasingly expensive to process a steady stream of correctable errors. Additi

svn commit: r343662 - svnadmin/conf

2019-02-01 Thread Jonathan T. Looney
Author: jtl Date: Fri Feb 1 15:38:20 2019 New Revision: 343662 URL: https://svnweb.freebsd.org/changeset/base/343662 Log: Add bz@ as a co-mentor for thj@. Approved by: core (implicit) Modified: svnadmin/conf/mentors Modified: svnadmin/conf/mentors =

svn commit: r340483 - head/sys/netinet

2018-11-16 Thread Jonathan T. Looney
Author: jtl Date: Fri Nov 16 18:32:48 2018 New Revision: 340483 URL: https://svnweb.freebsd.org/changeset/base/340483 Log: Add some additional length checks to the IPv4 fragmentation code. Specifically, block 0-length fragments, even when the MF bit is clear. Also, ensure that every fragm

Re: svn commit: r340241 - head/sys/vm

2018-11-08 Thread Jonathan T. Looney
Nice find! Jonathan On Wed, Nov 7, 2018 at 6:28 PM Mark Johnston wrote: > Author: markj > Date: Wed Nov 7 23:28:11 2018 > New Revision: 340241 > URL: https://svnweb.freebsd.org/changeset/base/340241 > > Log: > Fix a use-after-free in swp_pager_meta_free(). > > This was introduced in r32632

svn commit: r340077 - head/sys/netinet

2018-11-02 Thread Jonathan T. Looney
Author: jtl Date: Fri Nov 2 19:14:15 2018 New Revision: 340077 URL: https://svnweb.freebsd.org/changeset/base/340077 Log: m_pulldown() may reallocate n. Update the oip pointer after the m_pulldown() call. MFC after:2 weeks Sponsored by: Netflix Modified: head/sys/netinet/ip_icmp

svn commit: r339419 - in head: share/man/man9 sys/kern

2018-10-18 Thread Jonathan T. Looney
Author: jtl Date: Thu Oct 18 14:20:15 2018 New Revision: 339419 URL: https://svnweb.freebsd.org/changeset/base/339419 Log: r334853 added a "socket destructor" callback. However, as implemented, it was really a "socket close" callback. Update the socket destructor functionality to run when

svn commit: r339378 - head/sys/netinet

2018-10-16 Thread Jonathan T. Looney
Author: jtl Date: Tue Oct 16 14:41:09 2018 New Revision: 339378 URL: https://svnweb.freebsd.org/changeset/base/339378 Log: In r338102, the TCP reassembly code was substantially restructured. Prior to this change, the code sometimes used a temporary stack variable to hold details of a TCP seg

svn commit: r339375 - head/sys/contrib/ck/src

2018-10-15 Thread Jonathan T. Looney
Author: jtl Date: Tue Oct 16 02:30:13 2018 New Revision: 339375 URL: https://svnweb.freebsd.org/changeset/base/339375 Log: Import CK as of commit 5221ae2f3722a78c7fc41e47069ad94983d3bccb. This fixes two problems, one where epoch calls could occur before all the readers had exited the epoch s

svn commit: r339374 - vendor-sys/ck/20181014

2018-10-15 Thread Jonathan T. Looney
Author: jtl Date: Tue Oct 16 00:50:00 2018 New Revision: 339374 URL: https://svnweb.freebsd.org/changeset/base/339374 Log: Tag CK after import of commit 5221ae2f3722a78c7fc41e47069ad94983d3bccb. Added: vendor-sys/ck/20181014/ - copied from r339373, vendor-sys/ck/dist/ ___

svn commit: r339373 - vendor-sys/ck/dist/src

2018-10-15 Thread Jonathan T. Looney
Author: jtl Date: Tue Oct 16 00:48:18 2018 New Revision: 339373 URL: https://svnweb.freebsd.org/changeset/base/339373 Log: Import CK as of commit 5221ae2f3722a78c7fc41e47069ad94983d3bccb. This fixes two problems, one where epoch calls could occur before all the readers had exited the epoch s

Re: svn commit: r339251 - in head/sys: net netinet netinet6

2018-10-09 Thread Jonathan T. Looney
On Tue, Oct 9, 2018 at 11:02 AM John Baldwin wrote: > Do we have some sort of simple per-thread epoch counter similar to > td->td_locks that we could assert on in userret() and in the ithread loop > when ithreads go to sleep to help catch leaked locks? > Yes: td->td_epochnest. There are already

svn commit: r339251 - in head/sys: net netinet netinet6

2018-10-09 Thread Jonathan T. Looney
Author: jtl Date: Tue Oct 9 13:26:06 2018 New Revision: 339251 URL: https://svnweb.freebsd.org/changeset/base/339251 Log: There are three places where we return from a function which entered an epoch section without exiting that epoch section. This is bad for two reasons: the epoch section

Re: svn commit: r337776 - head/sys/netinet6

2018-08-30 Thread Jonathan T. Looney
On Thu, Aug 30, 2018 at 6:00 PM Kristof Provost wrote: > On 14 Aug 2018, at 19:17, Jonathan T. Looney wrote: > > + uint32_t hash, hashkey[sizeof(struct in6_addr) * 2 + 1], *hashkeyp; > > I’m pretty sure you didn’t mean for the hashkey to be 1028 bytes long. > Yikes. Yep

svn commit: r337804 - stable/11/share/man/man4

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 18:17:05 2018 New Revision: 337804 URL: https://svnweb.freebsd.org/changeset/base/337804 Log: MFC r337788: Update the inet(4) and inet6(4) man pages to reflect the changes made to the reassembly code in r337778, r337780, r337781, r337782, and r337783.

svn commit: r337803 - stable/11/sys/netinet6

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 18:15:10 2018 New Revision: 337803 URL: https://svnweb.freebsd.org/changeset/base/337803 Log: MFC r337787: Lower the default limits on the IPv6 reassembly queue. Currently, the limits are quite high. On machines with millions of mbuf clusters, the reas

svn commit: r337802 - stable/11/sys/netinet

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 18:13:36 2018 New Revision: 337802 URL: https://svnweb.freebsd.org/changeset/base/337802 Log: MFC r337786: Lower the default limits on the IPv4 reassembly queue. In particular, try to ensure that no bucket will have a reassembly queue larger than appro

svn commit: r337801 - stable/11/sys/netinet6

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 18:12:02 2018 New Revision: 337801 URL: https://svnweb.freebsd.org/changeset/base/337801 Log: MFC r337784: Drop 0-byte IPv6 fragments. Currently, we process IPv6 fragments with 0 bytes of payload, add them to the reassembly queue, and do not recognize

svn commit: r337799 - stable/11/sys/netinet6

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 18:10:25 2018 New Revision: 337799 URL: https://svnweb.freebsd.org/changeset/base/337799 Log: MFC r337783: Implement a limit on on the number of IPv6 reassembly queues per bucket. There is a hashing algorithm which should distribute IPv6 reassembly que

svn commit: r337798 - stable/11/sys/netinet6

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 18:06:59 2018 New Revision: 337798 URL: https://svnweb.freebsd.org/changeset/base/337798 Log: MFC r337782: Add a limit of the number of fragments per IPv6 packet. The IPv4 fragment reassembly code supports a limit on the number of fragments per packet.

svn commit: r337797 - stable/11/sys/netinet6

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:59:42 2018 New Revision: 337797 URL: https://svnweb.freebsd.org/changeset/base/337797 Log: MFC r337781: Make the IPv6 fragment limits be global, rather than per-VNET, limits. The IPv6 reassembly fragment limit is based on the number of mbuf clusters, w

svn commit: r337796 - stable/11/sys/netinet

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:54:39 2018 New Revision: 337796 URL: https://svnweb.freebsd.org/changeset/base/337796 Log: MFC r337780: Implement a limit on on the number of IPv4 reassembly queues per bucket. There is a hashing algorithm which should distribute IPv4 reassembly que

svn commit: r337795 - stable/11/sys/netinet

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:52:06 2018 New Revision: 337795 URL: https://svnweb.freebsd.org/changeset/base/337795 Log: MFC r337778: Add a global limit on the number of IPv4 fragments. The IP reassembly fragment limit is based on the number of mbuf clusters, which are a global

svn commit: r337790 - stable/11/sys/netinet6

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:46:54 2018 New Revision: 337790 URL: https://svnweb.freebsd.org/changeset/base/337790 Log: MFC r337776: Improve IPv6 reassembly performance by hashing fragments into buckets. Currently, all IPv6 fragment reassembly queues are kept in a flat linked l

svn commit: r337789 - stable/11/sys/netinet

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:43:11 2018 New Revision: 337789 URL: https://svnweb.freebsd.org/changeset/base/337789 Log: MFC r337775: Improve hashing of IPv4 fragments. Currently, IPv4 fragments are hashed into buckets based on a 32-bit key which is calculated by (src_ip ^ ip_id

svn commit: r337788 - head/share/man/man4

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:36:21 2018 New Revision: 337788 URL: https://svnweb.freebsd.org/changeset/base/337788 Log: Update the inet(4) and inet6(4) man pages to reflect the changes made to the reassembly code in r337778, r337780, r337781, r337782, and r337783. Security: FreeB

svn commit: r337787 - head/sys/netinet6

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:32:07 2018 New Revision: 337787 URL: https://svnweb.freebsd.org/changeset/base/337787 Log: Lower the default limits on the IPv6 reassembly queue. Currently, the limits are quite high. On machines with millions of mbuf clusters, the reassembly queue limits c

svn commit: r337786 - head/sys/netinet

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:30:46 2018 New Revision: 337786 URL: https://svnweb.freebsd.org/changeset/base/337786 Log: Lower the default limits on the IPv4 reassembly queue. In particular, try to ensure that no bucket will have a reassembly queue larger than approximately 100 items. T

svn commit: r337784 - head/sys/netinet6

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:29:22 2018 New Revision: 337784 URL: https://svnweb.freebsd.org/changeset/base/337784 Log: Drop 0-byte IPv6 fragments. Currently, we process IPv6 fragments with 0 bytes of payload, add them to the reassembly queue, and do not recognize them as duplicating o

svn commit: r337783 - head/sys/netinet6

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:27:41 2018 New Revision: 337783 URL: https://svnweb.freebsd.org/changeset/base/337783 Log: Implement a limit on on the number of IPv6 reassembly queues per bucket. There is a hashing algorithm which should distribute IPv6 reassembly queues across the availa

svn commit: r337782 - head/sys/netinet6

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:26:07 2018 New Revision: 337782 URL: https://svnweb.freebsd.org/changeset/base/337782 Log: Add a limit of the number of fragments per IPv6 packet. The IPv4 fragment reassembly code supports a limit on the number of fragments per packet. The default limit is

svn commit: r337781 - head/sys/netinet6

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:24:26 2018 New Revision: 337781 URL: https://svnweb.freebsd.org/changeset/base/337781 Log: Make the IPv6 fragment limits be global, rather than per-VNET, limits. The IPv6 reassembly fragment limit is based on the number of mbuf clusters, which are a global

svn commit: r337780 - head/sys/netinet

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:23:05 2018 New Revision: 337780 URL: https://svnweb.freebsd.org/changeset/base/337780 Log: Implement a limit on on the number of IPv4 reassembly queues per bucket. There is a hashing algorithm which should distribute IPv4 reassembly queues across the availa

svn commit: r337778 - head/sys/netinet

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:19:49 2018 New Revision: 337778 URL: https://svnweb.freebsd.org/changeset/base/337778 Log: Add a global limit on the number of IPv4 fragments. The IP reassembly fragment limit is based on the number of mbuf clusters, which are a global resource. However, th

svn commit: r337776 - head/sys/netinet6

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:17:37 2018 New Revision: 337776 URL: https://svnweb.freebsd.org/changeset/base/337776 Log: Improve IPv6 reassembly performance by hashing fragments into buckets. Currently, all IPv6 fragment reassembly queues are kept in a flat linked list. This has a numbe

svn commit: r337775 - head/sys/netinet

2018-08-14 Thread Jonathan T. Looney
Author: jtl Date: Tue Aug 14 17:15:47 2018 New Revision: 337775 URL: https://svnweb.freebsd.org/changeset/base/337775 Log: Improve hashing of IPv4 fragments. Currently, IPv4 fragments are hashed into buckets based on a 32-bit key which is calculated by (src_ip ^ ip_id) and combined with a

Re: svn commit: r337384 - in head: share/man/man4 sys/netinet

2018-08-06 Thread Jonathan T. Looney
On Mon, Aug 6, 2018 at 2:16 PM Bjoern A. Zeeb < bzeeb-li...@lists.zabbadoz.net> wrote: > > On 6 Aug 2018, at 17:36, Jonathan T. Looney wrote: > > > Author: jtl > > Date: Mon Aug 6 17:36:57 2018 > > New Revision: 337384 > > URL: https://svnweb.freebs

svn commit: r337392 - stable/10/share/man/man4

2018-08-06 Thread Jonathan T. Looney
Author: jtl Date: Mon Aug 6 18:47:03 2018 New Revision: 337392 URL: https://svnweb.freebsd.org/changeset/base/337392 Log: MFC r337390: Bump date after r337384. Modified: stable/10/share/man/man4/tcp.4 Directory Properties: stable/10/ (props changed) Modified: stable/10/share/man/man4/tc

svn commit: r337391 - stable/11/share/man/man4

2018-08-06 Thread Jonathan T. Looney
Author: jtl Date: Mon Aug 6 18:46:09 2018 New Revision: 337391 URL: https://svnweb.freebsd.org/changeset/base/337391 Log: MFC r337390: Bump date after r337384. Modified: stable/11/share/man/man4/tcp.4 Directory Properties: stable/11/ (props changed) Modified: stable/11/share/man/man4/tc

svn commit: r337390 - head/share/man/man4

2018-08-06 Thread Jonathan T. Looney
Author: jtl Date: Mon Aug 6 18:42:37 2018 New Revision: 337390 URL: https://svnweb.freebsd.org/changeset/base/337390 Log: Bump date after r337384. Reported by: bz Modified: head/share/man/man4/tcp.4 Modified: head/share/man/man4/tcp.4 ==

svn commit: r337389 - in releng/10.4: share/man/man4 sys/netinet

2018-08-06 Thread Jonathan T. Looney
Author: jtl Date: Mon Aug 6 17:50:40 2018 New Revision: 337389 URL: https://svnweb.freebsd.org/changeset/base/337389 Log: Address concerns about CPU usage while doing TCP reassembly. Currently, the per-queue limit is a function of the receive buffer size and the MSS. In certain cases (s

svn commit: r337388 - in releng/11.1: share/man/man4 sys/netinet

2018-08-06 Thread Jonathan T. Looney
Author: jtl Date: Mon Aug 6 17:48:46 2018 New Revision: 337388 URL: https://svnweb.freebsd.org/changeset/base/337388 Log: Address concerns about CPU usage while doing TCP reassembly. Currently, the per-queue limit is a function of the receive buffer size and the MSS. In certain cases (s

svn commit: r337387 - in releng/11.2: share/man/man4 sys/netinet

2018-08-06 Thread Jonathan T. Looney
Author: jtl Date: Mon Aug 6 17:47:47 2018 New Revision: 337387 URL: https://svnweb.freebsd.org/changeset/base/337387 Log: Address concerns about CPU usage while doing TCP reassembly. Currently, the per-queue limit is a function of the receive buffer size and the MSS. In certain cases (s

svn commit: r337386 - in stable/10: share/man/man4 sys/netinet

2018-08-06 Thread Jonathan T. Looney
Author: jtl Date: Mon Aug 6 17:46:28 2018 New Revision: 337386 URL: https://svnweb.freebsd.org/changeset/base/337386 Log: MFC r337384: Address concerns about CPU usage while doing TCP reassembly. Currently, the per-queue limit is a function of the receive buffer size and the MSS. I

svn commit: r337385 - in stable/11: share/man/man4 sys/netinet

2018-08-06 Thread Jonathan T. Looney
Author: jtl Date: Mon Aug 6 17:41:53 2018 New Revision: 337385 URL: https://svnweb.freebsd.org/changeset/base/337385 Log: MFC r337384: Address concerns about CPU usage while doing TCP reassembly. Currently, the per-queue limit is a function of the receive buffer size and the MSS. I

svn commit: r337384 - in head: share/man/man4 sys/netinet

2018-08-06 Thread Jonathan T. Looney
Author: jtl Date: Mon Aug 6 17:36:57 2018 New Revision: 337384 URL: https://svnweb.freebsd.org/changeset/base/337384 Log: Address concerns about CPU usage while doing TCP reassembly. Currently, the per-queue limit is a function of the receive buffer size and the MSS. In certain cases (s

Re: svn commit: r335856 - in head/sys: netinet sys

2018-07-02 Thread Jonathan T. Looney
On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland < steven.hartl...@multiplay.co.uk> wrote: > > You have M_WAITOK and a null check in this change And, that's the same as the way it was before his commits. So, he did exactly what he said he was doing and reverted his commits. I don't think it is good

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Jonathan T. Looney
On Wed, Jun 20, 2018 at 9:49 AM Stephen Kiernan wrote: > And I was working on those sets of changes, when work and family didn't > steal away time. I was told that some discussion happened at BSDCan this > year in such that veriexec should go in as-is so it would be there, which is why > the commi

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Jonathan T. Looney
On Tue, Jun 19, 2018 at 8:34 PM Conrad Meyer wrote: > Please revert this patchset. It's not ready. > I'm not sure I understand the need to revert the patches. They may need some refinement, but they also do provide some functionality upon which you can build the tooling that Simon discussed. U

Re: svn commit: r335068 - in head: share/man/man9 sys/amd64/amd64 sys/i386/i386 sys/kern sys/net sys/sys sys/vm

2018-06-14 Thread Jonathan T. Looney
On Thu, Jun 14, 2018 at 7:12 PM Olivier Houchard wrote: > On Fri, Jun 15, 2018 at 12:23:36AM +0200, Emmanuel Vadot wrote: > > This brake module loading on armv7 and arm64 > > I think I fixed it with r335182. > Jonathan probably missed it because modules are differnt on amd64 (and > mips), and th

svn commit: r335068 - in head: share/man/man9 sys/amd64/amd64 sys/i386/i386 sys/kern sys/net sys/sys sys/vm

2018-06-13 Thread Jonathan T. Looney
Author: jtl Date: Wed Jun 13 17:04:41 2018 New Revision: 335068 URL: https://svnweb.freebsd.org/changeset/base/335068 Log: Make UMA and malloc(9) return non-executable memory in most cases. Most kernel memory that is allocated after boot does not need to be executable. There are a few ex

svn commit: r334983 - head/sys/net

2018-06-11 Thread Jonathan T. Looney
Author: jtl Date: Mon Jun 11 23:32:06 2018 New Revision: 334983 URL: https://svnweb.freebsd.org/changeset/base/334983 Log: Fix a memory leak for the BIOCSETWF ioctl on kernels with the BPF_JITTER option. The BPF code was creating a compiled filter in the common filter-creation path. Ho

svn commit: r334949 - in head/sys/netinet: . tcp_stacks

2018-06-11 Thread Jonathan T. Looney
Author: jtl Date: Mon Jun 11 14:27:19 2018 New Revision: 334949 URL: https://svnweb.freebsd.org/changeset/base/334949 Log: Change RACK dependency on TCPHPTS from a build-time dependency to a load- time dependency. At present, RACK requires the TCPHPTS option to run. However, because mod

svn commit: r334854 - head/share/man/man9

2018-06-08 Thread Jonathan T. Looney
Author: jtl Date: Fri Jun 8 19:47:04 2018 New Revision: 334854 URL: https://svnweb.freebsd.org/changeset/base/334854 Log: Create a symlink for sodtor_set(9) to the socket(9) man page. Modified: head/share/man/man9/Makefile Modified: head/share/man/man9/Makefile =

svn commit: r334853 - in head: share/man/man9 sys/kern sys/sys

2018-06-08 Thread Jonathan T. Looney
Author: jtl Date: Fri Jun 8 19:35:24 2018 New Revision: 334853 URL: https://svnweb.freebsd.org/changeset/base/334853 Log: Add a socket destructor callback. This allows kernel providers to set callbacks to perform additional cleanup actions at the time a socket is closed. Michio Honda

Re: svn commit: r334804 - in head/sys: kern modules/tcp modules/tcp/rack netinet netinet/tcp_stacks sys

2018-06-08 Thread Jonathan T. Looney
On Fri, Jun 8, 2018 at 12:37 PM, hiren panchasara < hi...@strugglingcoder.info> wrote: > ps: I know we are not killing the default stack as of yet and just > stopping active maintenance of it but just wanted to raise these > (probably obvious) points. We absolutely are not stopping active maintena

svn commit: r334783 - head/sys/vm

2018-06-07 Thread Jonathan T. Looney
Author: jtl Date: Thu Jun 7 13:29:54 2018 New Revision: 334783 URL: https://svnweb.freebsd.org/changeset/base/334783 Log: Fix a typo in vm_domain_set(). When a domain crosses into the severe range, we need to set the domain bit from the vm_severe_domains bitset (instead of clearing it).

Re: svn commit: r334702 - head/sys/sys

2018-06-06 Thread Jonathan T. Looney
On Wed, Jun 6, 2018 at 10:14 PM, Ravi Pokala wrote: > > -Original Message- > From: on behalf of Mateusz Guzik < mjgu...@gmail.com> > Date: 2018-06-06, Wednesday at 09:01 > To: Ravi Pokala > Cc: Mateusz Guzik , src-committers < src-committ...@freebsd.org>, , < svn-src-h...@freebsd.org> >

svn commit: r334490 - head/share/man/man9

2018-06-01 Thread Jonathan T. Looney
Author: jtl Date: Fri Jun 1 16:47:39 2018 New Revision: 334490 URL: https://svnweb.freebsd.org/changeset/base/334490 Log: Update the sysctl(9) manpage to indicate that is required instead of . ( includes NULL, which is defined with and not .) Sponsored by: Netflix Modified: head/

Re: svn commit: r334104 - in head/sys: netinet sys

2018-05-23 Thread Jonathan T. Looney
On Wed, May 23, 2018 at 7:13 PM, Matthew Macy wrote: > > On Wed, May 23, 2018 at 11:52 AM, John Baldwin wrote: > > On Wednesday, May 23, 2018 05:00:05 PM Matt Macy wrote: > >> Author: mmacy > >> Date: Wed May 23 17:00:05 2018 > >> New Revision: 334104 > >> URL: https://svnweb.freebsd.org/changese

Re: svn commit: r333915 - head/sys/netinet

2018-05-21 Thread Jonathan T. Looney
Summary: I'm not sure this addresses all the subtleties of INPCB destruction. I think it would benefit from wider review. I suggest it be reverted in the meantime. On Sun, May 20, 2018 at 12:38 AM, Matt Macy wrote: > + > +/* > + * Unconditionally schedule an inpcb to be freed by decrementing its

Re: svn commit: r333690 - in head/sys: dev/hwpmc kern sys

2018-05-16 Thread Jonathan T. Looney
On Wed, May 16, 2018 at 6:29 PM, Matt Macy wrote: > > Author: mmacy > Date: Wed May 16 22:29:20 2018 > New Revision: 333690 > URL: https://svnweb.freebsd.org/changeset/base/333690 > > Log: > hwpmc: Implement per-thread counters for PMC sampling > > This implements per-thread counters for PMC s

svn commit: r333511 - stable/11/sys/kern

2018-05-11 Thread Jonathan T. Looney
Author: jtl Date: Sat May 12 01:55:24 2018 New Revision: 333511 URL: https://svnweb.freebsd.org/changeset/base/333511 Log: r285910 attempted to make shutdown() be POSIX compliant by returning ENOTCONN when shutdown() is called on unconnected sockets. This change was slightly modified by r31

Re: svn commit: r333503 - stable/11/sys/net

2018-05-11 Thread Jonathan T. Looney
On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd wrote: > > Author: shurd > Date: Fri May 11 20:40:26 2018 > New Revision: 333503 > URL: https://svnweb.freebsd.org/changeset/base/333503 > > Log: > MFC r29, r66, r73 > > r29: Fix off-by-one error requesting tx interrupt > r66:

Re: svn commit: r333211 - head/sys/netinet/cc

2018-05-03 Thread Jonathan T. Looney
On Thu, May 3, 2018 at 11:01 AM, Sean Bruno wrote: > > @@ -242,8 +241,8 @@ tf_cwnd(int ticks_since_cong, int rtt_ticks, unsigned > { > > /* Equation 4 of I-D. */ > - return (((wmax * CUBIC_BETA) + (((THREE_X_PT2 * ticks_since_cong * > - smss) << CUBIC_SHIFT) / TWO_SUB_PT2

svn commit: r332958 - head/sys/kern

2018-04-24 Thread Jonathan T. Looney
Author: jtl Date: Tue Apr 24 18:47:35 2018 New Revision: 332958 URL: https://svnweb.freebsd.org/changeset/base/332958 Log: Update r332860 by changing the default from suppressing post-panic assertions to not suppressing post-panic assertions. There are some post-panic assertions that are

Re: svn commit: r332860 - head/sys/kern

2018-04-24 Thread Jonathan T. Looney
On Mon, Apr 23, 2018 at 6:04 PM, John Baldwin wrote: > > I think this is actually a key question. In my experience to date I have not > encountered a large number of post-panic assertion failures. Given that > we already break all locks and disable assertions for locks I'd be curious > which ass

Re: svn commit: r332860 - head/sys/kern

2018-04-23 Thread Jonathan T. Looney
Hi Mark, Let me start by saying that I appreciate your well-reasoned response. (I think) I understand your reasoning, I appreciate your well-explained argument, and I respect your opinion. I just wanted to make that clear up front. On Sun, Apr 22, 2018 at 1:11 PM, Mark Johnston wrote: > > > All

svn commit: r332889 - stable/11/sys/netinet

2018-04-23 Thread Jonathan T. Looney
Author: jtl Date: Mon Apr 23 14:22:16 2018 New Revision: 332889 URL: https://svnweb.freebsd.org/changeset/base/332889 Log: MFC r331745 (by np): Fix RSS build (broken in r331309). Sponsored by: Chelsio Communications PR: 227691 Pointy-hat to:jtl Modified: st

svn commit: r332860 - head/sys/kern

2018-04-21 Thread Jonathan T. Looney
Author: jtl Date: Sat Apr 21 17:05:00 2018 New Revision: 332860 URL: https://svnweb.freebsd.org/changeset/base/332860 Log: When running with INVARIANTS, the kernel contains extra checks. However, these assumptions may not hold true once we've panic'd. Therefore, the checks hold less value a

Re: svn commit: r332833 - in head: contrib/llvm/include/llvm/CodeGen contrib/llvm/lib/CodeGen contrib/llvm/lib/Target/X86 contrib/llvm/lib/Target/X86/Disassembler contrib/llvm/tools/clang/include/clan

2018-04-20 Thread Jonathan T. Looney
On Fri, Apr 20, 2018 at 2:20 PM, Dimitry Andric wrote: > > Author: dim > Date: Fri Apr 20 18:20:55 2018 > New Revision: 332833 > URL: https://svnweb.freebsd.org/changeset/base/332833 > > Log: > Recommit r332501, with an additional upstream fix for "Cannot lower > EFLAGS copy that lives out of

svn commit: r332842 - stable/11/sys/netinet6

2018-04-20 Thread Jonathan T. Looney
Author: jtl Date: Fri Apr 20 20:18:10 2018 New Revision: 332842 URL: https://svnweb.freebsd.org/changeset/base/332842 Log: MFC r319216: Fix an unnecessary/incorrect check in the PKTOPT_EXTHDRCPY macro. This macro allocates memory and, if malloc does not return NULL, copies data in

svn commit: r332841 - stable/11/sys/netinet6

2018-04-20 Thread Jonathan T. Looney
Author: jtl Date: Fri Apr 20 20:16:42 2018 New Revision: 332841 URL: https://svnweb.freebsd.org/changeset/base/332841 Log: MFC r319215: Fix two places in the ICMP6 code where we could dereference a NULL pointer in the icmp6_input() function. When processing an ICMP6_ECHO_REQUEST,

svn commit: r332840 - in stable/11/sys: netinet netinet6

2018-04-20 Thread Jonathan T. Looney
Author: jtl Date: Fri Apr 20 20:09:42 2018 New Revision: 332840 URL: https://svnweb.freebsd.org/changeset/base/332840 Log: MFC r319214: Enforce the limit on ICMP messages before doing work to formulate the response. Delete an unneeded rate limit for UDP under IPv6. Because ICMP6

svn commit: r332834 - stable/11/sys/net

2018-04-20 Thread Jonathan T. Looney
Author: jtl Date: Fri Apr 20 18:37:19 2018 New Revision: 332834 URL: https://svnweb.freebsd.org/changeset/base/332834 Log: MFC r314286: Do some minimal work to better conform to the 802.3ad (LACP) standard. In particular, don't set the synchronized bit for the peer unless it truly ap

svn commit: r332831 - stable/11/sys/kern

2018-04-20 Thread Jonathan T. Looney
Author: jtl Date: Fri Apr 20 15:55:09 2018 New Revision: 332831 URL: https://svnweb.freebsd.org/changeset/base/332831 Log: MFC r314116: Fix a panic during boot caused by inadequate locking of some vt(4) driver data structures. vt_change_font() calls vtbuf_grow() to change some vt

svn commit: r332830 - in stable/11/sys: dev/acpica x86/x86

2018-04-20 Thread Jonathan T. Looney
Author: jtl Date: Fri Apr 20 15:48:50 2018 New Revision: 332830 URL: https://svnweb.freebsd.org/changeset/base/332830 Log: MFC r313447: Ensure the idle thread's loop services interrupts in a timely way when using the ACPI C1/mwait sleep method. Previously, the mwait instruction wo

svn commit: r332829 - stable/11/sys/netinet

2018-04-20 Thread Jonathan T. Looney
Author: jtl Date: Fri Apr 20 15:44:29 2018 New Revision: 332829 URL: https://svnweb.freebsd.org/changeset/base/332829 Log: MFC r307083: Currently, when tcp_input() receives a packet on a session that matches a TCPCB, it checks (so->so_options & SO_ACCEPTCONN) to determine whether or not

  1   2   >