svn commit: r367711 - in head: lib/libutil sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-15 Thread Scott Long
Author: scottl Date: Sun Nov 15 20:24:59 2020 New Revision: 367711 URL: https://svnweb.freebsd.org/changeset/base/367711 Log: Revert the whole getlocalbase() set of changes while a different design is hashed out. Deleted: head/lib/libutil/getlocalbase.3 head/lib/libutil/getlocalbase.c

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Scott Long
> On Nov 15, 2020, at 1:05 PM, Warner Losh wrote: > > Hey Scott, > > On Sun, Nov 15, 2020 at 11:46 AM Scott Long wrote: > The man page for strlcpy() made reference to the return value being > equivalent to what snprintf() does. The man page for snprintf() states > th

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Scott Long
t; Usage: pkg [-v] [-d] [-l] [-N] [-j |-c |-r >>> ] [-C ] [-R ] [-o var=value] >>> [-4|-6] [] >>> >>> For more information on available commands and options see 'pkg help'. >>> root@crow:~ # >>> >>> >>> I would double check very c

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Scott Long
> On Nov 15, 2020, at 12:01 PM, Jessica Clarke wrote: >> >> I felt similar concerns, but my misunderstanding of strlcpy() drove the >> result. Since the use case for getlocalbase() lends itself to also use >> strlcat()/strlcpy(), I was trying to replicate the API semantics of those, >> at

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Scott Long
> On Nov 15, 2020, at 11:31 AM, Jessica Clarke wrote: > > Hi Scott, > I'm concerned by this diff; see my comments below. > >> On 15 Nov 2020, at 07:48, Scott Long wrote: >> >> Author: scottl >> Date: Sun Nov 15 07:48:52 2020 >> New Revisi

Re: svn commit: r367687 - in head: sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-15 Thread Scott Long
I fixed this in r367702, sorry for the breakage. Scott > On Nov 15, 2020, at 11:12 AM, Brandon Bergren wrote: > >> --- head/usr.sbin/pkg/pkg.c Sat Nov 14 17:57:50 2020(r367686) >> +++ head/usr.sbin/pkg/pkg.c Sat Nov 14 18:01:14 2020(r367687) >> @@ -43,6 +43,7 @@

svn commit: r367702 - in head: sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-14 Thread Scott Long
Author: scottl Date: Sun Nov 15 07:50:29 2020 New Revision: 367702 URL: https://svnweb.freebsd.org/changeset/base/367702 Log: Fix the previous revision, it suffered from an incomplete change to the getlocalbase API. Also don't erroneously subtract the lenth from the buffer a second time.

svn commit: r367701 - head/lib/libutil

2020-11-14 Thread Scott Long
Author: scottl Date: Sun Nov 15 07:48:52 2020 New Revision: 367701 URL: https://svnweb.freebsd.org/changeset/base/367701 Log: Because getlocalbase() returns -1 on error, it needs to use a signed type internally. Do that, and make sure that conversations between signed and unsigned don't

Re: svn commit: r367686 - head/lib/libutil

2020-11-14 Thread Scott Long
when I try to 'pkg upgrade': > > $ doas pkg upgrade > Cannot determine local path > $ > > Is this error somehow related to this change? > > --Gordon > > On Sat, Nov 14, 2020 at 11:44:29AM -0700, Scott Long wrote: >> Hi, >> >> Yeah, I’m working on a fi

svn commit: r367689 - head/lib/libutil

2020-11-14 Thread Scott Long
Author: scottl Date: Sat Nov 14 19:04:36 2020 New Revision: 367689 URL: https://svnweb.freebsd.org/changeset/base/367689 Log: Fix a problem with r367686 related to the use of ssize_t. Not sure how this escaped prior testing, but it should be better now. Reported by: lots Modified:

Re: svn commit: r367686 - head/lib/libutil

2020-11-14 Thread Scott Long
on arm64 with the following src.conf: > > WITH_MALLOC_PRODUCTION=1 > WITH_EXTRA_TCP_STACKS=1 > WITH_BEARSSL=1 > WITH_PIE=1 > WITH_RETPOLINE=1 > > --Gordon > > On Sat, Nov 14, 2020 at 05:57:50PM +, Scott Long wrote: >> Author: scottl >> Date: Sat Nov

svn commit: r367687 - in head: sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-14 Thread Scott Long
Author: scottl Date: Sat Nov 14 18:01:14 2020 New Revision: 367687 URL: https://svnweb.freebsd.org/changeset/base/367687 Log: Replace hardcoded references to _PATH_LOCALBASE with calls to getlocalbase.3 Reviewed by: imp, se Modified: head/sbin/nvmecontrol/comnd.c

svn commit: r367686 - head/lib/libutil

2020-11-14 Thread Scott Long
ocalbase.3 == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/lib/libutil/getlocalbase.3 Sat Nov 14 17:57:50 2020 (r367686) @@ -0,0 +1,110 @@ +.\" +.\" SPDX-License-Identifier: BSD-2-Clause-FreeBSD +.\" +.\" Copyright 2020 Scott Long +.

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-26 Thread Scott Long
> On Oct 26, 2020, at 1:50 AM, Baptiste Daroussin wrote: > > On Mon, Oct 26, 2020 at 12:11:56AM -0600, Warner Losh wrote: >> On Mon, Oct 26, 2020 at 12:01 AM Alex Kozlov wrote: >> >>> On Sun, Oct 25, 2020 at 11:37:34AM +0100, Stefan Esser wrote: Am 25.10.20 um 06:56 schrieb Alex Kozlov:

svn commit: r367053 - head/usr.bin/calendar/calendars

2020-10-25 Thread Scott Long
Alexander Botero-Lowry died in San Francisco, California, United States, 2012 08/25 Beech Rintoul born in Oakland, California, United States, 1952 08/25 Jean Milanez Melo born in Divinopolis, Minas Gerais, Brazil, 1982 -08/26 Scott Long born in Chicago, Illinois, United States, 1974 +08/25

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-24 Thread Scott Long
> On Oct 24, 2020, at 9:46 PM, Rodney W. Grimes > wrote: > >>> >>> Something feels very wrong about this becoming a defined path in base, >>> it is further dependence on /usr/local which in the early days we spent >>> a great deal of time removing. >>> >>> I believe the whole ports system

svn commit: r366668 - in head/sys/dev: mpr mps

2020-10-13 Thread Scott Long
Author: scottl Date: Tue Oct 13 14:10:49 2020 New Revision: 38 URL: https://svnweb.freebsd.org/changeset/base/38 Log: Bring the request_descriptor union into harmony internally. No functional change. Modified: head/sys/dev/mpr/mpr.c head/sys/dev/mps/mps.c Modified:

Re: svn commit: r366429 - in head/sys: kern sys

2020-10-05 Thread Scott Long
> On Oct 5, 2020, at 1:35 PM, Mateusz Guzik wrote: > > On 10/5/20, Konstantin Belousov wrote: >> On Sun, Oct 04, 2020 at 09:06:02PM +, Rick Macklem wrote: >>> Mateusz Guzik wrote: Why is the process lock always taken? It looks like both routines just check a thread-local flag,

Re: svn commit: r366186 - in head/usr.sbin: bsdconfig/share/media bsdinstall/scripts

2020-09-29 Thread Scott Long
> On Sep 27, 2020, at 2:41 AM, Niclas Zeising wrote: > > On 2020-09-27 03:38, Scott Long wrote: >>> On Sep 26, 2020, at 5:24 PM, Rodney W. Grimes >>> wrote: >>> >>>  >>>> >>>> >>>>>> On Sep 26,

Re: svn commit: r366207 - head/lib/libc/gen

2020-09-28 Thread Scott Long
> On Sep 27, 2020, at 10:08 PM, Alan Somers wrote: > > On Sun, Sep 27, 2020 at 5:15 PM Konstantin Belousov > wrote: > On Sun, Sep 27, 2020 at 10:26:41PM +, Alan Somers wrote: > > Author: asomers > > Date: Sun Sep 27 22:26:41 2020 > > New Revision: 366207 > > URL:

Re: svn commit: r365643 - head/bin/cp

2020-09-27 Thread Scott Long
>> normal means before devfs can be mounted. However, several people have >> looked and found no evidence on their system. This means there's something >> special / unique to Rod's setup that's generating them (assuming it isn't a >> simple chroot without devfs). What that is, and how they come

Re: svn commit: r366186 - in head/usr.sbin: bsdconfig/share/media bsdinstall/scripts

2020-09-26 Thread Scott Long
> On Sep 26, 2020, at 5:24 PM, Rodney W. Grimes > wrote: > >  >> >> On Sep 26, 2020, at 1:22 PM, Warner Losh wrote: >>> >>> >>> >>> I am the wrong person to answer that question. >>> >>> In this case, things have not become lame. For instance, the names >>> ervers for

Re: svn commit: r366186 - in head/usr.sbin: bsdconfig/share/media bsdinstall/scripts

2020-09-26 Thread Scott Long
> On Sep 26, 2020, at 1:22 PM, Warner Losh wrote: > > > > I am the wrong person to answer that question. > > In this case, things have not become lame. For instance, the names > ervers for se.freebsd.org work fine, but ftp3.se and ftp6.se records are > removed. Same for ru.freebsd.org

Re: svn commit: r365984 - head/usr.bin/calendar/calendars

2020-09-22 Thread Scott Long
>> >> Does this file still need to be in FreeBSD? It may have been a novel= >> ty back >> in the day but IMO calendar.history has nothing to do with BSD, comp= >> uters >> or anything else of interest to FreeBSD. At the very least this file= >> should >> be moved to ports or

svn commit: r365707 - head/share/man/man9

2020-09-14 Thread Scott Long
Author: scottl Date: Mon Sep 14 06:26:36 2020 New Revision: 365707 URL: https://svnweb.freebsd.org/changeset/base/365707 Log: Update bus_dma.9 for the expanded template API. Add some clarifying language about the operation of parent tags in templates. Modified:

svn commit: r365706 - in head/sys: arm/arm arm64/arm64 dev/mpr dev/mps kern mips/mips powerpc/powerpc riscv/riscv sys x86/x86

2020-09-13 Thread Scott Long
Author: scottl Date: Mon Sep 14 05:58:12 2020 New Revision: 365706 URL: https://svnweb.freebsd.org/changeset/base/365706 Log: Refine the busdma template interface. Provide tools for filling in fields that can be extended, but also ensure compile-time type checking. Refactor common code

svn commit: r365644 - head/sys/dev/mps

2020-09-11 Thread Scott Long
Author: scottl Date: Fri Sep 11 22:27:35 2020 New Revision: 365644 URL: https://svnweb.freebsd.org/changeset/base/365644 Log: Convert the mps driver to use busdma templates Modified: head/sys/dev/mps/mps.c head/sys/dev/mps/mps_pci.c head/sys/dev/mps/mps_user.c Modified:

svn commit: r365641 - head/share/man/man9

2020-09-11 Thread Scott Long
Author: scottl Date: Fri Sep 11 19:45:26 2020 New Revision: 365641 URL: https://svnweb.freebsd.org/changeset/base/365641 Log: Improve the documenation for bus_dma templates. Also add notes to make it clear that filters may not work correctly and that their use is deprecated. MFC

svn commit: r363060 - in head: stand/defaults sys/amd64/amd64 sys/powerpc/aim sys/vm

2020-07-09 Thread Scott Long
Author: scottl Date: Thu Jul 9 22:38:36 2020 New Revision: 363060 URL: https://svnweb.freebsd.org/changeset/base/363060 Log: Revert r362998, r326999 while a better compatibility strategy is devised. Modified: head/stand/defaults/loader.conf head/sys/amd64/amd64/pmap.c

svn commit: r362999 - head/stand/defaults

2020-07-07 Thread Scott Long
Author: scottl Date: Tue Jul 7 20:42:35 2020 New Revision: 362999 URL: https://svnweb.freebsd.org/changeset/base/362999 Log: Fix a example/docs typo from r362998, no functional change. Modified: head/stand/defaults/loader.conf Modified: head/stand/defaults/loader.conf

svn commit: r362998 - in head: stand/defaults sys/amd64/amd64 sys/powerpc/aim sys/vm

2020-07-07 Thread Scott Long
Author: scottl Date: Tue Jul 7 20:33:11 2020 New Revision: 362998 URL: https://svnweb.freebsd.org/changeset/base/362998 Log: Migrate the feature of excluding RAM pages to use "excludelist" as its nomenclature. MFC after:1 week Modified: head/stand/defaults/loader.conf

Re: svn commit: r361284 - in head/sys/amd64: include vmm

2020-05-20 Thread Scott Long
There’s a better way to do this. People have been wanting larger names to be merged into 12.x and 11.x, and that was going to be hard with how I originally did this. Your compat shim doesn’t make it any easier. What I was going to do was return the ioctl in HEAD to the original size, and create

Re: svn commit: r360004 - head/sys/i386/i386

2020-04-16 Thread Scott Long
> On Apr 16, 2020, at 10:01 AM, Brooks Davis wrote: > > On Thu, Apr 16, 2020 at 05:27:14AM +0000, Scott Long wrote: >> Author: scottl >> Date: Thu Apr 16 05:27:13 2020 >> New Revision: 360004 >> URL: https://svnweb.freebsd.org/changeset/base/360004 >>

svn commit: r360004 - head/sys/i386/i386

2020-04-15 Thread Scott Long
Author: scottl Date: Thu Apr 16 05:27:13 2020 New Revision: 360004 URL: https://svnweb.freebsd.org/changeset/base/360004 Log: Fix ps_strings type change for i386 Modified: head/sys/i386/i386/machdep.c Modified: head/sys/i386/i386/machdep.c

svn commit: r360003 - head/usr.sbin/mpsutil

2020-04-15 Thread Scott Long
Author: scottl Date: Thu Apr 16 04:17:06 2020 New Revision: 360003 URL: https://svnweb.freebsd.org/changeset/base/360003 Log: Add support for some IOCFacts fields that are available with mpr (12Gb) controllers. It's ugly due to the single codebase for mpr and mps and not being able to

svn commit: r360002 - head/usr.sbin/mpsutil

2020-04-15 Thread Scott Long
Author: scottl Date: Thu Apr 16 03:33:46 2020 New Revision: 360002 URL: https://svnweb.freebsd.org/changeset/base/360002 Log: Don't keep a private copy of mpr_ioctl.h and mps_ioctl.h, since they easily get out of sync with the real files from the driver. Deleted:

svn commit: r360001 - in head/sys/dev: mpr mps

2020-04-15 Thread Scott Long
Author: scottl Date: Thu Apr 16 03:28:28 2020 New Revision: 360001 URL: https://svnweb.freebsd.org/changeset/base/360001 Log: Add a small hack to the ioctl header files so that both mpr and mps can be included. This isn't a great solution, but fixing it correctly is a bigger task and this

Re: svn commit: r359168 - head

2020-03-24 Thread Scott Long
On Tue, Mar 24, 2020, at 3:45 PM, Gleb Smirnoff wrote: > On Fri, Mar 20, 2020 at 04:02:46PM +, Ed Maste wrote: > E> Author: emaste > E> Date: Fri Mar 20 16:02:45 2020 > E> New Revision: 359168 > E> URL: https://svnweb.freebsd.org/changeset/base/359168 > E> > E> Log: > E> remove ancient

svn commit: r359187 - head/usr.sbin/pciconf

2020-03-20 Thread Scott Long
Author: scottl Date: Fri Mar 20 23:26:37 2020 New Revision: 359187 URL: https://svnweb.freebsd.org/changeset/base/359187 Log: When printing out the contents of the VSEC, include the contents of the headers. Device documentation often times give offsets relative to the start of the entire

svn commit: r358490 - stable/11/sys/cam/ata

2020-03-01 Thread Scott Long
Author: scottl Date: Sun Mar 1 18:03:09 2020 New Revision: 358490 URL: https://svnweb.freebsd.org/changeset/base/358490 Log: Add a quirk for the WDC Green series of SSDs to disable NCQ TRIM, as this avoids silent data corruption. PR: 225666 Submitted by: anders lundgren

svn commit: r358489 - stable/12/sys/cam/ata

2020-03-01 Thread Scott Long
Author: scottl Date: Sun Mar 1 18:02:00 2020 New Revision: 358489 URL: https://svnweb.freebsd.org/changeset/base/358489 Log: Add a quirk for the WDC Green series of SSDs to disable NCQ TRIM, as this avoids silent data corruption. PR: 225666 Submitted by: anders lundgren

svn commit: r358366 - head/sys/cam/ata

2020-02-26 Thread Scott Long
Author: scottl Date: Thu Feb 27 05:00:21 2020 New Revision: 358366 URL: https://svnweb.freebsd.org/changeset/base/358366 Log: Add a quirk for the WDC Green series of SSDs to disable NCQ TRIM, as this avoids silent data corruption. PR: 225666 Submitted by: anders lundgren

svn commit: r358041 - head/sys/dev/altera/sdcard

2020-02-17 Thread Scott Long
Author: scottl Date: Mon Feb 17 20:12:34 2020 New Revision: 358041 URL: https://svnweb.freebsd.org/changeset/base/358041 Log: Fix syntax error from r357647. Adjust a variable name to make the use more clear. Reported by: dim Modified: head/sys/dev/altera/sdcard/altera_sdcard_io.c

svn commit: r358009 - in head/sys: cam/ata cam/nvme cam/scsi ufs/ffs ufs/ufs

2020-02-16 Thread Scott Long
Author: scottl Date: Sun Feb 16 23:10:59 2020 New Revision: 358009 URL: https://svnweb.freebsd.org/changeset/base/358009 Log: Add rudamentary support for UFS to probe whether a block device supports the BIO_SPEEDUP command. Add complimentary support to the CAM periphs that support it.

svn commit: r357730 - in head/sys: cam/ata cam/nvme cam/scsi ufs/ffs ufs/ufs

2020-02-10 Thread Scott Long
Author: scottl Date: Mon Feb 10 14:27:28 2020 New Revision: 357730 URL: https://svnweb.freebsd.org/changeset/base/357730 Log: Revert r357710 and 357711 until they can be debugged Modified: head/sys/cam/ata/ata_da.c head/sys/cam/nvme/nvme_da.c head/sys/cam/scsi/scsi_da.c

Re: svn commit: r357710 - in head/sys: cam/ata cam/nvme cam/scsi ufs/ffs

2020-02-09 Thread Scott Long
>> >> It seems that this commit makes our systems to hang at the point, when trying >> to mount the >> root partition, last seen message on console is: >> >> [...] >> mountroot: waiting for device /dev/gpt/root... >> >> >> The root partitions on those systems resides on UFS2 formated SSDs (if

Re: svn commit: r357710 - in head/sys: cam/ata cam/nvme cam/scsi ufs/ffs

2020-02-09 Thread Scott Long
> On Feb 9, 2020, at 10:01 PM, O. Hartmann wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Am Mon, 10 Feb 2020 00:23:20 +0000 (UTC) > Scott Long schrieb: > >> Author: scottl >> Date: Mon Feb 10 00:23:20 2020 >> New Revision:

svn commit: r357711 - head/sys/ufs/ufs

2020-02-09 Thread Scott Long
Author: scottl Date: Mon Feb 10 00:26:41 2020 New Revision: 357711 URL: https://svnweb.freebsd.org/changeset/base/357711 Log: Missed a file in r357710, add it here. Modified: head/sys/ufs/ufs/ufsmount.h Modified: head/sys/ufs/ufs/ufsmount.h

svn commit: r357710 - in head/sys: cam/ata cam/nvme cam/scsi ufs/ffs

2020-02-09 Thread Scott Long
Author: scottl Date: Mon Feb 10 00:23:20 2020 New Revision: 357710 URL: https://svnweb.freebsd.org/changeset/base/357710 Log: Add rudamentary support for UFS to probe whether a block device supports the BIO_SPEEDUP command. Add complimentary support to the CAM periphs that support it.

svn commit: r357651 - in head: sys/dev/mpr sys/dev/mps usr.sbin/mpsutil

2020-02-07 Thread Scott Long
Author: scottl Date: Fri Feb 7 12:15:39 2020 New Revision: 357651 URL: https://svnweb.freebsd.org/changeset/base/357651 Log: Advertise the MPI Message Version that's contained in the IOCFacts message in the sysctl block for the driver. mpsutil/mprutil needs this so it can know how big of

svn commit: r357650 - head/usr.sbin/mpsutil

2020-02-07 Thread Scott Long
Author: scottl Date: Fri Feb 7 11:48:26 2020 New Revision: 357650 URL: https://svnweb.freebsd.org/changeset/base/357650 Log: Touch up some of the iocfacts fields Modified: head/usr.sbin/mpsutil/mps_show.c Modified: head/usr.sbin/mpsutil/mps_show.c

svn commit: r357647 - in head/sys: cam/ata cam/mmc cam/nvme cam/scsi dev/aac dev/altera/avgen dev/altera/sdcard dev/amr dev/cfi dev/flash dev/ida dev/ips dev/mfi dev/mlx dev/mmc dev/nvme dev/pst de...

2020-02-07 Thread Scott Long
Author: scottl Date: Fri Feb 7 09:22:08 2020 New Revision: 357647 URL: https://svnweb.freebsd.org/changeset/base/357647 Log: Ever since the block layer expanded its command syntax beyond just BIO_READ and BIO_WRITE, we've handled this expanded syntax poorly in drivers when the driver

svn commit: r356762 - head/usr.sbin/pciconf

2020-01-15 Thread Scott Long
Author: scottl Date: Wed Jan 15 16:47:44 2020 New Revision: 356762 URL: https://svnweb.freebsd.org/changeset/base/356762 Log: Fix a spacing error from the previous commit for -ll mode. Add a little more space padding to that mode to give the columns a consistent offset. Modified:

Re: svn commit: r356192 - head/sys/geom

2020-01-04 Thread Scott Long
Good job! > On Dec 29, 2019, at 7:46 PM, Alexander Motin wrote: > > Author: mav > Date: Mon Dec 30 00:46:10 2019 > New Revision: 356192 > URL: https://svnweb.freebsd.org/changeset/base/356192 > > Log: > Retire nstart/nend counters. > > Those counters were abused for decade to workaround

svn commit: r356267 - head/usr.sbin/pciconf

2020-01-01 Thread Scott Long
Author: scottl Date: Thu Jan 2 06:56:28 2020 New Revision: 356267 URL: https://svnweb.freebsd.org/changeset/base/356267 Log: Add a compact columnar output format, available by specifying a second '-l' command line option. Thanks to the removal of unnecessary information and the

svn commit: r356098 - head/sys/dev/pci

2019-12-26 Thread Scott Long
Author: scottl Date: Thu Dec 26 21:00:06 2019 New Revision: 356098 URL: https://svnweb.freebsd.org/changeset/base/356098 Log: Abstract the locking for PCIe hotplug. It still uses Giant so there's no functional change yet. Modified: head/sys/dev/pci/pci_pci.c

svn commit: r356052 - head/sys/dev/mpr

2019-12-24 Thread Scott Long
Author: scottl Date: Tue Dec 24 14:50:17 2019 New Revision: 356052 URL: https://svnweb.freebsd.org/changeset/base/356052 Log: Convert the mpr driver to use busdma templates. Modified: head/sys/dev/mpr/mpr.c head/sys/dev/mpr/mpr_pci.c head/sys/dev/mpr/mpr_user.c Modified:

svn commit: r356051 - head/sys/sys

2019-12-24 Thread Scott Long
Author: scottl Date: Tue Dec 24 14:49:37 2019 New Revision: 356051 URL: https://svnweb.freebsd.org/changeset/base/356051 Log: Bump __FreeBSD_version for the addition of busdma templates. Modified: head/sys/sys/param.h Modified: head/sys/sys/param.h

svn commit: r356050 - in head: share/man/man9 sys/arm/arm sys/arm64/arm64 sys/mips/mips sys/powerpc/powerpc sys/riscv/riscv sys/sparc64/sparc64 sys/sys sys/x86/x86

2019-12-24 Thread Scott Long
Author: scottl Date: Tue Dec 24 14:48:46 2019 New Revision: 356050 URL: https://svnweb.freebsd.org/changeset/base/356050 Log: Introduce the concept of busdma tag templates. A template can be allocated off the stack, initialized to default values, and then filled in with driver-specific

svn commit: r355741 - in head: sys/dev/pci usr.sbin/pciconf

2019-12-13 Thread Scott Long
Author: scottl Date: Fri Dec 13 23:46:59 2019 New Revision: 355741 URL: https://svnweb.freebsd.org/changeset/base/355741 Log: Add accessors for the Vendor Specific Extended Capability (VSEC) Parse out the VSEC. If the user invokes a second -c command line option, do a hex dump of the

svn commit: r355701 - stable/11/sys/x86/x86

2019-12-12 Thread Scott Long
Author: scottl Date: Fri Dec 13 06:54:41 2019 New Revision: 355701 URL: https://svnweb.freebsd.org/changeset/base/355701 Log: Merge r355134,355375,355589 Clean up and clarify meta commentary on TAA. Add a state to denote that TSX doesn't exist on the CPU. x86: Add missed break to

svn commit: r355698 - stable/12/sys/x86/x86

2019-12-12 Thread Scott Long
Author: scottl Date: Fri Dec 13 05:29:26 2019 New Revision: 355698 URL: https://svnweb.freebsd.org/changeset/base/355698 Log: Merge r355134,355375,355589 Clean up and clarify meta commentary on TAA. Add a state to denote that TSX doesn't exist on the CPU. x86: Add missed break to

Re: svn commit: r355430 - head/sys/cam/scsi

2019-12-11 Thread Scott Long
U+FFFD doesn’t make sense for an ASCII string, but 0x3F might. Any idea what Windows shows for this device? Scott > On Dec 11, 2019, at 8:42 AM, Alan Somers wrote: > > In this case the offending descriptor is solid 0xFF, so replacing individual > characters wouldn't accomplish anything. I

svn commit: r355589 - head/sys/x86/x86

2019-12-10 Thread Scott Long
Author: scottl Date: Tue Dec 10 18:57:39 2019 New Revision: 355589 URL: https://svnweb.freebsd.org/changeset/base/355589 Log: Fix the TAA state machine to do the right thing when the TAA migitation is available in microcode and the operator has set the sysctl to automatic mode.

Re: svn commit: r355436 - in head/sys: amd64/amd64 x86/x86

2019-12-06 Thread Scott Long
ote: > > > >> On Dec 6, 2019, at 4:36 AM, Ed Maste wrote: >> >> On Thu, 5 Dec 2019 at 21:43, Scott Long wrote: >>> >>> Author: scottl >>> Date: Fri Dec 6 02:43:05 2019 >>> New Revision: 355436 >>> URL: https://svnweb.free

svn commit: r355440 - stable/12/sys/amd64/vmm/intel

2019-12-06 Thread Scott Long
Author: scottl Date: Fri Dec 6 09:50:01 2019 New Revision: 355440 URL: https://svnweb.freebsd.org/changeset/base/355440 Log: MFC r349184. This fixing PCI passthrough via VT-d on modern chipsets with multiple translation units. PR: 229852 Submitted by: cal...@mitchison.org

svn commit: r355436 - in head/sys: amd64/amd64 x86/x86

2019-12-05 Thread Scott Long
Author: scottl Date: Fri Dec 6 02:43:05 2019 New Revision: 355436 URL: https://svnweb.freebsd.org/changeset/base/355436 Log: Move the mds, irbs, and ssb mitigation knobs into machdep.mitigations. They're in both the old and new places in HEAD for the moment for discussion and transition.

svn commit: r355429 - head/sys/dev/sound/pci/hda

2019-12-05 Thread Scott Long
Author: scottl Date: Thu Dec 5 19:39:51 2019 New Revision: 355429 URL: https://svnweb.freebsd.org/changeset/base/355429 Log: Add support for new sound HDA hardware Sponsored by: Intel Modified: head/sys/dev/sound/pci/hda/hdac.c head/sys/dev/sound/pci/hda/hdac.h

svn commit: r355310 - svnadmin/conf

2019-12-02 Thread Scott Long
Author: scottl Date: Mon Dec 2 22:15:26 2019 New Revision: 355310 URL: https://svnweb.freebsd.org/changeset/base/355310 Log: I took over mentorship of Scott Philips a while ago, update the mentors file appropriately. Modified: svnadmin/conf/mentors Modified: svnadmin/conf/mentors

svn commit: r355164 - in head: . share/man/man4 sys/amd64/conf sys/conf sys/dev/trm sys/i386/conf sys/modules sys/modules/trm

2019-11-27 Thread Scott Long
Author: scottl Date: Thu Nov 28 02:32:17 2019 New Revision: 355164 URL: https://svnweb.freebsd.org/changeset/base/355164 Log: Remove the trm(4) driver Differential Revision:https://reviews.freebsd.org/D22575 Deleted: head/share/man/man4/trm.4 head/sys/dev/trm/

svn commit: r355134 - head/sys/x86/x86

2019-11-27 Thread Scott Long
Author: scottl Date: Wed Nov 27 19:12:32 2019 New Revision: 355134 URL: https://svnweb.freebsd.org/changeset/base/355134 Log: Clean up and clarify meta commentary on TAA. Add a state to denote that TSX doesn't exist on the CPU. MFC after:3 days Sponsored by: Intel Modified:

svn commit: r355118 - in stable/12: share/man/man4 sys/dev/hpt27xx

2019-11-26 Thread Scott Long
Author: scottl Date: Tue Nov 26 19:04:19 2019 New Revision: 355118 URL: https://svnweb.freebsd.org/changeset/base/355118 Log: Partially revert r355028. hpt27xx is not Giant-locked in FreeBSD 12.x, so is it not going to be deprecated. Reported by: imp Modified:

svn commit: r355114 - in head: share/man/man4 sys/dev/hpt27xx

2019-11-26 Thread Scott Long
Author: scottl Date: Tue Nov 26 17:25:49 2019 New Revision: 355114 URL: https://svnweb.freebsd.org/changeset/base/355114 Log: Revert r355021. In my haste to grep for Giant, I missed that it was in conditional ifdefs for this driver. We will consider removing those ifdefs in the future.

svn commit: r355028 - in stable/12: share/man/man4 sys/dev/hpt27xx sys/dev/trm

2019-11-22 Thread Scott Long
Author: scottl Date: Sat Nov 23 07:06:16 2019 New Revision: 355028 URL: https://svnweb.freebsd.org/changeset/base/355028 Log: MFC 355012 and 355021. Mark trm and hpt27xx for removal in 13.0 Modified: stable/12/share/man/man4/hpt27xx.4 stable/12/share/man/man4/trm.4

svn commit: r355021 - in head: share/man/man4 sys/dev/hpt27xx

2019-11-22 Thread Scott Long
Author: scottl Date: Fri Nov 22 20:23:22 2019 New Revision: 355021 URL: https://svnweb.freebsd.org/changeset/base/355021 Log: Mark hpt27xx for removal in 13.0; all CAM drivers will be Giant-free by then. Relnotes: yes Modified: head/share/man/man4/hpt27xx.4

svn commit: r355012 - in head: share/man/man4 sys/dev/trm

2019-11-22 Thread Scott Long
Author: scottl Date: Fri Nov 22 18:50:53 2019 New Revision: 355012 URL: https://svnweb.freebsd.org/changeset/base/355012 Log: Schedule the trm(4) driver for removal. It relies on Giant and thus has required compat shims in CAM for 12 years. Relnotes: yes Modified:

svn commit: r355009 - head/sys/cam/scsi

2019-11-22 Thread Scott Long
Author: scottl Date: Fri Nov 22 18:18:36 2019 New Revision: 355009 URL: https://svnweb.freebsd.org/changeset/base/355009 Log: Remove NEEDGIANT from the scsi_sg /dev node. It likely has not been needed for many years. Reported by: imp Modified: head/sys/cam/scsi/scsi_sg.c Modified:

svn commit: r354764 - in stable/11/sys: amd64/amd64 dev/cpuctl x86/include x86/x86

2019-11-15 Thread Scott Long
Author: scottl Date: Sat Nov 16 00:52:04 2019 New Revision: 354764 URL: https://svnweb.freebsd.org/changeset/base/354764 Log: MFC r354759: TSX Asynchronous Abort mitigation for Intel CVE-2019-11135. This CVE has already been announced in FreeBSD SA-19:26.mcu. Mitigation for TAA

svn commit: r354763 - in stable/12/sys: amd64/amd64 dev/cpuctl x86/include x86/x86

2019-11-15 Thread Scott Long
Author: scottl Date: Sat Nov 16 00:36:42 2019 New Revision: 354763 URL: https://svnweb.freebsd.org/changeset/base/354763 Log: MFC r354759: TSX Asynchronous Abort mitigation for Intel CVE-2019-11135. This CVE has already been announced in FreeBSD SA-19:26.mcu. Mitigation for TAA

svn commit: r354762 - in stable/11/sys: kern sys

2019-11-15 Thread Scott Long
Author: scottl Date: Sat Nov 16 00:33:02 2019 New Revision: 354762 URL: https://svnweb.freebsd.org/changeset/base/354762 Log: MFC r354756: Create a new sysctl tree, machdep.mitigations Sponsored by: Intel Modified: stable/11/sys/kern/kern_mib.c stable/11/sys/sys/sysctl.h

svn commit: r354761 - in stable/12/sys: amd64/amd64 dev/cpuctl x86/include x86/x86

2019-11-15 Thread Scott Long
Author: scottl Date: Sat Nov 16 00:31:57 2019 New Revision: 354761 URL: https://svnweb.freebsd.org/changeset/base/354761 Log: Partially revert r354760, it included a patch that wasn't ready yet. Modified: stable/12/sys/amd64/amd64/machdep.c stable/12/sys/dev/cpuctl/cpuctl.c

svn commit: r354760 - in stable/12/sys: amd64/amd64 dev/cpuctl kern sys x86/include x86/x86

2019-11-15 Thread Scott Long
Author: scottl Date: Sat Nov 16 00:29:26 2019 New Revision: 354760 URL: https://svnweb.freebsd.org/changeset/base/354760 Log: MFC r354756: Create a new sysctl tree, machdep.mitigations Sponsored by: Intel Modified: stable/12/sys/amd64/amd64/machdep.c

svn commit: r354759 - in head/sys: amd64/amd64 dev/cpuctl x86/include x86/x86

2019-11-15 Thread Scott Long
Author: scottl Date: Sat Nov 16 00:26:42 2019 New Revision: 354759 URL: https://svnweb.freebsd.org/changeset/base/354759 Log: TSX Asynchronous Abort mitigation for Intel CVE-2019-11135. This CVE has already been announced in FreeBSD SA-19:26.mcu. Mitigation for TAA involves either

svn commit: r354756 - in head/sys: kern sys

2019-11-15 Thread Scott Long
Author: scottl Date: Fri Nov 15 23:27:17 2019 New Revision: 354756 URL: https://svnweb.freebsd.org/changeset/base/354756 Log: Create a new sysctl subtree, machdep.mitigations. Its purpose is to organize knobs and indicators for code that mitigates functional and security issues in the

Re: svn commit: r354703 - head/sys/dev/ioat

2019-11-15 Thread Scott Long
> On Nov 15, 2019, at 2:18 AM, Konstantin Belousov wrote: > > On Thu, Nov 14, 2019 at 09:41:36AM -0500, Alexander Motin wrote: >> On 14.11.2019 05:11, Konstantin Belousov wrote: >>> On Thu, Nov 14, 2019 at 04:39:49AM +, Alexander Motin wrote: Author: mav Date: Thu Nov 14 04:39:48

svn commit: r354730 - head/sys/x86/x86

2019-11-15 Thread Scott Long
Author: scottl Date: Fri Nov 15 11:54:51 2019 New Revision: 354730 URL: https://svnweb.freebsd.org/changeset/base/354730 Log: Revert a patch that accidentally was committed with r354729 Modified: head/sys/x86/x86/busdma_machdep.c Modified: head/sys/x86/x86/busdma_machdep.c

svn commit: r354729 - head/sys/x86/x86

2019-11-15 Thread Scott Long
Author: scottl Date: Fri Nov 15 11:53:06 2019 New Revision: 354729 URL: https://svnweb.freebsd.org/changeset/base/354729 Log: Fix a typo in how the AVX512DQ feature bit is checked. Reviewed by: kib Sponsored by: Intel Modified: head/sys/x86/x86/busdma_machdep.c

svn commit: r354683 - head/sys/dev/fb

2019-11-13 Thread Scott Long
Author: scottl Date: Wed Nov 13 15:31:31 2019 New Revision: 354683 URL: https://svnweb.freebsd.org/changeset/base/354683 Log: Stop the VESA driver from whining loudly in the dmesg during boot on systems that use EFI instead of BIOS. Modified: head/sys/dev/fb/vesa.c Modified:

svn commit: r354658 - in stable/11/sys/x86: include x86

2019-11-12 Thread Scott Long
Author: scottl Date: Tue Nov 12 19:35:46 2019 New Revision: 354658 URL: https://svnweb.freebsd.org/changeset/base/354658 Log: MFC: Add new bit definitions for TSX, related to the TAA issue. The actual mitigation will follow in a future commit. Obtained from:Intel Modified:

svn commit: r354657 - in stable/12/sys/x86: include x86

2019-11-12 Thread Scott Long
Author: scottl Date: Tue Nov 12 19:29:32 2019 New Revision: 354657 URL: https://svnweb.freebsd.org/changeset/base/354657 Log: MFC: Add new bit definitions for TSX, related to the TAA issue. The actual mitigation will follow in a future commit. Sponsored by: Intel Modified:

svn commit: r354655 - in head/sys/x86: include x86

2019-11-12 Thread Scott Long
Author: scottl Date: Tue Nov 12 19:15:16 2019 New Revision: 354655 URL: https://svnweb.freebsd.org/changeset/base/354655 Log: Add new bit definitions for TSX, related to the TAA issue. The actual mitigation will follow in a future commit. Sponsored by: Intel Modified:

svn commit: r354631 - head/sys/x86/x86

2019-11-11 Thread Scott Long
Author: scottl Date: Mon Nov 11 22:18:05 2019 New Revision: 354631 URL: https://svnweb.freebsd.org/changeset/base/354631 Log: Add the text attribute for MDS_NO in the IA32_ARCH_CAP MSR. Modified: head/sys/x86/x86/identcpu.c Modified: head/sys/x86/x86/identcpu.c

svn commit: r354143 - head/sys/dev/sound/pci/hda

2019-10-28 Thread Scott Long
Author: scottl Date: Mon Oct 28 23:31:22 2019 New Revision: 354143 URL: https://svnweb.freebsd.org/changeset/base/354143 Log: Add device IDs for the next generation of Intel HDA audio. MFC after:3 days Modified: head/sys/dev/sound/pci/hda/hdac.c head/sys/dev/sound/pci/hda/hdac.h

svn commit: r353462 - head/usr.sbin/pciconf

2019-10-12 Thread Scott Long
Author: scottl Date: Sun Oct 13 05:11:53 2019 New Revision: 353462 URL: https://svnweb.freebsd.org/changeset/base/353462 Log: Fix the botched field ordering in the last commit. While here, fix whitespace, and also reorder the fields so they are easier to read on an 80 column display (the

Re: svn commit: r353456 - head/usr.sbin/pciconf

2019-10-12 Thread Scott Long
> On Oct 12, 2019, at 7:10 PM, Rodney W. Grimes > wrote: > >> Author: scottl >> Date: Sat Oct 12 22:27:57 2019 >> New Revision: 353456 >> URL: https://svnweb.freebsd.org/changeset/base/353456 >> >> Log: >> Change from the non-standard nomenclature of "chip" and "card" to the >> standard

svn commit: r353456 - head/usr.sbin/pciconf

2019-10-12 Thread Scott Long
Author: scottl Date: Sat Oct 12 22:27:57 2019 New Revision: 353456 URL: https://svnweb.freebsd.org/changeset/base/353456 Log: Change from the non-standard nomenclature of "chip" and "card" to the standard nomenclature of "device" and "vendor" with the "sub" variants. This changes the

svn commit: r351939 - head/share/misc

2019-09-06 Thread Scott Long
Author: scottl Date: Fri Sep 6 17:06:48 2019 New Revision: 351939 URL: https://svnweb.freebsd.org/changeset/base/351939 Log: Add myself as a mentor for Scott Phillip (scottph) Modified: head/share/misc/committers-src.dot Modified: head/share/misc/committers-src.dot

svn commit: r345573 - in head/sys/dev: mpr mps

2019-09-03 Thread Scott Long
Author: scottl Date: Wed Mar 27 12:25:46 2019 New Revision: 345573 URL: https://svnweb.freebsd.org/changeset/base/345573 Log: Add missing break statements. Coverity CID 1400446. Reported by: mav Modified: head/sys/dev/mpr/mpr_table.c head/sys/dev/mps/mps_table.c Modified:

Re: svn commit: r351550 - head/sys/cam/scsi

2019-08-27 Thread Scott Long
To diagnose it I inserted assertion into > xpt_free_ccb(), checking ccb->ccb_h.pinfo.index for values used for > requests still in send queue. Not sure it is to be persistent, but in > this case it lead me directly to this place. > > On 27.08.2019 16:23, Scott Long wrote: >

Re: svn commit: r351550 - head/sys/cam/scsi

2019-08-27 Thread Scott Long
This is very concerning, and I wonder if it’s the cause of the mystery use-after-free / double-complete that I’ve seen for years and have never been able to catch. Can you say more about how you found it? Scott > On Aug 27, 2019, at 10:41 AM, Alexander Motin wrote: > > Author: mav > Date:

  1   2   3   4   5   6   >