Re: svn commit: r305952 - head/lib/libc/gen

2016-09-19 Thread John Baldwin 
On Monday, September 19, 2016 07:34:54 PM Ed Schouten wrote:
> 2016-09-19 18:06 GMT+02:00 John Baldwin :
> > Don't you need the _Generic hack we have for basename now?
> 
> The _Generic() hack that we have in place is for dirname() right now.
> I'll extend it to also cover basename() when replacing that function
> as well.

Oh, somehow I had misread this commit to be the commit to fix the
other one rather than a followup to the previous change.

-- 
John Baldwin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r305952 - head/lib/libc/gen

2016-09-19 Thread Ed Schouten 
2016-09-19 18:06 GMT+02:00 John Baldwin :
> Don't you need the _Generic hack we have for basename now?

The _Generic() hack that we have in place is for dirname() right now.
I'll extend it to also cover basename() when replacing that function
as well.

While we're on the subject, anyone willing to review this change? :-)

https://reviews.freebsd.org/D7844

-- 
Ed Schouten 
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r305952 - head/lib/libc/gen

2016-09-19 Thread John Baldwin 
On Sunday, September 18, 2016 08:47:55 PM Ed Schouten wrote:
> Author: ed
> Date: Sun Sep 18 20:47:55 2016
> New Revision: 305952
> URL: https://svnweb.freebsd.org/changeset/base/305952
> 
> Log:
>   Replace dirname(3) by a copy that complies to POSIX.
>   
>   It turns out that the path normalization that our brand new copy of
>   dirname(3) does is actually not allowed by the draft version of the
>   upcoming version of POSIX. It has to behave identically to the
>   dirname(1) utility.
>   
>   This change replaces our new dirname(3) implementation by yet another
>   version that doesn't implement the path normalization logic; it merely
>   looks for the end of the directory name and overwrites that with a null
>   byte.
>   
>   More details: See note #3370 at http://austingroupbugs.net/view.php?id=1073

Don't you need the _Generic hack we have for basename now?

-- 
John Baldwin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"