Re: svn commit: r288984 - head/sbin/sysctl

2015-10-07 Thread Baptiste Daroussin
On Wed, Oct 07, 2015 at 03:41:52PM -0700, NGie Cooper wrote: > On Wed, Oct 7, 2015 at 3:35 PM, Baptiste Daroussin wrote: > ... > > I do not think it is, but I couldn't find a way to reproduce another case > > than > > ENOENT, so I thought maybe the best would be to keep the current behaviour > >

Re: svn commit: r288984 - head/sbin/sysctl

2015-10-07 Thread Steven Hartland
On 07/10/2015 23:41, NGie Cooper wrote: On Wed, Oct 7, 2015 at 3:35 PM, Baptiste Daroussin wrote: ... I do not think it is, but I couldn't find a way to reproduce another case than ENOENT, so I thought maybe the best would be to keep the current behaviour for other cases :) Can't hit ENOTDIR

Re: svn commit: r288984 - head/sbin/sysctl

2015-10-07 Thread Bryan Drewery
On 10/7/2015 3:41 PM, NGie Cooper wrote: > On Wed, Oct 7, 2015 at 3:35 PM, Baptiste Daroussin wrote: > ... >> I do not think it is, but I couldn't find a way to reproduce another case >> than >> ENOENT, so I thought maybe the best would be to keep the current behaviour >> for >> other cases :) >

Re: svn commit: r288984 - head/sbin/sysctl

2015-10-07 Thread NGie Cooper
On Wed, Oct 7, 2015 at 3:35 PM, Baptiste Daroussin wrote: ... > I do not think it is, but I couldn't find a way to reproduce another case than > ENOENT, so I thought maybe the best would be to keep the current behaviour for > other cases :) Can't hit ENOTDIR: # sysctl kern=ireallyshouldnotbedoin

Re: svn commit: r288984 - head/sbin/sysctl

2015-10-07 Thread Baptiste Daroussin
On Wed, Oct 07, 2015 at 02:56:02PM -0700, Conrad Meyer wrote: > On Wed, Oct 7, 2015 at 2:28 AM, Baptiste Daroussin wrote: > > --- head/sbin/sysctl/sysctl.c Wed Oct 7 09:12:49 2015(r288983) > > +++ head/sbin/sysctl/sysctl.c Wed Oct 7 09:28:54 2015(r288984) > > @@ -276,7 +276,1

Re: svn commit: r288984 - head/sbin/sysctl

2015-10-07 Thread Conrad Meyer
On Wed, Oct 7, 2015 at 2:28 AM, Baptiste Daroussin wrote: > --- head/sbin/sysctl/sysctl.c Wed Oct 7 09:12:49 2015(r288983) > +++ head/sbin/sysctl/sysctl.c Wed Oct 7 09:28:54 2015(r288984) > @@ -276,7 +276,11 @@ parse(const char *string, int lineno) > if (qflag

svn commit: r288984 - head/sbin/sysctl

2015-10-07 Thread Baptiste Daroussin
Author: bapt Date: Wed Oct 7 09:28:54 2015 New Revision: 288984 URL: https://svnweb.freebsd.org/changeset/base/288984 Log: Only print the errno string in case sysctl(3) does not file with ENOENT This reduces the noise in error reporing from sysctl(8): Before: $ sysctl bla=something s