Re: bug triaging (was: Re: svn commit: r331728 - in stable/11/etc: . rc.d)

> This is addressed to developers in general, not just rgrimes, but he > made the comments, so ... :-) > > On Thu, Mar 29, 2018 at 09:33:44AM -0700, Rodney W. Grimes wrote: > > It seems that the Phabricator review system is somewhat dysfunctional > > in that actual review is only happening in

Re: bug triaging (was: Re: svn commit: r331728 - in stable/11/etc: . rc.d)

2018-03-30 11:04 GMT+08:00 Mark Linimon : > This is addressed to developers in general, not just rgrimes, but he > made the comments, so ... > > On Thu, Mar 29, 2018 at 09:33:44AM -0700, Rodney W. Grimes wrote: > > It seems that the Phabricator review system is somewhat

bug triaging (was: Re: svn commit: r331728 - in stable/11/etc: . rc.d)

This is addressed to developers in general, not just rgrimes, but he made the comments, so ... On Thu, Mar 29, 2018 at 09:33:44AM -0700, Rodney W. Grimes wrote: > It seems that the Phabricator review system is somewhat dysfunctional > in that actual review is only happening in some cases. Some

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thu, Mar 29, 2018 at 09:33:44AM -0700, Rodney W. Grimes wrote: > ... > It seems that the Phabricator review system is somewhat disfunctional > in that actual review is only happening in some cases. Some people > have even stated they flat out hate it. Others say that it is the > way to go.

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thu, Mar 29, 2018 at 1:39 PM, Ian Lepore wrote: > On Thu, 2018-03-29 at 09:33 -0700, Rodney W. Grimes wrote: > > > > > > On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > > > > > > > > > > > > > > > > > > Author: araujo > > > > > Date: Thu Mar 29 04:51:07 2018 >

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thu, 2018-03-29 at 09:33 -0700, Rodney W. Grimes wrote: > > > > On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > > > > > > > > > > > > > > Author: araujo > > > > Date: Thu Mar 29 04:51:07 2018 > > > > New Revision: 331728 > > > > URL:

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thu, Mar 29, 2018 at 11:45 AM, John Baldwin wrote: > On Thursday, March 29, 2018 09:33:44 AM Rodney W. Grimes wrote: > > > On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > > That's not a blocker for committing; plenty of time elapsed to allow > > > anyone to

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thursday, March 29, 2018 09:33:44 AM Rodney W. Grimes wrote: > > On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > That's not a blocker for committing; plenty of time elapsed to allow > > anyone to reject the change. IMO, even a flat-out rejection isn't a > > blocker to committing

Re: svn commit: r331728 - in stable/11/etc: . rc.d

> On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > > > > > Author: araujo > > > Date: Thu Mar 29 04:51:07 2018 > > > New Revision: 331728 > > > URL: https://svnweb.freebsd.org/changeset/base/331728 > > > > > > Log: > > > ? MFC r329817: > > I must of missed this when it landed in

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > > > Author: araujo > > Date: Thu Mar 29 04:51:07 2018 > > New Revision: 331728 > > URL: https://svnweb.freebsd.org/changeset/base/331728 > > > > Log: > >   MFC r329817: > I must of missed this when it landed in ^/head > > > > >  

Re: svn commit: r331728 - in stable/11/etc: . rc.d

On Thu, Mar 29, 2018, 9:20 PM Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: araujo > > Date: Thu Mar 29 04:51:07 2018 > > New Revision: 331728 > > URL: https://svnweb.freebsd.org/changeset/base/331728 > > > > Log: > > MFC r329817: > > I must of missed this when it landed

Re: svn commit: r331728 - in stable/11/etc: . rc.d

> Author: araujo > Date: Thu Mar 29 04:51:07 2018 > New Revision: 331728 > URL: https://svnweb.freebsd.org/changeset/base/331728 > > Log: > MFC r329817: I must of missed this when it landed in ^/head > The firewall_type is ignored if not set in rc.conf or rc.conf.local, > after r190575

svn commit: r331728 - in stable/11/etc: . rc.d

Author: araujo Date: Thu Mar 29 04:51:07 2018 New Revision: 331728 URL: https://svnweb.freebsd.org/changeset/base/331728 Log: MFC r329817: The firewall_type is ignored if not set in rc.conf or rc.conf.local, after r190575 there is an option to call rc.firewall with the firewall_type