Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86

2018-04-09 Thread Rodney W. Grimes
> On Fri, Apr 06, 2018 at 09:17:09AM -0700, Rodney W. Grimes wrote: > > [ Charset UTF-8 unsupported, converting... ] > > > Author: royger > > > Date: Fri Apr 6 11:20:06 2018 > > > New Revision: 332092 > > > URL: https://svnweb.freebsd.org/changeset/base/332092 > > > > > > Log: > > > remove

Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86

2018-04-09 Thread Roger Pau Monné
On Fri, Apr 06, 2018 at 09:17:09AM -0700, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] > > Author: royger > > Date: Fri Apr 6 11:20:06 2018 > > New Revision: 332092 > > URL: https://svnweb.freebsd.org/changeset/base/332092 > > > > Log: > > remove GiB/MiB macros from

Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86

2018-04-07 Thread Rodney W. Grimes
> On Fri, Apr 06, 2018 at 07:14:42AM -0700, Conrad Meyer wrote: > > I like something like this for clarity. But I don't see any reason > > for these function-like macros instead of the more general definition > > of an SI prefix constant multiple. A multiple works with numeric > > literals and

Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86

2018-04-07 Thread Alexey Dokuchaev
On Fri, Apr 06, 2018 at 07:14:42AM -0700, Conrad Meyer wrote: > I like something like this for clarity. But I don't see any reason > for these function-like macros instead of the more general definition > of an SI prefix constant multiple. A multiple works with numeric > literals and variables

Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86

2018-04-06 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > Author: royger > Date: Fri Apr 6 11:20:06 2018 > New Revision: 332092 > URL: https://svnweb.freebsd.org/changeset/base/332092 > > Log: > remove GiB/MiB macros from param.h > > And instead define them in the files where they are used. It

Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86

2018-04-06 Thread Conrad Meyer
I like something like this for clarity. But I don't see any reason for these function-like macros instead of the more general definition of an SI prefix constant multiple. A multiple works with numeric literals and variables alike. Something like: #define GiB ((size_t)1 << 30) my_foo = 15 *

Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86

2018-04-06 Thread Bruce Evans
On Fri, 6 Apr 2018, [UTF-8] Roger Pau Monn?? wrote: Log: remove GiB/MiB macros from param.h And instead define them in the files where they are used. Requested by: bde Thanks, but these files have a negative need for the macros. Modified: head/sys/amd64/amd64/mp_machdep.c

svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86

2018-04-06 Thread Roger Pau Monné
Author: royger Date: Fri Apr 6 11:20:06 2018 New Revision: 332092 URL: https://svnweb.freebsd.org/changeset/base/332092 Log: remove GiB/MiB macros from param.h And instead define them in the files where they are used. Requested by: bde Modified: head/sys/amd64/amd64/mp_machdep.c