Re: svn commit: r335836 - head/usr.bin/top

2018-07-09 Thread 後藤大地 via svn-src-all
I summarized in the Phabricator. Check it out please. https://reviews.freebsd.org/D16203 > 2018/07/05 1:37、Hiroki Sato のメール: > > Hiroki Sato wrote > in <20180703.020956.859981414196673670@allbsd.org>: > > hr> 後藤大地 wrote > hr> in <459bd898-8072-426e-a968-96c1382ac...@icloud.com>: >

Re: svn commit: r335836 - head/usr.bin/top

2018-07-04 Thread 後藤大地 via svn-src-all
I think that’s fine. I have not been committed for a while, so now I am in the state of being reactive commit bit mentee under George’s mentor. So I sent him an e-mail about rollback, but I have not heard back from him yet. I have been waiting for a reply mail. I planed to roll back as soon as

Re: svn commit: r335836 - head/usr.bin/top

2018-07-04 Thread Eitan Adler
On Wed, 4 Jul 2018 at 09:41, Hiroki Sato wrote: > > Are you going to back out r335836, or disagree about it? > > If there is no objection in the next 24 hours, I will commit the > attached patch. This should be a minimal change to support multibyte > characters in ARGV array depending on

Re: svn commit: r335836 - head/usr.bin/top

2018-07-04 Thread Hiroki Sato
Hiroki Sato wrote in <20180703.020956.859981414196673670@allbsd.org>: hr> 後藤大地 wrote hr> in <459bd898-8072-426e-a968-96c1382ac...@icloud.com>: hr> hr> da> hr> da> hr> da> > 2018/07/02 15:55、Hiroki Sato のメール: hr> da> > hr> da> > Eitan Adler wrote hr> da> > in : hr> da> > hr> da> > li>

Re: svn commit: r335836 - head/usr.bin/top

2018-07-03 Thread Hiroki Sato
Jilles Tjoelker wrote in <20180703211002.ga11...@stack.nl>: ji> > 3. Print the multibyte characters by using strvisx(3) family, which ji> > supports multibyte character, or swprintf(3) family if you want to ji> > format wide characters directly. Note that buffer length for ji> >

Re: svn commit: r335836 - head/usr.bin/top

2018-07-03 Thread Jilles Tjoelker
On Tue, Jul 03, 2018 at 02:09:56AM +0900, Hiroki Sato wrote: > 後藤大地 wrote > in <459bd898-8072-426e-a968-96c1382ac...@icloud.com>: > da> > 2018/07/02 15:55、Hiroki Sato のメール: > da> > Eitan Adler wrote > da> > in > : > da> > li> On 1 July 2018 at 10:08, Conrad Meyer wrote: > da> > li> > I

Re: svn commit: r335836 - head/usr.bin/top

2018-07-02 Thread Warner Losh
Sato-san Sorry for the top post, but your message would make an excellent intro to i18n in one of our developer guides. Warner On Mon, Jul 2, 2018, 11:13 AM Hiroki Sato wrote: > 後藤大地 wrote > in <459bd898-8072-426e-a968-96c1382ac...@icloud.com>: > > da> > da> > da> > 2018/07/02 15:55、Hiroki

Re: svn commit: r335836 - head/usr.bin/top

2018-07-02 Thread Hiroki Sato
後藤大地 wrote in <459bd898-8072-426e-a968-96c1382ac...@icloud.com>: da> da> da> > 2018/07/02 15:55、Hiroki Sato のメール: da> > da> > Eitan Adler wrote da> > in : da> > da> > li> On 1 July 2018 at 10:08, Conrad Meyer wrote: da> > li> > Hi Daichi, da> > li> > da> > li> > da> > li> > da> > li> > I

Re: svn commit: r335836 - head/usr.bin/top

2018-07-02 Thread 後藤大地
> 2018/07/02 2:08、Conrad Meyer のメール: > > Hi Daichi, > > On Sat, Jun 30, 2018 at 10:32 PM, Daichi GOTO wrote: >> Author: daichi >> Date: Sun Jul 1 05:32:03 2018 >> New Revision: 335836 >> URL: https://svnweb.freebsd.org/changeset/base/335836 >> >> Log: >> top(1) - support UTF-8 display >>

Re: svn commit: r335836 - head/usr.bin/top

2018-07-02 Thread 後藤大地
> 2018/07/02 15:55、Hiroki Sato のメール: > > Eitan Adler wrote > in : > > li> On 1 July 2018 at 10:08, Conrad Meyer wrote: > li> > Hi Daichi, > li> > > li> > > li> > > li> > I don't think code to decode UTF-8 belongs in top(1). I don't know > li> > what the goal of this routine is, but I doubt

Re: svn commit: r335836 - head/usr.bin/top

2018-07-02 Thread Hiroki Sato
Eitan Adler wrote in : li> On 1 July 2018 at 10:08, Conrad Meyer wrote: li> > Hi Daichi, li> > li> > li> > li> > I don't think code to decode UTF-8 belongs in top(1). I don't know li> > what the goal of this routine is, but I doubt this is the right way to li> > accomplish it. li> li> For

Re: svn commit: r335836 - head/usr.bin/top

2018-07-01 Thread Eitan Adler
On 1 July 2018 at 10:08, Conrad Meyer wrote: > Hi Daichi, > > > > I don't think code to decode UTF-8 belongs in top(1). I don't know > what the goal of this routine is, but I doubt this is the right way to > accomplish it. For the record, I agree. This is why I didn't click "accept" on the

Re: svn commit: r335836 - head/usr.bin/top

2018-07-01 Thread Conrad Meyer
On Sun, Jul 1, 2018 at 10:08 AM, Conrad Meyer wrote: > (Also, the patch in phabricator does not seem to match what was committed.) It seems the right phabricator URL is https://reviews.freebsd.org/D16058 . Best, Conrad ___ svn-src-all@freebsd.org

Re: svn commit: r335836 - head/usr.bin/top

2018-07-01 Thread Conrad Meyer
Hi Daichi, On Sat, Jun 30, 2018 at 10:32 PM, Daichi GOTO wrote: > Author: daichi > Date: Sun Jul 1 05:32:03 2018 > New Revision: 335836 > URL: https://svnweb.freebsd.org/changeset/base/335836 > > Log: > top(1) - support UTF-8 display > > ... >

svn commit: r335836 - head/usr.bin/top

2018-07-01 Thread Daichi GOTO
Author: daichi Date: Sun Jul 1 05:32:03 2018 New Revision: 335836 URL: https://svnweb.freebsd.org/changeset/base/335836 Log: top(1) - support UTF-8 display Reviewed by: eadler Approved by: gnn (mentor) Differential Revision:https://reviews.freebsd.org/D16006 Modified: