Re: svn commit: r344974 - stable/12/sys/netpfil/pf

2019-03-10 Thread Kristof Provost
On 10 Mar 2019, at 17:54, Ian Lepore wrote: > On Sun, 2019-03-10 at 10:34 +0100, Kristof Provost wrote: >> Yes. I should see about scripting these MFCs someday, to avoid silly >> mistakes like this. >> > > Or looking into using gonzo's mfc helper website at > > https://mfc.kernelnomicon.org/6/ >

Re: svn commit: r344974 - stable/12/sys/netpfil/pf

2019-03-10 Thread Ian Lepore
On Sun, 2019-03-10 at 10:34 +0100, Kristof Provost wrote: > On 10 Mar 2019, at 10:16, Harry Schmalzbauer wrote: > > Am 10.03.2019 um 01:56 schrieb Kristof Provost: > > > Author: kp > > > Date: Sun Mar 10 00:56:38 2019 > > > New Revision: 344974 > > > URL:

Re: svn commit: r344974 - stable/12/sys/netpfil/pf

2019-03-10 Thread Kristof Provost
On 10 Mar 2019, at 10:16, Harry Schmalzbauer wrote: Am 10.03.2019 um 01:56 schrieb Kristof Provost: Author: kp Date: Sun Mar 10 00:56:38 2019 New Revision: 344974 URL: https://svnweb.freebsd.org/changeset/base/344974 Log: pf: Small performance tweak Seems to be the MFC of 344493. Indeed,

Re: svn commit: r344974 - stable/12/sys/netpfil/pf

2019-03-10 Thread Harry Schmalzbauer
Am 10.03.2019 um 01:56 schrieb Kristof Provost: Author: kp Date: Sun Mar 10 00:56:38 2019 New Revision: 344974 URL: https://svnweb.freebsd.org/changeset/base/344974 Log: pf: Small performance tweak Seems to be the MFC of 344493. Out of curiosity, do you have to manually write these log

svn commit: r344974 - stable/12/sys/netpfil/pf

2019-03-09 Thread Kristof Provost
Author: kp Date: Sun Mar 10 00:56:38 2019 New Revision: 344974 URL: https://svnweb.freebsd.org/changeset/base/344974 Log: pf: Small performance tweak Because fetching a counter is a rather expansive function we should use counter_u64_fetch() in pf_state_expires() only when necessary. A