Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-24 Thread Conrad Meyer
Hi Philip, Sorry I'm late to the party. Unless I am mistaken, most of these are *not* overflows or vulnerabilities of any sort. On Wed, Jul 10, 2019 at 10:42 AM Philip Paeps wrote: > > Author: philip > Date: Wed Jul 10 17:42:04 2019 > New Revision: 349890 > URL:

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-11 Thread Bruce Evans
On Thu, 11 Jul 2019, Alexey Dokuchaev wrote: On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: New Revision: 349890 URL: https://svnweb.freebsd.org/changeset/base/349890 Log: telnet: fix a couple of snprintf() buffer overflows I see few fixes in this fix. I see even more

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-11 Thread Eitan Adler
On Wed, 10 Jul 2019 at 10:42, Philip Paeps wrote: > Author: philip > Date: Wed Jul 10 17:42:04 2019 > New Revision: 349890 > URL: https://svnweb.freebsd.org/changeset/base/349890 > > Log: > telnet: fix a couple of snprintf() buffer overflows > > Obtained from:Juniper Networks > MFC

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-10 Thread Cy Schubert
In message <20190711014729.gb23...@freebsd.org>, Alexey Dokuchaev writes: > On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: > > New Revision: 349890 > > URL: https://svnweb.freebsd.org/changeset/base/349890 > > > > Log: > > telnet: fix a couple of snprintf() buffer overflows > >

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-10 Thread Alexey Dokuchaev
On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: > New Revision: 349890 > URL: https://svnweb.freebsd.org/changeset/base/349890 > > Log: > telnet: fix a couple of snprintf() buffer overflows > > Modified: head/contrib/telnet/telnet/commands.c > @@ -1655,10 +1655,11 @@

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-10 Thread Alexey Dokuchaev
On Wed, Jul 10, 2019 at 04:45:06PM -0600, Warner Losh wrote: > On Wed, Jul 10, 2019 at 4:43 PM Shawn Webb > > ... > > Because the existing code already used malloc + snprintf. And this is > > contrib/telnet/telnet, which arguably should be `rm -rf`ed. ;) > > > > The bike shed is now

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-10 Thread Warner Losh
On Wed, Jul 10, 2019 at 4:43 PM Shawn Webb wrote: > On Wed, Jul 10, 2019 at 04:40:25PM -0600, Warner Losh wrote: > > On Wed, Jul 10, 2019 at 4:29 PM Shawn Webb > > wrote: > > > > > On Wed, Jul 10, 2019 at 04:22:18PM -0400, Shawn Webb wrote: > > > > On Wed, Jul 10, 2019 at 03:19:44PM -0500,

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-10 Thread Shawn Webb
On Wed, Jul 10, 2019 at 04:40:25PM -0600, Warner Losh wrote: > On Wed, Jul 10, 2019 at 4:29 PM Shawn Webb > wrote: > > > On Wed, Jul 10, 2019 at 04:22:18PM -0400, Shawn Webb wrote: > > > On Wed, Jul 10, 2019 at 03:19:44PM -0500, Justin Hibbits wrote: > > > > On Wed, 10 Jul 2019 15:55:48 -0400 >

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-10 Thread Warner Losh
On Wed, Jul 10, 2019 at 4:29 PM Shawn Webb wrote: > On Wed, Jul 10, 2019 at 04:22:18PM -0400, Shawn Webb wrote: > > On Wed, Jul 10, 2019 at 03:19:44PM -0500, Justin Hibbits wrote: > > > On Wed, 10 Jul 2019 15:55:48 -0400 > > > Shawn Webb wrote: > > > > > > > On Wed, Jul 10, 2019 at 05:42:04PM

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-10 Thread Shawn Webb
On Wed, Jul 10, 2019 at 04:22:18PM -0400, Shawn Webb wrote: > On Wed, Jul 10, 2019 at 03:19:44PM -0500, Justin Hibbits wrote: > > On Wed, 10 Jul 2019 15:55:48 -0400 > > Shawn Webb wrote: > > > > > On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: > > > > Author: philip > > > > Date:

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-10 Thread Shawn Webb
On Wed, Jul 10, 2019 at 03:19:44PM -0500, Justin Hibbits wrote: > On Wed, 10 Jul 2019 15:55:48 -0400 > Shawn Webb wrote: > > > On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: > > > Author: philip > > > Date: Wed Jul 10 17:42:04 2019 > > > New Revision: 349890 > > > URL:

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-10 Thread Justin Hibbits
On Wed, 10 Jul 2019 15:55:48 -0400 Shawn Webb wrote: > On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: > > Author: philip > > Date: Wed Jul 10 17:42:04 2019 > > New Revision: 349890 > > URL: https://svnweb.freebsd.org/changeset/base/349890 > > > > Log: > > telnet: fix a couple

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-10 Thread Shawn Webb
On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: > Author: philip > Date: Wed Jul 10 17:42:04 2019 > New Revision: 349890 > URL: https://svnweb.freebsd.org/changeset/base/349890 > > Log: > telnet: fix a couple of snprintf() buffer overflows > > Obtained from: Juniper

svn commit: r349890 - head/contrib/telnet/telnet

2019-07-10 Thread Philip Paeps
Author: philip Date: Wed Jul 10 17:42:04 2019 New Revision: 349890 URL: https://svnweb.freebsd.org/changeset/base/349890 Log: telnet: fix a couple of snprintf() buffer overflows Obtained from:Juniper Networks MFC after:1 week Modified: head/contrib/telnet/telnet/commands.c