Re: svn commit: r352795 - head/lib/libc/sys

2019-10-02 Thread Bruce Evans
On Tue, 1 Oct 2019, Ed Maste wrote: On Tue, 1 Oct 2019 at 12:23, Brooks Davis wrote: This isn't true with CHERI and as a result I've moved the variadic argument handling (except for syscall() and __syscall()) into libc. My grep found: open, openat, fcntl, semsys, msgsys, shmsys Is that the

Re: svn commit: r352795 - head/lib/libc/sys

2019-10-01 Thread Ed Maste
On Tue, 1 Oct 2019 at 14:13, Brooks Davis wrote: > > Also ioctl. I didn't handle the *sys() ones since they are internal only. Ah, yes - I didn't notice ioctl because syscalls.master lacked a XXX or ... comment. ___ svn-src-all@freebsd.org mailing

Re: svn commit: r352795 - head/lib/libc/sys

2019-10-01 Thread Brooks Davis
On Tue, Oct 01, 2019 at 01:08:27PM -0400, Ed Maste wrote: > On Tue, 1 Oct 2019 at 12:23, Brooks Davis wrote: > > > > This isn't true with CHERI and as a result I've moved the variadic > > argument handling (except for syscall() and __syscall()) into libc. > > My grep found: open, openat, fcntl,

Re: svn commit: r352795 - head/lib/libc/sys

2019-10-01 Thread Ed Maste
On Tue, 1 Oct 2019 at 12:23, Brooks Davis wrote: > > This isn't true with CHERI and as a result I've moved the variadic > argument handling (except for syscall() and __syscall()) into libc. My grep found: open, openat, fcntl, semsys, msgsys, shmsys Is that the full list?

Re: svn commit: r352795 - head/lib/libc/sys

2019-10-01 Thread Konstantin Belousov
On Tue, Oct 01, 2019 at 04:23:05PM +, Brooks Davis wrote: > On Sat, Sep 28, 2019 at 10:25:48AM +0300, Konstantin Belousov wrote: > > On Fri, Sep 27, 2019 at 03:19:59PM -0600, Warner Losh wrote: > > > On Fri, Sep 27, 2019 at 2:38 PM Mateusz Guzik wrote: > > > > > > > On 9/27/19, Konstantin

Re: svn commit: r352795 - head/lib/libc/sys

2019-10-01 Thread Brooks Davis
On Sat, Sep 28, 2019 at 10:25:48AM +0300, Konstantin Belousov wrote: > On Fri, Sep 27, 2019 at 03:19:59PM -0600, Warner Losh wrote: > > On Fri, Sep 27, 2019 at 2:38 PM Mateusz Guzik wrote: > > > > > On 9/27/19, Konstantin Belousov wrote: > > > > On Fri, Sep 27, 2019 at 08:32:20PM +0200, Mateusz

Re: svn commit: r352795 - head/lib/libc/sys

2019-09-28 Thread Konstantin Belousov
On Fri, Sep 27, 2019 at 03:19:59PM -0600, Warner Losh wrote: > On Fri, Sep 27, 2019 at 2:38 PM Mateusz Guzik wrote: > > > On 9/27/19, Konstantin Belousov wrote: > > > On Fri, Sep 27, 2019 at 08:32:20PM +0200, Mateusz Guzik wrote: > > >> On 9/27/19, Warner Losh wrote: > > >> > Document

Re: svn commit: r352795 - head/lib/libc/sys

2019-09-27 Thread Mateusz Guzik
On 9/27/19, Warner Losh wrote: > On Fri, Sep 27, 2019 at 2:38 PM Mateusz Guzik wrote: > >> On 9/27/19, Konstantin Belousov wrote: >> > On Fri, Sep 27, 2019 at 08:32:20PM +0200, Mateusz Guzik wrote: >> >> On 9/27/19, Warner Losh wrote: >> >> > Document varadic args as int, since you can't

Re: svn commit: r352795 - head/lib/libc/sys

2019-09-27 Thread Warner Losh
On Fri, Sep 27, 2019 at 2:38 PM Mateusz Guzik wrote: > On 9/27/19, Konstantin Belousov wrote: > > On Fri, Sep 27, 2019 at 08:32:20PM +0200, Mateusz Guzik wrote: > >> On 9/27/19, Warner Losh wrote: > >> > Document varadic args as int, since you can't have short varadic > args > >> > (they are

Re: svn commit: r352795 - head/lib/libc/sys

2019-09-27 Thread Mateusz Guzik
On 9/27/19, Konstantin Belousov wrote: > On Fri, Sep 27, 2019 at 08:32:20PM +0200, Mateusz Guzik wrote: >> On 9/27/19, Warner Losh wrote: >> > Document varadic args as int, since you can't have short varadic args >> > (they are >> > promoted to ints). >> > >> > - `mode_t` is `uint16_t`

Re: svn commit: r352795 - head/lib/libc/sys

2019-09-27 Thread Bruce Evans
On Fri, 27 Sep 2019, Konstantin Belousov wrote: On Fri, Sep 27, 2019 at 08:32:20PM +0200, Mateusz Guzik wrote: On 9/27/19, Warner Losh wrote: Author: imp Date: Fri Sep 27 16:11:47 2019 New Revision: 352795 URL: https://svnweb.freebsd.org/changeset/base/352795 Log: Document varadic args as

Re: svn commit: r352795 - head/lib/libc/sys

2019-09-27 Thread Konstantin Belousov
On Fri, Sep 27, 2019 at 08:32:20PM +0200, Mateusz Guzik wrote: > On 9/27/19, Warner Losh wrote: > > Author: imp > > Date: Fri Sep 27 16:11:47 2019 > > New Revision: 352795 > > URL: https://svnweb.freebsd.org/changeset/base/352795 > > > > Log: > > Document varadic args as int, since you can't

Re: svn commit: r352795 - head/lib/libc/sys

2019-09-27 Thread Mateusz Guzik
On 9/27/19, Warner Losh wrote: > Author: imp > Date: Fri Sep 27 16:11:47 2019 > New Revision: 352795 > URL: https://svnweb.freebsd.org/changeset/base/352795 > > Log: > Document varadic args as int, since you can't have short varadic args > (they are > promoted to ints). > > - `mode_t` is

svn commit: r352795 - head/lib/libc/sys

2019-09-27 Thread Warner Losh
Author: imp Date: Fri Sep 27 16:11:47 2019 New Revision: 352795 URL: https://svnweb.freebsd.org/changeset/base/352795 Log: Document varadic args as int, since you can't have short varadic args (they are promoted to ints). - `mode_t` is `uint16_t` (`sys/sys/_types.h`) - `openat` takes