Re: svn commit: r355784 - in head/sys: compat/linuxkpi/common/src dev/dpaa kern mips/nlm sys

2019-12-16 Thread Mateusz Guzik
The entire thing reads like a bug -- for each platform critical_exit can venture into mi_switch with interrupts disabled. On amd64 it just happens to do it after the count was updated, but still before they got-reenabled. Other platform also do critical enter/exit dance on each call instead of

Re: svn commit: r355784 - in head/sys: compat/linuxkpi/common/src dev/dpaa kern mips/nlm sys

2019-12-16 Thread Jeff Roberson
On Mon, 16 Dec 2019, Ryan Libby wrote: On Mon, Dec 16, 2019 at 7:30 AM Ed Maste wrote: On Sun, 15 Dec 2019 at 16:27, Jeff Roberson wrote: Author: jeff Date: Sun Dec 15 21:26:50 2019 New Revision: 355784 URL: https://svnweb.freebsd.org/changeset/base/355784 Log: schedlock 4/4 FYI

Re: svn commit: r355784 - in head/sys: compat/linuxkpi/common/src dev/dpaa kern mips/nlm sys

2019-12-16 Thread Ryan Libby
On Mon, Dec 16, 2019 at 7:30 AM Ed Maste wrote: > > On Sun, 15 Dec 2019 at 16:27, Jeff Roberson wrote: > > > > Author: jeff > > Date: Sun Dec 15 21:26:50 2019 > > New Revision: 355784 > > URL: https://svnweb.freebsd.org/changeset/base/355784 > > > > Log: > > schedlock 4/4 > > FYI i386, arm,

Re: svn commit: r355784 - in head/sys: compat/linuxkpi/common/src dev/dpaa kern mips/nlm sys

2019-12-16 Thread Ed Maste
On Sun, 15 Dec 2019 at 16:27, Jeff Roberson wrote: > > Author: jeff > Date: Sun Dec 15 21:26:50 2019 > New Revision: 355784 > URL: https://svnweb.freebsd.org/changeset/base/355784 > > Log: > schedlock 4/4 FYI i386, arm, arm64, riscv fail to boot now, with "panic: invalid count 2" Boot logs:

svn commit: r355784 - in head/sys: compat/linuxkpi/common/src dev/dpaa kern mips/nlm sys

2019-12-15 Thread Jeff Roberson
Author: jeff Date: Sun Dec 15 21:26:50 2019 New Revision: 355784 URL: https://svnweb.freebsd.org/changeset/base/355784 Log: schedlock 4/4 Don't hold the scheduler lock while doing context switches. Instead we unlock after selecting the new thread and switch within a spinlock section