Re: svn commit: r357614 - in head/sys: kern sys

On 2/6/20 4:45 AM, Pawel Biernacki wrote: > Author: kaktus > Date: Thu Feb 6 12:45:58 2020 > New Revision: 357614 > URL: https://svnweb.freebsd.org/changeset/base/357614 > > Log: > sysctl(9): add CTLFLAG_NEEDGIANT flag > > Add CTLFLAG_NEEDGIANT flag (modelled after D_NEEDGIANT) that will

Re: svn commit: r357614 - in head/sys: kern sys

On Thu, Feb 06, 2020 at 05:41:52PM +0100, Hans Petter Selasky wrote: > On 2020-02-06 13:45, Pawel Biernacki wrote: > > +#ifdef notyet > > +#defineSYSCTL_ENFORCE_FLAGS(x) > > \ > > +_Static_assert(((CTLFLAG_MPSAFE ^ CTLFLAG_NEEDGIANT) & (x)), \ > >

Re: svn commit: r357614 - in head/sys: kern sys

Thanks, will be fixed before enabling it. > On 6 Feb 2020, at 17:41, Hans Petter Selasky wrote: > > On 2020-02-06 13:45, Pawel Biernacki wrote: >> +#ifdef notyet >> +#define SYSCTL_ENFORCE_FLAGS(x) >> \ >> +_Static_assert(((CTLFLAG_MPSAFE ^

Re: svn commit: r357614 - in head/sys: kern sys

On 2020-02-06 13:45, Pawel Biernacki wrote: +#ifdef notyet +#defineSYSCTL_ENFORCE_FLAGS(x) \ +_Static_assert(((CTLFLAG_MPSAFE ^ CTLFLAG_NEEDGIANT) & (x)), \ +"Has to be either CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT") +#else +#define

Re: svn commit: r357614 - in head/sys: kern sys

Hi Pawel, I don't think the (notyet) static assertion is quite right. On Thu, Feb 6, 2020 at 4:46 AM Pawel Biernacki wrote: > > Author: kaktus > Date: Thu Feb 6 12:45:58 2020 > New Revision: 357614 > URL: https://svnweb.freebsd.org/changeset/base/357614 > > Log: > sysctl(9): add

svn commit: r357614 - in head/sys: kern sys

Author: kaktus Date: Thu Feb 6 12:45:58 2020 New Revision: 357614 URL: https://svnweb.freebsd.org/changeset/base/357614 Log: sysctl(9): add CTLFLAG_NEEDGIANT flag Add CTLFLAG_NEEDGIANT flag (modelled after D_NEEDGIANT) that will be used to mark sysctls that still require locking Giant.