Re: svn commit: r360241 - head/sys/dev/ichiic

2020-04-24 Thread John Baldwin
On 4/24/20 11:48 AM, Andriy Gapon wrote: > On 24/04/2020 19:23, Justin Hibbits wrote: >> Can you look at how ofw_iicbus does this? Everything works just fine >> with that, and it's compiled into the iicbus module as well. Perhaps >> you can pick some ideas from there. >> >> One thing I remember

Re: svn commit: r360241 - head/sys/dev/ichiic

2020-04-24 Thread Andriy Gapon
On 24/04/2020 19:23, Justin Hibbits wrote: > Can you look at how ofw_iicbus does this? Everything works just fine > with that, and it's compiled into the iicbus module as well. Perhaps > you can pick some ideas from there. > > One thing I remember doing on the fsl_i2c driver was to just name

Re: svn commit: r360241 - head/sys/dev/ichiic

2020-04-24 Thread John Baldwin
On 4/24/20 9:57 AM, Warner Losh wrote: > On Fri, Apr 24, 2020 at 10:07 AM Andriy Gapon wrote: >> Let's use ig4 as an example. >> Across its source files we had the following DRIVER_MODULE declarations: >> DRIVER_MODULE(ig4iic, acpi, ... -- in ig4_acpi.c >> DRIVER_MODULE(iicbus, ig4iic, ... -- in

Re: svn commit: r360241 - head/sys/dev/ichiic

2020-04-24 Thread Warner Losh
On Fri, Apr 24, 2020 at 10:07 AM Andriy Gapon wrote: > On 24/04/2020 18:11, Warner Losh wrote: > > > > > > On Fri, Apr 24, 2020 at 8:47 AM Andriy Gapon > > wrote: > > > > On 24/04/2020 17:29, Warner Losh wrote: > > > > > > > > > On Fri, Apr 24, 2020 at

Re: svn commit: r360241 - head/sys/dev/ichiic

2020-04-24 Thread Justin Hibbits
On Fri, 24 Apr 2020 19:07:35 +0300 Andriy Gapon wrote: > On 24/04/2020 18:11, Warner Losh wrote: > > > > > > On Fri, Apr 24, 2020 at 8:47 AM Andriy Gapon > > wrote: > > > > On 24/04/2020 17:29, Warner Losh wrote: > > > > > > > > > On Fri, Apr 24,

Re: svn commit: r360241 - head/sys/dev/ichiic

2020-04-24 Thread Andriy Gapon
On 24/04/2020 18:11, Warner Losh wrote: > > > On Fri, Apr 24, 2020 at 8:47 AM Andriy Gapon > wrote: > > On 24/04/2020 17:29, Warner Losh wrote: > > > > > > On Fri, Apr 24, 2020 at 1:49 AM Andriy Gapon > >

Re: svn commit: r360241 - head/sys/dev/ichiic

2020-04-24 Thread Warner Losh
On Fri, Apr 24, 2020 at 8:47 AM Andriy Gapon wrote: > On 24/04/2020 17:29, Warner Losh wrote: > > > > > > On Fri, Apr 24, 2020 at 1:49 AM Andriy Gapon > > wrote: > > > > Author: avg > > Date: Fri Apr 24 07:49:21 2020 > > New Revision: 360241 > > URL:

Re: svn commit: r360241 - head/sys/dev/ichiic

2020-04-24 Thread Andriy Gapon
On 24/04/2020 17:29, Warner Losh wrote: > > > On Fri, Apr 24, 2020 at 1:49 AM Andriy Gapon > wrote: > > Author: avg > Date: Fri Apr 24 07:49:21 2020 > New Revision: 360241 > URL: https://svnweb.freebsd.org/changeset/base/360241 > > Log: >  

Re: svn commit: r360241 - head/sys/dev/ichiic

2020-04-24 Thread Warner Losh
On Fri, Apr 24, 2020 at 1:49 AM Andriy Gapon wrote: > Author: avg > Date: Fri Apr 24 07:49:21 2020 > New Revision: 360241 > URL: https://svnweb.freebsd.org/changeset/base/360241 > > Log: > ig4: ensure that drivers always attach in correct order > > Use DRIVER_MODULE_ORDERED(SI_ORDER_ANY) so

svn commit: r360241 - head/sys/dev/ichiic

2020-04-24 Thread Andriy Gapon
Author: avg Date: Fri Apr 24 07:49:21 2020 New Revision: 360241 URL: https://svnweb.freebsd.org/changeset/base/360241 Log: ig4: ensure that drivers always attach in correct order Use DRIVER_MODULE_ORDERED(SI_ORDER_ANY) so that ig4's ACPI attachment happens after iicbus and acpi_iicbus