Re: svn commit: r361363 - in head/lib/libprocstat: . zfs

2020-05-23 Thread Andriy Gapon
On 23/05/2020 18:43, Niclas Zeising wrote: > On 2020-05-22 13:20, Andriy Gapon wrote: >> Author: avg >> Date: Fri May 22 11:20:23 2020 >> New Revision: 361363 >> URL: https://svnweb.freebsd.org/changeset/base/361363 >> >> Log: >>    libprocstat: fix ZFS support >>    > > > This might have

Re: svn commit: r361363 - in head/lib/libprocstat: . zfs

2020-05-23 Thread Niclas Zeising
On 2020-05-22 13:20, Andriy Gapon wrote: Author: avg Date: Fri May 22 11:20:23 2020 New Revision: 361363 URL: https://svnweb.freebsd.org/changeset/base/361363 Log: libprocstat: fix ZFS support This might have broken a couple of ports. The build is still going, but at least three ports

Re: svn commit: r361363 - in head/lib/libprocstat: . zfs

2020-05-22 Thread Andriy Gapon
On 22/05/2020 18:23, Andriy Gapon wrote: > On 22/05/2020 18:15, Conrad Meyer wrote: >> Hi Andriy, >> >> Would it make sense to also export sizes of those members? Currently >> the code assumes the members may be relocated in the struct, but never >> changed in size. If they can be moved around,

Re: svn commit: r361363 - in head/lib/libprocstat: . zfs

2020-05-22 Thread Andriy Gapon
On 22/05/2020 18:15, Conrad Meyer wrote: > Hi Andriy, > > Would it make sense to also export sizes of those members? Currently > the code assumes the members may be relocated in the struct, but never > changed in size. If they can be moved around, maybe they might be > enlarged or shrunk at

Re: svn commit: r361363 - in head/lib/libprocstat: . zfs

2020-05-22 Thread Conrad Meyer
Hi Andriy, Would it make sense to also export sizes of those members? Currently the code assumes the members may be relocated in the struct, but never changed in size. If they can be moved around, maybe they might be enlarged or shrunk at some time too? Maybe not; I am not very familiar with

svn commit: r361363 - in head/lib/libprocstat: . zfs

2020-05-22 Thread Andriy Gapon
Author: avg Date: Fri May 22 11:20:23 2020 New Revision: 361363 URL: https://svnweb.freebsd.org/changeset/base/361363 Log: libprocstat: fix ZFS support First of all, znode_phys_t hasn't been used for storing file attributes for a long time now. Modern ZFS versions use a System Attribute