Re: svn commit: r368667 - in head: . gnu/usr.bin gnu/usr.bin/binutils gnu/usr.bin/gdb tools/build/mk

2020-12-16 Thread John Baldwin
On 12/16/20 9:41 AM, Ed Maste wrote:
> On Tue, 15 Dec 2020 at 18:25, John Baldwin  wrote:
>>
>> On 12/15/20 9:44 AM, Ed Maste wrote:
>>> Author: emaste
>>> Date: Tue Dec 15 17:44:19 2020
>>> New Revision: 368667
>>> URL: https://svnweb.freebsd.org/changeset/base/368667
>>>
>>> Log:
>>>   Retire obsolete GDB 6.1.1
>>
>> Are you going to remove the -gdwarf-2 bits from kern.mk now?
> 
> Yes, soon. We probably need to change it to explicit -gdwarf-4 (not
> just remove it and rely on the compiler's default) as we'll see DWARF5
> by default before long and will need to update ctfconvert again.

We already don't bother doing that for userland, so I think I'd
rather us just drop the option and fix ctfconvert once there is a
need.

-- 
John Baldwin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r368667 - in head: . gnu/usr.bin gnu/usr.bin/binutils gnu/usr.bin/gdb tools/build/mk

2020-12-16 Thread Ed Maste
On Tue, 15 Dec 2020 at 18:25, John Baldwin  wrote:
>
> On 12/15/20 9:44 AM, Ed Maste wrote:
> > Author: emaste
> > Date: Tue Dec 15 17:44:19 2020
> > New Revision: 368667
> > URL: https://svnweb.freebsd.org/changeset/base/368667
> >
> > Log:
> >   Retire obsolete GDB 6.1.1
>
> Are you going to remove the -gdwarf-2 bits from kern.mk now?

Yes, soon. We probably need to change it to explicit -gdwarf-4 (not
just remove it and rely on the compiler's default) as we'll see DWARF5
by default before long and will need to update ctfconvert again.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r368667 - in head: . gnu/usr.bin gnu/usr.bin/binutils gnu/usr.bin/gdb tools/build/mk

2020-12-15 Thread Jessica Clarke
On 15 Dec 2020, at 23:25, John Baldwin  wrote:
> On 12/15/20 9:44 AM, Ed Maste wrote:
>> Author: emaste
>> Date: Tue Dec 15 17:44:19 2020
>> New Revision: 368667
>> URL: https://svnweb.freebsd.org/changeset/base/368667
>> 
>> Log:
>>  Retire obsolete GDB 6.1.1
>> 
>>  GDB 6.1.1 was released in June 2004 and is long obsolete. It does not
>>  support all of the architectures that FreeBSD does, and imposes
>>  limitations on the FreeBSD kernel build, such as the continued use of
>>  DWARF2 debugging information.
>> 
>>  It was kept (in /usr/libexec/) only for use by crashinfo(8), which
>>  extracts some basic information from a kernel core dump after a crash.
>>  Crashinfo already prefers gdb from port/package if installed.
>> 
>>  Future work may add kernel debug support to LLDB or find another path
>>  for crashinfo's needs, but in any case we do not want to ship the
>>  excessively outdated GDB in FreeBSD 13.
>> 
>>  Sponsored by:   The FreeBSD Foundation
>>  Differential Revision:  https://reviews.freebsd.org/D27610
> 
> Are you going to remove the -gdwarf-2 bits from kern.mk now?
> 
> (Does ctfconvert support newer DWARF?)

cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c:1964-1968:

debug(1, "DWARF version: %d\n", vers);
if (vers < 2 || vers > 4) {
terminate("file contains incompatible version %d DWARF code "
"(version 2, 3 or 4 required)\n", vers);
}

(since r261025)

Though that doesn't mean it works...

Jess

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r368667 - in head: . gnu/usr.bin gnu/usr.bin/binutils gnu/usr.bin/gdb tools/build/mk

2020-12-15 Thread John Baldwin
On 12/15/20 9:44 AM, Ed Maste wrote:
> Author: emaste
> Date: Tue Dec 15 17:44:19 2020
> New Revision: 368667
> URL: https://svnweb.freebsd.org/changeset/base/368667
> 
> Log:
>   Retire obsolete GDB 6.1.1
>   
>   GDB 6.1.1 was released in June 2004 and is long obsolete. It does not
>   support all of the architectures that FreeBSD does, and imposes
>   limitations on the FreeBSD kernel build, such as the continued use of
>   DWARF2 debugging information.
>   
>   It was kept (in /usr/libexec/) only for use by crashinfo(8), which
>   extracts some basic information from a kernel core dump after a crash.
>   Crashinfo already prefers gdb from port/package if installed.
>   
>   Future work may add kernel debug support to LLDB or find another path
>   for crashinfo's needs, but in any case we do not want to ship the
>   excessively outdated GDB in FreeBSD 13.
>   
>   Sponsored by:   The FreeBSD Foundation
>   Differential Revision:  https://reviews.freebsd.org/D27610

Are you going to remove the -gdwarf-2 bits from kern.mk now?

(Does ctfconvert support newer DWARF?)

-- 
John Baldwin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r368667 - in head: . gnu/usr.bin gnu/usr.bin/binutils gnu/usr.bin/gdb tools/build/mk

2020-12-15 Thread Ed Maste
Author: emaste
Date: Tue Dec 15 17:44:19 2020
New Revision: 368667
URL: https://svnweb.freebsd.org/changeset/base/368667

Log:
  Retire obsolete GDB 6.1.1
  
  GDB 6.1.1 was released in June 2004 and is long obsolete. It does not
  support all of the architectures that FreeBSD does, and imposes
  limitations on the FreeBSD kernel build, such as the continued use of
  DWARF2 debugging information.
  
  It was kept (in /usr/libexec/) only for use by crashinfo(8), which
  extracts some basic information from a kernel core dump after a crash.
  Crashinfo already prefers gdb from port/package if installed.
  
  Future work may add kernel debug support to LLDB or find another path
  for crashinfo's needs, but in any case we do not want to ship the
  excessively outdated GDB in FreeBSD 13.
  
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D27610

Deleted:
  head/gnu/usr.bin/binutils/
  head/gnu/usr.bin/gdb/
Modified:
  head/ObsoleteFiles.inc
  head/UPDATING
  head/gnu/usr.bin/Makefile
  head/tools/build/mk/OptionalObsoleteFiles.inc

Modified: head/ObsoleteFiles.inc
==
--- head/ObsoleteFiles.inc  Tue Dec 15 16:15:25 2020(r368666)
+++ head/ObsoleteFiles.inc  Tue Dec 15 17:44:19 2020(r368667)
@@ -36,6 +36,10 @@
 #   xargs -n1 | sort | uniq -d;
 # done
 
+# 20201215: in-tree gdb removed
+OLD_FILES+=usr/libexec/gdb
+OLD_FILES+=usr/libexec/kgdb
+
 # 20201211: hme(4) removed
 OLD_FILES+=usr/share/man/man4/hme.4.gz
 OLD_FILES+=usr/share/man/man4/if_hme.4.gz

Modified: head/UPDATING
==
--- head/UPDATING   Tue Dec 15 16:15:25 2020(r368666)
+++ head/UPDATING   Tue Dec 15 17:44:19 2020(r368667)
@@ -26,6 +26,10 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 13.x IS SLOW:
world, or to merely disable the most expensive debugging functionality
at runtime, run "ln -s 'abort:false,junk:false' /etc/malloc.conf".)
 
+20201215:
+   Obsolete in-tree GDB 6.1.1 has been removed.  GDB (including kgdb)
+   may be installed from ports or packages.
+
 20201124:
ping6 has been merged into ping.  It can now be called as "ping -6".
See ping(8) for details.

Modified: head/gnu/usr.bin/Makefile
==
--- head/gnu/usr.bin/Makefile   Tue Dec 15 16:15:25 2020(r368666)
+++ head/gnu/usr.bin/Makefile   Tue Dec 15 17:44:19 2020(r368667)
@@ -5,8 +5,6 @@
 SUBDIR.${MK_DIALOG}+=  dialog
 SUBDIR.${MK_GNU_DIFF}+=diff3
 SUBDIR.${MK_GNU_GREP}+=grep
-SUBDIR.${MK_GDB}+= binutils gdb
-SUBDIR_DEPEND_gdb= binutils
 SUBDIR.${MK_TESTS}+=   tests
 
 SUBDIR_PARALLEL=

Modified: head/tools/build/mk/OptionalObsoleteFiles.inc
==
--- head/tools/build/mk/OptionalObsoleteFiles.inc   Tue Dec 15 16:15:25 
2020(r368666)
+++ head/tools/build/mk/OptionalObsoleteFiles.inc   Tue Dec 15 17:44:19 
2020(r368667)
@@ -2143,11 +2143,6 @@ OLD_FILES+=usr/share/man/man1/llvm-cov.1.gz
 OLD_FILES+=usr/share/man/man1/llvm-profdata.1.gz
 .endif
 
-.if ${MK_GDB} == no
-OLD_FILES+=usr/libexec/gdb
-OLD_FILES+=usr/libexec/kgdb
-.endif
-
 .if ${MK_GOOGLETEST} == no
 OLD_FILES+=usr/include/gmock/gmock-actions.h
 OLD_FILES+=usr/include/gmock/gmock-cardinalities.h
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"