Re: svn commit: r285993 - in head/sys: kern sys ufs/ffs vm

2015-07-28 Thread Conrad Meyer
On Tue, Jul 28, 2015 at 7:26 PM, Jeff Roberson j...@freebsd.org wrote: Author: jeff Date: Wed Jul 29 02:26:57 2015 New Revision: 285993 URL: https://svnweb.freebsd.org/changeset/base/285993 Log: - Make 'struct buf *buf' private to vfs_bio.c. Having a global variable 'buf' is

Re: svn commit: r285766 - in head/sys: conf dev/vt dev/vt/logo

2015-07-22 Thread Conrad Meyer
On Wed, Jul 22, 2015 at 7:10 AM, Conrad Meyer c...@freebsd.org wrote: On Tue, Jul 21, 2015 at 9:26 PM, Luiz Otavio O Souza loos...@gmail.com wrote: This seems to break kernels without 'device splash'. ... linking kernel.debug vt_core.o: In function `vtterm_cnprobe': /usr/src/sys/dev/vt

Re: svn commit: r285766 - in head/sys: conf dev/vt dev/vt/logo

2015-07-22 Thread Conrad Meyer
On Tue, Jul 21, 2015 at 9:26 PM, Luiz Otavio O Souza loos...@gmail.com wrote: This seems to break kernels without 'device splash'. ... linking kernel.debug vt_core.o: In function `vtterm_cnprobe': /usr/src/sys/dev/vt/vt_core.c:1363: undefined reference to `vt_logo_sprite_height' vt_core.o:

Re: svn commit: r287117 - in head: share/man/man4 sys/amd64/conf sys/conf sys/dev/ioat sys/modules sys/modules/ioat tools/tools/ioat

2015-08-24 Thread Conrad Meyer
On Mon, Aug 24, 2015 at 1:18 PM, Xin Li delp...@delphij.net wrote: Hi, Quick question -- why the ioatcontrol is not imported to e.g. usr.sbin instead? Cheers, -- Xin LI delp...@delphij.nethttps://www.delphij.net/ Hi, The tool's name is a little misleading. It's not a general

Re: svn commit: r289867 - head/sys/sys

2015-10-24 Thread Conrad Meyer
This broke the build (xen_intr.c used BITSET_DEFINE() without a semi-colon). Fixed in and X-MFC-With: r289884. Best, Conrad On Fri, Oct 23, 2015 at 8:16 PM, Mark Johnston wrote: > Author: markj > Date: Sat Oct 24 03:16:40 2015 > New Revision: 289867 > URL:

Re: svn commit: r289773 - in head: sbin/sysctl sys/kern sys/sys

2015-10-23 Thread Conrad Meyer
On Thu, Oct 22, 2015 at 6:10 PM, NGie Cooper wrote: > On Thu, Oct 22, 2015 at 4:03 PM, Conrad E. Meyer wrote: >> URL: https://svnweb.freebsd.org/changeset/base/289773 >> >> Log: >> Sysctl: Add common support for U8, U16 types > > - This is missing

Re: svn commit: r290130 - head/sys/dev/ntb/ntb_hw

2015-10-29 Thread Conrad Meyer
On Thu, Oct 29, 2015 at 10:02 AM, John Baldwin wrote: > On Thursday, October 29, 2015 04:42:20 PM Steven Wahl wrote: >> We ran into this exact problem, pmap_change_attr not working right with >> large bars. I had been working up to seeing if this compiles on the current >>

Re: svn commit: r290130 - head/sys/dev/ntb/ntb_hw

2015-10-29 Thread Conrad Meyer
On Thu, 29 Oct 2015 09:53:43 +0200 Konstantin Belousov wrote: > On Thu, Oct 29, 2015 at 04:16:28AM +, Conrad E. Meyer > wrote: > > Author: cem > > Date: Thu Oct 29 04:16:28 2015 > > New Revision: 290130 > > URL: https://svnweb.freebsd.org/changeset/base/290130 > > > >

Re: svn commit: r290110 - in head: include lib/libc/stdio

2015-10-28 Thread Conrad Meyer
On Wed, 28 Oct 2015 08:52:15 -0700 Xin Li wrote: > On 10/28/15 07:40, Andrey A. Chernov wrote: > > Add _flags2 per jhb@ suggestion since no room left in > > _flags. Rewrite O_APPEND flag checking using new __S2OAP > > flag. > > Is this ABI-safe? (I was somewhat surprised

Re: svn commit: r289773 - in head: sbin/sysctl sys/kern sys/sys

2015-10-23 Thread Conrad Meyer
On Fri, Oct 23, 2015 at 2:06 PM, Mark Linimon <lini...@lonesome.com> wrote: > On Fri, Oct 23, 2015 at 08:09:35AM -0700, Conrad Meyer wrote: >> What is __FreeBSD_version and why would it be bumped? > > > > This variable exists to tell the Ports Collection, among ot

Re: svn commit: r289773 - in head: sbin/sysctl sys/kern sys/sys

2015-10-23 Thread Conrad Meyer
On Fri, Oct 23, 2015 at 2:56 PM, Ian Lepore <i...@freebsd.org> wrote: > On Fri, 2015-10-23 at 14:43 -0700, Conrad Meyer wrote: >> On Fri, Oct 23, 2015 at 2:06 PM, Mark Linimon <lini...@lonesome.com> >> wrote: >> > On Fri, Oct 23, 2015 at 08:09:35AM -0

Re: svn commit: r290613 - head/sys/compat/linuxkpi/common/include/linux

2015-11-10 Thread Conrad Meyer
On Tue, Nov 10, 2015 at 7:08 AM, Ian Lepore wrote: > On Tue, 2015-11-10 at 08:44 +0100, Hans Petter Selasky wrote: >> > -sysctl_root_handler_locked(struct sysctl_oid *oid, void *arg1, >> > intptr_t arg2, >> > +sysctl_root_handler_locked(struct sysctl_oid *oid, void *arg1, >> >

Re: svn commit: r290711 - head/sys/ofed/drivers/infiniband/core

2015-11-12 Thread Conrad Meyer
These should cast through (u)intptr_t rather than unsigned long. Best, Conrad On Thu, Nov 12, 2015 at 2:12 AM, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Nov 12 10:12:20 2015 > New Revision: 290711 > URL: https://svnweb.freebsd.org/changeset/base/290711 > >

Re: svn commit: r290221 - head/sys/powerpc/powerpc

2015-10-30 Thread Conrad Meyer
Comments inline. On Fri, Oct 30, 2015 at 7:08 PM, Justin Hibbits wrote: > Author: jhibbits > Date: Sat Oct 31 02:08:39 2015 > New Revision: 290221 > URL: https://svnweb.freebsd.org/changeset/base/290221 > > Log: > Print unsigned memory sizes, to handle >2GB RAM on 32-bit

Re: svn commit: r290475 - in head: share/man/man9 sys/kern sys/sys

2015-11-07 Thread Conrad Meyer
Sorry about that — Ravi and I missed this. I see Konstantin has since fixed it (thanks!). There is also the intptr_t in SYSCTL_HANDLER_ARGS and oid_arg2 in struct sysctl_oid remaining. Best, Conrad On Sat, Nov 7, 2015 at 12:37 AM, Svatopluk Kraus wrote: > You broke

Re: svn commit: r290475 - in head: share/man/man9 sys/kern sys/sys

2015-11-07 Thread Conrad Meyer
Can do — fixed in r290505. Thanks, Conrad On Sat, Nov 7, 2015 at 3:20 AM, Hans Petter Selasky wrote: > On 11/07/15 09:37, Svatopluk Kraus wrote: >> >> +#defineSYSCTL_NULL_U64_PTR ((unsigned *)NULL) > > > Hi Conrad, > > All the NULL macros must have correct type

Re: svn commit: r290493 - head/sys/sys

2015-11-07 Thread Conrad Meyer
Missed that instance of intptr_t, sorry. Thanks for fixing it. I think we should also s/intptr_t/intmax_t/ in SYSCTL_HANDLER_ARGS. Thanks, Conrad On Sat, Nov 7, 2015 at 4:33 AM, Konstantin Belousov wrote: > Author: kib > Date: Sat Nov 7 12:33:30 2015 > New Revision: 290493

Re: svn commit: r289281 - in head/sys/dev/ntb: if_ntb ntb_hw

2015-10-13 Thread Conrad Meyer
This catches us up to Linux @ Nov 26, 2013, modulo earlier caveats. Best, Conrad On Tue, Oct 13, 2015 at 7:14 PM, Conrad E. Meyer wrote: > Author: cem > Date: Wed Oct 14 02:14:45 2015 > New Revision: 289281 > URL: https://svnweb.freebsd.org/changeset/base/289281 > > Log: >

Re: svn commit: r288984 - head/sbin/sysctl

2015-10-07 Thread Conrad Meyer
On Wed, Oct 7, 2015 at 2:28 AM, Baptiste Daroussin wrote: > --- head/sbin/sysctl/sysctl.c Wed Oct 7 09:12:49 2015(r288983) > +++ head/sbin/sysctl/sysctl.c Wed Oct 7 09:28:54 2015(r288984) > @@ -276,7 +276,11 @@ parse(const char *string, int lineno) >

Re: svn commit: r289027 - head/contrib/tzcode/stdtime

2015-10-08 Thread Conrad Meyer
On Thu, Oct 8, 2015 at 5:51 AM, Andriy Gapon wrote: > On 08/10/2015 14:42, Craig Rodrigues wrote: >> Assume C89. >> >> >> https://github.com/eggert/tz/commit/400ecf36bb0b73f6390f9641e6cb8bbfb91a5cfd > > What if one day github disappears but FreeBSD is still going? > The

Re: svn commit: r289027 - head/contrib/tzcode/stdtime

2015-10-08 Thread Conrad Meyer
On Thu, Oct 8, 2015 at 9:06 AM, Andriy Gapon wrote: > This commit seems to set a precedent of "merging" a github pull request into > the > tree. That's why I decided to comment. I did so as well in r288238, for example. :-) Upstreams (for tz or libcxxrt), hosted at Github or

Re: svn commit: r289397 - head/sys/dev/ntb/ntb_hw

2015-10-15 Thread Conrad Meyer
This catches us up to the Linux driver as of Jun 23, 2015. Thanks, Conrad On Thu, Oct 15, 2015 at 4:46 PM, Conrad E. Meyer wrote: > Author: cem > Date: Thu Oct 15 23:46:07 2015 > New Revision: 289397 > URL: https://svnweb.freebsd.org/changeset/base/289397 > > Log: > NTB: MFV

Re: svn commit: r289653 - head/sys/dev/ntb/if_ntb

2015-10-20 Thread Conrad Meyer
This catches us up to Linus' master branch as of today (the most recent NTB patch there is from Sep 7, 2015) — modulo no DMA offload in if_ntb, no debugfs-equivalent statistics, and neither of Linux' NTB test drivers. Also we don't make any attempt to allocate memory in the device-local NUMA zone,

Re: svn commit: r289663 - head/share/mk

2015-10-20 Thread Conrad Meyer
On Tue, Oct 20, 2015 at 1:37 PM, Bryan Drewery wrote: > Author: bdrewery > Date: Tue Oct 20 20:37:00 2015 > New Revision: 289663 > URL: https://svnweb.freebsd.org/changeset/base/289663 > > Log: I think this should read: > Improve safety of caching from r289659 by only

Re: svn commit: r289667 - head/share/man/man9

2015-10-20 Thread Conrad Meyer
On Tue, Oct 20, 2015 at 5:09 PM, John Baldwin wrote: > On Tuesday, October 20, 2015 11:48:14 PM Conrad E. Meyer wrote: >> Author: cem >> Date: Tue Oct 20 23:48:14 2015 >> New Revision: 289667 >> URL: https://svnweb.freebsd.org/changeset/base/289667 >> >> Log: >> Document

Re: svn commit: r289157 - head/sys/dev/ntb/if_ntb

2015-10-11 Thread Conrad Meyer
On Sun, Oct 11, 2015 at 2:01 PM, Conrad E. Meyer wrote: > Author: cem > Date: Sun Oct 11 21:01:14 2015 > New Revision: 289157 > URL: https://svnweb.freebsd.org/changeset/base/289157 > > Log: > NTB: MFV c336acd3: memcpy lockup workaround This catches us up to the dual-licensed

Re: svn commit: r289266 - in head/sys/dev/ntb: if_ntb ntb_hw

2015-10-13 Thread Conrad Meyer
On Tue, Oct 13, 2015 at 1:55 PM, Conrad E. Meyer wrote: > Author: cem > Date: Tue Oct 13 20:55:21 2015 > New Revision: 289266 > URL: https://svnweb.freebsd.org/changeset/base/289266 > > Log: > NTB: MFV f9a2cf89: Comment Fix This catches us up to the dual-licensed BSD/GPL

Re: svn commit: r289208 - in head/sys/dev/ntb: if_ntb ntb_hw

2015-10-12 Thread Conrad Meyer
On Mon, Oct 12, 2015 at 9:00 PM, Glen Barber wrote: > On Mon, Oct 12, 2015 at 08:49:15PM -0700, Garrett Cooper wrote: >> NTB? >> > > The driver name? Yep. ___ svn-src-all@freebsd.org mailing list

Re: svn commit: r287442 - in head: lib/libprocstat lib/libutil share/man/man5 sys/kern sys/sys

2015-09-05 Thread Conrad Meyer
I'll be offline for the next ~48 hours. It sounds like it's annoying but not critical to fix. If it isn't fixed when I get back, I'll figure something out. Thanks, Conrad P.S., What systems have both imgact_elf64 and 32? On Sat, Sep 5, 2015 at 7:04 AM, Tijl Coosemans wrote: >

Re: svn commit: r287442 - in head: lib/libprocstat lib/libutil share/man/man5 sys/kern sys/sys

2015-09-07 Thread Conrad Meyer
On Sat, Sep 5, 2015 at 7:04 AM, Tijl Coosemans wrote: > This file can be compiled twice (included by both imgact_elf32.c and > imgact_elf64.c) so this sysctl can be added twice and the second time > results in an error message in dmesg: "can't re-use a leaf". Fixed in r287537,

Re: svn commit: r287403 - head/sys/dev/ioat

2015-09-02 Thread Conrad Meyer
On Wed, Sep 2, 2015 at 10:26 AM, John Baldwin wrote: > Alternatively you could use pci_restore_state() (before reset) and > pci_save_state() (after reset) to restore standard PCI config registers > (including MSI/MSI-X) after a reset. > > This might be more scalable if you want

Re: svn commit: r287403 - head/sys/dev/ioat

2015-09-02 Thread Conrad Meyer
https://reviews.freebsd.org/D3552 On Wed, Sep 2, 2015 at 12:15 PM, Conrad Meyer <c...@freebsd.org> wrote: > On Wed, Sep 2, 2015 at 10:26 AM, John Baldwin <j...@freebsd.org> wrote: >> Alternatively you could use pci_restore_state() (before reset) and >> pci_save_state

Re: svn commit: r288079 - in stable/10/sys: kern sys

2015-09-22 Thread Conrad Meyer
On Mon, Sep 21, 2015 at 11:55 PM, Oliver Pinter wrote: > On 9/22/15, Oliver Pinter wrote: >> Seems like this commit breaks the build: >> >> --- vfs_hash.o --- >>

Re: svn commit: r291907 - head/sys/vm

2015-12-07 Thread Conrad Meyer
On Mon, Dec 7, 2015 at 11:32 AM, Oliver Pinter wrote: > On 12/6/15, Conrad E. Meyer wrote: >> Author: cem >> Date: Sun Dec 6 17:46:12 2015 >> New Revision: 291907 >> URL: https://svnweb.freebsd.org/changeset/base/291907 >> >> Log: >>

Re: svn commit: r291741 - head/sys/geom

2015-12-04 Thread Conrad Meyer
On Fri, Dec 4, 2015 at 10:03 AM, Bruce Evans wrote: > On Fri, 4 Dec 2015, Andrew Turner wrote: >> I don't seem to see where in style(9) we disallow the use of bool. Can >> you point me where this is specified? > > > This is specified by not giving an example of using it.

Re: svn commit: r293039 - in head/sys/dev: sec tsec

2016-01-01 Thread Conrad Meyer
On Fri, Jan 1, 2016 at 7:17 AM, Justin Hibbits wrote: > Author: jhibbits > Date: Fri Jan 1 15:17:24 2016 > New Revision: 293039 > URL: https://svnweb.freebsd.org/changeset/base/293039 > > Log: > Fix a couple printf formats. > > ... > @@ -235,7 +236,7 @@ sec_probe(device_t

Re: svn commit: r293328 - head/sys/dev/nvme

2016-01-07 Thread Conrad Meyer
I believe it's spelled "howmany()." On Thu, Jan 7, 2016 at 8:27 AM, Ravi Pokala wrote: > -Original Message- > > > From: on behalf of Jim Harris > > Date: 2016-01-07, Thursday at 08:18 > To:

Re: svn commit: r292528 - head/sys/x86/include

2015-12-21 Thread Conrad Meyer
No, I didn't forget. AVX512VBMI is a flag in ECX ("cpu_stdext_feature2") rather than EBX ("cpu_stdext_feature"), and there aren't any macros for any of the ECX flags yet (PREFETCHWT1, AVX512VBMI, PKU, and OSPKE). Best, Conrad On Mon, Dec 21, 2015 at 12:57 PM, Ravi Pokala

Re: svn commit: r292454 - head/bin/ed

2015-12-18 Thread Conrad Meyer
On Fri, Dec 18, 2015 at 2:44 PM, Pedro Giffuni wrote: > Hi Warner; > >> Il giorno 18/dic/2015, alle ore 17:01, Warner Losh ha >> scritto: >> >> Isn’t strlcpy() the more appropriate interface? strncpy doesn’t guarantee >> NUL termination. >> > > Maybe, but we

Re: svn commit: r291263 - head/sys/dev/ntb/ntb_hw

2015-11-24 Thread Conrad Meyer
On Tue, Nov 24, 2015 at 10:51 AM, Conrad E. Meyer wrote: > Author: cem > Date: Tue Nov 24 18:51:17 2015 > New Revision: 291263 > URL: https://svnweb.freebsd.org/changeset/base/291263 > > Log: > ntb: Add MW tunable for MMR Xeon errata workaround > > Adds a new tunable,

Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64

2016-01-12 Thread Conrad Meyer
On Tue, Jan 12, 2016 at 5:32 PM, Ian Lepore wrote: > Yep, but then I had to do this because ef->off is 64 bits even on 32 > bit arches, so I got a pointer/int size mismatch warning... > > Index: common/load_elf.c >

Re: svn commit: r301339 - in head: contrib/libucl/src contrib/libucl/uthash lib/libucl

2016-06-04 Thread Conrad Meyer
On Sat, Jun 4, 2016 at 7:57 AM, Baptiste Daroussin wrote: > Author: bapt > Date: Sat Jun 4 14:57:25 2016 > New Revision: 301339 > URL: https://svnweb.freebsd.org/changeset/base/301339 > > Log: > Import libucl snapshot 20160604 > > It replaces xxhash with mumhash Why was

Re: svn commit: r301741 - head/sys/cam

2016-06-09 Thread Conrad Meyer
i386 as well (although we are replying to the wrong commit, I think r301771 is what broke it): In file included from /usr/src/sbin/camcontrol/camcontrol.c:56: /usr/obj/usr/src/tmp/usr/include/cam/cam_ccb.h:44:10: fatal error: 'cam/nvme/nvme_all.h' file not found #include ^ Best, Conrad

Re: svn commit: r300965 - head/lib/libc/stdlib

2016-05-29 Thread Conrad Meyer
Does clang actually generate different code with this change? On Sun, May 29, 2016 at 9:39 AM, Andrey A. Chernov wrote: > Author: ache > Date: Sun May 29 16:39:28 2016 > New Revision: 300965 > URL: https://svnweb.freebsd.org/changeset/base/300965 > > Log: > Micro optimize: C

Re: svn commit: r300868 - head/tools/tools/ioat

2016-05-27 Thread Conrad Meyer
I don't think such infrastructure is needed for simple test code like this. 128 is more than enough. On Fri, May 27, 2016 at 1:51 PM, Ngie Cooper (yaneurabeya) <yaneurab...@gmail.com> wrote: > >> On May 27, 2016, at 13:34, Conrad Meyer <c...@freebsd.org> wrote: >> >

Re: svn commit: r300866 - head/sys/boot/efi/libefi

2016-05-27 Thread Conrad Meyer
It seems he meant 'media native IO size', not 'media size'. I.e., on 4Kn media, 4k-multiple and -aligned IOs can be processed directly (but EFI's unit block size is still 512). Does that make sense? Best, Conrad On Fri, May 27, 2016 at 1:05 PM, Ravi Pokala wrote: >

Re: svn commit: r300868 - head/tools/tools/ioat

2016-05-27 Thread Conrad Meyer
On Fri, May 27, 2016 at 1:12 PM, Garrett Cooper wrote: > Author: ngie > Date: Fri May 27 20:12:32 2016 > New Revision: 300868 > URL: https://svnweb.freebsd.org/changeset/base/300868 > > Log: > Remove note about bogus chain-len maximum > > There's no current limit on

Re: svn commit: r300824 - head/lib/libmd

2016-05-27 Thread Conrad Meyer
There's nothing to support — literally ignoring the keyword is an acceptable implementation. So it's disappointing C++ chooses to reject C keywords. My take is that C++ programs shouldn't be including sys/md5.h directly at all. That's the kernel's header. If they want to use md5, they go

Re: svn commit: r301959 - head/sys/kern

2016-06-16 Thread Conrad Meyer
On Thu, Jun 16, 2016 at 4:58 AM, Konstantin Belousov wrote: > --- head/sys/kern/kern_thread.c Thu Jun 16 11:55:24 2016(r301958) > +++ head/sys/kern/kern_thread.c Thu Jun 16 11:58:46 2016(r301959) > @@ -669,11 +669,6 @@ weed_inhib(int mode, struct thread *td2, >

Re: svn commit: r293640 - head/sys/vm

2016-01-11 Thread Conrad Meyer
Does this fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204121 ? Thanks, Conrad On Sun, Jan 10, 2016 at 9:53 AM, Adrian Chadd wrote: > Author: adrian > Date: Sun Jan 10 17:53:43 2016 > New Revision: 293640 > URL: https://svnweb.freebsd.org/changeset/base/293640 > >

Re: svn commit: r294909 - head/crypto/openssh

2016-01-27 Thread Conrad Meyer
From context in other emails: This commit will not be MFCed, because this configuration is already enabled in stable/10. For the same reason, it doesn't need Relnotes. Best, Conrad On Wed, Jan 27, 2016 at 9:25 AM, NGie Cooper wrote: > >> On Jan 27, 2016, at 05:40,

Re: svn commit: r295134 - head/sys/kgssapi/krb5

2016-02-02 Thread Conrad Meyer
On Tue, Feb 2, 2016 at 10:21 AM, Alan Somers wrote: > On Mon, Feb 1, 2016 at 5:14 PM, Conrad E. Meyer wrote: >> URL: https://svnweb.freebsd.org/changeset/base/295134 >> >> Log: >> kcrypto_aes: Use separate sessions for AES and SHA1 > > Thanks for doing

Re: svn commit: r295209 - head/sys/fs/ext2fs

2016-02-03 Thread Conrad Meyer
On Wed, Feb 3, 2016 at 6:31 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Wed Feb 3 14:31:23 2016 > New Revision: 295209 > URL: https://svnweb.freebsd.org/changeset/base/295209 > > Log: > Revert r294695: > ext2fs: passthrough any extra timestamps to the dinode struct. >

Re: svn commit: r296025 - head/sys/netpfil/pf

2016-02-24 Thread Conrad Meyer
On Wed, Feb 24, 2016 at 11:41 PM, Adrian Chadd wrote: > .. what's capping totlen so one doesn't run out of memory? There was a DoS vector before (user controlled io->pfrio_size) and basically the same DoS vector now (either of io->pfrio_size or io->pfrio_size2). This

Re: svn commit: r294495 - in head: . crypto/openssh

2016-01-21 Thread Conrad Meyer
On Thu, Jan 21, 2016 at 3:10 AM, Dag-Erling Smørgrav wrote: > Author: des > Date: Thu Jan 21 11:10:14 2016 > New Revision: 294495 > URL: https://svnweb.freebsd.org/changeset/base/294495 > > Log: > Enable DSA keys by default. They were disabled in OpenSSH 6.9p1. Are we going

Re: svn commit: r294471 - head/sys/dev/usb/wlan

2016-01-21 Thread Conrad Meyer
On Thu, Jan 21, 2016 at 1:52 AM, Andriy Gapon wrote: > On 21/01/2016 03:28, Mark Johnston wrote: >> Isilon has done ad-hoc implementations of this for bufs and mbufs, and >> they're quite handy for debugging. With BUF_TRACKING enabled in our >> kernel config, each buf contains a

Re: svn commit: r290475 - in head: share/man/man9 sys/kern sys/sys

2016-01-24 Thread Conrad Meyer
No. They break ABI. Best, Conrad On Sun, Jan 24, 2016 at 1:45 PM, Oliver Pinter <oliver.pin...@hardenedbsd.org> wrote: > On 11/8/15, Hans Petter Selasky <h...@selasky.org> wrote: >> On 11/07/15 19:26, Conrad Meyer wrote: >>> Can do — fixed in r290505. >>>

Re: svn commit: r294547 - head/sys/boot/kshim

2016-01-22 Thread Conrad Meyer
Is this incomplete? On Thu, Jan 21, 2016 at 10:26 PM, Wojciech Macek wrote: > Author: wma > Date: Fri Jan 22 06:26:11 2016 > New Revision: 294547 > URL: https://svnweb.freebsd.org/changeset/base/294547 > > Log: > Provide busdma stubs for loader/kshim > > Simple bus

Re: svn commit: r295631 - head/lib/libc/stdio

2016-02-15 Thread Conrad Meyer
On Mon, Feb 15, 2016 at 10:13 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Mon Feb 15 18:13:33 2016 > New Revision: 295631 > URL: https://svnweb.freebsd.org/changeset/base/295631 > ... > Note that this implementation convention cannot be adhered to for strings > longer

Re: svn commit: r295768 - head/usr.sbin/iostat

2016-02-19 Thread Conrad Meyer
On Fri, Feb 19, 2016 at 3:06 PM, Gleb Smirnoff wrote: > Isn't zero filling part of the standard? I don't see why lack of > explicit zeroing is a warning? Looks a false warning to me. Yep. This is Clang being too whiney, IMO. I think a good workaround is to add

Re: svn commit: r295768 - head/usr.sbin/iostat

2016-02-19 Thread Conrad Meyer
On Fri, Feb 19, 2016 at 3:14 PM, Benjamin Kaduk wrote: > On Fri, Feb 19, 2016 at 5:06 PM, Gleb Smirnoff wrote: >> Isn't zero filling part of the standard? I don't see why lack of >> explicit zeroing is a warning? Looks a false warning to me. > > > It is

Re: svn commit: r296918 - head/sys/fs/autofs

2016-03-15 Thread Conrad Meyer
Instead you will get, "warning: unused but set variable 'error'" on -NODEBUG builds. Maybe add: (void)error; Best, Conrad On Tue, Mar 15, 2016 at 1:42 PM, Edward Tomasz Napierala wrote: > Author: trasz > Date: Tue Mar 15 20:42:36 2016 > New Revision: 296918 > URL:

Re: svn commit: r296927 - in head: share/man/man9 sys/kern sys/sys

2016-03-19 Thread Conrad Meyer
Sorry. I guess that whole routine needs to be wrapped in #if defined(STACK). I'll work to put together a patch soon. Thanks, Conrad On Wed, Mar 16, 2016 at 3:02 PM, Bjoern A. Zeeb wrote: > On Wed, 16 Mar 2016, Conrad E. Meyer wrote: > >> Author: cem >> Date:

Re: svn commit: r296548 - in head/sys: dev/agp dev/drm2 dev/drm2/i915 modules/drm2/i915kms

2016-03-09 Thread Conrad Meyer
On Wed, Mar 9, 2016 at 12:48 PM, Adrian Chadd wrote: > Woo! > > Just so its' not lost - people in irc have found power consumption has > jumped dramatically since this commit. :( For the record, on X230 (Ivybridge) I actually see lower power consumption with the new 3.8

Re: svn commit: r297897 - in head/usr.bin: . resizewin

2016-04-12 Thread Conrad Meyer
On Tue, Apr 12, 2016 at 5:30 PM, Conrad E. Meyer wrote: > Author: cem > Date: Wed Apr 13 00:30:42 2016 > New Revision: 297897 > URL: https://svnweb.freebsd.org/changeset/base/297897 > > Log: > Add a small tool, resizewin(1), to query terminal for window size Whoops. The

Re: svn commit: r297748 - in head/sys: conf dev/acpica kern vm x86/acpica

2016-04-09 Thread Conrad Meyer
On Sat, Apr 9, 2016 at 6:58 AM, John Baldwin wrote: > Author: jhb > Date: Sat Apr 9 13:58:04 2016 > New Revision: 297748 > URL: https://svnweb.freebsd.org/changeset/base/297748 > > Log: > Add more fine-grained kernel options for NUMA support. > ... > > MAXMEMDOM must still

Re: svn commit: r296548 - in head/sys: dev/agp dev/drm2 dev/drm2/i915 modules/drm2/i915kms

2016-04-11 Thread Conrad Meyer
an > > > On 9 March 2016 at 17:31, Conrad Meyer <c...@freebsd.org> wrote: >> On Wed, Mar 9, 2016 at 12:48 PM, Adrian Chadd <adrian.ch...@gmail.com> wrote: >>> Woo! >>> >>> Just so its' not lost - people in irc have found power consumption has &g

Re: svn commit: r296927 - in head: share/man/man9 sys/kern sys/sys

2016-03-20 Thread Conrad Meyer
Fixed in r296973. On Wed, Mar 16, 2016 at 3:02 PM, Bjoern A. Zeeb wrote: > On Wed, 16 Mar 2016, Conrad E. Meyer wrote: > >> Author: cem >> Date: Wed Mar 16 04:22:32 2016 >> New Revision: 296927 >> URL: https://svnweb.freebsd.org/changeset/base/296927 >> >> Log: >>

Re: svn commit: r297193 - head/sys/netinet

2016-03-22 Thread Conrad Meyer
On Tue, Mar 22, 2016 at 8:55 AM, Jonathan T. Looney wrote: > Author: jtl > Date: Tue Mar 22 15:55:17 2016 > New Revision: 297193 > URL: https://svnweb.freebsd.org/changeset/base/297193 > > ... > > MFC after:2 weeks This change seems like it would be ineligible for a MFC

Re: svn commit: r297201 - in head: share/man/man4 sys/dev/filemon

2016-03-22 Thread Conrad Meyer
On Tue, Mar 22, 2016 at 3:41 PM, Bryan Drewery wrote: > Author: bdrewery > Date: Tue Mar 22 22:41:07 2016 > New Revision: 297201 > ... > --- head/share/man/man4/filemon.4 Tue Mar 22 22:41:03 2016 > (r297200) > +++ head/share/man/man4/filemon.4 Tue Mar 22

Re: svn commit: r297201 - in head: share/man/man4 sys/dev/filemon

2016-03-22 Thread Conrad Meyer
On Tue, Mar 22, 2016 at 7:46 PM, Benjamin Kaduk wrote: > On Tue, Mar 22, 2016 at 9:11 PM, Bryan Drewery wrote: >> >> The manpage for close(2) does document some errors, one being ENOSPC. The >> close(2) behavior of returning write(2), really

Re: svn commit: r297331 - head/sbin/devd

2016-04-02 Thread Conrad Meyer
Should this be: On Sun, Mar 27, 2016 at 9:22 PM, Warner Losh wrote: > Author: imp > Date: Mon Mar 28 04:22:22 2016 > New Revision: 297331 > URL: https://svnweb.freebsd.org/changeset/base/297331 > ... > @@ -793,10 +793,15 @@ process_event(char *buffer) >

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Conrad Meyer
On Tue, Apr 26, 2016 at 2:13 PM, Adrian Chadd wrote: > You mean "hotplug mount a malicious USB disk via some installed > graphical enviornment?" > > NOone does that... :) Sure, but there the vulnerability is (IMO) that users are allowed to arbitrarily mount stuff. That's

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Conrad Meyer
On Tue, Apr 26, 2016 at 2:01 PM, Shawn Webb wrote: > On Tue, Apr 26, 2016 at 08:36:32PM +, Kristof Provost wrote: >> Author: kp >> Date: Tue Apr 26 20:36:32 2016 >> New Revision: 298664 >> URL: https://svnweb.freebsd.org/changeset/base/298664 >> >> Log: >>

Re: svn commit: r298669 - head/sys/dev/iscsi_initiator

2016-04-26 Thread Conrad Meyer
On Tue, Apr 26, 2016 at 2:59 PM, Oliver Pinter wrote: > On Tue, Apr 26, 2016 at 11:44 PM, Conrad E. Meyer wrote: >> Author: cem >> Date: Tue Apr 26 21:44:08 2016 >> New Revision: 298669 >> URL: https://svnweb.freebsd.org/changeset/base/298669 >>

Re: svn commit: r298789 - in head/sys: kern sys

2016-04-29 Thread Conrad Meyer
I think you'll want to remove them from the subsequent PRINT_BUF_FLAGS too. Best, Conrad On Fri, Apr 29, 2016 at 9:32 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Fri Apr 29 16:32:28 2016 > New Revision: 298789 > URL: https://svnweb.freebsd.org/changeset/base/298789 > >

Re: svn commit: r298655 - head/sys/kgssapi

2016-04-26 Thread Conrad Meyer
forgot it, or because the committer > just "doesn't do stable". > > Please help maintain stable/10. It's everyone's job. > -Alan > > On Tue, Apr 26, 2016 at 1:23 PM, Conrad Meyer <c...@freebsd.org> wrote: > >> Nope! I don't do stable/. >> >&g

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread Conrad Meyer
the 1:1 relationship between stack sbufs and DYNSTRUCT. Best, Conrad On Tue, Apr 26, 2016 at 1:45 PM, Ulrich Spörlein <uspoerl...@gmail.com> wrote: > On Apr 26, 2016 11:44 AM, "Conrad Meyer" <c...@freebsd.org> wrote: >> >> Right. False positive. Coverit

Re: svn commit: r298656 - head/sys/kern

2016-04-26 Thread Conrad Meyer
The sbuf use here was fine before. Best, Conrad On Tue, Apr 26, 2016 at 11:17 AM, Jamie Gritton wrote: > Author: jamie > Date: Tue Apr 26 18:17:44 2016 > New Revision: 298656 > URL: https://svnweb.freebsd.org/changeset/base/298656 > > Log: > Redo the changes to the SYSV

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread Conrad Meyer
Right. False positive. Coverity doesn't grok sbuf memory management fully. On Tue, Apr 26, 2016 at 11:22 AM, NGie Cooper wrote: > > > On Apr 26, 2016, at 11:03, Ulrich Spörlein wrote: > > > > 2016-04-25 10:06 GMT-07:00 Jamie Gritton

Re: svn commit: r298655 - head/sys/kgssapi

2016-04-26 Thread Conrad Meyer
Nope! I don't do stable/. On Tue, Apr 26, 2016 at 12:06 PM, Alan Somers wrote: > Nice catch. Will you be MFCing this to stable/10? > > On Tue, Apr 26, 2016 at 12:11 PM, Conrad E. Meyer wrote: > >> Author: cem >> Date: Tue Apr 26 18:11:45 2016 >> New

Re: svn commit: r300496 - in head/sys/compat/linuxkpi/common: include/linux src

2016-05-23 Thread Conrad Meyer
Didn't we already have list_sort in linuxkpi? Maybe I'm confused. On Mon, May 23, 2016 at 5:03 AM, Hans Petter Selasky wrote: > Author: hselasky > Date: Mon May 23 12:03:40 2016 > New Revision: 300496 > URL: https://svnweb.freebsd.org/changeset/base/300496 > > Log: > Add

Re: svn commit: r299090 - in head: etc/mtree include lib/libbluetooth sbin/hastd share/man/man3 sys/dev/xen/blkback sys/kern sys/net sys/sys tests/sys tests/sys/sys usr.sbin/bluetooth/hccontrol

2016-05-23 Thread Conrad Meyer
On Mon, May 23, 2016 at 4:34 PM, Alan Somers wrote: > On Mon, May 23, 2016 at 5:13 PM, Bryan Drewery wrote: >> >> On 5/23/16 1:30 PM, Alan Somers wrote: >> > UPDATING is updated as of r300539. Any objection to merging this to >> > stable/10? >> >> If

Re: svn commit: r300177 - head/contrib/ipfilter/man

2016-05-18 Thread Conrad Meyer
On Wed, May 18, 2016 at 7:06 PM, Cy Schubert wrote: > Author: cy > Date: Thu May 19 02:06:48 2016 > New Revision: 300177 > URL: https://svnweb.freebsd.org/changeset/base/300177 > > Log: > Fix typo. > > Modified: head/contrib/ipfilter/man/ipf.5 >

Re: svn commit: r300620 - head/lib/libc/rpc

2016-05-24 Thread Conrad Meyer
On Tue, May 24, 2016 at 11:44 AM, Garrett Cooper wrote: > Author: ngie > Date: Tue May 24 18:44:50 2016 > New Revision: 300620 > URL: https://svnweb.freebsd.org/changeset/base/300620 > > Log: > Use reallocf instead of malloc to fix leak with outbuf_pmap > > ... > > Add a

Re: svn commit: r300332 - in head/sys: amd64/amd64 i386/i386

2016-05-20 Thread Conrad Meyer
On Fri, May 20, 2016 at 4:02 PM, Bruce Evans wrote: > On Fri, 20 May 2016, Konstantin Belousov wrote: > >> --- head/sys/i386/i386/sys_machdep.cFri May 20 19:46:25 2016 >> (r300331) >> +++ head/sys/i386/i386/sys_machdep.cFri May 20 19:50:32 2016 >> (r300332) >> @@

Re: svn commit: r300332 - in head/sys: amd64/amd64 i386/i386

2016-05-20 Thread Conrad Meyer
On Fri, May 20, 2016 at 6:10 PM, Bruce Evans <b...@optusnet.com.au> wrote: > On Fri, 20 May 2016, Conrad Meyer wrote: > >> On Fri, May 20, 2016 at 4:02 PM, Bruce Evans <b...@optusnet.com.au> wrote: >>> >>> On Fri, 20 May 2016, Konstantin Belou

Re: svn commit: r300377 - head/sys/compat/ndis

2016-05-21 Thread Conrad Meyer
On Sat, May 21, 2016 at 10:52 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Sat May 21 17:52:44 2016 > New Revision: 300377 > URL: https://svnweb.freebsd.org/changeset/base/300377 > > Log: > ndis(4): Avoid overflow. > > This is a long standing problem: our random()

Re: svn commit: r300377 - head/sys/compat/ndis

2016-05-21 Thread Conrad Meyer
On Sat, May 21, 2016 at 1:40 PM, Pedro Giffuni <p...@freebsd.org> wrote: > > > On 05/21/16 14:05, Conrad Meyer wrote: >> Won't this still return a negative integer in many cases? >> >> random(9) returns u_long, whereas this rand() routine returns 'int'. >&

Re: svn commit: r300332 - in head/sys: amd64/amd64 i386/i386

2016-05-21 Thread Conrad Meyer
On Fri, May 20, 2016 at 9:13 PM, Bruce Evans <b...@optusnet.com.au> wrote: > On Fri, 20 May 2016, Conrad Meyer wrote: > >> On Fri, May 20, 2016 at 6:10 PM, Bruce Evans <b...@optusnet.com.au> wrote: >>> >>> >>> Signed integers are easier to u

Re: svn commit: r299473 - head/usr.bin/whois

2016-05-11 Thread Conrad Meyer
This commit message should have said: "No functional change." (As opposed to the follow-up commit which will come shortly.) Thanks, Conrad On Wed, May 11, 2016 at 10:52 AM, Conrad E. Meyer wrote: > Author: cem > Date: Wed May 11 17:52:06 2016 > New Revision: 299473 > URL:

Re: svn commit: r299467 - in head: share/man/man9 sys/dev/pci

2016-05-11 Thread Conrad Meyer
Backed out in r299493. Please re-commit after it compiles. Best, Conrad On Wed, May 11, 2016 at 2:50 PM, Jung-uk Kim wrote: > On 05/11/16 05:38 PM, Bjoern A. Zeeb wrote: >> >>> On 11 May 2016, at 17:07 , Andrew Turner wrote: >>> >>> Author: andrew >>>

Re: svn commit: r300062 - in head/sys: gnu/fs modules modules/reiserfs

2016-05-17 Thread Conrad Meyer
On Tue, May 17, 2016 at 9:29 AM, Pedro Giffuni wrote: >> Log: >> Kill off ReiserFS as it is no longer supported, for obvious reasons. >> > > It's not so obvious since the fs worked and could've been useful for > people migrating from ancient linux. This may still be possible

Re: svn commit: r299930 - in head/sys/compat/linuxkpi/common: include/linux src

2016-05-16 Thread Conrad Meyer
On Mon, May 16, 2016 at 2:16 AM, Hans Petter Selasky wrote: > Author: hselasky > Date: Mon May 16 09:16:15 2016 > New Revision: 299930 > URL: https://svnweb.freebsd.org/changeset/base/299930 > > Log: > Properly implement "cpu_has_clflush" macro. > ... > @@ -51,6 +51,10 @@

Re: svn commit: r300005 - head/usr.bin/ncal

2016-05-17 Thread Conrad Meyer
On Mon, May 16, 2016 at 10:05 PM, Don Lewis wrote: > Author: truckman > Date: Tue May 17 05:05:30 2016 > New Revision: 35 > URL: https://svnweb.freebsd.org/changeset/base/35 > > Log: > swprintf() and apparently wcsftime() want the their output buffer size >

Re: svn commit: r299751 - head/sys/dev/bwn

2016-05-14 Thread Conrad Meyer
On Sat, May 14, 2016 at 12:52 PM, Adrian Chadd wrote: > Author: adrian > Date: Sat May 14 19:52:04 2016 > New Revision: 299751 > URL: https://svnweb.freebsd.org/changeset/base/299751 > > Log: > [bwn] migrate sqrt and add another couple of util routines. > > ... > > +unsigned

Re: svn commit: r299778 - head/usr.sbin/bsnmpd/tools/libbsnmptools

2016-05-15 Thread Conrad Meyer
On Sat, May 14, 2016 at 4:22 PM, Garrett Cooper wrote: > Author: ngie > Date: Sat May 14 23:22:38 2016 > New Revision: 299778 > URL: https://svnweb.freebsd.org/changeset/base/299778 > > Log: > Use a consistent errno save/restore pattern before running strtoul This is begging

Re: svn commit: r299456 - in head: include lib/libc/stdio

2016-05-12 Thread Conrad Meyer
On Thu, May 12, 2016 at 12:49 PM, Antoine Brodin wrote: > On Wed, May 11, 2016 at 4:38 PM, Conrad E. Meyer wrote: >> Author: cem >> Date: Wed May 11 14:38:27 2016 >> New Revision: 299456 >> URL: https://svnweb.freebsd.org/changeset/base/299456 >> >> Log: >>

Re: svn commit: r298665 - head/sys/dev/aacraid

2016-05-03 Thread Conrad Meyer
On Tue, May 3, 2016 at 12:00 PM, Oliver Pinter wrote: > strlcpy instead or adjust the p->vendors size? Neither. The buffer is intentionally not nul-terminated. The coverity reports are false positives. Conrad ___

Re: svn commit: r298665 - head/sys/dev/aacraid

2016-05-03 Thread Conrad Meyer
On Tue, May 3, 2016 at 1:29 PM, Warner Losh <i...@bsdimp.com> wrote: > >> On May 3, 2016, at 1:44 PM, Conrad Meyer <c...@freebsd.org> wrote: >> >> On Tue, May 3, 2016 at 12:00 PM, Oliver Pinter >> <oliver.pin...@hardenedbsd.org> wrote: >

  1   2   3   4   5   6   7   >