Re: svn commit: r286649 - in head: contrib/netbsd-tests/lib/libc/locale lib/libc/tests/locale

[Jilles Tjoelker]

On Wed, Jan 11, 2017 at 02:14:13AM -0800, Ngie Cooper (yaneurabeya) wrote:

> > On Aug 11, 2015, at 6:45 PM, Craig Rodrigues  wrote:
> > 
> > On Tue, Aug 11, 2015 at 2:59 PM, Jilles Tjoelker  > > wrote:
> > Author: jilles
> > Date: Tue Aug 11 21:59:36 2015
> > New Revision: 286649
> > URL: https://svnweb.freebsd.org/changeset/base/286649 
> > 

> > Log:
> >   Fix and re-enable UTF-8 tests.

> > Modified:
> >   head/contrib/netbsd-tests/lib/libc/locale/t_mbrtowc.c
> >   head/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c
> >   head/lib/libc/tests/locale/Makefile

> > Thanks for fixing this.  What is the procedure that FreeBSD
> > developers need to follow to push this kind of change upstream to
> > NetBSD?

>   I’m submitting PRs with NetBSD as needed. To be frank, I’m not
> sure that this change is needed upstream (I’m probably going to #ifdef
> the code — some things I found when trying to push things back).

I think the change is required upstream as well, since UTF-8 no longer
includes code points greater than 0x10 per RFC 3629 (this change
made the code point ranges of UTF-8 and UTF-16 the same). The sequences
that used to correspond to code points greater than 0x10 shall be
treated as invalid. See also SVN r286490, r286491, r287125.

I suppose I should have included this reasoning in the original commit
message.

-- 
Jilles Tjoelker
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r286649 - in head: contrib/netbsd-tests/lib/libc/locale lib/libc/tests/locale

[Ngie Cooper (yaneurabeya)]

> On Aug 11, 2015, at 6:45 PM, Craig Rodrigues  wrote:
> 
> On Tue, Aug 11, 2015 at 2:59 PM, Jilles Tjoelker  > wrote:
> Author: jilles
> Date: Tue Aug 11 21:59:36 2015
> New Revision: 286649
> URL: https://svnweb.freebsd.org/changeset/base/286649 
> 
> 
> Log:
>   Fix and re-enable UTF-8 tests.
> 
> Modified:
>   head/contrib/netbsd-tests/lib/libc/locale/t_mbrtowc.c
>   head/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c
>   head/lib/libc/tests/locale/Makefile
> 
> 
> Thanks for fixing this.  What is the procedure that FreeBSD developers need 
> to follow
> to push this kind of change upstream to NetBSD?

I’m submitting PRs with NetBSD as needed. To be frank, I’m not sure 
that this change is needed upstream (I’m probably going to #ifdef the code — 
some things I found when trying to push things back).
Thanks,
-Ngie
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r286649 - in head: contrib/netbsd-tests/lib/libc/locale lib/libc/tests/locale

[Baptiste Daroussin]

On Tue, Aug 11, 2015 at 09:59:36PM +, Jilles Tjoelker wrote:
 Author: jilles
 Date: Tue Aug 11 21:59:36 2015
 New Revision: 286649
 URL: https://svnweb.freebsd.org/changeset/base/286649
 
 Log:
   Fix and re-enable UTF-8 tests.
 
Thank you very much I should have fixed it myself earlier.

Sorry.
Bapt


pgpYqq4xqeebE.pgp
Description: PGP signature

Re: svn commit: r286649 - in head: contrib/netbsd-tests/lib/libc/locale lib/libc/tests/locale

[NGie Cooper]

On Tue, Aug 11, 2015 at 2:59 PM, Jilles Tjoelker jil...@freebsd.org wrote:
 Author: jilles
 Date: Tue Aug 11 21:59:36 2015
 New Revision: 286649
 URL: https://svnweb.freebsd.org/changeset/base/286649

 Log:
   Fix and re-enable UTF-8 tests.

 Modified:
   head/contrib/netbsd-tests/lib/libc/locale/t_mbrtowc.c
   head/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c
   head/lib/libc/tests/locale/Makefile

I would have appreciated a CR :(...
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org

Re: svn commit: r286649 - in head: contrib/netbsd-tests/lib/libc/locale lib/libc/tests/locale

[Craig Rodrigues]

On Tue, Aug 11, 2015 at 2:59 PM, Jilles Tjoelker jil...@freebsd.org wrote:

 Author: jilles
 Date: Tue Aug 11 21:59:36 2015
 New Revision: 286649
 URL: https://svnweb.freebsd.org/changeset/base/286649

 Log:
   Fix and re-enable UTF-8 tests.

 Modified:
   head/contrib/netbsd-tests/lib/libc/locale/t_mbrtowc.c
   head/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c
   head/lib/libc/tests/locale/Makefile


Thanks for fixing this.  What is the procedure that FreeBSD developers need
to follow
to push this kind of change upstream to NetBSD?

--
Craig
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org