Re: svn commit: r305988 - in head/sys: geom sys

2016-09-21 Thread Edward Tomasz Napierala 
On 0920T0934, Ngie Cooper (yaneurabeya) wrote:
> 
> > On Sep 20, 2016, at 09:28, Alan Somers  wrote:
> > 
> > On Tue, Sep 20, 2016 at 10:23 AM, Alexander Motin  wrote:
> >> On 20.09.2016 09:20, Alan Somers wrote:
> >>> On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala
> >>>  wrote:
>  Author: trasz
>  Date: Mon Sep 19 17:46:15 2016
>  New Revision: 305988
>  URL: https://svnweb.freebsd.org/changeset/base/305988
>  
>  Log:
>   Remove unused bio_taskqueue().
>  
>   MFC after:1 month
>  
>  Modified:
>   head/sys/geom/geom_io.c
>   head/sys/sys/bio.h
>  
> >>> 
> >>> This is a KBI change, so you should bump __FreeBSD_version.  You
> >>> probably shouldn't MFC it, either.
> >> 
> >> The last/only consumer of this KPI I know gone with FreeBSD 9 and old
> >> ATA stack.  Do you know any other?
> > 
> > Nothing in-tree.  But it's publicly visible, so we have no way of
> > knowing who might be using it out-of-tree.
> 
> I’d have to check, but this might impact us (Isilon). We don’t use the 
> __FreeBSD_version #ifdefs though in our code, so it’s fine from my 
> perspective to leave things alone.
> 
> That being said, are you sure that port klds (e.g. open-vm-tools*) aren’t 
> impacted by this change? Did it go through a ports -exp run?

I'm not sure if it's worth it.  If something comes up, I'll fix it.

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r305988 - in head/sys: geom sys

2016-09-21 Thread Edward Tomasz Napierala 
On 0920T1020, Alan Somers wrote:
> On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala
>  wrote:
> > Author: trasz
> > Date: Mon Sep 19 17:46:15 2016
> > New Revision: 305988
> > URL: https://svnweb.freebsd.org/changeset/base/305988
> >
> > Log:
> >   Remove unused bio_taskqueue().
> >
> >   MFC after:1 month
> >
> > Modified:
> >   head/sys/geom/geom_io.c
> >   head/sys/sys/bio.h
> >
> 
> This is a KBI change, so you should bump __FreeBSD_version.  You
> probably shouldn't MFC it, either.

Done, thanks.  I won't MFC it either.

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r305988 - in head/sys: geom sys

2016-09-20 Thread Ngie Cooper (yaneurabeya) 

> On Sep 20, 2016, at 09:28, Alan Somers  wrote:
> 
> On Tue, Sep 20, 2016 at 10:23 AM, Alexander Motin  wrote:
>> On 20.09.2016 09:20, Alan Somers wrote:
>>> On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala
>>>  wrote:
 Author: trasz
 Date: Mon Sep 19 17:46:15 2016
 New Revision: 305988
 URL: https://svnweb.freebsd.org/changeset/base/305988
 
 Log:
  Remove unused bio_taskqueue().
 
  MFC after:1 month
 
 Modified:
  head/sys/geom/geom_io.c
  head/sys/sys/bio.h
 
>>> 
>>> This is a KBI change, so you should bump __FreeBSD_version.  You
>>> probably shouldn't MFC it, either.
>> 
>> The last/only consumer of this KPI I know gone with FreeBSD 9 and old
>> ATA stack.  Do you know any other?
> 
> Nothing in-tree.  But it's publicly visible, so we have no way of
> knowing who might be using it out-of-tree.

I’d have to check, but this might impact us (Isilon). We don’t use the 
__FreeBSD_version #ifdefs though in our code, so it’s fine from my perspective 
to leave things alone.

That being said, are you sure that port klds (e.g. open-vm-tools*) aren’t 
impacted by this change? Did it go through a ports -exp run?

Thanks,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r305988 - in head/sys: geom sys

2016-09-20 Thread Alan Somers 
On Tue, Sep 20, 2016 at 10:23 AM, Alexander Motin  wrote:
> On 20.09.2016 09:20, Alan Somers wrote:
>> On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala
>>  wrote:
>>> Author: trasz
>>> Date: Mon Sep 19 17:46:15 2016
>>> New Revision: 305988
>>> URL: https://svnweb.freebsd.org/changeset/base/305988
>>>
>>> Log:
>>>   Remove unused bio_taskqueue().
>>>
>>>   MFC after:1 month
>>>
>>> Modified:
>>>   head/sys/geom/geom_io.c
>>>   head/sys/sys/bio.h
>>>
>>
>> This is a KBI change, so you should bump __FreeBSD_version.  You
>> probably shouldn't MFC it, either.
>
> The last/only consumer of this KPI I know gone with FreeBSD 9 and old
> ATA stack.  Do you know any other?
>
> --
> Alexander Motin

Nothing in-tree.  But it's publicly visible, so we have no way of
knowing who might be using it out-of-tree.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r305988 - in head/sys: geom sys

2016-09-20 Thread Alexander Motin 
On 20.09.2016 09:20, Alan Somers wrote:
> On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala
>  wrote:
>> Author: trasz
>> Date: Mon Sep 19 17:46:15 2016
>> New Revision: 305988
>> URL: https://svnweb.freebsd.org/changeset/base/305988
>>
>> Log:
>>   Remove unused bio_taskqueue().
>>
>>   MFC after:1 month
>>
>> Modified:
>>   head/sys/geom/geom_io.c
>>   head/sys/sys/bio.h
>>
> 
> This is a KBI change, so you should bump __FreeBSD_version.  You
> probably shouldn't MFC it, either.

The last/only consumer of this KPI I know gone with FreeBSD 9 and old
ATA stack.  Do you know any other?

-- 
Alexander Motin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r305988 - in head/sys: geom sys

2016-09-20 Thread Alan Somers 
On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala
 wrote:
> Author: trasz
> Date: Mon Sep 19 17:46:15 2016
> New Revision: 305988
> URL: https://svnweb.freebsd.org/changeset/base/305988
>
> Log:
>   Remove unused bio_taskqueue().
>
>   MFC after:1 month
>
> Modified:
>   head/sys/geom/geom_io.c
>   head/sys/sys/bio.h
>

This is a KBI change, so you should bump __FreeBSD_version.  You
probably shouldn't MFC it, either.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"