Re: svn commit: r309368 - stable/11/sys/boot/zfs

[Toomas Soome]

> On 1. dets 2016, at 22:04, Oleksandr Tymoshenko  wrote:
> 
> 
>> On Dec 1, 2016, at 12:01 PM, Oleksandr Tymoshenko  wrote:
>> 
>> 
>>> On Dec 1, 2016, at 11:06 AM, Toomas Soome  wrote:
>>> 
>>> Author: tsoome
>>> Date: Thu Dec  1 19:06:09 2016
>>> New Revision: 309368
>>> URL: https://svnweb.freebsd.org/changeset/base/309368
>>> 
>>> Log:
>>> MFC r308776
>>> 
>>> loader: zfs toplevel vdev must have spa set.
>>> 
>>> PR: 214375
>>> Reported by:lstewart
>>> Reviewed by:allanjude, imp
>>> Approved by:allanjude (mentor), imp (mentor)
>>> Differential Revision:  https://reviews.freebsd.org/D8487
>> 
>> Hi Tom,
> 
> I am sorry, this should have been Toomas, not Tom.


no problem, and sorry, I’m already checking… 

rgds,
toomas
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r309368 - stable/11/sys/boot/zfs

[Oleksandr Tymoshenko]

> On Dec 1, 2016, at 12:34 PM, Toomas Soome  wrote:
> 
> 
>> On 1. dets 2016, at 22:01, Oleksandr Tymoshenko  wrote:
>> 
>> 
>>> On Dec 1, 2016, at 11:06 AM, Toomas Soome  wrote:
>>> 
>>> Author: tsoome
>>> Date: Thu Dec  1 19:06:09 2016
>>> New Revision: 309368
>>> URL: https://svnweb.freebsd.org/changeset/base/309368
>>> 
>>> Log:
>>> MFC r308776
>>> 
>>> loader: zfs toplevel vdev must have spa set.
>>> 
>>> PR: 214375
>>> Reported by:lstewart
>>> Reviewed by:allanjude, imp
>>> Approved by:allanjude (mentor), imp (mentor)
>>> Differential Revision:  https://reviews.freebsd.org/D8487
>> 
>> Hi Tom,
>> 
>> Looks like this commit breaks the build:
>> 
>> In file included from /src/FreeBSD/11/sys/boot/efi/loader/../../zfs/zfs.c:49:
>> /src/FreeBSD/11/sys/boot/efi/loader/../../zfs/zfsimpl.c:1021:13: error: no 
>> membe
>> r named 'spa' in 'struct vdev'
>>   top_vdev->spa = spa;
>>     ^
>> 
>> 
>> 
> 
> Yes, I am so sorry for this confusion, I did back it out; somehow the 
> impression was the skein boot support is already in 11…  my apologies.

No problem. Thanks for fixing. 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r309368 - stable/11/sys/boot/zfs

[Toomas Soome]

> On 1. dets 2016, at 22:01, Oleksandr Tymoshenko  wrote:
> 
> 
>> On Dec 1, 2016, at 11:06 AM, Toomas Soome  wrote:
>> 
>> Author: tsoome
>> Date: Thu Dec  1 19:06:09 2016
>> New Revision: 309368
>> URL: https://svnweb.freebsd.org/changeset/base/309368
>> 
>> Log:
>> MFC r308776
>> 
>> loader: zfs toplevel vdev must have spa set.
>> 
>> PR:  214375
>> Reported by: lstewart
>> Reviewed by: allanjude, imp
>> Approved by: allanjude (mentor), imp (mentor)
>> Differential Revision:   https://reviews.freebsd.org/D8487
> 
> Hi Tom,
> 
> Looks like this commit breaks the build:
> 
> In file included from /src/FreeBSD/11/sys/boot/efi/loader/../../zfs/zfs.c:49:
> /src/FreeBSD/11/sys/boot/efi/loader/../../zfs/zfsimpl.c:1021:13: error: no 
> membe
> r named 'spa' in 'struct vdev'
>top_vdev->spa = spa;
>  ^
> 
> 
> 

Yes, I am so sorry for this confusion, I did back it out; somehow the 
impression was the skein boot support is already in 11…  my apologies.

rgds,
toomas
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r309368 - stable/11/sys/boot/zfs

[Oleksandr Tymoshenko]

> On Dec 1, 2016, at 12:01 PM, Oleksandr Tymoshenko  wrote:
> 
> 
>> On Dec 1, 2016, at 11:06 AM, Toomas Soome  wrote:
>> 
>> Author: tsoome
>> Date: Thu Dec  1 19:06:09 2016
>> New Revision: 309368
>> URL: https://svnweb.freebsd.org/changeset/base/309368
>> 
>> Log:
>> MFC r308776
>> 
>> loader: zfs toplevel vdev must have spa set.
>> 
>> PR:  214375
>> Reported by: lstewart
>> Reviewed by: allanjude, imp
>> Approved by: allanjude (mentor), imp (mentor)
>> Differential Revision:   https://reviews.freebsd.org/D8487
> 
> Hi Tom,

I am sorry, this should have been Toomas, not Tom. 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r309368 - stable/11/sys/boot/zfs

[Oleksandr Tymoshenko]

> On Dec 1, 2016, at 11:06 AM, Toomas Soome  wrote:
> 
> Author: tsoome
> Date: Thu Dec  1 19:06:09 2016
> New Revision: 309368
> URL: https://svnweb.freebsd.org/changeset/base/309368
> 
> Log:
>  MFC r308776
> 
>  loader: zfs toplevel vdev must have spa set.
> 
>  PR:  214375
>  Reported by: lstewart
>  Reviewed by: allanjude, imp
>  Approved by: allanjude (mentor), imp (mentor)
>  Differential Revision:   https://reviews.freebsd.org/D8487

Hi Tom,

Looks like this commit breaks the build:

In file included from /src/FreeBSD/11/sys/boot/efi/loader/../../zfs/zfs.c:49:
/src/FreeBSD/11/sys/boot/efi/loader/../../zfs/zfsimpl.c:1021:13: error: no membe
r named 'spa' in 'struct vdev'
top_vdev->spa = spa;
  ^



___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"